Re: [PATCH v3 2/2] staging: media: davinci_vpfe: add kfree() on goto err statement

2018-03-20 Thread Dan Carpenter
Looks good. Thanks! regards, dan carpenter

cron job: media_tree daily build: WARNINGS

2018-03-20 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Mar 21 05:00:11 CET 2018 media-tree git hash:e68854a2588a923b31eebce348f8020374843f8e media_build git

[PATCH v3 2/2] staging: media: davinci_vpfe: add kfree() on goto err statement

2018-03-20 Thread Ji-Hun Kim
It needs to free of allocated params value in the goto error statement. Signed-off-by: Ji-Hun Kim --- Changes since v2: - add kfree(params) on the error case of the function - rename unclear goto statement name - declare the params value at start of the function, so it can be free end o

[PATCH v3 1/2] staging: media: davinci_vpfe: add error handling on kmalloc failure

2018-03-20 Thread Ji-Hun Kim
There is no failure checking on the param value which will be allocated memory by kmalloc. Add a null pointer checking statement. Then goto error: and return -ENOMEM error code when kmalloc is failed. Signed-off-by: Ji-Hun Kim --- Changes since v1: - Return with -ENOMEM directly, instead of got

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

2018-03-20 Thread Nicolas Dufresne
Le mardi 20 mars 2018 à 20:04 +0200, Laurent Pinchart a écrit : > Hi Nicolas, > > On Tuesday, 20 March 2018 19:45:51 EET Nicolas Dufresne wrote: > > Le mardi 20 mars 2018 à 13:20 +0100, Paul Menzel a écrit : > > > Dear Linux folks, > > > > > > > > > On the Dell XPS 13 9370, Linux 4.16-rc6 output

[PATCH v3 12/13] media: staging/imx: Switch to v4l2_async_notifier_add_subdev

2018-03-20 Thread Steve Longerbeam
Switch to v4l2_async_notifier_add_subdev() when adding async subdevs to the imx-media root notifier. This removes the need to check for an already added asd, since v4l2_async_notifier_add_subdev() does this check. Also no need to allocate a subdevs array when registering the root notifier, or keepi

[PATCH v3 11/13] media: staging/imx: Rename root notifier

2018-03-20 Thread Steve Longerbeam
Rename the imx-media root async notifier from "subdev_notifier" to simply "notifier", so as not to confuse it with true subdev notifiers. No functional changes. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-dev.c | 14 +++--- drivers/staging/media/imx/imx-media.

[PATCH v3 10/13] media: staging/imx: Loop through all registered subdevs for media links

2018-03-20 Thread Steve Longerbeam
The root imx-media notifier no longer sees all bound subdevices because some of them will be bound to subdev notifiers. So imx_media_create_links() now needs to loop through all subdevices registered with the v4l2-device, not just the ones in the root notifier's done list. This should be safe becau

[PATCH v3 13/13] media: staging/imx: TODO: Remove one assumption about OF graph parsing

2018-03-20 Thread Steve Longerbeam
The move to subdev notifiers fixes one assumption of OF graph parsing. If a subdevice has non-video related ports, the subdev driver knows not to follow those ports when adding remote devices to its subdev notifier. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/TODO | 29 +++-

[PATCH v3 09/13] media: staging/imx: of: Remove recursive graph walk

2018-03-20 Thread Steve Longerbeam
After moving to subdev notifiers, it's no longer necessary to recursively walk the OF graph, because the subdev notifiers will discover and add devices from the graph for us. So the recursive of_parse_subdev() function is gone, replaced with of_add_csi() which adds only the CSI port fwnodes to the

[PATCH v3 02/13] media: v4l2: async: Allow searching for asd of any type

2018-03-20 Thread Steve Longerbeam
Generalize v4l2_async_notifier_fwnode_has_async_subdev() to allow searching for any type of async subdev, not just fwnodes. Rename to v4l2_async_notifier_has_async_subdev() and pass it an asd pointer. TODO: support asd compare with CUSTOM match type in asd_equal(). Signed-off-by: Steve Longerbeam

[PATCH v3 00/13] media: imx: Switch to subdev notifiers

2018-03-20 Thread Steve Longerbeam
This patchset converts the imx-media driver and its dependent subdevs to use subdev notifiers. There are a couple shortcomings in v4l2-core that prevented subdev notifiers from working correctly in imx-media: 1. v4l2_async_notifier_fwnode_parse_endpoint() treats a fwnode endpoint that is not c

[PATCH v3 03/13] media: v4l2: async: Add v4l2_async_notifier_add_subdev

2018-03-20 Thread Steve Longerbeam
v4l2_async_notifier_add_subdev() adds an asd to the notifier. It checks that the asd's match_type is valid and that no other equivalent asd's have already been added to this notifier's asd list, or to other registered notifier's waiting or done lists, and increments num_subdevs. v4l2_async_notifie

[PATCH v3 05/13] media: v4l2-fwnode: Add a convenience function for registering subdevs with notifiers

2018-03-20 Thread Steve Longerbeam
Adds v4l2_async_register_fwnode_subdev(), which is a convenience function for parsing a sub-device's fwnode port endpoints for connected remote sub-devices, registering a sub-device notifier, and then registering the sub-device itself. Signed-off-by: Steve Longerbeam --- Changes since v2: - fix e

[PATCH v3 07/13] media: imx: csi: Register a subdev notifier

2018-03-20 Thread Steve Longerbeam
Parse neighbor remote devices on the CSI port, add them to a subdev notifier, and register the subdev notifier for the CSI, by calling v4l2_async_register_fwnode_subdev(). Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 11 ++- 1 file changed, 10 insertion

[PATCH v3 01/13] media: v4l2-fwnode: ignore endpoints that have no remote port parent

2018-03-20 Thread Steve Longerbeam
Documentation/devicetree/bindings/media/video-interfaces.txt states that the 'remote-endpoint' property is optional. So v4l2_async_notifier_fwnode_parse_endpoint() should not return error if the endpoint has no remote port parent. Just ignore the endpoint, skip adding an asd to the notifier and re

[PATCH v3 06/13] media: platform: video-mux: Register a subdev notifier

2018-03-20 Thread Steve Longerbeam
Parse neighbor remote devices on the video muxes input ports, add them to a subdev notifier, and register the subdev notifier for the video mux, by calling v4l2_async_register_fwnode_subdev(). Signed-off-by: Steve Longerbeam --- Changes since v2: - none Changes since v1: - add #include for kcall

[PATCH v3 04/13] media: v4l2-fwnode: Switch to v4l2_async_notifier_add_subdev

2018-03-20 Thread Steve Longerbeam
The fwnode endpoint and reference parsing functions in v4l2-fwnode.c are modified to make use of v4l2_async_notifier_add_subdev(). As a result the notifier->subdevs array is no longer allocated or re-allocated, and by extension the max_subdevs value is also no longer needed. Since the notifier->su

[PATCH v3 08/13] media: imx: mipi csi-2: Register a subdev notifier

2018-03-20 Thread Steve Longerbeam
Parse neighbor remote devices on the MIPI CSI-2 input port, add them to a subdev notifier, and register the subdev notifier for the MIPI CSI-2 receiver, by calling v4l2_async_register_fwnode_subdev(). csi2_parse_endpoints() is modified to be the parse_endpoint callback. Signed-off-by: Steve Longe

(Relief Coordinator, United Nations)

2018-03-20 Thread UNCU
United Nations Compensation Unit, Emergency Relief Coordinator, United Nations. Congratulations Beneficiary, We have been having a meeting for quit sometime now and we just came to a logical conclusion 72 hours ago in affiliation with the World Bank president. Your email was listed among

[PATCH 4/5] [media] ddbridge: add SPDX license headers

2018-03-20 Thread Daniel Scheller
From: Daniel Scheller Add SPDX license headers in all ddbridge driver files and fix MODULE_LICENSE accordingly. Also, apply some cosmetics to the file headers. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/Makefile| 2 +- drivers/media/pci/ddbridge/ddbridge-ci.c | 6 +

[PATCH 2/5] [media] dvb-frontends/mxl5xx: add SPDX license headers

2018-03-20 Thread Daniel Scheller
From: Daniel Scheller Add SPDX license headers to the mxl5xx DVB frontend driver and it's related includes, and fix MODULE_LICENSE while at it. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/mxl5xx.c | 6 +++--- drivers/media/dvb-frontends/mxl5xx.h | 13 +

[PATCH 5/5] [media] ngene: add SPDX license headers

2018-03-20 Thread Daniel Scheller
From: Daniel Scheller Add SPDX license headers in all ngene driver files and fix MODULE_LICENSE accordingly. Signed-off-by: Daniel Scheller --- drivers/media/pci/ngene/Makefile | 2 +- drivers/media/pci/ngene/ngene-cards.c | 10 +++--- drivers/media/pci/ngene/ngene-core.c | 8 ++---

[PATCH 0/5] SPDX license identifiers in all DD drivers

2018-03-20 Thread Daniel Scheller
From: Daniel Scheller This series adds SPDX license identifiers to all source files which are copyright by either Digital Devices GmbH or Metzlerbros GbR, who are the original authors of the ddbridge, ngene, cxd2099, mxl5xx, stv0910 and stv6111 bridge/demod/tuner drivers, with the mxl5xx driver b

[PATCH 3/5] [media] dvb-frontends/cxd2099: add SPDX license headers

2018-03-20 Thread Daniel Scheller
From: Daniel Scheller Add SPDX license headers in the cxd2099 driver files and fix MODULE_LICENSE accordingly. Cc: Jasmin Jessich Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/cxd2099.c | 5 +++-- drivers/media/dvb-frontends/cxd2099.h | 3 ++- 2 files changed, 5 insertions(+)

[PATCH 1/5] [media] stv0910/stv6111: add SPDX license headers

2018-03-20 Thread Daniel Scheller
From: Daniel Scheller Add SPDX license headers to the stv0910 and stv6111 DVB frontend drivers. Both drivers are licensed as GPL-2.0-only, so fix this in the MODULE_LICENSE while at it. Also, the includes were lacking any license headers at all, so add them now. Signed-off-by: Daniel Scheller -

[no subject]

2018-03-20 Thread Scott Tisdale
hi Linuxhttps://goo.gl/764kVN Scott Tisdale

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

2018-03-20 Thread Laurent Pinchart
Hi Nicolas, On Tuesday, 20 March 2018 19:45:51 EET Nicolas Dufresne wrote: > Le mardi 20 mars 2018 à 13:20 +0100, Paul Menzel a écrit : > > Dear Linux folks, > > > > > > On the Dell XPS 13 9370, Linux 4.16-rc6 outputs the messages below. > > > > ``` > > [2.338094] calling uvc_init+0x0/0x10

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

2018-03-20 Thread Christian König
Am 20.03.2018 um 15:08 schrieb Daniel Vetter: [SNIP] For the in-driver reservation path (CS) having a slow-path that grabs a temporary reference, drops the vram lock and then locks the reservation normally (using the acquire context used already for the entire CS) is a bit tricky, but totally fea

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

2018-03-20 Thread Nicolas Dufresne
Le mardi 20 mars 2018 à 13:20 +0100, Paul Menzel a écrit : > Dear Linux folks, > > > On the Dell XPS 13 9370, Linux 4.16-rc6 outputs the messages below. > > ``` > [2.338094] calling uvc_init+0x0/0x1000 [uvcvideo] @ 295 > [2.338569] calling iTCO_wdt_init_module+0x0/0x1000 [iTCO_wdt] @ 2

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

2018-03-20 Thread Paul Menzel
Dear Laurent, On 03/20/18 14:30, Laurent Pinchart wrote: On Tuesday, 20 March 2018 14:20:14 EET Paul Menzel wrote: On the Dell XPS 13 9370, Linux 4.16-rc6 outputs the messages below. ``` […] [2.340736] input: Integrated_Webcam_HD: Integrate as /devices/pci:00/:00:14.0/usb1/

Re: [PATCH] media: uvcvideo: Fix minor spelling

2018-03-20 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 20 March 2018 17:43:08 EET Kieran Bingham wrote: > From: Kieran Bingham > > Provide the missing 't' from straightforward. > > Signed-off-by: Kieran Bingham Acked-by: Laurent Pinchart and applied to my tree. > --- > drivers/media/usb/uvc/uvc

[PATCH] media: uvcvideo: Fix minor spelling

2018-03-20 Thread Kieran Bingham
From: Kieran Bingham Provide the missing 't' from straightforward. Signed-off-by: Kieran Bingham --- drivers/media/usb/uvc/uvc_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index 102594ec3e97..1daf

Issue with sharp protocol on ite-cir due to high idle timeout

2018-03-20 Thread Matthias Reichl
Hi Sean, yesterday we received an interesting bug report that might help to motivate using a lower idle timeout on ite-cir: https://forum.libreelec.tv/thread/11951-sharp-ir-remote-on-intel-nuc-2820-double-presses/ The rather long message time of the sharp protocol (about 86ms) in combination wit

Re: Double-free in /drivers/media/usb/hackrf driver

2018-03-20 Thread Dan Carpenter
Hi Linux Media Devs, This is similar to the one before. Please give reported-by credit to Reported-by: "Yavuz, Tuba" Or maybe flip the names around? The hackrf_probe() function has a double free on error after we set up: dev->v4l2_dev.release = hackrf_video_release; then the calls to:

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

2018-03-20 Thread Daniel Vetter
On Tue, Mar 20, 2018 at 11:54:18AM +0100, Christian König wrote: > Am 20.03.2018 um 08:44 schrieb Daniel Vetter: > > On Mon, Mar 19, 2018 at 5:23 PM, Christian König > > wrote: > > > Am 19.03.2018 um 16:53 schrieb Chris Wilson: > > > > Quoting Christian König (2018-03-16 14:22:32) > > > > [snip, p

Re: [PATCH v2] venus: vdec: fix format enumeration

2018-03-20 Thread Stanimir Varbanov
Hi Alex, Thanks! On 03/19/2018 11:32 AM, Alexandre Courbot wrote: > find_format_by_index() stops enumerating formats as soon as the index > matches, and returns NULL if venus_helper_check_codec() finds out that > the format is not supported. This prevents formats to be properly > enumerated if a

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

2018-03-20 Thread Laurent Pinchart
Hi Paul, On Tuesday, 20 March 2018 14:20:14 EET Paul Menzel wrote: > Dear Linux folks, > > > On the Dell XPS 13 9370, Linux 4.16-rc6 outputs the messages below. > > ``` > [2.338094] calling uvc_init+0x0/0x1000 [uvcvideo] @ 295 > [2.338569] calling iTCO_wdt_init_module+0x0/0x1000 [iTCO

[no subject]

2018-03-20 Thread Tom Crist
-- Hallo   Mein Name ist Tom Crist Ich habe eine Spende von €2.100.000,00 für Sie. Ich habe die Amerika-Lotterie in Amerika im Wert von 40 Millionen Dollar gewonnen und ich gebe einen Teil davon an fünf glückliche Leute zum Gedenken an meine verstorbene Frau, die an Krebs gestorben ist.

uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

2018-03-20 Thread Paul Menzel
Dear Linux folks, On the Dell XPS 13 9370, Linux 4.16-rc6 outputs the messages below. ``` [2.338094] calling uvc_init+0x0/0x1000 [uvcvideo] @ 295 [2.338569] calling iTCO_wdt_init_module+0x0/0x1000 [iTCO_wdt] @ 280 [2.338570] iTCO_wdt: Intel TCO WatchDog Timer Driver v1.11 [2.3

[GIT PULL] HEVC V4L2 controls and s5p-mfc update

2018-03-20 Thread Sylwester Nawrocki
Hi Mauro, The following changes since commit 3f127ce11353fd1071cae9b65bc13add6aec6b90: media: em28xx-cards: fix em28xx_duplicate_dev() (2018-03-08 06:06:51 -0500) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git tags/v4.17-media-samsung for you to fetch chang

Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-20 Thread Sakari Ailus
Hi Jacopo, On Tue, Mar 20, 2018 at 11:28:17AM +0100, jacopo mondi wrote: ... > > +static int dw9807_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) > > +{ > > + int rval; > > + > > + rval = pm_runtime_get_sync(sd->dev); > > + if (rval < 0) { > > + pm_runtime_put_noidle(sd->

[RFT] media: hdpvr: Fix Double kfree() error

2018-03-20 Thread Arvind Yadav
Here, double-free is happening on error path of hdpvr_probe. error_v4l2_unregister: v4l2_device_unregister(&dev->v4l2_dev); => v4l2_device_disconnect => put_device => kobject_put => kref_put => v4l2_device_release => hdpvr_d

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

2018-03-20 Thread Christian König
Am 20.03.2018 um 08:44 schrieb Daniel Vetter: On Mon, Mar 19, 2018 at 5:23 PM, Christian König wrote: Am 19.03.2018 um 16:53 schrieb Chris Wilson: Quoting Christian König (2018-03-16 14:22:32) [snip, probably lost too must context] This allows for full grown pipelining, e.g. the exporter can

Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-20 Thread jacopo mondi
Hi Andy, a few comments on you patch below... On Sat, Mar 17, 2018 at 01:05:26AM +0800, Andy Yeh wrote: > From: Alan Chiang > > DW9807 is a 10 bit DAC from Dongwoon, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and > provides control to set the de

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-03-20 Thread Pavel Machek
Hi! > > > 2) support for running libv4l2 on mc-based devices. I'd like to do > > > that. > > > > > > Description file would look like. (# comments would not be not part of > > > file). > > > > > > V4L2MEDIADESC > > > 3 # number of files to open > > > /dev/video2 > > > /dev/video6 > > > /dev/vid

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

2018-03-20 Thread Daniel Vetter
On Mon, Mar 19, 2018 at 5:23 PM, Christian König wrote: > Am 19.03.2018 um 16:53 schrieb Chris Wilson: >> >> Quoting Christian König (2018-03-16 14:22:32) >> [snip, probably lost too must context] >>> >>> This allows for full grown pipelining, e.g. the exporter can say I need >>> to move the buffe

Re: [PATCH v2 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler

2018-03-20 Thread Hans Verkuil
On 03/20/2018 02:41 AM, Nicolas Dufresne wrote: > Le mardi 20 mars 2018 à 00:46 +, Rohit Athavale a écrit : >> Hi Hans, >> >> Thanks for taking the time to take a look at this. >> >>> This should definitely use the V4L2 API. I guess it could be added >>> to staging/media with a big fat TODO tha