Re: [PATCH][RFC] kernel.h: provide array iterator

2018-03-15 Thread Julia Lawall
Le 16.03.2018 05:21, Kees Cook a écrit : On Thu, Mar 15, 2018 at 3:00 AM, Kieran Bingham wrote: Simplify array iteration with a helper to iterate each entry in an array. Utilise the existing ARRAY_SIZE macro to identify the length of the array and pointer arithmetic to process each item as a

[PATCH] staging: media: davinci_vpfe: add error handling on kmalloc failure

2018-03-15 Thread Ji-Hun Kim
There is no failure checking on the param value which will be allocated memory by kmalloc. Add a null pointer checking statement. Then goto error: and return -ENOMEM error code when kmalloc is failed. Signed-off-by: Ji-Hun Kim --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 8 1

cron job: media_tree daily build: ERRORS

2018-03-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Mar 16 05:00:19 CET 2018 media-tree git hash:e68854a2588a923b31eebce348f8020374843f8e media_build git

Re: [PATCH][RFC] kernel.h: provide array iterator

2018-03-15 Thread Kees Cook
On Thu, Mar 15, 2018 at 3:00 AM, Kieran Bingham wrote: > Simplify array iteration with a helper to iterate each entry in an array. > Utilise the existing ARRAY_SIZE macro to identify the length of the array > and pointer arithmetic to process each item as a for loop. > > Signed-off-by: Kieran Bing

Re: [PATCH v5 0/2] media: video-i2c: add video-i2c driver support

2018-03-15 Thread Matt Ranostay
On Fri, Mar 9, 2018 at 10:26 AM, Matt Ranostay wrote: > On Fri, Mar 9, 2018 at 4:45 AM, Hans Verkuil wrote: >> Hi Matt, >> >> This is looking good. One request before I merge: please run the >> 'v4l2-compliance -s -f' utility and post the result here. >> >> I don't think I've asked you to do that

Re: [PATCH v6 2/2] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

2018-03-15 Thread Niklas Söderlund
Hi Maxime, Thanks for your patch, I still need to find time to do a full review of this patch before I can add my review tag to it. But in case you post a new version before I find the time, the MODULE_LICENSE is still missing :-) On 2018-03-14 14:16:02 +0100, Maxime Ripard wrote: > The Cadenc

Re: [PATCH v6 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 TX Device Tree bindings

2018-03-15 Thread Niklas Söderlund
Hi Maxime, Thanks for your patch, On 2018-03-14 14:16:01 +0100, Maxime Ripard wrote: > The Cadence MIPI-CSI2 TX controller is a CSI2 bridge that supports up to 4 > video streams and can output on up to 4 CSI-2 lanes, depending on the > hardware implementation. > > It can operate with an external

Re: [PATCH 00/20] Add multiplexed media pads to support CSI-2 virtual channels

2018-03-15 Thread Niklas Söderlund
Hi Todor, On 2018-03-15 11:43:31 +0200, Todor Tomov wrote: > Hello, > > I'm trying to understand what is the current state of the multiple virtual > channel support in V4L2 and Media framework. This is the last activity > on this topic which I was able to find. Is anything new happened since > th

Re: [PATCH 1/8] clk: Add clk_bulk_alloc functions

2018-03-15 Thread Stephen Boyd
Quoting Marek Szyprowski (2018-02-20 01:36:03) > Hi Robin, > > On 2018-02-19 17:29, Robin Murphy wrote: > > > > Seeing how every subsequent patch ends up with the roughly this same > > stanza: > > > > x = devm_clk_bulk_alloc(dev, num, names); > > if (IS_ERR(x) > >     return PTR_ERR(x

[PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-15 Thread Peter Seiderer
- enables gstreamer v4l2src lost frame detection, e.g: 0:00:08.685185668 348 0x54f520 WARN v4l2src gstv4l2src.c:970:gst_v4l2src_create: lost frames detected: count = 141 - ts: 0:00:08.330177332 - fixes v4l2-compliance test failure: Streaming ioctls: test read/write: OK (Not Su

[PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry

2018-03-15 Thread Peter Seiderer
- fixes gstreamer v4l2src warning: 0:00:00.716640334 349 0x164f720 WARN v4l2bufferpool gstv4l2bufferpool.c:1195:gst_v4l2_buffer_pool_dqbuf: Driver should never set v4l2_buffer.field to ANY - fixes v4l2-compliance test failure: Streaming ioctls: test read/write: OK (Not Support

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-15 Thread Yeh, Andy
Both comments are OKAY. Thanks. -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Thursday, March 15, 2018 6:31 AM To: Yeh, Andy Cc: linux-media@vger.kernel.org; tf...@chromium.org; Chen, JasonX Z ; Chiang, AlanX ; Lai, Jim Subject: Re: [PATCH v8] medi

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread jacopo mondi
Hi Hans, On Thu, Mar 15, 2018 at 08:30:21AM -0700, Hans Verkuil wrote: > On 03/15/2018 07:38 AM, jacopo mondi wrote: > > Hi Sakari, > >thanks for looking into this! > > > > On Thu, Mar 15, 2018 at 01:35:34PM +0200, Sakari Ailus wrote: > >> Hi Jacopo, > >> > >> I wonder if it'd make sense to ju

[PATCH v9] media: imx258: Add imx258 camera sensor driver

2018-03-15 Thread Andy Yeh
From: Jason Chen Add a V4L2 sub-device driver for the Sony IMX258 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Andy Yeh Signed-off-by: Alan Chiang --- since v2: -- Update the streaming function to remove SW_STANDBY in the beginn

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread Hans Verkuil
On 03/15/2018 07:38 AM, jacopo mondi wrote: > Hi Sakari, >thanks for looking into this! > > On Thu, Mar 15, 2018 at 01:35:34PM +0200, Sakari Ailus wrote: >> Hi Jacopo, >> >> I wonder if it'd make sense to just make all the changes to the driver and >> then have it reviewed; I'm not sure the ol

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread jacopo mondi
Hi Sakari, thanks for looking into this! On Thu, Mar 15, 2018 at 01:35:34PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > I wonder if it'd make sense to just make all the changes to the driver and > then have it reviewed; I'm not sure the old driver can be said to have been > in a known-good stat

Re: [PATCH v2 1/1] media: mceusb: add IR learning support features (IR carrier frequency measurement and wide-band/short-range receiver)

2018-03-15 Thread Sean Young
On Wed, Mar 14, 2018 at 03:32:02PM -0400, A Sun wrote: > patch v2 revisions: > . Carrier frequency measurement results were consistently low in patch v1. >Improve measurement accuracy by adjusting IR carrier cycle count >assuming 1 missed count per IR "on" pulse. >Adjustments may need

Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"

2018-03-15 Thread Sakari Ailus
On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote: > According to the Devicetree Specification, "ok" is not a valid status. > > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") > Signed-off-by: Geert Uytterhoeven Acked-by: Sakari Ailus There are a few other

Re: Webcams not recognized on a Dell Latitude 5285 laptop

2018-03-15 Thread Sakari Ailus
Hi Andy and Frédéric, On Tue, Mar 13, 2018 at 06:11:00PM +0200, Andy Shevchenko wrote: > On Sun, Mar 11, 2018 at 2:38 PM, FRÉDÉRIC PARRENIN > wrote: > > Dear Oliver and all, > > > > So I was expecting linux-4.16 to recognize my webcams, thanks to this new > > PCI driver Oliver mentioned. > > The

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread Sakari Ailus
Hi Jacopo, I wonder if it'd make sense to just make all the changes to the driver and then have it reviewed; I'm not sure the old driver can be said to have been in a known-good state that'd be useful to compare against. I think you did that with another driver as well. On Mon, Mar 12, 2018 at 02

Re: [PATCH 1/4] dma-buf: add optional invalidate_mappings callback

2018-03-15 Thread Daniel Vetter
On Thu, Mar 15, 2018 at 10:56 AM, Christian König wrote: > Am 15.03.2018 um 10:20 schrieb Daniel Vetter: >> >> On Tue, Mar 13, 2018 at 06:20:07PM +0100, Christian König wrote: >> [SNIP] >> Take a look at the DOT graphs for atomic I've done a while ago. I think we >> could make a formidable competi

Re: [PATCH v2] media: omap3isp: fix unbalanced dma_iommu_mapping

2018-03-15 Thread Pavel Machek
On Wed 2018-03-14 10:41:36, Suman Anna wrote: > The OMAP3 ISP driver manages its MMU mappings through the IOMMU-aware > ARM DMA backend. The current code creates a dma_iommu_mapping and > attaches this to the ISP device, but never detaches the mapping in > either the probe failure paths or the driv

Re: [PATCH 21/47] media: platform: remove m32r specific arv driver

2018-03-15 Thread Mauro Carvalho Chehab
Em Wed, 14 Mar 2018 16:35:34 +0100 Arnd Bergmann escreveu: > The m32r architecture is getting removed, so this one is no longer needed. > > Signed-off-by: Arnd Bergmann Acked-by: Mauro Carvalho Chehab > --- > drivers/media/platform/Kconfig | 20 - > drivers/media/platform/Makefile | 2 -

Re: [PATCH 20/47] media: platform: remove blackfin capture driver

2018-03-15 Thread Mauro Carvalho Chehab
Em Wed, 14 Mar 2018 16:35:33 +0100 Arnd Bergmann escreveu: > The blackfin architecture is getting removed, so the video > capture driver is also obsolete. > > Signed-off-by: Arnd Bergmann Acked-by: Mauro Carvalho Chehab > --- > drivers/media/platform/Kconfig | 2 - > drive

[PATCH][RFC] kernel.h: provide array iterator

2018-03-15 Thread Kieran Bingham
Simplify array iteration with a helper to iterate each entry in an array. Utilise the existing ARRAY_SIZE macro to identify the length of the array and pointer arithmetic to process each item as a for loop. Signed-off-by: Kieran Bingham --- include/linux/kernel.h | 10 ++ 1 file changed,

Re: [PATCH 1/4] dma-buf: add optional invalidate_mappings callback

2018-03-15 Thread Christian König
Am 15.03.2018 um 10:20 schrieb Daniel Vetter: On Tue, Mar 13, 2018 at 06:20:07PM +0100, Christian König wrote: [SNIP] Take a look at the DOT graphs for atomic I've done a while ago. I think we could make a formidable competition for who's doing the worst diagrams :-) Thanks, going to give that

Re: [PATCH] venus: vdec: fix format enumeration

2018-03-15 Thread Stanimir Varbanov
Hi Alex, Thanks for the patch! On 13.03.2018 11:11, Alexandre Courbot wrote: > find_format_by_index() stops enumerating formats as soon as the index > matches, and returns NULL if venus_helper_check_codec() finds out that > the format is not supported. This prevents formats to be properly > enume

Re: [PATCH 00/20] Add multiplexed media pads to support CSI-2 virtual channels

2018-03-15 Thread Todor Tomov
Hello, I'm trying to understand what is the current state of the multiple virtual channel support in V4L2 and Media framework. This is the last activity on this topic which I was able to find. Is anything new happened since this RFC, is someone working on this or planing to work on? Best regards,

Re: [media] ov5645: Move an error code assignment in ov5645_probe()

2018-03-15 Thread SF Markus Elfring
>> Move an assignment for a specific error code so that it is stored only once >> in this function implementation. >> >> This issue was detected by using the Coccinelle software. > > How? Would you like to experiment a bit more with the following approach for the semantic patch language? show_sa

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-15 Thread Sakari Ailus
Hi Andy, On Wed, Mar 14, 2018 at 04:29:52PM +, Yeh, Andy wrote: > Still wrong line break... > Please check the list instead. Thanks. > https://patchwork.linuxtv.org/patch/47936/ The patch you sent using git send-email seems fine; I bet it's your e-mail client that does the rewrapping. -- Re

[PATCH 2/2] cec: stm32: add suspend/resume functions

2018-03-15 Thread Benjamin Gaignard
From: Benjamin Gaignard If wake up irq is defined in device-tree cec adapter could be used has wake up source. Signed-off-by: Benjamin Gaignard --- drivers/media/platform/stm32/stm32-cec.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/driv

[PATCH 1/2] cec: stm32: simplify clock management

2018-03-15 Thread Benjamin Gaignard
From: Benjamin Gaignard Since CEC framework enable and disable the adapter when it is needed just follow it orders to enable/disable the clocks. Call stm32_cec_hw_init() when the adapter is enabled and do not let regmap manage registers clock help to simplify clocking scheme. While reworking cec

Re: [PATCH v2 02/13] media: v4l2: async: Allow searching for asd of any type

2018-03-15 Thread Sakari Ailus
Hi Steve, Thanks for the patchset. Please see my comments below. On Sat, Mar 10, 2018 at 11:58:31AM -0800, Steve Longerbeam wrote: > Generalize v4l2_async_notifier_fwnode_has_async_subdev() to allow > searching for any type of async subdev, not just fwnodes. Rename to > v4l2_async_notifier_has_as

[PATCH 0/2] cec: stm32: add wakeup support

2018-03-15 Thread Benjamin Gaignard
CEC hardware block is enable to resume the system if a command is received on data lane. Prior to implement suspend/resume functions a patch simplify clock management int the driver by introducting pm_runtime{suspend/resume} functions. Benjamin Gaignard (2): cec: stm32: simplify clock management

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-15 Thread Rui Miguel Silva
://github.com/0day-ci/linux/commits/Rui-Miguel-Silva/media-Introduce-Omnivision-OV2680-driver/20180315-020617 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master

Re: [PATCH 1/4] dma-buf: add optional invalidate_mappings callback

2018-03-15 Thread Daniel Vetter
On Tue, Mar 13, 2018 at 06:20:07PM +0100, Christian König wrote: > Am 13.03.2018 um 17:00 schrieb Daniel Vetter: > > On Tue, Mar 13, 2018 at 04:52:02PM +0100, Christian König wrote: > > > Am 13.03.2018 um 16:17 schrieb Daniel Vetter: > > > [SNIP] > > Ok, so plan is to support fully pipeline moves a

Re: [PATCH] [media] ov5645: Move an error code assignment in ov5645_probe()

2018-03-15 Thread Todor Tomov
Hi, On 15.03.2018 00:17, Sakari Ailus wrote: > On Wed, Mar 14, 2018 at 10:15:43PM +0100, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Wed, 14 Mar 2018 22:02:52 +0100 >> >> Move an assignment for a specific error code so that it is stored only once >> in this function implementation.

Re: [PATCH 08/12] media: ov5640: Adjust the clock based on the expected rate

2018-03-15 Thread Sakari Ailus
On Tue, Mar 13, 2018 at 01:49:37PM +0100, Maxime Ripard wrote: > Hi Sakari, > > On Fri, Mar 09, 2018 at 01:16:24PM +0200, Sakari Ailus wrote: > > > + * > > > + * +--+ > > > + * | Oscillator | > > > > I wonder if this should be simply called external clock, that's what the > > se