cron job: media_tree daily build: ERRORS

2018-02-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Feb 10 05:00:19 CET 2018 media-tree git hash:273caa260035c03d89ad63d72d8cd3d9e5c5e3f1 media_build git

Re: [PATCH] media: imx: csi: fix enum_mbus_code for unknown mbus format codes

2018-02-09 Thread Steve Longerbeam
Hi Philipp, On 02/08/2018 12:01 PM, Hans Verkuil wrote: On 02/08/2018 08:27 PM, Steve Longerbeam wrote: On 02/08/2018 06:47 AM, Philipp Zabel wrote: If no imx_media_pixfmt is found for a given mbus format code, we shouldn't crash. Return -EINVAL for any index. Hi Philipp, If imx_media_find

Re: [PATCH] media: imx: csi: fix enum_mbus_code for unknown mbus format codes

2018-02-09 Thread Steve Longerbeam
Hi Hans, On 02/08/2018 12:01 PM, Hans Verkuil wrote: On 02/08/2018 08:27 PM, Steve Longerbeam wrote: On 02/08/2018 06:47 AM, Philipp Zabel wrote: If no imx_media_pixfmt is found for a given mbus format code, we shouldn't crash. Return -EINVAL for any index. Hi Philipp, If imx_media_find_mb

Re: [PATCH v2] media: imx-media-internal-sd: Use empty initializer

2018-02-09 Thread Steve Longerbeam
Hi Fabio, On 02/09/2018 03:11 PM, Fabio Estevam wrote: From: Fabio Estevam When building with W=1 the following warning shows up: drivers/staging/media/imx/imx-media-internal-sd.c:274:49: warning: Using plain integer as NULL pointer Fix this problem by using an empty initializer, which gua

[PATCH v2] media: imx-media-internal-sd: Use empty initializer

2018-02-09 Thread Fabio Estevam
From: Fabio Estevam When building with W=1 the following warning shows up: drivers/staging/media/imx/imx-media-internal-sd.c:274:49: warning: Using plain integer as NULL pointer Fix this problem by using an empty initializer, which guarantees that all struct members are zero-cleared. Signed-o

Re: [PATCH] media: imx-media-internal-sd: Use memset to clear pdevinfo struct

2018-02-09 Thread Ian Arkver
On 09/02/18 21:17, Ian Arkver wrote: On 09/02/18 16:36, Fabio Estevam wrote: When building with W=1 the following warning shows up: drivers/staging/media/imx/imx-media-internal-sd.c:274:49: warning: Using plain integer as NULL pointer Fix this problem by using memset() to clear the pdevinfo

dma-buf CPU access

2018-02-09 Thread Alexey Skidanov
Hi, According to the CPU access instructions in the dma-buf.c, I understand that on 32 bit platforms, due to the limited number of persistent kernel mappings or limited vmalloc range, the CPU access pattern should look like this: dma_buf_start_cpu_access(); void *ptr = dma_buf_kmap(); /*Access

Re: [PATCH] media: imx-media-internal-sd: Use memset to clear pdevinfo struct

2018-02-09 Thread Ian Arkver
On 09/02/18 16:36, Fabio Estevam wrote: When building with W=1 the following warning shows up: drivers/staging/media/imx/imx-media-internal-sd.c:274:49: warning: Using plain integer as NULL pointer Fix this problem by using memset() to clear the pdevinfo structure. Hi Fabio, I thought initi

[PATCH] media: imx-media-internal-sd: Use memset to clear pdevinfo struct

2018-02-09 Thread Fabio Estevam
When building with W=1 the following warning shows up: drivers/staging/media/imx/imx-media-internal-sd.c:274:49: warning: Using plain integer as NULL pointer Fix this problem by using memset() to clear the pdevinfo structure. Signed-off-by: Fabio Estevam --- drivers/staging/media/imx/imx-medi

[PATCH 3/3] media: dmxdev: Fix the logic that enables DMA mmap support

2018-02-09 Thread Mauro Carvalho Chehab
Some conditions required for DVB mmap support to work are reversed. Also, the logic is not too clear. So, improve the logic, making it easier to be handled. PS.: I'm pretty sure that I fixed it while testing, but, somehow, the change got lost. Signed-off-by: Mauro Carvalho Chehab --- drivers/m

[PATCH 1/3] media: dvb: add continuity error indicators for memory mapped buffers

2018-02-09 Thread Mauro Carvalho Chehab
While userspace can detect discontinuity errors, it is useful to also let Kernelspace reporting discontinuity, as it can help to identify if the data loss happened either at Kernel or userspace side. Signed-off-by: Mauro Carvalho Chehab --- include/uapi/linux/dvb/dmx.h | 33 +

[PATCH 2/3] media: dvb: update buffer mmaped flags and frame counter

2018-02-09 Thread Mauro Carvalho Chehab
Now that we have support for a buffer counter and for error flags, update them at DMX_DQBUF. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dmxdev.c| 11 +++-- drivers/media/dvb-core/dvb_demux.c | 95 -- drivers/media/dvb-core/dvb_vb2.c

[PATCH] [media] dvb-frontends/stv0910: rework and fix DiSEqC send

2018-02-09 Thread Daniel Scheller
From: Daniel Scheller Rework both DiSEqC send functions (send_master_cmd() and send_burst()) to utilise the new SET_REG() and SET_FIELD() macros. Esp. due to SET_FIELD(), this makes sure that not all bits (with unrelated purposes) are always rewritten, but only those needed for sending DiSEqC com

Re: [PATCH 1/2] media: i2c: adv748x: Simplify regmap configuration

2018-02-09 Thread Kieran Bingham
Hi Niklas, On 09/02/18 15:39, Niklas Söderlund wrote: > Hi Kieran, > > Thanks for your patch. > > On 2018-02-07 17:34:45 +, Kieran Bingham wrote: >> From: Kieran Bingham >> >> The ADV748x has identical map configurations for each register map. The >> duplication of each map can be simplifie

Re: [PATCH 2/2] media: i2c: adv748x: Add missing CBUS page.

2018-02-09 Thread Niklas Söderlund
Hi Kieran, Thanks for your patch, On 2018-02-07 17:34:46 +, Kieran Bingham wrote: > From: Kieran Bingham > > The ADV748x has 12 pages mapped onto I2C addresses. > > In the existing implementation only 11 are mapped correctly in the page > enumerations, which causes an off-by-one fault on p

Re: [PATCH 1/2] media: i2c: adv748x: Simplify regmap configuration

2018-02-09 Thread Niklas Söderlund
Hi Kieran, Thanks for your patch. On 2018-02-07 17:34:45 +, Kieran Bingham wrote: > From: Kieran Bingham > > The ADV748x has identical map configurations for each register map. The > duplication of each map can be simplified using a helper macro such that > each map is represented on a sing

Re: [PATCH] media: i2c: adv748x: Fix cleanup jump on chip identification

2018-02-09 Thread Niklas Söderlund
Hi Kieran, Thanks for your patch. On 2018-02-07 21:11:35 +, Kieran Bingham wrote: > From: Kieran Bingham > > The error handling for the adv748x_identify_chip() call erroneously > jumps to the err_cleanup_clients label before the clients have been > established. > > Correct this by jumping

Re: [PATCH v2] media: ov5640: fix virtual_channel parameter permissions

2018-02-09 Thread jacopo mondi
Hi Hugues, On Tue, Feb 06, 2018 at 02:24:09PM +0100, Hugues Fruchet wrote: > Fix module_param(virtual_channel) permissions. > This problem was detected by checkpatch: > $ scripts/checkpatch.pl -f drivers/media/i2c/ov5640.c > ERROR: Use 4 digit octal (0777) not decimal permissions > #131: FILE: dri

Re: [PATCH] v4l: vsp1: Fix continuous mode for dual pipelines

2018-02-09 Thread Kieran Bingham
Hi Laurent, On 09/02/18 13:27, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 9 February 2018 15:18:25 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> To allow dual pipelines utilising two WPF entities when available, the >> VSP was updated to support h

[PATCH] v4l: vsp1: Fix header display list status check in continuous mode

2018-02-09 Thread Kieran Bingham
From: Kieran Bingham To allow dual pipelines utilising two WPF entities when available, the VSP was updated to support header-mode display list in continuous pipelines. A small bug in the status check of the command register causes the second pipeline to be directly afflicted by the running of t

[PATCH] em28xx: use %*phC to print small buffers

2018-02-09 Thread Antonio Cardace
Use %*phC format to print small buffers as hex strings Suggested-by: Andy Shevchenko Signed-off-by: Antonio Cardace --- drivers/media/usb/em28xx/em28xx-i2c.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em

Re: [PATCH v2 9/9] [media] Add documentation for YUV420 bus format

2018-02-09 Thread Ian Arkver
On 09/02/18 01:22, Satish Kumar Nagireddy wrote: The code is MEDIA_BUS_FMT_VYYUYY8_1X24 Signed-off-by: Satish Kumar Nagireddy --- Documentation/media/uapi/v4l/subdev-formats.rst | 34 + 1 file changed, 34 insertions(+) diff --git a/Documentation/media/uapi/v4l/subdev

Re: [PATCHv2 06/15] v4l2-subdev: implement VIDIOC_DBG_G_CHIP_INFO ioctl

2018-02-09 Thread Hans Verkuil
On 02/09/18 14:21, Laurent Pinchart wrote: > Hi Hans, > > On Friday, 9 February 2018 15:13:26 EET Hans Verkuil wrote: >> On 02/09/18 14:04, Laurent Pinchart wrote: >>> On Friday, 9 February 2018 15:00:53 EET Hans Verkuil wrote: On 02/09/18 13:44, Sakari Ailus wrote: > On Fri, Feb 09, 2018

Re: [PATCH] v4l: vsp1: Fix continuous mode for dual pipelines

2018-02-09 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 9 February 2018 15:18:25 EET Kieran Bingham wrote: > From: Kieran Bingham > > To allow dual pipelines utilising two WPF entities when available, the > VSP was updated to support header-mode display list in continuous > pipelines. > > A small bug i

Re: [PATCHv2 11/15] media-device.c: zero reserved field

2018-02-09 Thread Hans Verkuil
On 02/09/18 14:04, Sakari Ailus wrote: > Hi Hans, > > On Fri, Feb 09, 2018 at 01:52:50PM +0100, Hans Verkuil wrote: >> On 02/09/18 13:46, Sakari Ailus wrote: >>> On Fri, Feb 09, 2018 at 01:20:41PM +0100, Hans Verkuil wrote: On 02/09/18 13:17, Sakari Ailus wrote: > On Thu, Feb 08, 2018 at

Re: [PATCH] media-device: zero reserved media_links_enum field

2018-02-09 Thread Sakari Ailus
On Fri, Feb 09, 2018 at 02:25:44PM +0100, Hans Verkuil wrote: > Zero the reserved field of struct media_links_enum. > > Signed-off-by: Hans Verkuil > Reported-by: Sakari Ailus Thanks! Acked-by: Sakari Ailus > --- > diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c > in

[PATCH] media-device: zero reserved media_links_enum field

2018-02-09 Thread Hans Verkuil
Zero the reserved field of struct media_links_enum. Signed-off-by: Hans Verkuil Reported-by: Sakari Ailus --- diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index afbf23a19e16..7af6fadd206d 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@

Re: [PATCHv2 06/15] v4l2-subdev: implement VIDIOC_DBG_G_CHIP_INFO ioctl

2018-02-09 Thread Laurent Pinchart
Hi Hans, On Friday, 9 February 2018 15:13:26 EET Hans Verkuil wrote: > On 02/09/18 14:04, Laurent Pinchart wrote: > > On Friday, 9 February 2018 15:00:53 EET Hans Verkuil wrote: > >> On 02/09/18 13:44, Sakari Ailus wrote: > >>> On Fri, Feb 09, 2018 at 01:18:18PM +0100, Hans Verkuil wrote: > O

[PATCH] v4l: vsp1: Fix continuous mode for dual pipelines

2018-02-09 Thread Kieran Bingham
From: Kieran Bingham To allow dual pipelines utilising two WPF entities when available, the VSP was updated to support header-mode display list in continuous pipelines. A small bug in the status check of the command register causes the second pipeline to be directly afflicted by the running of t

Re: [PATCHv2 04/15] v4l2-subdev: without controls return -ENOTTY

2018-02-09 Thread Hans Verkuil
On 02/09/18 14:09, Sakari Ailus wrote: > On Fri, Feb 09, 2018 at 01:48:49PM +0100, Hans Verkuil wrote: >> On 02/09/18 13:38, Sakari Ailus wrote: >>> Hi Hans, >>> >>> On Fri, Feb 09, 2018 at 12:56:37PM +0100, Hans Verkuil wrote: On 02/09/18 12:46, Sakari Ailus wrote: > Hi Hans, > >

Re: [PATCHv2 06/15] v4l2-subdev: implement VIDIOC_DBG_G_CHIP_INFO ioctl

2018-02-09 Thread Hans Verkuil
On 02/09/18 14:04, Laurent Pinchart wrote: > Hi Hans, > > On Friday, 9 February 2018 15:00:53 EET Hans Verkuil wrote: >> On 02/09/18 13:44, Sakari Ailus wrote: >>> On Fri, Feb 09, 2018 at 01:18:18PM +0100, Hans Verkuil wrote: On 02/09/18 13:01, Sakari Ailus wrote: > On Thu, Feb 08, 2018 a

Re: [PATCHv2 04/15] v4l2-subdev: without controls return -ENOTTY

2018-02-09 Thread Sakari Ailus
On Fri, Feb 09, 2018 at 01:48:49PM +0100, Hans Verkuil wrote: > On 02/09/18 13:38, Sakari Ailus wrote: > > Hi Hans, > > > > On Fri, Feb 09, 2018 at 12:56:37PM +0100, Hans Verkuil wrote: > >> On 02/09/18 12:46, Sakari Ailus wrote: > >>> Hi Hans, > >>> > >>> On Thu, Feb 08, 2018 at 09:36:44AM +0100,

Re: [PATCHv2 11/15] media-device.c: zero reserved field

2018-02-09 Thread Sakari Ailus
Hi Hans, On Fri, Feb 09, 2018 at 01:52:50PM +0100, Hans Verkuil wrote: > On 02/09/18 13:46, Sakari Ailus wrote: > > On Fri, Feb 09, 2018 at 01:20:41PM +0100, Hans Verkuil wrote: > >> On 02/09/18 13:17, Sakari Ailus wrote: > >>> On Thu, Feb 08, 2018 at 09:36:51AM +0100, Hans Verkuil wrote: > M

Re: [PATCHv2 06/15] v4l2-subdev: implement VIDIOC_DBG_G_CHIP_INFO ioctl

2018-02-09 Thread Laurent Pinchart
Hi Hans, On Friday, 9 February 2018 15:00:53 EET Hans Verkuil wrote: > On 02/09/18 13:44, Sakari Ailus wrote: > > On Fri, Feb 09, 2018 at 01:18:18PM +0100, Hans Verkuil wrote: > >> On 02/09/18 13:01, Sakari Ailus wrote: > >>> On Thu, Feb 08, 2018 at 09:36:46AM +0100, Hans Verkuil wrote: > The

Re: [PATCHv2 06/15] v4l2-subdev: implement VIDIOC_DBG_G_CHIP_INFO ioctl

2018-02-09 Thread Hans Verkuil
On 02/09/18 13:44, Sakari Ailus wrote: > On Fri, Feb 09, 2018 at 01:18:18PM +0100, Hans Verkuil wrote: >> On 02/09/18 13:01, Sakari Ailus wrote: >>> Hi Hans, >>> >>> On Thu, Feb 08, 2018 at 09:36:46AM +0100, Hans Verkuil wrote: The VIDIOC_DBG_G/S_REGISTER ioctls imply that VIDIOC_DBG_G_CHIP_IN

Re: [PATCHv2 06/15] v4l2-subdev: implement VIDIOC_DBG_G_CHIP_INFO ioctl

2018-02-09 Thread Laurent Pinchart
Hello, On Friday, 9 February 2018 14:44:07 EET Sakari Ailus wrote: > On Fri, Feb 09, 2018 at 01:18:18PM +0100, Hans Verkuil wrote: > > On 02/09/18 13:01, Sakari Ailus wrote: > >> On Thu, Feb 08, 2018 at 09:36:46AM +0100, Hans Verkuil wrote: > >>> The VIDIOC_DBG_G/S_REGISTER ioctls imply that VIDIO

Re: [PATCHv2 11/15] media-device.c: zero reserved field

2018-02-09 Thread Hans Verkuil
On 02/09/18 13:46, Sakari Ailus wrote: > On Fri, Feb 09, 2018 at 01:20:41PM +0100, Hans Verkuil wrote: >> On 02/09/18 13:17, Sakari Ailus wrote: >>> On Thu, Feb 08, 2018 at 09:36:51AM +0100, Hans Verkuil wrote: MEDIA_IOC_SETUP_LINK didn't zero the reserved field of the media_link_desc str

Re: [PATCHv2 00/15] Media Controller compliance fixes

2018-02-09 Thread Sakari Ailus
On Fri, Feb 09, 2018 at 02:48:07PM +0200, Sakari Ailus wrote: > On Thu, Feb 08, 2018 at 09:36:40AM +0100, Hans Verkuil wrote: > > From: Hans Verkuil > > > > Hi all, > > > > I've been posting random patches fixing various MC problems, but it is > > easier to see them all in a single patch series.

Re: [PATCHv2 04/15] v4l2-subdev: without controls return -ENOTTY

2018-02-09 Thread Hans Verkuil
On 02/09/18 13:38, Sakari Ailus wrote: > Hi Hans, > > On Fri, Feb 09, 2018 at 12:56:37PM +0100, Hans Verkuil wrote: >> On 02/09/18 12:46, Sakari Ailus wrote: >>> Hi Hans, >>> >>> On Thu, Feb 08, 2018 at 09:36:44AM +0100, Hans Verkuil wrote: If the subdev did not define any controls, then retu

Re: [PATCHv2 00/15] Media Controller compliance fixes

2018-02-09 Thread Sakari Ailus
On Thu, Feb 08, 2018 at 09:36:40AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Hi all, > > I've been posting random patches fixing various MC problems, but it is > easier to see them all in a single patch series. > > All patches except 13 and 14 are identical to was I posted earlier. >

Re: [PATCHv2 11/15] media-device.c: zero reserved field

2018-02-09 Thread Sakari Ailus
On Fri, Feb 09, 2018 at 01:20:41PM +0100, Hans Verkuil wrote: > On 02/09/18 13:17, Sakari Ailus wrote: > > On Thu, Feb 08, 2018 at 09:36:51AM +0100, Hans Verkuil wrote: > >> MEDIA_IOC_SETUP_LINK didn't zero the reserved field of the media_link_desc > >> struct. Do so in media_device_setup_link(). >

Re: [PATCHv2 06/15] v4l2-subdev: implement VIDIOC_DBG_G_CHIP_INFO ioctl

2018-02-09 Thread Sakari Ailus
On Fri, Feb 09, 2018 at 01:18:18PM +0100, Hans Verkuil wrote: > On 02/09/18 13:01, Sakari Ailus wrote: > > Hi Hans, > > > > On Thu, Feb 08, 2018 at 09:36:46AM +0100, Hans Verkuil wrote: > >> The VIDIOC_DBG_G/S_REGISTER ioctls imply that VIDIOC_DBG_G_CHIP_INFO is > >> also > >> present, since with

Re: [PATCHv2 04/15] v4l2-subdev: without controls return -ENOTTY

2018-02-09 Thread Sakari Ailus
Hi Hans, On Fri, Feb 09, 2018 at 12:56:37PM +0100, Hans Verkuil wrote: > On 02/09/18 12:46, Sakari Ailus wrote: > > Hi Hans, > > > > On Thu, Feb 08, 2018 at 09:36:44AM +0100, Hans Verkuil wrote: > >> If the subdev did not define any controls, then return -ENOTTY if > >> userspace attempts to call

Re: [PATCHv2 13/15] media: document and zero reservedX fields in media_v2_topology

2018-02-09 Thread Sakari Ailus
Hi Hans, On Thu, Feb 08, 2018 at 09:36:53AM +0100, Hans Verkuil wrote: > The MEDIA_IOC_G_TOPOLOGY documentation didn't document the reservedX fields. > Related to that was that the documented type of the num_* fields was also > wrong. > > The reservedX fields were not set to 0, that is now also f

Re: [PATCHv2 11/15] media-device.c: zero reserved field

2018-02-09 Thread Hans Verkuil
On 02/09/18 13:17, Sakari Ailus wrote: > On Thu, Feb 08, 2018 at 09:36:51AM +0100, Hans Verkuil wrote: >> MEDIA_IOC_SETUP_LINK didn't zero the reserved field of the media_link_desc >> struct. Do so in media_device_setup_link(). >> >> Signed-off-by: Hans Verkuil >> --- >> drivers/media/media-devic

Re: [PATCHv2 06/15] v4l2-subdev: implement VIDIOC_DBG_G_CHIP_INFO ioctl

2018-02-09 Thread Hans Verkuil
On 02/09/18 13:01, Sakari Ailus wrote: > Hi Hans, > > On Thu, Feb 08, 2018 at 09:36:46AM +0100, Hans Verkuil wrote: >> The VIDIOC_DBG_G/S_REGISTER ioctls imply that VIDIOC_DBG_G_CHIP_INFO is also >> present, since without that you cannot use v4l2-dbg. >> >> Just like the implementation in v4l2-ioc

Re: [PATCHv2 11/15] media-device.c: zero reserved field

2018-02-09 Thread Sakari Ailus
On Thu, Feb 08, 2018 at 09:36:51AM +0100, Hans Verkuil wrote: > MEDIA_IOC_SETUP_LINK didn't zero the reserved field of the media_link_desc > struct. Do so in media_device_setup_link(). > > Signed-off-by: Hans Verkuil > --- > drivers/media/media-device.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCHv2 06/15] v4l2-subdev: implement VIDIOC_DBG_G_CHIP_INFO ioctl

2018-02-09 Thread Sakari Ailus
Hi Hans, On Thu, Feb 08, 2018 at 09:36:46AM +0100, Hans Verkuil wrote: > The VIDIOC_DBG_G/S_REGISTER ioctls imply that VIDIOC_DBG_G_CHIP_INFO is also > present, since without that you cannot use v4l2-dbg. > > Just like the implementation in v4l2-ioctl.c this can be implemented in the > core and n

Re: [PATCHv2 04/15] v4l2-subdev: without controls return -ENOTTY

2018-02-09 Thread Hans Verkuil
On 02/09/18 12:46, Sakari Ailus wrote: > Hi Hans, > > On Thu, Feb 08, 2018 at 09:36:44AM +0100, Hans Verkuil wrote: >> If the subdev did not define any controls, then return -ENOTTY if >> userspace attempts to call these ioctls. >> >> The control framework functions will return -EINVAL, not -ENOTT

Re: [PATCHv2 04/15] v4l2-subdev: without controls return -ENOTTY

2018-02-09 Thread Sakari Ailus
Hi Hans, On Thu, Feb 08, 2018 at 09:36:44AM +0100, Hans Verkuil wrote: > If the subdev did not define any controls, then return -ENOTTY if > userspace attempts to call these ioctls. > > The control framework functions will return -EINVAL, not -ENOTTY if > vfh->ctrl_handler is NULL. > > Several o

Re: [PATCH v9 6/8] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-09 Thread Tim Harvey
On Fri, Feb 9, 2018 at 12:02 AM, Hans Verkuil wrote: > On 02/09/2018 09:00 AM, Tim Harvey wrote: >> On Thu, Feb 8, 2018 at 11:41 PM, Hans Verkuil wrote: >>> On 02/09/2018 07:01 AM, Tim Harvey wrote: I don't see v4l2-subdev.c (or anything) ever calling g_input_status. How do I test

Re: [PATCH v10 6/8] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-09 Thread Hans Verkuil
Hi Tim, We're almost there. Two more comments: On 02/09/2018 07:32 AM, Tim Harvey wrote: > +static int > +tda1997x_detect_std(struct tda1997x_state *state, > + struct v4l2_dv_timings *timings) > +{ > + struct v4l2_subdev *sd = &state->sd; > + u32 vper; > + u16 hper; >

Re: [PATCH v9 6/8] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-09 Thread Hans Verkuil
On 02/09/2018 09:00 AM, Tim Harvey wrote: > On Thu, Feb 8, 2018 at 11:41 PM, Hans Verkuil wrote: >> On 02/09/2018 07:01 AM, Tim Harvey wrote: >>> >>> I don't see v4l2-subdev.c (or anything) ever calling g_input_status. >>> How do I test this? >> >> Huh, that's a very good question! It is meant to

Re: [PATCH v9 6/8] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-09 Thread Tim Harvey
On Thu, Feb 8, 2018 at 11:41 PM, Hans Verkuil wrote: > On 02/09/2018 07:01 AM, Tim Harvey wrote: >> >> I don't see v4l2-subdev.c (or anything) ever calling g_input_status. >> How do I test this? > > Huh, that's a very good question! It is meant to be called by bridge > drivers implementing VIDIOC_