On 02/09/2018 07:01 AM, Tim Harvey wrote:
>>> +static int
>>> +tda1997x_g_input_status(struct v4l2_subdev *sd, u32 *status)
>>> +{
>>> + struct tda1997x_state *state = to_state(sd);
>>> +
>>> + mutex_lock(&state->lock);
>>> + if (state->detected_timings)
>>
>> What this actually tests i
This is a v4l2 subdev driver supporting the TDA1997x HDMI video receiver.
I've tested this on a Gateworks GW54xx/GW551x with an IMX6Q/IMX6DL which
uses the TDA19971 with 16bits connected to the IMX6 CSI and single-lane
I2S audio providing 2-channel audio.
For this configuration I've tested both 1
Add a new media entity function definition for digital TV decoders:
MEDIA_ENT_F_DTV_DECODER
Signed-off-by: Tim Harvey
---
Documentation/media/uapi/mediactl/media-types.rst | 11 +++
include/uapi/linux/media.h| 5 +
2 files changed, 16 insertions(+)
diff --gi
From: Hans Verkuil
Add the v4l2_hdmi_colorimetry() function so we have a single function
that determines the colorspace, YCbCr encoding, quantization range and
transfer function from the InfoFrame data.
Cc: Randy Dunlap
Signed-off-by: Hans Verkuil
---
v9:
- fix kernel-doc format (Randy)
dri
The GW54xx has a front-panel microHDMI connector routed to a TDA19971
which is connected the the IPU CSI when using IMX6Q.
Signed-off-by: Tim Harvey
---
v5:
- remove leading 0 from unit address
- add newline between property list and child node
v4: no changes
v3: no changes
v2:
- add HDMI au
Signed-off-by: Tim Harvey
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 845fc25..439b500 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13262,6 +13262,14 @@ T: git git://linuxtv.org/mkrufky/tuners.git
S: Maintained
F: dri
Acked-by: Rob Herring
Acked-by: Sakari Ailus
Signed-off-by: Tim Harvey
---
v6:
- replace copyright with SPDX tag
- added Rob's ack
v5:
- added Sakari's ack
v4:
- move include/dt-bindings/media/tda1997x.h to bindings patch
- clarify port node details
v3:
- fix typo
v2:
- add vendor pre
Signed-off-by: Tim Harvey
---
v5:
- add missing audmux config
arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 138 ++
1 file changed, 138 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
index 30d4662..749548a 100
Signed-off-by: Tim Harvey
---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
b/drivers/media/v4l2-core/v4l2-ioctl.c
index 7961499..5f3670d 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/driver
Add support for the TDA1997x HDMI receivers.
Cc: Hans Verkuil
Signed-off-by: Tim Harvey
---
v10:
- removed unnecessary check for !timings in get/set/query dv timings (Hans)
- dropped pointless s_stream handler (Hans)
- remove need for detected_timings and always use set timings (Hans)
v9:
-
On Thu, Feb 8, 2018 at 7:06 AM, Hans Verkuil wrote:
> Hi Tim,
>
> I was so hoping I could make a pull request for this, but I still found
> problems with g/s/query_dv_timings.
>
> I strongly suspect that v4l2-compliance would fail if you boot up the system
> *without* a source connected.
>
> And I
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Feb 9 05:00:22 CET 2018
media-tree git hash:273caa260035c03d89ad63d72d8cd3d9e5c5e3f1
media_build git
The code is MEDIA_BUS_FMT_VYYUYY8_1X24
Signed-off-by: Satish Kumar Nagireddy
---
Documentation/media/uapi/v4l/subdev-formats.rst | 34 +
1 file changed, 34 insertions(+)
diff --git a/Documentation/media/uapi/v4l/subdev-formats.rst
b/Documentation/media/uapi/v4l/subdev-f
Get multiplying factor to calculate bpp especially
in case of 10 bit formats.
Get multiplying factor to calculate padding width
Signed-off-by: Satish Kumar Nagireddy
---
drivers/media/platform/xilinx/xilinx-dma.c | 29 ++---
1 file changed, 26 insertions(+), 3 deletions(-
From: Hyun Kwon
The pixel format for RGB24 is missing, and the driver
always falls back to YUYV as no format descriptor matches
with RGB24 fourcc. The pixel format is added to RGB24
format descriptor so that user can use the format.
Signed-off-by: Satish Kumar Nagireddy
---
drivers/media/platf
The current v4l driver supports single plane formats. This patch
will add support to handle multi-planar formats. Updated driver
capabilities to multi-planar, where it can handle both single and
multi-planar formats
Signed-off-by: Satish Kumar Nagireddy
---
drivers/media/platform/xilinx/xilinx-d
From: Jeffrey Mouroux
The Xilinx Video Framebuffer DMA IP supports video memory formats
that are not represented in the current V4L2 fourcc library. This
patch adds those missing fourcc codes. This includes both new
8-bit and 10-bit pixel formats.
Signed-off-by: Satish Kumar Nagireddy
---
incl
The patches are for xilinx v4l. The patcheset enable support to handle
multiplanar
formats and 10 bit formats. The implemenation has handling of single plane
formats
too for backward compatibility of some existing applications.
Some patches are included as dependencies and are intended to sy
This patch updates video format descriptor to help information
viz., number of planes per color format and chroma sub sampling
factors.
This commit adds the various 8-bit and 10-bit that are supported
to the table queried by drivers.
Signed-off-by: Satish Kumar Nagireddy
---
drivers/media/platf
From: Radhey Shyam Pandey
In current implementation driver only checks the colorspace
between the last subdev in the pipeline and the connected video node,
the pipeline could be configured with wrong colorspace information
until the very end. It thus makes little sense to check the
colorspace onl
From: Rohit Athavale
This commit adds a YUV 420 media bus format. Currently, one
doesn't exist. VYYUYY8_1X24 does not describe the way the pixels are
sent over the bus, but is an approximation.
Signed-off-by: Satish Kumar Nagireddy
---
include/uapi/linux/media-bus-format.h | 3 ++-
1 file chan
scaling_factor function returns multiplying factor to calculate
bytes per component based on color format.
For eg. scaling factor of YUV420 8 bit format is 1
so multiplying factor is 1 (8/8)
scaling factor of YUV420 10 bit format is 1.25 (10/8)
padding_factor function returns multiplying factor to
This is to avoid pending interrupts to be handled during
stream off, in which case, the ready buffer will be removed
from buffer list, thus not all buffers can be returned to VB2
as expected. Disable CIO2 irq at cio2_hw_exit() so no new
interrupts are generated.
Signed-off-by: Yong Zhi
Signed-off
Hi Kieran,
On Thursday, 8 February 2018 01:30:43 EET Kieran Bingham wrote:
> On 07/02/18 21:59, Laurent Pinchart wrote:
> > On Wednesday, 7 February 2018 17:14:09 EET Kieran Bingham wrote:
> >> On 29/01/18 10:26, Laurent Pinchart wrote:
> >>> On Monday, 22 January 2018 14:50:00 EET Kieran Bingham
Hi Maxime,
Thank you for the patch.
On Wednesday, 7 February 2018 16:26:43 EET Maxime Ripard wrote:
> The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used
> as a bridge between pixel interfaces and a CSI-2 bus.
>
> It supports operating with an internal or external D-PHY, wi
On 02/08/2018 08:27 PM, Steve Longerbeam wrote:
>
>
> On 02/08/2018 06:47 AM, Philipp Zabel wrote:
>> If no imx_media_pixfmt is found for a given mbus format code,
>> we shouldn't crash. Return -EINVAL for any index.
>
> Hi Philipp,
>
> If imx_media_find_mbus_format() returns NULL at that locat
From: Daniel Scheller
Deduplicate the checks for a valid ptr in port->en, and also handle the
default case to also catch eventually yet unsupported CI hardware.
Signed-off-by: Daniel Scheller
---
drivers/media/pci/ddbridge/ddbridge-ci.c | 12
1 file changed, 4 insertions(+), 8 del
From: Daniel Scheller
Convert the cxd2099 driver to use regmap for I2C accesses, removing all
own i2c_*() functions. With that, make the driver a proper I2C client
driver. This also adds the benefit of having a proper cleanup function
(cxd2099_remove() in this case) that takes care of resource cl
From: Daniel Scheller
Patch series done by Jasmin and me.
This patch series, besides one little cosmetic fix in ddbridge, converts
the cxd2099 CI controller driver to the regmap API and thus makes it a
proper I2C client driver. This not only moves it away from the legacy/
"proprietary" DVB attac
From: Daniel Scheller
Change the way the cxd2099 hardware is being attached to the new I2C
client interface way.
Signed-off-by: Daniel Scheller
Signed-off-by: Jasmin Jessich
---
drivers/media/pci/ddbridge/ddbridge-ci.c | 62 +---
drivers/media/pci/ddbridge/ddbridge
From: Daniel Scheller
Change the way the cxd2099 hardware is being attached to the new I2C
client interface way.
Signed-off-by: Daniel Scheller
Signed-off-by: Jasmin Jessich
---
drivers/media/pci/ngene/ngene-core.c | 41
drivers/media/pci/ngene/ngene.h
From: Daniel Scheller
According to the TODO file, this driver only landed in staging because of
the way device nodes and data transfers are handled. Besides that this way
(use of secX devices) has become sort of standard to date (ie. VDR
supports this literally since ages via the ddci plugin, TVH
From: Jasmin Jessich
The cxd2099 driver is now maintained and being taken care of by
* Jasmin Jessich
Signed-off-by: Jasmin Jessich
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index aee793bff977..c3b689e2583e 100644
--- a/MAINTAINER
From: Daniel Scheller
As all drivers using the cxd2099 are converted to handle attach/detach
the generic I2C client way, the static inline cxd2099_attach isn't
required anymore. Thus cleanup cxd2099.h from the remainders, the adr
struct member isn't used anymore aswell.
Signed-off-by: Daniel Sch
On 02/08/2018 06:47 AM, Philipp Zabel wrote:
If no imx_media_pixfmt is found for a given mbus format code,
we shouldn't crash. Return -EINVAL for any index.
Hi Philipp,
If imx_media_find_mbus_format() returns NULL at that location, it means
the current format has an invalid pixel code. It's
Hi Maxime,
Thank you for the patch.
On Wednesday, 7 February 2018 16:26:42 EET Maxime Ripard wrote:
> The Cadence MIPI-CSI2 TX controller is a CSI2 bridge that supports up to 4
> video streams and can output on up to 4 CSI-2 lanes, depending on the
> hardware implementation.
>
> It can operate w
Hi, Sakari,
> -Original Message-
> From: Sakari Ailus [mailto:sakari.ai...@iki.fi]
> Sent: Wednesday, February 7, 2018 11:38 PM
> To: Zhi, Yong
> Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com;
> tf...@chromium.org; Qiu, Tian Shu ; Zheng, Jian
> Xu ; Mani, Rajmohan
>
> Sub
Hi Maxime,
Thank you for the patch.
On Thursday, 8 February 2018 17:08:30 EET Maxime Ripard wrote:
> The Cadence CSI-2 RX Controller is an hardware block meant to be used as a
> bridge between a CSI-2 bus and pixel grabbers.
>
> It supports operating with internal or external D-PHY, with up to 4
cec_transmit_msg_fh() first checked the message for errors, and only after
the message was found to be valid did it log the message contents.
However, that makes it hard to associate an error in the kernel log with the
message since the message contents was never logged in that case.
So swap the
Hi Sakari,
On 02/07/2018 03:59 PM, Sakari Ailus wrote:
Hi Gustavo,
On Tue, Feb 06, 2018 at 10:47:50AM -0600, Gustavo A. R. Silva wrote:
Add suffix ULL to constants 1 and 100 in order to give the
compiler complete information about the proper arithmetic to use.
Notice that these constan
On 02/08/18 16:13, Philipp Zabel wrote:
> On Thu, 2018-02-08 at 13:01 +0100, Hans Verkuil wrote:
>>> These are likely to be filled correctly already. I've just added a commit
>>> to v4l2-compliance to make it easier to see what function is used:
>>>
>>> v4l2-compliance -m0 -v
>>
>> Actually, ca
Hi,
Here is the seventh attempt at supporting the MIPI-CSI2 RX block from
Cadence.
This IP block is able to receive CSI data over up to 4 lanes, and
split it to over 4 streams. Those streams are basically the interfaces
to the video grabbers that will perform the capture.
It is able to map strea
The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up to
4 CSI-2 lanes, and can route the frames to up to 4 streams, depending on
the hardware implementation.
It can operate with an external D-PHY, an internal one or no D-PHY at all
in some configurations.
Acked-by: Rob Herring
The Cadence CSI-2 RX Controller is an hardware block meant to be used as a
bridge between a CSI-2 bus and pixel grabbers.
It supports operating with internal or external D-PHY, with up to 4 lanes,
or without any D-PHY. The current code only supports the former case.
It also support dynamic mappin
Hi Tim,
I was so hoping I could make a pull request for this, but I still found
problems with g/s/query_dv_timings.
I strongly suspect that v4l2-compliance would fail if you boot up the system
*without* a source connected.
And I discovered that I was missing additional checks in the timings test
If no imx_media_pixfmt is found for a given mbus format code,
we shouldn't crash. Return -EINVAL for any index.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-csi.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/media/imx/imx-media-csi.c
b/drivers/
The following changes since commit 273caa260035c03d89ad63d72d8cd3d9e5c5e3f1:
media: v4l2-compat-ioctl32.c: make ctrl_is_pointer work for subdevs
(2018-01-31 03:09:04 -0500)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git sur40
for you to fetch changes up t
Use v4l2_find_nearest_size instead of a driver specific function to find
nearest matching size.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/ov5670.c | 34 +++---
1 file changed, 3 insertions(+), 31 deletions(-)
diff --git a/drivers/media/i2c/ov5670.c b/drivers/
Use v4l2_find_nearest_size instead of a driver specific function to find
nearest matching size.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/vivid/vivid-vid-cap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/vivid/vivid-vid-cap.c
b/d
Use v4l2_find_nearest_size instead of a driver specific function to find
nearest matching size.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/ov13858.c | 37 +++--
1 file changed, 3 insertions(+), 34 deletions(-)
diff --git a/drivers/media/i2c/ov13858.c b/dri
Hi folks,
This set should make it a bit easier to support finding the right size in
sensor drivers. Two sensor drivers and vivid are converted as an example.
I've tested the vivid change only but the patches are effectively the same
and trivial.
Sakari Ailus (5):
v4l: common: Add a function to
Add a function (as well as a helper macro) to obtain the best size in a
list of device specific sizes. This helps writing drivers as well as
aligns interface behaviour across drivers.
The struct in which this information is contained in is typically specific
to the driver, therefore the existing f
v4l2_find_nearest_format is not useful for drivers in finding the best
matching format as it assumes a V4L2 specific struct. Drivers will use
v4l2_find_nearest_size instead.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-common.c | 26 --
include/media/v4l2-
After a framerate update through s_frame_interval(), the new
framerate was not taken into account when streaming,
but was taken into account on next session.
This was due to sensor->current_mode not updated accordingly to new
framerate setting in ov5640_s_frame_interval().
Signed-off-by: Hugues Fr
After a framerate update through s_frame_interval(), the new
framerate was not taken into account when streaming,
but was taken into account on next session.
This was due to sensor->current_mode not updated accordingly to new
framerate setting in ov5640_s_frame_interval().
Change-Id: I6d62510b708c
On 02/08/18 12:56, Hans Verkuil wrote:
> On 02/08/18 11:46, Philipp Zabel wrote:
>> On Wed, 2018-02-07 at 23:19 +0100, Hans Verkuil wrote:
>>> On 02/07/2018 11:05 PM, Tim Harvey wrote:
On Wed, Feb 7, 2018 at 1:09 AM, Hans Verkuil wrote:
> On 02/07/18 09:22, Hans Verkuil wrote:
>> On 0
On 02/08/18 11:46, Philipp Zabel wrote:
> On Wed, 2018-02-07 at 23:19 +0100, Hans Verkuil wrote:
>> On 02/07/2018 11:05 PM, Tim Harvey wrote:
>>> On Wed, Feb 7, 2018 at 1:09 AM, Hans Verkuil wrote:
On 02/07/18 09:22, Hans Verkuil wrote:
> On 02/07/2018 12:29 AM, Tim Harvey wrote:
>> M
Thanks Hans,
v2 sent, rebased on your helpers !
Best regards,
Hugues.
On 02/07/2018 06:52 PM, Hans Verkuil wrote:
> On 02/07/2018 06:43 PM, Hugues Fruchet wrote:
>> Add g/s_parm framerate support by calling subdev
>> g/s_frame_interval ops.
>> This allows user to control sensor framerate by
>> cal
Add g/s_parm framerate support by calling subdev
g/s_frame_interval ops.
This allows user to control sensor framerate by
calling ioctl G/S_PARM.
Signed-off-by: Hugues Fruchet
---
version 2:
- Rebase on Hans branch to use new helpers:
See https://www.mail-archive.com/linux-media@vger.kernel.
On Wed, 2018-02-07 at 23:19 +0100, Hans Verkuil wrote:
> On 02/07/2018 11:05 PM, Tim Harvey wrote:
> > On Wed, Feb 7, 2018 at 1:09 AM, Hans Verkuil wrote:
> > > On 02/07/18 09:22, Hans Verkuil wrote:
> > > > On 02/07/2018 12:29 AM, Tim Harvey wrote:
> > > > > Media Controller ioctls:
> > > > >
Hi hans,
2018-02-06 21:21 GMT+08:00 Hans Verkuil :
> On 12/29/17 08:52, Shunqian Zheng wrote:
>> From: Jacob Chen
>>
>> This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver
>>
>> Signed-off-by: Jacob Chen
>> Signed-off-by: Shunqian Zheng
>> Signed-off-by: Tomasz Figa
>> ---
Find the sensor mode by comparing the size of the requested image size
and the sensor mode's image size. The distance between image sizes is the
size in pixels of the non-overlapping regions between the requested size
and the frame-specified size. This logic is borrowed from et8ek8 sensor
driver.
I2C transfer functions return number of successful operations (on success).
Do not return the received positive return code but instead return 0 on
success. The users of write_reg function already use this logic.
Signed-off-by: Todor Tomov
---
drivers/media/i2c/ov5645.c | 6 --
1 file chang
Hi Maxime,
On Thu, Feb 08, 2018 at 11:05:08AM +0200, Sakari Ailus wrote:
> Hi Maxime,
>
> Thanks for the update. Please see my comments below.
>
> On Wed, Feb 07, 2018 at 03:24:37PM +0100, Maxime Ripard wrote:
> > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a
> > bri
On Wed, Feb 07, 2018 at 03:26:42PM +0100, Maxime Ripard wrote:
> The Cadence MIPI-CSI2 TX controller is a CSI2 bridge that supports up to 4
> video streams and can output on up to 4 CSI-2 lanes, depending on the
> hardware implementation.
>
> It can operate with an external D-PHY, an internal one
Hi Maxime,
Thanks for the update. Please see my comments below.
On Wed, Feb 07, 2018 at 03:24:37PM +0100, Maxime Ripard wrote:
> The Cadence CSI-2 RX Controller is an hardware block meant to be used as a
> bridge between a CSI-2 bus and pixel grabbers.
>
> It supports operating with internal or
The ov7251 sensor is a 1/7.5-Inch B&W VGA (640x480) CMOS Digital Image
Sensor from Omnivision.
The driver supports the following modes:
- 640x480 30fps
- 640x480 60fps
- 640x480 90fps
Output format is MIPI RAW 10.
The driver supports configuration via user controls for:
- exposure and gain;
- ho
Add the document for ov7251 device tree binding.
CC: Rob Herring
CC: Mark Rutland
CC: devicet...@vger.kernel.org
Signed-off-by: Todor Tomov
---
.../devicetree/bindings/media/i2c/ov7251.txt | 51 ++
1 file changed, 51 insertions(+)
create mode 100644 Documentation/dev
This replaces all the old boilerplate license code with the new SPDX
tags for Cisco-authored files in the media subsystem.
Regards,
Hans
The following changes since commit 273caa260035c03d89ad63d72d8cd3d9e5c5e3f1:
media: v4l2-compat-ioctl32.c: make ctrl_is_pointer work for subdevs
(2
There are currently two subdev ops variants to get/set the frame interval:
g/s_parm and g/s_frame_interval.
This patch series replaces all g/s_parm calls by g/s_frame_interval.
The first patch adds helper functions that can be used by bridge drivers.
Only em28xx can't use it and it needs custom c
This patch registers four standard control handlers using the corresponding
V4L2 framework.
Signed-off-by: Florian Echtler
---
drivers/input/touchscreen/sur40.c | 64 +++
1 file changed, 64 insertions(+)
diff --git a/drivers/input/touchscreen/sur40.c
b/drive
This patch adds parameter definitions and module parameters for the four
userspace controls that the SUR40 can currently provide.
Signed-off-by: Florian Echtler
---
drivers/input/touchscreen/sur40.c | 28
1 file changed, 28 insertions(+)
diff --git a/drivers/input/t
Iteration 4, now with min/max values for module parameters.
Best regards, Florian
The SUR40 can recognize specific printed patterns directly in hardware;
this information (i.e. the pattern id) is present but currently unused
in the blob structure.
Signed-off-by: Florian Echtler
---
drivers/input/touchscreen/sur40.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
di
These functions provide write access to the internal LCD panel registers
which also control the sensor. They can be used to disable the
preprocessor, set the illumination brightness, and adjust gain/contrast
(which are stored together in one register internally called "vsvideo").
Signed-off-by: Fl
On 02/07/2018 03:39 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> If the device is of type VFL_TYPE_SUBDEV then vdev->ioctl_ops
> is NULL so the 'if (!ops->vidioc_query_ext_ctrl)' check would crash.
> Add a test for !ops to the condition.
>
> All sub-devices that have controls will use the co
Clear the reserved fields for these ioctls according to the specification:
VIDIOC_SUBDEV_ENUM_FRAME_INTERVAL
VIDIOC_SUBDEV_ENUM_FRAME_SIZE
VIDIOC_SUBDEV_ENUM_MBUS_CODE
VIDIOC_SUBDEV_G_CROP, VIDIOC_SUBDEV_S_CROP
VIDIOC_SUBDEV_G_FMT, VIDIOC_SUBDEV_S_FMT
VIDIOC_SUBDEV_G_FRAME_INTERVAL, VIDIOC_SUBDEV_
From: Hans Verkuil
Hi all,
I've been posting random patches fixing various MC problems, but it is
easier to see them all in a single patch series.
All patches except 13 and 14 are identical to was I posted earlier.
For 13 and 14 I decided to drop the requirement that the application
clears the
The pad field should be passed on to the subdev driver, but it is cleared in
v4l2-ioctl.c so the subdev driver always sees a 0 pad.
Found with v4l2-compliance.
Signed-off-by: Hans Verkuil
Reported-by: Tim Harvey
Acked-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
1 file ch
The media.h public header is very messy. It mixes legacy and 'new' defines
and it is not easy to figure out what should and what shouldn't be used. It
also contains confusing comment that are either out of date or completely
uninteresting for anyone that needs to use this header.
The patch groups
These structures have reserved fields that were never documented.
Signed-off-by: Hans Verkuil
---
.../media/uapi/mediactl/media-ioc-enum-entities.rst | 19 +++
.../media/uapi/mediactl/media-ioc-enum-links.rst | 18 ++
2 files changed, 33 insertions(+), 4 de
MEDIA_IOC_SETUP_LINK didn't zero the reserved field of the media_link_desc
struct. Do so in media_device_setup_link().
Signed-off-by: Hans Verkuil
---
drivers/media/media-device.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
in
The source_id and sink_id descriptions were the same for interface-to-entity
links. The source_id is the interface ID, not the entity ID. Fix this.
Signed-off-by: Hans Verkuil
---
Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
The sensor subdev didn't handle control events. Add support for this.
Found with v4l2-compliance.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vimc/vimc-common.c | 4 +++-
drivers/media/platform/vimc/vimc-sensor.c | 8
2 files changed, 11 insertions(+), 1 deletion(-)
diff --g
Subdevs are initialized with MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN, not
MEDIA_ENT_T_V4L2_SUBDEV_UNKNOWN.
Signed-off-by: Hans Verkuil
---
include/uapi/linux/media.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
index b9b94460
From: Alexandre Courbot
with -> which
Signed-off-by: Alexandre Courbot
---
Documentation/media/uapi/mediactl/media-types.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/media/uapi/mediactl/media-types.rst
b/Documentation/media/uapi/mediactl/media-types.rs
The VIDIOC_DBG_G/S_REGISTER ioctls imply that VIDIOC_DBG_G_CHIP_INFO is also
present, since without that you cannot use v4l2-dbg.
Just like the implementation in v4l2-ioctl.c this can be implemented in the
core and no drivers need to be modified.
It also makes it possible for v4l2-compliance to p
The MEDIA_IOC_G_TOPOLOGY documentation didn't document the reservedX fields.
Related to that was that the documented type of the num_* fields was also
wrong.
The reservedX fields were not set to 0, that is now also fixed.
Found with v4l2-compliance.
Signed-off-by: Hans Verkuil
---
.../media/ua
If the subdev did not define any controls, then return -ENOTTY if
userspace attempts to call these ioctls.
The control framework functions will return -EINVAL, not -ENOTTY if
vfh->ctrl_handler is NULL.
Several of these framework functions are also called directly from
drivers, so I don't want to
Instead of calling everything a MEDIA_ENT_F_ATV_DECODER, pick the
correct functions for these blocks.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vimc/vimc-debayer.c | 2 +-
drivers/media/platform/vimc/vimc-scaler.c | 2 +-
drivers/media/platform/vimc/vimc-sensor.c | 2 +-
3 files c
The ycbcr_enc, quantization and xfer_func fields are __u16 and not enums.
Signed-off-by: Hans Verkuil
---
Documentation/media/uapi/v4l/subdev-formats.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/media/uapi/v4l/subdev-formats.rst
b/Documentation/med
data conector -> connector
... -> etc.
'...' looked odd when my browser put the ... by itself on the next line, 'etc.'
is clearer IMHO.
Signed-off-by: Hans Verkuil
Acked-by: Sakari Ailus
---
Documentation/media/uapi/mediactl/media-types.rst | 10 +-
1 file changed, 5 insertions(+), 5
ivtv-alsa-mixer functions was introduced in commit 269c11fbac4f ("[media] ivtv,
ivtv-alsa: Add initial ivtv-alsa interface driver for ivtv")
But according to commit message, ivtv-alsa-mixer.c was already dead
code.
5 years after, we should remove it.
Signed-off-by: Corentin Labbe
---
drivers/me
cx18-alsa-mixer functions are not used since commit 4cb565cc2700 ("V4L/DVB:
cx18: make it so cx18-alsa-main.c compiles")
9 year later, lets just remove them.
Signed-off-by: Corentin Labbe
---
drivers/media/pci/cx18/cx18-alsa-main.c | 1 -
drivers/media/pci/cx18/cx18-alsa-mixer.c | 170 ---
94 matches
Mail list logo
