cron job: media_tree daily build: ERRORS

2017-11-01 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Nov 2 05:00:16 CET 2017 media-tree git hash:9917fbcfa20ab987d6381fd0365665e5c1402d75 media_build git

Re: [PATCH] [media] dw9714: Set the v4l2 focus ctrl step as 1

2017-11-01 Thread Tomasz Figa
On Thu, Nov 2, 2017 at 1:00 PM, Tomasz Figa wrote: > Hi Sakari, > > On Thu, Aug 31, 2017 at 6:28 AM, Sakari Ailus wrote: >> Hi Rajmohan, >> >> On Wed, Aug 30, 2017 at 10:48:52AM -0700, Rajmohan Mani wrote: >>> Current v4l2 focus ctrl step value of 16, limits >>> the minimum granularity of focus p

Re: [PATCH] dma-buf: Cleanup comments on dma_buf_map_attachment()

2017-11-01 Thread Alex Deucher
On Wed, Nov 1, 2017 at 10:06 AM, Liviu Dudau wrote: > Mappings need to be unmapped by calling dma_buf_unmap_attachment() and > not by calling again dma_buf_map_attachment(). Also fix some spelling > mistakes. > > Signed-off-by: Liviu Dudau Reviewed-by: Alex Deucher > --- > drivers/dma-buf/dma

Re: [PATCH] [media] dw9714: Set the v4l2 focus ctrl step as 1

2017-11-01 Thread Tomasz Figa
Hi Sakari, On Thu, Aug 31, 2017 at 6:28 AM, Sakari Ailus wrote: > Hi Rajmohan, > > On Wed, Aug 30, 2017 at 10:48:52AM -0700, Rajmohan Mani wrote: >> Current v4l2 focus ctrl step value of 16, limits >> the minimum granularity of focus positions to 16. >> Setting this value as 1, enables more accur

Re: [PATCH] media: atmel-isc: get rid of an unused var

2017-11-01 Thread Yang, Wenyou
On 2017/10/31 17:37, Mauro Carvalho Chehab wrote: drivers/media/platform/atmel/atmel-isc.c: In function 'isc_async_complete': drivers/media/platform/atmel/atmel-isc.c:1900:28: warning: variable 'sd_entity' set but not used [-Wunused-but-set-variable] struct isc_subdev_entity *sd_entity;

Re: [PATCH v2 08/26] media: v4l2-async: shut up an unitialized symbol warning

2017-11-01 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Wednesday, 1 November 2017 23:05:45 EET Mauro Carvalho Chehab wrote: > Smatch reports this warning: > drivers/media/v4l2-core/v4l2-async.c:597 v4l2_async_register_subdev() > error: uninitialized symbol 'ret'. > > However, there's nothing wrong there. S

Re: [PATCH v2 14/26] media: xilinx: fix a debug printk

2017-11-01 Thread Laurent Pinchart
Hi Mauro, (CC'ing Rob and Sakari) Thank you for the patch. On Wednesday, 1 November 2017 23:05:51 EET Mauro Carvalho Chehab wrote: > Two orthogonal changesets caused a breakage at several printk > messages inside xilinx. Changeset 859969b38e2e > ("[media] v4l: Switch from V4L2 OF not V4L2 fwnode

Re: MAINTAINERS has a AS3645A LED FLASH duplicated section in -next

2017-11-01 Thread Laurent Pinchart
Hi Joe, On Thursday, 2 November 2017 03:54:29 EET Joe Perches wrote: > MAINTAINERS is not supposed to have duplicated sections. > Can you both please resolve this? Sure. Sakari, your plan was to drop drivers/media/i2c/as3645a.c if I recall correctly. Do you still want to proceed with that, or s

MAINTAINERS has a AS3645A LED FLASH duplicated section in -next

2017-11-01 Thread Joe Perches
MAINTAINERS is not supposed to have duplicated sections. Can you both please resolve this? AS3645A LED FLASH CONTROLLER DRIVER M: Sakari Ailus L: linux-l...@vger.kernel.org S: Maintained F: drivers/leds/leds-as3645a.c AS3645A LED FLASH CONTROLLER DRIVER M: Laurent Pincha

[no subject]

2017-11-01 Thread Roy Cockrum Foundation
Hallo, Sie machen eine Spende von 4.800.000,00 EUR, ich habe die America Lotto in Amerika im Wert von 259,9 Millionen Dollar gewonnen, und ich gebe einen Teil davon fünf glückliche Menschen und Wohltätigkeits-Häuser in Erinnerung an meine verstorbene Frau, die an Krebs gestorben ist. Kontaktie

Re: [PATCH v4 2/3] media: ov7740: Document device tree bindings

2017-11-01 Thread Rob Herring
On Tue, Oct 31, 2017 at 09:11:44AM +0800, Wenyou Yang wrote: > Add the device tree binding documentation for the ov7740 sensor driver. > > Signed-off-by: Wenyou Yang > --- > > Changes in v4: None > Changes in v3: > - Explicitly document the "remote-endpoint" property. > > Changes in v2: None >

RE: [PATCH v4 03/12] intel-ipu3: Add IOMMU based dmamap support

2017-11-01 Thread Zhi, Yong
Hi, Sakari, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Friday, October 20, 2017 2:20 AM > To: Zhi, Yong > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; Zheng, Jian > Xu ; Mani, Rajmohan > ; Toivonen, Tuukka > ; Hu, Jerry W ; > a...@arnd

[PATCH v2 02/26] media: dvb_frontend: be sure to init dvb_frontend_handle_ioctl() return code

2017-11-01 Thread Mauro Carvalho Chehab
As smatch warned: drivers/media/dvb-core/dvb_frontend.c:2468 dvb_frontend_handle_ioctl() error: uninitialized symbol 'err'. The ioctl handler actually got a regression here: before changeset d73dcf0cdb95 ("media: dvb_frontend: cleanup ioctl handling logic"), the code used to return -EOPNO

[PATCH v2 05/26] media: s5c73m3-core: fix logic on a timeout condition

2017-11-01 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/i2c/s5c73m3/s5c73m3-core.c:268 s5c73m3_check_status() error: uninitialized symbol 'status'. if s5c73m3_check_status() is called too late, time_is_after_jiffies(end) will return 0, causing the while to abort before reading status. The current code will d

[PATCH v2 22/26] [RFC] media: cxd2841er: ensure that status will always be available

2017-11-01 Thread Mauro Carvalho Chehab
The loop with read status use a dynamic timeout value, calculated from symbol rate. It should run the loop at least one time for the status to be handled after the loop. While this should, in practice, happen every time, it doesn't hurt to change the logic to make it explicit. This solves a smatc

[PATCH v2 03/26] media: led-class-flash: better handle NULL flash struct

2017-11-01 Thread Mauro Carvalho Chehab
The logic at V4L2 led core assumes that the flash struct can be null. However, it doesn't check for null while trying to set, causing some smatch to warn: drivers/media/v4l2-core/v4l2-flash-led-class.c:210 v4l2_flash_s_ctrl() error: we previously assumed 'fled_cdev' could be null (see li

[PATCH v2 13/26] media: rcar: fix a debug printk

2017-11-01 Thread Mauro Carvalho Chehab
Two orthogonal changesets caused a breakage at a printk inside rcar. Changeset 859969b38e2e ("[media] v4l: Switch from V4L2 OF not V4L2 fwnode API") made davinci to use struct fwnode_handle instead of struct device_node. Changeset 68d9c47b1679 ("media: Convert to using %pOF instead of full_name") c

[PATCH v2 14/26] media: xilinx: fix a debug printk

2017-11-01 Thread Mauro Carvalho Chehab
Two orthogonal changesets caused a breakage at several printk messages inside xilinx. Changeset 859969b38e2e ("[media] v4l: Switch from V4L2 OF not V4L2 fwnode API") made davinci to use struct fwnode_handle instead of struct device_node. Changeset 68d9c47b1679 ("media: Convert to using %pOF instead

[PATCH v2 06/26] media: xc5000: better handle I2C error messages

2017-11-01 Thread Mauro Carvalho Chehab
As warned by smatch, there are several places where the I2C transfer may fail, leading into inconsistent behavior: drivers/media/tuners/xc5000.c:689 xc_debug_dump() error: uninitialized symbol 'regval'. drivers/media/tuners/xc5000.c:841 xc5000_is_firmware_loaded() error: uninitia

[PATCH v2 16/26] media: drxd_hard: better handle I2C errors

2017-11-01 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/dvb-frontends/drxd_hard.c:989 HI_Command() error: uninitialized symbol 'waitCmd'. drivers/media/dvb-frontends/drxd_hard.c:1306 SC_WaitForReady() error: uninitialized symbol 'curCmd'. drivers/media/dvb-frontends/drxd_hard.c:1322 SC_SendCom

[PATCH v2 17/26] media: mxl111sf: improve error handling logic

2017-11-01 Thread Mauro Carvalho Chehab
As reported by smatch: drivers/media/usb/dvb-usb-v2/mxl111sf-demod.c:485 mxl111sf_demod_read_signal_strength() error: uninitialized symbol 'modulation'. The mxl111sf_demod_read_signal_strength() just ignores if something gets wrong while reading snr or modulation. Signed-off-by: Mauro Ca

[PATCH v2 12/26] media: davinci: fix a debug printk

2017-11-01 Thread Mauro Carvalho Chehab
Two orthogonal changesets caused a breakage at a printk inside davinci. Changeset a2d17962c9ca ("[media] davinci: Switch from V4L2 OF to V4L2 fwnode") made davinci to use struct fwnode_handle instead of struct device_node. Changeset 68d9c47b1679 ("media: Convert to using %pOF instead of full_name")

[PATCH v2 08/26] media: v4l2-async: shut up an unitialized symbol warning

2017-11-01 Thread Mauro Carvalho Chehab
Smatch reports this warning: drivers/media/v4l2-core/v4l2-async.c:597 v4l2_async_register_subdev() error: uninitialized symbol 'ret'. However, there's nothing wrong there. So, just shut up the warning. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/v4l2-async.c | 2 +-

[PATCH v2 09/26] media: cx25821-alsa: fix usage of a pointer printk

2017-11-01 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/pci/cx25821/cx25821-alsa.c:155 cx25821_alsa_dma_init() warn: argument 3 to %08lx specifier is cast from pointer Use the standard %p to print a pointer. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/cx25821/cx25821-alsa.c | 4 ++-- 1 file

[PATCH v2 18/26] media: dvbsky: shut up a bogus warning

2017-11-01 Thread Mauro Carvalho Chehab
Smatch gives two bogus warnings on this driver: drivers/media/usb/dvb-usb-v2/dvbsky.c:336 dvbsky_s960_attach() error: uninitialized symbol 'i2c_adapter'. drivers/media/usb/dvb-usb-v2/dvbsky.c:459 dvbsky_s960c_attach() error: uninitialized symbol 'i2c_adapter'. Shut them up. Sign

[PATCH v2 21/26] media: m88rs2000: handle the case where tuner doesn't have get_frequency

2017-11-01 Thread Mauro Carvalho Chehab
If the tuner doesn't have get_frequency() callback, the current code will place a random value as the frequency offset. That doesn't seem right! The better is to just assume that, on such case, the tuner was able to set the exact frequency that was requested. Fixes a smatch warning: driver

[PATCH v2 15/26] media: pt1: fix logic when pt1_nr_tables is zero or negative

2017-11-01 Thread Mauro Carvalho Chehab
pt1_nr_tables is a modprobe parameter. The way the logic handles it, it can't be negative. However, user can set it to zero. If set to zero, however, it will cause troubles at pt1_init_tables(), as reported by smatch: drivers/media/pci/pt1/pt1.c:468 pt1_init_tables() error: uninitialized

[PATCH v2 19/26] media: ov9650: fix bogus warnings

2017-11-01 Thread Mauro Carvalho Chehab
The smatch logic gets confused with the syntax used to check if the ov9650x_read() reads succedded: drivers/media/i2c/ov9650.c:895 __g_volatile_ctrl() error: uninitialized symbol 'reg2'. drivers/media/i2c/ov9650.c:895 __g_volatile_ctrl() error: uninitialized symbol 'reg1'. There'

[PATCH v2 26/26] media: mb86a16: avoid division by zero

2017-11-01 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/dvb-frontends/mb86a16.c:1690 mb86a16_read_ber() error: uninitialized symbol 'timer'. drivers/media/dvb-frontends/mb86a16.c:1706 mb86a16_read_ber() error: uninitialized symbol 'timer'. There is a potential risk of doing a division by zero if time

[PATCH v2 25/26] media: mb86a16: be more resilient if I2C fails on sync

2017-11-01 Thread Mauro Carvalho Chehab
If the I2C read fails while check for sync, there's no point on doing adjusting the tuner due to a random value that might be at VIRM var. So, set VIRM to zero, as that makes the caller for check_sync() to return an error. Fix those smatch warnings: drivers/media/dvb-frontends/mb86a16.c:14

Re: [PATCH v2 01/26] media: atmel-isc: avoid returning a random value at isc_parse_dt()

2017-11-01 Thread Mauro Carvalho Chehab
Em Wed, 1 Nov 2017 18:59:48 -0200 Mauro Carvalho Chehab escreveu: > Em Wed, 1 Nov 2017 16:56:33 -0400 > Mauro Carvalho Chehab escreveu: > > > As warned by smatch: > > drivers/media/platform/atmel/atmel-isc.c:2097 isc_parse_dt() error: > > uninitialized symbol 'ret'. > > > > The problem here

[PATCH v2 11/26] media: qt1010: fix bogus warnings

2017-11-01 Thread Mauro Carvalho Chehab
The logic at qt1010_init_meas1() and qt1010_init_meas2() are too complex for static analizers to identify that some vars are always be initialized. That causes smatch to produce the following warnings: drivers/media/tuners/qt1010.c:248 qt1010_init_meas1() error: uninitialized symbol 'val2

[PATCH v2 23/26] media: drxj: better handle errors

2017-11-01 Thread Mauro Carvalho Chehab
as reported by smatch: drivers/media/dvb-frontends/drx39xyj/drxj.c:2157 drxj_dap_atomic_read_write_block() error: uninitialized symbol 'word'. The driver doesn't check if a read error occurred. Add such check. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xy

[PATCH v2 24/26] media: stv090x: Only print tuner lock if get_status is available

2017-11-01 Thread Mauro Carvalho Chehab
The current code doesn't report tuner lock properly if the tuner get_status callback is not available, as reported by smatch: drivers/media/dvb-frontends/stv090x.c:2220 stv090x_get_coldlock() error: uninitialized symbol 'reg'. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-f

[PATCH v2 07/26] media: radio-si476x: fix behavior when seek->range* are defined

2017-11-01 Thread Mauro Carvalho Chehab
The logic at si476x_radio_s_hw_freq_seek() checks if the frequency range that will be used to handle hardware seek has the minimal frequency under rangelow. That works fine if userspace zeros both fields. However, if userspace fills either seek->rangelow or seek-rangehigh, it won't read the corresp

[PATCH v2 04/26] media: tda8290: initialize agc gain

2017-11-01 Thread Mauro Carvalho Chehab
The tuning logic at tda8290 relies on agc_stat and adc_sat to be initialized. However, as warned by smatch: drivers/media/tuners/tda8290.c:261 tda8290_set_params() error: uninitialized symbol 'agc_stat'. drivers/media/tuners/tda8290.c:261 tda8290_set_params() error: uninitialized

[PATCH v2 10/26] media: xc4000: don't ignore error if hwmodel fails

2017-11-01 Thread Mauro Carvalho Chehab
If, for some reason, reading the hwmodel register on xc4000 fails, it will cause the following logig to use a random value, as reported by smatch: drivers/media/tuners/xc4000.c:1047 check_firmware() error: uninitialized symbol 'hwmodel'. drivers/media/tuners/xc4000.c:1060 check_fi

[PATCH v2 20/26] media: imx274: don't randomly return if range_count is zero

2017-11-01 Thread Mauro Carvalho Chehab
As smatch reported: drivers/media/i2c/imx274.c:659 imx274_regmap_util_write_table_8() error: uninitialized symbol 'err'. There is a bug at imx274_regmap_util_write_table_8() with causes it to randomly return a random error if range_count is zero. Worse than that, the logic there starts w

Re: [PATCH v2 01/26] media: atmel-isc: avoid returning a random value at isc_parse_dt()

2017-11-01 Thread Mauro Carvalho Chehab
Em Wed, 1 Nov 2017 18:59:48 -0200 Mauro Carvalho Chehab escreveu: > Em Wed, 1 Nov 2017 16:56:33 -0400 > Mauro Carvalho Chehab escreveu: > > > As warned by smatch: > > drivers/media/platform/atmel/atmel-isc.c:2097 isc_parse_dt() error: > > uninitialized symbol 'ret'. > > > > The problem here

Re: [PATCH v2 01/26] media: atmel-isc: avoid returning a random value at isc_parse_dt()

2017-11-01 Thread Mauro Carvalho Chehab
Em Wed, 1 Nov 2017 16:56:33 -0400 Mauro Carvalho Chehab escreveu: > As warned by smatch: > drivers/media/platform/atmel/atmel-isc.c:2097 isc_parse_dt() error: > uninitialized symbol 'ret'. > > The problem here is that of_graph_get_next_endpoint() can > potentially return NULL on its first pass

[PATCH v2 01/26] media: atmel-isc: avoid returning a random value at isc_parse_dt()

2017-11-01 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/platform/atmel/atmel-isc.c:2097 isc_parse_dt() error: uninitialized symbol 'ret'. The problem here is that of_graph_get_next_endpoint() can potentially return NULL on its first pass, with would make it return a random value, as ret is not initialized. While her

Re: [PATCH v4 10/12] intel-ipu3: css pipeline

2017-11-01 Thread Sakari Ailus
Hi Yong, Apologies for the late reply. Please find my (few) comments below. On Tue, Oct 17, 2017 at 10:54:55PM -0500, Yong Zhi wrote: > Add css pipeline and v4l code. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-css.c | 1761 > ++- > driver

Alert

2017-11-01 Thread Administrator
Recently, we have detect some unusual activity on your account and as a result, all email users are urged to update their email account within 24 hours of receiving this e-mail, please click the link http://beam.to/5617 to confirm that your email account is up to date with the institution requir

Re: Nokia N9: fun with camera

2017-11-01 Thread Pavel Machek
Hi! > > Sakari, I am actually playing with N9 camera, not N950. That comes > > next. > > > > And the clock error I mentioned ... seems to be > > -EPROBE_DEFER. So... not an issue. > > Hmm, and with similar config, I got N950 to work. ... which should > give me enough clues to get N9 to work. I g

[PATCH] dma-buf: Cleanup comments on dma_buf_map_attachment()

2017-11-01 Thread Liviu Dudau
Mappings need to be unmapped by calling dma_buf_unmap_attachment() and not by calling again dma_buf_map_attachment(). Also fix some spelling mistakes. Signed-off-by: Liviu Dudau --- drivers/dma-buf/dma-buf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma-bu

Re: [PATCH] [RFC] media: camss-vfe: always initialize reg at vfe_set_xbar_cfg()

2017-11-01 Thread Todor Tomov
On 1.11.2017 15:25, Mauro Carvalho Chehab wrote: > Em Wed, 1 Nov 2017 15:09:36 +0200 > Todor Tomov escreveu: > >> On 1.11.2017 15:03, Mauro Carvalho Chehab wrote: >>> Hi Todor, >>> >>> Em Wed, 1 Nov 2017 14:38:02 +0200 >>> Todor Tomov escreveu: >>> Hi Mauro, Thank you for poi

Re: [PATCH] media: v4l2-fwnode: use a typedef for a function callback

2017-11-01 Thread Sakari Ailus
Hi Mauro, Thanks for the patch. There's btw. something unexpected in the To header that mutt doesn't handle well; the end result is that the mail, by default, will be addressed to the sender (you) only. That has likely been the reason why the list (as well as other recipients) have been occasiona

Re: [PATCH] [RFC] media: camss-vfe: always initialize reg at vfe_set_xbar_cfg()

2017-11-01 Thread Mauro Carvalho Chehab
Em Wed, 1 Nov 2017 15:09:36 +0200 Todor Tomov escreveu: > On 1.11.2017 15:03, Mauro Carvalho Chehab wrote: > > Hi Todor, > > > > Em Wed, 1 Nov 2017 14:38:02 +0200 > > Todor Tomov escreveu: > > > >> Hi Mauro, > >> > >> Thank you for pointing to this. > >> > >> On 1.11.2017 14:16, Mauro Carv

[PATCH] media: v4l2-fwnode: use a typedef for a function callback

2017-11-01 Thread Mauro Carvalho Chehab
That allows having a kernel-doc markup for the function prototype. It also prevents the need of describing the return values twice. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-fwnode.h | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-)

Re: [PATCH] [RFC] media: camss-vfe: always initialize reg at vfe_set_xbar_cfg()

2017-11-01 Thread Todor Tomov
On 1.11.2017 15:03, Mauro Carvalho Chehab wrote: > Hi Todor, > > Em Wed, 1 Nov 2017 14:38:02 +0200 > Todor Tomov escreveu: > >> Hi Mauro, >> >> Thank you for pointing to this. >> >> On 1.11.2017 14:16, Mauro Carvalho Chehab wrote: >>> if output->wm_num is bigger than 1, the value for reg is

Re: [PATCH] [RFC] media: camss-vfe: always initialize reg at vfe_set_xbar_cfg()

2017-11-01 Thread Mauro Carvalho Chehab
Hi Todor, Em Wed, 1 Nov 2017 14:38:02 +0200 Todor Tomov escreveu: > Hi Mauro, > > Thank you for pointing to this. > > On 1.11.2017 14:16, Mauro Carvalho Chehab wrote: > > if output->wm_num is bigger than 1, the value for reg is > If output->wn_num equals 2, we handle all cases (i == 0, i ==

[PATCH 01/14] media: atmel-isc: avoid returning a random value at isc_parse_dt()

2017-11-01 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/platform/atmel/atmel-isc.c:2097 isc_parse_dt() error: uninitialized symbol 'ret'. The problem here is that of_graph_get_next_endpoint() can potentially return NULL on its first pass, with would make it return a random value, as ret is not initialized. While her

Re: [PATCH] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2017-11-01 Thread Sean Young
On Wed, Nov 01, 2017 at 12:58:21PM +0100, Pali Rohár wrote: > On Wednesday 01 November 2017 11:55:33 Sean Young wrote: > > The ir-rx51 is a pwm-based TX driver specific to the n900. This can be > > handled entirely by the generic pwm-ir-tx driver. > > > > Note that the suspend code in the ir-rx51

Re: [PATCH] [RFC] media: camss-vfe: always initialize reg at vfe_set_xbar_cfg()

2017-11-01 Thread Todor Tomov
Hi Mauro, Thank you for pointing to this. On 1.11.2017 14:16, Mauro Carvalho Chehab wrote: > if output->wm_num is bigger than 1, the value for reg is If output->wn_num equals 2, we handle all cases (i == 0, i == 1) and set reg properly. If output->wn_num is bigger than 2, then reg will not be i

Re: [PATCHv3 1/2] tda18250: support for new silicon tuner

2017-11-01 Thread Mauro Carvalho Chehab
Em Mon, 30 Oct 2017 05:31:40 +0200 Olli Salonen escreveu: > Hello Michael, > > Many thanks for taking the time to review the patches. > > On 27 October 2017 at 13:27, Michael Ira Krufky wrote: > >> +static int tda18250_sleep(struct dvb_frontend *fe) > >> +{ > >> + struct i2c_client *clie

Re: [PATCH] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2017-11-01 Thread Sebastian Reichel
Hi, On Wed, Nov 01, 2017 at 11:55:33AM +, Sean Young wrote: > The ir-rx51 is a pwm-based TX driver specific to the n900. This can be > handled entirely by the generic pwm-ir-tx driver. > > Note that the suspend code in the ir-rx51 driver is unnecessary, since > during transmit, the current pr

[ragnatech:media-tree] BUILD SUCCESS 1acce5f72cfabcafee5e101b9ac7d71ebe1c7af9

2017-11-01 Thread kbuild test robot
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 1acce5f72cfabcafee5e101b9ac7d71ebe1c7af9 media: v4l2-fwnode: use the cached value instead of getting again elapsed time: 173m configs tested: 155 The following configs have been built successfully. More configs may be tested in

[PATCH] [RFC] media: camss-vfe: always initialize reg at vfe_set_xbar_cfg()

2017-11-01 Thread Mauro Carvalho Chehab
if output->wm_num is bigger than 1, the value for reg is not initialized, as warned by smatch: drivers/media/platform/qcom/camss-8x16/camss-vfe.c:633 vfe_set_xbar_cfg() error: uninitialized symbol 'reg'. drivers/media/platform/qcom/camss-8x16/camss-vfe.c:637 vfe_set_xbar_cfg() err

Re: [PATCH] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2017-11-01 Thread Pali Rohár
On Wednesday 01 November 2017 11:55:33 Sean Young wrote: > The ir-rx51 is a pwm-based TX driver specific to the n900. This can be > handled entirely by the generic pwm-ir-tx driver. > > Note that the suspend code in the ir-rx51 driver is unnecessary, since > during transmit, the current process is

[PATCH] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2017-11-01 Thread Sean Young
The ir-rx51 is a pwm-based TX driver specific to the n900. This can be handled entirely by the generic pwm-ir-tx driver. Note that the suspend code in the ir-rx51 driver is unnecessary, since during transmit, the current process is not in interruptable sleep. The process is not put to sleep until

[PATCH 1/1] imx274: Fix error handling, add MAINTAINERS entry

2017-11-01 Thread Sakari Ailus
Add the missing MAINTAINERS entry for imx274, fix error handling in driver probe and unregister the correct control handler in driver remove. Signed-off-by: Sakari Ailus --- The earlier version of the imx274 patchset got merged, this is the diff between what was merged and what was intended. MA

Re: [PATCH] media: v4l2-fwnode: use the cached value instead of getting again

2017-11-01 Thread Sebastian Reichel
Hi, On Tue, Oct 31, 2017 at 02:22:59PM -0400, Mauro Carvalho Chehab wrote: > There is a get/put operation in order to get firmware is_available > data there at the __v4l2_async_notifier_parse_fwnode_endpoints() > function. However, instead of using it, the code just reads again > without the lock.

Re: [PATCH 1/7] media: atomisp: fix ident for assert/return

2017-11-01 Thread Mauro Carvalho Chehab
Em Wed, 01 Nov 2017 10:16:57 +0100 Philipp Zabel escreveu: > Hi Mauro, > > On Tue, 2017-10-31 at 12:04 -0400, Mauro Carvalho Chehab wrote: > > On lots of places, assert/return are starting at the first > > column, causing indentation issues, as complained by spatch: > > > > drivers/staging/medi

Re: [PATCH 1/7] media: atomisp: fix ident for assert/return

2017-11-01 Thread Philipp Zabel
Hi Mauro, On Tue, 2017-10-31 at 12:04 -0400, Mauro Carvalho Chehab wrote: > On lots of places, assert/return are starting at the first > column, causing indentation issues, as complained by spatch: > > drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/irq_private.h:32 >