Re: [PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe

Hi Sakari, Sorry for late answer, because I was in vacation last week. On 2017/9/29 5:25, Sakari Ailus wrote: Hi Wenyou, On Thu, Sep 28, 2017 at 04:18:26PM +0800, Wenyou Yang wrote: To meet the relationship, enable the HCLOCK and ispck during the device probe, "isc_pck frequency is less than

[RESEND PATCH] media: uvcvideo: Fix memory leak of uvc resources

The refcount would be inited to 1 in kref_init(), so we don't need to increase it at the end of uvc_register_video(). Fixes: 9d15cd958c17 ("media: uvcvideo: Convert from using an atomic variable to a reference count") Signed-off-by: Jeffy Chen --- drivers/media/usb/uvc/uvc_driver.c | 1 - 1 fi

[PATCH] media: uvcvideo: Fix memory leak of uvc resources

The refcount would be inited to 1 in kref_init(), so we don't need to increase it at the end of uvc_probe(). Fixes: 9d15cd958c17 ("media: uvcvideo: Convert from using an atomic variable to a reference count") Signed-off-by: Jeffy Chen --- drivers/media/usb/uvc/uvc_driver.c | 1 - 1 file change

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Oct 9 05:00:05 CEST 2017 media-tree git hash:c1301077213d4dca34f01fc372b64d3c4a49a437 media_build gi

Re: [PATCH v8 1/3] media: dt: bindings: Add binding for tango HW IR decoder

On Fri, Oct 6, 2017 at 7:23 AM, Marc Gonzalez wrote: > Add DT binding for the HW IR decoder embedded in SMP86xx/SMP87xx. > > Signed-off-by: Marc Gonzalez > --- > .../devicetree/bindings/media/tango-ir.txt | 21 > + > 1 file changed, 21 insertions(+) > create mode 1

Re: [PATCH v15 07/32] v4l: async: Add V4L2 async documentation to the documentation build

Hi, On Thu, Oct 05, 2017 at 12:50:26AM +0300, Sakari Ailus wrote: > The V4L2 async wasn't part of the documentation build. Fix this. > > Signed-off-by: Sakari Ailus > Reviewed-by: Niklas Söderlund > Acked-by: Hans Verkuil > Reviewed-by: Laurent Pinchart Reviewed-by: Sebastian Reichel -- Se

Re: [PATCH v15 06/32] v4l: async: Use more intuitive names for internal functions

Hi, On Thu, Oct 05, 2017 at 12:50:25AM +0300, Sakari Ailus wrote: > Rename internal functions to make the names of the functions better > describe what they do. > > Old nameNew name > v4l2_async_test_notify v4l2_async_match_notify > v4l2_async_belongs

Re: [PATCH v15 05/32] v4l: async: Correctly serialise async sub-device unregistration

Hi, On Thu, Oct 05, 2017 at 12:50:24AM +0300, Sakari Ailus wrote: > The check whether an async sub-device is bound to a notifier was performed > without list_lock held, making it possible for another process to > unbind the async sub-device before the sub-device unregistration function > proceeds

Re: [PATCH v15 03/32] v4l: async: fix unbind error in v4l2_async_notifier_unregister()

Hi, On Thu, Oct 05, 2017 at 12:50:22AM +0300, Sakari Ailus wrote: > From: Niklas Söderlund > > The call to v4l2_async_cleanup() will set sd->asd to NULL so passing it to > notifier->unbind() have no effect and leaves the notifier confused. Call > the unbind() callback prior to cleaning up the su

Re: [PATCH v15 02/32] v4l: async: Don't set sd->dev NULL in v4l2_async_cleanup

Hi, On Thu, Oct 05, 2017 at 12:50:21AM +0300, Sakari Ailus wrote: > v4l2_async_cleanup() is called when the async sub-device is unbound from > the media device. As the pointer is set by the driver registering the > async sub-device, leave the pointer as set by the driver. > > Signed-off-by: Sakar

Re: [PATCH v15 01/32] v4l: async: Remove re-probing support

Hi, On Thu, Oct 05, 2017 at 12:50:20AM +0300, Sakari Ailus wrote: > Remove V4L2 async re-probing support. The re-probing support has been > there to support cases where the sub-devices require resources provided by > the main driver's hardware to function, such as clocks. > > Reprobing has allowe

Re: [PATCH] v4l2-dv-timings.h: fix polarity for 4k formats

On Mon, 2016-05-02 at 10:11 +0200, Hans Verkuil wrote: > Backport to 3.16-4.0 of mainline commit > 3020ca711871fdaf0c15c8bab677a6bc302e28fe > > The VSync polarity was negative instead of positive for the 4k CEA formats. > I probably copy-and-pasted these from the DMT 4k format, which does have a

[PATCH] media: rc: check for integer overflow

The ioctl LIRC_SET_REC_TIMEOUT would set a timeout of 704ns if called with a timeout of 4294968us. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-li

Re: [PATCH v3 00/17] kernel-doc: add supported to document nested structs/

> Am 07.10.2017 um 18:34 schrieb Jonathan Corbet : > > On Wed, 4 Oct 2017 08:48:38 -0300 > Mauro Carvalho Chehab wrote: > >> Right now, it is not possible to document nested struct and nested unions. >> kernel-doc simply ignore them. >> >> Add support to document them. > > So I've finally fo

[PATCH 2/2] staging: atomisp: cleanup out of memory messages

Logging of explicit out of memory messages is redundant since memory allocation failures produce a backtrace. Done with the help of the following cocci script: @@ expression ex, ret; statement s; constant char[] c; constant err; identifier f, l; @@ ex = \(kmalloc\|kmalloc_array\|kzalloc\|kcalloc

[PATCH 1/2] staging: atomisp2: cleanup null check on memory allocation

For memory allocation functions that fail with a NULL return value, it is preferred to use the (!x) test in place of (x == NULL). Changes in atomisp2/css2400/sh_css.c were done by hand. Done with the help of the following cocci script: @@ type T; T* p; statement s,s1; @@ p = \(devm_kzalloc\|d

[PATCH 0/2] staginng: atomisp: memory allocation cleanups

Patch series performs minor code cleanups using coccinelle to simplify memory allocation tests and remove redundant OOM log messages. Aishwarya Pant (2): staging: atomisp2: cleanup null check on memory allocation staging: atomisp: cleanup out of memory messages drivers/staging/media/atomisp/