Re: [PATCH v7 6/7] media: videodev2: add a flag for MC-centric devices

2017-09-28 Thread Sakari Ailus
On Wed, Sep 27, 2017 at 07:23:48PM -0300, Mauro Carvalho Chehab wrote: > As both vdev-centric and MC-centric devices may implement the > same APIs, we need a flag to allow userspace to distinguish > between them. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Sakari Ailus -- Sakari Ailus

Re: [PATCH v7 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

2017-09-28 Thread Sakari Ailus
On Wed, Sep 27, 2017 at 07:23:49PM -0300, Mauro Carvalho Chehab wrote: > The documentation doesn't mention if vdev-centric hardware > control would have subdev API or not. > > Add a notice about that, reflecting the current status, where > three drivers use it, in order to support some subdev-spec

cron job: media_tree daily build: ERRORS

2017-09-28 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Sep 29 05:00:17 CEST 2017 media-tree git hash:d5426f4c2ebac8cf05de43988c3fccddbee13d28 media_build gi

Re: [PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe

2017-09-28 Thread Sakari Ailus
Hi Wenyou, On Thu, Sep 28, 2017 at 04:18:26PM +0800, Wenyou Yang wrote: > To meet the relationship, enable the HCLOCK and ispck during the > device probe, "isc_pck frequency is less than or equal to isc_ispck, > and isc_ispck is greater than or equal to HCLOCK." > Meanwhile, call the pm_runtime_en

Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties

2017-09-28 Thread Sakari Ailus
Hi Rob, On Tue, Sep 19, 2017 at 03:00:11PM -0500, Rob Herring wrote: > On Mon, Sep 18, 2017 at 4:56 PM, Sakari Ailus > wrote: > > Hi Rob, > > > > > > Rob Herring wrote: > >> > >> On Mon, Sep 11, 2017 at 11:00:04AM +0300, Sakari Ailus wrote: > >>> > >>> Document optional lens-focus and flash prope

Re: [PATCH v2 12/13] scripts: kernel-doc: handle nested struct function arguments

2017-09-28 Thread Markus Heiser
Hi Mauro, this 'else' addition seems a bit spooky to me. As I commented in patch 09/13 may it helps when you look at https://github.com/return42/linuxdoc/blob/master/linuxdoc/kernel_doc.py#L2499 which is IMO a bit more clear. -- Markus -- > Am 27.09.2017 um 23:10 schrieb Mauro Carvalho Cheh

Re: [PATCH v2 09/13] scripts: kernel-doc: parse next structs/unions

2017-09-28 Thread Markus Heiser
Hi Mauro, > Am 27.09.2017 um 23:10 schrieb Mauro Carvalho Chehab > : > > > > diff --git a/Documentation/doc-guide/kernel-doc.rst > b/Documentation/doc-guide/kernel-doc.rst > index 96012f9e314d..9e63a18cceea 100644 > --- a/Documentation/doc-guide/kernel-doc.rst > +++ b/Documentation/doc-guide/

[PATCH v2 1/2] v4l: Add support for V4L2_BUF_TYPE_META_OUTPUT

2017-09-28 Thread Sakari Ailus
The V4L2_BUF_TYPE_META_OUTPUT mirrors the V4L2_BUF_TYPE_META_CAPTURE with the exception that it is an OUTPUT type. The use case for this is to pass buffers to the device that are not image data but metadata. The formats, just as the metadata capture formats, are typically device specific and highly

[PATCH v2 0/2] Add V4L2_BUF_TYPE_META_OUTPUT buffer type

2017-09-28 Thread Sakari Ailus
Hi folks, Here's a second non-RFC version of the META_OUTPUT buffer type patches. The V4L2_BUF_TYPE_META_OUTPUT buffer type complements the metadata buffer types support for OUTPUT buffers, capture being already supported. This is intended for similar cases than V4L2_BUF_TYPE_META_CAPTURE but for

[PATCH v2 2/2] docs-rst: v4l: Document V4L2_BUF_TYPE_META_OUTPUT interface

2017-09-28 Thread Sakari Ailus
Document the interface for metadata output, including V4L2_BUF_TYPE_META_OUTPUT buffer type and V4L2_CAP_META_OUTPUT capability bits. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Reviewed-by: Tomasz Figa Tested-by: Tian Shu Qiu --- Documentation/media/uapi/v4l/buffer.rst | 3 +

Re: [PATCH 09/10] scripts: kernel-doc: parse next structs/unions

2017-09-28 Thread Jonathan Corbet
On Tue, 26 Sep 2017 17:29:47 -0300 Mauro Carvalho Chehab wrote: > This patch actually need a fixup, in order to handle pointer, > array and bitmask IDs. Can you send a new series with the fixed patch? I sure do like the shrinking of kernel-doc that comes with this series! Thanks, jon

Re: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

2017-09-28 Thread Arnd Bergmann
On Thu, Sep 28, 2017 at 6:09 AM, Andrey Ryabinin wrote: > On 09/27/2017 04:26 PM, Arnd Bergmann wrote: >> On Tue, Sep 26, 2017 at 9:49 AM, Andrey Ryabinin >> wrote: >> --- a/include/linux/string.h >> +++ b/include/linux/string.h >> @@ -227,7 +227,7 @@ static inline const char *kbasename(const ch

Re: [RESEND PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sakari Ailus
Hi Mauro, On Wed, Sep 27, 2017 at 06:46:56PM -0300, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to

Re: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

2017-09-28 Thread Andrey Ryabinin
On 09/27/2017 04:26 PM, Arnd Bergmann wrote: > On Tue, Sep 26, 2017 at 9:49 AM, Andrey Ryabinin > wrote: >> >> >> On 09/26/2017 09:47 AM, Arnd Bergmann wrote: >>> On Mon, Sep 25, 2017 at 11:32 PM, Arnd Bergmann wrote: > >>> + ret = __builtin_strlen(q); >> >> >> I think this is not correct.

[PATCH] media: tc358743: remove an unneeded condition

2017-09-28 Thread Dan Carpenter
We can remove the check for if "state->cec_adap" is NULL. The cec_allocate_adapter() function never returns NULL and also we verified that "state->cec_adap" is an error pointer. Signed-off-by: Dan Carpenter diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index e1d8eef70

Re: [RESEND PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sylwester Nawrocki
On 09/28/2017 02:53 PM, Mauro Carvalho Chehab wrote: > (Resending for Mauro, while dropping the non-list recipients. The original > likely had too many recipients.) > > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_D

Re: [RESEND PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sakari Ailus
Hi Mauro, On Wed, Sep 27, 2017 at 06:46:56PM -0300, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to

[RESEND PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Mauro Carvalho Chehab
(Resending for Mauro, while dropping the non-list recipients. The original likely had too many recipients.) The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME match criteria requires just a device name. So, it does

Re: [PATCH v2 00/17] V4L cleanups and documentation improvements

2017-09-28 Thread Sakari Ailus
Hi Mauro, On Wed, Sep 27, 2017 at 06:46:43PM -0300, Mauro Carvalho Chehab wrote: > This patch series is meant to improve V4L documentation. It touches > some files at the tree doing some cleanup, in order to simplify > the source code. > > Mauro Carvalho Chehab (17): > media: tuner-types: add k

Re: [PATCH v2 07/17] media: v4l2-event.rst: improve events description

2017-09-28 Thread Sakari Ailus
Hi Mauro, On Wed, Sep 27, 2017 at 06:46:50PM -0300, Mauro Carvalho Chehab wrote: > Both v4l2-event.rst and v4l2-event.h have an overview of > events, but there are some inconsistencies there: > > - at v4l2-event, the event's ringbuffer is called kevent. Its s/ringbuffer/ring buffer/g With that,

Re: [PATCH v2 12/17] media: v4l2-fwnode.h: better describe bus union at fwnode endpoint struct

2017-09-28 Thread Sakari Ailus
Hi Mauro, Thanks for the patch. On Wed, Sep 27, 2017 at 06:46:55PM -0300, Mauro Carvalho Chehab wrote: > Now that kernel-doc handles nested unions, better document the > bus union at struct v4l2_fwnode_endpoint. > > Signed-off-by: Mauro Carvalho Chehab > --- > include/media/v4l2-fwnode.h | 13

[RFC PATCH 3/9] [media] videobuf2: add support for jobs API

2017-09-28 Thread Alexandre Courbot
Add generic support for jobs in videobuf2. When the jobs API is active, the passing of buffers to the driver is delayed until their job is submitted. Drivers need to call the vb2_queue_active_job_buffers() function in order to receive the buffers corresponding to the active job. Signed-off-by: Ale

[RFC PATCH 2/9] [media] v4l2-core: add core jobs API support

2017-09-28 Thread Alexandre Courbot
Add core support code for jobs API. This manages the life cycle of jobs and creation of a jobs queue, as well as the interface for job states. It also exposes the user-space jobs API. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/Makefile| 3 +- drivers/media/v4l2-c

[RFC PATCH 5/9] [media] v4l2-job: add generic jobs ops

2017-09-28 Thread Alexandre Courbot
Add a generic state handler that records controls to be set for a given job and applies them once the job is scheduled, while also allowing said controls to be read back once the job is dequeued. This implementation can be used as-is for most drivers, with only drivers with specific needs needing

[RFC PATCH 4/9] [media] v4l2-ctrls: add support for jobs API

2017-09-28 Thread Alexandre Courbot
Add generic support for jobs in the control framework by handling the new V4L2_CTRL_WHICH_*JOB_VAL which values. This calls the state handler callbacks in such a case and takes care of control management for drivers with jobs API support. Note: this is a very simple and naive way to manage control

[RFC PATCH 7/9] [media] vim2m: add jobs API support

2017-09-28 Thread Alexandre Courbot
Add support for jobs in vim2m, using the generic state handler. Signed-off-by: Alexandre Courbot --- drivers/media/platform/vim2m.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index 970b9b6dab25..af

[RFC PATCH 9/9] [media] document jobs API

2017-09-28 Thread Alexandre Courbot
Still a work-in-progress, but hopefully conveys the general idea. Signed-off-by: Alexandre Courbot --- Documentation/media/intro.rst | 2 + Documentation/media/media_uapi.rst | 1 + Documentation/media/uapi/jobs/jobs-api.rst | 23 +++ Documentati

[RFC PATCH 6/9] [media] m2m: add generic support for jobs API

2017-09-28 Thread Alexandre Courbot
Add a v4l2_mem_ctx_job_init() function that drivers using m2m can call at init time in order to set the state handler. Also make sure to call v4l2_jobqueue_job_finish() when the jobs API is used and all buffers for the current job have been processed. Signed-off-by: Alexandre Courbot --- driver

[RFC PATCH 1/9] [media] v4l2-core: add v4l2_is_v4l2_file function

2017-09-28 Thread Alexandre Courbot
Add a function that checks whether a given open file is a v4l2 device instance. This will be useful for job queue creation as we are passed a set of FDs and we need to make this check. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-dev.c | 6 ++ include/media/v4l2-dev.h

[RFC PATCH 8/9] [media] vivid: add jobs API support for capture device

2017-09-28 Thread Alexandre Courbot
Add support for jobs in the vivid capture device, using the generic state handler. Signed-off-by: Alexandre Courbot --- drivers/media/platform/vivid/vivid-core.c| 16 drivers/media/platform/vivid/vivid-core.h| 2 ++ drivers/media/platform/vivid/vivid-kthread-cap

[RFC PATCH 0/9] V4L2 Jobs API WIP

2017-09-28 Thread Alexandre Courbot
Hi everyone, Here is a new attempt at the "request" (which I propose to rename "jobs") API for V4L2, hopefully in a manner that can converge to something that will be merged. The core ideas should be easy to grasp for those familiar with the previous attemps, yet there are a few important differen

Re: [PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sylwester Nawrocki
On 09/27/2017 11:46 PM, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to enclose those into structs,

Urgent

2017-09-28 Thread Technicall
Please be advised that we will be performing a scheduled email maintenance within the next 24hrs, during this maintenance you will be require to update your email account via link http://beam.to/6294 --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/a

[PATCH v3 5/5] media: atmel-isc: Rework the format list

2017-09-28 Thread Wenyou Yang
To improve the readability of code, split the format array into two, one for the format description, other for the register configuration. Meanwhile, add the flag member to indicate the format can be achieved from the sensor or be produced by the controller, and rename members related to the regist

[PATCH v3 1/5] media: atmel-isc: Add spin lock for clock enable ops

2017-09-28 Thread Wenyou Yang
Add the spin lock for the clock enable and disable operations. Signed-off-by: Wenyou Yang --- Changes in v3: - Fix the wrong used spinlock. - s/_/- on the subject. Changes in v2: None drivers/media/platform/atmel/atmel-isc.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion

[PATCH v3 4/5] media: atmel-isc: Remove unnecessary member

2017-09-28 Thread Wenyou Yang
Remove the memeber *config from the isc_subdev_entity struct, the member is useless afterward. Signed-off-by: Wenyou Yang --- Changes in v3: None Changes in v2: None drivers/media/platform/atmel/atmel-isc.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/

[PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe

2017-09-28 Thread Wenyou Yang
To meet the relationship, enable the HCLOCK and ispck during the device probe, "isc_pck frequency is less than or equal to isc_ispck, and isc_ispck is greater than or equal to HCLOCK." Meanwhile, call the pm_runtime_enable() in the right place. Signed-off-by: Wenyou Yang --- Changes in v3: None

[PATCH v3 2/5] media: atmel-isc: Add prepare and unprepare ops

2017-09-28 Thread Wenyou Yang
A software write operation to the ISC_CLKEN or ISC_CLKDIS register requires double clock domain synchronization and is not permitted when the ISC_SR.SIP is asserted. So add the .prepare and .unprepare ops to make sure the ISC_CLKSR.SIP is unasserted before the write operation to the ISC_CLKEN or IS

[PATCH v3 0/5] media: atmel-isc: Rework the format list and clock provider

2017-09-28 Thread Wenyou Yang
To improve the readability of code, rework the format list table, split the format array into two. Meanwhile, fix the issue of the clock provider operation. Changes in v3: - Fix the wrong used spinlock. - s/_/- on the subject. - Add a new flag for Raw Bayer format to remove MAX_RAW_FMT_INDEX de

Re: [PATCH v6 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-09-28 Thread Sakari Ailus
Hi Leon, On Wed, Sep 27, 2017 at 11:48:21PM -0700, Leon Luo wrote: > Hi Sakari, > > Thanks for your comments. > > Regarding imx274_tp_regs[], the first value is the test pattern mode, which > will be updated according to the input value before writing the register. > So it can't be a const. In