Hi Rajmohan,
Thanks for the patch. A few comments below.
On Tue, Sep 05, 2017 at 04:44:58PM -0700, Rajmohan Mani wrote:
> From: Chiranjeevi Rapolu
>
> Instead of calculating pixle-rate at two different places, calculate at run
> time at a single place.
>
> Instead of using hardcoded pixels-per
On Wed, Sep 06, 2017 at 08:58:26AM +0800, Yang, Wenyou wrote:
> Hi,
>
>
> On 2017/9/5 4:04, SF Markus Elfring wrote:
> > From: Markus Elfring
> > Date: Mon, 4 Sep 2017 21:44:55 +0200
> >
> > A few update suggestions were taken into account
> > from static source code analysis.
> Thank you for y
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Sep 6 05:00:14 CEST 2017
media-tree git hash:1efdf1776e2253b77413c997bed862410e4b6aaf
media_build gi
Hi,
On 2017/9/5 4:04, SF Markus Elfring wrote:
From: Markus Elfring
Date: Mon, 4 Sep 2017 21:44:55 +0200
A few update suggestions were taken into account
from static source code analysis.
Thank you for your patches.
You can add my Acked-by for the patch series.
Acked-by: Wenyou Yang
Ma
From: Chiranjeevi Rapolu
Instead of calculating pixle-rate at two different places, calculate at run
time at a single place.
Instead of using hardcoded pixels-per-line, extract it from current sensor
mode.
Signed-off-by: Chiranjeevi Rapolu
---
drivers/media/i2c/ov13858.c | 42
Hi Jacek and Arnd,
Thanks for fixing this plus the ack! I chatted with Mauro, and as the
patches are still only in mediatree, we'll apply this there, possibly
with a minor spelling fix to the subject (depdendency -> dependency).
https://git.linuxtv.org/sailus/media_tree.git/commit/?h=as3645a-
Hi, Sakari and Hans,
Sorry for the late response to this header file.
> -Original Message-
> From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com]
> Sent: Wednesday, June 7, 2017 3:23 PM
> To: Hans Verkuil
> Cc: Zhi, Yong ; linux-media@vger.kernel.org; Zheng,
> Jian Xu ; tf...@chromiu
Hi Laurent,
2017-09-04 11:56 GMT+02:00 Laurent Pinchart :
> Hi Pavel,
>
> Thank you for the patch.
>
> On Monday, 4 September 2017 11:14:17 EEST Pavel Rojtberg wrote:
>> From: Pavel Rojtberg
>>
>> attaching two Logitech C615 webcams currently results in
>> VIDIOC_STREAMON: No space left on de
From: Colin Ian King
The error handling paths all end up with retval being non-zero,
so the check for retval being zero is always false and hence
is redundant. Remove it.
Detected by CoverityScan CID#1309479 ("Logically dead code")
Signed-off-by: Colin Ian King
---
drivers/media/pci/cobalt/co
On Mon, Sep 04, 2017 at 05:49:40PM +0200, Pavel Machek wrote:
> On Sun 2017-09-03 20:49:41, Sakari Ailus wrote:
> > In V4L2 the practice is to have the KernelDoc documentation in the header
> > and not in .c source code files. This consequientally makes the V4L2
>
> consequientally: spelling?
>
>
Hi Maxime,
On Mon, Sep 04, 2017 at 03:03:34PM +0200, Maxime Ripard wrote:
> The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up to
> 4 CSI-2 lanes, and can route the frames to up to 4 streams, depending on
> the hardware implementation.
>
> It can operate with an external D-PH
We only want to link sub-devices that were bound to the async notifier the
isp driver registered but there may be other sub-devices in the
v4l2_device as well. Check for the correct async notifier.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isp.c | 2 +-
1 file changed, 1 in
Remove V4L2 async re-probing support. The re-probing support has been
there to support cases where the sub-devices require resources provided by
the main driver's hardware to function, such as clocks.
Reprobing has allowed unbinding and again binding the main driver without
explicilty unbinding th
From: Laurent Pinchart
The async subdev notifier .bound(), .unbind() and .complete() operations
are function pointers stored directly in the v4l2_async_subdev
structure. As the structure isn't immutable, this creates a potential
security risk as the function pointers are mutable.
To fix this, mo
The V4L2 async wasn't part of the documentation build. Fix this.
Signed-off-by: Sakari Ailus
Reviewed-by: Niklas Söderlund
Acked-by: Hans Verkuil
---
Documentation/media/kapi/v4l2-async.rst | 3 +++
Documentation/media/kapi/v4l2-core.rst | 1 +
2 files changed, 4 insertions(+)
create mode 1
Hi folks,
We have a large influx of new, unmerged, drivers that are now parsing
fwnode endpoints and each one of them is doing this a little bit
differently. The needs are still exactly the same for the graph data
structure is device independent. This is still a non-trivial task and the
majority o
The current practice is that drivers iterate over their endpoints and
parse each endpoint separately. This is very similar in a number of
drivers, implement a generic function for the job. Driver specific matters
can be taken into account in the driver specific callback.
Signed-off-by: Sakari Ailu
Instead of using driver implementation, use
v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints
of the device.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isp.c | 115 +++---
drivers/media/platform/omap3isp/isp.h | 5 +-
2
Instead of using driver implementation, use
v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints
of the device.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/rcar-vin/rcar-core.c | 112 +---
drivers/media/platform/rcar-vin/rcar-dma.c | 10
Parse async sub-devices by using
v4l2_subdev_fwnode_reference_parse_sensor_common().
These types devices aren't directly related to the sensor, but are
nevertheless handled by the smiapp driver due to the relationship of these
component to the main part of the camera module --- the sensor.
This d
Add flash and indicator LED phandles to the sensor node.
Signed-off-by: Sakari Ailus
---
arch/arm/boot/dts/omap3-n9.dts | 1 +
arch/arm/boot/dts/omap3-n950-n9.dtsi | 4 ++--
arch/arm/boot/dts/omap3-n950.dts | 1 +
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/
Add three helper functions to call async operations callbacks. Besides
simplifying callbacks, this allows async notifiers to have no ops set,
i.e. it can be left NULL.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-async.c | 49 ++--
include/media/v4
Add v4l2_fwnode_parse_reference_sensor_common for parsing common
sensor properties that refer to adjacent devices such as flash or lens
driver chips.
As this is an association only, there's little a regular driver needs to
know about these devices as such.
Signed-off-by: Sakari Ailus
Acked-by: H
Add function v4l2_fwnode_reference_count() for counting external
references and v4l2_fwnode_reference_parse() for parsing them as async
sub-devices.
This can be done on e.g. flash or lens async sub-devices that are not part
of but are associated with a sensor.
struct v4l2_async_notifier.max_subde
Registering a notifier has required the knowledge of struct v4l2_device
for the reason that sub-devices generally are registered to the
v4l2_device (as well as the media device, also available through
v4l2_device).
This information is not available for sub-device drivers at probe time.
What this
Camera flash drivers (and LEDs) are separate from the sensor devices in
DT. In order to make an association between the two, provide the
association information to the software.
Signed-off-by: Sakari Ailus
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/media/video-interfaces.txt |
Document optional lens-focus and flash properties for the smiapp driver.
Signed-off-by: Sakari Ailus
---
Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/nokia,smia.txt
b/Documentation/de
The lens-focus property contains a phandle to the lens voice coil driver
that is associated to the sensor; typically both are contained in the same
camera module.
Signed-off-by: Sakari Ailus
Acked-by: Pavel Machek
Reviewed-by: Sebastian Reichel
Acked-by: Rob Herring
---
Documentation/devicetr
Qualcomm CAMSS was left out from documentation build. Fix this.
Signed-off-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
Documentation/media/v4l-drivers/index.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/media/v4l-drivers/index.rst
b/Docume
Register the sub-device before calling the notifier's bound callback.
Doing this the other way around is problematic as the struct v4l2_device
has not assigned for the sub-device yet and may be required by the bound
callback.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-async.c |
In V4L2 the practice is to have the KernelDoc documentation in the header
and not in .c source code files. This consequientally makes the V4L2
fwnode function documentation part of the Media documentation build.
Also correct the link related function and argument naming in
documentation.
Signed-o
If no source pads are found in an entity, print the name of the entity.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/omap3isp/isp.c
b/drivers/media/platform/omap3isp/isp.c
ind
Rename internal functions to make the names of the functions better
describe what they do.
Old nameNew name
v4l2_async_test_notify v4l2_async_match_notify
v4l2_async_belongs v4l2_async_find_match
Signed-off-by: Sakari Ailus
---
drivers/media
Those two ioctls were never used within the Kernel. Still, there
used to have compat32 code there (and an if #0 block at the core).
Get rid of them.
Fixes: 286fe1ca3fa1 ("media: dmx.h: get rid of DMX_GET_CAPS")
Fixes: 13adefbe9e56 ("media: dmx.h: get rid of DMX_SET_SOURCE")
Signed-off-by: Mauro C
tree: git://linuxtv.org/media_tree.git fixes
head: 12f92866f13f9ca12e158c07978246ed83d52ed0
commit: 13adefbe9e566c6db91579e4ce17f1e5193d6f2c [2543/2599] media: dmx.h: get
rid of DMX_SET_SOURCE
config: x86_64-randconfig-i0-201736 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
re
From: Colin Ian King
Don't populate the const arrays vfd_packet6 and fp_packet on the
stack, instead make them static. Makes the object code smaller
by over 600 bytes:
Before:
textdata bss dec hex filename
43794 179201024 62738f512 drivers/media/rc/imon.o
After
tree: git://linuxtv.org/mchehab/media-next.git master
head: 12f92866f13f9ca12e158c07978246ed83d52ed0
commit: 286fe1ca3fa1b6fcc7ce8695b7c8d681e6e1c3b7 [2542/2599] media: dmx.h: get
rid of DMX_GET_CAPS
config: x86_64-randconfig-i0-201736 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4
Avoid this warning:
/devel/v4l/docs/Documentation/media/v4l-drivers/qcom_camss.rst::
WARNING: document isn't included in any toctree
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/v4l-drivers/index.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/media
There's a chapter for the legacy APIs. Move the frontend DVBv3
API to it, and update the chapter's introduction accordingly.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/dvb/frontend.rst| 1 -
Documentation/media/uapi/dvb/legacy_dvb_apis.rst | 21 ++-
Adjust dvb ca.h, dmx.h and frontend.h in order to make
checkpatch happier. Now, it only complains about the typedefs,
and those are there just to provide backward userspace
compatibility.
Signed-off-by: Mauro Carvalho Chehab
---
include/uapi/linux/dvb/ca.h | 2 +-
include/uapi/linux/dvb/dm
From: Colin Ian King
Don't populate the array syds on the stack, instead make it static const.
Makes the object code smaller by over 280 bytes:
Before:
textdata bss dec hex filename
81451 12784 704 94939 172db cx25840-core.o
textdata bss dec hex
Hi Hans,
According to my tests, when pressing 'Press and Hold' key, the messages
received are
always the same until the button is released. The second message is received
after
~550 ms and each next message is received every ~100 ms.
Regards,
Maciej
On 27/08/2017 14:40, Hans Verkuil
>
> Also, if you plan to attend, please let me know. It is open for all, but it is
> nice if we know beforehand who we can expect.
>
> So if you have a topic that you want to discuss there, then just reply to this
> post. If possible, please add a rough idea of how much time you think you will
> ne
Hi Mauro,
On Mon, Sep 04, 2017 at 05:41:27PM -0300, Mauro Carvalho Chehab wrote:
> From: Sakari Ailus
>
> There appears to be an issue in using \small in certain cases on Sphinx
> 1.4 and 1.5. Other format documents don't use \small either, remove it
> from here as well.
>
> [mche...@s-opensour
Hi Hans
On Fri, Sep 1, 2017 at 11:46 AM, Hans Verkuil wrote:
>
>
> Also, if you plan to attend, please let me know. It is open for all, but it is
> nice if we know beforehand who we can expect.
>
I plan to attend. I do not have any specific topic right now, but as
the date gets closer I might ad
>
> Ok, looking more at the spec, the driver and your patch, here's what I
> come up with:
>
> 1. UVC defines which standard controls should have which flags. Among
> those flags it specifies, which controls should specify the Autoupdate
> flag. E.g. see the first of them as it appears in my
Hi Hans,
Thanks for the review!
On 09/05/17 09:49, Hans Verkuil wrote:
> On 09/03/2017 07:49 PM, Sakari Ailus wrote:
>> Registering a notifier has required the knowledge of struct v4l2_device
>> for the reason that sub-devices generally are registered to the
>> v4l2_device (as well as the media d
47 matches
Mail list logo
