Re: [RFC 1/2] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

Hi Dave, Am 14.06.2017 um 17:15 schrieb Dave Stevenson: > Document the DT bindings for the CSI2/CCP2 receiver peripheral > (known as Unicam) on BCM283x SoCs. > > Signed-off-by: Dave Stevenson please add the devicetree guys in CC for the binding. > --- > .../devicetree/bindings/media/bcm2835-un

Re: [PATCH 4/8] v4l2-flash: Use led_classdev instead of led_classdev_flash for indicator

Hi Sakari, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.12-rc5 next-20170614] [cannot apply to robh/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

Hi, Hans, Would you have time to review this patch v2? The patch v1 violates v4l2 spec. I have fixed it in v2. Sincerely, Ming Hsiu On Fri, 2017-05-12 at 10:42 +0800, Minghsiu Tsai wrote: > From: Daniel Kurtz > > Experiments show that the: > (1) mtk-mdp uses the _MPLANE form of CAPTURE/OUTPU

[PATCH 11/15] af9013: add configurable TS output pin

On serial TS mode output pin could be selected from D0 or D7. Add configuration option to for it. Rename TS mode config option prefix from AF9013_TS_ to AF9013_TS_MODE_. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 27 ++- drivers/media/dvb-f

[PATCH 03/15] af9013: add i2c client bindings

Add kernel i2c driver bindings. That allows dev_* logging, regmap and more. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 321 ++- drivers/media/dvb-frontends/af9013.h | 84 + 2 files changed, 241 insertions(+), 164 deletions(-

[PATCH 10/15] af9015: enable 2nd TS flow control when dual mode

It needs to be enabled in order to get stream from slave af9013 demod. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9015.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c b/drivers/media/usb/dvb-usb-

[PATCH 07/15] af9013: fix error handling

Use typical (return 0/goto err/return err) error handling everywhere. Add missing error handling where missing. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 86 +--- 1 file changed, 51 insertions(+), 35 deletions(-) diff --git a/drive

[PATCH 13/15] af9015: move 2nd demod power-up wait different location

We need to wait 2nd demod power-up before download firmware. Move that wait to more correct location. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9015.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c b/driver

[PATCH 15/15] af9013: refactor power control

Move power-up and power-down functionality to init/sleep ops and get rid of old function. Fixes and simplifies power-up functionality slightly. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 93 ++-- 1 file changed, 36 insertions(+), 57

[PATCH 02/15] af9013: move config values directly under driver state

It shorten, as typed chars, access to config values as there is one pointer less. Also, when config/platform data is passed to driver there could be some values that are not relevant to store state as such or not needed to store at all. Signed-off-by: Antti Palosaari --- drivers/media/dvb-fronte

[PATCH 14/15] af9013: refactor firmware download routine

Refactor firmware download routine. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 65 +--- 1 file changed, 30 insertions(+), 35 deletions(-) diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/media/dvb-frontends/af9013.c inde

[PATCH 01/15] af9015: use correct 7-bit i2c addresses

Driver was using wrong "8-bit" i2c addresses for demods and tuners. Internal demod i2c address was not set at all. These are needed to be fixed before proper i2c client binding is used. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9015.c | 24 +--- driver

[PATCH 12/15] af9013: remove unneeded register writes

Removed register writes are already chip defaults, are not required, are set later or belong to AF9015 USB interface. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 42 1 file changed, 42 deletions(-) diff --git a/drivers/media/dvb

[PATCH 08/15] af9013: add dvbv5 cnr

Add support for DVBv5 CNR. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/media/dvb-frontends/af9013.c index a6b88ae..68091f2 100644 --- a/drivers/media/dvb-front

[PATCH 05/15] af9013: fix logging

We can simplify logging as we now have a proper i2c client to pass for kernel dev_* logging functions. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 202 +-- 1 file changed, 100 insertions(+), 102 deletions(-) diff --git a/drivers/medi

[PATCH 04/15] af9033: use kernel 64-bit division

Replace own binary division with 64-bit multiply and division. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 34 +++ drivers/media/dvb-frontends/af9013_priv.h | 1 + 2 files changed, 4 insertions(+), 31 deletions(-) diff --git a/driv

[PATCH 06/15] af9013: convert to regmap api

Use regmap for register access. Own low level i2c read and write routines for regmap is still needed because chip uses single command byte in addition to typical i2c register access. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/Kconfig | 1 + drivers/media/dvb-frontends

[PATCH 09/15] af9015: fix and refactor i2c adapter algo logic

* fix write+read when write has more than one byte * remove lock, not needed on that case * remove useless i2c msg send loop, as we support only write, read and write+read as one go and nothing more Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9015.c | 153 ++

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

Hi Sakari, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20170614] [cannot apply to robh/for-next v4.12-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

RE: [PATCH 11/12] intel-ipu3: Add imgu v4l2 driver

Hi, Hans and Sakari, Thanks a lot for the code review, I attached the topology print FYI. Regards, Yong From: Sakari Ailus [sakari.ai...@iki.fi] Sent: Friday, June 09, 2017 2:20 AM To: Hans Verkuil Cc: Zhi, Yong; linux-media@vger.kernel.org; sakari.ai...@

Re: [PATCH v3 1/1] i2c: Add Omnivision OV5670 5M sensor support

Hi Chiranjeevi, I presume the register lists in the driver assume a particular external clock frequency? That was the case for the ov13848 driver, too. Could you check as well that the "clock-frequency" property has the desired value, as the latest ov13848 driver does? A few comments below... On

Re: [PATCH 6/8] leds: as3645a: Add LED flash class driver

Ahoy! On Thu, Jun 15, 2017 at 12:28:33AM +0200, Pavel Machek wrote: > Hi! > > > Thanks for the review! > > You are welcome :-). > > > On Wed, Jun 14, 2017 at 11:39:41PM +0200, Pavel Machek wrote: > > > Hi! > > > > > > > From: Sakari Ailus > > > > > > That address no longer works, right? > >

Re: [PATCH v3 1/3] videodev2.h, v4l2-ioctl: add IPU3 raw10 color format

On Wed, Jun 14, 2017 at 02:48:40PM +0100, Alan Cox wrote: > On Tue, 13 Jun 2017 15:17:14 -0500 > Yong Zhi wrote: > > > Add IPU3 specific formats: > > > > V4L2_PIX_FMT_IPU3_SBGGR10 > > V4L2_PIX_FMT_IPU3_SGBRG10 > > V4L2_PIX_FMT_IPU3_SGRBG10 > > V4L2_PIX_FMT_IPU3_SRGGB10 > > As I

Re: [PATCH 6/8] leds: as3645a: Add LED flash class driver

Hi! > Thanks for the review! You are welcome :-). > On Wed, Jun 14, 2017 at 11:39:41PM +0200, Pavel Machek wrote: > > Hi! > > > > > From: Sakari Ailus > > > > That address no longer works, right? > > Why wouldn't it work? Or... do you know something I don't? :-) Aha. I thought I was removin

Re: [PATCH 00/12] Intel IPU3 ImgU patchset

Hi Alan, On Mon, Jun 05, 2017 at 09:46:59PM +0100, Alan Cox wrote: > > data structures used by the firmware and the hardware. On top of that, > > the algorithms require highly specialized user space to make meaningful > > use of them. For these reasons it has been chosen video buffers to pass > >

Re: [PATCH 6/8] leds: as3645a: Add LED flash class driver

Hi Pavel, Thanks for the review! On Wed, Jun 14, 2017 at 11:39:41PM +0200, Pavel Machek wrote: > Hi! > > > From: Sakari Ailus > > That address no longer works, right? Why wouldn't it work? Or... do you know something I don't? :-) > > > Add a LED flash class driver for the as3654a flash cont

[PATCH v2 09/12] intel-ipu3: css hardware setup

Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/ipu3-css.c | 515 drivers/media/pci/intel/ipu3/ipu3-css.h | 5 + 2 files changed, 520 insertions(+) create mode 100644 drivers/media/pci/intel/ipu3/ipu3-css.c diff --git a/drivers/media/pci/intel/ipu3/ip

[PATCH v2 08/12] intel-ipu3: params: compute and program ccs

A collection of routines that are mainly responsible to calculate the acc parameters. Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/ipu3-css-params.c | 3119 drivers/media/pci/intel/ipu3/ipu3-css-params.h | 105 + drivers/media/pci/intel/ipu3/ipu3-css.h

[PATCH v2 06/12] intel-ipu3: css: imgu dma buff pool

The pools are used to store previous parameters set by user with the parameter queue. Due to pipelining, there needs to be multiple sets (up to four) of parameters which are queued in a host-to-sp queue. Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/ipu3-css-pool.c | 129 +

[PATCH v2 12/12] intel-ipu3: imgu top level pci device

Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/Kconfig | 15 + drivers/media/pci/intel/ipu3/Makefile | 6 + drivers/media/pci/intel/ipu3/ipu3.c | 740 ++ drivers/media/pci/intel/ipu3/ipu3.h | 183 + 4 files changed, 944 insertions(+) crea

[PATCH v2 10/12] intel-ipu3: css pipeline

Add css pipeline and v4l code Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/ipu3-css.c | 1764 ++- drivers/media/pci/intel/ipu3/ipu3-css.h | 84 ++ 2 files changed, 1842 insertions(+), 6 deletions(-) diff --git a/drivers/media/pci/intel/ipu3/ipu3-css.c

[PATCH v2 07/12] intel-ipu3: css: firmware management

Functions to load and install imgu FW blobs Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/ipu3-abi.h| 1573 drivers/media/pci/intel/ipu3/ipu3-css-fw.c | 272 + drivers/media/pci/intel/ipu3/ipu3-css-fw.h | 219 drivers/media/pci/intel/ipu3/ip

[PATCH v2 11/12] intel-ipu3: Add imgu v4l2 driver

ipu3 imgu video device based on v4l2, vb2 and media controller framework. Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/ipu3-v4l2.c | 727 +++ 1 file changed, 727 insertions(+) create mode 100644 drivers/media/pci/intel/ipu3/ipu3-v4l2.c diff --git a/drive

[PATCH v2 03/12] intel-ipu3: Add DMA API implementation

IPU3 mmu based DMA mapping driver Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/Kconfig | 6 + drivers/media/pci/intel/ipu3/Makefile | 1 + drivers/media/pci/intel/ipu3/ipu3-dmamap.c | 366 + drivers/media/pci/intel/ipu3/ipu3-dmamap.h | 20 +

[PATCH v2 04/12] intel-ipu3: Add user space ABI definitions

Signed-off-by: Yong Zhi --- include/uapi/linux/intel-ipu3.h | 2182 +++ 1 file changed, 2182 insertions(+) create mode 100644 include/uapi/linux/intel-ipu3.h diff --git a/include/uapi/linux/intel-ipu3.h b/include/uapi/linux/intel-ipu3.h new file mode 100644 i

[PATCH v2 02/12] intel-ipu3: mmu: implement driver

From: Tuukka Toivonen This driver translates Intel IPU3 internal virtual address to physical address. Signed-off-by: Tuukka Toivonen Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/Kconfig| 11 + drivers/media/pci/intel/ipu3/Makefile | 1 + drivers/media/pci/intel/ipu3/ipu3-

[PATCH v2 00/12] Intel IPU3 ImgU patchset

This patchset adds support for the Intel IPU3 (Image Processing Unit) ImgU which is essentially a modern memory-to-memory ISP. It implements raw Bayer to YUV image format conversion as well as a large number of other pixel processing algorithms for improving the image quality. Meta data formats ar

[PATCH v2 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format

Add the IPU3 specific processing parameter format V4L2_META_FMT_IPU3_PARAMS and metadata formats for 3A and other statistics: V4L2_META_FMT_IPU3_PARAMS V4L2_META_FMT_IPU3_STAT_3A V4L2_META_FMT_IPU3_STAT_DVS V4L2_META_FMT_IPU3_STAT_LACE Signed-off-by: Yong Zhi --- drivers/media/v4l2-core

Re: [PATCH 6/8] leds: as3645a: Add LED flash class driver

Hi Jacek, Thanks for the review! I have to say I found the v4l2-flash-led-class framework quite useful, now that I refactored a driver for using it. Now we have a user for the indicator, too. :-) On Wed, Jun 14, 2017 at 11:15:24PM +0200, Jacek Anaszewski wrote: > > +static __maybe_unused int as3

RE: [PATCH 07/12] intel-ipu3: css: firmware management

> -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Hans Verkuil > Sent: Tuesday, June 6, 2017 1:39 AM > To: Zhi, Yong ; linux-media@vger.kernel.org; > sakari.ai...@linux.intel.com > Cc: Zheng, Jian Xu ; tf...@chromium.or

Re: [PATCH 6/8] leds: as3645a: Add LED flash class driver

Hi! > From: Sakari Ailus That address no longer works, right? > Add a LED flash class driver for the as3654a flash controller. A V4L2 flash > driver for it already exists (drivers/media/i2c/as3645a.c), and this driver > is based on that. > > Signed-off-by: Sakari Ailus > + * Based on drivers

[PATCH v2 07/11] r820t: mark register functions as noinline_if_stackbloat

With KASAN, we get an overly long stack frame due to inlining the register access function: drivers/media/tuners/r820t.c: In function 'generic_set_freq.isra.7': drivers/media/tuners/r820t.c:1334:1: error: the frame size of 2880 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] An earl

[PATCH v2 06/11] dvb-frontends: reduce stack size in i2c access

A typical code fragment was copied across many dvb-frontend drivers and causes large stack frames when built with -fsanitize-address-use-after-scope, e.g. drivers/media/dvb-frontends/cxd2841er.c:3225:1: error: the frame size of 3992 bytes is larger than 3072 bytes [-Werror=frame-larger-than=] dri

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

Hi Jacek, On Wed, Jun 14, 2017 at 11:14:13PM +0200, Jacek Anaszewski wrote: > Hi Sakari, > > On 06/14/2017 11:47 AM, Sakari Ailus wrote: > > None of the flash operations are not mandatory and therefore there should > > be no need for the flash ops structure either. Accept NULL. > > > > Signed-of

Re: [PATCH 6/8] leds: as3645a: Add LED flash class driver

Hi Sakari, I have two remarks in the code below. On 06/14/2017 11:47 AM, Sakari Ailus wrote: > From: Sakari Ailus > > Add a LED flash class driver for the as3654a flash controller. A V4L2 flash > driver for it already exists (drivers/media/i2c/as3645a.c), and this driver > is based on that. >

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

Hi Sakari, On 06/14/2017 11:47 AM, Sakari Ailus wrote: > None of the flash operations are not mandatory and therefore there should > be no need for the flash ops structure either. Accept NULL. > > Signed-off-by: Sakari Ailus > --- > drivers/media/v4l2-core/v4l2-flash-led-class.c | 4 ++-- > 1 f

Re: [PATCH 4/8] v4l2-flash: Use led_classdev instead of led_classdev_flash for indicator

Hi Sakari, On 06/14/2017 11:47 AM, Sakari Ailus wrote: > The V4L2 flash class initialisation expects struct led_classdev_flash that > describes an indicator but only uses struct led_classdev which is a field > iled_cdev in the struct. Use struct iled_cdev only. > > Signed-off-by: Sakari Ailus >

Re: [RFC 0/2] BCM283x Camera Receiver driver

On 14 June 2017 at 18:38, Hans Verkuil wrote: > On 06/14/2017 06:29 PM, Dave Stevenson wrote: >> >> Hi Hans. >> >> On 14 June 2017 at 16:42, Hans Verkuil wrote: >>> >>> Hi Dave, >>> >>> How does this driver relate to this staging driver: >>> >>> drivers/staging/vc04_services/bcm2835-camera/ >>> >

Re: [patch, libv4l]: add sdlcam example for testing digital still camera functionality

Hi! > > Utilities like v4l2-ctl are tied closely to the kernel and are updated > > whenever > > new APIs appear. But yet another viewer? > > > > Mauro, I find that v4l-utils is a bit polluted with non-core utilities. > > IMHO it should only contain the core libv4l2, core utilities and > > drive

[PATCH v5 1/2] media: i2c: adv748x: add adv748x driver

From: Kieran Bingham Provide support for the ADV7481 and ADV7482. The driver is modelled with 4 subdevices to allow simultaneous streaming from the AFE (Analog front end) and HDMI inputs though two CSI TX entities. The HDMI entity is linked to the TXA CSI bus, whilst the AFE is linked to the TX

Re: v4l2-fwnode: status, plans for merge, any branch to merge against?

Hi! > > > > Are there any news about the fwnode branch? > > > > > > > > I have quite usable camera, but it is still based on > > > > 982e8e40390d26430ef106fede41594139a4111c (that's v4.10). It would be > > > > good to see fwnode stuff upstream... are there any plans for that? > > > > > > > > Is

RE: [PATCH] ov5670: Add Omnivision OV5670 5M sensor support

Sakari, Thanks for the review. Version 3 uploaded. See the responses below. Got some syntax suggestions from automated scripts on v3, will submit v4 soon. Thanks, Chiran. -Original Message- >From: Sakari Ailus [mailto:sakari.ai...@iki.fi] >Sent: Friday, May 26, 2017 1:29 AM >To: Rapolu

Re: [PATCH] uvcvideo: Hardcoded CTRL_QUERY GET_LEN for a lying device

On 06/04/2017 03:41 PM, Alexandre Macabies wrote: > Hello, I forgot to Cc: the full list of maintainers for this patch. This follow-up includes them. Sorry for the noise! My original email & patch is quoted below. Best, Alexandre > This thread comes after two others[1][2] about a similar issue.

Re: [RFC 0/2] BCM283x Camera Receiver driver

On 06/14/2017 06:29 PM, Dave Stevenson wrote: Hi Hans. On 14 June 2017 at 16:42, Hans Verkuil wrote: Hi Dave, How does this driver relate to this staging driver: drivers/staging/vc04_services/bcm2835-camera/ It's not obvious to me. drivers/staging/vc04_services/bcm2835-camera/ is using th

Re: [RFC 0/2] BCM283x Camera Receiver driver

Hi Hans. On 14 June 2017 at 16:42, Hans Verkuil wrote: > Hi Dave, > > How does this driver relate to this staging driver: > > drivers/staging/vc04_services/bcm2835-camera/ > > It's not obvious to me. drivers/staging/vc04_services/bcm2835-camera/ is using the VideoCore firmware to control Unicam,

Re: [RFC 0/2] BCM283x Camera Receiver driver

Hi Dave, How does this driver relate to this staging driver: drivers/staging/vc04_services/bcm2835-camera/ It's not obvious to me. On 06/14/2017 05:15 PM, Dave Stevenson wrote: Hi All. This is adding a V4L2 subdevice driver for the CSI2/CCP2 camera receiver peripheral on BCM283x, as used on

[RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

Add driver for the Unicam camera receiver block on BCM283x processors. Signed-off-by: Dave Stevenson --- drivers/media/platform/Kconfig |1 + drivers/media/platform/Makefile |2 + drivers/media/platform/bcm2835/Kconfig | 14 + drivers/media/

RE: [PATCH v3 1/3] videodev2.h, v4l2-ioctl: add IPU3 raw10 color format

> -Original Message- > From: Alan Cox [mailto:gno...@lxorguk.ukuu.org.uk] > Sent: Wednesday, June 14, 2017 6:49 AM > To: Zhi, Yong > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; Zheng, Jian > Xu ; tf...@chromium.org; Mani, Rajmohan > ; Toivonen, Tuukka > ; Yang, Hyungwo

Re: [PATCH 2/8] dt: bindings: Add lens-focus binding for image sensors

On Wed, Jun 14, 2017 at 12:47:13PM +0300, Sakari Ailus wrote: > The lens-focus property contains a phandle to the lens voice coil driver > that is associated to the sensor; typically both are contained in the same > camera module. > > Signed-off-by: Sakari Ailus > Acked-by: Pavel Machek > Review

Re: [PATCH 1/8] dt: bindings: Add a binding for flash devices associated to a sensor

On Wed, Jun 14, 2017 at 12:47:12PM +0300, Sakari Ailus wrote: > Camera flash drivers (and LEDs) are separate from the sensor devices in > DT. In order to make an association between the two, provide the > association information to the software. > > Signed-off-by: Sakari Ailus > --- > Documentat

[RFC 0/2] BCM283x Camera Receiver driver

Hi All. This is adding a V4L2 subdevice driver for the CSI2/CCP2 camera receiver peripheral on BCM283x, as used on Raspberry Pi. v4l2-compliance results depend on the sensor subdevice this is connected to. It passes the basic tests cleanly with TC358743, but objects with OV5647 fail: v4l2-test-co

[RFC 1/2] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

Document the DT bindings for the CSI2/CCP2 receiver peripheral (known as Unicam) on BCM283x SoCs. Signed-off-by: Dave Stevenson --- .../devicetree/bindings/media/bcm2835-unicam.txt | 76 ++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devicetree/bindin

Re: [PATCH v3 1/3] videodev2.h, v4l2-ioctl: add IPU3 raw10 color format

On Tue, 13 Jun 2017 15:17:14 -0500 Yong Zhi wrote: > Add IPU3 specific formats: > > V4L2_PIX_FMT_IPU3_SBGGR10 > V4L2_PIX_FMT_IPU3_SGBRG10 > V4L2_PIX_FMT_IPU3_SGRBG10 > V4L2_PIX_FMT_IPU3_SRGGB10 As I said before these are just more bitpacked bayer formats with no reason t

[PATCH] i2c: fix platform_no_drv_owner.cocci warnings

drivers/media/i2c/ov5670.c:2577:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Chiranjeevi Rapolu Signed-off-by: Fengguang Wu --- ov5670.c |1 -

[PATCH] i2c: fix semicolon.cocci warnings

drivers/media/i2c/ov5670.c:2001:2-3: Unneeded semicolon drivers/media/i2c/ov5670.c:2033:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Chiranjeevi Rapolu Signed-off-by: Fengguang Wu --- ov5670.c |4 ++-- 1 file changed, 2 in

Re: [PATCH v3 1/1] i2c: Add Omnivision OV5670 5M sensor support

Hi Chiranjeevi, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.12-rc5 next-20170614] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/chiranjeevi-rapolu-intel

Re: [PATCH] dvb-usb-af9035: load HID table

- Original Message - > Hello > > Jaroslav Škarvada kirjoitti 2017-06-09 20:46: > > Automatically load sniffed HID table from Windows driver if > > USB_VID_ITETECH:USB_PID_ITETECH_IT9135_9006 device is present (e.g. > > Evolveo > > Mars) or if module parameter force_hid_tab_load is set. >

Re: [PATCH v10 00/18] Qualcomm video decoder/encoder driver

Hi Mauro, One note, I have sent pull request for the firmware but forgot to update the firmware path in the driver for the new location. It is not a big deal, but I have to send one more patch which changes the firmware path. About COMPILE_TEST, the patch for qcom_scm driver probably will be take

Re: [PATCH 1/9] [media] s5p-jpeg: Reset the Codec before doing a soft reset

Hi, W dniu 13.06.2017 o 20:46, Jacek Anaszewski pisze: Hi Thierry, On 06/07/2017 02:34 PM, Thierry Escande wrote: Hi Jacek, On 02/06/2017 21:50, Jacek Anaszewski wrote: Hi Thierry, On 06/02/2017 06:02 PM, Thierry Escande wrote: From: Abhilash Kesavan This patch resets the encoding and de

Re: [PATCH v4 2/2] arm64: dts: renesas: salvator-x: Add ADV7482 support

Hi Kieran, On Wed, Jun 14, 2017 at 11:43 AM, Kieran Bingham wrote: > On 14/06/17 10:39, Geert Uytterhoeven wrote: >> On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham wrote: >>> From: Kieran Bingham >>> >>> Provide ADV7482, and the needed connectors >>> >>> Signed-off-by: Kieran Bingham >> >> Th

Re: [patch, libv4l]: add sdlcam example for testing digital still camera functionality

Hi Hans, Pavel, Mauro, others, On Mon, May 29, 2017 at 10:02:26AM +0200, Hans Verkuil wrote: > On 05/29/2017 09:32 AM, Pavel Machek wrote: > >On Mon 2017-05-29 08:13:22, Hans Verkuil wrote: > >>Hi Pavel, > >> > >>On 05/21/2017 12:33 PM, Pavel Machek wrote: > >>>Add simple SDL-based application for

Re: v4l2-fwnode: status, plans for merge, any branch to merge against?

Hi, Pavel! On Tue, Jun 13, 2017 at 11:09:00PM +0200, Pavel Machek wrote: > Hi! > > > > Are there any news about the fwnode branch? > > > > > > I have quite usable camera, but it is still based on > > > 982e8e40390d26430ef106fede41594139a4111c (that's v4.10). It would be > > > good to see fwnode

Re: [PATCH v1] [media] as3645a: Join string literals back

On Sun, Jun 04, 2017 at 09:29:18PM +0300, Andy Shevchenko wrote: > There is no need to split long string literals. > Join them back. > > No functional change intended. > > Signed-off-by: Andy Shevchenko Thanks, applied! -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.

Re: [PATCH RESEND v11 1/1] [media] i2c: add support for OV13858 sensor

On Wed, Jun 14, 2017 at 01:12:49PM +0300, Sakari Ailus wrote: > Hi Hyungwoo, > > On Tue, Jun 13, 2017 at 03:06:16PM -0700, Hyungwoo Yang wrote: > > This patch adds driver for Omnivision's ov13858 > > sensor, the driver supports following features: > > > > - manual exposure/gain(analog and digital

Re: [PATCH v8] dw9714: Initial driver for dw9714 VCM

On Sat, Jun 03, 2017 at 11:40:32AM +0300, Sakari Ailus wrote: > Hi Rajmohan, > > On Sat, Jun 03, 2017 at 01:11:40AM -0700, Rajmohan Mani wrote: > > DW9714 is a 10 bit DAC, designed for linear > > control of voice coil motor. > > > > This driver creates a V4L2 subdevice and > > provides control to

Re: [PATCH v2 2/2] v4l: controls: Improve documentation for V4L2_CID_GAIN

On 06/09/17 15:21, Sakari Ailus wrote: > Elaborate the differences between V4L2_CID_GAIN and gain-type specific > V4L2_CID_DIGITAL_GAIN and V4L2_CID_ANALOGUE_GAIN. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Regards, Hans > --- > Documentation/media/uapi/v4l/control.rst

Re: [PATCH v2 1/2] v4l: ctrls: Add a control for digital gain

On 06/09/17 15:21, Sakari Ailus wrote: > Add V4L2_CID_DIGITAL_GAIN to control explicitly digital gain. > > We already have analogue gain control which the digital gain control > complements. Typically higher quality images are obtained using analogue > gain only as the digital gain does not add in

Re: [PATCH v7 1/2] media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver documentation

Hi Niklas, On Tue, Jun 13, 2017 at 06:50:14PM +0200, Niklas Söderlund wrote: > Hi Sakari, > > Thanks for your feedback. > > On 2017-05-29 14:16:25 +0300, Sakari Ailus wrote: > > Hi Niklas, > > > > On Wed, May 24, 2017 at 02:13:52AM +0200, Niklas Söderlund wrote: > > > From: Niklas Söderlund >

Re: [PATCH RESEND v11 1/1] [media] i2c: add support for OV13858 sensor

Hi Hyungwoo, On Tue, Jun 13, 2017 at 03:06:16PM -0700, Hyungwoo Yang wrote: > This patch adds driver for Omnivision's ov13858 > sensor, the driver supports following features: > > - manual exposure/gain(analog and digital) control support > - two link frequencies > - VBLANK/HBLANK support > - tes

Re: [PATCH v3 2/2] media: entity: Add media_entity_get_fwnode_pad() function

Hi Niklas, Thanks for the update! On Tue, Jun 13, 2017 at 04:31:26PM +0200, Niklas Söderlund wrote: > This is a wrapper around the media entity get_fwnode_pad operation. > > Signed-off-by: Niklas Söderlund > --- > drivers/media/media-entity.c | 35 +++ > include

Re: [PATCH v3 1/2] media: entity: Add get_fwnode_pad entity operation

On Tue, Jun 13, 2017 at 04:31:25PM +0200, Niklas Söderlund wrote: > The optional operation can be used by entities to report how it maps its > fwnode endpoints to media pad numbers. This is useful for devices which > require advanced mappings of pads. > > Signed-off-by: Niklas Söderlund Thanks!

Re: [PATCH 0/8] Support registering lens, flash and EEPROM devices

On Wed, Jun 14, 2017 at 12:47:11PM +0300, Sakari Ailus wrote: > Hi folks, > > This set adds support for async registering of lens, flash and EEPROM > devices, as well as support for this in the smiapp driver and a LED driver > for the as3645a. > > The lens and flash devices are entities in the me

[PATCH 8/8] arm: dts: omap3: N9/N950: Add AS3645A camera flash

From: Sakari Ailus Add the as3645a flash controller to the DT source as well as the flash property with the as3645a device phandle to the sensor DT node. Signed-off-by: Sakari Ailus --- arch/arm/boot/dts/omap3-n9.dts | 1 + arch/arm/boot/dts/omap3-n950-n9.dtsi | 14 ++ arch/

[PATCH 1/8] dt: bindings: Add a binding for flash devices associated to a sensor

Camera flash drivers (and LEDs) are separate from the sensor devices in DT. In order to make an association between the two, provide the association information to the software. Signed-off-by: Sakari Ailus --- Documentation/devicetree/bindings/media/video-interfaces.txt | 8 1 file chan

[PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

None of the flash operations are not mandatory and therefore there should be no need for the flash ops structure either. Accept NULL. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-flash-led-class.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/med

[PATCH 3/8] dt: bindings: Add a binding for referencing EEPROM from camera sensors

Many camera sensor devices contain EEPROM chips that describe the properties of a given unit --- the data is specific to a given unit can thus is not stored e.g. in user space or the driver. Some sensors embed the EEPROM chip and it can be accessed through the sensor's I2C interface. This property

[PATCH 4/8] v4l2-flash: Use led_classdev instead of led_classdev_flash for indicator

The V4L2 flash class initialisation expects struct led_classdev_flash that describes an indicator but only uses struct led_classdev which is a field iled_cdev in the struct. Use struct iled_cdev only. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-flash-led-class.c | 19 +++

[PATCH 0/8] Support registering lens, flash and EEPROM devices

Hi folks, This set adds support for async registering of lens, flash and EEPROM devices, as well as support for this in the smiapp driver and a LED driver for the as3645a. The lens and flash devices are entities in the media graph whereas the EEPROM is at least currently not. By providing the ass

[PATCH 2/8] dt: bindings: Add lens-focus binding for image sensors

The lens-focus property contains a phandle to the lens voice coil driver that is associated to the sensor; typically both are contained in the same camera module. Signed-off-by: Sakari Ailus Acked-by: Pavel Machek Reviewed-by: Sebastian Reichel --- Documentation/devicetree/bindings/media/video

[PATCH 6/8] leds: as3645a: Add LED flash class driver

From: Sakari Ailus Add a LED flash class driver for the as3654a flash controller. A V4L2 flash driver for it already exists (drivers/media/i2c/as3645a.c), and this driver is based on that. Signed-off-by: Sakari Ailus --- MAINTAINERS | 6 + drivers/leds/Kconfig| 8 +

[PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

These types devices aren't directly related to the sensor, but are nevertheless handled by the smiapp driver due to the relationship of these component to the main part of the camera module --- the sensor. Additionally, for the async sub-device registration to work, the notifier containing matchin

Re: [PATCH v4 2/2] arm64: dts: renesas: salvator-x: Add ADV7482 support

Hi Geert, On 14/06/17 10:39, Geert Uytterhoeven wrote: > Hi Kieran, > > On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Provide ADV7482, and the needed connectors >> >> Signed-off-by: Kieran Bingham > > Thanks for your patch! > >> v4: >> - dt: Rebase to

Re: [PATCH v4 2/2] arm64: dts: renesas: salvator-x: Add ADV7482 support

Hi Kieran, On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham wrote: > From: Kieran Bingham > > Provide ADV7482, and the needed connectors > > Signed-off-by: Kieran Bingham Thanks for your patch! > v4: > - dt: Rebase to dts/renesas/salvator-x.dtsi > - dt: Use AIN0-7 rather than AIN1-8 > > arc

Re: [PATCH v4 2/2] arm64: dts: renesas: salvator-x: Add ADV7482 support

On Tue, Jun 13, 2017 at 01:35:08AM +0100, Kieran Bingham wrote: > From: Kieran Bingham > > Provide ADV7482, and the needed connectors > > Signed-off-by: Kieran Bingham I am marking this as deferred pending acceptance of the bindings.

Re: [PATCH v4 2/2] arm64: dts: renesas: salvator-x: Add ADV7482 support

Hi Simon, On 14/06/17 10:04, Simon Horman wrote: > On Tue, Jun 13, 2017 at 01:35:08AM +0100, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Provide ADV7482, and the needed connectors >> >> Signed-off-by: Kieran Bingham > > I am marking this as deferred pending acceptance of the bindings.

Re: [PATCH v2] [media] v4l2-subdev: check colorimetry in link validate

Hi Helen and Mauro, On Thu, Jun 08, 2017 at 02:05:08PM -0300, Helen Koike wrote: > colorspace, ycbcr_enc, quantization and xfer_func must match > across the link. > Check if they match in v4l2_subdev_link_validate_default > unless they are set as _DEFAULT. I think you could ignore my earlier comm

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Jun 14 05:00:18 CEST 2017 media-tree git hash:acec3630155763c170c7ae6508cf973355464508 media_build gi

Re: [PATCH v2 0/2] Avoid namespace collision within macros & tidyup

On 14/06/17 08:18, Ramesh Shanmugasundaram wrote: Subject: Re: [PATCH v2 0/2] Avoid namespace collision within macros & tidyup On 13/06/17 14:33, Ramesh Shanmugasundaram wrote: Hi All, The readx_poll_timeout & similar macros defines local variable that can cause name space collision with the c

RE: [PATCH v2 0/2] Avoid namespace collision within macros & tidyup

> Subject: Re: [PATCH v2 0/2] Avoid namespace collision within macros & > tidyup > > On 13/06/17 14:33, Ramesh Shanmugasundaram wrote: > > Hi All, > > > > The readx_poll_timeout & similar macros defines local variable that > > can cause name space collision with the caller. Fixed this issue by > >