[PATCH] [media] s5p-jpeg: fix recursive spinlock acquisition

2017-04-24 Thread Alexandre Courbot
v4l2_m2m_job_finish(), which is called from the interrupt handler with slock acquired, can call the device_run() hook immediately if another context was in the queue. This hook also acquires slock, resulting in a deadlock for this scenario. Fix this by releasing slock right before calling v4l2_m2m

Re: [PATCH 1/2] [media] vb2: Fix an off by one error in 'vb2_plane_vaddr'

2017-04-24 Thread Christophe JAILLET
Le 24/04/2017 à 22:29, Sakari Ailus a écrit : Hi Christophe, On Mon, Apr 24, 2017 at 10:00:24PM +0200, Christophe JAILLET wrote: Le 24/04/2017 à 16:16, Sakari Ailus a écrit : On Sun, Apr 23, 2017 at 11:32:57PM +0200, Christophe JAILLET wrote: We should ensure that 'plane_no' is '< vb->num_pla

cron job: media_tree daily build: ERRORS

2017-04-24 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Apr 25 05:00:13 CEST 2017 media-tree git hash:9eb9db3a0f92b75ec710066202e0b2accb45afa9 media_build gi

[PATCH -next] [media] rainshadow-cec: Fix missing spin_lock_init()

2017-04-24 Thread Wei Yongjun
From: Wei Yongjun The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly. This is detected by Coccinelle semantic patch. Fixes: 0f314f6c2e77 ("[media] rainshadow-cec: new RainShadow Tech HDMI CEC driver") Signed-off-by: Wei Yongjun --- d

Re: [PATCH] [media] ov2640: make GPIOLIB an optional dependency

2017-04-24 Thread Mauro Carvalho Chehab
Em Mon, 24 Apr 2017 20:38:47 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Apr 24, 2017 at 12:50:36PM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 24 Apr 2017 17:44:02 +0300 > > Sakari Ailus escreveu: > > > > > Hi Mauro and others, > > > > > > On Fri, Apr 21, 2017 at 11:39:42AM -0

Re: support autofocus / autogain in libv4l2

2017-04-24 Thread Mauro Carvalho Chehab
Em Tue, 25 Apr 2017 00:07:01 +0200 Pavel Machek escreveu: > Hi! > > > Please don't add a new application under lib/. It is fine if you want > > some testing application, if the ones there aren't enough, but please > > place it under contrib/test/. > > > > You should likely take a look at v4l2gr

[PATCH] [media] pxa_camera: fix module remove codepath for v4l2 clock

2017-04-24 Thread Petr Cvek
The conversion from soc_camera omitted a correct handling of the clock gating for a sensor. When the pxa_camera driver module was removed it tried to unregister clk, but this caused a similar warning: WARNING: CPU: 0 PID: 6740 at drivers/media/v4l2-core/v4l2-clk.c:278 v4l2_clk_unregister(): Re

Re: support autofocus / autogain in libv4l2

2017-04-24 Thread Mauro Carvalho Chehab
Em Mon, 24 Apr 2017 23:29:14 +0200 Pavel Machek escreveu: > Hi! > > > > For focus to be useful, we need autofocus implmented > > > somewhere. Unfortunately, v4l framework does not seem to provide good > > > place where to put autofocus. I believe, long-term, we'll need some > > > kind of "video

Re: support autofocus / autogain in libv4l2

2017-04-24 Thread Pavel Machek
Hi! > Please don't add a new application under lib/. It is fine if you want > some testing application, if the ones there aren't enough, but please > place it under contrib/test/. > > You should likely take a look at v4l2grab first, as it could have > almost everything you would need. I really n

Re: support autofocus / autogain in libv4l2

2017-04-24 Thread Pavel Machek
Hi! > > For focus to be useful, we need autofocus implmented > > somewhere. Unfortunately, v4l framework does not seem to provide good > > place where to put autofocus. I believe, long-term, we'll need some > > kind of "video server" providing this kind of services. > > > > Anyway, we probably do

Re: [PATCH 2/2] [media] vb2: Fix error handling in '__vb2_buf_mem_alloc'

2017-04-24 Thread Sakari Ailus
Hi Christophe, On Mon, Apr 24, 2017 at 10:25:18PM +0200, Christophe JAILLET wrote: > Le 24/04/2017 à 16:23, Sakari Ailus a écrit : > >Hi Christophe, > > > >On Sun, Apr 23, 2017 at 11:40:30PM +0200, Christophe JAILLET wrote: > >>'call_ptr_memop' can return NULL, so we must test its return value wit

Re: [PATCH 1/2] [media] vb2: Fix an off by one error in 'vb2_plane_vaddr'

2017-04-24 Thread Sakari Ailus
Hi Christophe, On Mon, Apr 24, 2017 at 10:00:24PM +0200, Christophe JAILLET wrote: > Le 24/04/2017 à 16:16, Sakari Ailus a écrit : > >On Sun, Apr 23, 2017 at 11:32:57PM +0200, Christophe JAILLET wrote: > >>We should ensure that 'plane_no' is '< vb->num_planes' as done in > >>'vb2_plane_cookie' jus

Re: [PATCH 2/2] [media] vb2: Fix error handling in '__vb2_buf_mem_alloc'

2017-04-24 Thread Christophe JAILLET
Le 24/04/2017 à 16:23, Sakari Ailus a écrit : Hi Christophe, On Sun, Apr 23, 2017 at 11:40:30PM +0200, Christophe JAILLET wrote: 'call_ptr_memop' can return NULL, so we must test its return value with 'IS_ERR_OR_NULL'. Otherwise, the test 'if (mem_priv)' is meaningless. Signed-off-by: Christop

Re: [PATCH 1/2] [media] vb2: Fix an off by one error in 'vb2_plane_vaddr'

2017-04-24 Thread Christophe JAILLET
Le 24/04/2017 à 16:16, Sakari Ailus a écrit : On Sun, Apr 23, 2017 at 11:32:57PM +0200, Christophe JAILLET wrote: We should ensure that 'plane_no' is '< vb->num_planes' as done in 'vb2_plane_cookie' just a few lines below. Signed-off-by: Christophe JAILLET --- drivers/media/v4l2-core/videobu

EXTREMELY IMPORTANT

2017-04-24 Thread Ms. Katherine
Dear Beloved, Sorry for the inconvenience, I am getting in touch with you regarding an extremely important and urgent matter, Please I need your urgent assistance and idea to finish up a project (Orphanage Home) Due to my health condition, Everything is available to finish up the project, All I

[PATCH 2/2] rcar-vin: group: use correct of_node

2017-04-24 Thread Kieran Bingham
From: Kieran Bingham The unbind function dereferences the subdev->dev node to obtain the of_node. In error paths, the subdev->dev can be set to NULL, whilst the correct reference to the of_node is available as subdev->of_node. Correct the dereferencing, and move the variable outside of the loop

[PATCH 1/2] rcar-vin: Verify pads on linkage

2017-04-24 Thread Kieran Bingham
From: Kieran Bingham The current code determines the pad from the identifiers in the DTB. This is accepted without bounds in the driver. Invalid port/reg addresses defined in the DTB will cause a kernel panic when dereferencing non-existing pads. Protect the linkage with a check that the pad nu

[PATCH v2] V4L2 SDR: Add Real U8 format (V4L2_SDR_FMT_RU8)

2017-04-24 Thread Bertold Van den Bergh
This patch adds support for the Real U8 format to the V4L2 SDR framework. Signed-off-by: Bertold Van den Bergh --- Thanks for your comments. I was not aware of the V4L format documentation. I don't think there is a clear natural ordering for these types of formats, but I agree it looks more consi

Re: [PATCH] [media] ov2640: make GPIOLIB an optional dependency

2017-04-24 Thread Sakari Ailus
On Mon, Apr 24, 2017 at 08:38:47PM +0300, Sakari Ailus wrote: ... > ret won't be zero here, that was checked above. You could check for just ret > though, it'd be easier to read that way. I missed ret would have to have type long instead. How about: ret = PTR_ERR(priv->reset_gpio); if (!priv->res

Re: [PATCH] [media] ov2640: make GPIOLIB an optional dependency

2017-04-24 Thread Sakari Ailus
Hi Mauro, On Mon, Apr 24, 2017 at 12:50:36PM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 24 Apr 2017 17:44:02 +0300 > Sakari Ailus escreveu: > > > Hi Mauro and others, > > > > On Fri, Apr 21, 2017 at 11:39:42AM -0300, Mauro Carvalho Chehab wrote: > > > Em Fri, 21 Apr 2017 08:33:12 +0200 > > >

Re: [PATCH] rc-core: use the full 32 bits for NEC scancodes in wakefilters

2017-04-24 Thread Sean Young
On Tue, Apr 18, 2017 at 10:31:04PM +0200, David Härdeman wrote: > The new sysfs wakefilter API will expose the difference between the NEC > protocols to userspace for no good reason and once exposed, it will be much > more difficult to change the logic. > > By only allowing full NEC32 scancodes to

Re: [PATCH v5 1/3] [media] v4l: add parsed MPEG-2 support

2017-04-24 Thread Hans Verkuil
On 21/04/17 17:52, Hugues Fruchet wrote: > Add "parsed MPEG-2" pixel format & related controls > needed by stateless video decoders. > In order to decode the video bitstream chunk provided > by user on output queue, stateless decoders require > also some extra data resulting from this video bitstre

Re: [PATCH] rc-core: use the full 32 bits for NEC scancodes

2017-04-24 Thread Sean Young
On Tue, Apr 18, 2017 at 05:50:27PM +0200, David Härdeman wrote: > Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core > and the nec decoder without any loss of functionality. At the same time > it ensures that scancodes for NEC16/NEC24/NEC32 do not overlap and > removes lots of

Re: [PATCH] [media] ov2640: make GPIOLIB an optional dependency

2017-04-24 Thread Mauro Carvalho Chehab
Em Mon, 24 Apr 2017 17:44:02 +0300 Sakari Ailus escreveu: > Hi Mauro and others, > > On Fri, Apr 21, 2017 at 11:39:42AM -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 21 Apr 2017 08:33:12 +0200 > > Pavel Machek escreveu: > > > > > Hi! > > > > > > > > Better solution would be for VIDEO_EM

Re: [PATCH] [media] Order the Makefile alphabetically

2017-04-24 Thread Sakari Ailus
Hi Mauro and Maxime, On Fri, Apr 21, 2017 at 12:11:05PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 21 Apr 2017 16:41:25 +0200 > Maxime Ripard escreveu: > > > On Wed, Apr 19, 2017 at 08:15:45AM -0300, Mauro Carvalho Chehab wrote: > > > Em Thu, 6 Apr 2017 16:40:51 +0200 > > > Maxime Ripard es

Re: [PATCH] [media] ov2640: make GPIOLIB an optional dependency

2017-04-24 Thread Sakari Ailus
Hi Mauro and others, On Fri, Apr 21, 2017 at 11:39:42AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 21 Apr 2017 08:33:12 +0200 > Pavel Machek escreveu: > > > Hi! > > > > > > Better solution would be for VIDEO_EM28XX_V4L2 to depend on GPIOLIB, > > > > too, no? If not, should there be BUG_ON(pr

Re: [PATCH] V4L2 SDR: Add Real U8 format (V4L2_SDR_FMT_RU8)

2017-04-24 Thread Philipp Zabel
Hi Bertold, On Mon, 2017-04-24 at 00:45 +0200, Bertold Van den Bergh wrote: > This patch adds support for the Real U8 format to the V4L2 SDR framework. > This will be used for a piece of hardware we are developing. > > Signed-off-by: Bertold Van den Bergh > --- > drivers/media/v4l2-core/v4l2-io

Re: [PATCH 2/2] [media] vb2: Fix error handling in '__vb2_buf_mem_alloc'

2017-04-24 Thread Sakari Ailus
Hi Christophe, On Sun, Apr 23, 2017 at 11:40:30PM +0200, Christophe JAILLET wrote: > 'call_ptr_memop' can return NULL, so we must test its return value with > 'IS_ERR_OR_NULL'. Otherwise, the test 'if (mem_priv)' is meaningless. > > Signed-off-by: Christophe JAILLET > --- > Note that error check

Re: [PATCH 1/2] [media] vb2: Fix an off by one error in 'vb2_plane_vaddr'

2017-04-24 Thread Sakari Ailus
On Sun, Apr 23, 2017 at 11:32:57PM +0200, Christophe JAILLET wrote: > We should ensure that 'plane_no' is '< vb->num_planes' as done in > 'vb2_plane_cookie' just a few lines below. > > Signed-off-by: Christophe JAILLET > --- > drivers/media/v4l2-core/videobuf2-core.c | 2 +- > 1 file changed, 1

Re: support autofocus / autogain in libv4l2

2017-04-24 Thread Mauro Carvalho Chehab
Hi Pavel, Em Mon, 24 Apr 2017 11:30:59 +0200 Pavel Machek escreveu: > Hi! > > For focus to be useful, we need autofocus implmented > somewhere. Unfortunately, v4l framework does not seem to provide good > place where to put autofocus. I believe, long-term, we'll need some > kind of "video serve

Re: TW686x Linux Main Line Driver Issue

2017-04-24 Thread Lucas Stach
Am Donnerstag, den 20.04.2017, 11:12 -0300 schrieb Ezequiel Garcia: > On 20 April 2017 at 07:10, Anuradha Ranasinghe > wrote: > > Dear All, > > > > This issue is associated to the Linux Mainline Kernel 4.1.15.2 (branch2) > > tw686x upstream driver and IMX6Q platform. > > > > We have an analog cam

support autofocus / autogain in libv4l2

2017-04-24 Thread Pavel Machek
Hi! For focus to be useful, we need autofocus implmented somewhere. Unfortunately, v4l framework does not seem to provide good place where to put autofocus. I believe, long-term, we'll need some kind of "video server" providing this kind of services. Anyway, we probably don't want autofocus in ke