cron job: media_tree daily build: ERRORS

2017-03-20 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 21 05:00:14 CET 2017 media-tree git hash:700ea5e0e0dd70420a04e703ff264cc133834cba media_build git

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Steve Longerbeam
On 03/20/2017 10:23 AM, Philipp Zabel wrote: Hi Steve, Russell, On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: The same document says: Sca

Re: [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

2017-03-20 Thread kbuild test robot
Hi unknown, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.11-rc3 next-20170320] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/unknown/staging-radio-bcm2048-Fix

[PATCH 4/4 V2] staging: atomisp: remove redudant condition in if-statement

2017-03-20 Thread Daeseok Youn
The V4L2_FIELD_ANY is zero, so the (!field) is same meaning with (field == V4L2_FIELD_ANY) in if-statement. Signed-off-by: Daeseok Youn --- V2: one(2/4) of this series was updated so I tried to send them again. drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 2 +- 1 file changed, 1 i

[PATCH 3/4 V2] staging: atomisp: remove useless condition in if-statements

2017-03-20 Thread Daeseok Youn
The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if- statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY', it could not enter the next if-statement. But the "next" if-statement has the condition to check whether the css_pipe_id equals to 'CSS_PIPE_ID_COPY' or not.

[PATCH 2/4 V2] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

2017-03-20 Thread Daeseok Youn
If v4l2_subdev_call() gets the global frame interval values, it returned 0 and it could be checked whether numerator is zero or not. If the numerator is not zero, the fps could be calculated in this function. If not, it just returns 0. Signed-off-by: Daeseok Youn --- V2: split error handling, th

[PATCH 1/4 V2] staging: atomisp: remove else statement after return

2017-03-20 Thread Daeseok Youn
It doesn't need to have else statement after return. Signed-off-by: Daeseok Youn --- V2: one(2/4) of this series was updated so I tried to send them again. drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/

Re: [PATCH 2/2] [media] vcodec: mediatek: mark pm functions as __maybe_unused

2017-03-20 Thread Rick Chang
On Mon, 2017-03-20 at 10:47 +0100, Arnd Bergmann wrote: > When CONFIG_PM is disabled, we get a couple of unused functions: > > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:927:13: error: > 'mtk_jpeg_clk_off' defined but not used [-Werror=unused-function] > static void mtk_jpeg_clk_off(struct

Re: [PATCH 2/4] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

2017-03-20 Thread DaeSeok Youn
2017-03-20 22:11 GMT+09:00 walter harms : > > > Am 20.03.2017 13:51, schrieb DaeSeok Youn: >> 2017-03-20 21:04 GMT+09:00 walter harms : >>> >>> >>> Am 20.03.2017 11:59, schrieb Daeseok Youn: If v4l2_subdev_call() gets the global frame interval values, it returned 0 and it could be checked

Re: [PATCH 1/2] [media] vcodec: mediatek: add missing linux/slab.h include

2017-03-20 Thread Rick Chang
Hi Arnd, Thank you for the patch, but someone has fixed the same problem. Regards, Rick On Mon, 2017-03-20 at 10:47 +0100, Arnd Bergmann wrote: > With the newly added driver, I have run into randconfig failures like: > > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function 'mtk_jpeg_ope

Reply Urgently.

2017-03-20 Thread JOJO AKPE
I am Barr, Jojo Akpe, esq, a personal attorney to your late relative. I want to contact you to work with me in securing the transfer of fund(US$10,000,000.00 M) legacy by your late relative. I solicit your consent to enable me produce you as the Next of Kin to my deceased client since both of you

Re: [PATCH] [media] dvb-frontends/cxd2841er: define symbol_rate_min/max in T/C fe-ops

2017-03-20 Thread Abylay Ospan
Hello, looks good for me. Acked-by: Abylay Ospan 2017-03-19 11:26 GMT-04:00 Daniel Scheller : > From: Daniel Scheller > > Fixes "w_scan -f c" complaining with > > This dvb driver is *buggy*: the symbol rate limits are undefined - please > report to linuxtv.org) > > Signed-off-by: Daniel Sch

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Russell King - ARM Linux
On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote: > --8<-- > >From 2830aebc404bdfc9d7fc1ec94e5282d0b668e8f6 Mon Sep 17 00:00:00 2001 > From: Philipp Zabel > Date: Mon, 20 Mar 2017 17:10:21 +0100 > Subject: [PATCH] media: imx: csi: add sink selection rectangles > > Mov

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Steve Longerbeam
On 03/20/2017 07:00 AM, Philipp Zabel wrote: On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote: The above paragraph suggests we skip any rectangles that are not supported. In our case that would be 3. and 4., since

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Russell King - ARM Linux
On Mon, Mar 20, 2017 at 06:40:21PM +0100, Philipp Zabel wrote: > On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: > > I have tripped over a bug in media-ctl when specifying both a crop and > > compose rectangle - the --help output suggests that "," should be used > > to separate t

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Philipp Zabel
On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > > The same document says: > > > > > > Scaling support is optional. When supported by a su

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-20 Thread Mauro Carvalho Chehab
Em Mon, 20 Mar 2017 16:10:03 + Russell King - ARM Linux escreveu: > On Mon, Mar 20, 2017 at 12:39:38PM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 20 Mar 2017 14:24:25 +0100 > > Hans Verkuil escreveu: > > > I don't think this control inheritance patch will magically prevent you > > > f

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Philipp Zabel
Hi Steve, Russell, On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > > The same document says: > > > > > > Scaling support is optional. Wh

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Russell King - ARM Linux
On Mon, Mar 20, 2017 at 02:17:05PM +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > > The same document says: > > > > > > Scaling support is optional. When supported

Re: [PATCHv5 06/16] atmel-isi: document device tree bindings

2017-03-20 Thread Rob Herring
On Mon, Mar 20, 2017 at 11:49 AM, Hans Verkuil wrote: > On 03/20/2017 05:41 PM, Rob Herring wrote: >> On Sat, Mar 11, 2017 at 12:23:18PM +0100, Hans Verkuil wrote: >>> From: Hans Verkuil >>> +ov2640: camera@30 { >>> +compatible = "ovti,ov2640"; >>> +reg = <0x30>; >>>

Re: [PATCHv5 06/16] atmel-isi: document device tree bindings

2017-03-20 Thread Hans Verkuil
On 03/20/2017 05:41 PM, Rob Herring wrote: > On Sat, Mar 11, 2017 at 12:23:18PM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Document the device tree bindings for this hardware. >> >> Mostly copied from the atmel-isc bindings. > > This commit message doesn't really reflect what you are

Re: [PATCHv5 06/16] atmel-isi: document device tree bindings

2017-03-20 Thread Rob Herring
On Sat, Mar 11, 2017 at 12:23:18PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Document the device tree bindings for this hardware. > > Mostly copied from the atmel-isc bindings. This commit message doesn't really reflect what you are doing and the reformatting and fixes really make th

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-20 Thread Russell King - ARM Linux
On Mon, Mar 20, 2017 at 05:29:07PM +0100, Philipp Zabel wrote: > According to the documentation [1], you are doing the right thing: > > The struct v4l2_subdev_frame_interval pad references a non-existing > pad, or the pad doesn’t support frame intervals. > > But v4l2_subdev_call returns -

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-20 Thread Philipp Zabel
On Mon, 2017-03-20 at 15:43 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 02:20:16PM +0100, Philipp Zabel wrote: > > To set and read colorimetry information: > > https://patchwork.linuxtv.org/patch/39350/ > > Thanks, I've applied all four of your patches, but there's a side effe

Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning

2017-03-20 Thread Arnd Bergmann
On Mon, Mar 20, 2017 at 4:05 PM, Stephen Hemminger wrote: > On Mon, 20 Mar 2017 10:32:19 +0100 > Arnd Bergmann wrote: > >> -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/) >> +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void) >> { > Why keep the comment? The comment

Re: [PATCHv5 01/16] ov7670: document device tree bindings

2017-03-20 Thread Rob Herring
On Sat, Mar 11, 2017 at 12:23:13PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Add binding documentation and add that file to the MAINTAINERS entry. > > Signed-off-by: Hans Verkuil > Acked-by: Sakari Ailus > --- > .../devicetree/bindings/media/i2c/ov7670.txt | 43 >

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-20 Thread Russell King - ARM Linux
On Mon, Mar 20, 2017 at 12:39:38PM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 20 Mar 2017 14:24:25 +0100 > Hans Verkuil escreveu: > > I don't think this control inheritance patch will magically prevent you > > from needed a plugin. > > Yeah, it is not just control inheritance. The driver needs

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 12:33 -0300, Mauro Carvalho Chehab wrote: > Em Mon, 20 Mar 2017 08:11:41 -0700 > Michael Zoran escreveu: > > > On Mon, 2017-03-20 at 11:58 -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 20 Mar 2017 04:08:21 -0700 > > > Michael Zoran escreveu: > > >    > > > > On Mon, 201

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-20 Thread Hans Verkuil
On 03/20/2017 03:11 PM, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote: >> On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote: >>> It's what I have - remember, not everyone is happy to constantly replace >>> their distro packages with random new s

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-20 Thread Russell King - ARM Linux
On Mon, Mar 20, 2017 at 02:20:16PM +0100, Philipp Zabel wrote: > To set and read colorimetry information: > https://patchwork.linuxtv.org/patch/39350/ Thanks, I've applied all four of your patches, but there's a side effect from that. Old media-ctl (modified by me): - entity 53: imx219 0-0010 (2

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-20 Thread Mauro Carvalho Chehab
Em Mon, 20 Mar 2017 08:11:41 -0700 Michael Zoran escreveu: > On Mon, 2017-03-20 at 11:58 -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 20 Mar 2017 04:08:21 -0700 > > Michael Zoran escreveu: > > > > > On Mon, 2017-03-20 at 07:58 -0300, Mauro Carvalho Chehab wrote: > > > > Em Sun, 19 Mar 20

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-20 Thread Mauro Carvalho Chehab
Em Mon, 20 Mar 2017 14:24:25 +0100 Hans Verkuil escreveu: > On 03/14/2017 11:21 AM, Mauro Carvalho Chehab wrote: > > Em Tue, 14 Mar 2017 08:55:36 +0100 > > Hans Verkuil escreveu: > > > >> On 03/14/2017 04:45 AM, Mauro Carvalho Chehab wrote: > >>> Hi Sakari, > >>> > >> We're all very driver

Re: [PATCH v3 2/6] media: uapi: Add RGB and YUV bus formats for Synopsys HDMI TX Controller

2017-03-20 Thread Hans Verkuil
On 03/07/2017 05:42 PM, Neil Armstrong wrote: > In order to describe the RGB and YUB bus formats used to feed the > Synopsys DesignWare HDMI TX Controller, add missing formats to the > list of Bus Formats. > > Documentation for these formats is added in a separate patch. > > Signed-off-by: Neil A

Re: [PATCH v5 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-03-20 Thread Rob Herring
+Ramiro On Thu, Mar 09, 2017 at 08:52:42PM -0800, Steve Longerbeam wrote: > Add bindings documentation for the i.MX media driver. > > Signed-off-by: Steve Longerbeam > --- > Documentation/devicetree/bindings/media/imx.txt | 74 > + > 1 file changed, 74 insertions(+) >

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 11:58 -0300, Mauro Carvalho Chehab wrote: > Em Mon, 20 Mar 2017 04:08:21 -0700 > Michael Zoran escreveu: > > > On Mon, 2017-03-20 at 07:58 -0300, Mauro Carvalho Chehab wrote: > > > Em Sun, 19 Mar 2017 22:11:07 -0300 > > > Mauro Carvalho Chehab escreveu: > > >    > > > > Em

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-20 Thread Mauro Carvalho Chehab
Em Mon, 20 Mar 2017 14:10:30 +0100 Hans Verkuil escreveu: > On 03/17/2017 03:37 PM, Russell King - ARM Linux wrote: > > On Fri, Mar 17, 2017 at 02:51:10PM +0100, Philipp Zabel wrote: > >> On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote: > >> [...] > >>> The big question, waitin

[GIT PULL for v4.12] RC fixes

2017-03-20 Thread Sean Young
Hi Mauro, Various small RC fixes and documentation fixes. The most controversial is the changing of the return code of lirc ioctls. I've tested lirc. If you can think of anything else which needs testing, please let me know. Thanks, Sean The following changes since commit 700ea5e0e0dd70420a04e70

Re: [PATCH v3 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

2017-03-20 Thread Hans Verkuil
On 03/17/2017 05:11 PM, Neil Armstrong wrote: > On 03/16/2017 06:01 PM, Archit Taneja wrote: >> >> >> On 3/7/2017 10:12 PM, Neil Armstrong wrote: >>> Add documentation for added Bus Formats to describe RGB and YUS formats used >> >> s/YUS/YUV > > Thanks again > >> >>> as input to the Synopsys

Re: [PATCH v5 03/39] [media] dt/bindings: Add bindings for OV5640

2017-03-20 Thread Rob Herring
On Thu, Mar 09, 2017 at 08:52:43PM -0800, Steve Longerbeam wrote: > Add device tree binding documentation for the OV5640 camera sensor. > > Signed-off-by: Steve Longerbeam > --- > .../devicetree/bindings/media/i2c/ov5640.txt | 45 > ++ > 1 file changed, 45 insertions(+

Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning

2017-03-20 Thread Stephen Hemminger
On Mon, 20 Mar 2017 10:32:19 +0100 Arnd Bergmann wrote: > -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/) > +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void) > { Why keep the comment?

[PATCH 08/24] atomisp/imx: Fix locking bug on error path

2017-03-20 Thread Alan Cox
This was reported by Dan Carpenter. When we error with an IMX 227 we don't release the lock and the sensor would then hang. Signed-off-by: Alan Cox --- drivers/staging/media/atomisp/i2c/imx/imx.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/ato

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-20 Thread Mauro Carvalho Chehab
Em Mon, 20 Mar 2017 04:08:21 -0700 Michael Zoran escreveu: > On Mon, 2017-03-20 at 07:58 -0300, Mauro Carvalho Chehab wrote: > > Em Sun, 19 Mar 2017 22:11:07 -0300 > > Mauro Carvalho Chehab escreveu: > > > > > Em Sun, 19 Mar 2017 10:04:28 -0700 > > > Michael Zoran escreveu: > > > > > > >

[PATCH 12/24] staging: media: atomisp: select REGMAP_I2C needed by ap1302.c

2017-03-20 Thread Alan Cox
From: Jérémy Lefaure REGMAP_I2C should be enabled to build the driver ap1302 because it uses regmap functions. Signed-off-by: Jérémy Lefaure Signed-off-by: Alan Cox --- drivers/staging/media/atomisp/i2c/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomi

[PATCH 06/24] atomisp: kill another define

2017-03-20 Thread Alan Cox
We don't need an ifdef for the sake of 8-12 bytes. This undoes the ifdef added by fde469701c7efabebf885e785edf367bfb1a8f3f. Instead turn it into a single const string array at a fixed location thereby saving even more memory. Signed-off-by: Alan Cox --- .../staging/media/atomisp/pci/atomisp2/h

[PATCH 07/24] ov5693: remove unused function

2017-03-20 Thread Alan Cox
It's commented out in the tree with a note saying to remove it. So let's remove it. Signed-off-by: Alan Cox --- drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 23 - 1 file changed, 23 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c b/driv

[PATCH 24/24] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

2017-03-20 Thread Alan Cox
From: Daeseok Youn If v4l2_subdev_call() gets the global frame interval values, it returned 0 and it could be checked whether numerator is zero or not. If the numerator is not zero, the fps could be calculated in this function. If not, it just returns 0. Signed-off-by: Daeseok Youn Signed-off-

[PATCH 23/24] atomisp: remove a sysfs error message that can be used to log spam

2017-03-20 Thread Alan Cox
Instead of logging this just report ERANGE as an error, which will give something close to the right user space report. The others of these were already removed by Dan Carpenter's patch. Signed-off-by: Alan Cox --- .../media/atomisp/pci/atomisp2/atomisp_drvfs.c |4 +--- 1 file changed,

[PATCH 05/24] atomisp: ia_css_bh_hmem_encode is a no-op so remove it

2017-03-20 Thread Alan Cox
This is a do nothing function so we can replace it with nothing and eliminate it entirely. Signed-off-by: Alan Cox --- .../ia_css_isp_params.c|6 -- .../ia_css_isp_params.c|6 -- .../ia_css_isp_params.c

[PATCH 22/24] staging: atomisp: remove redudant condition in if-statement

2017-03-20 Thread Alan Cox
From: Daeseok Youn The V4L2_FIELD_ANY is zero, so the (!field) is same meaning with (field == V4L2_FIELD_ANY) in if-statement. Signed-off-by: Daeseok Youn Signed-off-by: Alan Cox --- .../media/atomisp/pci/atomisp2/atomisp_cmd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH 21/24] staging: atomisp: remove else statement after return

2017-03-20 Thread Alan Cox
From: Daeseok Youn It doesn't need to have else statement after return. Signed-off-by: Daeseok Youn Signed-off-by: Alan Cox --- .../media/atomisp/pci/atomisp2/atomisp_cmd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/ato

[PATCH 16/24] stating/atomisp: fix -Wold-style-definition warning

2017-03-20 Thread Alan Cox
From: Arnd Bergmann ia_css_dequeue_param_buffers does not have an arguement type, causing a warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c: In function 'ia_css_dequeue_param_buffers': drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:3728:6: error:

Re: [PATCHv2 1/4] video: add hotplug detect notifier support

2017-03-20 Thread Hans Verkuil
On 03/20/2017 03:27 PM, Russell King - ARM Linux wrote: On Mon, Mar 20, 2017 at 02:26:16PM +, Russell King - ARM Linux wrote: On Mon, Jan 02, 2017 at 03:19:04PM +0100, Hans Verkuil wrote: From: Hans Verkuil Add support for video hotplug detect and EDID/ELD notifiers, which is used to conv

[PATCH 13/24] staging: media: atomisp: add missing dependencies in Kconfig

2017-03-20 Thread Alan Cox
From: Jérémy Lefaure Two dependencies were missing to build atomisp drivers: _ MEDIA_CONTROLLER: to use the entity field of v4l2_subdev structure. Since every atomisp driver needs MEDIA_CONTROLLER has a dependency, let's add it to INTEL_ATOMISP _ EFI: to use efivar_entry_get: drivers/built-in.o

[PATCH 17/24] staging/atomisp: remove sh_css_lace_stat code

2017-03-20 Thread Alan Cox
From: Arnd Bergmann I ran into a build warning on my randconfig build box: drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c: In function 'ia_css_lace_statistics_free': drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:2845:64: error: parameter 'me' set but no

[PATCH 09/24] atomisp: remove another pair of 2400/2401 differences

2017-03-20 Thread Alan Cox
The first of these checks the PCI identifier in order to decide what to do so needs no ifdef. The other is simply a variation on what is dumped for debug - so favour dumping the most. Signed-off-by Alan Cox --- .../media/atomisp/pci/atomisp2/atomisp_cmd.c |7 --- .../atomisp/pci/

[PATCH 14/24] staging/atomisp: include linux/io.h where needed

2017-03-20 Thread Alan Cox
From: Arnd Bergmann The plat_clock implementation fails ot build in some configurations: platform/clock/vlv2_plat_clock.c: In function 'vlv2_plat_set_clock_freq': platform/clock/vlv2_plat_clock.c:88:2: error: implicit declaration of function 'writel';did you mean 'wrmsrl'? [-Werror=implicit-fun

[PATCH 20/24] staging/atomisp: add ACPI dependency

2017-03-20 Thread Alan Cox
From: Arnd Bergmann Without ACPI, some of the code fails to build: media/atomisp/platform/intel-mid/atomisp_gmin_platform.c: In function 'atomisp_register_i2c_module': media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:174:7: error: dereferencing pointer to incomplete type 'struct acpi_d

[PATCH 10/24] Staging: atomisp: fix locking in alloc_user_pages()

2017-03-20 Thread Alan Cox
From: Dan Carpenter We call this function with the lock held and should also return with the lock held as well. This one error path is not-consistent because we should return without the lock held. Signed-off-by: Dan Carpenter Signed-off-by: Alan Cox --- .../media/atomisp/pci/atomisp2/hmm/hm

[PATCH 18/24] staging/atomisp: add VIDEO_V4L2_SUBDEV_API dependency

2017-03-20 Thread Alan Cox
From: Arnd Bergmann The driver fails to build if this is disabled, so we need an explicit Kconfig dependency: drivers/staging/media/atomisp/pci/atomisp2/./atomisp_cmd.c:6085:48: error: 'struct v4l2_subdev_fh' has no member named 'pad' Fixes: a49d25364dfb ("staging/atomisp: Add support for the

[PATCH 11/24] Staging: atomisp: fix an uninitialized variable bug

2017-03-20 Thread Alan Cox
From: Dan Carpenter There are some error paths in atomisp_css_frame_allocate() which don't initialize "res" so it could lead us to try release random memory. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter Signed-off-by: Alan Cox --- .../

[PATCH 15/24] staging/atomisp: fix empty-body warning

2017-03-20 Thread Alan Cox
From: Arnd Bergmann Defining a debug function to nothing causes a warning with an empty block after if()/else(): drivers/staging/media/atomisp/i2c/ov2680.c: In function 'ov2680_s_stream': drivers/staging/media/atomisp/i2c/ov2680.c:1208:55: error: suggest braces around empty body in an 'else' st

[PATCH 19/24] staging/atomisp: add PCI dependency

2017-03-20 Thread Alan Cox
From: Arnd Bergmann Without CONFIG_PCI, config space reads never return any data, leading to undefined behavior that gcc warns about: platform/intel-mid/intel_mid_pcihelpers.c: In function 'intel_mid_msgbus_read32_raw': platform/intel-mid/intel_mid_pcihelpers.c:66:9: error: 'data' is used unin

Re: [PATCHv2 1/4] video: add hotplug detect notifier support

2017-03-20 Thread Russell King - ARM Linux
On Mon, Mar 20, 2017 at 02:26:16PM +, Russell King - ARM Linux wrote: > On Mon, Jan 02, 2017 at 03:19:04PM +0100, Hans Verkuil wrote: > > From: Hans Verkuil > > > > Add support for video hotplug detect and EDID/ELD notifiers, which is used > > to convey information from video drivers to their

Re: [PATCHv2 1/4] video: add hotplug detect notifier support

2017-03-20 Thread Russell King - ARM Linux
On Mon, Jan 02, 2017 at 03:19:04PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Add support for video hotplug detect and EDID/ELD notifiers, which is used > to convey information from video drivers to their CEC and audio counterparts. > > Based on an earlier version from Russell King: >

Re: [PATCH v3 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

2017-03-20 Thread Hans Verkuil
On 03/07/2017 05:42 PM, Neil Armstrong wrote: > Add documentation for added Bus Formats to describe RGB and YUS formats used > as input to the Synopsys DesignWare HDMI TX Controller. > > Signed-off-by: Neil Armstrong > --- > Documentation/media/uapi/v4l/subdev-formats.rst | 4992 > +

[PATCH 04/24] atomisp: remove another layer of allocator indirection

2017-03-20 Thread Alan Cox
Our driver only ever uses one set of routines for the allocators used by the CSS layer to manage memory and the memory management on the ISP. We can thus remove the function vectors and simply call the intended routines directly. These routines in turn are simply wrappers around another layer of

[PATCH 03/24] atomisp: remove the unused debug wrapping from the mmgr layer

2017-03-20 Thread Alan Cox
We don't need this layer of indirection and the debugging information is not used. With this removed we can then go on to try and remove the abstraction layer entirely. Signed-off-by: Alan Cox --- .../memory_access/memory_access.h | 80 +++- .../pci/atomisp2/c

[PATCH 02/24] atomisp: remove aa kernel wrappers

2017-03-20 Thread Alan Cox
The aa kernel is used but it consists of nothing more than a set of wrappers for a memset and an assignment. Replace these at the calling points with the memset and assignment. Keep the structures for now - those should disappear as the next layer up gets unwrapped. Signed-off-by: Alan Cox ---

[PATCH 01/24] atomisp: remove the iefd2 kernel

2017-03-20 Thread Alan Cox
While this is included and the headers pulled in nothing actually uses this functionality in the driver, so remove it. Signed-off-by: Alan Cox --- .../staging/media/atomisp/pci/atomisp2/Makefile|3 .../ia_css_isp_params.c|1 .../ia_css_isp_states.h

Re: [PATCH v10 1/2] Documentation: DT: Add OV5647 bindings

2017-03-20 Thread Vladimir Zapolskiy
Hi Ramiro, On 03/06/2017 01:16 PM, Ramiro Oliveira wrote: > Create device tree bindings documentation. > > Signed-off-by: Ramiro Oliveira The device tree binding description looks perfect from my perspective. Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Russell King - ARM Linux
On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > The same document says: > > > > Scaling support is optional. When supported by a subdev, the crop > > rectangle on the subdev's sink pad is scaled to the size

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Philipp Zabel
On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote: > > The above paragraph suggests we skip any rectangles that are not > > supported. In our case that would be 3. and 4., since the CSI can't > > compose into a larger

Re: [PATCH v10 2/2] media: i2c: Add support for OV5647 sensor.

2017-03-20 Thread Vladimir Zapolskiy
Hi Ramiro, On 03/06/2017 01:16 PM, Ramiro Oliveira wrote: > The OV5647 sensor from Omnivision supports up to 2592x1944 @ 15 fps, RAW 8 > and RAW 10 output formats, and MIPI CSI-2 interface. > > The driver adds support for 640x480 RAW 8. > > Signed-off-by: Ramiro Oliveira All updates are fine,

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-20 Thread Russell King - ARM Linux
On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote: > On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote: > > It's what I have - remember, not everyone is happy to constantly replace > > their distro packages with random new stuff. > > This is a compliance test, which is continuously

Re: [bug report] staging/atomisp: Add support for the Intel IPU v2

2017-03-20 Thread Alan Cox
>    674   >    675  /* To avoid owerflows when calling the efivar API */ >    676  if (*out_len > ULONG_MAX) > > This is impossible.  Was UINT_MAX intended? I am really not sure. The only case I can imagine is 32bit EFI on a 64bit system, b

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-20 Thread Hans Verkuil
On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 02:01:58PM +0100, Hans Verkuil wrote: >> On 03/19/2017 06:54 PM, Steve Longerbeam wrote: >>> >>> >>> On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: What did you do with: ioctl(3, VIDIOC_REQBUFS

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-20 Thread Russell King - ARM Linux
On Mon, Mar 20, 2017 at 02:01:58PM +0100, Hans Verkuil wrote: > On 03/19/2017 06:54 PM, Steve Longerbeam wrote: > > > > > > On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: > >> What did you do with: > >> > >> ioctl(3, VIDIOC_REQBUFS, {count=0, type=0 /* V4L2_BUF_TYPE_??? */, > >> memory=

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-20 Thread Philipp Zabel
On Sun, 2017-03-19 at 12:14 +, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > > On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: > > >0:00:01.955927879 20954 0x15ffe90 INFOv4l2 > > >gstv4l2object.c:3811:gst_v4l2

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-20 Thread Hans Verkuil
On 03/14/2017 11:21 AM, Mauro Carvalho Chehab wrote: > Em Tue, 14 Mar 2017 08:55:36 +0100 > Hans Verkuil escreveu: > >> On 03/14/2017 04:45 AM, Mauro Carvalho Chehab wrote: >>> Hi Sakari, >>> >>> I started preparing a long argument about it, but gave up in favor of a >>> simpler one. >>> >>> Em M

Re: [PATCH 2/4] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

2017-03-20 Thread walter harms
Am 20.03.2017 13:51, schrieb DaeSeok Youn: > 2017-03-20 21:04 GMT+09:00 walter harms : >> >> >> Am 20.03.2017 11:59, schrieb Daeseok Youn: >>> If v4l2_subdev_call() gets the global frame interval values, >>> it returned 0 and it could be checked whether numerator is zero or not. >>> >>> If the nu

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-20 Thread Hans Verkuil
On 03/17/2017 03:37 PM, Russell King - ARM Linux wrote: > On Fri, Mar 17, 2017 at 02:51:10PM +0100, Philipp Zabel wrote: >> On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote: >> [...] >>> The big question, waiting for an answer on the last 8 years is >>> who would do that? Such person

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-20 Thread Philipp Zabel
On Sat, 2017-03-18 at 12:58 -0700, Steve Longerbeam wrote: > > On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: > > Hi Steve, > > > > I've just been trying to get gstreamer to capture and h264 encode > > video from my camera at various frame rates, and what I've discovered > > does not look

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-20 Thread Hans Verkuil
On 03/19/2017 06:54 PM, Steve Longerbeam wrote: > > > On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: >> On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >>> Right, imx-media-capture.c (the "standard" v4l2 user interface module) >>> is not implementing VIDIOC_ENUM_FRAMESI

Re: [PATCH 2/4] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

2017-03-20 Thread DaeSeok Youn
2017-03-20 21:04 GMT+09:00 walter harms : > > > Am 20.03.2017 11:59, schrieb Daeseok Youn: >> If v4l2_subdev_call() gets the global frame interval values, >> it returned 0 and it could be checked whether numerator is zero or not. >> >> If the numerator is not zero, the fps could be calculated in th

[PATCH 6/9] staging/atomisp: add PCI dependency

2017-03-20 Thread Arnd Bergmann
Without CONFIG_PCI, config space reads never return any data, leading to undefined behavior that gcc warns about: platform/intel-mid/intel_mid_pcihelpers.c: In function 'intel_mid_msgbus_read32_raw': platform/intel-mid/intel_mid_pcihelpers.c:66:9: error: 'data' is used uninitialized in this func

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-20 Thread Hans Verkuil
On 03/19/2017 01:14 PM, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >> On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: >>> 0:00:01.955927879 20954 0x15ffe90 INFOv4l2 >>> gstv4l2object.c:3811:gst_v4l2_object_get_ca

[PATCH 9/9] staging/atomisp: add EFI dependency

2017-03-20 Thread Arnd Bergmann
Without CONFIG_EFI, the driver fails to call efivar_entry_get: drivers/staging/built-in.o: In function `gmin_get_config_var': (.text+0x1e3b): undefined reference to `efivar_entry_get' Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Arnd Bergmann --- driv

[PATCH 8/9] staging/atomisp: add MEDIA_CONTROLLER dependency globally

2017-03-20 Thread Arnd Bergmann
One i2c driver already gained a dependency, but the others are equally broken: drivers/staging/media/atomisp/i2c/ap1302.c: In function 'ap1302_remove': drivers/staging/media/atomisp/i2c/ap1302.c:1143:31: error: 'struct v4l2_subdev' has no member named 'entity' drivers/staging/media/atomisp/i2c/mt

[PATCH 5/9] staging/atomisp: add VIDEO_V4L2_SUBDEV_API dependency

2017-03-20 Thread Arnd Bergmann
The driver fails to build if this is disabled, so we need an explicit Kconfig dependency: drivers/staging/media/atomisp/pci/atomisp2/./atomisp_cmd.c:6085:48: error: 'struct v4l2_subdev_fh' has no member named 'pad' Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-

[PATCH 7/9] staging/atomisp: add ACPI dependency

2017-03-20 Thread Arnd Bergmann
Without ACPI, some of the code fails to build: media/atomisp/platform/intel-mid/atomisp_gmin_platform.c: In function 'atomisp_register_i2c_module': media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:174:7: error: dereferencing pointer to incomplete type 'struct acpi_device' We could work

[PATCH 4/9] staging/atomisp: remove sh_css_lace_stat code

2017-03-20 Thread Arnd Bergmann
I ran into a build warning on my randconfig build box: drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c: In function 'ia_css_lace_statistics_free': drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:2845:64: error: parameter 'me' set but not used [-Werror=unused

[PATCH 1/9] staging/atomisp: include linux/io.h where needed

2017-03-20 Thread Arnd Bergmann
The plat_clock implementation fails ot build in some configurations: platform/clock/vlv2_plat_clock.c: In function 'vlv2_plat_set_clock_freq': platform/clock/vlv2_plat_clock.c:88:2: error: implicit declaration of function 'writel';did you mean 'wrmsrl'? [-Werror=implicit-function-declaration] pla

[PATCH 2/9] staging/atomisp: fix empty-body warning

2017-03-20 Thread Arnd Bergmann
Defining a debug function to nothing causes a warning with an empty block after if()/else(): drivers/staging/media/atomisp/i2c/ov2680.c: In function 'ov2680_s_stream': drivers/staging/media/atomisp/i2c/ov2680.c:1208:55: error: suggest braces around empty body in an 'else' statement [-Werror=empty

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Russell King - ARM Linux
On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote: > The above paragraph suggests we skip any rectangles that are not > supported. In our case that would be 3. and 4., since the CSI can't > compose into a larger frame. I hadn't realised that the crop selection > currently happens on the

Re: mainline build: 208 builds: 0 failed, 208 passed, 422 warnings (v4.11-rc2-164-gdefc7d752265)

2017-03-20 Thread Will Deacon
On Wed, Mar 15, 2017 at 09:02:06PM +0100, Arnd Bergmann wrote: > On Wed, Mar 15, 2017 at 6:53 PM, kernelci.org bot wrote: > > > > mainline build: 208 builds: 0 failed, 208 passed, 422 warnings > > (v4.11-rc2-164-gdefc7d752265) > > The last build failure in mainline is gone now, though I don't kn

Re: [PATCH 2/4] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

2017-03-20 Thread walter harms
Am 20.03.2017 11:59, schrieb Daeseok Youn: > If v4l2_subdev_call() gets the global frame interval values, > it returned 0 and it could be checked whether numerator is zero or not. > > If the numerator is not zero, the fps could be calculated in this function. > If not, it just returns 0. > > Si

Re: [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

2017-03-20 Thread Dan Carpenter
Also fix your From header. regards, dan carpenter

Re: [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

2017-03-20 Thread Dan Carpenter
The subject is too long. On Mon, Mar 20, 2017 at 10:02:33PM +1100, unknown wrote: > Signed-off-by: Eddie Youseph You need to have a changelog. regards, dan carpenter

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-20 Thread Stefan Wahren
Hi Mauro, Am 20.03.2017 um 11:58 schrieb Mauro Carvalho Chehab: Em Sun, 19 Mar 2017 22:11:07 -0300 Mauro Carvalho Chehab escreveu: Em Sun, 19 Mar 2017 10:04:28 -0700 Michael Zoran escreveu: A working DT that I tried this morning with the current firmware is posted here: http://lists.infra

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Philipp Zabel
On Sun, 2017-03-19 at 12:08 -0700, Steve Longerbeam wrote: > > On 03/19/2017 08:22 AM, Russell King - ARM Linux wrote: > > On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote: > >> From: Philipp Zabel > >> > >> The csi_try_crop call in set_fmt should compare the cropping rectangle >

  1   2   >