[PATCH] v4l2-ctrls.c: add NULL check

2017-01-24 Thread Hans Verkuil
Check that the control whose events we want to delete is still there. Normally this will always be the case, but I am not 100% certain if there aren't any corner cases when a device is forcibly unbound. In any case, this will satisfy static checkers and simply make it more robust. Signed-off-by:

cron job: media_tree daily build: WARNINGS

2017-01-24 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Jan 25 05:00:24 CET 2017 media-tree git hash:40eca140c404505c09773d1c6685d818cb55ab1a media_build git

Re: [PATCH v3 19/24] media: imx: Add IC subdev drivers

2017-01-24 Thread Steve Longerbeam
On 01/20/2017 06:29 AM, Hans Verkuil wrote: On 01/07/2017 03:11 AM, Steve Longerbeam wrote: + +static const struct v4l2_ctrl_config prpenc_std_ctrl[] = { + { + .id = V4L2_CID_HFLIP, + .name = "Horizontal Flip", + .type = V4L2_CTRL_TYPE_BOOLEAN, +

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-24 Thread Steve Longerbeam
On 01/24/2017 04:02 AM, Philipp Zabel wrote: Hi Hans, On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote: + +int vidsw_g_mbus_config(struct v4l2_subdev *sd, struct v4l2_mbus_config *cfg) +{ + struct vidsw *vidsw = v4l2_subdev_to_vidsw(sd); + struct media_pad *pad; + int

[PATCH] [media] exynos-gsc: Avoid spamming the log on VIDIOC_TRY_FMT

2017-01-24 Thread Javier Martinez Canillas
There isn't an ioctl to enum the supported field orders, so a user-space application can call VIDIOC_TRY_FMT using different field orders to know if one is supported. For example, GStreamer does this so during playback dozens of the following messages appear in the kernel log buffer: [ 442.143393]

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2017-01-24 Thread Philipp Zabel
Hi Steve, On Mon, 2017-01-09 at 20:43 +0100, Philipp Zabel wrote: > On the other hand, there is currently no way to communicate to userspace > that the IC can't downscale bilinearly, but only to 1/2 or 1/4 of the > input resolution, and then scale up bilinearly for there. This is completely wrong

[PATCH v2] pci: drop link_reset

2017-01-24 Thread Michael S. Tsirkin
No hardware seems to actually call link_reset, and no driver implements it as more than a nop stub. This drops the mentions of the callback from everywhere. It's dropped from the documentation as well, but the doc really needs to be updated to reflect reality better (e.g. on pcie slot reset is the

Re: [PATCH] pci: drop link_reset

2017-01-24 Thread Michael S. Tsirkin
On Wed, Jan 18, 2017 at 07:19:48PM -0500, Doug Ledford wrote: > On Wed, 2017-01-18 at 23:39 +0200, Michael S. Tsirkin wrote: > > No hardware seems to actually call link_reset, and > > no driver implements it as more than a nop stub. > > > > This drops the mentions of the callback from everywhere.

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-24 Thread Javier Martinez Canillas
Hello Steve, On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: > From: Philipp Zabel [snip] > > +config VIDEO_MULTIPLEXER > + tristate "Video Multiplexer" > + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER The driver can be build as a module... > + > +static const st

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-24 Thread Philipp Zabel
Hi Hans, On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote: > On 01/07/2017 03:11 AM, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > This driver can handle SoC internal and external video bus multiplexers, > > controlled either by register bit fields or by a GPIO. The subdevice > >

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-24 Thread Philipp Zabel
On Wed, 2017-01-18 at 17:44 -0800, Steve Longerbeam wrote: > > On 01/14/2017 02:42 PM, Steve Longerbeam wrote: > > > >>> +/* parse inputs property from a sensor node */ > >>> +static void of_parse_sensor_inputs(struct imx_media_dev *imxmd, > >>> +struct imx_media_subdev

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-24 Thread Philipp Zabel
Hi Steve, On Mon, 2017-01-23 at 17:45 -0800, Steve Longerbeam wrote: > > On 01/23/2017 05:38 PM, Steve Longerbeam wrote: > > > >> > >>> Second, ignoring the above locking issue for a moment, > >>> v4l2_pipeline_pm_use() > >>> will call s_power on the sensor _first_, then the mipi csi-2 s_power, >

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-24 Thread Philipp Zabel
On Mon, 2017-01-23 at 12:08 +0100, Hans Verkuil wrote: > On 01/23/2017 12:00 PM, Philipp Zabel wrote: > > On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote: [...] > As long as it is mentioned in the TODO, and ideally in the Kconfig as well, > then I'm fine with it. > > The big advantage of bein

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-24 Thread Philipp Zabel
Hi Steve, Hans, [added Laurent to Cc: who I believe might have an opinion on the media bus formats, too. Sorry for the wall of text, I have put a marker where the MEDIA_BUS argument starts] The central issue seems to be that I think media pad links / media bus formats should describe physical lin

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2017-01-24 Thread Mauro Carvalho Chehab
Hi Sakari, Just returned this week from vacations. I'm reading my long e-mail backlog, starting from my main inbox... Em Mon, 2 Jan 2017 09:53:49 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Dec 19, 2016 at 07:46:55AM -0200, Mauro Carvalho Chehab wrote: > > Em Fri, 16 Dec 2016 17:07:23

Re: kernel bug 191891

2017-01-24 Thread Mauro Carvalho Chehab
Marc, I'm c/c the ML, as other people may be experiencing the very same issue. Em Sun, 8 Jan 2017 01:22:41 +0100 Marc Duponcheel escreveu: > Hi Mauro, > > Congratulations with your work on the kernel. Thanks! > > You may have noticed bugzilla kernel bug 191891. > > Initially I suspected co

[PATCH v2] [media] atmel-isc: add the isc pipeline function

2017-01-24 Thread Songjun Wu
Image Sensor Controller has an internal image processor. It can convert raw format to the other formats, like RGB565, YUV420P. A module parameter 'sensor_preferred' is used to enable or disable the pipeline function. Some v4l2 controls are added to tuning the image when the pipeline function is ena