Re: [RFC, v2, 10/11] vb2: dma-contig: Let drivers decide DMA attrs of MMAP and USERPTR bufs

2016-12-25 Thread Ricky Liang
Hi Laurent, On Fri, Dec 16, 2016 at 9:24 AM, Laurent Pinchart wrote: > From: Sakari Ailus > > The desirable DMA attributes are not generic for all devices using > Videobuf2 contiguous DMA ops. Let the drivers decide. > > This change also results in MMAP buffers always having an sg_table > (dma_s

cron job: media_tree daily build: ERRORS

2016-12-25 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Dec 26 05:00:17 CET 2016 media-tree git hash:c739c0a7c3c2472d7562b8f802cdce44d2597c8b media_build git

[PATCH 19/19] [media] uvc_video: Add some spaces for better code readability

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 19:00:29 +0100 Use space characters at some source code places according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 18/19] [media] uvc_video: Enclose an expression for the sizeof operator by parentheses

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 18:50:35 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: sizeof *ctrl should be sizeof(*ctrl) Thus fix the affected source code place. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_video.c | 2 +-

[PATCH 17/19] [media] uvc_video: Fix a typo in a comment line

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 18:42:58 +0100 The script "checkpatch.pl" pointed out that a word may be misspelled. Add a missing character there. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 16/19] [media] uvc_video: Adjust 18 checks for null pointers

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 18:26:21 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code pla

[PATCH 15/19] [media] uvc_video: Adjust one function call together with a variable assignment

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 18:00:39 +0100 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code place. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_video.c | 4 ++--

[PATCH 14/19] [media] uvc_video: Combine substrings for 22 messages

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 17:54:05 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines * Thus fix the affected source code places. * Improve indentation for passed parameters. Signed-off-by: Markus Elfring -

[PATCH 13/19] [media] uvc_video: Use kmalloc_array() in uvc_video_clock_init()

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 16:45:21 +0100 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software.

[PATCH 12/19] [media] uvc_driver: Move six assignments in uvc_parse_streaming()

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 16:25:57 +0100 Move the assignments for six local variables so that these statements will only be executed if memory allocations succeeded by this function. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_driver.c | 15 ++- 1

[PATCH 11/19] [media] uvc_driver: Delete an unnecessary variable initialisation in uvc_parse_streaming()

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 16:02:46 +0100 The local variable "streaming" will be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_driver.c | 2 +- 1 file changed, 1 in

[PATCH 10/19] [media] uvc_driver: Return -ENOMEM after a failed kzalloc() call in uvc_parse_streaming()

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 16:00:17 +0100 Use the return code "-ENOMEM" (instead of "-EINVAL") after a call of the function "kzalloc" failed here. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 09/19] [media] uvc_driver: Less function calls in uvc_parse_streaming() after error detection

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 15:45:31 +0100 The kfree() function was called in a few cases by the uvc_parse_streaming() function during error handling even if the passed data structure member contained a null pointer. Adjust jump targets according to the Linux coding style convent

[PATCH 08/19] [media] uvc_driver: Rename a jump label in uvc_scan_fallback()

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 10:57:12 +0100 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_driver.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/media/usb/uvc/

[PATCH 07/19] [media] uvc_driver: Rename a jump label in uvc_probe()

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 10:54:15 +0100 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_driver.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/media/u

[PATCH 06/19] [media] uvc_driver: Add some spaces for better code readability

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 10:37:17 +0100 Use space characters at some source code places according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_driver.c | 62 +++--- 1 file changed, 31 insert

[PATCH 05/19] [media] uvc_driver: Enclose 24 expressions for the sizeof operator by parentheses

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 10:05:05 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" pointed information out like the following. WARNING: sizeof … should be sizeof(…) Thus fix the affected source code pla

[PATCH 04/19] [media] uvc_driver: Adjust 28 checks for null pointers

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 09:40:21 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code pla

[PATCH 03/19] [media] uvc_driver: Adjust three function calls together with a variable assignment

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 08:05:58 +0100 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_driver.c | 10 +

[PATCH 02/19] [media] uvc_driver: Combine substrings for 48 messages

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 07:41:29 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines * Thus fix the affected source code places. * Improve indentation for passed parameters. Signed-off-by: Markus Elfring -

[PATCH 01/19] [media] uvc_driver: Use kmalloc_array() in uvc_simplify_fraction()

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Dec 2016 21:10:16 +0100 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software.

[PATCH 00/19] [media] USB Video Class driver: Fine-tuning for several function implementations

2016-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 25 Dec 2016 19:23:32 +0100 Several update suggestions were taken into account from static source code analysis. Markus Elfring (19): uvc_driver: Use kmalloc_array() in uvc_simplify_fraction() uvc_driver: Combine substrings for 48 messages uvc_driver: Adjust

[PATCH] [media] cx23885: attach md88ds3103 driver via i2c_client for DVBSky S952

2016-12-25 Thread Niels Ole Salscheider
With this patch we use the new style to attach the frontend. Signed-off-by: Niels Ole Salscheider --- drivers/media/pci/cx23885/cx23885-dvb.c | 54 +++-- 1 file changed, 32 insertions(+), 22 deletions(-) diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers