Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

On Mon, 24 Oct 2016, Mauro Carvalho Chehab wrote: > Em Mon, 24 Oct 2016 23:28:44 +0100 > Andrey Utkin escreveu: > > > On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > > > From: Markus Elfring > > > Date: Mon, 24 Oct 2016 22:08:47 +0200 > > > > > > * Multiplications for the

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Oct 25 05:00:15 CEST 2016 media-tree git hash:bd676c0c04ec94bd830b9192e2c33f2c4532278d media_build gi

Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

Em Mon, 24 Oct 2016 23:28:44 +0100 Andrey Utkin escreveu: > On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Mon, 24 Oct 2016 22:08:47 +0200 > > > > * Multiplications for the size determination of memory allocations > > indicated that array

Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 24 Oct 2016 22:08:47 +0200 > > * Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. > Thus use the corresponding fun

[PATCH 3/3] [media] au0828-video: Move two assignments in au0828_init_isoc()

From: Markus Elfring Date: Mon, 24 Oct 2016 22:44:02 +0200 Move the assignment for the data structure members "isoc_copy" and "num_bufs" behind the source code for memory allocations by this function. Signed-off-by: Markus Elfring --- drivers/media/usb/au0828/au0828-video.c | 5 ++--- 1 file c

[PATCH 2/3] [media] au0828-video: Delete three error messages for a failed memory allocation

From: Markus Elfring Date: Mon, 24 Oct 2016 22:28:03 +0200 Omit extra messages for a memory allocation failure in this function. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/media/usb/au0828/au08

[PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

From: Markus Elfring Date: Mon, 24 Oct 2016 22:08:47 +0200 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software.

[PATCH 0/3] [media] au0828-video: Fine-tuning for au0828_init_isoc()

From: Markus Elfring Date: Mon, 24 Oct 2016 22:52:10 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use kcalloc() Delete three error messages for a failed memory allocation Move two assignments drivers/media/usb/au0828/au0828-

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Mon, Oct 24, 2016 at 05:32:33PM -0200, Mauro Carvalho Chehab wrote: > Em Wed, 28 Sep 2016 07:21:44 +0200 > khal...@piap.pl (Krzysztof Hałasa) escreveu: > > > Andrey Utkin writes: > > > > > Lockup happens only on 6010. In provided log you can see that 6110 > > > passes just fine right before 6

Re: cron job: media_tree daily build: ERRORS

I've applied this patch to my smatch. Thanks for looking into this. Regards, Hans On 10/24/2016 10:21 PM, Mauro Carvalho Chehab wrote: > Em Mon, 24 Oct 2016 06:03:16 +0200 > "Hans Verkuil" escreveu: > >> This message is generated daily by a cron job that builds media_tree for >> the ke

Re: [PATCH -next] staging: media: stih-cec: remove unused including

Em Sun, 2 Oct 2016 16:55:05 +0200 Greg Kroah-Hartman escreveu: > On Wed, Sep 28, 2016 at 03:13:13PM +, Wei Yongjun wrote: > > From: Wei Yongjun > > > > Remove including that don't need it. > > > > Signed-off-by: Wei Yongjun > > Acked-by: Benjamin Gaignard > > --- > > drivers/staging/me

Re: cron job: media_tree daily build: ERRORS

Em Mon, 24 Oct 2016 06:03:16 +0200 "Hans Verkuil" escreveu: > This message is generated daily by a cron job that builds media_tree for > the kernels and architectures in the list below. > > Results of the daily build of media_tree: ... > sparse: WARNINGS > > Detailed results are available her

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

Em Wed, 28 Sep 2016 07:21:44 +0200 khal...@piap.pl (Krzysztof Hałasa) escreveu: > Andrey Utkin writes: > > > Lockup happens only on 6010. In provided log you can see that 6110 > > passes just fine right before 6010. Also if 6010 PCI ID is removed from > > solo6x10 driver's devices list, the free

Re: [Patch 20/35] media: ti-vpe: vpe: Added MODULE_DEVICE_TABLE hint

Hello Benoit, On Wed, Sep 28, 2016 at 5:22 PM, Benoit Parrot wrote: > ti_vpe module currently does not get loaded automatically. > Added MODULE_DEVICE_TABLE hint to the driver to assist. > > Signed-off-by: Benoit Parrot > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier -- To un

Re: [Patch 05/35] media: ti-vpe: Use line average de-interlacing for first 2 frames

Hans Verkuil wrote on Mon [2016-Oct-17 16:14:35 +0200]: > On 09/28/2016 11:20 PM, Benoit Parrot wrote: > > From: Archit Taneja > > > > For n input fields, the VPE de-interlacer creates n - 2 progressive frames. > > That's confusing. I think you mean '(n / 2) - 1'? Two fields make one frame, >

Re: [Patch 00/35] media: ti-vpe: fixes and enhancements

Hans, Thank you for taking the time to review my patches. I'll update the patch set relating to your comments and submit a v2 shortly. Regards Benoit Hans Verkuil wrote on Mon [2016-Oct-17 16:35:01 +0200]: > On 09/28/2016 11:16 PM, Benoit Parrot wrote: > > This patch series is to publish a numb

Re: [Patch 06/35] media: ti-vpe: vpe: Do not perform job transaction atomically

Hans Verkuil wrote on Mon [2016-Oct-17 16:17:15 +0200]: > On 09/28/2016 11:20 PM, Benoit Parrot wrote: > > From: Nikhil Devshatwar > > > > Current VPE driver does not start the job until all the buffers for > > a transaction are not queued. When running in multiple context, this might > > I thi

Re: [Patch 01/35] media: ti-vpe: vpdma: Make vpdma library into its own module

Hans, Thanks for the review. Hans Verkuil wrote on Mon [2016-Oct-17 16:08:55 +0200]: > On 09/28/2016 11:16 PM, Benoit Parrot wrote: > > The VPDMA (Video Port DMA) as found in devices such as DRA7xx is > > used for both the Video Processing Engine (VPE) and the Video Input > > Port (VIP). > > >

[PATCH v2 1/2] [media] videobuf2-dc: Move vb2_dc_get_base_sgt() above mmap callbacks

This patch moves vb2_dc_get_base_sgt() function above mmap buffers callbacks, particularly vb2_dc_alloc() and vb2_dc_mmap() from where it will be called for cacheable MMAP support introduced in the next patch. Signed-off-by: Thierry Escande --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 44

[PATCH v2 2/2] [media] videobuf2-dc: Support cacheable MMAP

From: Heng-Ruey Hsu DMA allocations for MMAP type are uncached by default. But for some cases, CPU has to access the buffers. ie: memcpy for format converter. Supporting cacheable MMAP improves huge performance. This patch enables cacheable memory for DMA coherent allocator in mmap buffer alloca

[PATCH v2 0/2] [media] videobuf2-dc: Add support for cacheable MMAP

Hi, This series adds support for cacheable MMAP in DMA coherent allocator. The first patch moves the vb2_dc_get_base_sgt() function above mmap callbacks for calls introduced by the second patch. This avoids a forward declaration. Changes in v2: - Put function move in a separate patch - Added com

Re: [PATCH] [media] si2157: Improve support Si2158-A20 tuner

Em Thu, 4 Aug 2016 10:54:02 +0300 Oleh Kravchenko escreveu: > Signed-off-by: Oleh Kravchenko What's the status of this patch? Is it still valid? If so, please re-send with a proper description. e. g. what is it improving? why? how? Regards, Mauro > --- > drivers/media/tuners/si2157.c |

Re: [PATCH 2/4] mtk_mdp_vpu: remove a double unlock at the error path

On Fri, 2016-10-21 at 11:59 -0200, Mauro Carvalho Chehab wrote: > As warned by smatch: > drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c:98 mtk_mdp_vpu_send_msg() > error: double unlock 'mutex:&ctx->mdp_dev->vpulock' > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/platform/mtk

Re: [PATCH 3/4] mtk_mdp_m2m: remove an unused struct

On Fri, 2016-10-21 at 11:59 -0200, Mauro Carvalho Chehab wrote: > drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c:48:33: warning: > ‘mtk_mdp_size_align’ defined but not used [-Wunused-variable] > static struct mtk_mdp_pix_align mtk_mdp_size_align = { > ^~

Re: [PATCH v4 3/4] v4l: Add Renesas R-Car FDP1 Driver

Hi Kieran, On Monday 24 Oct 2016 12:21:39 Kieran Bingham wrote: > Hi Laurent, > > Thanks for your reworking and improvements here. > > The documentation additions look good. > > Only one grammar fixup found inline in the struct fdp1_ctx which isn't > critical (and could have been from my origin

[PATCH v4.1 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings

From: Kieran Bingham The FDP1 is a de-interlacing module which converts interlaced video to progressive video. It is also capable of performing pixel format conversion between YCbCr/YUV formats and RGB formats. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart Acked-by: Rob Herring

Re: [PATCH 4/4] mtk-mdp: fix compilation warnings if !DEBUG

On Fri, 2016-10-21 at 11:59 -0200, Mauro Carvalho Chehab wrote: > The mtk_mdp_dbg() is empty if !DEBUG. This causes the following > warnings: > > drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c: In function > ‘mtk_mdp_try_fmt_mplane’: > drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c:231:52

Re: [PATCH 1/4] mtk_mdp_vpu: fix build with COMPILE_TEST for 32 bits

Hi Mauro, This issue has been fixed by the patch below and merged in media tree, and also signed by you. Is it duplicate? commit 37bf7e34ecc817ce6b8278588aeb22aab5635e1c Author: Minghsiu Tsai Date: Mon Sep 19 03:34:42 2016 -0300 [media] media: mtk-mdp: fix build warning in arch x86

Re: [PATCH v4 3/4] v4l: Add Renesas R-Car FDP1 Driver

Hi Laurent, Thanks for your reworking and improvements here. The documentation additions look good. Only one grammar fixup found inline in the struct fdp1_ctx which isn't critical (and could have been from my original submission), so don't worry about it unless there ends up being another respin

Re: [PATCH v4 4/4] arm64: dts: renesas: r8a7796: Add FDP1 instance

On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart wrote: > The r8a7796 has a single FDP1 instance. > > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m

©Faculty/ Password Update

Help Desk Your password will soon expire To keep your password active. Click Here to update Sincerely, IT-Service Help Desk -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

Hi Mauro, On Mon, 2016-10-24 at 07:05 -0200, Mauro Carvalho Chehab wrote: > Em Mon, 24 Oct 2016 11:22:08 +0800 > Tiffany Lin escreveu: > > > Hi Mauro, > > > > On Fri, 2016-10-21 at 11:01 -0200, Mauro Carvalho Chehab wrote: > > > Em Fri, 2 Sep 2016 20:19:54 +0800 > > > Tiffany Lin escreveu: > >

Re: [PATCH v4 4/4] arm64: dts: renesas: r8a7796: Add FDP1 instance

Hi Laurent, On 24/10/16 10:03, Laurent Pinchart wrote: > The r8a7796 has a single FDP1 instance. > > Signed-off-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi > b/

RE: [RFC 5/5] doc_rst: media: New SDR formats SC16, SC18 & SC20

Hi Laurent, Thank you for the review comments. > On Wednesday 12 Oct 2016 15:10:29 Ramesh Shanmugasundaram wrote: > > This patch adds documentation for the three new SDR formats > > > > V4L2_SDR_FMT_SCU16BE > > V4L2_SDR_FMT_SCU18BE > > V4L2_SDR_FMT_SCU20BE > > > > Signed-off-by: Ramesh Shanmugasu

Re: [PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings

Hi Laurent, On Mon, Oct 24, 2016 at 11:46 AM, Laurent Pinchart wrote: > On Monday 24 Oct 2016 11:14:11 Geert Uytterhoeven wrote: >> On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart wrote: >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt >> > +Optional prop

Re: [PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings

Hi Geert, On Monday 24 Oct 2016 11:14:11 Geert Uytterhoeven wrote: > On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart wrote: > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt > > @@ -0,0 +1,33 @@ > > +Renesas R-Car Fine Display Processor (FDP1) > > +---

Re: Documentation/media/uapi/cec/ sporadically unnecessarily rebuilding

Em Mon, 24 Oct 2016 12:04:31 +0300 Jani Nikula escreveu: > I think I saw some of this in the past [1], but then couldn't reproduce > it after all. Now I'm seeing it again. Sporadically > Documentation/media/uapi/cec/ gets rebuilt on successive runs of make > htmldocs, even when nothing has change

Re: [PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings

On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart wrote: > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt > @@ -0,0 +1,33 @@ > +Renesas R-Car Fine Display Processor (FDP1) > +--- > + > +The FDP1 is a de-interlacing module whi

Re: [PATCH v3 02/10] v4l: ctrls: Add deinterlacing mode control

Hi Hans, On Friday 21 Oct 2016 16:34:50 Hans Verkuil wrote: > On 09/08/16 00:25, Laurent Pinchart wrote: > > The menu control selects the operation mode of a video deinterlacer. The > > menu entries are driver specific. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > Documentation/

Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

Em Mon, 24 Oct 2016 11:22:08 +0800 Tiffany Lin escreveu: > Hi Mauro, > > On Fri, 2016-10-21 at 11:01 -0200, Mauro Carvalho Chehab wrote: > > Em Fri, 2 Sep 2016 20:19:54 +0800 > > Tiffany Lin escreveu: > > > > > Add v4l2 layer decoder driver for MT8173 > > > > > > Signed-off-by: Tiffany Lin

[PATCH v4 0/4] v4l: platform: Add Renesas R-Car FDP1 Driver

Hello, Here's the fourth version of the Renesas R-Car FDP1 driver. The FDP1 (Fine Display Processor) is a hardware memory-to-memory de-interlacer device, with capability to convert from various YCbCr/YUV formats to both YCbCr/YUV and RGB formats at the same time as converting interlaced content t

[PATCH v4 1/4] v4l: ctrls: Add deinterlacing mode control

The menu control selects the operation mode of a video deinterlacer. The menu entries are driver specific. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Acked-by: Hans Verkuil --- Changes since v3: - Link the deinterlacing mode control to driver-specific documentation --- Docume

Documentation/media/uapi/cec/ sporadically unnecessarily rebuilding

I think I saw some of this in the past [1], but then couldn't reproduce it after all. Now I'm seeing it again. Sporadically Documentation/media/uapi/cec/ gets rebuilt on successive runs of make htmldocs, even when nothing has changed. Output of 'make SPHINXOPTS="-v -v" htmldocs' attached for both

[PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings

From: Kieran Bingham The FDP1 is a de-interlacing module which converts interlaced video to progressive video. It is also capable of performing pixel format conversion between YCbCr/YUV formats and RGB formats. Reviewed-by: Laurent Pinchart Acked-by: Rob Herring Signed-off-by: Kieran Bingham

[PATCH v4 4/4] arm64: dts: renesas: r8a7796: Add FDP1 instance

The r8a7796 has a single FDP1 instance. Signed-off-by: Laurent Pinchart --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index 9217da983525..fbec7a29121a

[PATCH v4 3/4] v4l: Add Renesas R-Car FDP1 Driver

From: Kieran Bingham The FDP1 driver performs advanced de-interlacing on a memory 2 memory based video stream, and supports conversion from YCbCr/YUV to RGB pixel formats Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- Changes since v3: - Squas

Re: [patch] [media] st-hva: fix some error handling in hva_hw_probe()

Thanks, Acked-by: Jean-Christophe Trotin On 10/14/2016 09:32 AM, Dan Carpenter wrote: > The devm_ioremap_resource() returns error pointers, never NULL. The > platform_get_resource() returns NULL on error, never error pointers. > The error code needs to be set, as well. The current code returns

Re: [PATCH v4] [media] vb2: Add support for capture_dma_bidirectional queue flag

Hi Thierry, On 2016-10-24 09:30, Thierry Escande wrote: From: Pawel Osciak When this flag is set for CAPTURE queues by the driver on calling vb2_queue_init(), it forces the buffers on the queue to be allocated/mapped with DMA_BIDIRECTIONAL direction flag instead of DMA_FROM_DEVICE. This allow

Re: [PATCH] [media] st-hva: fix a copy-and-paste variable name error

Thanks (and sorry for the delay of my answer), Acked-by: Jean-Christophe Trotin On 09/19/2016 08:19 AM, Colin King wrote: > From: Colin Ian King > > The second check for an error on hva->lmi_err_reg appears > to be a copy-and-paste error, it should be hva->emi_err_reg > instead. > > Signed-off-

[PATCH v4] [media] vb2: Add support for capture_dma_bidirectional queue flag

From: Pawel Osciak When this flag is set for CAPTURE queues by the driver on calling vb2_queue_init(), it forces the buffers on the queue to be allocated/mapped with DMA_BIDIRECTIONAL direction flag instead of DMA_FROM_DEVICE. This allows the device not only to write to the buffers, but also read

Re: [PATCH 1/5] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages

Hi Tvrtko, On 2016-10-21 16:11, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Scatterlist entries have an unsigned int for the offset so correct the sg_alloc_table_from_pages function accordingly. Since these are offsets withing a page, unsigned int is wide enough. Also converts callers which

Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

On Mon, Oct 24, 2016 at 06:57:25AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin writes: > > > --- a/drivers/media/pci/solo6x10/solo6x10.h > > +++ b/drivers/media/pci/solo6x10/solo6x10.h > > @@ -284,7 +284,10 @@ static inline u32 solo_reg_read(struct solo_dev > > *solo_dev, int reg) > > static