cron job: media_tree daily build: ERRORS

2016-10-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Oct 20 05:00:15 CEST 2016 media-tree git hash:43ea43b9d8b27b7acd443ec59319faa3cdb8a616 media_build gi

Re: [PATCH v2 53/58] firewire: don't break long lines

2016-10-19 Thread Stefan Richter
On Oct 19 Mauro Carvalho Chehab wrote: > Em Wed, 19 Oct 2016 08:03:01 +0900 > Takashi Sakamoto escreveu: > > A structure for firedtv (struct firedtv) has a member for a pointer to > > struct device. In this case, we can use dev_dbg() for debug printing. [...] > Stefan, > > Would the above be OK f

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2016-10-19 Thread Sakari Ailus
On Fri, Oct 14, 2016 at 07:34:20PM +0200, Philipp Zabel wrote: > Hi, > > the second round removes the prepare_stream callback and instead lets the > intermediate subdevices propagate s_stream calls to their sources rather > than individually calling s_stream on each subdevice from the bridge drive

Re: [PATCH 1/2] [media] vb2: Store dma_dir in vb2_queue

2016-10-19 Thread Sakari Ailus
Hi Thierry, On Wed, Oct 19, 2016 at 10:24:16AM +0200, Thierry Escande wrote: > From: Pawel Osciak > > Store dma_dir in struct vb2_queue and reuse it, instead of recalculating > it each time. > > Signed-off-by: Pawel Osciak > Tested-by: Pawel Osciak > Reviewed-by: Tomasz Figa > Reviewed-by: O

Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix indentation

2016-10-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Oct 2016 22:47:13 +0200 Jean-Baptiste Abbadie escreveu: > Align multiple lines statement with parentheses Looks OK to me. Greg, do you want to pick it on your tree or do you prefer if I pick myself? If you prefer to pick it: Acked-by: Mauro Carvalho Chehab > > Signed-off-by: Jean

Re: [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice

2016-10-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Oct 2016 22:47:14 +0200 Jean-Baptiste Abbadie escreveu: > Removes the superfluous statement about writing to the FSF in the GPL > notice Looks OK to me. Greg, do you want to pick it on your tree or do you prefer if I pick myself? If you prefer to pick it: Acked-by: Mauro Carvalho Ch

Re: [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions

2016-10-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Oct 2016 22:47:12 +0200 Jean-Baptiste Abbadie escreveu: You should run get_maintainers.pl and check whomever submitted the driver, in order to get review. In particular, this driver looks to be submitted by Hans, although I guess he didn't authored: commit 899127b67df098e6d878f27be05

[PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions

2016-10-19 Thread Jean-Baptiste Abbadie
This replaces the S_* style permissions by numbers for the __ATTR macros Signed-off-by: Jean-Baptiste Abbadie --- drivers/staging/media/bcm2048/radio-bcm2048.c | 58 +-- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bc

[PATCH 2/3] Staging: media: radio-bcm2048: Fix indentation

2016-10-19 Thread Jean-Baptiste Abbadie
Align multiple lines statement with parentheses Signed-off-by: Jean-Baptiste Abbadie --- drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2

[PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice

2016-10-19 Thread Jean-Baptiste Abbadie
Removes the superfluous statement about writing to the FSF in the GPL notice Signed-off-by: Jean-Baptiste Abbadie --- drivers/staging/media/bcm2048/radio-bcm2048.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm204

[PATCH 0/3] media: radio-bcm2048: multiple small cleanups

2016-10-19 Thread Jean-Baptiste Abbadie
Hello, This is a series of minor patches to fix checkpatch.pl issues. Regards, Jean-Baptiste Jean-Baptiste Abbadie (3): Staging: media: radio-bcm2048: Fix symbolic permissions Staging: media: radio-bcm2048: Fix indentation Staging: media: radio-bcm2048: Remove FSF address from GPL notice

Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues

2016-10-19 Thread Johannes Stezenbach
On Wed, Oct 19, 2016 at 07:17:12PM +0200, Jean-Baptiste Abbadie wrote: > Signed-off-by: Jean-Baptiste Abbadie > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c > b/driv

Re: [PATCH v2 08/21] [media] imx: Add i.MX IPUv3 capture driver

2016-10-19 Thread Marek Vasut
On 10/19/2016 06:22 PM, Jack Mitchell wrote: > Hi Philipp, > > On 17/10/16 13:12, Philipp Zabel wrote: >> Hi Jack, >> >> Am Montag, den 17.10.2016, 12:32 +0100 schrieb Jack Mitchell: >>> Hi Philipp, >>> >>> I'm looking at how I would enable a parallel greyscale camera using this >>> set of drivers

Re: em28xx WinTV dualHD in Raspbian

2016-10-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Oct 2016 20:50:09 +0200 escreveu: > > Based on this log: > > > > Oct 18 23:08:01 mediapi kernel: [ 7590.369200] em28xx_dvb: disagrees about > > version of symbol dvb_dmxdev_init Oct 18 23:08:01 mediapi kernel: [ > > 7590.369228] em28xx_dvb: Unknown symbol dvb_dmxdev_init (err -22) >

AW: em28xx WinTV dualHD in Raspbian

2016-10-19 Thread ps00de
> Based on this log: > > Oct 18 23:08:01 mediapi kernel: [ 7590.369200] em28xx_dvb: disagrees about > version of symbol dvb_dmxdev_init Oct 18 23:08:01 mediapi kernel: [ > 7590.369228] em28xx_dvb: Unknown symbol dvb_dmxdev_init (err -22) > > It seems you messed the modules install or you have th

Re: em28xx WinTV dualHD in Raspbian

2016-10-19 Thread ps00de
> Based on this log: > > Oct 18 23:08:01 mediapi kernel: [ 7590.369200] em28xx_dvb: disagrees about > version of symbol dvb_dmxdev_init Oct 18 23:08:01 mediapi kernel: [ > 7590.369228] em28xx_dvb: Unknown symbol dvb_dmxdev_init (err -22) > > it seems you messed the modules install or you have t

Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues

2016-10-19 Thread Greg Kroah-Hartman
On Wed, Oct 19, 2016 at 08:10:25PM +0200, Jean-Baptiste Abbadie wrote: > On 19/10/16 19:51, Greg Kroah-Hartman wrote: > > I can't take a patch with no changelog text, sorry. > Hello, > > Should I add the changelog in the same thread or start a new thread ? Whole new patch please. -- To unsubscrib

Re: [PATCH v2 54/58] i2c: don't break long lines

2016-10-19 Thread Lad, Prabhakar
Hi Mauro, Thanks for the patch. On Tue, Oct 18, 2016 at 9:46 PM, Mauro Carvalho Chehab wrote: > Due to the 80-cols restrictions, and latter due to checkpatch > warnings, several strings were broken into multiple lines. This > is not considered a good practice anymore, as it makes harder > to gr

Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues

2016-10-19 Thread Jean-Baptiste Abbadie
On 19/10/16 19:51, Greg Kroah-Hartman wrote: I can't take a patch with no changelog text, sorry. Hello, Should I add the changelog in the same thread or start a new thread ? Sorry, for the mistakes that's my first submitted patch. Regards, Jean-Baptiste -- To unsubscribe from this list: sen

Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues

2016-10-19 Thread Greg Kroah-Hartman
On Wed, Oct 19, 2016 at 07:17:12PM +0200, Jean-Baptiste Abbadie wrote: > Signed-off-by: Jean-Baptiste Abbadie I can't take a patch with no changelog text, sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-19 Thread Dave Hansen
On 10/19/2016 10:01 AM, Michal Hocko wrote: > The question I had earlier was whether this has to be an explicit FOLL > flag used by g-u-p users or we can just use it internally when mm != > current->mm The reason I chose not to do that was that deferred work gets run under a basically random 'curr

[PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice

2016-10-19 Thread Jean-Baptiste Abbadie
Signed-off-by: Jean-Baptiste Abbadie --- drivers/staging/media/bcm2048/radio-bcm2048.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index f66bea631e8e..607dd5285149 100644 --- a/drivers/stagin

[PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions

2016-10-19 Thread Jean-Baptiste Abbadie
This is a series of minor patch to fix checkpatch.pl issues. Signed-off-by: Jean-Baptiste Abbadie --- drivers/staging/media/bcm2048/radio-bcm2048.c | 58 +-- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/d

[PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues

2016-10-19 Thread Jean-Baptiste Abbadie
Signed-off-by: Jean-Baptiste Abbadie --- drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index 188d045d44ad..f66bea631e8e 100644 ---

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-19 Thread Michal Hocko
On Wed 19-10-16 09:49:43, Dave Hansen wrote: > On 10/19/2016 02:07 AM, Michal Hocko wrote: > > On Wed 19-10-16 09:58:15, Lorenzo Stoakes wrote: > >> On Tue, Oct 18, 2016 at 05:30:50PM +0200, Michal Hocko wrote: > >>> I am wondering whether we can go further. E.g. it is not really clear to > >>> me

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-19 Thread Dave Hansen
On 10/19/2016 02:07 AM, Michal Hocko wrote: > On Wed 19-10-16 09:58:15, Lorenzo Stoakes wrote: >> On Tue, Oct 18, 2016 at 05:30:50PM +0200, Michal Hocko wrote: >>> I am wondering whether we can go further. E.g. it is not really clear to >>> me whether we need an explicit FOLL_REMOTE when we can in

[PATCH 2/2] [media] vb2: Add support for capture_dma_bidirectional queue flag

2016-10-19 Thread Thierry Escande
From: Pawel Osciak When this flag is set for CAPTURE queues by the driver on calling vb2_queue_init(), it forces the buffers on the queue to be allocated/mapped with DMA_BIDIRECTIONAL direction flag, instead of DMA_FROM_DEVICE. This allows the device not only to write to the buffers, but also rea

[PATCH 1/2] [media] vb2: Store dma_dir in vb2_queue

2016-10-19 Thread Thierry Escande
From: Pawel Osciak Store dma_dir in struct vb2_queue and reuse it, instead of recalculating it each time. Signed-off-by: Pawel Osciak Tested-by: Pawel Osciak Reviewed-by: Tomasz Figa Reviewed-by: Owen Lin Signed-off-by: Thierry Escande --- drivers/media/v4l2-core/videobuf2-core.c | 12 +++-

Re: [PATCH 05/10] mm: replace get_vaddr_frames() write/force parameters with gup_flags

2016-10-19 Thread Jan Kara
On Thu 13-10-16 01:20:15, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_vaddr_frames() and > replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit > in callers as use of this flag can result in surprising behaviour (and hence > bugs

Re: [PATCH v2 2/2] ARM: dts: koelsch: add HDMI input

2016-10-19 Thread Geert Uytterhoeven
On Tue, Oct 18, 2016 at 5:01 PM, Ulrich Hecht wrote: > From: Hans Verkuil > > Add support in the dts for the HDMI input. Based on the Lager dts > patch from Ultich Hecht. Ulrich ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

Re: [PATCH 4/5] [media] winbond-cir: One variable and its check less in wbcir_shutdown() after error detection

2016-10-19 Thread SF Markus Elfring
+ /* Set CEIR_EN */ + wbcir_set_bits(data->wbase + WBCIR_REG_WCEIR_CTL, 0x01, 0x01); +set_irqmask: /* * ACPI will set the HW disable bit for SP3 which means that the * output signals are left in an undefined state which may cause @@ -876,6 +858,14 @@ wbcir_shutdow

Re: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

2016-10-19 Thread SF Markus Elfring
>> Move the setting for the local variables "mask", "match" and "rc6_csl" >> behind the source code for a condition check by this function >> at the beginning. > > Again, I can't see what the point is? * How do you think about to set these variables only after the initial check succeded? * Do

Re: [PATCH v2 08/21] [media] imx: Add i.MX IPUv3 capture driver

2016-10-19 Thread Jack Mitchell
Hi Philipp, On 17/10/16 13:12, Philipp Zabel wrote: Hi Jack, Am Montag, den 17.10.2016, 12:32 +0100 schrieb Jack Mitchell: Hi Philipp, I'm looking at how I would enable a parallel greyscale camera using this set of drivers and am a little bit confused. Do you have an example somewhere of a de

[FYI] Very limited time for code review this week and next week

2016-10-19 Thread Hans Verkuil
Hi all, Real-life (tm) is interfering with media development this week and next week. So I doubt I'll have much opportunity to do code reviews during that period. Just so people are aware of this. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media"

Re: [media] winbond-cir: Move a variable assignment in wbcir_tx()

2016-10-19 Thread SF Markus Elfring
>> * How do you think about to avoid a variable assignment in case >> that this memory allocation failed anyhow? > > There is no memory allocation that can fail at this point. Do you really know the failure probability for a call of the function "kmalloc" (within the function "wbcir_tx") under al

Re: [media] winbond-cir: Move a variable assignment in two functions

2016-10-19 Thread SF Markus Elfring
>> Move the assignment for the local variable "data" behind the source code >> for condition checks by these functions. > > Why? * Would you like to set these variables only after the initial check succeeded? * Do you care for data access locality also in these cases? Regards, Markus -- To u

Re: [media] winbond-cir: Move a variable assignment in wbcir_tx()

2016-10-19 Thread SF Markus Elfring
>> Move the assignment for the local variable "data" behind the source code >> for a memory allocation by this function. > > Sorry, I can't see what the point is? * How do you think about to avoid a variable assignment in case that this memory allocation failed anyhow? * Do you care for data a

[PATCH 0/2] [media] DMA direction support in vb2_queue

2016-10-19 Thread Thierry Escande
Hi, This series adds a dma_dir field to the vb2_queue structure in order to store the DMA direction once for all in vb2_queue_init(); It also adds a new capture_dma_bidirectional flag to the vb2_queue structure allowing the hardware to read from the CAPTURE buffer. This flag is ignored for OUTPUT

Re: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

2016-10-19 Thread SF Markus Elfring
Move the setting for the local variables "mask", "match" and "rc6_csl" behind the source code for a condition check by this function at the beginning. >>> >>> Again, I can't see what the point is? >> >> * How do you think about to set these variables only after the initial >> check s

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-19 Thread Michal Hocko
On Wed 19-10-16 09:58:15, Lorenzo Stoakes wrote: > On Tue, Oct 18, 2016 at 05:30:50PM +0200, Michal Hocko wrote: > > I am wondering whether we can go further. E.g. it is not really clear to > > me whether we need an explicit FOLL_REMOTE when we can in fact check > > mm != current->mm and imply that

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

2016-10-19 Thread Michal Hocko
On Wed 19-10-16 09:59:03, Jan Kara wrote: > On Thu 13-10-16 01:20:18, Lorenzo Stoakes wrote: > > This patch removes the write parameter from __access_remote_vm() and > > replaces it > > with a gup_flags parameter as use of this function previously _implied_ > > FOLL_FORCE, whereas after this patch

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

2016-10-19 Thread Michal Hocko
On Wed 19-10-16 10:06:46, Lorenzo Stoakes wrote: > On Wed, Oct 19, 2016 at 10:52:05AM +0200, Michal Hocko wrote: > > yes this is the desirable and expected behavior. > > > > > wonder if this is desirable behaviour or whether this ought to be limited > > > to > > > ptrace system calls. Regardless,

Re: [PATCH v2 08/58] cx23885: don't break long lines

2016-10-19 Thread Hans Verkuil
On 10/18/2016 10:45 PM, Mauro Carvalho Chehab wrote: > Due to the 80-cols restrictions, and latter due to checkpatch > warnings, several strings were broken into multiple lines. This > is not considered a good practice anymore, as it makes harder > to grep for strings at the source code. > > As we

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-19 Thread Lorenzo Stoakes
On Tue, Oct 18, 2016 at 05:30:50PM +0200, Michal Hocko wrote: > I am wondering whether we can go further. E.g. it is not really clear to > me whether we need an explicit FOLL_REMOTE when we can in fact check > mm != current->mm and imply that. Maybe there are some contexts which > wouldn't work, I

Re: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

2016-10-19 Thread David Härdeman
October 19, 2016 3:38 PM, "SF Markus Elfring" wrote: >>> Move the setting for the local variables "mask", "match" and "rc6_csl" >>> behind the source code for a condition check by this function >>> at the beginning. >> >> Again, I can't see what the point is? > > * How do you think about to set

Re: [PATCH 2/5] [media] winbond-cir: Move a variable assignment in wbcir_tx()

2016-10-19 Thread David Härdeman
October 14, 2016 1:42 PM, "SF Markus Elfring" wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 07:34:46 +0200 > > Move the assignment for the local variable "data" behind the source code > for a memory allocation by this function. Sorry, I can't see what the point is? > Signed-off-by:

Re: em28xx WinTV dualHD in Raspbian

2016-10-19 Thread Mauro Carvalho Chehab
Em Tue, 18 Oct 2016 23:55:04 +0200 escreveu: > Hi there, > > I am running an updated raspbian image with kernel 4.4.23-v7+, matching > linux-headers-4.4.23-v7+_4.4.23-v7+-2_armhf from here: > https://www.niksula.hut.fi/~mhiienka/Rpi/linux-headers-rpi/ and > dvb-demod-si2168-b40-01.fw (see linuxt

Re: [PATCH 1/5] [media] winbond-cir: Use kmalloc_array() in wbcir_tx()

2016-10-19 Thread David Härdeman
October 14, 2016 1:41 PM, "SF Markus Elfring" wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 07:19:00 +0200 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc

Re: [PATCH v6 1/2] media: i2c/ov5645: add the device tree binding document

2016-10-19 Thread Laurent Pinchart
Hi Todor, On Wednesday 19 Oct 2016 12:14:55 Todor Tomov wrote: > On 10/19/2016 11:49 AM, Laurent Pinchart wrote: > > On Friday 14 Oct 2016 15:01:08 Todor Tomov wrote: > >> On 09/08/2016 03:22 PM, Laurent Pinchart wrote: > >>> On Thursday 08 Sep 2016 12:13:54 Todor Tomov wrote: > Add the docum

Re: [PATCH 2/2] [media] vb2: Add support for use_dma_bidirectional queue flag

2016-10-19 Thread Sakari Ailus
On Tue, Oct 18, 2016 at 06:08:53PM +0200, Thierry Escande wrote: > >#define vb2_dma_dir(q) \ ^ VB2_DMA_DIR(), as most of our other macros use capitals as well. -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

2016-10-19 Thread Jan Kara
On Thu 13-10-16 01:20:14, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages_locked() > and replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit in callers as use of this flag can result in surprising behaviour > (and > hence

Re: [PATCH 5/5] [media] winbond-cir: Move a variable assignment in two functions

2016-10-19 Thread David Härdeman
October 14, 2016 1:45 PM, "SF Markus Elfring" wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 13:13:11 +0200 > > Move the assignment for the local variable "data" behind the source code > for condition checks by these functions. Why? > Signed-off-by: Markus Elfring > --- > drivers/med

Re: [PATCH 4/5] [media] winbond-cir: One variable and its check less in wbcir_shutdown() after error detection

2016-10-19 Thread David Härdeman
October 15, 2016 3:30 PM, "Sean Young" wrote: > On Fri, Oct 14, 2016 at 01:44:02PM +0200, SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Fri, 14 Oct 2016 12:48:41 +0200 >> >> The local variable "do_wake" was set to "false" after an invalid system >> setting was detected so that a b

Re: [PATCH 4/5] [media] winbond-cir: One variable and its check less in wbcir_shutdown() after error detection

2016-10-19 Thread David Härdeman
October 15, 2016 6:42 PM, "SF Markus Elfring" wrote: >>> + /* Set CEIR_EN */ >>> + wbcir_set_bits(data->wbase + WBCIR_REG_WCEIR_CTL, 0x01, 0x01); >>> +set_irqmask: >>> /* >>> * ACPI will set the HW disable bit for SP3 which means that the >>> * output signals are left in an undefined state which

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

2016-10-19 Thread Lorenzo Stoakes
On Wed, Oct 19, 2016 at 10:13:52AM +0200, Michal Hocko wrote: > On Wed 19-10-16 09:59:03, Jan Kara wrote: > > On Thu 13-10-16 01:20:18, Lorenzo Stoakes wrote: > > > This patch removes the write parameter from __access_remote_vm() and > > > replaces it > > > with a gup_flags parameter as use of thi

Re: [PATCH v6 1/2] media: i2c/ov5645: add the device tree binding document

2016-10-19 Thread Laurent Pinchart
Hi Todor, On Friday 14 Oct 2016 15:01:08 Todor Tomov wrote: > On 09/08/2016 03:22 PM, Laurent Pinchart wrote: > > On Thursday 08 Sep 2016 12:13:54 Todor Tomov wrote: > >> Add the document for ov5645 device tree binding. > >> > >> Signed-off-by: Todor Tomov > >> --- > >> > >> .../devicetree/bin

[PATCH v2 1/1] doc-rst: v4l: Add documentation on CSI-2 bus configuration

2016-10-19 Thread Sakari Ailus
Document the interface between the CSI-2 transmitter and receiver drivers. Signed-off-by: Sakari Ailus --- Hi Philipp, Indeed the pixel rate is used by some driver as well. How about this one instead? The HTML page is available here (without CCS unfortunately): http://www.retiisi.org.uk/v4l2/

Re: [PATCH v2 53/58] firewire: don't break long lines

2016-10-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Oct 2016 08:03:01 +0900 Takashi Sakamoto escreveu: > From: Takashi Sakamoto > Date: Wed, 19 Oct 2016 07:53:35 +0900 > Subject: [PATCH] [media] firewire: use dev_dbg() instead of printk() > > A structure for firedtv (struct firedtv) has a member for a pointer to > struct device. In th

Re: [PATCH v2 53/58] firewire: don't break long lines

2016-10-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Oct 2016 09:56:25 +0200 Stefan Richter escreveu: > On Oct 19 Takashi Sakamoto wrote: > > --- a/drivers/media/firewire/firedtv-rc.c > > +++ b/drivers/media/firewire/firedtv-rc.c > > @@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned > > int code) > > else if (cod

Re: [PATCH v2 1/3] ARM: dts: r8a7793: Enable VIN0-VIN2

2016-10-19 Thread Geert Uytterhoeven
On Tue, Oct 18, 2016 at 5:02 PM, Ulrich Hecht wrote: > Signed-off-by: Ulrich Hecht Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical peo

Re: [PATCH v2 53/58] firewire: don't break long lines

2016-10-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Oct 2016 10:01:13 +0200 Stefan Richter escreveu: > On Oct 18 Mauro Carvalho Chehab wrote: > [...] > > The patch was generated via the script below, and manually > > adjusted if needed. > [...] > > Reviewed-by: Takashi Sakamoto > > Acked-by: Stefan Richter > > Signed-off-by: Mauro C

Re: [PATCH v3 2/2] Add support for Omnivision OV5647

2016-10-19 Thread Pavel Machek
Hi! > >> +struct regval_list { > >> + uint16_t addr; > >> + uint8_t data; > >> +}; > > u8/u16? > > This sensor uses 16 bits for addresses and 8 for data, so I think it makes > sense > to keep it this way. Yes, you can do it. But please use u8/u16 types (also elsewhere in the driver), they are

Re: [PATCH v3 2/2] Add support for Omnivision OV5647

2016-10-19 Thread Ramiro Oliveira
Hi! On 10/18/2016 7:31 PM, Pavel Machek wrote: > Hi! > >> +/* >> + * A V4L2 driver for OmniVision OV5647 cameras. >> + * >> + * Based on Samsung S5K6AAFX SXGA 1/6" 1.3M CMOS Image Sensor driver >> + * Copyright (C) 2011 Sylwester Nawrocki >> + * >> + * Based on Omnivision OV7670 Camera Driver >>

Re: [PATCH v2 50/58] v4l2-core: don't break long lines

2016-10-19 Thread Sakari Ailus
Hi Mauro, On Tue, Oct 18, 2016 at 06:46:02PM -0200, Mauro Carvalho Chehab wrote: > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c > b/drivers/media/v4l2-core/v4l2-ioctl.c > index c52d94c018bb..26fe7aef1196 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

2016-10-19 Thread Jan Kara
On Thu 13-10-16 01:20:18, Lorenzo Stoakes wrote: > This patch removes the write parameter from __access_remote_vm() and replaces > it > with a gup_flags parameter as use of this function previously _implied_ > FOLL_FORCE, whereas after this patch callers explicitly pass this flag. > > We make thi

Re: [PATCH v2 50/58] v4l2-core: don't break long lines

2016-10-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Oct 2016 10:09:16 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Tue, Oct 18, 2016 at 06:46:02PM -0200, Mauro Carvalho Chehab wrote: > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c > > b/drivers/media/v4l2-core/v4l2-ioctl.c > > index c52d94c018bb..26fe7aef1196 100644 > > --- a

Re: [PATCH v2 1/1] doc-rst: v4l: Add documentation on CSI-2 bus configuration

2016-10-19 Thread Philipp Zabel
Am Mittwoch, den 19.10.2016, 17:27 +0300 schrieb Sakari Ailus: > On 10/19/16 17:24, Philipp Zabel wrote: > > Am Mittwoch, den 19.10.2016, 15:59 +0300 schrieb Sakari Ailus: > >> Document the interface between the CSI-2 transmitter and receiver drivers. > >> > >> Signed-off-by: Sakari Ailus > >> ---

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

2016-10-19 Thread Lorenzo Stoakes
On Wed, Oct 19, 2016 at 10:52:05AM +0200, Michal Hocko wrote: > yes this is the desirable and expected behavior. > > > wonder if this is desirable behaviour or whether this ought to be limited to > > ptrace system calls. Regardless, by making the flag more visible it makes it > > easier to see that

Re: [PATCH v6 1/2] media: i2c/ov5645: add the device tree binding document

2016-10-19 Thread Todor Tomov
Hi Laurent, Thank you for the review. On 10/19/2016 11:49 AM, Laurent Pinchart wrote: > Hi Todor, > > On Friday 14 Oct 2016 15:01:08 Todor Tomov wrote: >> On 09/08/2016 03:22 PM, Laurent Pinchart wrote: >>> On Thursday 08 Sep 2016 12:13:54 Todor Tomov wrote: Add the document for ov5645 devi

Re: [PATCH 1/1] doc-rst: v4l: Add documentation on CSI-2 bus configuration

2016-10-19 Thread Philipp Zabel
Am Dienstag, den 18.10.2016, 18:02 +0300 schrieb Sakari Ailus: > Document the interface between the CSI-2 transmitter and receiver drivers. > > Signed-off-by: Sakari Ailus > --- > Hi folks, > > We've got multiple CSI-2 tranmitter and receiver drivers currently in the > kernel. Some receivers req

Re: [PATCH v2 53/58] firewire: don't break long lines

2016-10-19 Thread Stefan Richter
On Oct 19 Takashi Sakamoto wrote: > --- a/drivers/media/firewire/firedtv-rc.c > +++ b/drivers/media/firewire/firedtv-rc.c > @@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned > int code) > else if (code >= 0x4540 && code <= 0x4542) > code = oldtable[code - 0x

[PATCH v3 1/1] doc-rst: v4l: Add documentation on CSI-2 bus configuration

2016-10-19 Thread Sakari Ailus
Document the interface between the CSI-2 transmitter and receiver drivers. Signed-off-by: Sakari Ailus --- since v2: - Add bits_per_sample variable to the formula. It should be correct now. Documentation/media/kapi/csi2.rst | 61 ++ Documentation/media/medi

Re: [PATCH 3/5] [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

2016-10-19 Thread David Härdeman
October 14, 2016 1:43 PM, "SF Markus Elfring" wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 10:40:12 +0200 > > Move the setting for the local variables "mask", "match" and "rc6_csl" > behind the source code for a condition check by this function > at the beginning. Again, I can't see

Re: [PATCH v2 1/1] doc-rst: v4l: Add documentation on CSI-2 bus configuration

2016-10-19 Thread Philipp Zabel
Am Mittwoch, den 19.10.2016, 15:59 +0300 schrieb Sakari Ailus: > Document the interface between the CSI-2 transmitter and receiver drivers. > > Signed-off-by: Sakari Ailus > --- > Hi Philipp, > > Indeed the pixel rate is used by some driver as well. > > How about this one instead? > > The HTML

Re: [PATCH v2 1/1] doc-rst: v4l: Add documentation on CSI-2 bus configuration

2016-10-19 Thread Sakari Ailus
On 10/19/16 17:24, Philipp Zabel wrote: > Am Mittwoch, den 19.10.2016, 15:59 +0300 schrieb Sakari Ailus: >> Document the interface between the CSI-2 transmitter and receiver drivers. >> >> Signed-off-by: Sakari Ailus >> --- >> Hi Philipp, >> >> Indeed the pixel rate is used by some driver as well.

Re: [media] winbond-cir: Move a variable assignment in wbcir_tx()

2016-10-19 Thread David Härdeman
October 19, 2016 3:32 PM, "SF Markus Elfring" wrote: >>> Move the assignment for the local variable "data" behind the source code >>> for a memory allocation by this function. >> >> Sorry, I can't see what the point is? > > * How do you think about to avoid a variable assignment in case > that

Re: [RFC PATCH 6/7] atmel-isi: remove dependency of the soc-camera framework

2016-10-19 Thread Hans Verkuil
On 10/19/2016 09:36 AM, Wu, Songjun wrote: > > > On 10/18/2016 18:58, Hans Verkuil wrote: >> On 10/18/16 11:21, Wu, Songjun wrote: >>> Hi Hans, >>> >>> Do you have any issue on this patch? >> >> ENOTIME :-( >> >>> Could I give you some help? :) >> >> I would certainly help if you can make the req

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-10-19 Thread Laurent Pinchart
Hi Todor, (CC'ing Mark Brown for a question on regulators) On Friday 14 Oct 2016 14:57:01 Todor Tomov wrote: > Hi Laurent, > > Thank you for the time spent to do this thorough review of the patch! > > Below I have removed some of the comments where I agree and I'll fix. > I have left the places

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

2016-10-19 Thread Michal Hocko
On Wed 19-10-16 09:40:45, Lorenzo Stoakes wrote: > On Wed, Oct 19, 2016 at 10:13:52AM +0200, Michal Hocko wrote: > > On Wed 19-10-16 09:59:03, Jan Kara wrote: > > > On Thu 13-10-16 01:20:18, Lorenzo Stoakes wrote: > > > > This patch removes the write parameter from __access_remote_vm() and > > > >

Re: [PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags

2016-10-19 Thread Jan Kara
On Thu 13-10-16 01:20:16, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages() and > replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit > in callers as use of this flag can result in surprising behaviour (and hence > bugs)

Re: [PATCH 07/10] mm: replace get_user_pages_remote() write/force parameters with gup_flags

2016-10-19 Thread Jan Kara
On Thu 13-10-16 01:20:17, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages_remote() > and replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit in callers as use of this flag can result in surprising behaviour > (and > hence

Re: [RFC PATCH 6/7] atmel-isi: remove dependency of the soc-camera framework

2016-10-19 Thread Wu, Songjun
On 10/18/2016 18:58, Hans Verkuil wrote: On 10/18/16 11:21, Wu, Songjun wrote: Hi Hans, Do you have any issue on this patch? ENOTIME :-( Could I give you some help? :) I would certainly help if you can make the requested change to this patch. Let me know if you want to do that, because

Re: [RFC PATCH 6/7] atmel-isi: remove dependency of the soc-camera framework

2016-10-19 Thread Wu, Songjun
On 10/19/2016 15:46, Hans Verkuil wrote: On 10/19/2016 09:36 AM, Wu, Songjun wrote: On 10/18/2016 18:58, Hans Verkuil wrote: On 10/18/16 11:21, Wu, Songjun wrote: Hi Hans, Do you have any issue on this patch? ENOTIME :-( Could I give you some help? :) I would certainly help if you c

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

2016-10-19 Thread Jan Kara
On Tue 18-10-16 14:56:09, Lorenzo Stoakes wrote: > On Tue, Oct 18, 2016 at 02:54:25PM +0200, Jan Kara wrote: > > > @@ -1282,7 +1282,7 @@ long get_user_pages(unsigned long start, unsigned > > > long nr_pages, > > > int write, int force, struct page **pages, > > >