On Mon, 2016-07-18 at 14:18 +0200, Hans Verkuil wrote:
> On 07/14/2016 02:18 PM, Minghsiu Tsai wrote:
> > Add MDP driver for MT8173
> >
> > Signed-off-by: Minghsiu Tsai
> > ---
> > drivers/media/platform/Kconfig| 16 +
> > drivers/media/platform/Makefile |2 +
On 7/21/2016 16:41, Hans Verkuil wrote:
On 07/21/2016 10:14 AM, Songjun Wu wrote:
The Image Sensor Controller driver includes two parts.
1) Driver code to implement the ISC function.
2) Device tree binding documentation, it describes how
to add the ISC in device tree.
Test result with v4
On 7/21/2016 17:13, Hans Verkuil wrote:
On 07/21/2016 10:14 AM, Songjun Wu wrote:
Add driver for the Image Sensor Controller. It manages
incoming data from a parallel based CMOS/CCD sensor.
It has an internal image processor, also integrates a
triple channel direct memory access controller m
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Jul 22 04:00:17 CEST 2016
git branch: test
git hash: 009a620848218d521f008141c62f56bf19294dd9
gcc versi
On Thu, Jul 21, 2016 at 04:14:58PM +0800, Songjun Wu wrote:
> DT binding documentation for ISC driver.
>
> Signed-off-by: Songjun Wu
> ---
>
> Changes in v6:
> - Add "iscck" and "gck" to clock-names.
>
> Changes in v5:
> - Add clock-output-names.
>
> Changes in v4:
> - Remove the isc clock nod
Add cross-references for the functions/structs and add
the markup tags to improve its display.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-dev.rst | 352 +++-
Documentation/media/kapi/v4l2-videobuf.rst | 2 +
Documentation/media/kapi/v4
Not all functions at v4l2-common.h are documented. Add
documentation for some other ones.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-common.h | 43 ++-
1 file changed, 38 insertions(+), 5 deletions(-)
diff --git a/include/media/v4l2-commo
Move the documentation for video device node creation to
a separate file.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-core.rst | 1 +
Documentation/media/kapi/v4l2-dev.rst | 343 +++
Documentation/media/kapi/v4l2-framework.rst | 344
The v4l2_subdev reference was using the wrong tag. Fix it.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/mc-core.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/media/kapi/mc-core.rst
b/Documentation/media/kapi/mc-core.rst
index 4c47f5e3
Add documentation for v4l2-dev.h, and put it at v4l2-framework.rst,
where struct video_device is currently documented.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-framework.rst | 5 +
drivers/media/v4l2-core/v4l2-dev.c | 34 ---
include/media/v4l2-dev.h
There are two additional subdev-specific sections at the
v4l2-framework file. Move them to the subdev chapter, in order
to better organize the book.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-framework.rst | 165 ---
Documentation/media/kapi/v4
Part of the contents of v4l2-framework is related to the
kAPI defined by v4l2-device. Move such contents to the
v4l2-device.rst.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-device.rst| 140 +++-
Documentation/media/kapi/v4l2-framework.rst |
Sphinx produce a 1:1 mapping between a rst file and an html file.
So, we need to split the kernel-doc tags on multiple documents.
A side effect is that we're now having a better name for each
section of the kAPI documentation.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v
The two new sections were missing cross-references, and had
some other minor issues with the markups. Add such things.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-subdev.rst | 152 +--
1 file changed, 82 insertions(+), 70 deletions(-)
diff
There are some subdev-specific functions at v4l2-common.h
that are mentioned at v4l2-subdev.rst.
Document them.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-subdev.rst | 6
include/media/v4l2-common.h | 49 +++-
2 files ch
Enrich the subdevice description by linking it to the
functions and structs from v4l2-subdev.h.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-subdev.rst | 158 ---
1 file changed, 83 insertions(+), 75 deletions(-)
diff --git a/Documentation/m
The functions at v4l2-device.h are not using the proper
markups. Add it, and include at the v4l2-core.rst.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-core.rst | 2 +
include/media/v4l2-device.h| 194 -
2 files changed, 143
The Async API is actually part of the v4l2 subdev.
Move its declarations to it.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-async.rst | 4
Documentation/media/kapi/v4l2-core.rst | 1 -
Documentation/media/kapi/v4l2-subdev.rst | 5 +
3 files changed, 5 inser
This header were poorly documented, and weren't using the
kernel-doc format. Document everything but the macros using
the right format.
While here, also fix the other comments to match the
Linux CodingStyle.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v4l2-subdev.c | 10 -
There are one enum and 4 functions undocumented there.
Document them. That will fix the broken links at the
v4l2-subdev.rst file.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-async.h | 39 +++
1 file changed, 39 insertions(+)
diff --git a/inclu
There are lots of documentation about V4L2 subdevices at
v4l2-framework.rst. Move them to its specific chapter at
v4l2-subdev.rst.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-framework.rst | 257
Documentation/media/kapi/v4l2-subdev.rst
This document describes the main kAPI interfaces for the
v4l2-device.h header. Add cross references to the documentation
produced via kernel-doc.
While here, also use monotonic font for constants.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-device.rst | 130 ++
Hi All.
Just a quick query to avoid duplicating effort. Has anyone worked on a
Sony IMX219 (or other Sony sensor) subdevice driver as yet?
With the new Raspberry Pi camera being IMX219, and as Broadcom have
released an soc_camera based driver for the sensor already
(https://android.googlesou
Signed-off-by: Charles-Antoine Couret
---
Documentation/media/uapi/v4l/vidioc-enuminput.rst | 31 +-
.../media/uapi/v4l/vidioc-g-dv-timings.rst | 15 +++
2 files changed, 39 insertions(+), 7 deletions(-)
diff --git a/Documentation/media/uapi/v4l/vidioc-enumin
On Thu, 21 Jul 2016 16:41:53 +0200
Markus Heiser wrote:
> Am 21.07.2016 um 01:28 schrieb Jonathan Corbet :
>
> > I would hope that most people wouldn't have to worry about it, and would
> > be able to just use what their distribution provides - that's the reason
> > for the 1.2 compatibility requ
Adding others generic flags, which could be used by many
components like GS1662.
Signed-off-by: Charles-Antoine Couret
---
drivers/media/v4l2-core/v4l2-dv-timings.c | 11 +++
include/uapi/linux/v4l2-dv-timings.h | 12
include/uapi/linux/videodev2.h| 8 +
Am 19.07.2016 um 19:18 schrieb Mauro Carvalho Chehab :
>> A bit OT, but I see that you often use tabs / I recommend to use
>> spaces for indentation:
>>
>> http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#whitespace
>
> The Kernel policies are to use tabs instead of spaces,
libmediatext is a helper library for converting configurations (Media
controller links, V4L2 controls and V4L2 sub-device media bus formats and
selections) from text-based form into IOCTLs.
libmediatext depends on libv4l2subdev and libmediactl.
Signed-off-by: Sakari Ailus
---
libmediatext.pc.in
Hi everyone,
We've got a number of V4L2 (and MC) test programs for about as many reasons.
The existing programs are concentrated to work on a single device node at a
time, and with a single interface, be that Media controller or V4L2.
The test programs are also command line controlled, working th
Fix libv4l2 and compliance tests as well for reserved field access.
Signed-off-by: Sakari Ailus
---
include/linux/media.h | 32 +
include/linux/v4l2-subdev.h | 11 --
include/linux/videodev2.h | 7 +-
Extract the list of V4L2 pixel format strings and 4cc codes from
videodev2.h for use in mediatext in order to convert user given format
names to 4cc codes that IOCTLs use.
Signed-off-by: Sakari Ailus
---
utils/media-ctl/Makefile.am | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
dif
You can read datasheet here:
http://www.c-dis.net/media/871/GS1662_Datasheet.pdf
It's a component which supports HD and SD CEA or SDI formats
to SDI output. It's configured through SPI bus.
GS1662 driver is implemented as v4l2 subdev.
Signed-off-by: Charles-Antoine Couret
---
drivers/media/Kco
Hi Sean,
> > > > + ret = regulator_enable(idata->regulator);
> > > > + if (ret)
> > > > + return ret;
> > > > +
> > > > + mutex_lock(&idata->mutex);
> > > > + idata->xfer.len = n;
> > > > + idata->xfer.tx_buf = buffer;
> > > > + mutex_unlock(&idata
These patches add a driver for GS1662 component, a video serializer which
supports CEA and SDI timings.
To perform that, we need to determine SDI definition and some flags.
The associated documentation will be into another patchset to be
Sphinx comaptible.
This patchset add:
* rename V4L2
Hi Andi,
On Thu, Jul 21, 2016 at 09:48:12AM +0900, Andi Shyti wrote:
> > > Raw transmitters receive the data which need to be sent to
> > > receivers from userspace as stream of bits, they don't require
> > > any handling from the lirc framework.
> >
> > No drivers of type RC_DRIVER_IR_RAW_TX sho
Am 21.07.2016 um 01:28 schrieb Jonathan Corbet :
> On Wed, 20 Jul 2016 08:07:54 +0200
> Markus Heiser wrote:
>
>> Jon, what do you think ... could we serve this 1.2 doc
>> on https://www.kernel.org/doc/ as reference?
>
> Seems like a good idea. I don't really know who controls that directory
if specified DVB-C bandwidth not supported then force 8MHz.
Should work for most cases.
Signed-off-by: Abylay Ospan
---
drivers/media/dvb-frontends/cxd2841er.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/media/dvb-frontends/cxd2841er.c
b/drivers/media/dvb-frontends/cxd28
On 07/21/2016 02:34 PM, Charles-Antoine Couret wrote:
> Adding others generic flags, which could be used by many
> components like GS1662.
>
> Signed-off-by: Charles-Antoine Couret
> ---
> drivers/media/v4l2-core/v4l2-dv-timings.c | 11 +++
> include/uapi/linux/v4l2-dv-timings.h |
Hi
On 2016-07-21 14:14, Hans Verkuil wrote:
From: Hans Verkuil
Make error handling of alloc, get_userptr and attach_dmabuf systematic.
Add tests to check for a valid non-NULL device pointer.
Acked-by: Marek Szyprowski
Regards,
Hans
Changes since v1:
- Split into two patches
On Thu, Jul 21, 2016 at 02:14:01PM +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Make error handling of alloc, get_userptr and attach_dmabuf systematic.
>
> Add tests to check for a valid non-NULL device pointer.
Thanks!
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.
Adding others generic flags, which could be used by many
components like GS1662.
Signed-off-by: Charles-Antoine Couret
---
drivers/media/v4l2-core/v4l2-dv-timings.c | 11 +++
include/uapi/linux/v4l2-dv-timings.h | 12
include/uapi/linux/videodev2.h| 5 +
You can read datasheet here:
http://www.c-dis.net/media/871/GS1662_Datasheet.pdf
It's a component which supports HD and SD CEA or SDI formats
to SDI output. It's configured through SPI bus.
GS1662 driver is implemented as v4l2 subdev.
Signed-off-by: Charles-Antoine Couret
---
drivers/media/Kco
These patches add a driver for GS1662 component, a video serializer which
supports CEA and SDI timings.
To perform that, we need to determine SDI definition and some flags.
This third patchset add:
* flags printing in v4l2_print_dv_timings() function
* improvement of some comments
From: Hans Verkuil
Always return an ERR_PTR() instead of NULL.
This makes the behavior of alloc, get_userptr and attach_dmabuf the
same.
Update the documentation in videobuf2-core.h as well.
Signed-off-by: Hans Verkuil
---
drivers/media/v4l2-core/videobuf2-core.c| 12
driver
From: Hans Verkuil
The dma-contig and dma-sg memops require a valid struct device for
the DMA to be handled correctly.
Call WARN_ON and return ERR_PTR(-EINVAL) if it was NULL.
Setting the correct device pointer was forgotten in several new driver
submissions. This was caught during code review,
From: Hans Verkuil
Make error handling of alloc, get_userptr and attach_dmabuf systematic.
Add tests to check for a valid non-NULL device pointer.
Regards,
Hans
Changes since v1:
- Split into two patches
- Drop pr_debug
Hans Verkuil (2):
vb2: don't return NULL for alloc and get_us
New IOCTLs (especially for the request API) do not necessarily need the
graph mutex acquired. Leave this up to the drivers.
Signed-off-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
---
drivers/media/media-device.c | 47 ++--
1 file changed, 28 insertions
Instead of checking for a strict size for the IOCTL arguments, place
minimum and maximum limits.
As an additional bonus, IOCTL handlers will be able to check whether the
caller actually set (using the argument size) the field vs. assigning it
to zero. Separate macro can be provided for that.
This
Each IOCTL handler can be listed in an array instead of using a large and
cumbersome switch. Do that.
Reviewed-by: Laurent Pinchart
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c | 81 +---
1 file changed, 23 insertions(+), 58 deletions(-)
Preparation for refactoring media IOCTL handling to unify common parts.
Reviewed-by: Laurent Pinchart
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c | 48 ++--
1 file changed, 46 insertions(+), 2 deletions(-)
diff --git a/drivers/media/medi
Hi,
This is the third version of the media IOCTL handling rework set. What's
changed since v2:
patch 3:
- Remove function to calculate maximum argument size, replace by a char
array of 256 or kmalloc() if that's too small.
- info->arg_from_user() may f
Refactor copying the IOCTL argument structs from the user space and back,
in order to reduce code copied around and make the implementation more
robust.
As a result, the copying is done while not holding the graph mutex.
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c | 190 +++
New IOCTLs (especially for the request API) do not necessarily need the
graph mutex acquired. Leave this up to the drivers.
Signed-off-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
---
since v2:
- Arrange the flags field next to cmd, which is an integer. This avoids
creating extra holes in t
Refactor copying the IOCTL argument structs from the user space and back,
in order to reduce code copied around and make the implementation more
robust.
As a result, the copying is done while not holding the graph mutex.
Signed-off-by: Sakari Ailus
---
since v2.2:
- Instead of providing a no-op
Em Wed, 20 Jul 2016 17:33:31 +0200
Markus Heiser escreveu:
> Am 20.07.2016 um 17:06 schrieb Mauro Carvalho Chehab
> :
>
> > Em Wed, 20 Jul 2016 16:49:59 +0200
> > Markus Heiser escreveu:
> >
> >> Am 20.07.2016 um 16:31 schrieb Jonathan Corbet :
> >>
> >>> On Wed, 20 Jul 2016 16:23:28 +02
Em Wed, 20 Jul 2016 17:06:41 -0600
Jonathan Corbet escreveu:
> On Wed, 20 Jul 2016 11:41:11 -0300
> Mauro Carvalho Chehab wrote:
>
> > > The thing with that is that a lot of literal blocks *do* have C code, even
> > > in kernel-documentation.rst. Setting that in conf.py would turn off all C
>
Hi Andi,
On Thu, Jul 21, 2016 at 10:09:26AM +0900, Andi Shyti wrote:
> > > + ret = regulator_enable(idata->regulator);
> > > + if (ret)
> > > + return ret;
> > > +
> > > + mutex_lock(&idata->mutex);
> > > + idata->xfer.len = n;
> > > + idata->xfer.tx_buf = buffer;
> > > + mutex_unlock(&ida
Hi Hans,
On Thu, Jul 21, 2016 at 11:19:11AM +0200, Hans Verkuil wrote:
> Check whether the struct device pointer is NULL and return -EINVAL in that
> case.
>
> This also required a small change to vb2-core where it didn't call PTR_ERR to
> get the real error code.
>
> I have seen several new dri
On 07/21/2016 09:30 AM, Jean Christophe TROTIN wrote:
>
> On 07/18/2016 01:45 PM, Hans Verkuil wrote:
>> Hi Jean-Christophe,
>>
>> See my review comments below. Nothing really major, but I do need to know
>> more
>> about the g/s_parm and the restriction on the number of open()s has to be
>> l
Check whether the struct device pointer is NULL and return -EINVAL in that
case.
This also required a small change to vb2-core where it didn't call PTR_ERR to
get the real error code.
I have seen several new driver submissions that forgot to set the vb2_queue
dev field, so add these checks to pre
On 07/21/2016 10:14 AM, Songjun Wu wrote:
> Add driver for the Image Sensor Controller. It manages
> incoming data from a parallel based CMOS/CCD sensor.
> It has an internal image processor, also integrates a
> triple channel direct memory access controller master
> interface.
>
> Signed-off-by
Hi Hans,
On Fri, 2016-07-08 at 13:44 +0200, Hans Verkuil wrote:
> On 07/07/2016 12:16 PM, tiffany lin wrote:
> > Hi Hans,
> >
> >
> > On Wed, 2016-07-06 at 15:19 +0200, Hans Verkuil wrote:
> >> Hi Tiffany,
> >>
> >> I plan to review this patch series on Friday, but one obvious question is
> >> w
On 07/21/2016 10:14 AM, Songjun Wu wrote:
> The Image Sensor Controller driver includes two parts.
> 1) Driver code to implement the ISC function.
> 2) Device tree binding documentation, it describes how
>to add the ISC in device tree.
>
> Test result with v4l-utils 1.10.1
Please compile fr
On 07/15/2016 03:14 PM, Charles-Antoine Couret wrote:
> From 111c02ef44dc1588891b40337fb0669fa586ec50 Mon Sep 17 00:00:00 2001
> From: Charles-Antoine Couret
> Date: Fri, 15 Jul 2016 15:06:43 +0200
> Subject: [PATCH 2/2] Add GS1662 driver, a video serializer
>
> You can read datasheet here:
> h
Hi Charles-Antoine,
These new flags have to be documented. As you may have seen, we're switching
away from docbook to sphinx (doc-rst). The 'docs-next' tree in the media_tree
repository can be used for the documentation patches.
This will appear in v4.8.
What is completely missing here is a disc
The Image Sensor Controller driver includes two parts.
1) Driver code to implement the ISC function.
2) Device tree binding documentation, it describes how
to add the ISC in device tree.
Test result with v4l-utils 1.10.1
Driver Info:
Driver name : atmel_isc
Card type : Atm
Add driver for the Image Sensor Controller. It manages
incoming data from a parallel based CMOS/CCD sensor.
It has an internal image processor, also integrates a
triple channel direct memory access controller master
interface.
Signed-off-by: Songjun Wu
---
Changes in v6: None
Changes in v5:
- Mo
DT binding documentation for ISC driver.
Signed-off-by: Songjun Wu
---
Changes in v6:
- Add "iscck" and "gck" to clock-names.
Changes in v5:
- Add clock-output-names.
Changes in v4:
- Remove the isc clock nodes.
Changes in v3:
- Remove the 'atmel,sensor-preferred'.
- Modify the isc clock node
The module is still called 'hva'. I suggest calling it sti-hva instead.
> Format ioctls:
> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
> warn:
> /local/home/frq08988/views/opensdk-2.1.4.1/sources/v4l-utils/utils/v4l2-compliance/v4l2-test-formats.cpp(1187):
This patch adds V4L2 HVA (Hardware Video Accelerator) video encoder
driver for STMicroelectronics SoC. It uses the V4L2 mem2mem framework.
This patch only contains the core parts of the driver:
- the V4L2 interface with the userland (hva-v4l2.c)
- the hardware services (hva-hw.c)
- the memory mana
This patch adds the H.264 video encoding capability in the V4L2 HVA
video encoder driver for STMicroelectronics SoC (hva-h264.c).
The main supported features are:
- profile: baseline, main, high, stereo high
- level: up to 4.2
- bitrate mode: CBR, VBR
- entropy mode: CABAC, CAVLC
- video aspect: 1
This patch adds DT binding documentation for STMicroelectronics hva
driver.
Signed-off-by: Yannick Fertre
Signed-off-by: Jean-Christophe Trotin
---
.../devicetree/bindings/media/st,sti-hva.txt | 24 ++
1 file changed, 24 insertions(+)
create mode 100644 Documentation/
version 3:
- Comments from Nicolas, Javier and Hans about version 2 taken into account:
- Kconfig's comment reworked
- querycap: "driver" contains the name of the encoder ("hva"), "card"
identifies the hardware version ("hva" with
equal to 400 here, which leads to "hva400"), and
On 07/18/2016 01:55 PM, Hans Verkuil wrote:
> On 07/11/2016 05:14 PM, Jean-Christophe Trotin wrote:
>> This patch adds the H.264 video encoding capability in the V4L2 HVA
>> video encoder driver for STMicroelectronics SoC (hva-h264.c).
>>
>> The main supported features are:
>> - profile: baseline
On 07/18/2016 01:45 PM, Hans Verkuil wrote:
> Hi Jean-Christophe,
>
> See my review comments below. Nothing really major, but I do need to know more
> about the g/s_parm and the restriction on the number of open()s has to be
> lifted.
> That's not allowed.
>
Hi Hans,
Thank you for your comments
75 matches
Mail list logo
