This patch series finally gets rid of the old v4l2_subdev control helpers ops.
Instead use the ctrl_handler of the v4l2_subdev struct directly.
Regards,
Hans
The following changes since commit a4d020e97d8e65d57061677c15c89e99609d0b37:
[media] Convert Wideview WT220 DVB USB driver to
On 07/08/2016 01:25 PM, Nick Dyer wrote:
> This is a series of patches to add output of raw touch diagnostic data via
> V4L2
> to the Atmel maXTouch and Synaptics RMI4 drivers.
>
> It's a rewrite of the previous implementation which output via debugfs: it now
> uses a V4L2 device in a similar way
Hi Andrey,
Thanks for this driver. Some review comments below:
On 07/09/2016 09:46 PM, Andrey Utkin wrote:
> From: Andrey Utkin
>
>
> Changes in v3 since v2:
> - Kconfig: select VIDEOBUF2_DMA_CONTIG, not SG
> - drop i2c code as unused
> - Dropped num_buffers check in queue_setup as suggeste
The following changes since commit a4d020e97d8e65d57061677c15c89e99609d0b37:
[media] Convert Wideview WT220 DVB USB driver to rc-core (2016-07-09 12:10:33
-0300)
are available in the git repository at:
git://linuxtv.org/hverkuil/media_tree.git for-v4.8i
for you to fetch changes up to 2c8a5
Hi Tiffany,
My apologies for the delay, but here is my review at last:
On 05/30/2016 09:52 AM, Tiffany Lin wrote:
> This patch add g/s_selection support for MT8173
>
> Signed-off-by: Tiffany Lin
> ---
> drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 74
>
> 1 file
On 07/11/2016 05:48 AM, tiffany lin wrote:
>
> reviewed-by: Tiffany Lin
>
>
> May I know why and how we use struct device *alloc_devs[] in queue_setup
> callback function?
That's only needed if the hardware has to allocate each plane buffer from a
different memory bank. That's important for th
Hi Hans,
On Fri, 2016-07-08 at 13:44 +0200, Hans Verkuil wrote:
> On 07/07/2016 12:16 PM, tiffany lin wrote:
> > Hi Hans,
> >
> >
> > On Wed, 2016-07-06 at 15:19 +0200, Hans Verkuil wrote:
> >> Hi Tiffany,
> >>
> >> I plan to review this patch series on Friday, but one obvious question is
> >> w
reviewed-by: Tiffany Lin
May I know why and how we use struct device *alloc_devs[] in queue_setup
callback function?
best regards,
Tiffany
On Fri, 2016-07-08 at 21:11 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> The patch dropping the vb2_dma_contig_init_ctx() and _cleanup_ctx()
> f
Fix two warnings:
af9033.c: In function 'af9033_read_status':
af9033.c:883:25: warning: 'snr_lut' may be used uninitialized in this function
[-Wmaybe-uninitialized]
const struct val_snr *snr_lut;
^
af9033.c:952:25: warning: 'tmp' may be used uninitialized in this funct
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Mon Jul 11 04:00:30 CEST 2016
git branch: test
git hash: a4d020e97d8e65d57061677c15c89e99609d0b37
gcc versi
On Fri, 2016-07-08 at 21:11 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Allow VIDEO_MEDIATEK_VCODEC to build when COMPILE_TEST is set (even
> without MTK_IOMMU).
>
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/platform/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(
On Sat, 2016-07-09 at 09:32 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> mtk-vcodec/mtk_vcodec_enc.c: In function 'mtk_venc_worker':
> mtk-vcodec/mtk_vcodec_enc.c:1030:43: warning: format '%lx' expects argument
> of type 'long unsigned int', but argument 7 has type 'size_t {aka unsigned
On Sat, 2016-07-09 at 09:32 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> mtk-vcodec/venc_vpu_if.c:40:30: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
> struct venc_vpu_inst *vpu = (struct venc_vpu_inst *)msg->venc_inst;
>
Hi Hans,
On Fri, 2016-07-08 at 12:23 +0200, Hans Verkuil wrote:
> On 05/30/2016 02:29 PM, Tiffany Lin wrote:
> > Add V4L2_PIX_FMT_MT21 documentation
> >
> > Signed-off-by: Tiffany Lin
> > ---
> > Documentation/DocBook/media/v4l/pixfmt.xml |6 ++
> > 1 file changed, 6 insertions(+)
> >
Hi Hans,
On Fri, 2016-07-08 at 12:18 +0200, Hans Verkuil wrote:
> On 05/12/2016 01:24 PM, Tiffany Lin wrote:
> > Add V4L2_PIX_FMT_MT21 format used on MT8173 driver.
> > It is compressed format and need MT8173 MDP driver to transfer to other
> > standard format.
> >
> > Signed-off-by: Tiffany Lin
On 07/10/2016 07:30 AM, Hans Verkuil wrote:
On 07/10/2016 04:17 PM, Ian Arkver wrote:
On 10/07/16 13:55, Hans Verkuil wrote:
On 07/10/2016 02:10 PM, Lars-Peter Clausen wrote:
On 07/09/2016 11:36 PM, Steve Longerbeam wrote:
On 07/09/2016 02:10 PM, Steve Longerbeam wrote:
On 07/09/2016 11:59
The redrat3 sends an usb packet to the host either when the minimum pause
or the timeout occurs, so we can always add a trailing space in our
processing.
Signed-off-by: Sean Young
---
drivers/media/rc/redrat3.c | 48 +++---
1 file changed, 11 insertions(+)
Signed-off-by: Sean Young
---
drivers/media/rc/ir-lirc-codec.c | 5 -
drivers/media/rc/redrat3.c | 34 ++
include/media/rc-core.h | 3 +++
3 files changed, 41 insertions(+), 1 deletion(-)
diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers
Signed-off-by: Sean Young
---
Documentation/ABI/testing/sysfs-class-rc-redrat3 | 33
drivers/media/rc/redrat3.c | 200 +++
2 files changed, 233 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-class-rc-redrat3
diff --git a/Document
Currently v4l-utils has no tooling provided for receiving and sending
raw IR using the lirc interface. Some of this can be done using various
tools from the user-space lirc package, but not everything is covered.
We want to be able to do the following:
- List all the features that a lirc device p
LIRC_SET_SEND_CARRIER should return 0 on success or -errno.
Signed-off-by: Sean Young
---
Documentation/DocBook/media/v4l/lirc_device_interface.xml | 2 +-
drivers/media/rc/ene_ir.c | 2 +-
drivers/media/rc/iguanair.c | 2 +-
drivers/
When s_tx_mask is given an invalid bitmask, the number of transmitters
should be returned. See the LIRC_SET_TRANSMITTER_MASK lirc ioctl
documentation.
Signed-off-by: Sean Young
---
drivers/media/rc/mceusb.c | 6 ++
drivers/media/rc/winbond-cir.c | 4
2 files changed, 10 insertions(
Em Sun, 22 May 2016 11:06:05 +0200
Geert Uytterhoeven escreveu:
> Submitters of device tree binding documentation may forget to CC
> the subsystem maintainer if this is missing.
I'm assuming that this patch will go via DT git tree, so:
>
> Signed-off-by: Geert Uytterhoeven
> Cc: Mauro Carvalho
Make the note better formatted and documented.
Signed-off-by: Mauro Carvalho Chehab
---
.../media/uapi/dvb/fe_property_parameters.rst | 26 +-
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/Documentation/media/uapi/dvb/fe_property_parameters.rst
b/Docum
There are several notes and warning mesages in the middle of
the media docbook. Use the ReST tags for that, as it makes
them visually better and hightlights them.
While here, modify a few ones to make them clearer.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/cec/cec-func-c
There are several notes for this DTV property. Some are
outdated, so take some care of it, making it updated.
Signed-off-by: Mauro Carvalho Chehab
---
.../media/uapi/dvb/fe_property_parameters.rst | 28 +-
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/D
On 07/10/2016 04:17 PM, Ian Arkver wrote:
> On 10/07/16 13:55, Hans Verkuil wrote:
>> On 07/10/2016 02:10 PM, Lars-Peter Clausen wrote:
>>> On 07/09/2016 11:36 PM, Steve Longerbeam wrote:
On 07/09/2016 02:10 PM, Steve Longerbeam wrote:
>
> On 07/09/2016 11:59 AM, Steve Longerbeam
On 10/07/16 13:55, Hans Verkuil wrote:
On 07/10/2016 02:10 PM, Lars-Peter Clausen wrote:
On 07/09/2016 11:36 PM, Steve Longerbeam wrote:
On 07/09/2016 02:10 PM, Steve Longerbeam wrote:
On 07/09/2016 11:59 AM, Steve Longerbeam wrote:
On 07/07/2016 07:52 AM, Lars-Peter Clausen wrote:
On 07/
Added linux-input to the Cc list.
Dmitry, it probably makes the most sense if this goes through the media
tree with your Ack, unless you know there will be a conflict.
Regards,
Hans
On 07/10/2016 03:11 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This is for the new pulse8-cec sta
From: Hans Verkuil
This is for the new pulse8-cec staging driver.
Signed-off-by: Hans Verkuil
Cc: Dmitry Torokhov
---
include/uapi/linux/serio.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/serio.h b/include/uapi/linux/serio.h
index c2ea169..f2447a8 100644
--- a/incl
From: Hans Verkuil
Add entry for the pulse8-cec driver.
Signed-off-by: Hans Verkuil
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a975b8e..7486757 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9258,6 +9258,13 @@ F: include/lin
From: Hans Verkuil
Explain what needs to be done to move this driver out of staging.
Signed-off-by: Hans Verkuil
---
drivers/staging/media/pulse8-cec/TODO | 35 +++
1 file changed, 35 insertions(+)
create mode 100644 drivers/staging/media/pulse8-cec/TODO
diff
From: Hans Verkuil
CEC USB dongles can be unplugged at any time, and at that point they will
be unregistered. Make sure that any attempt afterwards to set the physical
or logical addresses will be ignored.
Signed-off-by: Hans Verkuil
---
drivers/staging/media/cec/cec-adap.c | 5 -
1 file c
From: Hans Verkuil
This adds support for the Pulse-Eight USB CEC dongle. It has been tested
with both v4 and v5 firmware.
It is still in staging because 1) the CEC framework it depends on is still in
staging, 2) the code needs to be refactored a bit and 3) it needs more testing.
That said, it'
From: Hans Verkuil
This supports the Pulse-Eight USB-CEC Adapter.
It has been tested with firmware versions 4 and 5, but it should
hopefully work fine with older firmwares as well.
Signed-off-by: Hans Verkuil
---
drivers/staging/media/Kconfig | 2 +
drivers/staging/media/Mak
On 07/10/2016 02:10 PM, Lars-Peter Clausen wrote:
> On 07/09/2016 11:36 PM, Steve Longerbeam wrote:
>>
>>
>> On 07/09/2016 02:10 PM, Steve Longerbeam wrote:
>>>
>>>
>>> On 07/09/2016 11:59 AM, Steve Longerbeam wrote:
On 07/07/2016 07:52 AM, Lars-Peter Clausen wrote:
> On 07/07/20
Unfortunately, captions are new on Sphinx for c blocks: it was
added only on version 1.3. Also, it were already bad enough
not being able to auto-numerate them.
So, let's give up and use, instead, titles before the examples.
Not much is lost, and, as a side track, we don't need to
numerate them an
On 07/09/2016 11:36 PM, Steve Longerbeam wrote:
>
>
> On 07/09/2016 02:10 PM, Steve Longerbeam wrote:
>>
>>
>> On 07/09/2016 11:59 AM, Steve Longerbeam wrote:
>>>
>>>
>>> On 07/07/2016 07:52 AM, Lars-Peter Clausen wrote:
On 07/07/2016 12:59 AM, Steve Longerbeam wrote:
> Add a device tree
Unfortunately, captions are new on Sphinx for c blocks: it was
added only on version 1.3. Also, it were already bad enough
not being able to auto-numerate them.
So, let's give up and use, instead, titles before the examples.
Not much is lost, and, as a side track, we don't need to
numerate them an
The lirc syscall documentation uses a very different and
simplified way than the rest of the media book. make it
closer. Still, there's just one page for all ioctls.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/rc/lirc_ioctl.rst | 187 +++--
Documenta
Just like the other parts of the document, let's add the LIRC
header, as it is part of the API.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/Makefile | 5 -
Documentation/media/lirc.h.rst.exceptions | 2 ++
Documentation/media/uapi/rc/remote_con
Just like the other parts of the media book, group the MC
functions together on one chapter.
Signed-off-by: Mauro Carvalho Chehab
---
.../media/uapi/mediactl/media-controller.rst | 20 +---
Documentation/media/uapi/mediactl/media-funcs.rst| 18 ++
2 fi
Some files start with an upper letter. Also, they have big
names. rename them.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
.../media/uapi/rc/{Remote_controllers_Intro.rst => rc-intro.rst} | 0
.../rc/{remote_controllers_sysfs_nodes.rst => rc-sysfs-nodes.rst} | 0
.../{Remot
There's no need to say: Table of Contents there. Also, this
generates a duplicated caption xref. So, remove, to use the
same format on every part.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/uapi/cec/cec-api.rst | 1 -
Documentation/media/uapi/v4l/v4l2.rst| 1 -
2 files chan
Now that the LIRC header was added, we can cross-reference it
and identify the documentation gaps.
There are lots of stuff missing there, but at least now we
can avoid the gap to increase.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/lirc.h.rst.exceptions | 72 +
45 matches
Mail list logo
