Re: [PATCHv2] v4l2-ctrl.h: fix comments

2016-06-15 Thread Sakari Ailus
On Wed, Jun 15, 2016 at 02:57:48PM +0200, Hans Verkuil wrote: > The comments for the unlocked v4l2_ctrl_s_ctrl* functions were wrong (copy > and pasted from the locked variants). Fix this, since it is confusing. > > Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sa

cron job: media_tree daily build: OK

2016-06-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jun 16 04:00:23 CEST 2016 git branch: test git hash: 7579639f37abeb025aebd89a67c7469790eb3853 gcc versi

Re: [PATCH 00/38] i.MX5/6 Video Capture

2016-06-15 Thread Steve Longerbeam
Hi Jack, On 06/15/2016 03:43 AM, Jack Mitchell wrote: > > Trying to use a user pointer rather than mmap also fails and causes a kernel > splat. > Hmm, I've tested userptr with the mem2mem driver, but maybe never with video capture. I tried "v4l2-ctl -d/dev/video0 --stream-user=8" but that retur

Re: [PATCH 35/38] media: adv7180: add power pin control

2016-06-15 Thread Steve Longerbeam
Hi Lars, On 06/15/2016 09:05 AM, Lars-Peter Clausen wrote: > On 06/15/2016 12:49 AM, Steve Longerbeam wrote: >> +usleep_range(5000, 5001); > That's kind of not how usleep_range() (the emphasis is on range) is supposed > to be used. You typically dont care too much about the upper limit

[PATCH] videodev2.h: Fix V4L2_PIX_FMT_YUV411P description

2016-06-15 Thread Laurent Pinchart
YUV 4:1:1 uses 12 bits per pixel on average, not 16. Signed-off-by: Laurent Pinchart --- include/uapi/linux/videodev2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 587b3c1c257e..49bdbc8dc25e 100644 ---

[PATCH] videodev2.h: Group YUV 3 planes formats together

2016-06-15 Thread Laurent Pinchart
The formats are interleaved with the YUV packed and miscellaneous formats, making the result confusing especially with the YUV444 format being packed and not planar like YUV410 or YUV420. Move them to their own group as the 2 planes or 3 non-contiguous planes formats to clarify the header. Signed-

[PATCH 3/3] media: i2c/soc_camera: fix ov6650 sensor getting wrong clock

2016-06-15 Thread Janusz Krzysztofik
After changes to v4l2_clk API introduced in v4.1 by commits a37462b919 '[media] V4L: remove clock name from v4l2_clk API' and 4f528afcfb '[media] V4L: add CCF support to the v4l2_clk API', ov6650 sensor stopped responding because v4l2_clk_get(), still called with depreciated V4L2 clock name "mclk",

[PATCH 2/3] staging: media: omap1: fix sensor probe not working anymore

2016-06-15 Thread Janusz Krzysztofik
After clock_start() removal from from soc_camera_probe() (commit 9aea470b39 '[media] soc-camera: switch I2C subdevice drivers to use v4l2-clk', introduced in v3.11), it occurred omap1_camera's sensor can't be probed successfully without its clock being turned on in advance. Fix that by surrounding

[PATCH 1/3] staging: media: omap1: fix null pointer dereference in omap1_cam_probe()

2016-06-15 Thread Janusz Krzysztofik
Commit 76e543382bd4 ("staging: media: omap1: Switch to devm_ioremap_resource") moved assignment of struct resource *res = platform_get_resource() several lines down. That resulted in the following error: [3.793237] Unable to handle kernel NULL pointer dereference at virtual address 0004 [

[linuxtv-media:master 229/231] DockBook: include/media/media-devnode.h:102: warning: No description found for parameter 'media_dev'

2016-06-15 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 6f0dd24a084a17f9984dd49dffbf7055bf123993 commit: a087ce704b802becbb4b0f2a20f2cb3f6911802e [229/231] [media] media-device: dynamically allocate struct media_devnode reproduce: make htmldocs All warnings (new ones prefixed by >>): include/

[PATCH 0/3] media: fixes for Amstrad Delta camera

2016-06-15 Thread Janusz Krzysztofik
Janusz Krzysztofik (3): staging: media: omap1: fix null pointer dereference in omap1_cam_probe() staging: media: omap1: fix sensor probe not working anymore media: i2c/soc_camera: fix ov6650 sensor getting wrong clock drivers/media/i2c/soc_camera/ov6650.c | 2 +- drivers/staging/m

Re: [PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-15 Thread Shuah Khan
On 06/15/2016 02:37 PM, Max Kellermann wrote: > On 2016/06/15 22:32, Shuah Khan wrote: >> This change introduces memory leaks, since drivers are relying on >> media_device_unregister() to free interfaces. > > This is what I thought, too, until I checked the code paths. Who adds > entries to that

Re: [PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-15 Thread Max Kellermann
On 2016/06/15 22:32, Shuah Khan wrote: > This change introduces memory leaks, since drivers are relying on > media_device_unregister() to free interfaces. This is what I thought, too, until I checked the code paths. Who adds entries to that list? Only media_gobj_create() does, and only when typ

Re: [PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-15 Thread Shuah Khan
On 06/15/2016 02:15 PM, Max Kellermann wrote: > While removing all interfaces in media_device_unregister(), all > media_interface pointers are freed. This is illegal and results in > double kfree() if any media_interface is still linked at this point; > maybe because a userspace process still has

[PATCH 1/3] drivers/media/dvb-core/en50221: use kref to manage struct dvb_ca_private

2016-06-15 Thread Max Kellermann
Don't free the object until the file handle has been closed. Fixes use-after-free bug which occurs when I disconnect my DVB-S received while VDR is running. Signed-off-by: Max Kellermann --- drivers/media/dvb-core/dvb_ca_en50221.c | 24 +++- 1 file changed, 23 insertions(+

[PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-15 Thread Max Kellermann
media_gobj_destroy() may be called twice on one instance - once by media_device_unregister() and again by dvb_media_device_free(). The function media_remove_intf_links() establishes and documents the convention that mdev==NULL means that the object is not registered, but nobody ever NULLs this var

[PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-15 Thread Max Kellermann
While removing all interfaces in media_device_unregister(), all media_interface pointers are freed. This is illegal and results in double kfree() if any media_interface is still linked at this point; maybe because a userspace process still has a file handle. Once the process closes the file handl

Need help with ir-keytable imon bug report

2016-06-15 Thread Gregor Jasny
Hello, could someone please help me triaging the following ir-keytable bug? The reporter complains that the 'other' IR protocol results in double clicks and we should set the device to RC6 instead: https://bugs.launchpad.net/ubuntu/+source/v4l-utils/+bug/1579760 This is what we have in v4l-utils

BUSINESS VORSCHLAG

2016-06-15 Thread Mr. phil
BUSINESS VORSCHLAG Ich vertrete eine Investition Interesse von Dubai für die wir Ihre Teilnahme als Vertreter Übersee suchen. Die Antwort auf e-Mail unten, wenn interessiert. E-Mail: philipber...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a

Re: [PATCH v3 2/2] media: et8ek8: Add documentation

2016-06-15 Thread Ivaylo Dimitrov
On 15.06.2016 21:41, Rob Herring wrote: On Tue, Jun 14, 2016 at 11:31 PM, Sakari Ailus wrote: Hi Rob, On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: Add DT bindings description Not exactly the best commit msg.

Re: [PATCH v3 2/2] media: et8ek8: Add documentation

2016-06-15 Thread Rob Herring
On Tue, Jun 14, 2016 at 11:31 PM, Sakari Ailus wrote: > Hi Rob, > > On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: >> On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: >> > Add DT bindings description >> >> Not exactly the best commit msg. >> >> > >> > Signed-off-by: I

Re: [PATCH v2] [media] adv7604: Add support for hardware reset

2016-06-15 Thread Laurent Pinchart
Hi Dragos, Thank you for the patch. On Tuesday 24 May 2016 17:33:27 Dragos Bogdan wrote: > The part can be reset by a low pulse on the RESET pin (i.e. a hardware > reset) with a minimum width of 5 ms. It is recommended to wait 5 ms > after the low pulse before an I2C write is performed to the par

Re: [PATCH 35/38] media: adv7180: add power pin control

2016-06-15 Thread Lars-Peter Clausen
On 06/15/2016 12:49 AM, Steve Longerbeam wrote: > + usleep_range(5000, 5001); That's kind of not how usleep_range() (the emphasis is on range) is supposed to be used. You typically dont care too much about the upper limit here so something like maybe 1 is more appropriate. > +sta

Astrometa DVB-T2 not working correctly with Kernel 4.6

2016-06-15 Thread Ferda Mravenec
Hello everybody, I own this TV stick: https://www.linuxtv.org/wiki/index.php/Astrometa_DVB-T2 It uses different chips to decode DVB-T and DVB-T2 streams, the required modules are rtl2832 and mn88473. Up until linux 4.5 it worked correctly, in 4.6 only DVB-T works. In 4.6 the mn88473 module is

[PATCHv2] v4l2-ctrl.h: fix comments

2016-06-15 Thread Hans Verkuil
The comments for the unlocked v4l2_ctrl_s_ctrl* functions were wrong (copy and pasted from the locked variants). Fix this, since it is confusing. Signed-off-by: Hans Verkuil --- Fixed the v4l2_ctrl_s_ctrl_int64() comment, which was inadvertently changed as well. Thanks to Ian Arkver for reportin

Re: [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled

2016-06-15 Thread Sebastian Reichel
Hi Andrew, On Tue, Jun 14, 2016 at 11:13:04AM -0500, Andrew F. Davis wrote: > If the HSI core is built as a module hsi_boardinfo may still > be built-in as its Kconfig type is bool, which can cause build > issues. Fix this by building this code into the HSI core when > enabled. > > Reported-by: k

Re: [very-RFC 7/8] AVB ALSA - Add ALSA shim for TSN

2016-06-15 Thread Richard Cochran
On Wed, Jun 15, 2016 at 02:13:03PM +0200, Henrik Austad wrote: > On Wed, Jun 15, 2016 at 01:49:08PM +0200, Richard Cochran wrote: > And how would v4l2 benefit from this being in alsalib? Should we require > both V4L and ALSA to implement the same, or should we place it in a common > place for all

Re: [PATCH] v4l2-ctrl.h: fix comments

2016-06-15 Thread Ian Arkver
On 15/06/16 11:10, Hans Verkuil wrote: The comments for the unlocked v4l2_ctrl_s_ctrl* functions were wrong (copy and pasted from the locked variants). Fix this, since it is confusing. Signed-off-by: Hans Verkuil diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h index 0bc9b3

Re: [very-RFC 7/8] AVB ALSA - Add ALSA shim for TSN

2016-06-15 Thread Henrik Austad
On Wed, Jun 15, 2016 at 01:49:08PM +0200, Richard Cochran wrote: > Now that I understand better... > > On Sun, Jun 12, 2016 at 01:01:35AM +0200, Henrik Austad wrote: > > Userspace is supposed to reserve bandwidth, find StreamID etc. > > > > To use as a Talker: > > > > mkdir /config/tsn/test/eth0

Re: [PATCH] [media] v4l2-ioctl.c: fix warning due wrong check in v4l_cropcap()

2016-06-15 Thread Javier Martinez Canillas
Hello Hans, On 06/15/2016 02:09 AM, Hans Verkuil wrote: > On 06/14/2016 10:18 PM, Javier Martinez Canillas wrote: >> Commit 95dd7b7e30f3 ("[media] v4l2-ioctl.c: improve cropcap compatibility >> code") tried to check if both .vidioc_cropcap and .vidioc_g_selection are >> NULL ops and warn if that w

Re: [very-RFC 7/8] AVB ALSA - Add ALSA shim for TSN

2016-06-15 Thread Richard Cochran
Now that I understand better... On Sun, Jun 12, 2016 at 01:01:35AM +0200, Henrik Austad wrote: > Userspace is supposed to reserve bandwidth, find StreamID etc. > > To use as a Talker: > > mkdir /config/tsn/test/eth0/talker > cd /config/tsn/test/eth0/talker > echo 65535 > buffer_size > echo 08:00

Re: [very-RFC 0/8] TSN driver for the kernel

2016-06-15 Thread Richard Cochran
On Wed, Jun 15, 2016 at 09:04:41AM +0200, Richard Cochran wrote: > On Tue, Jun 14, 2016 at 10:38:10PM +0200, Henrik Austad wrote: > > Whereas I want to do > > > > aplay some_song.wav > > Can you please explain how your patches accomplish this? Never mind. Looking back, I found it in patch #7.

Re: [PATCH 00/38] i.MX5/6 Video Capture

2016-06-15 Thread Hans Verkuil
On 06/15/16 12:43, Jack Mitchell wrote: > On 14/06/16 23:48, Steve Longerbeam wrote: >> Tested on imx6q SabreAuto with ADV7180, and imx6q SabreSD with >> mipi-csi2 OV5640. There is device-tree support also for imx6qdl >> SabreLite, but that is not tested. Also, this driver should >> theoretically w

Re: [PATCH 00/38] i.MX5/6 Video Capture

2016-06-15 Thread Jack Mitchell
On 14/06/16 23:48, Steve Longerbeam wrote: Tested on imx6q SabreAuto with ADV7180, and imx6q SabreSD with mipi-csi2 OV5640. There is device-tree support also for imx6qdl SabreLite, but that is not tested. Also, this driver should theoretically work on i.MX5 targets, but that is also untested. I

[PATCH] v4l2-ctrl.h: fix comments

2016-06-15 Thread Hans Verkuil
The comments for the unlocked v4l2_ctrl_s_ctrl* functions were wrong (copy and pasted from the locked variants). Fix this, since it is confusing. Signed-off-by: Hans Verkuil diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h index 0bc9b35..e9e87e023 100644 --- a/include/media/v

[PATCH] jpeg_memsrcdest: extend feature check

2016-06-15 Thread Patrick Ohly
libjpeg.h in OpenEmbedded master (from libjpeg-turbo 1.5.0) provides these methods if "JPEG_LIB_VERSION >= 80 || defined(MEM_SRCDST_SUPPORTED)". The support for the jpeg_mem functions was added even when not emulating the libjpeg8 API, controlled via the MEM_SRCDST_SUPPORTED define, so checking fo

Re: EIT off-air tables for HD in UK

2016-06-15 Thread Jemma Denson
On 14/06/16 19:31, Nick Whitehead wrote: I've just started to use this to recover EIT information from the transmitted stream (UK, freeview). I've managed to get the tables OK, but the EIT name / description for all HD channels is scrambled. Some research indicates these are huffman encoded f

Re: [very-RFC 0/8] TSN driver for the kernel

2016-06-15 Thread Richard Cochran
On Wed, Jun 15, 2016 at 12:15:24PM +0900, Takashi Sakamoto wrote: > > On Mon, Jun 13, 2016 at 01:47:13PM +0200, Richard Cochran wrote: > >> I have seen audio PLL/multiplier chips that will take, for example, a > >> 10 kHz input and produce your 48 kHz media clock. With the right HW > >> design, yo

Re: [very-RFC 0/8] TSN driver for the kernel

2016-06-15 Thread Henrik Austad
On Wed, Jun 15, 2016 at 09:04:41AM +0200, Richard Cochran wrote: > On Tue, Jun 14, 2016 at 10:38:10PM +0200, Henrik Austad wrote: > > Whereas I want to do > > > > aplay some_song.wav > > Can you please explain how your patches accomplish this? In short: modprobe tsn modprobe avb_alsa mkdir /sy

Re: [very-RFC 0/8] TSN driver for the kernel

2016-06-15 Thread Richard Cochran
On Tue, Jun 14, 2016 at 10:38:10PM +0200, Henrik Austad wrote: > Where is your media-application in this? Um, that *is* a media application. It plays music on the sound card. > You only loop the audio from > network to the dsp, is the media-application attached to the dsp-device? Sorry, I thou

Re: [very-RFC 0/8] TSN driver for the kernel

2016-06-15 Thread Richard Cochran
On Tue, Jun 14, 2016 at 10:38:10PM +0200, Henrik Austad wrote: > Whereas I want to do > > aplay some_song.wav Can you please explain how your patches accomplish this? Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@