Re: [PATCH] [media] stk1160: Check *nplanes in queue_setup

On 05/10/2016 05:06 AM, Helen Koike wrote: > If *nplanes is not zero, it should use the requested size if valid *nplanes is never 0 since the create_buffers ioctl isn't implemented in this driver. Adding support for it (simply use vb2_create_buffers) would make sense. Regards, Hans >

RE: V4L2 SDR compliance test?

Hi Mauro, > Ramesh Shanmugasundaram escreveu: > > > Hi Mauro, > > > > Thanks for the clarifications. > > > > > Ramesh Shanmugasundaram > escreveu: > > > > > > > Hi Maintainers, All, > > > > > > > > Renesas R-Car SoCs have Digital Radio Interface (DRIF) controllers. > > > > They are receive only

[PATCH] [media] m88rs2000: initialize status to zero

From: Colin Ian King status is not initialized so it can contain garbage. The check for status containing the FE_HAS_LOCK bit may randomly pass or fail if the read of register 0x8c fails to set status after 25 read attempts. Fix this by initializing status to 0. Issue found with CoverityScan, C

[PATCH] [media] stk1160: Check *nplanes in queue_setup

If *nplanes is not zero, it should use the requested size if valid Signed-off-by: Helen Koike --- drivers/media/usb/stk1160/stk1160-v4l.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/stk1160/stk1160-v4l.c b/drivers/media/usb/stk1160/stk1160-v4l.c index 77131fd..7ddbc

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue May 10 04:00:27 CEST 2016 git branch: test git hash: d1532d5575696965a52b19553dd7dacf75f3fec5 gcc versi

Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver

Hi, On Mon, May 09, 2016 at 04:07:35PM -0500, Rob Herring wrote: > There's already a pwm-led binding that can be used. Though there > may be missing consumer IR to LED subsystem support in the kernel. > You could list both compatibles, use the rx51 IR driver now, and > then move to pwm-led driver

Re: [PATCH 2/2] [media] media-device: dynamically allocate struct media_devnode

On 05/09/2016 09:03 AM, Mauro Carvalho Chehab wrote: > Em Mon, 9 May 2016 14:40:02 +0300 > Laurent Pinchart escreveu: > >> Hi Mauro, >> >> Thank you for the patch. >> >> On Saturday 07 May 2016 12:12:09 Mauro Carvalho Chehab wrote: >>> struct media_devnode is currently embedded at struct media_de

Re: [PATCH 2/2] uvc: correct speed testing

Hi Oliver, Thank you for the patch. On Monday 02 May 2016 13:23:21 Oliver Neukum wrote: > Allow for SS+ USB devices > > Signed-off-by: Oliver Neukum Reviewed-by: Laurent Pinchart And applied to my tree. > --- > drivers/media/usb/uvc/uvc_video.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver

On 10.05.2016 00:07, Rob Herring wrote: On Mon, May 9, 2016 at 3:53 PM, Ivaylo Dimitrov wrote: Hi, On 9.05.2016 23:06, Rob Herring wrote: On Sat, May 07, 2016 at 06:21:45PM +0300, Ivaylo Dimitrov wrote: With the upcoming removal of legacy boot, lets add support to one of the last N900 d

Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver

On Mon, May 9, 2016 at 3:53 PM, Ivaylo Dimitrov wrote: > Hi, > > On 9.05.2016 23:06, Rob Herring wrote: >> >> On Sat, May 07, 2016 at 06:21:45PM +0300, Ivaylo Dimitrov wrote: >>> >>> With the upcoming removal of legacy boot, lets add support to one of the >>> last N900 drivers remaining without i

Re: [PATCH 3/3] v4l: subdev: Call pad init_cfg operation when opening subdevs

Hi Laurent, On Mon, May 09, 2016 at 07:18:11PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Wednesday 04 May 2016 14:25:33 Sakari Ailus wrote: > > From: Laurent Pinchart > > > > The subdev core code currently rely on the subdev open handler to > > initialize the file handle's pad configur

Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver

Hi, On 9.05.2016 23:06, Rob Herring wrote: On Sat, May 07, 2016 at 06:21:45PM +0300, Ivaylo Dimitrov wrote: With the upcoming removal of legacy boot, lets add support to one of the last N900 drivers remaining without it. As the driver still uses omap dmtimer, add auxdata as well. Signed-off-b

Re: [PATCH 5/7] ARM: OMAP: dmtimer: Do not call PM runtime functions when not needed.

Hi, On 9.05.2016 22:36, Tony Lindgren wrote: * Ivaylo Dimitrov [160507 08:24]: once omap_dm_timer_start() is called, which calls omap_dm_timer_enable() and thus pm_runtime_get_sync(), it doesn't make sense to call PM runtime functions again before omap_dm_timer_stop is called(). Otherwise PM

Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver

On Sat, May 07, 2016 at 06:21:45PM +0300, Ivaylo Dimitrov wrote: > With the upcoming removal of legacy boot, lets add support to one of the > last N900 drivers remaining without it. As the driver still uses omap > dmtimer, add auxdata as well. > > Signed-off-by: Ivaylo Dimitrov > --- > .../devic

Re: [PATCH 2/7] pwm: omap-dmtimer: Allow for setting dmtimer clock source

On Sat, May 07, 2016 at 06:21:43PM +0300, Ivaylo Dimitrov wrote: > OMAP GP timers can have different input clocks that allow different PWM > frequencies. However, there is no other way of setting the clock source but > through clocks or clock-names properties of the timer itself. This limits > PWM

Re: [PATCH 5/7] ARM: OMAP: dmtimer: Do not call PM runtime functions when not needed.

* Ivaylo Dimitrov [160507 08:24]: > once omap_dm_timer_start() is called, which calls omap_dm_timer_enable() > and thus pm_runtime_get_sync(), it doesn't make sense to call PM runtime > functions again before omap_dm_timer_stop is called(). Otherwise PM runtime > functions called in omap_dm_timer_

[PATCH 2/2] [media] em28xx: add missing USB IDs

Add missing USB id's for em281xx devices. Signed-off-by: Mauro Carvalho Chehab --- Documentation/video4linux/CARDLIST.em28xx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/video4linux/CARDLIST.em28xx b/Documentation/video4linux/CARDLIST.em28xx ind

[PATCH 1/2] [media] update cx23885 and em28xx cardlists

Some new boards were added without updating those lists. Signed-off-by: Mauro Carvalho Chehab --- Documentation/video4linux/CARDLIST.cx23885 | 2 ++ Documentation/video4linux/CARDLIST.em28xx | 1 + 2 files changed, 3 insertions(+) diff --git a/Documentation/video4linux/CARDLIST.cx23885 b/Docu

Re: [PATCH 3/3] v4l: subdev: Call pad init_cfg operation when opening subdevs

Hi Sakari, On Wednesday 04 May 2016 14:25:33 Sakari Ailus wrote: > From: Laurent Pinchart > > The subdev core code currently rely on the subdev open handler to > initialize the file handle's pad configuration, even though subdevs now > have a pad operation dedicated for that purpose. > > As a f

[PATCH] v4l2-compliance: Improve test readability when fail

In case of failure, print "q.create_bufs(node, 1, &fmt) != EINVAL" instead of "ret != EINVAL" Signed-off-by: Helen Koike --- Hello, I was wondering, why the q.create_bufs is expected to should return EINVAL in this test? The height and size are set to half of the original values, and the type

Re: V4L2 SDR compliance test?

Em Mon, 9 May 2016 13:59:52 + Ramesh Shanmugasundaram escreveu: > Hi Mauro, > > Thanks for the clarifications. > > > Ramesh Shanmugasundaram escreveu: > > > > > Hi Maintainers, All, > > > > > > Renesas R-Car SoCs have Digital Radio Interface (DRIF) controllers. > > > They are receive on

[PATCH v7 2/3] SMAF: add CMA allocator

SMAF CMA allocator implement helpers functions to allow SMAF to allocate contiguous memory. match() each if at least one of the attached devices have coherent_dma_mask set to DMA_BIT_MASK(32). For allocation it use dma_alloc_attrs() with DMA_ATTR_WRITE_COMBINE and not dma_alloc_writecombine to be

[PATCH v7 0/3] Secure Memory Allocation Framework

version 7 changes: - rebased on kernel 4.6-rc7 - simplify secure module API - add vma ops to be able to detect mmap/munmap calls - add ioctl to get number and allocator names - update libsmaf with adding tests https://git.linaro.org/people/benjamin.gaignard/libsmaf.git - add debug log in f

[PATCH v7 1/3] create SMAF module

Secure Memory Allocation Framework goal is to be able to allocate memory that can be securing. There is so much ways to allocate and securing memory that SMAF doesn't do it by itself but need help of additional modules. To be sure to use the correct allocation method SMAF implement deferred allocat

[PATCH v7 3/3] SMAF: add fake secure module

This module is allow testing secure calls of SMAF. Signed-off-by: Benjamin Gaignard --- drivers/smaf/Kconfig | 6 +++ drivers/smaf/Makefile | 1 + drivers/smaf/smaf-fakesecure.c | 85 ++ 3 files changed, 92 insertions(+) create mode 1

Re: [PATCH 2/2] [media] media-device: dynamically allocate struct media_devnode

Em Mon, 9 May 2016 14:40:02 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Saturday 07 May 2016 12:12:09 Mauro Carvalho Chehab wrote: > > struct media_devnode is currently embedded at struct media_device. > > s/at/in/ > > > While this works fine during norm

RE: V4L2 SDR compliance test?

Hi Mauro, Thanks for the clarifications. > Ramesh Shanmugasundaram escreveu: > > > Hi Maintainers, All, > > > > Renesas R-Car SoCs have Digital Radio Interface (DRIF) controllers. > > They are receive only SPI slave modules that support I2S format. The > > targeted application of these control

Re: [PATCH v2.1 3/5] media: Refactor copying IOCTL arguments from and to user space

Hi Laurent, Many thanks for the review! Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Wednesday 04 May 2016 16:09:51 Sakari Ailus wrote: >> Refactor copying the IOCTL argument structs from the user space and back, >> in order to reduce code copied around and make the

Re: [RESEND PATCH] [media] s5p-mfc: don't close instance after free OUTPUT buffers

Le vendredi 06 mai 2016 à 18:11 -0400, Javier Martinez Canillas a écrit : > From: ayaka > > User-space applications can use the VIDIOC_REQBUFS ioctl to determine > if a > memory mapped, user pointer or DMABUF based I/O is supported by the > driver. > > So a set of VIDIOC_REQBUFS ioctl calls will

Re: [RESEND PATCH] [media] s5p-mfc: don't close instance after free OUTPUT buffers

Hello Nicolas, Thanks for your feedback. On 05/06/2016 09:25 PM, Nicolas Dufresne wrote: > Thanks for re-submitting. See inline two typos to fix in teh comment. > You are welcome, as we talked in IRC you needed this to make video decoding in your Exynos4412 Odroid X2 board, so it would be great

Re: [PATCH v2 4/5] media: Add flags to tell whether to take graph mutex for an IOCTL

Hi Sakari, Thank you for the patch. On Wednesday 04 May 2016 14:20:54 Sakari Ailus wrote: > New IOCTLs (especially for the request API) do not necessarily need the > graph mutex acquired. Leave this up to the drivers. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > dri

Re: [PATCH v2 2/5] media: Unify IOCTL handler calling

Hi Sakari, Thank you for the patch. On Wednesday 04 May 2016 14:20:52 Sakari Ailus wrote: > Each IOCTL handler can be listed in an array instead of using a large and > cumbersome switch. Do that. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > drivers/media/media-devic

Re: [PATCH v2 1/5] media: Determine early whether an IOCTL is supported

Hi Sakari, Thank you for the patch. On Wednesday 04 May 2016 14:20:51 Sakari Ailus wrote: > Preparation for refactoring media IOCTL handling to unify common parts. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > drivers/media/media-device.c | 52 +++

Re: [PATCH v2.1 3/5] media: Refactor copying IOCTL arguments from and to user space

Hi Sakari, Thank you for the patch. On Wednesday 04 May 2016 16:09:51 Sakari Ailus wrote: > Refactor copying the IOCTL argument structs from the user space and back, > in order to reduce code copied around and make the implementation more > robust. > > As a result, the copying is done while not

Re: [PATCH 2/2] [media] media-device: dynamically allocate struct media_devnode

Hi Mauro, Thank you for the patch. On Saturday 07 May 2016 12:12:09 Mauro Carvalho Chehab wrote: > struct media_devnode is currently embedded at struct media_device. s/at/in/ > While this works fine during normal usage, it leads to a race > condition during devnode unregister. Strictly speakin

Re: Driver for Magewell PCIe capture cards

Hi Will, Em Thu, 05 May 2016 17:09:46 +0100 Will Manley escreveu: > Hi There > > Magewell are a manufacturer of video-capture devices. They have both > USB and PCIe devices. The USB devices use the upstream uvcvideo driver > and Magewell currently provide proprietary drivers for their PCIe >

Re: [PATCH v4] media: vb2-dma-contig: configure DMA max segment size properly

Em Mon, 09 May 2016 08:13:06 +0200 Marek Szyprowski escreveu: > Hi Mauro > > > On 2016-05-06 20:52, Mauro Carvalho Chehab wrote: > > Em Wed, 04 May 2016 11:00:03 +0200 > > Marek Szyprowski escreveu: > > > >> This patch lets vb2-dma-contig memory allocator to configure DMA max > >> segment si

V4L2 SDR compliance test?

Hi Maintainers, All, Renesas R-Car SoCs have Digital Radio Interface (DRIF) controllers. They are receive only SPI slave modules that support I2S format. The targeted application of these controllers is SDR. While evaluating the V4L2 SDR framework for this controller, we noticed the compliance

[patch v2][media] em28xx-i2c: rt_mutex_trylock() returns zero on failure

The code is checking for negative returns but it should be checking for zero. Fixes: aab3125c43d8 ('[media] em28xx: add support for registering multiple i2c buses') Signed-off-by: Dan Carpenter --- Use different error code. diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb

Re: gstreamer: v4l2videodec plugin

On 05/02/2016 12:48 AM, Nicolas Dufresne wrote: > Le jeudi 28 avril 2016 à 14:33 +0300, Stanimir Varbanov a écrit : >> So I'm wondering is that intensional? >> >> Depending on the answer I should make the same in the Gallium dri2 in >> dri2_from_dma_bufs(). > > It's DRI format that are confusing.