[PATCH] media: videobuf2-core: Fix one __qbuf_dmabuf() error path

2015-12-08 Thread Wu, Xia
Add dma_buf_put() to decrease refcount of the dmabuf in error path if DMABUF size is smaller than the requirement. Signed-off-by: wu xia --- drivers/media/v4l2-core/videobuf2-core.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/

cron job: media_tree daily build: ERRORS

2015-12-08 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Dec 9 04:00:23 CET 2015 git branch: test git hash: 991ce92f8de24cde063d531246602b6e14d3fef2 gcc versio

Re: Failed to build on 4.2.6

2015-12-08 Thread Greg Kroah-Hartman
On Mon, Dec 07, 2015 at 10:25:19AM -0500, Steven Rostedt wrote: > Hi, > > The attached config doesn't build on 4.2.6, but changing it to the > following: > > VIDEO_V4L2_SUBDEV_API n -> y > +V4L2_FLASH_LED_CLASS n > > does build. Did this work on older kernels (4.2.5? .4? older?) thanks, gr

Re: [v4l-utils PATCH RESEND 0/2] Add field support to libv4l2subdev

2015-12-08 Thread Laurent Pinchart
Hi Sakari, On Tuesday 08 December 2015 17:09:21 Sakari Ailus wrote: > Hi Laurent, > > Just resending after a rebase, no change in the patches. > > The earlier set is here: > > http://www.spinics.net/lists/linux-media/msg94605.html> Thank you for the patch. I've pushed them to the public git tr

Re: [PATCH] v4l: Fix dma buf single plane compat handling

2015-12-08 Thread Laurent Pinchart
Hi Sakari, On Tuesday 08 December 2015 17:29:16 Sakari Ailus wrote: > On Mon, Dec 07, 2015 at 10:45:39AM +0200, Laurent Pinchart wrote: > > From: Gjorgji Rosikopulos > > > > Buffer length is needed for single plane as well, otherwise > > is uninitialized and behaviour is undetermined. > > How a

Re: DVBSky T980C ci not working with kernel 4.x

2015-12-08 Thread Torbjorn Jansson
On 2015-12-08 04:49, Nibble Max wrote: Does this card work with the media code from dvbsky.net from kernel 4.x? On 2015-12-06 19:10:41, Timo_Helkiƶ wrote: Hi Common interface in Dvbsky T980C is not working with Ubuntu 15.10 kernel 4.2.0 and vanilla kernel 4.6 and latest dvb-drivers from Li

Re: [PATCH v8 50/55] [media] media-entity: unregister entity links

2015-12-08 Thread Mauro Carvalho Chehab
Em Mon, 23 Nov 2015 23:27:40 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 06 September 2015 09:03:10 Mauro Carvalho Chehab wrote: > > Add functions to explicitly unregister all entity links. > > This function is called automatically when an entity > >

Re: [PATCH v8 49/55] [media] media-device: add support for MEDIA_IOC_G_TOPOLOGY ioctl

2015-12-08 Thread Mauro Carvalho Chehab
Em Fri, 11 Sep 2015 16:08:54 +0200 Hans Verkuil escreveu: > On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > > Add support for the new MEDIA_IOC_G_TOPOLOGY ioctl, according > > with the RFC for the MC next generation. > > > > Signed-off-by: Mauro Carvalho Chehab > > Two comments: > > >

Re: [PATCH v8 49/55] [media] media-device: add support for MEDIA_IOC_G_TOPOLOGY ioctl

2015-12-08 Thread Mauro Carvalho Chehab
Em Tue, 24 Nov 2015 00:04:02 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > Sakari and Hans have made several comments on this and the previous version > of > the same patch and I generally agree with them. I'll thus review the next > version. What next versio

Re: [PATCH v8 48/55] [media] media_device: add a topology version field

2015-12-08 Thread Mauro Carvalho Chehab
Em Tue, 24 Nov 2015 00:18:07 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Friday 04 September 2015 14:08:27 Mauro Carvalho Chehab wrote: > > Em Mon, 31 Aug 2015 15:35:38 +0200 Hans Verkuil escreveu: > > > On 08/31/2015 02:52 PM, Mauro Carvalho Chehab wrote: > > >> Em Mon, 31 Aug 2015 14:2

Re: [PATCH v8 44/55] [media] uapi/media.h: Add MEDIA_IOC_G_TOPOLOGY ioctl

2015-12-08 Thread Arnd Bergmann
On Tuesday 08 December 2015 17:23:40 Mauro Carvalho Chehab wrote: > > > + > > > +struct media_v2_topology { > > > + __u32 topology_version; > > > + > > > + __u32 num_entities; > > > + struct media_v2_entity *entities; > > > > The kernel seems to be moving to using __u64 instead of pointers i

[PATCH v2 2/2] media: rc: improve lirc module detection

2015-12-08 Thread Heiner Kallweit
Improve detection whether lirc codec is loaded and avoid dependency on config symbols and having to check for a specific module. This also fixes the bug that the current check checks for module lirc_dev instead of ir_lirc_codec (which depends on lirc_dev). If the ir_lirc_codec module is unloaded t

Re: [PATCH v8 46/55] [media] media: move mdev list init to gobj

2015-12-08 Thread Mauro Carvalho Chehab
Em Tue, 24 Nov 2015 00:32:49 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 06 September 2015 09:03:06 Mauro Carvalho Chehab wrote: > > Let's control the topology changes inside the graph_object. So, move the > > addition and removal of interfaces/entiti

Re: [PATCH] v4l: Fix dma buf single plane compat handling

2015-12-08 Thread grosikopulos
Hi Sakari, > Hi Laurent and Gjorgji, > > On Mon, Dec 07, 2015 at 10:45:39AM +0200, Laurent Pinchart wrote: >> From: Gjorgji Rosikopulos grosikopu...@mm-sol.com >> >> Buffer length is needed for single plane as well, otherwise >> is uninitialized and behaviour is undetermined. > > How about: >

Re: [PATCH v8 44/55] [media] uapi/media.h: Add MEDIA_IOC_G_TOPOLOGY ioctl

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 02:47:39 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 06 September 2015 09:03:04 Mauro Carvalho Chehab wrote: > > Add a new ioctl that will report the entire topology on > > one go. > > > > Signed-off-by: Mauro Carvalho Chehab > >

Re: [PATCH v8 43/55] [media] media: report if a pad is sink or source at debug msg

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 02:53:57 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 06 September 2015 09:03:03 Mauro Carvalho Chehab wrote: > > Sometimes, it is important to see if the created pad is > > sink or source. Add info to track that. > > > > Signed-of

Re: [PATCH v8 41/55] [media] DocBook: update descriptions for the media controller entities

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 03:00:57 +0200 Laurent Pinchart escreveu: > Hello, > > On Friday 11 September 2015 15:13:30 Hans Verkuil wrote: > > On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > > > Cleanup the media controller entities description: > > > - remove MEDIA_ENT_T_DEVNODE and MEDIA_ENT_T

Re: [PATCH v8 37/55] [media] omap4iss: stop MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 03:46:28 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:48 Mauro Carvalho Chehab wrote: > > This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, as it uses a > > hack to check if the remote entity is a subdev. Get rid

Re: [PATCH v8 38/55] [media] v4l2-subdev: use MEDIA_ENT_T_UNKNOWN for new subdevs

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 03:37:59 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > In addition to my reply to Sakari's e-mail, please see below for a few small > comments. > > On Sunday 06 September 2015 09:02:58 Mauro Carvalho Chehab wrote: > > Instead of abusing MEDI

Re: [PATCH v8 36/55] [media] davinci_vbpe: stop MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 03:52:01 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:47 Mauro Carvalho Chehab wrote: > > This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV: > > > > - it uses a hack to check if the remote entity is a subdev; > >

Re: [PATCH v8 35/55] [media] s5k5baf: fix subdev type

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 03:55:32 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:46 Mauro Carvalho Chehab wrote: > > X-Patchwork-Delegate: m.che...@samsung.com > > This sensor driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, creating > > some s

Re: [PATCH v8 34/55] [media] s5c73m3: fix subdev type

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 03:57:56 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:45 Mauro Carvalho Chehab wrote: > > This sensor driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, creating > > some subdevs with a non-existing type. > > > > As th

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-12-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Dec 2015 15:05:51 -0200 Mauro Carvalho Chehab escreveu: > Em Tue, 8 Dec 2015 13:57:55 -0200 > Mauro Carvalho Chehab escreveu: > > > Em Mon, 12 Oct 2015 18:35:05 +0300 > > Sakari Ailus escreveu: > > > > > Hi Mauro, > > > > > > On Sun, Oct 11, 2015 at 09:56:25PM -0300, Mauro Carvalho

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-12-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Dec 2015 13:57:55 -0200 Mauro Carvalho Chehab escreveu: > Em Mon, 12 Oct 2015 18:35:05 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Sun, Oct 11, 2015 at 09:56:25PM -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 12 Oct 2015 00:07:52 +0300 > > > Sakari Ailus escreveu:

Re: [PATCH v8 33/55] [media] omap3/omap4/davinci: get rid of MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 04:08:17 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:44 Mauro Carvalho Chehab wrote: > > On omap3/omap4/davinci drivers, MEDIA_ENT_T_V4L2_SUBDEV macro is > > abused in order to "simplify" the pad checks. > > A

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 04:16:15 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:43 Mauro Carvalho Chehab wrote: > > Instead of relying on media subtype, use the new macros to detect > > if an entity is a subdev or an A/V DMA entity. > >

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-12-08 Thread Mauro Carvalho Chehab
Em Mon, 12 Oct 2015 18:35:05 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Sun, Oct 11, 2015 at 09:56:25PM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 12 Oct 2015 00:07:52 +0300 > > Sakari Ailus escreveu: > > > > > Hi Mauro, > > > > > > On Sun, Aug 30, 2015 at 12:06:43AM -0300, Mauro Ca

Re: [PATCH v8 31/55] [media] media: add macros to check if subdev or V4L2 DMA

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 04:20:38 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 06 September 2015 09:02:57 Mauro Carvalho Chehab wrote: > > As we'll be removing entity subtypes from the Kernel, we need > > to provide a way for drivers and core to check if a

Re: [PATCH] v4l: Fix dma buf single plane compat handling

2015-12-08 Thread Sakari Ailus
Hi Laurent and Gjorgji, On Mon, Dec 07, 2015 at 10:45:39AM +0200, Laurent Pinchart wrote: > From: Gjorgji Rosikopulos > > Buffer length is needed for single plane as well, otherwise > is uninitialized and behaviour is undetermined. How about: The v4l2_buffer length field must be passed as well

[v4l-utils PATCH 1/1] Allow building static binaries

2015-12-08 Thread Sakari Ailus
$ LDFLAGS="--static -static" ./configure --enable-static $ LDFLAGS=-static make can be used to create static binaries. The issue was that shared libraries were attempted to link statically which naturally failed. Signed-off-by: Sakari Ailus --- lib/libv4l1/Makefile.am | 3 +-- l

[v4l-utils PATCH v2 0/3] List supported formats in libv4l2subdev

2015-12-08 Thread Sakari Ailus
Hi, Rebased on current v4l-utils. There were conflicts as new media bus formats were added. The earlier version is here: http://www.spinics.net/lists/linux-media/msg94619.html> These patches go on top of the field support set, which hasn't appeared in the archive yet. The earlier version is here

[v4l-utils PATCH v2 3/3] media-ctl: List supported media bus formats

2015-12-08 Thread Sakari Ailus
Add a new topic option for -h to allow listing supported media bus codes in conversion functions. This is useful in figuring out which media bus codes are actually supported by the library. The numeric values of the codes are listed as well. Signed-off-by: Sakari Ailus --- utils/media-ctl/option

[v4l-utils PATCH v2 1/3] libv4l2subdev: Use generated format definitions in libv4l2subdev

2015-12-08 Thread Sakari Ailus
Instead of manually adding each and every new media bus pixel code to libv4l2subdev, generate the list automatically. The pre-existing formats that do not match the list are not modified so that existing users are unaffected by this change, with the exception of converting codes to strings, which w

[v4l-utils PATCH v2 2/3] libv4l2subdev: Add a function to list library supported pixel codes

2015-12-08 Thread Sakari Ailus
Also mark which format definitions are compat definitions for the pre-existing codes. This way we don't end up listing the same formats twice. Signed-off-by: Sakari Ailus --- utils/media-ctl/libv4l2subdev.c | 69 +++-- utils/media-ctl/v4l2subdev.h| 11

[v4l-utils PATCH RESEND 1/2] libv4l2subdev: Add a forward definition for missing struct media_device

2015-12-08 Thread Sakari Ailus
This avoids a compiler warning if mediactl.h isn't included. Signed-off-by: Sakari Ailus --- utils/media-ctl/v4l2subdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/utils/media-ctl/v4l2subdev.h b/utils/media-ctl/v4l2subdev.h index 1cb53ff..4961308 100644 --- a/utils/media-ctl/v4l2subdev

[v4l-utils PATCH RESEND 2/2] media-ctl: Add field support for the media bus format

2015-12-08 Thread Sakari Ailus
From: Laurent Pinchart Signed-off-by: Laurent Pinchart Use strncasecmp() instead of strncmp() when comparing field names and add documentation on setting the field value. Wrap a few lines as well. Signed-off-by: Sakari Ailus --- utils/media-ctl/libv4l2subdev.c | 64 ++

[v4l-utils PATCH RESEND 0/2] Add field support to libv4l2subdev

2015-12-08 Thread Sakari Ailus
Hi Laurent, Just resending after a rebase, no change in the patches. The earlier set is here: http://www.spinics.net/lists/linux-media/msg94605.html> -- Kind regards, Sakari -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.ke

Re: [PATCH 3/7] of: reserved_mem: add support for named reserved mem nodes

2015-12-08 Thread Rob Herring
On Mon, Dec 7, 2015 at 6:08 AM, Marek Szyprowski wrote: > This patch allows device drivers to use more than one reserved memory > region assigned to given device. When NULL name is passed to > of_reserved_mem_device_init(), the default (first) region is used. Every property that's an array does n

[PATCH] media: s5p-jpeg: Adjust buffer size for Exynos 4412

2015-12-08 Thread Marek Szyprowski
From: Andrzej Pietrasiewicz Eliminate iommu fault during encoding by adjusting image size used for buffer size computation and ensuring that the buffer is not overrun. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Marek Szyprowski --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 7

Re: [PATCH v8 14/55] [media] media: add functions to allow creating interfaces

2015-12-08 Thread Mauro Carvalho Chehab
Em Fri, 11 Sep 2015 14:57:41 +0200 Hans Verkuil escreveu: > On 09/06/2015 02:02 PM, Mauro Carvalho Chehab wrote: > > Interfaces are different than entities: they represent a > > Kernel<->userspace interaction, while entities represent a > > piece of hardware/firmware/software that executes a func

[PATCH] [media] exynos4-is: fix a format string bug

2015-12-08 Thread Rasmus Villemoes
Ironically, 7d4020c3c400 ("[media] exynos4-is: fix some warnings when compiling on arm64") fixed some format string bugs but introduced a new one. buf_index is a simple int, so it should be printed with %d, not %pad (which is correctly used for dma_addr_t). Fixes: 7d4020c3c400 ("[media] exynos4-is

Re: [PATCH] rcar_jpu: add fallback compatibility string

2015-12-08 Thread Sergei Shtylyov
Hello. On 12/8/2015 8:42 AM, Simon Horman wrote: Add fallback compatibility string. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman --- Documentation/devicetree/bindings/media/renesas,jpu.txt | 13 +

Re: [PATCH 0/7] Exynos: MFC driver: reserved memory cleanup and IOMMU support

2015-12-08 Thread Marek Szyprowski
Hello, On 2015-12-07 13:08, Marek Szyprowski wrote: This patchset finally perform cleanup of custom code in s5p-mfc codec driver. The first part is removal of custom, driver specific code for intializing and handling of reserved memory. Instead, a generic code for reserved memory regions is used