Re: [PATCH v7 13/44] [media] uapi/media.h: Declare interface types

2015-08-24 Thread Hans Verkuil
On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > Declare the interface types that will be used by the new > G_TOPOLOGY ioctl that will be defined latter on. > > For now, we need those types, as they'll be used on the > internal structs associated with the new media_interface > graph object d

Re: [PATCH v7 12/44] [media] media: remove media entity .parent field

2015-08-24 Thread Hans Verkuil
On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > Now that the struct media_entity .parent field is unused, it can be > safely removed. Since all the previous users were converted to use > the .mdev field from the embedded struct media_gobj instead. > > Su

Re: [PATCH v7 11/44] [media] media: use entity.graph_obj.mdev instead of .parent

2015-08-24 Thread Hans Verkuil
On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > The struct media_entity has a .parent field that stores a pointer > to the parent struct media_device. But recently a media_gobj was > embedded into the entities and since struct media_gojb already has > a p

Re: [PATCH v7 03/44] [media] omap3isp: get entity ID using media_entity_id()

2015-08-24 Thread Hans Verkuil
On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > X-Patchwork-Delegate: laurent.pinch...@ideasonboard.com > The struct media_entity does not have an .id field anymore since > now the entity ID is stored in the embedded struct media_gobj. > > This caused th

Re: [PATCH v7 02/44] [media] staging: omap4iss: get entity ID using media_entity_id()

2015-08-24 Thread Hans Verkuil
On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > The struct media_entity does not have an .id field anymore since > now the entity ID is stored in the embedded struct media_gobj. > > This caused the omap4iss driver fail to build. Fix by using the > media_

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-24 Thread Hans Verkuil
A quick follow-up to Thierry's excellent review: On 08/25/2015 02:26 AM, Bryan Wu wrote: > On 08/21/2015 06:03 AM, Thierry Reding wrote: >> On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: >>> +static void >>> +__tegra_channel_try_format(struct tegra_channel *chan, struct >>> v4l2_pix

cron job: media_tree daily build: WARNINGS

2015-08-24 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Aug 25 04:00:18 CEST 2015 git branch: test git hash: d071c833a0d30e7aae0ea565d92ef83c79106d6f gcc versi

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-24 Thread Bryan Wu
On 08/21/2015 02:28 AM, Hans Verkuil wrote: Hi Bryan, Thanks for contributing this driver, very much appreciated. I do have some comments below, basically about the same things we discussed privately before. On 08/21/2015 02:51 AM, Bryan Wu wrote: NVIDIA Tegra processor contains a powerful Vi

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-24 Thread Bryan Wu
On 08/21/2015 06:03 AM, Thierry Reding wrote: On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: NVIDIA Tegra processor contains a powerful Video Input (VI) hardware controller which can support up to 6 MIPI CSI camera sensors. This patch adds a V4L2 media controller and capture driver t

Re: [PATCH v7 07/44] [media] media: use media_gobj inside links

2015-08-24 Thread Shuah Khan
On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab wrote: > Just like entities and pads, links also need to have unique > Object IDs along a given media controller. > > So, let's add a media_gobj inside it and initialize > the object then a new link is created. > > Signed-off-by: Mauro Carvalh

[PATCH] add interface protocol 1 for Surface Pro 3 cameras

2015-08-24 Thread Zvi Effron
The cameras on the Surface Pro 3 report interface protocol of 1. The generic USB video class doesn't work for them. This adds entries for the front and rear camera. Signed-off-by: Zvi Effron --- drivers/media/usb/uvc/uvc_driver.c | 16 1 file changed, 16 insertions(+) diff --gi

Re: [PATCH v7 05/44] [media] media: use media_gobj inside entities

2015-08-24 Thread Shuah Khan
On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab wrote: > As entities are graph objects, let's embed media_gobj > on it. That ensures an unique ID for entities that can be > global along the entire media controller. > > For now, we'll keep the already existing entity ID. Such > field need to

Re: [PATCH] rcar_vin: propagate querystd() error upstream

2015-08-24 Thread Sergei Shtylyov
hello. On 08/21/2015 12:51 AM, Laurent Pinchart wrote: rcar_vin_set_fmt() defaults to PAL when the subdevice's querystd() method call fails (e.g. due to I2C error). This doesn't work very well when a camera being used outputs NTSC which has different order of fields and resolution. Let us

Re: [PATCH] lib: scatterlist: add sg splitting function

2015-08-24 Thread Jens Axboe
On 08/24/2015 02:26 PM, Andrew Morton wrote: On Mon, 24 Aug 2015 14:15:08 -0600 Jens Axboe wrote: On 08/08/2015 02:44 AM, Robert Jarzmik wrote: Sometimes a scatter-gather has to be split into several chunks, or sub scatter lists. This happens for example if a scatter list will be handled by m

Re: [PATCH] lib: scatterlist: add sg splitting function

2015-08-24 Thread Andrew Morton
On Mon, 24 Aug 2015 14:15:08 -0600 Jens Axboe wrote: > On 08/08/2015 02:44 AM, Robert Jarzmik wrote: > > Sometimes a scatter-gather has to be split into several chunks, or sub > > scatter lists. This happens for example if a scatter list will be > > handled by multiple DMA channels, each one fill

Re: [PATCH] media: don't try to empty links list in media_entity_cleanup()

2015-08-24 Thread Javier Martinez Canillas
Hello, On 08/24/2015 07:57 PM, Javier Martinez Canillas wrote: > The media_entity_cleanup() function only cleans up the entity links list > but this operation is already made in media_device_unregister_entity(). > > In most cases this should be harmless (besides having duplicated code) > since th

Re: [PATCH] lib: scatterlist: add sg splitting function

2015-08-24 Thread Jens Axboe
On 08/08/2015 02:44 AM, Robert Jarzmik wrote: Sometimes a scatter-gather has to be split into several chunks, or sub scatter lists. This happens for example if a scatter list will be handled by multiple DMA channels, each one filling a part of it. A concrete example comes with the media V4L2 API

Re: [PATCH v7 04/44] [media] media: add a common struct to be embed on media graph objects

2015-08-24 Thread Shuah Khan
On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab wrote: > Due to the MC API proposed changes, we'll need to have an unique > object ID for all graph objects, and have some shared fields > that will be common on all media graph objects. > > Right now, the only common object is the object ID,

[PATCH v4 11/11] mtrr: bury MTRR - unexport mtrr_add() and mtrr_del()

2015-08-24 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The crusade to replace mtrr_add() with architecture agnostic arch_phys_wc_add() is complete, this will ensure write-combining implementations (PAT on x86) is taken advantage instead of using MTRR. With the crusade done now, hide direct MTRR access for drivers. Update x8

Re: [PATCH v7 03/44] [media] omap3isp: get entity ID using media_entity_id()

2015-08-24 Thread Javier Martinez Canillas
Hello Shuah, Thanks for your feedback. On 08/24/2015 08:14 PM, Shuah Khan wrote: > On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab > wrote: >> From: Javier Martinez Canillas >> >> X-Patchwork-Delegate: laurent.pinch...@ideasonboard.com >> The struct media_entity does not have an .id fiel

Re: [PATCH v7 03/44] [media] omap3isp: get entity ID using media_entity_id()

2015-08-24 Thread Shuah Khan
On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > X-Patchwork-Delegate: laurent.pinch...@ideasonboard.com > The struct media_entity does not have an .id field anymore since > now the entity ID is stored in the embedded struct media_gobj. > > This c

Re: [PATCH v7 01/44] [media] media: create a macro to get entity ID

2015-08-24 Thread Mauro Carvalho Chehab
Em Mon, 24 Aug 2015 11:24:58 -0600 Shuah Khan escreveu: > On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab > wrote: > > Instead of accessing directly entity.id, let's create a macro, > > as this field will be moved into a common struct later on. > > > > Signed-off-by: Mauro Carvalho Chehab

[PATCH] media: don't try to empty links list in media_entity_cleanup()

2015-08-24 Thread Javier Martinez Canillas
The media_entity_cleanup() function only cleans up the entity links list but this operation is already made in media_device_unregister_entity(). In most cases this should be harmless (besides having duplicated code) since the links list would be empty so the iteration would not happen but the link

Re: [PATCH v7 02/44] [media] staging: omap4iss: get entity ID using media_entity_id()

2015-08-24 Thread Shuah Khan
On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > The struct media_entity does not have an .id field anymore since > now the entity ID is stored in the embedded struct media_gobj. > > This caused the omap4iss driver fail to build. Fix by using the

Re: [PATCH v7 01/44] [media] media: create a macro to get entity ID

2015-08-24 Thread Shuah Khan
On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab wrote: > Instead of accessing directly entity.id, let's create a macro, > as this field will be moved into a common struct later on. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Hans Verkuil > Signed-off-by: Mauro Carvalho Chehab >

Re: AW: Bugs reporting

2015-08-24 Thread Anton Tinchev
Hello. It is not critical (our multiswitches works with normal disqc too), but should be reported and taken care. Most important are the i2c errors i'm getting: This during module load Aug 21 04:45:05 dvb-tams2 kernel: [5.518270] Attaching STV0900 demodulator(2) Cut=0x30 Aug 21

[BUG] STV0299 has bogus CAN_INVERSION_AUTO flag

2015-08-24 Thread Johann Klammer
from gdb dump: [...] info = { name = "ST STV0299 DVB-S", '\000' , type = FE_QPSK, frequency_min = 95, frequency_max = 215, frequency_stepsize = 125, frequency_tolerance = 0, symbol_rate_min = 100, symbol_rate_max = 4500, symbol_rate_tolerance = 500,

Re: linux-next: Tree for Aug 24 (media/i2c/tc358743.c)

2015-08-24 Thread Randy Dunlap
On 08/24/15 04:52, Stephen Rothwell wrote: > Hi all, > > Changes since 20150821: > on x86_64: drivers/built-in.o: In function `print_avi_infoframe': tc358743.c:(.text.unlikely+0x7849): undefined reference to `hdmi_infoframe_unpack' tc358743.c:(.text.unlikely+0x787e): undefined reference to `h

[PATCH] net-next: Fix warning while make xmldocs caused by skbuff.c

2015-08-24 Thread Masanari Iida
This patch fix following warnings. .//net/core/skbuff.c:407: warning: No description found for parameter 'len' .//net/core/skbuff.c:407: warning: Excess function parameter 'length' description in '__netdev_alloc_skb' .//net/core/skbuff.c:476: warning: No description found for parameter 'len' .//

[PATCH] [media] v4l2-core: create MC interfaces for devnodes

2015-08-24 Thread Mauro Carvalho Chehab
All V4L2 device nodes should create an interface, if the Media Controller support is enabled. Please notice that radio devices should not create an entity, as radio input/output is either via wires or via ALSA. Signed-off-by: Mauro Carvalho Chehab --- With this patch, V4L is now creating inter

AW: Bugs reporting

2015-08-24 Thread Norbert Auge
Hello Anton, the driver for STV0910 does not support ToneBurst (=minidiseqc). If it is essential for you we can address this in our driver development best regards Dieter -Ursprüngliche Nachricht- Von: Anton Tinchev [mailto:a...@unixsol.org] Gesendet: Freitag, 21. August 2015 16:33 An: N

[PATCH 1/2] [media] media-entity: unregister entity links

2015-08-24 Thread Mauro Carvalho Chehab
Add functions to explicitly unregister all entity links. This function is called automatically when an entity link is destroyed. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index fc6bb48027ab..7e6fb5a86b21 100644 --- a/drivers/med

[PATCH 0/2] MC next gen: add sub-device interfaces

2015-08-24 Thread Mauro Carvalho Chehab
This patch depends on my MC next gen previous series. It creates interfaces for V4L2-subdev when the corresponding device nodes are created. Mauro Carvalho Chehab (2): [media] media-entity: unregister entity links [media] v4l2-subdev: create interfaces at MC drivers/media/media-entity.c

[PATCH 2/2] [media] v4l2-subdev: create interfaces at MC

2015-08-24 Thread Mauro Carvalho Chehab
Now that the Media Controller has support for interfaces, create them when v4l-subdev interfaces are created. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/v4l2-core/v4l2-device.c b/drivers/media/v4l2-core/v4l2-device.c index 5b0a30b9252b..1e5176c558bf 100644 --- a/drivers/med

Re: [PATCH v3 3/3] media: atmel-isi: add sanity check for supported formats in try/set_fmt()

2015-08-24 Thread Josh Wu
Hi, Laurent On 8/22/2015 2:22 AM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Friday 21 August 2015 16:08:14 Josh Wu wrote: After adding the format check in try_fmt()/set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type.

Re: [PATCH v6 7/8] [media] media: add a debug message to warn about gobj creation/removal

2015-08-24 Thread Mauro Carvalho Chehab
Em Sat, 22 Aug 2015 01:54:07 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Friday 21 August 2015 18:09:31 Mauro Carvalho Chehab wrote: > > Em Fri, 21 Aug 2015 20:54:29 +0300 Laurent Pinchart escreveu: > > > On Friday 21 August 2015 07:19:21 Mauro Carvalho Chehab wrote: > > >> Em Fri, 21 Au

Re: [PATCH v6 3/8] [media] media: use media_gobj inside entities

2015-08-24 Thread Mauro Carvalho Chehab
Em Sat, 22 Aug 2015 01:47:37 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Friday 21 August 2015 18:01:31 Mauro Carvalho Chehab wrote: > > Em Fri, 21 Aug 2015 20:51:10 +0300 Laurent Pinchart escreveu: > > > On Friday 21 August 2015 07:09:44 Mauro Carvalho Chehab wrote: > > >> Em Fri, 21 Au