Hi Ezequiel,
OTOH I don't see any reason preventing you from sending a pull request
for the inclusion of the TW686x driver, Mauro could merge this stuff
then (assuming it's ready).
You don't have to wait for me and a driver doesn't need to be a single
patch from a single person.
--
Krzysztof Hał
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Aug 12 04:00:28 CEST 2015
git branch: test
git hash: 2696f495bdc046d84da6c909a1e7f535138a2a62
gcc versi
On 08/12/2015 01:39 AM, Mauro Carvalho Chehab wrote:
Otherwise, it will break on 32 bits archs.
Look good!
Antti
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/dvb-frontends/tda10071.c
b/drivers/media/dvb-frontends/tda10071.c
index ee6653124618..119d47596ac8 100644
--- a
Otherwise, it will break on 32 bits archs.
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/dvb-frontends/tda10071.c
b/drivers/media/dvb-frontends/tda10071.c
index ee6653124618..119d47596ac8 100644
--- a/drivers/media/dvb-frontends/tda10071.c
+++ b/drivers/media/dvb-frontends/tda
compiling on some archs fail with:
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:540:8: error: implicit
declaration of function ‘pinctrl_select_state’
[-Werror=implicit-function-declaration]
ret = pinctrl_select_state(fei->pinctrl, tsin->pstate);
That's due the need of including pinct
While this is the first DVB platform drivers, let's keep the
Kconfig options well organized, adding it on its own DVB menu.
Of course, it should depend on MEDIA_DIGITAL_TV_SUPPORT, as
this enables all DVB-related menus.
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/platform/Kc
Hello, thank you for your feedback
On Tue, Aug 11, 2015 at 6:36 AM, Mauro Carvalho Chehab
wrote:
> Em Tue, 11 Aug 2015 11:28:25 +0200
> Hans Verkuil escreveu:
>
>> Hi Helen,
>>
>> On 08/10/15 19:21, Helen Fornazier wrote:
>> > Hi, thanks for your reviews
>> >
>> > On Mon, Aug 10, 2015 at 10:11 A
While it won't work, it is good to allow it to build with
COMPILE_TEST, as we can check if other patches would break
compilation for this driver.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/sti/c8sectpfe/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
As reported by smatch:
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:365
find_channel() error: buffer overflow 'fei->channel_data' 8 <= 63
It seems that a cut-and-paste type of error occurred here:
the channel_data array size is C8SECTPFE_MAX_TSIN_CHAN, and not
C8SECTPFE_MAXCHANNE
As reported by smatch:
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:365
find_channel() error: buffer overflow 'fei->channel_data' 8 <= 63
It seems that a cut-and-paste type of error occurred here:
the channel_data array size is C8SECTPFE_MAX_TSIN_CHAN, and not
C8SECTPFE_MAXCHANNE
The Linux stack is short; we need to be able to count the number
of bytes used at stack on each function. So, we don't like to
use variable-length arrays, as complained by smatch:
drivers/media/dvb-frontends/horus3a.c:57:19: warning: Variable length
array is used.
The max usecase of the d
The Linux stack is short; we need to be able to count the number
of bytes used at stack on each function. So, we don't like to
use variable-length arrays, as complained by smatch:
drivers/media/dvb-frontends/cxd2841er.c:205:19: warning: Variable
length array is used.
The max usecase of t
The Linux stack is short; we need to be able to count the number
of bytes used at stack on each function. So, we don't like to
use variable-length arrays, as complained by smatch:
drivers/media/dvb-frontends/horus3a.c:57:19: warning: Variable length
array is used.
The max usecase of the d
drivers/media/dvb-frontends/cxd2841er.c:992:5: warning: no previous prototype
for 'cxd2841er_get_carrier_offset_t2' [-Wmissing-prototypes]
int cxd2841er_get_carrier_offset_t2(
^
drivers/media/dvb-frontends/cxd2841er.c:1032:5: warning: no previous prototype
for 'cxd2841er_get_carrier_offset_
On 11 August 2015 at 13:16, Tony Lindgren wrote:
> * Michael Allwright [150810 08:19]:
>> +
>> +/*
>> +We need a better solution for this
>> +*/
>> +#include <../arch/arm/mach-omap2/omap-pm.h>
>
> Please let's not do things like this, I end up having to deal with
> all these eventually :(
>
>> +s
Hi David,
Em Wed, 22 Jul 2015 22:55:24 +0200
David Härdeman escreveu:
> Commit 275ddb40bcf686d210d86c6718e42425a6a0bc76 removed the lirc
> "protocol" but kept backwards compatibility by always listing
> the protocol as present and enabled. This patch further improves
> the logic by only listing
Em Tue, 11 Aug 2015 18:18:39 +0300
Antti Palosaari escreveu:
> On 08/11/2015 01:20 PM, Mauro Carvalho Chehab wrote:
> > Em Thu, 9 Jul 2015 07:06:29 +0300
> > Antti Palosaari escreveu:
> >
> >> Use jiffies to set timeout for firmware command status polling.
> >> It is more elegant solution than
Wall time obtained from do_gettimeofday is susceptible to sudden jumps due to
user setting the time or due to NTP.
Monotonic time is constantly increasing time better suited for comparing two
timestamps.
Signed-off-by: Abhilash Jindal
---
drivers/media/pci/bt8xx/bttv-input.c | 23 +---
sr030pc30_get_fmt() can only succeed if both info->curr_win and
info->curr_fmt are not NULL.
If one of those vars are null, the curent code would call:
ret = sr030pc30_set_params(sd);
If the curr_win is null, it will return -EINVAL, as it would be
expected. However, if curr_fmt is NULL, t
drivers/media/i2c/tc358743.c:148:19: warning: Variable length array is used.
As the maximum size is 1026, we can't use dynamic var, as it
would otherwise spend 1056 bytes of the stack at i2c_wr() function.
So, allocate a buffer with the allowed maximum size together with
the state var.
Signed-of
drivers/media/i2c/ov9650.c:1439 ov965x_detect_sensor() warn: inconsistent
indenting
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
index 2bc473385c91..e691bba1945b 100644
--- a/drivers/media/i2c/ov9650.c
+++ b/drivers/media/i2c/ov9650.c
Why to store the chosed values for prediv, postdiv and mult if
those won't be used?
drivers/media/i2c/ov2659.c: In function 'ov2659_pll_calc_params':
drivers/media/i2c/ov2659.c:912:35: warning: variable 's_mult' set but not used
[-Wunused-but-set-variable]
u32 s_prediv = 1, s_postdiv = 1, s_mul
On 08/11/2015 01:20 PM, Mauro Carvalho Chehab wrote:
Em Thu, 9 Jul 2015 07:06:29 +0300
Antti Palosaari escreveu:
Use jiffies to set timeout for firmware command status polling.
It is more elegant solution than poll X times with sleep.
/* wait cmd execution terminate */
- for
sr030pc30_get_fmt() can only succeed if both info->curr_win and
info->curr_fmt are not NULL.
If one of those vars are null, the curent code would call:
ret = sr030pc30_set_params(sd);
If the curr_win is null, it will return -EINVAL, as it would be
expected. However, if curr_fmt is NULL, t
drivers/media/i2c/ov9650.c:1439 ov965x_detect_sensor() warn: inconsistent
indenting
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/i2c/ov9650.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
index 2bc473385c91.
Why to store the chosed values for prediv, postdiv and mult if
those won't be used?
drivers/media/i2c/ov2659.c: In function 'ov2659_pll_calc_params':
drivers/media/i2c/ov2659.c:912:35: warning: variable 's_mult' set but not used
[-Wunused-but-set-variable]
u32 s_prediv = 1, s_postdiv = 1, s_mul
drivers/media/i2c/tc358743.c:148:19: warning: Variable length array is used.
As the maximum size is 1026, we can't use dynamic var, as it
would otherwise spend 1056 bytes of the stack at i2c_wr() function.
So, allocate a buffer with the allowed maximum size together with
the state var.
Signed-of
Wall time obtained from do_gettimeofday is susceptible to sudden jumps due to
user setting the time or due to NTP.
Monotonic time is constantly increasing time better suited for comparing two
timestamps.
Signed-off-by: Abhilash Jindal
---
drivers/media/pci/zoran/zoran_device.c | 18 +-
Hi Hans,
On Tue, 11 Aug 2015, Hans Verkuil wrote:
0015-v4l-subdev-Add-pad-config-allocator-and-init.patch
0016-media-soc_camera-rcar_vin-Add-BT.709-24-bit-RGB888-i.patch
0017-media-soc_camera-pad-aware-driver-initialisation.patch
0018-media-rcar_vin-Use-correct-pad-number-in-try_fmt.patch
0019-m
Hi Hans,
On Tuesday 11 August 2015 15:59:35 Hans Verkuil wrote:
> On 08/11/15 15:56, Laurent Pinchart wrote:
> > Hijacking this e-mail thread a bit, would it make sense for the new
> > vb2-core to support different memory allocation for different planes ?
> > I'm foreseeing use cases for buffers t
On 08/11/15 15:56, Laurent Pinchart wrote:
>
> Hijacking this e-mail thread a bit, would it make sense for the new vb2-core
> to support different memory allocation for different planes ? I'm foreseeing
> use cases for buffers that bundle image data with meta-data, where image data
> should be
Hello,
On Monday 10 August 2015 10:22:12 Hans Verkuil wrote:
> On 07/31/2015 10:44 AM, Junghak Sung wrote:
> > Define enum vb2_buf_type and enum vb2_memory for videobuf2-core. This
> > change requires translation functions that could covert v4l2-core stuffs
> > to videobuf2-core stuffs in videobuf
Okay, I split it up and sent it to the proper lists.
Just noticed I forgot to set the "in-reply-to" headers though. Hope that won't
be a problem.
On 11-08-15 13:45, Hans Verkuil wrote:
Hi Mike,
Please split up this patch: these are two different drivers with different
authors and different
Hello,
On Monday 10 August 2015 15:38:48 Hans Verkuil wrote:
> On 08/10/2015 02:55 PM, Mauro Carvalho Chehab wrote:
> > Em Mon, 10 Aug 2015 14:07:21 +0200 Hans Verkuil escreveu:
> >> Hi Junghak,
> >>
> >> I'm reviewing the header changes since I think there are several
> >> improvements that can
Gotos makes a little harder to check the code. In this
particular case, the goto is doing nothing but jumping into
a return.
Instead, just replace the goto by the return, making it
simpler.
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/pci/mantis/mantis_dma.c
b/drivers/media/
>>> diff --git a/include/media/media-entity.h b/include/media/media-entity.h
>>> index 403019035424..f6e2136480f1 100644
>>> --- a/include/media/media-entity.h
>>> +++ b/include/media/media-entity.h
>>> @@ -43,6 +43,17 @@ enum media_graph_type {
>>> MEDIA_GRAPH_LINK,
>>> };
>>>
>>> +/**
>>>
queryctrl and querymenu menu ops don't need to be initialized
if sd.ctrl_handler is set. Since no other core ops are required
by the wrapper don't initialize related field of v4l2_flash_subdev_ops.
Signed-off-by: Jacek Anaszewski
Cc: Hans Verkuil
---
drivers/media/v4l2-core/v4l2-flash-led-class
Em Tue, 11 Aug 2015 14:25:18 +0200
Hans Verkuil escreveu:
> Hi Mauro,
>
> Thanks for posting the missing patches.
Thanks for reviewing this patch series!
>
> On 08/11/15 14:09, Mauro Carvalho Chehab wrote:
> > As we'll need to create links between entities and interfaces,
> > we need to ident
Hi Mauro,
On 08/11/15 15:08, Mauro Carvalho Chehab wrote:
> Em Tue, 28 Jul 2015 11:22:15 +0200
> Hans Verkuil escreveu:
>
>> This pull request contains a pile of fixes/enhancements, mostly soc-camera
>> related.
>>
>> Regards,
>>
>> Hans
>>
>> The following changes since commit 4dc102b2f53d
Em Tue, 28 Jul 2015 11:22:15 +0200
Hans Verkuil escreveu:
> This pull request contains a pile of fixes/enhancements, mostly soc-camera
> related.
>
> Regards,
>
> Hans
>
> The following changes since commit 4dc102b2f53d63207fa12a6ad49c7b6448bc3301:
>
> [media] dvb_core: Replace memset
Em Fri, 24 Jul 2015 16:12:44 +0200
Hans Verkuil escreveu:
> On 07/23/2015 02:21 PM, William Towle wrote:
> > From: Laurent Pinchart
> >
> > Add a new subdev operation to initialize a subdev pad config array, and
> > a helper function to allocate and initialize the array. This can be used
> > by
On 08/11/15 14:56, Jacek Anaszewski wrote:
> On 07/28/2015 12:00 PM, Hans Verkuil wrote:
>> On 06/19/2015 09:31 AM, Jacek Anaszewski wrote:
>>> This patch adds helper functions for registering/unregistering
>>> LED Flash class devices as V4L2 sub-devices. The functions should
>>> be called from the
On 07/28/2015 12:00 PM, Hans Verkuil wrote:
On 06/19/2015 09:31 AM, Jacek Anaszewski wrote:
This patch adds helper functions for registering/unregistering
LED Flash class devices as V4L2 sub-devices. The functions should
be called from the LED subsystem device driver. In case the
support for V4L
On 08/11/15 14:24, Mauro Carvalho Chehab wrote:
> Em Tue, 11 Aug 2015 13:14:41 +0200
> Hans Verkuil escreveu:
>
>> On 08/07/15 16:20, Mauro Carvalho Chehab wrote:
>>> Interfaces are different than entities: they represent a
>>> Kernel<->userspace interaction, while entities represent a
>>> piece
Hi Mauro,
Thanks for posting the missing patches.
On 08/11/15 14:09, Mauro Carvalho Chehab wrote:
> As we'll need to create links between entities and interfaces,
> we need to identify the link endpoints by the media_graph_obj.
>
> Most of the changes here was done by this small script:
>
> for
Em Tue, 11 Aug 2015 13:14:41 +0200
Hans Verkuil escreveu:
> On 08/07/15 16:20, Mauro Carvalho Chehab wrote:
> > Interfaces are different than entities: they represent a
> > Kernel<->userspace interaction, while entities represent a
> > piece of hardware/firmware/software that executes a function.
Header claims GPL v2, so make the MODULE_LICENSE reflect that properly.
Signed-off-by: Mike Looijmans
---
drivers/media/i2c/adv7511.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c/adv7511.c
index 95bcd40..497ee00 100644
--- a/
Now that a link can be either between two different graph
objects, we'll need to add more functions to create links.
So, rename the existing one that create links only between
two pads as media_create_pad_link().
No functional changes.
This patch was created via this shell script:
for i i
As we'll need to create links between entities and interfaces,
we need to identify the link endpoints by the media_graph_obj.
Most of the changes here was done by this small script:
for i in `find drivers/media -type f` `find drivers/staging/media -type f`; do
perl -ne
's,([\w]+)\-\>(sou
A small vivid improvement and two patches that fix compiler/linker warnings.
Regards,
Hans
The following changes since commit 267897a4708fd7a0592333f33a4a7c393c999ab7:
[media] tda10071: implement DVBv5 statistics (2015-08-11 07:34:58 -0300)
are available in the git repository at:
Hi Mike,
Please split up this patch: these are two different drivers with different
authors and different subsystems.
The media/i2c/adv7511.c patch I can handle, but the patch for the drm driver
should go to the dri-devel mailinglist. I can't take that change.
Easiest is just to post two patches
Em Tue, 11 Aug 2015 12:57:04 +0200
Hans Verkuil escreveu:
> On 08/07/15 16:20, Mauro Carvalho Chehab wrote:
> > In preparation to add a public function to add links, let's
> > make the internal function that creates link more generic.
> >
> > Signed-off-by: Mauro Carvalho Chehab
> >
> > diff -
* Michael Allwright [150810 08:19]:
> +
> +/*
> +We need a better solution for this
> +*/
> +#include <../arch/arm/mach-omap2/omap-pm.h>
Please let's not do things like this, I end up having to deal with
all these eventually :(
> +static void iss_set_constraints(struct iss_device *iss, bool enab
On 08/07/15 16:20, Mauro Carvalho Chehab wrote:
> Interfaces are different than entities: they represent a
> Kernel<->userspace interaction, while entities represent a
> piece of hardware/firmware/software that executes a function.
>
> Let's distinguish them by creating a separate structure to
> s
Em Tue, 11 Aug 2015 12:49:40 +0200
Hans Verkuil escreveu:
> On 08/07/15 16:20, Mauro Carvalho Chehab wrote:
> > Using memory realloc to increase the size of an array
> > is complex and makes harder to remove links. Also, by
> > embedding the link inside an array at the entity makes harder
> > to
Em Tue, 11 Aug 2015 12:34:46 +0200
Hans Verkuil escreveu:
> On 08/11/15 11:36, Mauro Carvalho Chehab wrote:
> > Em Tue, 11 Aug 2015 11:28:25 +0200
> > Hans Verkuil escreveu:
> >
> >> Hi Helen,
> >>
> >> On 08/10/15 19:21, Helen Fornazier wrote:
> >>> Hi, thanks for your reviews
> >>>
> >>> On M
On 08/07/15 16:20, Mauro Carvalho Chehab wrote:
> In preparation to add a public function to add links, let's
> make the internal function that creates link more generic.
>
> Signed-off-by: Mauro Carvalho Chehab
>
> diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
> index
On 08/07/15 16:20, Mauro Carvalho Chehab wrote:
> Using memory realloc to increase the size of an array
> is complex and makes harder to remove links. Also, by
> embedding the link inside an array at the entity makes harder
> to change the code to add interfaces, as interfaces will
> also need to u
On 08/11/15 11:36, Mauro Carvalho Chehab wrote:
> Em Tue, 11 Aug 2015 11:28:25 +0200
> Hans Verkuil escreveu:
>
>> Hi Helen,
>>
>> On 08/10/15 19:21, Helen Fornazier wrote:
>>> Hi, thanks for your reviews
>>>
>>> On Mon, Aug 10, 2015 at 10:11 AM, Hans Verkuil wrote:
Hi Helen!
On 0
Em Thu, 9 Jul 2015 07:06:29 +0300
Antti Palosaari escreveu:
> Use jiffies to set timeout for firmware command status polling.
> It is more elegant solution than poll X times with sleep.
>
> Shorten timeout to 30ms as all commands seems to be executed under
> 10ms.
>
> Signed-off-by: Antti Palo
Em Tue, 11 Aug 2015 11:28:25 +0200
Hans Verkuil escreveu:
> Hi Helen,
>
> On 08/10/15 19:21, Helen Fornazier wrote:
> > Hi, thanks for your reviews
> >
> > On Mon, Aug 10, 2015 at 10:11 AM, Hans Verkuil wrote:
> >> Hi Helen!
> >>
> >> On 08/08/2015 03:55 AM, Helen Fornazier wrote:
> >>> Hi!
>
Hi Helen,
On 08/10/15 19:21, Helen Fornazier wrote:
> Hi, thanks for your reviews
>
> On Mon, Aug 10, 2015 at 10:11 AM, Hans Verkuil wrote:
>> Hi Helen!
>>
>> On 08/08/2015 03:55 AM, Helen Fornazier wrote:
>>> Hi!
>>>
>>> I've made a first sketch about the API of the vimc driver (virtual
>>> med
62 matches
Mail list logo
