Re: [RFC PATCH v2 4/5] media: videobuf2: Define vb2_buf_type and vb2_memory

2015-08-10 Thread Hans Verkuil
On 08/11/2015 04:19 AM, Junghak Sung wrote: > > Hi Hans, > > On 08/10/2015 05:22 PM, Hans Verkuil wrote: >> On 07/31/2015 10:44 AM, Junghak Sung wrote: >>> Define enum vb2_buf_type and enum vb2_memory for videobuf2-core. This >>> change requires translation functions that could covert v4l2-core s

Re: [PATCHv3 12/13] DocBook: fix S_FREQUENCY => G_FREQUENCY

2015-08-10 Thread Antti Palosaari
On 08/10/2015 12:41 PM, Hans Verkuil wrote: On 07/31/2015 04:10 AM, Antti Palosaari wrote: It is VIDIOC_G_FREQUENCY which does not use type to identify tuner, not VIDIOC_S_FREQUENCY. VIDIOC_S_FREQUENCY uses both tuner and type fields. One of these V4L API weirdness... Actually, that's not what

cron job: media_tree daily build: OK

2015-08-10 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Aug 11 04:00:25 CEST 2015 git branch: test git hash: 4dc102b2f53d63207fa12a6ad49c7b6448bc3301 gcc versi

Re: [RFC PATCH v2 4/5] media: videobuf2: Define vb2_buf_type and vb2_memory

2015-08-10 Thread Junghak Sung
Hi Hans, On 08/10/2015 05:22 PM, Hans Verkuil wrote: On 07/31/2015 10:44 AM, Junghak Sung wrote: Define enum vb2_buf_type and enum vb2_memory for videobuf2-core. This change requires translation functions that could covert v4l2-core stuffs to videobuf2-core stuffs in videobuf2-v4l2.c file. The

Re: [RFC PATCH v2 0/5] Refactoring Videobuf2 for common use

2015-08-10 Thread Junghak Sung
Hi, Hans and Mauro. First of all, thank you for your reviews. On 08/10/2015 08:44 PM, Hans Verkuil wrote: On 08/10/2015 12:49 PM, Mauro Carvalho Chehab wrote: Em Mon, 10 Aug 2015 12:11:39 +0200 Hans Verkuil escreveu: On 08/10/2015 11:32 AM, Mauro Carvalho Chehab wrote: Em Mon, 10 Aug 2015

Re: dvb_usb_af9015: command failed=1 _ kernel >= 4.1.x

2015-08-10 Thread Antti Palosaari
On 08/11/2015 12:46 AM, poma wrote: Furthermore, to fix this issue - AF9015 DVB-T USB2.0 stick brokenness - is the responsibility of developers. I am here only proven tester. I hope we understand each other, and this problem will be resolved in good faith. Your patches are implemented wrong.

Re: dvb_usb_af9015: command failed=1 _ kernel >= 4.1.x

2015-08-10 Thread poma
On 31.07.2015 17:55, Olli Salonen wrote: > Hi Poma, > > Might I suggest reading points 9, 10 and 11 from the following document: > https://www.kernel.org/doc/Documentation/SubmittingPatches > > Especially point 11 needs to be taken care of in order for your patch to be > merged. > > Cheers, > -o

[PATCH v2] Staging: media: davinci_vpfe: Fix over 80 characters coding style issue

2015-08-10 Thread Junsu Shin
This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected. Signed-off-by: Junsu Shin --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/driver

WARNING: CPU: 1 PID: 813 at kernel/module.c:291 module_assert_mutex_or_preempt+0x49/0x90()

2015-08-10 Thread poma
[ cut here ] WARNING: CPU: 1 PID: 813 at kernel/module.c:291 module_assert_mutex_or_preempt+0x49/0x90() Modules linked in: mxl5007t af9013 ... dvb_usb_af9015(+) ... dvb_usb_v2 dvb_core rc_core ... CPU: 1 PID: 813 Comm: systemd-udevd Not tainted 4.2.0-0.rc6.git0.1.fc24.x8

Re: VIMC: API proposal, configuring the topology through user space

2015-08-10 Thread Helen Fornazier
Hi, thanks for your reviews On Mon, Aug 10, 2015 at 10:11 AM, Hans Verkuil wrote: > Hi Helen! > > On 08/08/2015 03:55 AM, Helen Fornazier wrote: >> Hi! >> >> I've made a first sketch about the API of the vimc driver (virtual >> media controller) to configure the topology through user space. >> As

[PATCH] [media] mantis: Fix error handling in mantis_dma_init()

2015-08-10 Thread Fabio Estevam
Current code assigns 0 to variable 'err', which makes mantis_dma_init() to return success even if mantis_alloc_buffers() fails. Fix it by checking the return value from mantis_alloc_buffers() and propagating it in the case of error. Reported-by: RUC_Soft_Sec Signed-off-by: Fabio Estevam --- d

[FWD] PROBLEM: there exists a wrong return value of function mantis_dma_init()

2015-08-10 Thread Linus Torvalds
It does seem like the error handling for mantis_dma_init() is insane.. Linus On Sun, Aug 9, 2015 at 5:12 PM, RUC_Soft_Sec wrote: > Summary: > there exists a wrong return value of function mantis_dma_init().It's a > theoretical problem. we use static analysis method to dete

[PATCH RFC] DT support for omap4-iss

2015-08-10 Thread Michael Allwright
Hi All, The following PRELIMINARY patch adds DT support to the OMAP4 ISS. It also fixes some problems a have found along the way. It is tightly modelled after the omap3-isp media platform driver. This patch is a work in progress as I would like feedback. It contains debugging messages that need to

Re: [PATCH] [media] v4l2-subdev: return -EPIPE instead of -EINVAL in link validate default

2015-08-10 Thread Hans Verkuil
On 07/14/2015 04:32 PM, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 14 July 2015 16:19:50 Hans Verkuil wrote: >> On 07/13/15 10:03, Sakari Ailus wrote: >>> Helen Fornazier wrote: On Tue, Jun 30, 2015 at 4:26 PM, Helen Fornazier wrote: > On Tue, Jun 30, 2015 at 6:19 AM, Sakari Ailus

Re: [media-workshop] [RFC] Media graph flow for an hybrid device as discussed at the media workshop

2015-08-10 Thread Hans Verkuil
On 08/10/2015 03:19 PM, Mauro Carvalho Chehab wrote: > Em Mon, 10 Aug 2015 10:05:24 -0300 > Mauro Carvalho Chehab escreveu: > >> Em Mon, 10 Aug 2015 14:43:50 +0200 >> Hans Verkuil escreveu: >> >>> Hi Mauro, >> >> Thanks for the review! >> >>> >>> On 08/08/2015 01:33 PM, Mauro Carvalho Chehab wro

Re: [RFC PATCH v2 3/5] media: videobuf2: Divide videobuf2-core into 2 parts

2015-08-10 Thread Hans Verkuil
On 08/10/2015 02:55 PM, Mauro Carvalho Chehab wrote: > Em Mon, 10 Aug 2015 14:07:21 +0200 > Hans Verkuil escreveu: > >> Hi Junghak, >> >> I'm reviewing the header changes since I think there are several improvements >> that can be done that will make things more logical and will simplify the >>

Re: [media-workshop] [RFC] Media graph flow for an hybrid device as discussed at the media workshop

2015-08-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Aug 2015 10:05:24 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 10 Aug 2015 14:43:50 +0200 > Hans Verkuil escreveu: > > > Hi Mauro, > > Thanks for the review! > > > > > On 08/08/2015 01:33 PM, Mauro Carvalho Chehab wrote: > > > During the discussions at the Media Workshop, we ca

Re: VIMC: API proposal, configuring the topology through user space

2015-08-10 Thread Hans Verkuil
Hi Helen! On 08/08/2015 03:55 AM, Helen Fornazier wrote: > Hi! > > I've made a first sketch about the API of the vimc driver (virtual > media controller) to configure the topology through user space. > As first suggested by Laurent Pinchart, it is based on configfs. > > I would like to know you

Re: [media-workshop] [RFC] Media graph flow for an hybrid device as discussed at the media workshop

2015-08-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Aug 2015 14:43:50 +0200 Hans Verkuil escreveu: > Hi Mauro, Thanks for the review! > > On 08/08/2015 01:33 PM, Mauro Carvalho Chehab wrote: > > During the discussions at the Media Workshop, we came with some dot files > > that > > would describe a hybrid PC-consumer TV stick with ra

Re: [RFC PATCH v2 3/5] media: videobuf2: Divide videobuf2-core into 2 parts

2015-08-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Aug 2015 14:07:21 +0200 Hans Verkuil escreveu: > Hi Junghak, > > I'm reviewing the header changes since I think there are several improvements > that can be done that will make things more logical and will simplify the > code. > > My comments below are a mix of suggestions for impro

Re: [RFC] Media graph flow for an hybrid device as discussed at the media workshop

2015-08-10 Thread Hans Verkuil
Hi Mauro, On 08/08/2015 01:33 PM, Mauro Carvalho Chehab wrote: > During the discussions at the Media Workshop, we came with some dot files that > would describe a hybrid PC-consumer TV stick with radio, analog video, analog > TV and digital TV on it. > > I consolidated all the dot files we've wor

Re: [RFC PATCH v2 3/5] media: videobuf2: Divide videobuf2-core into 2 parts

2015-08-10 Thread Hans Verkuil
Hi Junghak, I'm reviewing the header changes since I think there are several improvements that can be done that will make things more logical and will simplify the code. My comments below are a mix of suggestions for improvement and brainstorming. Feel free to ask for clarification if something

Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-08-10 Thread Ricardo Ribalda Delgado
Hello Hans, Sakari and Laurent: I am back from holidays :). Shall I prepare a new patchset with the suggestion from Hans? Thanks! On Mon, Jul 20, 2015 at 4:31 PM, Hans Verkuil wrote: > On 07/20/2015 03:52 PM, Ricardo Ribalda Delgado wrote: >> Hello >> >> I have no preference over the two implem

Re: [RFC PATCH v2 0/5] Refactoring Videobuf2 for common use

2015-08-10 Thread Hans Verkuil
On 08/10/2015 12:49 PM, Mauro Carvalho Chehab wrote: > Em Mon, 10 Aug 2015 12:11:39 +0200 > Hans Verkuil escreveu: > >> On 08/10/2015 11:32 AM, Mauro Carvalho Chehab wrote: >>> Em Mon, 10 Aug 2015 10:31:03 +0200 >>> Hans Verkuil escreveu: >>> Hi Jungsak, On 07/31/2015 10:44 AM, Ju

Re: [RFC PATCH v2 0/5] Refactoring Videobuf2 for common use

2015-08-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Aug 2015 12:11:39 +0200 Hans Verkuil escreveu: > On 08/10/2015 11:32 AM, Mauro Carvalho Chehab wrote: > > Em Mon, 10 Aug 2015 10:31:03 +0200 > > Hans Verkuil escreveu: > > > >> Hi Jungsak, > >> > >> On 07/31/2015 10:44 AM, Junghak Sung wrote: > >>> Hello everybody, > >>> > >>> This i

Re: [RFC PATCH v2 0/5] Refactoring Videobuf2 for common use

2015-08-10 Thread Hans Verkuil
On 08/10/2015 11:32 AM, Mauro Carvalho Chehab wrote: > Em Mon, 10 Aug 2015 10:31:03 +0200 > Hans Verkuil escreveu: > >> Hi Jungsak, >> >> On 07/31/2015 10:44 AM, Junghak Sung wrote: >>> Hello everybody, >>> >>> This is the 2nd round for refactoring Videobuf2(a.k.a VB2). >>> The purpose of this pa

Re: [PATCHv3 13/13] DocBook: add tuner types SDR and RF for G_TUNER / S_TUNER

2015-08-10 Thread Hans Verkuil
On 07/31/2015 04:10 AM, Antti Palosaari wrote: > Add V4L2_TUNER_SDR and V4L2_TUNER_RF to supported tuner types to > table. > > Cc: Hans Verkuil > Signed-off-by: Antti Palosaari > --- > Documentation/DocBook/media/v4l/vidioc-g-tuner.xml | 10 ++ > 1 file changed, 10 insertions(+) > > di

Re: [PATCHv3 12/13] DocBook: fix S_FREQUENCY => G_FREQUENCY

2015-08-10 Thread Hans Verkuil
On 07/31/2015 04:10 AM, Antti Palosaari wrote: > It is VIDIOC_G_FREQUENCY which does not use type to identify tuner, > not VIDIOC_S_FREQUENCY. VIDIOC_S_FREQUENCY uses both tuner and type > fields. One of these V4L API weirdness... Actually, that's not what this is about. It's about whether g/s_fre

Re: [PATCHv3 10/13] hackrf: add support for transmitter

2015-08-10 Thread Hans Verkuil
Some comments below: On 07/31/2015 04:10 AM, Antti Palosaari wrote: > HackRF SDR device has both receiver and transmitter. There is limitation > that receiver and transmitter cannot be used at the same time > (half-duplex operation). That patch implements transmitter support to > existing receiver

Re: [RFC PATCH v2 0/5] Refactoring Videobuf2 for common use

2015-08-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Aug 2015 10:31:03 +0200 Hans Verkuil escreveu: > Hi Jungsak, > > On 07/31/2015 10:44 AM, Junghak Sung wrote: > > Hello everybody, > > > > This is the 2nd round for refactoring Videobuf2(a.k.a VB2). > > The purpose of this patch series is to separate existing VB2 framework > > into co

Re: [PATCHv3 09/13] hackrf: switch to single function which configures everything

2015-08-10 Thread Hans Verkuil
On 07/31/2015 04:10 AM, Antti Palosaari wrote: > Implement single funtion, hackrf_set_params(), which handles all > needed settings. Controls and other IOCTLs are just wrappers to that > function. That way we can get easily better control what we could do > on different device states - sleeping, re

Re: [PATCHv3 08/13] hackrf: add control for RF amplifier

2015-08-10 Thread Hans Verkuil
On 07/31/2015 04:10 AM, Antti Palosaari wrote: > There is Avago MGA-81563 amplifier just right after antenna connector. > It could be turned on/off and its gain is around 12dB. > > Signed-off-by: Antti Palosaari Acked-by: Hans Verkuil > --- > drivers/media/usb/hackrf/hackrf.c | 26 +++

Re: [PATCHv3 07/13] DocBook: add modulator type field

2015-08-10 Thread Hans Verkuil
On 07/31/2015 04:10 AM, Antti Palosaari wrote: > Add new modulator type field to documentation. > > Cc: Hans Verkuil > Signed-off-by: Antti Palosaari > --- > Documentation/DocBook/media/v4l/vidioc-g-modulator.xml | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/D

Re: [PATCHv3 06/13] v4l: add type field to v4l2_modulator struct

2015-08-10 Thread Hans Verkuil
On 07/31/2015 04:10 AM, Antti Palosaari wrote: > Add type field to that struct like it counterpart v4l2_tuner > already has. We need type field to distinguish different tuner > types from each others for transmitter too. > > Cc: Hans Verkuil > Signed-off-by: Antti Palosaari Acked-by: Hans Verku

Re: [PATCHv3 03/13] DocBook: document tuner RF gain control

2015-08-10 Thread Hans Verkuil
On 07/31/2015 04:10 AM, Antti Palosaari wrote: > Add brief description for tuner RF gain control. > > Cc: Hans Verkuil Acked-by: Hans Verkuil > Signed-off-by: Antti Palosaari > --- > Documentation/DocBook/media/v4l/compat.xml | 4 > Documentation/DocBook/media/v4l/controls.xml | 14 +

Re: [PATCHv3 02/13] v4l2: add RF gain control

2015-08-10 Thread Hans Verkuil
On 07/31/2015 04:10 AM, Antti Palosaari wrote: > Add new RF tuner gain control named RF Gain. That is aimed for first > amplifier chip right after antenna connector. > There is existing LNA Gain control, which is quite same, but it is > aimed for cases amplifier is integrated to tuner chip. Some de

Re: [RFC PATCH v2 0/5] Refactoring Videobuf2 for common use

2015-08-10 Thread Hans Verkuil
Hi Jungsak, On 07/31/2015 10:44 AM, Junghak Sung wrote: > Hello everybody, > > This is the 2nd round for refactoring Videobuf2(a.k.a VB2). > The purpose of this patch series is to separate existing VB2 framework > into core part and V4L2 specific part. So that not only V4L2 but also other > frame

Re: [RFC PATCH v2 4/5] media: videobuf2: Define vb2_buf_type and vb2_memory

2015-08-10 Thread Hans Verkuil
On 07/31/2015 10:44 AM, Junghak Sung wrote: > Define enum vb2_buf_type and enum vb2_memory for videobuf2-core. This > change requires translation functions that could covert v4l2-core stuffs > to videobuf2-core stuffs in videobuf2-v4l2.c file. > The v4l2-specific member variables(e.g. type, memory)

Re: [RFC PATCH v2 1/5] media: videobuf2: Rename videobuf2-core to videobuf2-v4l2

2015-08-10 Thread Hans Verkuil
Hi Junghak, On 07/31/2015 10:44 AM, Junghak Sung wrote: > Rename file name - from videobuf2-core.[ch] to videobuf2-v4l2.[ch] > This renaming patch should be accompanied by the modifications for all device > drivers that include this header file. It can be done with just running this > shell script