Re: [PATCH v1.1 14/15] omap3isp: Add support for the Device Tree

2015-03-22 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. This looks good to me, except that there's one last bug I've spotted. Please see below. On Saturday 21 March 2015 00:05:04 Sakari Ailus wrote: > Add the ISP device to omap3 DT include file and add support to the driver to > use it. > > Also obtain information

Re: [media-workshop] [ANN] Media Mini-Summit Draft Agenda for March 26th

2015-03-22 Thread Mauro Carvalho Chehab
Em Mon, 16 Mar 2015 12:25:28 +0100 Hans Verkuil escreveu: > This is the draft agenda for the media mini-summit in San Jose on March 26th. > > Time: 9 AM to 5 PM (approximately) > Room: TBC (Mauro, do you know this?) I'll check on this Monday with LF and wiĺl give you a feedback. > > Attendees

cron job: media_tree daily build: WARNINGS

2015-03-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Mar 23 04:00:14 CET 2015 git branch: test git hash: 3d945be05ac1e806af075e9315bc1b3409adae2b gcc versio

Re: DVB-T Receivers Latency

2015-03-22 Thread Devin Heitmueller
Hi Pier, On Sun, Mar 22, 2015 at 6:37 PM, pier@libero.it wrote: > Hello, > > I was wondering if anyone had any idea of how much latency a DVB-T receiver > can add, in the path between radiofrequency and the MPEG-TS stream. I have > 100ms of unwanted latency I can't explain in an application I

Re: [PATCH v2] [media] mantis: fix error handling

2015-03-22 Thread Dan Carpenter
Good, but still a couple nits. On Sun, Mar 22, 2015 at 06:16:18PM +0100, Silvan Jegen wrote: > --- a/drivers/media/pci/mantis/mantis_cards.c > +++ b/drivers/media/pci/mantis/mantis_cards.c > @@ -170,7 +170,7 @@ static int mantis_pci_probe(struct pci_dev *pdev, > if (mantis == NULL) { >

DVB-T Receivers Latency

2015-03-22 Thread pier....@libero.it
Hello, I was wondering if anyone had any idea of how much latency a DVB-T receiver can add, in the path between radiofrequency and the MPEG-TS stream. I have 100ms of unwanted latency I can't explain in an application I'm developing, so I was faulting either the tx modulator or the rx demodulat

[PATCH v2 1/4] v4l: of: Remove the head field in struct v4l2_of_endpoint

2015-03-22 Thread Sakari Ailus
The field is unused. Remove it. Signed-off-by: Sakari Ailus --- include/media/v4l2-of.h |2 -- 1 file changed, 2 deletions(-) diff --git a/include/media/v4l2-of.h b/include/media/v4l2-of.h index 70fa7b7..dc468de 100644 --- a/include/media/v4l2-of.h +++ b/include/media/v4l2-of.h @@ -54,7 +54

[PATCH v2 2/4] v4l: of: Instead of zeroing bus_type and bus field separately, unify this

2015-03-22 Thread Sakari Ailus
Clean the entire struct starting from bus_type. As more fields are added, no changes will be needed in the function to reset their value explicitly. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-of.c |5 +++-- include/media/v4l2-of.h |1 + 2 files changed, 4 inse

[PATCH v2 4/4] smiapp: Use v4l2_of_alloc_parse_endpoint()

2015-03-22 Thread Sakari Ailus
Instead of parsing the link-frequencies property in the driver, let v4l2_of_alloc_parse_endpoint() do it. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/media/

[PATCH v2 0/4] Add link-frequencies to struct v4l2_of_endpoint

2015-03-22 Thread Sakari Ailus
Hi, I've split off the third and obviously somewhat problematic patch in the set, and sent a pull req containing the first two patches and another dependent patch: http://www.spinics.net/lists/linux-media/msg88033.html> The changes intend to address the review comments I gathered the last time.

[PATCH v2 3/4] v4l: of: Parse variable length properties --- link-frequencies

2015-03-22 Thread Sakari Ailus
The link-frequencies property is a variable length array of link frequencies in an endpoint. The array is needed by an increasing number of drivers, so it makes sense to add it to struct v4l2_of_endpoint. However, the length of the array is variable and the size of struct v4l2_of_endpoint is fixed

Re: [PATCH 1/1] mn88473: implement lock for all delivery systems

2015-03-22 Thread Antti Palosaari
On 03/22/2015 06:02 PM, Benjamin Larsson wrote: Now it works. Next time I really expect you will test your patches somehow before sending. Now I tested 3 different patch versions, find 2 first to be broken and last one working. It took around 2 hours of my time. Patch applied. Antti Yeah, my

Re: [PATCH v2] [media] mantis: fix error handling

2015-03-22 Thread walter harms
Am 22.03.2015 18:16, schrieb Silvan Jegen: > Remove dead code, make goto label names more expressive and add a label > in order to call mantis_dvb_exit if mantis_uart_init fails. > > Also make sure that mantis_pci_exit is called if we fail the > mantis_stream_control call and that we call mantis

[PATCH 1/1] [media] DocBook media: fix broken EIA hyperlink

2015-03-22 Thread Michael Opdenacker
This fixes the bibliography hyperlink to "http://www.eia.org"; which now redirects to a page with a "404 Not found" error. The latest update to the document referred to is now available on the Consumer Electronics Association website. Signed-off-by: Michael Opdenacker --- Documentation/DocBook/

[PATCH 0/1] DocBook media: fix broken EIA hyperlink

2015-03-22 Thread Michael Opdenacker
Hi, This is a fix for the only broken link in kernel documentation, at least according to the "linkchecker" tool that we are running on the Free Electrons website once a day. As kernel documentation is part of our website (on http://free-electrons.com/kerneldoc/), I get reminded of this broken li

[PATCH v2] [media] mantis: fix error handling

2015-03-22 Thread Silvan Jegen
Remove dead code, make goto label names more expressive and add a label in order to call mantis_dvb_exit if mantis_uart_init fails. Also make sure that mantis_pci_exit is called if we fail the mantis_stream_control call and that we call mantis_i2c_exit if mantis_get_mac fails. Signed-off-by: Silv

Re: [PATCH 1/1] mn88473: implement lock for all delivery systems

2015-03-22 Thread Benjamin Larsson
Now it works. Next time I really expect you will test your patches somehow before sending. Now I tested 3 different patch versions, find 2 first to be broken and last one working. It took around 2 hours of my time. Patch applied. Antti Yeah, my bad. Next I want to move the driver out of stagi

Re: [RFC] Extend struct v4l2_fmtdesc to give more format info

2015-03-22 Thread Sakari Ailus
Hi Hans, On Fri, Mar 20, 2015 at 02:25:57PM +0100, Hans Verkuil wrote: > This is a proposal to extend the information returned by v4l2_fmtdesc > (VIDIOC_ENUM_FMT). > > Especially in combination with my previous RFC PATCH > (https://patchwork.linuxtv.org/patch/28877/) > this is very easy to fill

Re: [PATCH v1.1 14/15] omap3isp: Add support for the Device Tree

2015-03-22 Thread Sakari Ailus
Hi Laurent, On Sat, Mar 21, 2015 at 12:05:04AM +0200, Sakari Ailus wrote: > Add the ISP device to omap3 DT include file and add support to the driver to > use it. > > Also obtain information on the external entities and the ISP configuration > related to them through the Device Tree in addition t

[PATCH v1.1 10/15] omap3isp: Move the syscon register out of the ISP register maps

2015-03-22 Thread Sakari Ailus
The syscon register isn't part of the ISP, use it through the syscom driver regmap instead. The syscom block is considered to be from 343x on ISP revision 2.0 whereas 15.0 is assumed to have 3630 syscon. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart Acked-by: Tony Lindgren --- since v1

Re: [RFC PATCH] v4l2-ioctl: fill in the description for VIDIOC_ENUM_FMT

2015-03-22 Thread Sakari Ailus
On Fri, Mar 20, 2015 at 01:17:19PM +0100, Hans Verkuil wrote: > The descriptions used in drivers for the formats returned with ENUM_FMT > are all over the place. > > So instead allow the core to fill in the description and flags. This > allows drivers to drop the description and flags. > > If the

[GIT PULL FOR v4.1] smiapp OF fixes

2015-03-22 Thread Sakari Ailus
Hi Mauro, The three patches contain first two cleanups and finally move the reading of link-frequencies property from the endpoint node where it is actually located. I've left the patch that adds link-frequencies reading to the V4L2 OF code out for it isn't necessary to get it in now. There will

[GIT PULL 4.1] Astrometa / mn88472 / mn88473

2015-03-22 Thread Antti Palosaari
Two fixes for r820t which I reviewed quite carefully and should be OK. mn88472 and mn88473 are staging demodulator drivers. regards Antti The following changes since commit 3d945be05ac1e806af075e9315bc1b3409adae2b: [media] mn88473: simplify bandwidth registers setting code (2015-03-03 13:09

Re: [PATCH 1/1] mn88473: implement lock for all delivery systems

2015-03-22 Thread Antti Palosaari
On 03/21/2015 12:18 PM, Benjamin Larsson wrote: On 03/21/2015 12:25 AM, Antti Palosaari wrote: On 03/21/2015 01:13 AM, Benjamin Larsson wrote: On 03/19/2015 03:44 PM, Antti Palosaari wrote: Bad news. It does lock for DVB-C now, but DVB-T nor DVB-T2 does not lock. regards Antti I'm getting t

Re: [GIT FIXES FOR v3.20] Fix USERPTR buffers for vb2 dma-contig mem type

2015-03-22 Thread Sakari Ailus
Ping. On Fri, Feb 13, 2015 at 12:16:11PM +0200, Sakari Ailus wrote: > Hi Mauro, > > This single patch fixes setting the write parameter to 1 for > get_user_pages() on writable buffers. Without this using USERPTR buffers > with the dma-contig mem type will corrupt system memory. > > This is direc

Re: [PATCH v1.1 13/15] v4l: of: Read lane-polarities endpoint property

2015-03-22 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Saturday 21 March 2015 00:08:15 Sakari Ailus wrote: > Add lane_polarities field to struct v4l2_of_bus_mipi_csi2 and write the > contents of the lane-polarities property to it. The field tells the polarity > of the physical lanes starting from the first one. A