Hi Dan,
Thanks for the patch!
On Mon, Sep 22, 2014 at 9:00 AM, Dan Carpenter wrote:
> We don't need to check "ret", we know it's zero.
>
> Signed-off-by: Dan Carpenter
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
>
> diff --git a/drivers/media/platform/davinci/vpfe_capture.c
> b/drive
Hi Fancy Fang,
I do have a few comments:
1) One reason why the switch to vm_iomap_memory() was made originally was that
that function did a bunch of sanity checks. Since this patch moves back to
remap_pfn_range() those sanity checks are lost and should be reinstated.
2) You need Marek's Ack as w
On 23.09.2014 00:58, Mauro Carvalho Chehab wrote:
> Em Sun, 31 Aug 2014 13:35:12 +0200
> Matthias Schwarzott escreveu:
>
>> The new file has a different name: dvb-demod-si2165-D.fw
>>
>> Count blocks instead of reading count from extra header.
>> Calculate CRC during upload and compare result to
Hans,
Do you have any more comment on this patch?
Best regards,
Fancy Fang
-Original Message-
From: Fang Chen-B47543
Sent: Wednesday, September 10, 2014 3:29 PM
To: 'Hans Verkuil'; m.che...@samsung.com; v...@zeniv.linux.org.uk
Cc: Guo Shawn-R65073; linux-media@vger.kernel.org;
linux-ker
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Sep 23 04:00:19 CEST 2014
git branch: test
git hash: c0aaf696d45e2a72048a56441e81dad78659c698
gcc versi
tree: git://linuxtv.org/media_tree.git devel-3.17-rc6
head: 7f8de65b0dc84c19e79d7a642a5655524c57035c
commit: f5ac7a471e156f997833f94bad2228e57122c227 [491/499] [media] em28xx:
remove some unnecessary fields from struct em28xx_audio_mode
config: i386-randconfig-r0-0923 (attached as .config)
rep
xc5000 releases firmware right after loading it. Change it to
save the firmware and release it from xc5000_release(). This
helps avoid fecthing firmware when forced firmware load requests
come in to change analog tv frequence and when firmware needs to
be reloaded after suspend and resume.
Signed-
Em Sat, 13 Sep 2014 10:52:22 +0200
Frank Schäfer escreveu:
> Now that we have enum em28xx_int_audio (none/i2s/ac97), it is no longer
> necessary to check dev->audio_mode.ac97 to determine the type of internal
> audio connection.
> There is also no need to save the type of the detected AC97 chip.
Em Tue, 9 Sep 2014 21:31:58 +0200
Matthias Schwarzott escreveu:
> This patch is sent out, because I got multiple requests for it.
> So here it is.
>
> It works only for HVR-4400/HVR-5500.
> For WinTV-HVR-930C-HD it fails with bad/no reception for unknown reasons.
There are some coding style is
Em Sun, 31 Aug 2014 13:35:12 +0200
Matthias Schwarzott escreveu:
> The new file has a different name: dvb-demod-si2165-D.fw
>
> Count blocks instead of reading count from extra header.
> Calculate CRC during upload and compare result to what chip calcuated.
> Use 0x01 instead of real patch versi
Em Mon, 22 Sep 2014 23:21:41 +0100
Srinivas Kandagatla escreveu:
> Hi Mauro,
>
> Thankyou for the "[media] enable COMPILE_TEST for media drivers" patch
> which picked up few things in st-rc driver in linux-next testing.
Anytime. Yeah, the idea is to let more people to test and check for
hidden
There is no need to init .owner field.
Based on the patch from Peter Griffin
"mmc: remove .owner field for drivers using module_platform_driver"
This patch removes the superflous .owner field for drivers which
use the module_platform_driver API, as this is overriden in
platform_driver_register a
This patch moves setting of pm_ops out of the CONFIG_PM_SLEEP condition.
Setting pm ops under CONFIG_PM_SLEEP does not make any sense.
This patch also remove unnecessary also remove CONFIG_PM condition for pm
member in st_rc_driver structure.
Signed-off-by: Srinivas Kandagatla
---
drivers/media/
This patch fixes a compilation error while building with the
random kernel configuration.
drivers/media/rc/st_rc.c: In function 'st_rc_probe':
drivers/media/rc/st_rc.c:281:2: error: implicit declaration of
function 'reset_control_get' [-Werror=implicit-function-declaration]
rc_dev->rstc = reset_
Hi Mauro,
Thankyou for the "[media] enable COMPILE_TEST for media drivers" patch
which picked up few things in st-rc driver in linux-next testing.
Here is a few minor fixes to the driver, could you consider them for
the next merge window.
Thanks,
srini
Srinivas Kandagatla (3):
media: st-rc: m
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@decl@
identifier i1,fld;
type T;
field list[n] fs;
@@
struct i1 {
fs
T fld;
...};
@bad@
identifier decl.i1,i2;
expression e;
initializer list[decl.n] is;
@@
struct i1 i2 = { is
On Mon, 22 Sep 2014, Daniel Glöckner wrote:
It is needed when requesting the irq.
Signed-off-by: Daniel Glöckner
---
drivers/media/common/saa7146/saa7146_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/common/saa7146/saa7146_core.c
b/drivers/media
On 09/22/2014 02:18 PM, Mauro Carvalho Chehab wrote:
> Em Wed, 13 Aug 2014 19:09:23 -0600
> Shuah Khan escreveu:
>
>> xc5000 releases firmware right after loading it. Change it to
>> save the firmware and release it from xc5000_release(). This
>> helps avoid fecthing firmware when forced firmware
It is needed when requesting the irq.
Signed-off-by: Daniel Glöckner
---
drivers/media/common/saa7146/saa7146_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/common/saa7146/saa7146_core.c
b/drivers/media/common/saa7146/saa7146_core.c
index 97afee6.
cab_state->modulation is initialized with a wrong value:
drivers/media/dvb-frontends/stv0367.c:3000:42: warning: mixing different enum
types
drivers/media/dvb-frontends/stv0367.c:3000:42: int enum fe_modulation
versus
drivers/media/dvb-frontends/stv0367.c:3000:42: int enum stv0367cab_mo
This comment is already at the au0828-i2c where it belongs.
So, remove it from a board's entry. It doesn't make any sense
there, as we're setting the clock to 250kHz there, slowing it
down only at the au0828-i2c.
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/usb/au0828/au0828-c
Hi Devin,
On 09/22/2014 01:21 PM, Devin Heitmueller wrote:
> Hi Shuah,
>
> What about G_INPUT and G_TUNER? Consider the following use case, which is
> entirely legal in the V4L2 API:
Did you mean G_INPUT and G_STD here? I didn't see G_TUNER mentioned
below in the use-case.
I didn't know this u
Em Wed, 13 Aug 2014 19:09:23 -0600
Shuah Khan escreveu:
> xc5000 releases firmware right after loading it. Change it to
> save the firmware and release it from xc5000_release(). This
> helps avoid fecthing firmware when forced firmware load requests
> come in to change analog tv frequence and whe
Hi,
does anyone have an idea what this is?
Card is working flawless, for me it is just cosmetic.
3.17.0-rc6
[1.793384] saa7146: register extension 'budget_av'
[1.793393] ata1.00: ATA-8: ST31000524AS, JC4B, max UDMA/133
[1.793394] ata1.00: 1953525168 sectors, multi 16: LBA48 NCQ (d
On 22 September 2014 18:05, Philipp Zabel wrote:
> From: Ulf Hansson
>
> For several reasons it's good practice to leave devices in runtime PM
> active state while those have been probed.
>
> In this cases we also want to prevent the device from going inactive,
> until the firmware has been compl
No caller or macro uses the return value so make it void.
Signed-off-by: Joe Perches
---
This change is associated to a desire to eventually
change printk to return void.
drivers/media/tuners/tda18271-common.c | 19 ---
drivers/media/tuners/tda18271-priv.h | 4 ++--
2 files c
Building with the attached random configuration file,
drivers/built-in.o: In function `vivid_fb_release_buffers':
(.text+0x14960f): undefined reference to `fb_dealloc_cmap'
drivers/built-in.o: In function `vivid_fb_init':
(.text+0x149828): undefined reference to `fb_alloc_cmap'
drivers/built-in.o:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
2014/09/23 00:28, Kamil Debski wrote:
> Hi Ayaka,
>
> Sorry for such a late reply - I just noticed this patch.
>
>> The NV12M is supported by all the version of MFC, so it is better
>> to use it as default OUTPUT format. MFC v5 doesn't support NV2
On 09/22/2014 10:37 AM, Hans Verkuil wrote:
> On 09/22/2014 06:31 PM, Shuah Khan wrote:
>> Hi Hans and Mauro,
>>
>> While I was making changes for media token work, I noticed there are
>> several places au0828_init_tuner() gets called without holding dev lock.
>
> au0828 sets the lock pointer in s
On 09/22/2014 06:31 PM, Shuah Khan wrote:
> Hi Hans and Mauro,
>
> While I was making changes for media token work, I noticed there are
> several places au0828_init_tuner() gets called without holding dev lock.
au0828 sets the lock pointer in struct video_device to the dev lock.
That means that a
Hi Hans and Mauro,
While I was making changes for media token work, I noticed there are
several places au0828_init_tuner() gets called without holding dev lock.
vidioc_s_std(), vidioc_g_tuner(), vidioc_s_tuner(), vidioc_streamon()
au0828_v4l2_resume()
Some of these might be intended since au0828
Hi Ayaka,
Sorry for such a late reply - I just noticed this patch.
> From: ayaka [mailto:ay...@soulik.info]
> Sent: Wednesday, July 23, 2014 6:15 PM
> To: linux-media@vger.kernel.org
> Cc: kyungmin.p...@samsung.com; k.deb...@samsung.com;
> jtp.p...@samsung.com; m.che...@samsung.com; ayaka
> Subje
From: Ulf Hansson
For several reasons it's good practice to leave devices in runtime PM
active state while those have been probed.
In this cases we also want to prevent the device from going inactive,
until the firmware has been completely installed, especially when using
a PM domain.
Signed-of
This patch adds a description of 'flashes' property
to the samsung-fimc.txt.
Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
---
.../devicetree/bindings/media/samsung-fimc.txt |5 +
1 file c
Use "skyworks" as the vendor prefix for the
Skyworks Solutions, Inc.
Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
---
.../devicetree/bindings/vendor-prefixes.txt|1 +
1 file changed, 1 in
This patch adds device tree binding documentation for
the flash cell of the Maxim max77693 multifunctional device.
Signed-off-by: Jacek Anaszewski
Signed-off-by: Andrzej Hajda
Acked-by: Kyungmin Park
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
---
Docum
Addition of a LED Flash Class extension entails the need for flash led
specific device tree properties. The properties being added are:
iout-torch, iout-flash, iout-indicator and flash-timeout.
Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Stephen Warren
Cc: Grant Likely
Cc: Rob
This patch adds device tree binding documentation for
1.5A Step-Up Current Regulator for Flash LEDs.
Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
---
.../devicetree/bindings/leds/leds-aat1290.txt
The documentation being added contains overall description of the
LED Flash Class and the related sysfs attributes. There are also
chapters devoted specifically to the Flash Manager feature.
Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Bryan Wu
Cc: Richard Purdie
---
Documentat
This patch set is the follow-up of the LED / flash API integration
series [1]. For clarity reasons the patchset has been split into
four subsets:
- LED Flash Class
- V4L2 Flash
- LED Flash Class drivers
- Documentation
Changes since version 5:
-
This patch set is the follow-up of the LED / flash API integration
series [1]. For clarity reasons the patchset has been split into
four subsets:
- LED Flash Class
- V4L2 Flash
- LED Flash Class drivers
- Documentation
Changes since version 5:
-
This patch adds led-flash support to Maxim max77693 chipset.
A device can be exposed to user space through LED subsystem
sysfs interface or through V4L2 subdevice when the support
for V4L2 Flash sub-devices is enabled. Device supports up to
two leds which can work in flash and torch mode. Leds can
This patch adds a driver for the 1.5A Step-Up
Current Regulator for Flash LEDs. The device is
programmed through a Skyworks' proprietary AS2Cwire
serial digital interface.
Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Bryan Wu
Cc: Richard Purdie
---
drivers/leds/Kconfig|
Some LED devices support two operation modes - torch and flash.
This patch provides support for flash LED devices in the LED subsystem
by introducing new sysfs attributes and kernel internal interface.
The attributes being introduced are: flash_brightness, flash_strobe,
flash_timeout, max_flash_tim
This patch set is the follow-up of the LED / flash API integration
series [1]. For clarity reasons the patchset has been split into
four subsets:
- LED Flash Class
- V4L2 Flash
- LED Flash Class drivers
- Documentation
Changes since version 5:
-
This patch adds suppport for external v4l2-flash devices.
The support includes parsing camera-flash DT property
and asynchronous subdevice registration.
Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Sylwester Nawrocki
---
drivers/media/platform/exynos4-is/media-dev.c | 36 +
Add a mechanism for locking LED subsystem sysfs interface.
This patch prepares ground for addition of LED Flash Class
extension, whose API will be integrated with V4L2 Flash API.
Such a fusion enforces introducing a locking scheme, which
will secure consistent access to the LED Flash Class device.
This patch prepares ground for addition of LED Flash Class extension to
the LED subsystem. Since turning the torch on must have guaranteed
immediate effect the brightness_set op can't be used for it. Drivers must
schedule a work queue task in this op to be compatible with led-triggers,
which call b
This patch set is the follow-up of the LED / flash API integration
series [1]. For clarity reasons the patchset has been split into
four subsets:
- LED Flash Class
- V4L2 Flash
- LED Flash Class drivers
- Documentation
Changes since version 5:
-
This patch adds helper functions for registering/unregistering
LED class flash devices as V4L2 subdevs. The functions should
be called from the LED subsystem device driver. In case the
support for V4L2 Flash sub-devices is disabled in the kernel
config the functions' empty versions will be used.
S
Changed au0828-core to create media token resource in its
usb_probe() and destroy it from usb_disconnect() interfaces.
It creates the resource on the main struct device which is
the parent device for the interface usb device. This is the
main struct device that is common for all the drivers that
co
Add media token device resource framework to allow sharing
resources such as tuner, dma, audio etc. across media drivers
and non-media sound drivers that control media hardware. The
Media token resource is created at the main struct device that
is common to all drivers that claim various pieces of
Add media token device resource framework to allow sharing
resources such as tuner, dma, audio etc. across media drivers
and non-media sound drivers that control media hardware. The
Media token resource is created at the main struct device that
is common to all drivers that claim various pieces of
Changes to v4l2-core to hold tuner token in v4l2 ioctl that change
the tuner modes, and reset the token from fh exit. The changes are
limited to vb2 calls that disrupt digital stream. vb1 changes are
made in the driver. The following ioctls are changed:
S_INPUT, S_OUTPUT, S_FMT, S_TUNER, S_MODULAT
au0828-video driver uses vb1 api and needs changes to vb1
v4l2 interfaces that change the tuner status. In addition
to that this driver initializes the tuner from a some ioctls
that are query (read) tuner status. These ioctls are changed
to hold the tuner token to avoid disrupting digital stream
if
Change to hold media tuner token exclusive mode in
dvb_frontend_start() before starting the dvb thread
and release from dvb_frontend_thread() when thread
exits. dvb frontend thread is started only when the
dvb device is opened in Read/Write mode.
Signed-off-by: Shuah Khan
---
drivers/media/dvb-c
Building with the attached random configuration file,
drivers/media/rc/st_rc.c: In function ‘st_rc_probe’:
drivers/media/rc/st_rc.c:281:2: error: implicit declaration of
function ‘reset_control_get’ [-Werror=implicit-function-declaration]
rc_dev->rstc = reset_control_get(dev, NULL);
^
drivers/
Dear Recipient,
You have been awarded the sum of 8,000,000.00 (Eight Million Pounds sterling)
with reference number 77100146 by office of the ministry of finance UK.Send us
your personal details to deliver your funds.
Gloria Pete
--
To unsubscribe from this list: send the line "unsubscribe lin
Commit 90c0ae50097 changed how the frame_type of a decoded frame
gets determined, by switching from the get_dec_frame_type to
get_disp_frame_type operation. Unfortunately it seems that on MFC v5 the
result of get_disp_frame_type is always 0 (no display) when decoding
(tested with H264), resulting i
This is 1) *much* easier to type, and 2) is consistent with vivid
('vi' for virtual). More of such virtual drivers are planned, so keeping
the naming consistent makes sense.
Note that the old module name is retained as a module alias.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/Kconf
> >> Is that two tuners in the same device, or two tuners in different devices?
> >
> > DViCO FusionHDTV DVB-T Dual Express2
> >
> > 2 tuners on one card
>
> Any idea if there were changes or are issues with i2c access when there are
> two tuners in the same device?
>
> That's not really my expe
The following changes since commit f5281fc81e9a0a3e80b78720c5ae2ed06da3bfae:
[media] vpif: Fix compilation with allmodconfig (2014-09-09 18:08:08 -0300)
are available in the git repository at:
git://linuxtv.org/hverkuil/media_tree.git for-v3.18d
for you to fetch changes up to 6b167cb4cc6a3b
Mauro,
On 09/22/2014 11:58 AM, James Harper wrote:
>
> Any hints on what I can do to figure out what layer it's stalling at?
I have no idea. I would do a git bisect to try and narrow it down.
>>>
>>> Problem with the bisect is that I can't be sure what version it actually
>>
> >>>
> >>> Any hints on what I can do to figure out what layer it's stalling at?
> >>
> >> I have no idea. I would do a git bisect to try and narrow it down.
> >>
> >
> > Problem with the bisect is that I can't be sure what version it actually
> worked on. It certainly predates when my patch for m
On 09/22/2014 11:46 AM, James Harper wrote:
>>
>>>
>>> Any hints on what I can do to figure out what layer it's stalling at?
>>
>> I have no idea. I would do a git bisect to try and narrow it down.
>>
>
> Problem with the bisect is that I can't be sure what version it actually
> worked on. It cer
>
> >
> > Any hints on what I can do to figure out what layer it's stalling at?
>
> I have no idea. I would do a git bisect to try and narrow it down.
>
Problem with the bisect is that I can't be sure what version it actually worked
on. It certainly predates when my patch for my card was commi
On 09/22/2014 10:30 AM, James Harper wrote:
>>
>> I'll test out the downgrade to 73d8102298719863d54264f62521362487f84256
>> just to be sure, then see if I can take it further back.
>>
>
> 73d8102298719863d54264f62521362487f84256 still breaks for me, so it's
> definitely not related to the conver
>
> I'll test out the downgrade to 73d8102298719863d54264f62521362487f84256
> just to be sure, then see if I can take it further back.
>
73d8102298719863d54264f62521362487f84256 still breaks for me, so it's
definitely not related to the conversion.
Any hints on what I can do to figure out what
Am 21.09.2014 um 22:45 schrieb Jannis:
> Am 21.09.2014 um 19:28 schrieb JPT:
>> Tommorrow I'll swap the sat cable just to make sure this isn't the cause.
>
> Hi Jan,
>
> Are we talking about this device:
> http://www.linuxtv.org/wiki/index.php/Technisat_SkyStar_USB_HD
Yes, exactly.
> (You nev
We don't need to check "ret", we know it's zero.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/platform/davinci/vpfe_capture.c
b/drivers/media/platform/davinci/vpfe_capture.c
index c557eb5..3eb6e4b 100644
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform
We know "ret" is zero so we don't need to test for it. It upsets the
static checkers when we test stuff but we know the answer.
drivers/media/usb/as102/as102_usb_drv.c:164 as102_send_ep1() warn: we tested
'ret' before and it was 'false'
drivers/media/usb/as102/as102_usb_drv.c:189 as102_read_ep2(
71 matches
Mail list logo
