Hi.
On Wed, Sep 03, 2014 at 05:33:00PM -0300, Mauro Carvalho Chehab wrote:
Instead of using if (on == true), just use
if (on).
That allows a faster mental parsing when analyzing the
code.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Sakari Ailus
I will keep it in my mind for my next pa
Hi Oliver,
I added some improvements at libdvbv5 to parse the DVB-T2 and DVB-S2 lines
at dtv-scan-tables.
It can now successully parse all correct files there. The patches for
it are already merged upstream at:
http://git.linuxtv.org/cgit.cgi/v4l-utils.git/
I also added there the Makefil
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Sep 5 04:00:19 CEST 2014
git branch: test
git hash: 89fffac802c18caebdf4e91c0785b522c9f6399a
gcc versi
Updated:
for you to fetch changes up to ccf62c1bfc897f1d9eb22fa685362638c715e9db:
af9035: remove I2C client differently (2014-09-05 02:13:03 +0300)
On 09/05/2014 12:53 AM, Antti Palosaari wrote:
The following changes since commit
89fffac802c18caebdf4e91c0785b522c9f6399a:
[media] drxk_ha
V2
* Fixed trivial bug reported by Daniel
* if/if => if/if else. Compiler, very likely, could not see adap->id
behind many pointers, cannot change between two consecutive if's. Adding
exclusive if()/if else() makes sure compiler knows only one of if
branches could taken.
Antti
On 09/05/2014
It crash kernel when device was removed while it was streaming.
That is because we removed driver and frontend thread was still
running. Use new callback which allows I2C driver removal just
after frontend is unregistered.
V2: fixed by reported by Daniel
Reported-by: Daniel Glöckner
Signed-off-b
On 09/05/2014 01:50 AM, Daniel Glöckner wrote:
On Fri, Sep 05, 2014 at 12:43:43AM +0300, Antti Palosaari wrote:
+ switch (state->af9033_config[adap->id].tuner) {
+ case AF9033_TUNER_IT9135_38:
+ case AF9033_TUNER_IT9135_51:
+ case AF9033_TUNER_IT9135_52:
+ case AF
On Fri, Sep 05, 2014 at 12:43:43AM +0300, Antti Palosaari wrote:
> + switch (state->af9033_config[adap->id].tuner) {
> + case AF9033_TUNER_IT9135_38:
> + case AF9033_TUNER_IT9135_51:
> + case AF9033_TUNER_IT9135_52:
> + case AF9033_TUNER_IT9135_60:
> + case AF9033_TUNER_IT91
The following changes since commit 89fffac802c18caebdf4e91c0785b522c9f6399a:
[media] drxk_hard: fix bad alignments (2014-09-03 19:19:18 -0300)
are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git af9035
for you to fetch changes up to 9507ed6ce19644d0078e0d68af8e4
Add tuner_detach callback in order to allow custom detach. It is
needed when tuner driver is implemented I2C client or some other
kernel bus, but not proprietary dvb_attach / dvb_detach.
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/dvb_usb.h | 1 +
drivers/media/usb/dvb-u
It crash kernel when device was removed while it was streaming.
That is because we removed driver and frontend thread was still
running. Use new callback which allows I2C driver removal just
after frontend is unregistered.
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/af9035.c
Add frontend_detach callback in order to allow custom detach. It is
needed when demod driver is implemented I2C client or some other
kernel bus, but not proprietary dvb_attach / dvb_detach.
Signed-off-by: Antti Palosaari
---
drivers/media/usb/dvb-usb-v2/dvb_usb.h | 2 ++
drivers/media/usb/
Hi Vincent,
On Wednesday 03 September 2014 17:47:48 Vincent Palatin wrote:
> Map V4L2_CID_TILT_SPEED and V4L2_CID_PAN_SPEED to the standard UVC
> CT_PANTILT_RELATIVE_CONTROL terminal control request.
>
> Tested by plugging a Logitech ConferenceCam C3000e USB camera
> and controlling pan/tilt from
Hi Vincent,
Thank you for the patch.
On Wednesday 03 September 2014 17:47:48 Vincent Palatin wrote:
> Map V4L2_CID_TILT_SPEED and V4L2_CID_PAN_SPEED to the standard UVC
> CT_PANTILT_RELATIVE_CONTROL terminal control request.
>
> Tested by plugging a Logitech ConferenceCam C3000e USB camera
> and
Hi Mauro,
Thank you for the patch.
On Wednesday 03 September 2014 17:32:50 Mauro Carvalho Chehab wrote:
> Instead of using 0 or 1 for boolean, use the true/false
> defines.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Laurent Pinchart
> diff --git a/drivers/media/platform/omap3isp/ispc
Hi Hans,
First bad commit (maybe != root cause):
tree: git://linuxtv.org/media_tree.git devel
head: 160416682519b8b63693a47a13460384a2656dad
commit: e75420dd25bc9d7b6f4e3b4c4f6c778b610c8cda [360/499] [media] vivid:
enable the vivid driver
drivers/media/platform/vivid/vivid-radio-rx.c:198
v
Hi Karel,
I suggest you to zero fill v4l2 structures before assign values also
check the return value of all ioctl call.
for example,
struct v4l2_format fmt;
memset(&fmt, 0, sizeof fmt);
fmt.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
fmt.fmt.pix.width = xRes;
ret = ioctl(fd, VIDIOC_
Hi Mauro,
On Thu, 2014-09-04 at 12:36 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 22 May 2014 14:48:07 +0200
> Paul Bolle escreveu:
>
> > dib0900.c has always shipped with its own, manual, configuration
> > system. There a three problems with it.
> >
> > 1) macros that are defined, but not us
HI
We sale cisco new and original switches and routers, following is the product
and price list.
If you are interested, please contact me!
WS-C3750X-24S-S
WS-C3750X-48P-S
WS-C2960S-24TS-L
WS-C2960S-48TS-L
WS-C2960S-48LPS-L
WS-C2960S-48FPS-L
WS-C2960S-48LPD-L
WS-C2960S-48FPD-L
MY S
From: Hans Verkuil
tw_writel maps to writel which maps to __raw_writel(__cpu_to_le32(b),addr).
So tw_writel already calls cpu_to_le32 and it shouldn't be called again
in the code.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/tw68/tw68-video.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
From: Hans Verkuil
The code to calculate the maximum number of buffers allowed in 4 MB
is 1) wrong if PAGE_SIZE != 4096 and 2) unnecessarily complex.
Fix and simplify the code.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/tw68/tw68-video.c | 11 +--
1 file changed, 1 insertion(+)
On 09/04/2014 04:46 PM, Mauro Carvalho Chehab wrote:
> drivers/media/pci/tw68/tw68-video.c:351:9: warning: incorrect type in
> argument 1 (different base types)
> drivers/media/pci/tw68/tw68-video.c:351:9:expected unsigned int
> [unsigned] val
> drivers/media/pci/tw68/tw68-video.c:351:9:g
On 09/04/2014 04:46 PM, Mauro Carvalho Chehab wrote:
> This code implicitly assumes that pagesize is 4096, but this is
> not true on all archs, as the PAGE_SHIFT can be different than
> 12 on all those architectures: alpha, arc, arm64, cris, frv,
> hexagon,ia64, m68k, metag, microblaze, mips, openr
Hi Paul,
Em Thu, 22 May 2014 14:48:07 +0200
Paul Bolle escreveu:
> dib0900.c has always shipped with its own, manual, configuration
> system. There a three problems with it.
>
> 1) macros that are defined, but not used:
> CONFIG_SYS_DVBT
> CONFIG_DIB0090_USE_PWM_AGC
>
> 2) checks for m
Em Thu, 04 Sep 2014 16:54:38 +0200
Hans Verkuil escreveu:
> I'll need to review this as well. Perhaps tw_writel should expect a __le32?
There are several other parts where it is using the address as CPU endian.
Anyway, if you have some BE system, then you can test the board there and
see what w
I need to review this more closely tomorrow.
Hans
On 09/04/14 16:46, Mauro Carvalho Chehab wrote:
> This code implicitly assumes that pagesize is 4096, but this is
> not true on all archs, as the PAGE_SHIFT can be different than
> 12 on all those architectures: alpha, arc, arm64, cris, fr
I'll need to review this as well. Perhaps tw_writel should expect a __le32?
Hans
On 09/04/14 16:46, Mauro Carvalho Chehab wrote:
> drivers/media/pci/tw68/tw68-video.c:351:9: warning: incorrect type in
> argument 1 (different base types)
> drivers/media/pci/tw68/tw68-video.c:351:9:exp
Acked-by: Hans Verkuil
Thanks!
Hans
On 09/04/14 16:46, Mauro Carvalho Chehab wrote:
> drivers/media/pci/tw68/tw68-core.c:72:22: warning: symbol 'tw68_pci_tbl' was
> not declared. Should it be static?
>
> Signed-off-by: Mauro Carvalho Chehab
>
> diff --git a/drivers/media/pci/tw68/tw
drivers/media/pci/tw68/tw68-video.c:351:9: warning: incorrect type in argument
1 (different base types)
drivers/media/pci/tw68/tw68-video.c:351:9:expected unsigned int [unsigned]
val
drivers/media/pci/tw68/tw68-video.c:351:9:got restricted __le32 [usertype]
Signed-off-by: Mauro Carvalh
This code implicitly assumes that pagesize is 4096, but this is
not true on all archs, as the PAGE_SHIFT can be different than
12 on all those architectures: alpha, arc, arm64, cris, frv,
hexagon,ia64, m68k, metag, microblaze, mips, openrisc, parisc,
powerpc, sh, sparc and tile.
The real constrant
drivers/media/pci/tw68/tw68-core.c:72:22: warning: symbol 'tw68_pci_tbl' was
not declared. Should it be static?
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/pci/tw68/tw68-core.c
b/drivers/media/pci/tw68/tw68-core.c
index baf93af1d764..a6fb48cf7aae 100644
--- a/drivers/media/
On 08/04/14 10:47, Hans Verkuil wrote:
> See this bugreport for valgrind with the attached patch:
>
> https://bugs.kde.org/show_bug.cgi?id=338023
A quick follow-up: this patch has been committed in the valgrind repo,
so I assume it will appear in the next valgrind release.
Regards,
Hans
Em Thu, 04 Sep 2014 10:03:40 +0300
Sakari Ailus escreveu:
> On Wed, Sep 03, 2014 at 05:32:48PM -0300, Mauro Carvalho Chehab wrote:
> > Instead of using 0 or 1 for boolean, use the true/false
> > defines.
> >
> > Signed-off-by: Mauro Carvalho Chehab
>
> Thanks!
>
> Acked-by: Sakari Ailus
>
>
There is no need to use hex_dump_to_buffer() since we have a kernel helper to
dump up to 64 bytes just via printk().
Signed-off-by: Andy Shevchenko
---
drivers/media/usb/hdpvr/hdpvr-control.c | 21 ++---
drivers/media/usb/hdpvr/hdpvr-core.c| 27 ++-
2
Hello,
I’ve recently noticed a problem with Modecom Venus and A4Tech PK-333E webcams.
Both can be put into a “bad state” in which they refuse to do anything until
they’re reconnected to the usb port. The test case is simple:
gst-launch-1.0 v4l2src ! videoconvert ! autovideosink
Setting pipeline
We call kfree(data_buf) in the error handling and that will oops if this
is an error pointer.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/media/lirc/lirc_imon.c
b/drivers/staging/media/lirc/lirc_imon.c
index 96c76b3..5441f40 100644
--- a/drivers/staging/media/lirc/lirc_imon.c
+++
When user requests V4L2_MEMORY_MMAP type buffers, the videobuf-core
will assign the corresponding offset to the 'boff' field of the
videobuf_buffer for each requested buffer sequentially. Later, user
may call mmap() to map one or all of the buffers with the 'offset'
parameter which is equal to its
The patch remove the non-multiplanar api for enum_fmt in s5p-mfc.
Now enum_fmt in the driver will only work with multiplanar.
I think it is a bug, hverkuil think it is too. so I made this patch.
Actually gstreamer doesn't care about it, it will merge the result
from non-multiplanar and multiplanar.
As the s5p-mfc is a driver which use multiplanar api, so the
vidioc_enum_fmt_vid serial of ioctl should only for
multiplanar, non-multiplanar shouldn't be implemented at all.
Signed-off-by: ayaka
---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 24 +++-
drivers/media/platf
On Wed, Sep 03, 2014 at 05:33:00PM -0300, Mauro Carvalho Chehab wrote:
> Instead of using if (on == true), just use
> if (on).
>
> That allows a faster mental parsing when analyzing the
> code.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai.
On Wed, Sep 03, 2014 at 05:32:48PM -0300, Mauro Carvalho Chehab wrote:
> Instead of using 0 or 1 for boolean, use the true/false
> defines.
>
> Signed-off-by: Mauro Carvalho Chehab
Thanks!
Acked-by: Sakari Ailus
Would you like me to pick this patch to my tree, or would you like to apply
it di
41 matches
Mail list logo
