Re: [git:media_tree/master] [media] Siano: smsusb - Add a device id for PX-S1UD

2014-03-11 Thread Sat
Thank you for the update, Mauro. I didn't know how to check the status, now I get it :-) Thanks, Satoshi (2014/03/12 0:12), Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch > were queued at the > http://git.linuxtv.org/media_tree.git tr

cron job: media_tree daily build: ERRORS

2014-03-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Mar 12 04:00:31 CET 2014 git branch: test git hash: 262912335c823a2bbcc87003ee55d62cc27f4e48 gcc versio

Re: [REVIEWv3 PATCH 05/35] videodev2.h: add struct v4l2_query_ext_ctrl and VIDIOC_QUERY_EXT_CTRL.

2014-03-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Mar 2014 21:29:29 +0100 Hans Verkuil escreveu: > On 03/11/2014 08:42 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 17 Feb 2014 10:57:20 +0100 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> Add a new struct and ioctl to extend the amount of information you can > >> g

Re: [REVIEWv3 PATCH 06/35] v4l2-ctrls: add support for complex types.

2014-03-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Mar 2014 21:43:47 +0100 Hans Verkuil escreveu: > Hi Mauro, > > On 03/11/2014 09:14 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 17 Feb 2014 10:57:21 +0100 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> This patch implements initial support for complex types. > >>

Re: [REVIEWv3 PATCH 08/35] v4l2-ctrls: create type_ops.

2014-03-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Mar 2014 21:49:51 +0100 Hans Verkuil escreveu: > On 03/11/2014 09:22 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 17 Feb 2014 10:57:23 +0100 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> Since complex controls can have non-standard types we need to be able to do >

Re: [REVIEWv3 PATCH 04/35] videodev2.h: add initial support for complex controls.

2014-03-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Mar 2014 21:23:26 +0100 Hans Verkuil escreveu: > Hi Mauro, > > On 03/11/2014 08:34 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 17 Feb 2014 10:57:19 +0100 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> Complex controls are controls that can be used for compound an

Upstream patches for Samsung Exynos s5p-mfc and gsc-m2m

2014-03-11 Thread John Sheu
This patchset upstreams some changes carried in the ChromeOS kernel tree especially regarding the s5p-mfc video encoder and gsc-m2m color converter hardware functionality. Patch 4 in particular affects the V4L2 interface by allowing VIDIOC_REQBUFS(0) to succeed when the queue is of type V4L2_MEMOR

[PATCH 4/4] v4l2-mem2mem: allow reqbufs(0) with "in use" MMAP buffers

2014-03-11 Thread John Sheu
v4l2-mem2mem presently does not allow VIDIOC_REQBUFS to destroy outstanding buffers if the queue is of type V4L2_MEMORY_MMAP, and if the buffers are considered "in use". This is different behavior than for other memory types, and prevents us for deallocating buffers in a few cases: * In the case

[PATCH 2/4] CHROMIUM: s5p-mfc: support dynamic encoding parameter changes

2014-03-11 Thread John Sheu
Add support for dynamic encoding parameter changes in MFCv6. Parameters set are applied with the next OUTPUT buffer queued to the device with VIDIOC_QBUF. Supported parameters are: * GOP size (V4L2_CID_MPEG_VIDEO_GOP_SIZE) * framerate (from VIDIOC_S_PARM) * VBR target bitrate (V4L2_CID_MPEG_VIDE

[PATCH 1/4] s5p-mfc: fix encoder crash after VIDIOC_STREAMOFF

2014-03-11 Thread John Sheu
VIDIOC_STREAMOFF clears the encoder's destination queue -- routines run from the interrupt handler cannot assume that the queue is non-empty. Signed-off-by: John Sheu --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) dif

[PATCH 3/4] gsc-m2m: report correct format bytesperline and sizeimage

2014-03-11 Thread John Sheu
Explicitly specify sampling period for subsampled chroma formats, so stride and image size are properly reported through VIDIOC_{S,G}_FMT. Signed-off-by: John Sheu --- drivers/media/platform/exynos-gsc/gsc-core.c | 154 +++ drivers/media/platform/exynos-gsc/gsc-core.h |

Re: [REVIEWv3 PATCH 08/35] v4l2-ctrls: create type_ops.

2014-03-11 Thread Hans Verkuil
On 03/11/2014 09:22 PM, Mauro Carvalho Chehab wrote: > Em Mon, 17 Feb 2014 10:57:23 +0100 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> Since complex controls can have non-standard types we need to be able to do >> type-specific checks etc. In order to make that easy type operations are

Re: [REVIEWv3 PATCH 06/35] v4l2-ctrls: add support for complex types.

2014-03-11 Thread Hans Verkuil
Hi Mauro, On 03/11/2014 09:14 PM, Mauro Carvalho Chehab wrote: > Em Mon, 17 Feb 2014 10:57:21 +0100 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> This patch implements initial support for complex types. >> >> For the most part the changes are fairly obvious (basic support for is_ptr >>

Re: [REVIEWv3 PATCH 05/35] videodev2.h: add struct v4l2_query_ext_ctrl and VIDIOC_QUERY_EXT_CTRL.

2014-03-11 Thread Hans Verkuil
On 03/11/2014 08:42 PM, Mauro Carvalho Chehab wrote: > Em Mon, 17 Feb 2014 10:57:20 +0100 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> Add a new struct and ioctl to extend the amount of information you can >> get for a control. >> >> It gives back a unit string, the range is now a s64

[PATCH] media: rc-core: use %s in rc_map_get() module load

2014-03-11 Thread Kees Cook
rc_map_get() takes a single string literal for the module to load, so make sure it cannot be used as a format string in the call to request_module(). Signed-off-by: Kees Cook --- On another security note, this raw request_module() call should have some kind of prefix associated with it to make su

Re: [REVIEWv3 PATCH 04/35] videodev2.h: add initial support for complex controls.

2014-03-11 Thread Hans Verkuil
Hi Mauro, On 03/11/2014 08:34 PM, Mauro Carvalho Chehab wrote: > Em Mon, 17 Feb 2014 10:57:19 +0100 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> Complex controls are controls that can be used for compound and array >> types. This allows for more complex data structures to be used with

Re: [REVIEWv3 PATCH 08/35] v4l2-ctrls: create type_ops.

2014-03-11 Thread Mauro Carvalho Chehab
Em Mon, 17 Feb 2014 10:57:23 +0100 Hans Verkuil escreveu: > From: Hans Verkuil > > Since complex controls can have non-standard types we need to be able to do > type-specific checks etc. In order to make that easy type operations are > added. > There are four operations: > > - equal: check if

[linuxtv-media:master 428/499] ERROR: "__divdi3" undefined!

2014-03-11 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 262912335c823a2bbcc87003ee55d62cc27f4e48 commit: 03fdfbfd3b5944bfd210541a83c9b222e2c20920 [428/499] [media] drx-j: Prepare to use DVBv5 stats config: make ARCH=mips allmodconfig Note: the linuxtv-media/master HEAD 262912335c823a2bbcc87003ee5

Re: [REVIEWv3 PATCH 06/35] v4l2-ctrls: add support for complex types.

2014-03-11 Thread Mauro Carvalho Chehab
Em Mon, 17 Feb 2014 10:57:21 +0100 Hans Verkuil escreveu: > From: Hans Verkuil > > This patch implements initial support for complex types. > > For the most part the changes are fairly obvious (basic support for is_ptr > types, the type_is_int function is replaced by a is_int bitfield, and > v

Re: [REVIEWv3 PATCH 05/35] videodev2.h: add struct v4l2_query_ext_ctrl and VIDIOC_QUERY_EXT_CTRL.

2014-03-11 Thread Mauro Carvalho Chehab
Em Mon, 17 Feb 2014 10:57:20 +0100 Hans Verkuil escreveu: > From: Hans Verkuil > > Add a new struct and ioctl to extend the amount of information you can > get for a control. > > It gives back a unit string, the range is now a s64 type, and the matrix > and element size can be reported through

Re: [REVIEWv3 PATCH 04/35] videodev2.h: add initial support for complex controls.

2014-03-11 Thread Mauro Carvalho Chehab
Em Mon, 17 Feb 2014 10:57:19 +0100 Hans Verkuil escreveu: > From: Hans Verkuil > > Complex controls are controls that can be used for compound and array > types. This allows for more complex data structures to be used with the > control framework. > > Such controls always have the V4L2_CTRL_FL

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Philipp Zabel
Hi Laurent, Am Dienstag, den 11.03.2014, 16:21 +0100 schrieb Laurent Pinchart: > Hi Philipp, > > On Tuesday 11 March 2014 16:07:00 Philipp Zabel wrote: > > Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: > > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > > [snip] >

[GIT PULL] Samsung media drivers update

2014-03-11 Thread Sylwester Nawrocki
Hi Mauro, The following changes since commit 0d49e7761173520ff02cec6f11d581f8ebca764d: drx-j: Fix post-BER calculus on QAM modulation (2014-03-11 07:43:54 -0300) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git for-v3.15 for you to fetch changes up to 431c298

PLEASE TAKE NOTE OF THIS INFORMATION AND REPLY URGENTLY.

2014-03-11 Thread Mr.Laurance Welam
Greetings!! Please, I would respectfully request that you keep the contents of this e-mail confidential and respect the integrity of the information you come by as result of this e-mail. I contact you independently and no one is informed of this communication. Firstly, I am Mr. LAURANCE WELAM,

Re: mmotm 2014-03-10-15-35 uploaded (media/pci/ttpci/av7110)

2014-03-11 Thread Randy Dunlap
On 03/10/2014 03:37 PM, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2014-03-10-15-35 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of m

Re: [PATCH v3 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Hans Verkuil
On 03/11/2014 05:24 PM, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 11 March 2014 17:11:07 Hans Verkuil wrote: >> On 03/11/2014 05:08 PM, Laurent Pinchart wrote: >>> Hi Hans, >>> >>> On Tuesday 11 March 2014 16:44:27 Hans Verkuil wrote: On 03/11/2014 04:09 PM, Laurent Pinchart wrote: >>

Re: [PATCH v8 3/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Laurent Pinchart
On Tuesday 11 March 2014 17:34:30 Sylwester Nawrocki wrote: > This patch documents following updates of the Exynos4 SoC camera subsystem > devicetree binding: > > - addition of #clock-cells and clock-output-names properties to 'camera' >node - these are now needed so the image sensor sub-devi

[PATCH v8 3/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Sylwester Nawrocki
This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells and clock-output-names properties to 'camera' node - these are now needed so the image sensor sub-devices can reference clocks provided by the camera host interface, -

Re: [PATCH v7 3/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Sylwester Nawrocki
Hi Laurent, On 11/03/14 17:20, Laurent Pinchart wrote: >> Image sensor nodes >> > -- >> > @@ -97,8 +108,8 @@ Image sensor nodes >> > The sensor device nodes should be added to their control bus controller >> > (e.g. I2C0) nodes and linked to a port node in the csis or the >> > p

[GIT PULL 3.15] m88ds3103 fix non-important issues

2014-03-11 Thread Antti Palosaari
These are reported by Coverity and has no functionality changes. regards Antti The following changes since commit c3c2077d9579472b07581ecdaf6cc5a60b1700bc: [media] nuvoton-cir: Activate PNP device when probing (2014-03-11 12:22:50 -0300) are available in the git repository at: git://lin

Re: [PATCH v3 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 March 2014 17:11:07 Hans Verkuil wrote: > On 03/11/2014 05:08 PM, Laurent Pinchart wrote: > > Hi Hans, > > > > On Tuesday 11 March 2014 16:44:27 Hans Verkuil wrote: > >> On 03/11/2014 04:09 PM, Laurent Pinchart wrote: > >>> The subdev EDID ioctls receive a pad field that mu

Re: [PATCH v7 3/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Laurent Pinchart
Hi Sylwester, Thank you for the patch. On Tuesday 11 March 2014 17:00:35 Sylwester Nawrocki wrote: > This patch documents following updates of the Exynos4 SoC camera subsystem > devicetree binding: > > - addition of #clock-cells and clock-output-names properties to 'camera' >node - these ar

[GIT PULL 3.14] m88ds3103 bugfix

2014-03-11 Thread Antti Palosaari
I have forgotten to pull request that earlier. It is simple one bit wrong in one register. regards Antti The following changes since commit 81d428cbdb9e630f4424bf81522cd35394beba76: [media] saa7134: fix WARN_ON during resume (2014-03-11 10:17:06 -0300) are available in the git repository at

Re: [PATCH v3 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Hans Verkuil
On 03/11/2014 05:08 PM, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 11 March 2014 16:44:27 Hans Verkuil wrote: >> On 03/11/2014 04:09 PM, Laurent Pinchart wrote: >>> The subdev EDID ioctls receive a pad field that must reference an >>> existing pad and an EDID field that must point to a buff

Re: [GIT PULL] m88ds3103 fixes

2014-03-11 Thread Antti Palosaari
DROP that request! I will split it to 2 requests, one for 3.14 and one for 3.15. Antti On 11.03.2014 17:42, Antti Palosaari wrote: I just noticed from patchwork these old patches are pending. It appears I have not pull requested or mail is just missed from the reason or the other. They are jus

Re: [PATCH v3 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 March 2014 16:44:27 Hans Verkuil wrote: > On 03/11/2014 04:09 PM, Laurent Pinchart wrote: > > The subdev EDID ioctls receive a pad field that must reference an > > existing pad and an EDID field that must point to a buffer. Validate > > both fields in the core code instead o

[PATCH v7 3/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Sylwester Nawrocki
This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells and clock-output-names properties to 'camera' node - these are now needed so the image sensor sub-devices can reference clocks provided by the camera host interface, -

[linuxtv-media:master 446/499] drxj.c:undefined reference to `__divdi3'

2014-03-11 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: c3c2077d9579472b07581ecdaf6cc5a60b1700bc commit: 03fdfbfd3b5944bfd210541a83c9b222e2c20920 [446/499] [media] drx-j: Prepare to use DVBv5 stats config: make ARCH=i386 allyesconfig Note: the linuxtv-media/master HEAD c3c2077d9579472b07581ecdaf6

Re: [PATCH v3 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Hans Verkuil
On 03/11/2014 04:09 PM, Laurent Pinchart wrote: > The subdev EDID ioctls receive a pad field that must reference an > existing pad and an EDID field that must point to a buffer. Validate > both fields in the core code instead of duplicating validation in all > drivers. > > Signed-off-by: Laurent P

[GIT PULL] m88ds3103 fixes

2014-03-11 Thread Antti Palosaari
I just noticed from patchwork these old patches are pending. It appears I have not pull requested or mail is just missed from the reason or the other. They are just fine for 3.15, but "m88ds3103: fix bug on .set_tone()" is stuff for 3.14 too. I know it is very late, but given the fact it fixes

[linuxtv-media:master 448/499] ERROR: "__divdi3" [drivers/media/dvb-frontends/drx39xyj/drx39xyj.ko] undefined!

2014-03-11 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 7b802ce7e8c67510389fdbbe29edd87a75df3a93 commit: 03fdfbfd3b5944bfd210541a83c9b222e2c20920 [448/499] [media] drx-j: Prepare to use DVBv5 stats config: make ARCH=m68k allmodconfig Note: the linuxtv-media/master HEAD 7b802ce7e8c67510389fdbbe29e

Re: [PATCH v3 26/48] v4l: Add support for DV timings ioctls on subdev nodes

2014-03-11 Thread Hans Verkuil
On 03/11/2014 04:09 PM, Laurent Pinchart wrote: > Validate the pad field in the core code whenever specified. > > Signed-off-by: Laurent Pinchart Reviewed-by: Hans Verkuil Regards, Hans > --- > .../DocBook/media/v4l/vidioc-dv-timings-cap.xml| 27 +++ > .../DocBoo

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Laurent Pinchart
Hi Philipp, On Tuesday 11 March 2014 16:07:00 Philipp Zabel wrote: > Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: [snip] > > > In theory unidirectional links in DT are indeed enough. However, let's > > > not forget t

[PATCH v3 46/48] adv7604: Add DT support

2014-03-11 Thread Laurent Pinchart
Parse the device tree node to populate platform data. Signed-off-by: Laurent Pinchart Acked-by: Hans Verkuil --- .../devicetree/bindings/media/i2c/adv7604.txt | 56 + drivers/media/i2c/adv7604.c| 92 ++ 2 files changed, 134 insertions

[PATCH v3 42/48] adv7604: Replace *_and_or() functions with *_clr_set()

2014-03-11 Thread Laurent Pinchart
The *_and_or() functions take an 'and' bitmask to be ANDed with the register value before ORing it with th 'or' bitmask. As the functions are used to mask and set bits selectively, this requires the caller to invert the 'and' bitmask and is thus error prone. Replace those functions with a *_clr_set

[PATCH v3 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Laurent Pinchart
The subdev EDID ioctls receive a pad field that must reference an existing pad and an EDID field that must point to a buffer. Validate both fields in the core code instead of duplicating validation in all drivers. Signed-off-by: Laurent Pinchart Acked-by: Sakari Ailus --- drivers/media/i2c/ad93

[PATCH v3 36/48] adv7604: Make output format configurable through pad format operations

2014-03-11 Thread Laurent Pinchart
Replace the dummy video format operations by pad format operations that configure the output format. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/adv7604.c | 280 include/media/adv7604.h | 56 - 2 files changed, 275 insertions(+)

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Philipp Zabel
Hi Grant, Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart > wrote: > > On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: > > > On 08/03/14 13:41, Grant Likely wrote: > > > >> Ok. If we go for single directional link, the qu

[PATCH v3 26/48] v4l: Add support for DV timings ioctls on subdev nodes

2014-03-11 Thread Laurent Pinchart
Validate the pad field in the core code whenever specified. Signed-off-by: Laurent Pinchart --- .../DocBook/media/v4l/vidioc-dv-timings-cap.xml| 27 +++ .../DocBook/media/v4l/vidioc-enum-dv-timings.xml | 30 +- drivers/media/v4l2-core/v4l2-subdev.c

Re: [PATCH v6 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Laurent Pinchart
Hi Sylwester, On Tuesday 11 March 2014 14:38:37 Sylwester Nawrocki wrote: > Hi Laurent, > > Thanks for your review. You're welcome. > On 11/03/14 13:30, Laurent Pinchart wrote: > [...] > > >> --- > >> > >> .../devicetree/bindings/media/samsung-fimc.txt | 34 +- > >> 1 file

Re: [PATCH] saa7134: Add support for SnaZio TvPVR PRO

2014-03-11 Thread Mauro Carvalho Chehab
Em Mon, 10 Feb 2014 07:28:31 +0200 Antti Palosaari escreveu: > Moikka! > > On 10.02.2014 01:44, GEORGE wrote: > > > b/drivers/media/rc/keymaps/rc-snazio-tvpvr-pro.c > > new file mode 100644 > > index 000..44f0c81 > > --- /dev/null > > +++ b/drivers/media/rc/keymaps/rc-snazio-tvpvr-pro.c > >

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Andrzej Hajda
On 03/10/2014 12:42 PM, Laurent Pinchart wrote: > Hi Andrzej, > >>> I like that idea. I would prefer making the 'port' nodes mandatory and the >>> 'ports' and 'endpoint' nodes optional. Leaving the 'port' node out >>> slightly decreases readability in my opinion, but making the 'endpoint' >>> node

Re: [PATCH v4 3/3] Documentation: of: Document graph bindings

2014-03-11 Thread Sylwester Nawrocki
On 10/03/14 07:53, Tomi Valkeinen wrote: > On 08/03/14 14:25, Grant Likely wrote: > >> Sure. If endpoints are logical, then only create the ones actually >> hooked up. No problem there. But nor do I see any issue with having >> empty connections if the board author things it makes sense to have th

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Philipp Zabel
Hi, Am Dienstag, den 11.03.2014, 15:27 +0200 schrieb Tomi Valkeinen: > On 11/03/14 15:16, Laurent Pinchart wrote: > > >> And if I gathered Grant's opinion correctly (correct me if I'm wrong), > >> he thinks things should be explicit, i.e. the bindings for, say, an > >> encoder should state that t

[PATCH] drx39xyj: fix 64 bit division on 32 bit arch

2014-03-11 Thread Gianluca Gennari
Fix this linker warning: WARNING: "__divdi3" [media_build/v4l/drx39xyj.ko] undefined! Signed-off-by: Gianluca Gennari --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c b/drivers/med

Re: [PATCH v6 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Sylwester Nawrocki
Hi Laurent, Thanks for your review. On 11/03/14 13:30, Laurent Pinchart wrote: [...] >> --- >> .../devicetree/bindings/media/samsung-fimc.txt | 34 - >> 1 file changed, 26 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Tomi Valkeinen
On 11/03/14 15:16, Laurent Pinchart wrote: >> And if I gathered Grant's opinion correctly (correct me if I'm wrong), >> he thinks things should be explicit, i.e. the bindings for, say, an >> encoder should state that the encoder's output endpoint _must_ contain a >> remote-endpoint property, where

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Laurent Pinchart
Hi Tomi, On Tuesday 11 March 2014 14:59:20 Tomi Valkeinen wrote: > On 11/03/14 13:43, Laurent Pinchart wrote: > >> We could scan the whole tree for entities, ports and endpoints once, in > >> the base oftree code, and put that into a graph structure, adding the > >> backlinks. The of_graph_* helpe

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-11 Thread Archit Taneja
On Tuesday 11 March 2014 06:19 PM, Hans Verkuil wrote: On 03/11/14 13:46, Archit Taneja wrote: On Tuesday 11 March 2014 05:51 PM, Hans Verkuil wrote: Hi Archit, A few small comments below... On 03/11/14 09:33, Archit Taneja wrote: Yes. If for no other reason that I plan on adding crop/co

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Andrzej Hajda
On 03/10/2014 04:15 PM, Laurent Pinchart wrote: > Hi Grant, > > On Monday 10 March 2014 14:58:15 Grant Likely wrote: >> On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: >>> On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: On 08/03/14 13:41, Grant Likely wrote: >> Ok. If w

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Tomi Valkeinen
On 11/03/14 13:43, Laurent Pinchart wrote: >> We could scan the whole tree for entities, ports and endpoints once, in >> the base oftree code, and put that into a graph structure, adding the >> backlinks. >> The of_graph_* helpers could then use that graph instead of the device >> tree. > > That

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-11 Thread Hans Verkuil
On 03/11/14 13:46, Archit Taneja wrote: > On Tuesday 11 March 2014 05:51 PM, Hans Verkuil wrote: >> Hi Archit, >> >> A few small comments below... >> >> On 03/11/14 09:33, Archit Taneja wrote: >>> Add selection ioctl ops. For VPE, cropping makes sense only for the input to >>> VPE(or V4L2_BUF_TYPE_

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-11 Thread Archit Taneja
On Tuesday 11 March 2014 05:51 PM, Hans Verkuil wrote: Hi Archit, A few small comments below... On 03/11/14 09:33, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only

[GIT PULL FOR v3.15] DocBook fixes and a new pci skeleton driver template

2014-03-11 Thread Hans Verkuil
Hi Mauro, This patch series adds a bunch of docbook fixes, posted here earlier: http://www.spinics.net/lists/linux-media/msg74059.html and it adds a pci skeleton driver originally written for FOSDEM 2014 and posted earlier here: http://comments.gmane.org/gmane.linux.drivers.video-input-infrastr

Re: [PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-03-11 Thread Arun Kumar K
Hi Kamil, On Tue, Mar 11, 2014 at 4:59 PM, Kamil Debski wrote: > Hi Arun, > >> From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun >> Kumar K >> Sent: Friday, March 07, 2014 9:26 AM >> >> From: Pawel Osciak >> >> Currently, for formats that are not H264, MFC driver will check

Re: [PATCH v3 14/14] v4l: ti-vpe: retain v4l2_buffer flags for captured buffers

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: > The dequed CAPTURE_MPLANE type buffers don't contain the flags that the > originally queued OUTPUT_MPLANE type buffers have. This breaks compliance. > > Copy the source v4l2_buffer flags to the destination v4l2_buffer flags before > they are dequed. > > S

Re: [PATCH v3 13/14] v4l: ti-vpe: Set correct field parameter for output and capture buffers

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: > The vpe driver wasn't setting the correct field parameter for dequed CAPTURE > type buffers for the case where the captured output is progressive. > > Set the field to V4L2_FIELD_NONE for the completed destination buffers when > the captured output is prog

Re: [PATCH v6 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Laurent Pinchart
Hi Sylwester, Thank you for the patch. On Thursday 06 March 2014 17:20:12 Sylwester Nawrocki wrote: > This patch documents following updates of the Exynos4 SoC camera subsystem > devicetree binding: > > - addition of #clock-cells property to 'camera' node - the #clock-cells >property is nee

Re: [GIT PULL] SDR API

2014-03-11 Thread Antti Palosaari
On 10.03.2014 21:38, Antti Palosaari wrote: That is just same set I sent earlier too, but rebased to latest media/master and 6 small compliance fix. PULL request update. I rebased that again to todays media/master as master was rebased. The following changes since commit 0d49e7761173520ff

Re: [PATCH v3 12/14] v4l: ti-vpe: zero out reserved fields in try_fmt

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: > Zero out the reserved formats in v4l2_pix_format_mplane and > v4l2_plane_pix_format members of the returned v4l2_format pointer when passed > through TRY_FMT ioctl. > > This ensures that the user doesn't interpret the non-zero fields as some data > passed

Re: [PATCH v3 11/14] v4l: ti-vpe: Fix initial configuration queue data

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: > The vpe output and capture queues are initially configured to default values > in > vpe_open(). A G_FMT before any S_FMTs will result in these values being > populated. > > The colorspace and bytesperline parameter of this initial configuration are > inco

Re: [PATCH v3 10/14] v4l: ti-vpe: Use correct bus_info name for the device in querycap

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: > The bus_info parameter in v4l2_capabilities expects a 'platform_' prefix. This > wasn't done in the driver and hence was breaking compliance. Update the > bus_info > parameter accordingly. > > Signed-off-by: Archit Taneja Reviewed-by: Hans Verkuil > -

Re: [PATCH v3 09/14] v4l: ti-vpe: report correct capabilities in querycap

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: > querycap currently returns V4L2_CAP_VIDEO_M2M as a capability, this should be > V4L2_CAP_VIDEO_M2M_MPLANE instead, as the driver supports multiplanar formats. > > Signed-off-by: Archit Taneja Reviewed-by: Hans Verkuil > --- > drivers/media/platform/ti

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-11 Thread Hans Verkuil
Hi Archit, A few small comments below... On 03/11/14 09:33, Archit Taneja wrote: > Add selection ioctl ops. For VPE, cropping makes sense only for the input to > VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense > only for the output of VPE(or V4L2_BUF_TYPE_VIDEO_CAPTURE

Re: [PATCH v2 01/48] v4l: of: Support empty port nodes

2014-03-11 Thread Sylwester Nawrocki
Hi Laurent, On 11/03/14 00:15, Laurent Pinchart wrote: > Empty port nodes are allowed but currently unsupported as the > v4l2_of_get_next_endpoint() function assumes that all port nodes have at > least an endpoint. Fix this. > > Signed-off-by: Laurent Pinchart Acked-by: Sylwester Nawrocki > -

Re: [PATCH v3 04/14] v4l: ti-vpe: Allow DMABUF buffer type support

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: > For OMAP and DRA7x, we generally allocate video and graphics buffers through > omapdrm since the corresponding omap-gem driver provides DMM-Tiler backed > contiguous buffers. omapdrm is a dma-buf exporter. These buffers are used by > other drivers in the vi

Re: [PATCH v3 03/14] v4l: ti-vpe: Use video_device_release_empty

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: > The video_device struct is currently embedded in the driver data struct > vpe_dev. > A vpe_dev instance is allocated by the driver, and the memory for the vfd is a > part of this struct. > > The v4l2 core, however, manages the removal of the vfd region, t

Re: [PATCH v3 05/14] v4l: ti-vpe: Allow usage of smaller images

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: > The minimum width and height for VPE input/output was kept as 128 pixels. VPE > doesn't have a constraint on the image height, it requires the image width to > be at least 16 bytes. > > Change the minimum supported dimensions to 32x32. This allows us to >

Re: [PATCH v2 00/48] ADV7611 support

2014-03-11 Thread Hans Verkuil
Hi Laurent, You can add my: Reviewed-by: Hans Verkuil for patches 28-35, 37-45 and 47. For patches 46 and 48 (DT related) add my: Acked-by: Hans Verkuil For patches 26 and 27 I posted review comments, and patch 36 is removing support for the op_ch_sel field which I really need on my system.

cron job: media_tree daily build: WARNINGS

2014-03-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 11 12:12:39 CET 2014 git branch: test git hash: 0d49e7761173520ff02cec6f11d581f8ebca764d gcc versio

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Laurent Pinchart
Hi Philipp, On Monday 10 March 2014 16:40:30 Philipp Zabel wrote: > Am Montag, den 10.03.2014, 16:15 +0100 schrieb Laurent Pinchart: > > On Monday 10 March 2014 14:58:15 Grant Likely wrote: > > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > > > > On Monday 10 March 2014 12:18:20 T

RE: [PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-03-11 Thread Kamil Debski
Hi Arun, > From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun > Kumar K > Sent: Friday, March 07, 2014 9:26 AM > > From: Pawel Osciak > > Currently, for formats that are not H264, MFC driver will check the > consumed stream size returned by the firmware and, based on that, w

Re: [PATCH 36/47] adv7604: Make output format configurable through pad format operations

2014-03-11 Thread Hans Verkuil
Hi Laurent, On 03/11/14 12:16, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 11 March 2014 10:05:00 Hans Verkuil wrote: >> On 03/10/14 23:43, Laurent Pinchart wrote: >>> On Wednesday 12 February 2014 16:01:17 Hans Verkuil wrote: On 02/05/14 17:42, Laurent Pinchart wrote: > Replace th

Re: [PATCH 36/47] adv7604: Make output format configurable through pad format operations

2014-03-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 March 2014 10:05:00 Hans Verkuil wrote: > On 03/10/14 23:43, Laurent Pinchart wrote: > > On Wednesday 12 February 2014 16:01:17 Hans Verkuil wrote: > >> On 02/05/14 17:42, Laurent Pinchart wrote: > >>> Replace the dummy video format operations by pad format operations that >

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-11 Thread Mauro Carvalho Chehab
Em Mon, 10 Mar 2014 14:37:58 + Grant Likely escreveu: > On Mon, 10 Mar 2014 10:26:30 -0300, Mauro Carvalho Chehab > wrote: > > Em Fri, 07 Mar 2014 18:23:30 + > > Grant Likely escreveu: > > > > > On Thu, 06 Mar 2014 18:13:20 +0100, Philipp Zabel > > > wrote: > > > > Hi Mauro, Russell

Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-11 Thread Philipp Zabel
Hi Laurent, Am Montag, den 10.03.2014, 20:19 +0100 schrieb Laurent Pinchart: > On Friday 07 March 2014 18:40:54 Philipp Zabel wrote: > > While we look at of_graph_get_next_endpoint(), could you explain the > > reason behind the extra reference count increase on the prev node: > > > > /* > >

Re: [linuxtv-media:master 499/499] drivers/media/dvb-frontends/drx39xyj/drx39xxj.h:22:0: error: unterminated #ifndef

2014-03-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Mar 2014 18:48:53 +0800 kbuild test robot escreveu: > tree: git://linuxtv.org/media_tree.git master > head: 164e5cfb7d37e4826a8337029716f4885657d859 > commit: 164e5cfb7d37e4826a8337029716f4885657d859 [499/499] [media] > drx39xxj.h: Fix undefined reference to attach function > conf

cron job: media_tree daily build: ERRORS

2014-03-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 11 11:47:29 CET 2014 git branch: test git hash: 0d49e7761173520ff02cec6f11d581f8ebca764d gcc versio

Re: [PATCH v2 26/48] v4l: Add support for DV timings ioctls on subdev nodes

2014-03-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 March 2014 11:38:39 Hans Verkuil wrote: > On 03/11/14 00:15, Laurent Pinchart wrote: > > Validate the pad field in the core code whenever specified. > > > > Signed-off-by: Laurent Pinchart > > --- > > > > .../DocBook/media/v4l/vidioc-dv-timings-cap.xml| 27 ++

Re: [PATCH v2 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Hans Verkuil
On 03/11/14 11:57, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 11 March 2014 11:45:09 Hans Verkuil wrote: >> On 03/11/14 00:15, Laurent Pinchart wrote: >>> The subdev EDID ioctls receive a pad field that must reference an >>> existing pad and an EDID field that must point to a buffer. Vali

Re: [PATCH v2 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 March 2014 11:45:09 Hans Verkuil wrote: > On 03/11/14 00:15, Laurent Pinchart wrote: > > The subdev EDID ioctls receive a pad field that must reference an > > existing pad and an EDID field that must point to a buffer. Validate > > both fields in the core code instead of dup

[linuxtv-media:master 499/499] drivers/media/dvb-frontends/drx39xyj/drx39xxj.h:22:0: error: unterminated #ifndef

2014-03-11 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 164e5cfb7d37e4826a8337029716f4885657d859 commit: 164e5cfb7d37e4826a8337029716f4885657d859 [499/499] [media] drx39xxj.h: Fix undefined reference to attach function config: make ARCH=m68k allmodconfig All error/warnings: In file included f

Re: [PATCH v2 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Hans Verkuil
On 03/11/14 00:15, Laurent Pinchart wrote: > The subdev EDID ioctls receive a pad field that must reference an > existing pad and an EDID field that must point to a buffer. Validate > both fields in the core code instead of duplicating validation in all > drivers. > > Signed-off-by: Laurent Pincha

[PATCH] drx-j: Fix post-BER calculus on QAM modulation

2014-03-11 Thread Mauro Carvalho Chehab
There are two troubles there: 1) the bit error measure were not accumulating; 2) it was missing the bit count. Fix them. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dri

Re: [PATCH v2 26/48] v4l: Add support for DV timings ioctls on subdev nodes

2014-03-11 Thread Hans Verkuil
On 03/11/14 00:15, Laurent Pinchart wrote: > Validate the pad field in the core code whenever specified. > > Signed-off-by: Laurent Pinchart > --- > .../DocBook/media/v4l/vidioc-dv-timings-cap.xml| 27 +++ > .../DocBook/media/v4l/vidioc-enum-dv-timings.xml | 30 > +

[PATCH] drx-j: use ber_count var

2014-03-11 Thread Mauro Carvalho Chehab
drivers/media/dvb-frontends/drx39xyj/drxj.c: In function 'ctrl_get_qam_sig_quality': drivers/media/dvb-frontends/drx39xyj/drxj.c:9468:6: warning: variable 'ber_cnt' set but not used [-Wunused-but-set-variable] u32 ber_cnt = 0; /* BER count */ ^ By reading the comment, it is said that BER

[GIT PULL for 3.15] mem2mem patches

2014-03-11 Thread Kamil Debski
The following changes since commit f2d7313534072a5fe192e7cf46204b413acef479: [media] drx-d: add missing braces in drxd_hard.c:DRXD_init (2014-03-09 09:20:50 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git master for you to fetch changes up to 0dceda

Re: [PATCH v2 06/48] v4l: Add pad-level DV timings subdev operations

2014-03-11 Thread Hans Verkuil
Reviewed-by: Hans Verkuil On 03/11/14 00:15, Laurent Pinchart wrote: > Signed-off-by: Laurent Pinchart > --- > include/media/v4l2-subdev.h| 4 > include/uapi/linux/videodev2.h | 10 -- > 2 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/include/media/v4l2-sub

[PATCH] v4l: subdev: Move [gs]_std operation to video ops

2014-03-11 Thread Laurent Pinchart
The g_std and s_std operations are video-related, move them to the video ops where they belong. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/adv7180.c | 6 +- drivers/media/i2c/adv7183.c | 4 ++-- drivers/media/i2c/adv7842.c

[PATCH] em28xx: fix PCTV 290e LNA oops

2014-03-11 Thread Antti Palosaari
Pointer to device state has been moved to different location during some change. PCTV 290e LNA function still uses old pointer, carried over FE priv, and it crash. Reported-by: Janne Kujanpää Signed-off-by: Antti Palosaari --- drivers/media/usb/em28xx/em28xx-dvb.c | 3 ++- 1 file changed, 2 ins

  1   2   >