cron job: media_tree daily build: WARNINGS

2014-02-14 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Feb 15 04:00:21 CET 2014 git branch: test git hash: 37e59f876bc710d67a30b660826a5e83e07101ce gcc versio

Re: OMAP3 ISP capabilities, resizer

2014-02-14 Thread Laurent Pinchart
Hi Peter, On Wednesday 12 February 2014 16:19:55 Peter Meerwald wrote: > Hello, > > some more findings: > > * the driver bug seen below was observed with kernel 3.7 and is already > fixed in more recent kernels, likely with commit 864a121274, > [media] v4l: Don't warn during link validation when

[PATCH 2/2] omap3isp: Don't ignore failure to locate external subdev

2014-02-14 Thread Laurent Pinchart
A failure to locate the external subdev for a non memory-to-memory pipeline is a fatal error, don't ignore it. Signed-off-by: Laurent Pinchart --- drivers/media/platform/omap3isp/ispvideo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap3isp/is

[PATCH 0/2] OMAP3 ISP pipeline validation patches

2014-02-14 Thread Laurent Pinchart
Hello, Those two patches fix the OMAP3 ISP pipeline validation when locating the external subdevice. The code currently works by chance with memory-to-memory pipelines, as it tries to locate the external subdevice when none is available, but ignores the failure due to a bug. This patch set fixes

[PATCH 1/2] omap3isp: Don't try to locate external subdev for mem-to-mem pipelines

2014-02-14 Thread Laurent Pinchart
Memory-to-memory pipelines have no external subdev, we shouldn't try to locate one and validate its configuration. The driver currently works by chance due to another bug that results in failure to locate the external subdev being ignored. This gets rid of the "omap3isp omap3isp: can't find source

Re: linux-next: Tree for Feb 14 (media/pci/ttpci/av7110_ir.c)

2014-02-14 Thread Randy Dunlap
On 02/13/2014 09:28 PM, Stephen Rothwell wrote: > Hi all, > > If you see failures in building this tree due to missing declarations of > k..alloc/free, then it may be caused by commit 2bd59d48ebfb ("cgroup: > convert to kernfs"). Please send Tejun Heo a patch > adding an inclusion of linux/slab.

SAA7134 warning during resume from S3: regression 3.8.13 -> 3.9.0

2014-02-14 Thread valerio.va...@inwind.it
This is also on bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69581 [1.] One line summary of the problem: Kernel gives a oops warning during resume from S3 sleep. [2.] Full description of the problem/report: OS is Debian Lenny, with vanilla kernel. It happens the same after upgrade to S

Re: [REVIEW PATCH 13/16] rtl2832_sdr: expose e4000 controls to user

2014-02-14 Thread Hans Verkuil
On 02/11/2014 03:04 AM, Antti Palosaari wrote: > E4000 tuner driver provides now some controls. Expose those to > userland. > > Signed-off-by: Antti Palosaari > --- > drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --g

Re: [REVIEW PATCH 08/16] rtl2832_sdr: Realtek RTL2832 SDR driver module

2014-02-14 Thread Hans Verkuil
On 02/11/2014 03:04 AM, Antti Palosaari wrote: > Implement SDR driver for Realtek RTL2832U chip as a DVB extension > module. SDR module is attached by DVB USB RTL28XXU driver as a DVB > SEC (satellite equipment controller) module. Abusing unused SEC here > has no harm as that is DVB-T only frontend

Re: Instructions to release your payment.

2014-02-14 Thread Dr.William Davies
Attention Sir, Following an application brought, seeking the release of your due payment through British bank, I am directed to inform you that the application has been approved and Natwest bank of London has been mandated to make transfer of your payment to the bank account you will nominate. Pl

Re: [REVIEW PATCH 1/6] v4l: add RF tuner gain controls

2014-02-14 Thread Hans Verkuil
On 02/14/2014 03:44 PM, Antti Palosaari wrote: > On 14.02.2014 16:30, Hans Verkuil wrote: >> On 02/10/2014 05:17 PM, Antti Palosaari wrote: >>> Modern silicon RF tuners used nowadays has many controllable gain >>> stages on signal path. Usually, but not always, there is at least >>> 3 gain stages.

Re: [REVIEW PATCH 0/5] SDR API - Mirics MSi3101 driver

2014-02-14 Thread Hans Verkuil
On 02/14/2014 03:40 PM, Hans Verkuil wrote: > Hi Antti, > > Just one very tiny thing: in patch 1 in msi3101_template you added this line: > > + .debug= 0, > > Please remove. Fields initialized to 0 should in general be dropped since the > compiler sets it to 0 already, an

Re: [REVIEW PATCH 3/6] v4l: reorganize RF tuner control ID numbers

2014-02-14 Thread Hans Verkuil
On 02/14/2014 03:36 PM, Antti Palosaari wrote: > On 14.02.2014 16:20, Hans Verkuil wrote: >> Hi Antti, >> >> On 02/10/2014 05:17 PM, Antti Palosaari wrote: >>> It appears that controls are ordered by ID number. Change order of >>> controls by reorganizing assigned IDs now as we can. It is not >>> r

Re: [REVIEW PATCH 1/6] v4l: add RF tuner gain controls

2014-02-14 Thread Antti Palosaari
On 14.02.2014 16:30, Hans Verkuil wrote: On 02/10/2014 05:17 PM, Antti Palosaari wrote: Modern silicon RF tuners used nowadays has many controllable gain stages on signal path. Usually, but not always, there is at least 3 gain stages. Also on some cases there could be multiple gain stages within

Re: [REVIEW PATCH 0/5] SDR API - Mirics MSi3101 driver

2014-02-14 Thread Hans Verkuil
Hi Antti, Just one very tiny thing: in patch 1 in msi3101_template you added this line: + .debug= 0, Please remove. Fields initialized to 0 should in general be dropped since the compiler sets it to 0 already, and eventually the debug field will disappear anyway since y

Re: [REVIEW PATCH 3/6] v4l: reorganize RF tuner control ID numbers

2014-02-14 Thread Antti Palosaari
On 14.02.2014 16:20, Hans Verkuil wrote: Hi Antti, On 02/10/2014 05:17 PM, Antti Palosaari wrote: It appears that controls are ordered by ID number. Change order of controls by reorganizing assigned IDs now as we can. It is not reasonable possible after the API is released. Leave some spare spa

[PATCH] [media] of: move common endpoint parsing to drivers/media

2014-02-14 Thread Philipp Zabel
This patch adds a new struct of_endpoint which is embedded in struct v4l2_of_endpoint and contains the endpoint properties that are not V4L2 specific: port number, endpoint id, local device tree node. of_graph_parse_endpoint parses those properties and is used by v4l2_of_parse_endpoint, which just

Re: [REVIEW PATCH 2/6] v4l: add RF tuner channel bandwidth control

2014-02-14 Thread Hans Verkuil
On 02/10/2014 05:17 PM, Antti Palosaari wrote: > Modern silicon RF tuners has one or more adjustable filters on > signal path, in order to filter noise from desired radio channel. > > Add channel bandwidth control to tell the driver which is radio > channel width we want receive. Filters could be

Re: [REVIEW PATCH 1/6] v4l: add RF tuner gain controls

2014-02-14 Thread Hans Verkuil
On 02/10/2014 05:17 PM, Antti Palosaari wrote: > Modern silicon RF tuners used nowadays has many controllable gain > stages on signal path. Usually, but not always, there is at least > 3 gain stages. Also on some cases there could be multiple gain > stages within the ones specified here. However, I

Re: [REVIEW PATCH 3/6] v4l: reorganize RF tuner control ID numbers

2014-02-14 Thread Hans Verkuil
Hi Antti, On 02/10/2014 05:17 PM, Antti Palosaari wrote: > It appears that controls are ordered by ID number. Change order of > controls by reorganizing assigned IDs now as we can. It is not > reasonable possible after the API is released. Leave some spare > space between IDs too for future extens

[RFCv4 PATCH 10/11] vivi: correctly cleanup after a start_streaming failure.

2014-02-14 Thread Hans Verkuil
From: Hans Verkuil If start_streaming fails then any queued buffers must be given back to the vb2 core. Signed-off-by: Hans Verkuil --- drivers/media/platform/vivi.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/vivi.c b/drivers/media/

[RFCv4 PATCH 02/11] vb2: change result code of buf_finish to void.

2014-02-14 Thread Hans Verkuil
From: Hans Verkuil The buf_finish op should always work, so change the return type to void. Update the few drivers that use it. Note that buf_finish can be called both when the DMA is streaming and when it isn't (during queue_cancel). Update drivers to check that where appropriate. Signed-off-by

[RFCv4 PATCH 01/11] vb2: add debugging code to check for unbalanced ops.

2014-02-14 Thread Hans Verkuil
From: Hans Verkuil When a vb2_queue is freed check if all the mem_ops and queue ops were balanced. So the number of calls to e.g. buf_finish has to match the number of calls to buf_prepare, etc. This code is only enabled if CONFIG_VIDEO_ADV_DEBUG is set. Signed-off-by: Hans Verkuil Acked-by: P

[RFCv4 PATCH 05/11] vb2: fix buf_init/buf_cleanup call sequences

2014-02-14 Thread Hans Verkuil
From: Hans Verkuil Ensure that these ops are properly balanced. There are two scenarios: 1) for MMAP buf_init is called when the buffers are created and buf_cleanup must be called when the queue is finally freed. This scenario was always working. 2) for USERPTR and DMABUF it is more comp

[RFCv4 PATCH 03/11] vb2: add note that buf_finish can be called with !vb2_is_streaming()

2014-02-14 Thread Hans Verkuil
From: Hans Verkuil Drivers need to be aware that buf_finish can be called when there is no streaming going on, so make a note of that. Also add a bunch of missing periods at the end of sentences. Signed-off-by: Hans Verkuil Acked-by: Pawel Osciak --- include/media/videobuf2-core.h | 44 +

[RFCv4 PATCH 08/11] vb2: q->num_buffers was updated too soon

2014-02-14 Thread Hans Verkuil
From: Hans Verkuil In __reqbufs() and __create_bufs() the q->num_buffers field was updated with the number of newly allocated buffers, but right after that those are freed again if some error had occurred before. Move the line updating num_buffers to *after* that error check. Signed-off-by: Hans

[RFCv4 PATCH 04/11] vb2: call buf_finish from __dqbuf

2014-02-14 Thread Hans Verkuil
From: Hans Verkuil This ensures that it is also called from queue_cancel, which also calls __dqbuf(). Without this change any time queue_cancel is called while streaming the buf_finish op will not be called and any driver cleanup will not happen. Signed-off-by: Hans Verkuil Acked-by: Pawel Osci

[RFCv4 PATCH 00/11] vb2: fixes, balancing callbacks

2014-02-14 Thread Hans Verkuil
This patch series is v4 of the previous series: http://www.spinics.net/lists/linux-media/msg73005.html Changelog: - Fixed a number of typos as pointed out by Pawel Osciak - Added better documentation and renamed the index fields in patch 6 (fix read/write regression) - added patch 8/11 to fix

[RFCv4 PATCH 11/11] v4l2-ioctl: add CREATE_BUFS sanity checks.

2014-02-14 Thread Hans Verkuil
From: Hans Verkuil Many drivers do not check anything. At least make sure that the various buffer size related fields are not obviously wrong. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ioctl.c | 52 ++-- 1 file changed, 50 insertions(+), 2 del

[RFCv4 PATCH 06/11] vb2: fix read/write regression

2014-02-14 Thread Hans Verkuil
From: Hans Verkuil Commit 88e268702bfba78448abd20a31129458707383aa ("vb2: Improve file I/O emulation to handle buffers in any order") broke read/write support if the size of the buffer being read/written is less than the size of the image. When the commit was tested originally I used qv4l2, whic

[RFCv4 PATCH 07/11] vb2: rename queued_count to owned_by_drv_count

2014-02-14 Thread Hans Verkuil
From: Hans Verkuil 'queued_count' is a bit vague since it is not clear to which queue it refers to: the vb2 internal list of buffers or the driver-owned list of buffers. Rename to make it explicit. Signed-off-by: Hans Verkuil Acked-by: Pawel Osciak --- drivers/media/v4l2-core/videobuf2-core.

[RFCv4 PATCH 09/11] vb2: only call start_streaming if sufficient buffers are queued

2014-02-14 Thread Hans Verkuil
From: Hans Verkuil In commit 02f142ecd24aaf891324ffba8527284c1731b561 support was added to start_streaming to return -ENOBUFS if insufficient buffers were queued for the DMA engine to start. The vb2 core would attempt calling start_streaming again if another buffer would be queued up. Later anal

Re: [RFC v3,3/3] media: i2c: add new dual LED Flash driver, lm3646

2014-02-14 Thread Andy Shevchenko
On Fri, 2014-02-14 at 18:46 +0900, Daniel Jeong wrote: > Add new dual flash driver. > Fixed the previous issues and added device tree support. > > Signed-off-by: Daniel Jeong > --- > drivers/media/i2c/Kconfig |9 + > drivers/media/i2c/Makefile |1 + > drivers/media/i2c/lm3646.c | 451

Re: [RFCv3 PATCH 08/10] vb2: only call start_streaming if sufficient buffers are queued

2014-02-14 Thread Hans Verkuil
On 02/14/2014 06:13 AM, Pawel Osciak wrote: > On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> In commit 02f142ecd24aaf891324ffba8527284c1731b561 support was added to >> start_streaming to return -ENOBUFS if insufficient buffers were queued >> for the DMA engine to

Re: [RFCv3 PATCH 05/10] vb2: fix buf_init/buf_cleanup call sequences

2014-02-14 Thread Hans Verkuil
Hi Pawel, Thanks for the review! On 02/14/2014 05:40 AM, Pawel Osciak wrote: > On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Ensure that these ops are properly balanced. >> >> There two scenarios: > > s/There two/There are two/ > >> >> 1) for MMAP buf_init i

Re: [RFCv3 PATCH 06/10] vb2: fix read/write regression

2014-02-14 Thread Hans Verkuil
On 02/14/2014 05:49 AM, Pawel Osciak wrote: > On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Commit 88e268702bfba78448abd20a31129458707383aa ("vb2: Improve file I/O >> emulation to handle buffers in any order") broke read/write support if >> the size of the buffe

[RFC v3,3/3] media: i2c: add new dual LED Flash driver, lm3646

2014-02-14 Thread Daniel Jeong
Add new dual flash driver. Fixed the previous issues and added device tree support. Signed-off-by: Daniel Jeong --- drivers/media/i2c/Kconfig |9 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/lm3646.c | 451 include/media/lm3646.h

[RFC v3,2/3] controls.xml : add addtional Flash fault bits

2014-02-14 Thread Daniel Jeong
Add addtional falult bits for FLASH V4L2_FLASH_FAULT_UNDER_VOLTAGE : UVLO V4L2_FLASH_FAULT_INPUT_VOLTAGE : input voltage is adjusted by IVFM V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE : NTC Trip point is crossed. Signed-off-by: Daniel Jeong --- Documentation/DocBook/media/v4l/controls.xml | 16 ++

[RFC v3,1/3] v4l2-controls.h: add addtional Flash fault bits

2014-02-14 Thread Daniel Jeong
Add addtional falult bits for FLASH V4L2_FLASH_FAULT_UNDER_VOLTAGE : UVLO V4L2_FLASH_FAULT_INPUT_VOLTAGE : input voltage is adjusted by IVFM V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE : NTC Trip point is crossed. Signed-off-by: Daniel Jeong --- include/uapi/linux/v4l2-controls.h |3 +++ 1 file

[PATCH v3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/media

2014-02-14 Thread Philipp Zabel
From: Philipp Zabel This patch moves the parsing helpers used to parse connected graphs in the device tree, like the video interface bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt, from drivers/media/v4l2-core to drivers/media. This allows to reuse the same p