Re: [RFCv3 PATCH 08/10] vb2: only call start_streaming if sufficient buffers are queued

2014-02-13 Thread Pawel Osciak
On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote: > From: Hans Verkuil > > In commit 02f142ecd24aaf891324ffba8527284c1731b561 support was added to > start_streaming to return -ENOBUFS if insufficient buffers were queued > for the DMA engine to start. The vb2 core would attempt calling > start_

Re: [RFCv3 PATCH 06/10] vb2: fix read/write regression

2014-02-13 Thread Pawel Osciak
On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Commit 88e268702bfba78448abd20a31129458707383aa ("vb2: Improve file I/O > emulation to handle buffers in any order") broke read/write support if > the size of the buffer being read/written is less than the size of the >

Re: [RFCv3 PATCH 07/10] vb2: rename queued_count to owned_by_drv_count

2014-02-13 Thread Pawel Osciak
On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote: > From: Hans Verkuil > > 'queued_count' is a bit vague since it is not clear to which queue it > refers to: the vb2 internal list of buffers or the driver-owned list > of buffers. > > Rename to make it explicit. > > Signed-off-by: Hans Verkuil

Re: [RFCv3 PATCH 05/10] vb2: fix buf_init/buf_cleanup call sequences

2014-02-13 Thread Pawel Osciak
On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Ensure that these ops are properly balanced. > > There two scenarios: s/There two/There are two/ > > 1) for MMAP buf_init is called when the buffers are created and buf_cleanup >must be called when the queue is fi

cron job: media_tree daily build: WARNINGS

2014-02-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Feb 14 04:00:23 CET 2014 git branch: test git hash: 37e59f876bc710d67a30b660826a5e83e07101ce gcc versio

Re: [RFCv3 PATCH 04/10] vb2: call buf_finish from __dqbuf

2014-02-13 Thread Pawel Osciak
On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote: > From: Hans Verkuil > > This ensures that it is also called from queue_cancel, which also calls > __dqbuf(). Without this change any time queue_cancel is called while > streaming the buf_finish op will not be called and any driver cleanup > wi

Re: [RFCv3 PATCH 03/10] vb2: add note that buf_finish can be called with !vb2_is_streaming()

2014-02-13 Thread Pawel Osciak
Thanks Hans. Acked-by: Pawel Osciak On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Drivers need to be aware that buf_finish can be called when there is no > streaming going on, so make a note of that. > > Also add a bunch of missing periods at the end of sentence

Re: [RFCv3 PATCH 02/10] vb2: change result code of buf_finish to void.

2014-02-13 Thread Pawel Osciak
Thanks! vb2 parts: Acked-by: Pawel Osciak others: Reviewed-by: Pawel Osciak On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil wrote: > From: Hans Verkuil > > The buf_finish op should always work, so change the return type to void. > Update the few drivers that use it. Note that buf_finish can be

Re: Video capture in FPGA -- simple hardware to emulate?

2014-02-13 Thread Steven Toth
>> > Are you using a USB or PCIe controller to talk to the fpga, or does >> > the fpga contain embedded IP cores for USB or PCIe? > > There should be no USB/PCIe involved. How are you planning to connect the FPGA memory space to your host cpu kernel memory space? Soft CPU directly inside the fpga

Re: Video capture in FPGA -- simple hardware to emulate?

2014-02-13 Thread Pavel Machek
Hi! > > > I'm working on project that will need doing video capture from > > > FPGA. That means I can define interface between kernel and hardware. > > > > > > Is there suitable, simple hardware we should emulate in the FPGA? I > > > took a look, and pxa_camera seems to be one of the simple ones..

[PATCH 1/4] it913x: dead code Remove driver.

2014-02-13 Thread Malcolm Priestley
Following moving ids to af9035. This driver is no longer in use. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/Kconfig | 7 - drivers/media/usb/dvb-usb-v2/Makefile | 3 - drivers/media/usb/dvb-usb-v2/it913x.c | 809 -- 3 files changed, 81

[PATCH 4/4] get_dvb_firmware: it913x: Remove it9137 firmware files

2014-02-13 Thread Malcolm Priestley
Remove it9137 firmware files it9137.txt and it9137 get_dvb_firmware. dvb-usb-it9137-01.fw firmware is no longer in use. Signed-off-by: Malcolm Priestley --- Documentation/dvb/get_dvb_firmware | 22 ++ Documentation/dvb/it9137.txt | 9 - 2 files changed, 2 inse

Re: Video capture in FPGA -- simple hardware to emulate?

2014-02-13 Thread Guennadi Liakhovetski
On Thu, 13 Feb 2014, Steven Toth wrote: > On Thu, Feb 13, 2014 at 2:52 PM, Pavel Machek wrote: > > Hi! > > > > I'm working on project that will need doing video capture from > > FPGA. That means I can define interface between kernel and hardware. > > > > Is there suitable, simple hardware we shou

[PATCH 3/4] MAINTAINERS: Remove it913x* maintainers entries.

2014-02-13 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley --- MAINTAINERS | 16 1 file changed, 16 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b2cf5cf..538b894 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4771,22 +4771,6 @@ F: Documentation/hwmon/it87 F: drivers/hwmon/it87.c

Re: Video capture in FPGA -- simple hardware to emulate?

2014-02-13 Thread Steven Toth
On Thu, Feb 13, 2014 at 2:52 PM, Pavel Machek wrote: > Hi! > > I'm working on project that will need doing video capture from > FPGA. That means I can define interface between kernel and hardware. > > Is there suitable, simple hardware we should emulate in the FPGA? I > took a look, and pxa_camera

Video capture in FPGA -- simple hardware to emulate?

2014-02-13 Thread Pavel Machek
Hi! I'm working on project that will need doing video capture from FPGA. That means I can define interface between kernel and hardware. Is there suitable, simple hardware we should emulate in the FPGA? I took a look, and pxa_camera seems to be one of the simple ones... Thanks,

[PATCH 2/2] af9035: use af9033 PID filters

2014-02-13 Thread Antti Palosaari
PID filters are property of af9033 demod. Use PID filters from af9033 driver as it provides those now. Allow possible dual mode on USB 1.1 mode too as bandwidth could be just enough when filters are used on both frontends. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9035.c

[PATCH 1/2] af9033: implement PID filter

2014-02-13 Thread Antti Palosaari
Implement PID filter and export it via symbol. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9033.c | 53 drivers/media/dvb-frontends/af9033.h | 19 + 2 files changed, 72 insertions(+) diff --git a/drivers/media/dvb-frontends/a

Re: [PATCH] gspca_amscope: AmScope MT1000 camera driver

2014-02-13 Thread Hans de Goede
Hi, On 02/13/2014 01:32 PM, Todd Brandt wrote: > Hello, I'm working on adding a new GSPCA driver for the AmScope MT1000 > series microscope camera and I'm having a bit of trouble. The patch below > is my work-in-progress. I can succesfully get a video stream from the device > at 1280x1024 (the def

Re: [PATCH 43/47] adv7604: Control hot-plug detect through a GPIO

2014-02-13 Thread Laurent Pinchart
Hi Hans, On Thursday 13 February 2014 10:47:44 Hans Verkuil wrote: > On 02/11/14 13:03, Laurent Pinchart wrote: > > On Tuesday 11 February 2014 11:09:31 Hans Verkuil wrote: > >> On 02/05/14 17:42, Laurent Pinchart wrote: > >>> Replace the ADV7604-specific hotplug notifier with a GPIO to control th

[PATCH] gspca_amscope: AmScope MT1000 camera driver

2014-02-13 Thread Todd Brandt
Hello, I'm working on adding a new GSPCA driver for the AmScope MT1000 series microscope camera and I'm having a bit of trouble. The patch below is my work-in-progress. I can succesfully get a video stream from the device at 1280x1024 (the default) and can set the exposure value, but I seem to be h

Re: [PATCH 43/47] adv7604: Control hot-plug detect through a GPIO

2014-02-13 Thread Lars-Peter Clausen
On 02/13/2014 10:47 AM, Hans Verkuil wrote: On 02/11/14 13:03, Laurent Pinchart wrote: Hi Hans, On Tuesday 11 February 2014 11:09:31 Hans Verkuil wrote: On 02/05/14 17:42, Laurent Pinchart wrote: Replace the ADV7604-specific hotplug notifier with a GPIO to control the HPD pin directly instead

Re: [PATCH 43/47] adv7604: Control hot-plug detect through a GPIO

2014-02-13 Thread Hans Verkuil
On 02/11/14 13:03, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 11 February 2014 11:09:31 Hans Verkuil wrote: >> On 02/05/14 17:42, Laurent Pinchart wrote: >>> Replace the ADV7604-specific hotplug notifier with a GPIO to control the >>> HPD pin directly instead of going through the bridge dri

[RFCv3 PATCH 04/10] vb2: call buf_finish from __dqbuf

2014-02-13 Thread Hans Verkuil
From: Hans Verkuil This ensures that it is also called from queue_cancel, which also calls __dqbuf(). Without this change any time queue_cancel is called while streaming the buf_finish op will not be called and any driver cleanup will not happen. Signed-off-by: Hans Verkuil --- drivers/media/v

[RFCv3 PATCH 09/10] vivi: correctly cleanup after a start_streaming failure.

2014-02-13 Thread Hans Verkuil
From: Hans Verkuil If start_streaming fails then any queued buffers must be given back to the vb2 core. Signed-off-by: Hans Verkuil --- drivers/media/platform/vivi.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/vivi.c b/drivers/media/

[RFCv3 PATCH 02/10] vb2: change result code of buf_finish to void.

2014-02-13 Thread Hans Verkuil
From: Hans Verkuil The buf_finish op should always work, so change the return type to void. Update the few drivers that use it. Note that buf_finish can be called both when the DMA is streaming and when it isn't (during queue_cancel). Update drivers to check that where appropriate. Signed-off-by

[RFCv3 PATCH 00/10] vb2: fixes, balancing callbacks

2014-02-13 Thread Hans Verkuil
This patch series is v3 of the previous series: http://www.spinics.net/lists/linux-media/msg72465.html The only difference is that the dropped buf_finish return code check in patch 4 was moved to patch 2, otherwise the compile would break after applying patch 2. Thanks to Pawel Osciak for pointin

[RFCv3 PATCH 07/10] vb2: rename queued_count to owned_by_drv_count

2014-02-13 Thread Hans Verkuil
From: Hans Verkuil 'queued_count' is a bit vague since it is not clear to which queue it refers to: the vb2 internal list of buffers or the driver-owned list of buffers. Rename to make it explicit. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 10 +- inclu

[RFCv3 PATCH 06/10] vb2: fix read/write regression

2014-02-13 Thread Hans Verkuil
From: Hans Verkuil Commit 88e268702bfba78448abd20a31129458707383aa ("vb2: Improve file I/O emulation to handle buffers in any order") broke read/write support if the size of the buffer being read/written is less than the size of the image. When the commit was tested originally I used qv4l2, whic

[RFCv3 PATCH 05/10] vb2: fix buf_init/buf_cleanup call sequences

2014-02-13 Thread Hans Verkuil
From: Hans Verkuil Ensure that these ops are properly balanced. There two scenarios: 1) for MMAP buf_init is called when the buffers are created and buf_cleanup must be called when the queue is finally freed. This scenario was always working. 2) for USERPTR and DMABUF it is more complica

[RFCv3 PATCH 08/10] vb2: only call start_streaming if sufficient buffers are queued

2014-02-13 Thread Hans Verkuil
From: Hans Verkuil In commit 02f142ecd24aaf891324ffba8527284c1731b561 support was added to start_streaming to return -ENOBUFS if insufficient buffers were queued for the DMA engine to start. The vb2 core would attempt calling start_streaming again if another buffer would be queued up. Later anal

[RFCv3 PATCH 03/10] vb2: add note that buf_finish can be called with !vb2_is_streaming()

2014-02-13 Thread Hans Verkuil
From: Hans Verkuil Drivers need to be aware that buf_finish can be called when there is no streaming going on, so make a note of that. Also add a bunch of missing periods at the end of sentences. Signed-off-by: Hans Verkuil --- include/media/videobuf2-core.h | 44 ++---

[RFCv3 PATCH 01/10] vb2: add debugging code to check for unbalanced ops.

2014-02-13 Thread Hans Verkuil
From: Hans Verkuil When a vb2_queue is freed check if all the mem_ops and queue ops were balanced. So the number of calls to e.g. buf_finish has to match the number of calls to buf_prepare, etc. This code is only enabled if CONFIG_VIDEO_ADV_DEBUG is set. Signed-off-by: Hans Verkuil Acked-by: P

[RFCv3 PATCH 10/10] v4l2-ioctl: add CREATE_BUFS sanity checks.

2014-02-13 Thread Hans Verkuil
From: Hans Verkuil Many drivers do not check anything. At least make sure that the various buffer size related fields are not obviously wrong. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ioctl.c | 52 ++-- 1 file changed, 50 insertions(+), 2 del

Re: [RFCv2 PATCH 01/10] vb2: add debugging code to check for unbalanced ops.

2014-02-13 Thread Hans Verkuil
On 02/13/14 09:01, Pawel Osciak wrote: > Hi Hans, > Thanks for the patch. I'm really happy to see this, it's a great idea > and it will be very useful. > > Two comments: > - What do you think about moving the debug stuff to something like > videobuf2-debug.{c,h} instead? It's not quite worth it a

Re: [RFCv2 PATCH 01/10] vb2: add debugging code to check for unbalanced ops.

2014-02-13 Thread Pawel Osciak
Hi Hans, Thanks for the patch. I'm really happy to see this, it's a great idea and it will be very useful. Two comments: - What do you think about moving the debug stuff to something like videobuf2-debug.{c,h} instead? - At this point vb2_buffer_done() shouldn't be required to be balanced with buf

Contact me for more details.

2014-02-13 Thread MARTIN DESMOND
Hi friend. I want to transfer an abandoned USD5.5Million to your Bank account. 40/percent will be your share. Contact me for more details. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://