cron job: media_tree daily build: WARNINGS

2013-11-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Nov 20 04:00:25 CET 2013 git branch: test git hash: 80f93c7b0f4599ffbdac8d964ecd1162b8b618b9 gcc versio

Re: [PATCH] [v4l-utils] Fix configure.ac --disable-v4l-utils option

2013-11-19 Thread Gregor Jasny
On 19/11/13 14:28, Alain VOLMAT wrote: When using AC_ARG_ENABLE with a string containing - in it, the variable created will contains a _ instead of the -. Thus for AC_ARG_ENABLE(v4l-utils ..., the variable enable_v4l_utils must be checked. Applied, Thanks! -- To unsubscribe from this list:

Re: [PATCH 14/16] s5p-jpeg: Synchronize V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value

2013-11-19 Thread Hans Verkuil
On 11/19/2013 03:27 PM, Jacek Anaszewski wrote: > When output queue fourcc is set to any flavour of YUV, > the V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value as > well as its in-driver cached counterpart have to be > updated with the subsampling property of the format > so as to be able to provide

Re: [PATCH 15/16] s5p-jpeg: Ensure setting correct value of the chroma subsampling control

2013-11-19 Thread Hans Verkuil
On 11/19/2013 03:27 PM, Jacek Anaszewski wrote: > Exynos4x12 has limitations regarding setting chroma subsampling > of an output JPEG image. It cannot be lower than the subsampling > of the raw source image. Also in case of V4L2_JPEG_CHROMA_SUBSAMPLING_GRAY > option the source image fourcc has to b

[PATCH 05/16] s5p-jpeg: Rename functions specific to the S5PC210 SoC accordingly

2013-11-19 Thread Jacek Anaszewski
Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 58 --- 1 file changed, 34 insertions(+), 24 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-cor

[PATCH 04/16] s5p-jpeg: Remove superfluous call to the jpeg_bound_align_image function

2013-11-19 Thread Jacek Anaszewski
Aligning capture queue image dimensions while enqueuing output queue doesn't make a sense as the S_FMT ioctl might have not been called for the capture queue until that moment, whereas it is required to know capture format as the type of alignment heavily depends on it. Signed-off-by: Jacek Anasze

[PATCH 15/16] s5p-jpeg: Ensure setting correct value of the chroma subsampling control

2013-11-19 Thread Jacek Anaszewski
Exynos4x12 has limitations regarding setting chroma subsampling of an output JPEG image. It cannot be lower than the subsampling of the raw source image. Also in case of V4L2_JPEG_CHROMA_SUBSAMPLING_GRAY option the source image fourcc has to be V4L2_PIX_FMT_GREY. This patch adds mechanism that prev

[PATCH 10/16] s5p-jpeg: Add hardware API for the exynos4x12 JPEG codec.

2013-11-19 Thread Jacek Anaszewski
Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/Makefile |2 +- drivers/media/platform/s5p-jpeg/jpeg-core.c | 620 +++--- drivers/media/platform/s5p-jpeg/jpeg-core.h | 72 ++- drivers/media/platform/s5p-jpe

[PATCH 11/16] s5p-jpeg: Retrieve "YCbCr subsampling" field from the jpeg header

2013-11-19 Thread Jacek Anaszewski
Make s5p_jpeg_parse_hdr function capable of parsing "YCbCr subsampling" field of a jpeg file header. Store the parsed value in the context. The information about source JPEG subsampling is required to make validation of destination format possible, which must be conducted for exynos4x12 device as t

[PATCH 16/16] s5p-jpeg: Adjust g_volatile_ctrl callback to Exynos4x12 needs

2013-11-19 Thread Jacek Anaszewski
Whereas S5PC210 device produces decoded JPEG subsampling values that map on V4L2_JPEG_CHROMA_SUBSAMPLNG values, the Exynos4x12 device doesn't. This patch adds helper function decoded_subsampling_to_v4l2, which performs HW -> V4L2 translation. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmi

[PATCH 08/16] s5p-jpeg: Synchronize cached controls with V4L2 core

2013-11-19 Thread Jacek Anaszewski
This patch adds proper initialization of the in-driver cached state of JPEG controls with V4L2 core. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/s5p-

[PATCH 12/16] s5p-jpeg: Ensure correct capture format for Exynos4x12

2013-11-19 Thread Jacek Anaszewski
Adjust capture format to the Exynos4x12 device limitations, according to the subsampling value parsed from the source JPEG image header. If the capture format was set to YUV with subsampling lower than the one of the source JPEG image the decoding process would not succeed. Signed-off-by: Jacek An

[PATCH 13/16] s5p-jpeg: Allow for wider JPEG subsampling scope for Exynos4x12 encoder

2013-11-19 Thread Jacek Anaszewski
Exynos4x12 supports wider scope of subsampling modes than S5PC210. Adjust corresponding mask accordingly. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 07/16] s5p-jpeg: Fix lack of spin_lock protection

2013-11-19 Thread Jacek Anaszewski
s5p_jpeg_device_run and s5p_jpeg_runtime_resume callbacks should have spin_lock protection as they alter device registers. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletio

[PATCH 06/16] s5p-jpeg: Fix clock resource management

2013-11-19 Thread Jacek Anaszewski
Standard suspend/resume path is called after runtime resume of the given device, so suspend/resume callbacks must do all clock management done also by runtime pm to allow for proper power domain shutdown. Moreover, JPEG clock is enabled from probe function but is is not necessary. This patch also m

[PATCH 14/16] s5p-jpeg: Synchronize V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value

2013-11-19 Thread Jacek Anaszewski
When output queue fourcc is set to any flavour of YUV, the V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value as well as its in-driver cached counterpart have to be updated with the subsampling property of the format so as to be able to provide correct information to the user space and preclude setting

[PATCH 09/16] s5p-jpeg: Split jpeg-hw.h to jpeg-hw-s5p.c and jpeg-hw-s5p.c

2013-11-19 Thread Jacek Anaszewski
Move function definitions from jpeg-hw.h to jpeg-hw-s5p.c and put function declarations in the jpeg-hw-s5p.h. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/Makefile |2 +- drivers/media/platform/s5p-jpeg/jpeg-core.c|2

[PATCH 03/16] s5p-jpeg: Fix erroneous condition while validating bytesperline value

2013-11-19 Thread Jacek Anaszewski
The aim of the condition is ensuring that the bytesperline value set by the user space application is proper for the given format and adjusting it if isn't. As the depth value of the format description entry is expressed in bits then the bytesperline value needs to be divided, not multiplied, by th

[PATCH 02/16] s5p-jpeg: Fix output YUV 4:2:0 fourcc for decoder

2013-11-19 Thread Jacek Anaszewski
Output samples during decoding phase for the YUV 4:2:0 format are arranged in the manner compatible with 2-planar NV12, not 3-planar YUV420 fourcc. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |2 +- 1 file changed, 1 insertion

[PATCH 01/16] s5p-jpeg: Reorder quantization tables

2013-11-19 Thread Jacek Anaszewski
Reorder quantization tables so that their elements are arranged in the manner reflecting compression quality level that is in accordance with V4L2 documentation, i.e. the larger value of the V4L2_CID_JPEG_COMPRESSION_QUALITY control the better image quality, and thus lower compression quality. The

[PATCH 00/16] Add support for Exynox4x12 to the s5p-jpeg driver

2013-11-19 Thread Jacek Anaszewski
The main aim of this series is to add support for Exynos4x12 SoC for the s5p-jpeg driver. Nonetheless, a room for couple of fixes and improvements has been found during development, which is reflected in the corresponding patches. Thanks, Jacek Anaszewski Jacek Anaszewski (16): s5p-jpeg: Reorde

[PATCH] media: cx24117: use a valid dev pointer for dev_err printout

2013-11-19 Thread Andi Shyti
Don't use '&state->priv->i2c->dev' reference to device because state is still 'NULL'. Use '&i2c->dev' instead. This bug has been reported by scan.coverity.com Signed-off-by: Andi Shyti --- Hi, please apply this patch after my previous patch, forgot to format them together. Thanks, Andi ---

[PATCH] media: cx24117: remove dead code in always 'false' if statement

2013-11-19 Thread Andi Shyti
At this point of the execution in the function cx24117_attach() demod cannot be '0'. In that case the function returns earlier with an error value ('NULL'). Remove the if statement. This error has been reported by scan.coverity.com Signed-off-by: Andi Shyti --- drivers/media/dvb-frontends/cx241

[PATCH] [v4l-utils] Fix configure.ac --disable-v4l-utils option

2013-11-19 Thread Alain VOLMAT
When using AC_ARG_ENABLE with a string containing - in it, the variable created will contains a _ instead of the -. Thus for AC_ARG_ENABLE(v4l-utils ..., the variable enable_v4l_utils must be checked. Signed-off-by: Alain Volmat --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-19 Thread Hans Verkuil
Hi Valentine, I don't entirely understand how you use this driver with soc-camera. Since soc-camera doesn't support FMT_CHANGE notifies it can't really act on it. Did you hack soc-camera to do this? The way it stands I would prefer to see a version of the driver without soc-camera support. I woul

Re: RFC: Properties, Configuration Storage, Selections and Matrices

2013-11-19 Thread Hans Verkuil
Just a quick update: I've been working on this for the past four days and I am now in the process of testing this. Adding matrix support to the control framework was actually the hardest part, particularly since I wanted it to be efficient. The code is still a bit too complex for my liking, but on