cron job: media_tree daily build: WARNINGS

2013-11-08 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Nov 9 04:00:19 CET 2013 git branch: for-v3.13c git hash: 3adeac2c34cc28e05d0ec52f38f009dcce278555 gcc

Re: [PATCH 3/8] Montage M88DS3103 DVB-S/S2 demodulator driver

2013-11-08 Thread Manu Abraham
On Sat, Nov 9, 2013 at 8:18 AM, Antti Palosaari wrote: > On 09.11.2013 04:35, Manu Abraham wrote: >> >> On Wed, Nov 6, 2013 at 11:27 PM, Antti Palosaari wrote: > > > >>> +/* >>> + * Driver implements own I2C-adapter for tuner I2C access. That's since >>> chip >>> + * has I2C-gate control which cl

Re: [PATCH 3/8] Montage M88DS3103 DVB-S/S2 demodulator driver

2013-11-08 Thread Antti Palosaari
On 09.11.2013 04:35, Manu Abraham wrote: On Wed, Nov 6, 2013 at 11:27 PM, Antti Palosaari wrote: +/* + * Driver implements own I2C-adapter for tuner I2C access. That's since chip + * has I2C-gate control which closes gate automatically after I2C transfer. + * Using own I2C adapter we can wor

Re: [PATCH 3/8] Montage M88DS3103 DVB-S/S2 demodulator driver

2013-11-08 Thread Manu Abraham
On Wed, Nov 6, 2013 at 11:27 PM, Antti Palosaari wrote: > --- > drivers/media/dvb-frontends/Kconfig |7 + > drivers/media/dvb-frontends/Makefile |1 + > drivers/media/dvb-frontends/m88ds3103.c | 1293 > ++ > drivers/media/dvb-frontends/m88ds3

[PATCH -next] [media] media: i2c: lm3560: use correct clientdata in lm3560_remove()

2013-11-08 Thread Wei Yongjun
From: Wei Yongjun We had set the i2c clientdata to &flash->subdev_led[LM3560_LED1] after call lm3560_subdev_init(flash, LM3560_LED1, "lm3560-led1"), but the container_of() in lm3560_remove() return the wrong pointer to flash.(should be container_of(subdev, struct lm3560_flash, subdev_led[LM3560_L

Re: [patch] [media] exynos4-is: cleanup a define

2013-11-08 Thread Sylwester Nawrocki
(dropping some unrelated e-mail addresses from Cc) On 11/08/2013 10:52 AM, Dan Carpenter wrote: This define is only used in s5pcsis_irq_handler(): if ((status& S5PCSIS_INTSRC_NON_IMAGE_DATA)&& pktbuf->data) { The problem is that "status" is a 32 bit and (0xff<< 28) is larger than 3

[PATCH] media: i2c: Add camera driver for ov9655 chips.

2013-11-08 Thread Marek Belisko
This is a driver for the Omnivision OV9655 camera module connected to the OMAP3 parallel camera interface and using the ISP (Image Signal Processor). It supports SXGA and VGA plus some other modes. It was tested on gta04 board. Signed-off-by: Marek Belisko Signed-off-by: H. Nikolaus Schaller --

Deadlock between M88DS3103 and M88TS2022 drivers from I2C parentage

2013-11-08 Thread David Howells
Hi Antti, This patch: http://git.linuxtv.org/anttip/media_tree.git/commit/a0e4024e85ec053699bb4878ccc0800333f84a42 That sets the parentage relationship between the M88DS3103 and M88TS2022 drivers that you have here: http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/h

Re: [PATCH v5] videodev2: Set vb2_rect's width and height as unsigned

2013-11-08 Thread Ricardo Ribalda Delgado
Hello Sakari On Fri, Nov 8, 2013 at 11:39 AM, Sakari Ailus wrote: > On Fri, Nov 08, 2013 at 11:12:54AM +0100, Ricardo Ribalda Delgado wrote: > ... >> Also I am not aware of a reason why clamp_t is better than clamp (I am >> probably wrong here). If there is a good reason for not using >> clam

Re: [PATCH v5] videodev2: Set vb2_rect's width and height as unsigned

2013-11-08 Thread Sakari Ailus
On Fri, Nov 08, 2013 at 11:12:54AM +0100, Ricardo Ribalda Delgado wrote: ... > Also I am not aware of a reason why clamp_t is better than clamp (I am > probably wrong here). If there is a good reason for not using > clamp_t I have no problem in reviewing again the patch and use > unsigned const

Re: [patch] [media] v4l: ti-vpe: checking for IS_ERR() instead of NULL

2013-11-08 Thread Archit Taneja
Hi Dan, On Friday 08 November 2013 03:31 PM, Dan Carpenter wrote: devm_ioremap() returns NULL on error, it doesn't return an ERR_PTR. Signed-off-by: Dan Carpenter diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 4e58069..e163466 100644 --- a/driver

Re: [PATCH v5] videodev2: Set vb2_rect's width and height as unsigned

2013-11-08 Thread Ricardo Ribalda Delgado
Hello Laurent Thanks for your comments On Fri, Nov 8, 2013 at 3:42 AM, Laurent Pinchart wrote: > Hi Ricardo, > > Thank you for the patch. > > On Wednesday 06 November 2013 19:42:16 Ricardo Ribalda Delgado wrote: >> As discussed on the media summit 2013, there is no reason for the width >> and he

[PATCH] vb2: Return 0 when streamon and streamoff are already on/off

2013-11-08 Thread Ricardo Ribalda Delgado
According to the doc: If VIDIOC_STREAMON is called when streaming is already in progress, or if VIDIOC_STREAMOFF is called when streaming is already stopped, then the ioctl does nothing and 0 is returned. The current implementation was returning -EINVAL instead. Signed-off-by: Ricardo Ribalda De

[patch] [media] v4l: ti-vpe: checking for IS_ERR() instead of NULL

2013-11-08 Thread Dan Carpenter
devm_ioremap() returns NULL on error, it doesn't return an ERR_PTR. Signed-off-by: Dan Carpenter diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 4e58069..e163466 100644 --- a/drivers/media/platform/ti-vpe/vpe.c +++ b/drivers/media/platform/ti-vpe/vpe

[patch] [media] exynos4-is: cleanup a define

2013-11-08 Thread Dan Carpenter
This define is only used in s5pcsis_irq_handler(): if ((status & S5PCSIS_INTSRC_NON_IMAGE_DATA) && pktbuf->data) { The problem is that "status" is a 32 bit and (0xff << 28) is larger than 32 bits and that sets off a static checker warning. I consulted with Sylwester Nawrocki and the defi