Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Kishon Vijay Abraham I
Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: > On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Friday 19 July 2013 11:13 AM, Greg KH wrote: >>> On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: + ret = dev_set_name(

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 19 July 2013 11:13 AM, Greg KH wrote: > > On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: > >> + ret = dev_set_name(&phy->dev, "%s.%d", dev_name(dev), id); > > > > Y

[PATCH RFC v4 0/1] [media] blackfin: add video display device driver

2013-07-18 Thread Scott Jiang
v4l2-compliance output for this driver root:/> v4l2-compliance -d 0 Driver Info:bfin_display bfin_display.0: = START STATUS = Driver name : bfin_display Card type : BF609 Bus info : platform:bfin_display Driver version:

[PATCH RFC v4 1/1] [media] blackfin: add video display device driver

2013-07-18 Thread Scott Jiang
This is a V4L2 driver for Blackfin video display (E)PPI interface. This module is common for BF537/BF561/BF548/BF609. Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/Kconfig| 15 +- drivers/media/platform/blackfin/Makefile |1 + drivers/media/platform/blackfin/

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Kishon Vijay Abraham I
Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: > On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: >> +ret = dev_set_name(&phy->dev, "%s.%d", dev_name(dev), id); > > Your naming is odd, no "phy" anywhere in it? You rely on the sender to > never s

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: > +ret = dev_set_name(&phy->dev, "%s.%d", dev_name(dev), id); > >>> > >>> Your naming is odd, no "phy" anywhere in it? You rely on the sender to > >>> never send a duplicate name.id pair? Why not create your own

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Kishon Vijay Abraham I
Hi, On Thursday 18 July 2013 09:19 PM, Greg KH wrote: > On Thu, Jul 18, 2013 at 02:29:52PM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Thursday 18 July 2013 12:50 PM, Greg KH wrote: >>> On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: +struct phy_provider *__of

Re: mb86a20s and cx23885

2013-07-18 Thread Alfredo Jesús Delaiti
Hi all El 17/07/13 16:23, Mauro Carvalho Chehab escribió: No. You'll need to clone the entire kernel tree (either Linus one or mine). The build system at the Kernel will rebuild an entire Kernel image. You'll then need to boot that new image. That takes some machine time, but, after the first

Re: [PATCH] cx23885[v2]: Fix IR interrupt storm.

2013-07-18 Thread nibble.max
Hello Luis, The internel interrupts are rounted as follow: flatiron(include ADC)--->HammerHead(include IR inside)--->Pecos(PCIe) The flatiron interrupt is enabled when chip power up. When HammerHead interrupt is enalbe in Pecos, the most of interrupts are coming from flatiron. The more accurate co

[PATCH] cx23885[v2]: Fix IR interrupt storm.

2013-07-18 Thread Luis Alves
Hi all, This path is meant to be up-streamed. Andy has a nice explanation for the interrupt storm when enabling the IR interrupt: The flatiron core (the audio adc) signals the end of its self-test with an interrupt. Since the flatiron irq seems OR-wired with the IR irq the result is this interrup

Re: Possible problem with stk1160 driver

2013-07-18 Thread Sergey 'Jin' Bostandzhyan
Hi Ezequiel, On Thu, Jul 18, 2013 at 09:55:59AM -0300, Ezequiel Garcia wrote: > > You generally can't switch standards while streaming. That said, it is OK > > to accept the same standard, i.e. return 0 if the standard is unchanged and > > EBUSY otherwise. > > > > Ok, I'll add a check for unchan

cron job: media_tree daily build: WARNINGS

2013-07-18 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jul 18 19:00:20 CEST 2013 git branch: test git hash: 1c26190a8d492adadac4711fe5762d46204b18b0 gcc versi

Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.

2013-07-18 Thread Frank Schäfer
Am 18.07.2013 17:51, schrieb Antti Palosaari: > On 07/18/2013 06:13 PM, Frank Schäfer wrote: >> Am 17.07.2013 00:57, schrieb Alban Browaeys: >>> Set the config structure pointer to the eeprom data pointer (data, >>> here eedata dereferenced) not the pointer to the pointer to >>> the eeprom data (ee

RE: [PATCH 1/1] [media] s5p-g2d: Fix registration failure

2013-07-18 Thread Kamil Debski
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Monday, July 15, 2013 8:36 AM > > Commit 1c1d86a1ea ("[media] v4l2: always require v4l2_dev, rename > parent to dev_parent") expects v4l2_dev to be always set. > It converted most of the drivers using the parent field of video_device >

[PATCH v4] media: i2c: tvp7002: add OF support

2013-07-18 Thread Lad, Prabhakar
From: "Lad, Prabhakar" add OF support for the tvp7002 driver. Signed-off-by: Lad, Prabhakar --- This patch depends on https://patchwork.kernel.org/patch/2828800/ Changes for v4: 1: Improved descrition of end point properties. Changes for v3: 1: Fixed review comments pointed by Sylwester

Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.

2013-07-18 Thread Antti Palosaari
On 07/18/2013 06:13 PM, Frank Schäfer wrote: Am 17.07.2013 00:57, schrieb Alban Browaeys: Set the config structure pointer to the eeprom data pointer (data, here eedata dereferenced) not the pointer to the pointer to the eeprom data (eedata itself). Signed-off-by: Alban Browaeys --- drivers/

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 02:29:52PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 18 July 2013 12:50 PM, Greg KH wrote: > > On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: > >> +struct phy_provider *__of_phy_provider_register(struct device *dev, > >> + struct m

Re: [PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*

2013-07-18 Thread Prabhakar Lad
Hi Joe, On Thu, Jul 18, 2013 at 9:10 PM, Joe Perches wrote: > On Thu, 2013-07-18 at 20:59 +0530, Prabhakar Lad wrote: >> Use the dev_* message logging API instead of raw printk. > [] >> diff --git a/drivers/media/platform/davinci/vpbe.c >> b/drivers/media/platform/davinci/vpbe.c > [] >> @@ -595,

Re: [PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*

2013-07-18 Thread Joe Perches
On Thu, 2013-07-18 at 20:59 +0530, Prabhakar Lad wrote: > Use the dev_* message logging API instead of raw printk. [] > diff --git a/drivers/media/platform/davinci/vpbe.c > b/drivers/media/platform/davinci/vpbe.c [] > @@ -595,7 +595,7 @@ static int vpbe_initialize(struct device *dev, struct > vpb

[PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*

2013-07-18 Thread Prabhakar Lad
From: "Lad, Prabhakar" Use the dev_* message logging API instead of raw printk. Signed-off-by: Lad, Prabhakar --- Posting independent patch of the series, http://www.spinics.net/lists/linux-media/msg65701.html Changes for v2: 1: Fixed logging levels. drivers/media/platform/davinci/vpbe

Re: [PATCH 3/4] [media] em28xx: usb power config is in the low byte.

2013-07-18 Thread Frank Schäfer
Am 17.07.2013 01:06, schrieb Alban Browaeys: > According to the em2860 datasheet, eeprom byte 08H is Chip > Configuration Low Byte and 09H is High Byte. > Usb power configuration is in the Low byte (same as the usb audio > class config). > > Signed-off-by: Alban Browaeys > --- > drivers/media/us

Re: [PATCH 2/4] [media] em28xx: i2s 5 sample rates is a subset of 3 one.

2013-07-18 Thread Frank Schäfer
Am 17.07.2013 01:05, schrieb Alban Browaeys: > As: > EM28XX_CHIPCFG_I2S_3_SAMPRATES 0x20 > EM28XX_CHIPCFG_I2S_5_SAMPRATES 0x30 > > the board chipcfg is 0xf0 thus if 3_SAMPRATES is tested > first and matches while it is a 5_SAMPRATES. > > Signed-off-by: Alban Browaeys > --- > drivers/media/usb/em2

Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.

2013-07-18 Thread Frank Schäfer
Am 17.07.2013 00:57, schrieb Alban Browaeys: > Set the config structure pointer to the eeprom data pointer (data, > here eedata dereferenced) not the pointer to the pointer to > the eeprom data (eedata itself). > > Signed-off-by: Alban Browaeys > --- > drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-

Re: [PATCH] videobuf2-dma-sg: Minimize the number of dma segments

2013-07-18 Thread Marek Szyprowski
Hello, On 7/18/2013 9:39 AM, Ricardo Ribalda Delgado wrote: Hello again: I have started to implemt it, but I think there is more hidden work in this task as it seems. In order to call dma_map_sg and max_dma_segment_size I need acess to the struct device, but (correct me if I am wrong), vb2 is d

[PATCH] media: stk1160: Ignore unchanged standard set

2013-07-18 Thread Ezequiel Garcia
This commit adds an early check to vidioc_s_std() to detect if the new and current standards are equal, and exit with success in that case. This is needed to prevent userspace applications that might attempt to re-set the same standard from failing if that's done when streaming has started. Signe

Re: Possible problem with stk1160 driver

2013-07-18 Thread Ezequiel Garcia
Hi Hans, Thanks for jumping in. On Thu, Jul 18, 2013 at 08:31:13AM +0200, Hans Verkuil wrote: > On 07/18/2013 02:17 AM, Ezequiel Garcia wrote: > > > > Ah... forgot to mention about that. I haven't included the fix for standard > > setting, because either the stk1160 chip or the userspace applica

Re: [PATCH] cx23885: Fix interrupt storm that happens in some cards when IR is enabled.

2013-07-18 Thread Luis Alves
Hi Konstantin, It was not my intention to send this piece of code as a patch to be upstreamed. My apologies for that misunderstanding. My intention was just to send something for people to try and see if it solves the interrupt spam in their cards. I should have sent it just as a normal email to t

Re: [PATCH] cx23885: Fix interrupt storm that happens in some cards when IR is enabled.

2013-07-18 Thread Konstantin Dimitrov
On Thu, Jul 18, 2013 at 4:33 AM, Luis Alves wrote: > Signed-off-by: Luis Alves > --- > drivers/media/pci/cx23885/cx23885-cards.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/media/pci/cx23885/cx23885-cards.c > b/drivers/media/pci/cx23885/cx23885-ca

Re: [PATCH] cx23885: Fix interrupt storm that happens in some cards when IR is enabled.

2013-07-18 Thread Andy Walls
On Wed, 2013-07-17 at 22:41 -0400, Devin Heitmueller wrote: > On Wed, Jul 17, 2013 at 10:15 PM, Antti Palosaari wrote: > > hmm, I looked again the cx23885 driver. > > > > 0x4c == [0x98 >> 1] = "flatiron" == some internal block of the chip > > Yeah, ok. Pretty sure Flatiron is the codename for th

Re: [PATCH v2 1/5] media: Fix circular graph traversal

2013-07-18 Thread Sakari Ailus
Hi Laurent, On Thu, Jul 18, 2013 at 01:06:40AM +0200, Laurent Pinchart wrote: > On Wednesday 17 July 2013 22:47:03 Sakari Ailus wrote: > > On Wed, Jul 17, 2013 at 04:54:38PM +0200, Laurent Pinchart wrote: > > > The graph traversal API (media_entity_graph_walk_*) will fail to > > > correctly walk t

Re: [PATCH] cx23885: Fix interrupt storm that happens in some cards when IR is enabled.

2013-07-18 Thread Luis Alves
Sorry if I wasn't clear, but this patch is not intended to be merged in the main tree (as it is). I've sent it so that people facing this interrupt storm when IR is enabled can test it in their cards (I only have the TBS6981 to test and it works). Probably I should have just sent a mail with a code

Re: [PATCH v3] ov10635: Add OmniVision ov10635 SoC camera driver

2013-07-18 Thread phil . edworthy
Hi Guennadi, > > There is one issue with setting the camera to achieve different framerate. > > The camera can work at up to 60fps with lower resolutions, i.e. when > > vertical sub-sampling is used. However, the API uses separate functions > > for changing resolution and framerate. So, users

Re: [PATCH v3] ov10635: Add OmniVision ov10635 SoC camera driver

2013-07-18 Thread Guennadi Liakhovetski
Hi Phil On Thu, 18 Jul 2013, phil.edwor...@renesas.com wrote: > Hi Guennadi, > > > > +{ > > > + struct i2c_client *client = v4l2_get_subdevdata(sd); > > > + struct ov10635_priv *priv = to_ov10635(client); > > > + struct v4l2_captureparm *cp = &parms->parm.capture; > > > + enum v4l2_mbus_

Re: [PATCH v3] ov10635: Add OmniVision ov10635 SoC camera driver

2013-07-18 Thread phil . edworthy
Hi Guennadi, > > +{ > > + struct i2c_client *client = v4l2_get_subdevdata(sd); > > + struct ov10635_priv *priv = to_ov10635(client); > > + struct v4l2_captureparm *cp = &parms->parm.capture; > > + enum v4l2_mbus_pixelcode code; > > + int ret; > > + > > + if (parms->type != V4L2_BUF_TYP

Re: [PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework

2013-07-18 Thread Kishon Vijay Abraham I
On Thursday 18 July 2013 12:51 PM, Greg KH wrote: > On Thu, Jul 18, 2013 at 12:16:11PM +0530, Kishon Vijay Abraham I wrote: >> Used the generic PHY framework API to create the PHY. Now the power off and >> power on are done in omap_usb_power_off and omap_usb_power_on respectively. >> >> However usi

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Kishon Vijay Abraham I
Hi, On Thursday 18 July 2013 12:50 PM, Greg KH wrote: > On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: >> +struct phy_provider *__of_phy_provider_register(struct device *dev, >> +struct module *owner, struct phy * (*of_xlate)(struct device *dev, >> +struct of_phand

Re: [RFC PATCH 0/5] Matrix and Motion Detection support

2013-07-18 Thread Hans Verkuil
Hi Laurent, Thanks for your reviews! On Thu 18 July 2013 02:12:49 Laurent Pinchart wrote: > Hello, > > On Sunday 07 July 2013 23:50:30 Sylwester Nawrocki wrote: > > On 06/28/2013 02:27 PM, Hans Verkuil wrote: > > > This patch series adds support for matrices and motion detection and > > > conver

Re: [RFC PATCH 2/5] v4l2-compat-ioctl32: add g/s_matrix support.

2013-07-18 Thread Hans Verkuil
On Thu 18 July 2013 02:22:05 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 28 June 2013 14:27:31 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > --- > > drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 55

Re: [RFC PATCH 4/5] v4l2: add a motion detection event.

2013-07-18 Thread Hans Verkuil
On Thu 18 July 2013 02:14:28 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 28 June 2013 14:27:33 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > --- > > include/uapi/linux/videodev2.h | 17 + > > 1 file changed, 1

Re: [PATCH 4/4] [media] em28xx: Fix vidioc fmt vid cap v4l2 compliance

2013-07-18 Thread Hans Verkuil
On Thu 18 July 2013 04:07:51 Devin Heitmueller wrote: > On Tue, Jul 16, 2013 at 7:06 PM, Alban Browaeys > wrote: > > Set fmt.pix.priv to zero in vidioc_g_fmt_vid_cap > > and vidioc_try_fmt_vid_cap. > > Any reason not to have the v4l2 core do this before dispatching to the > driver? Set it to ze

Re: [PATCH] videobuf2-dma-sg: Minimize the number of dma segments

2013-07-18 Thread Ricardo Ribalda Delgado
Hello again: I have started to implemt it, but I think there is more hidden work in this task as it seems. In order to call dma_map_sg and max_dma_segment_size I need acess to the struct device, but (correct me if I am wrong), vb2 is device agnostic. Adding the above functionality will mean not on

Re: [PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 12:16:11PM +0530, Kishon Vijay Abraham I wrote: > Used the generic PHY framework API to create the PHY. Now the power off and > power on are done in omap_usb_power_off and omap_usb_power_on respectively. > > However using the old USB PHY library cannot be completely removed

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: > +struct phy_provider *__of_phy_provider_register(struct device *dev, > + struct module *owner, struct phy * (*of_xlate)(struct device *dev, > + struct of_phandle_args *args)); > +struct phy_provider *__devm_of_phy_pro

Re: [PATCH] videobuf2-dma-sg: Minimize the number of dma segments

2013-07-18 Thread Marek Szyprowski
Hello, On 7/17/2013 4:20 PM, Ricardo Ribalda Delgado wrote: Hello again Marek In my system I am doing the scatter gather compaction on device driver... But I agree that it would be better done on the vb2 layer. For the oversize sglist we could do one of this two things. If we want to have a s

Re: [PATCH 05/15] ARM: dts: omap: update usb_otg_hs data

2013-07-18 Thread Tony Lindgren
* Kishon Vijay Abraham I [130717 23:53]: > Updated the usb_otg_hs dt data to include the *phy* and *phy-names* > binding in order for the driver to use the new generic PHY framework. > Also updated the Documentation to include the binding information. > The PHY binding information can be found at

Re: [PATCH 04/15] ARM: OMAP: USB: Add phy binding information

2013-07-18 Thread Tony Lindgren
* Kishon Vijay Abraham I [130717 23:53]: > In order for controllers to get PHY in case of non dt boot, the phy > binding information (phy device name) should be added in the platform > data of the controller. > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Sylwester Nawrocki > Acked-by