Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-05-02 Thread Jon Arne Jørgensen
On Thu, May 02, 2013 at 11:09:14PM -0300, Ezequiel Garcia wrote: > Hi Jon, > > On Mon, Apr 29, 2013 at 10:41:07PM +0200, Jon Arne Jørgensen wrote: > > As we're now seeing other variants from chinese clones, like > > gm1113c, we'll need to add more bits at the detection code. > > > > So, move it i

[PATCH RFC v3] media: i2c: mt9p031: add OF support

2013-05-02 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the mt9p031 sensor driver. Alongside this patch sorts the header inclusion alphabetically. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus

Re: [PATCH V2 3/3] saa7115: Add register setup and config for gm7113c

2013-05-02 Thread Jon Arne Jørgensen
On Thu, May 02, 2013 at 11:24:07PM -0300, Ezequiel Garcia wrote: > On Mon, Apr 29, 2013 at 10:41:09PM +0200, Jon Arne Jørgensen wrote: > > > > Signed-off-by: Jon Arne Jørgensen > > Every patch *must* have a proper commit message indicating what you're doing > and why you're doing it. > > In par

Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-05-02 Thread Jon Arne Jørgensen
On Thu, May 02, 2013 at 11:09:14PM -0300, Ezequiel Garcia wrote: > Hi Jon, > > On Mon, Apr 29, 2013 at 10:41:07PM +0200, Jon Arne Jørgensen wrote: > > As we're now seeing other variants from chinese clones, like > > gm1113c, we'll need to add more bits at the detection code. > > > > So, move it i

Re: [PATCH 0/3] saa7115: add detection code for gm7113c

2013-05-02 Thread Jon Arne Jørgensen
On Thu, May 02, 2013 at 11:00:41PM -0300, Ezequiel Garcia wrote: > Hi Jon, > > On Mon, Apr 29, 2013 at 10:41:06PM +0200, Jon Arne Jørgensen wrote: > > This is the second version of a patch-set previously posted by Mauro, > > the first verseon was posted on 26 April, and can be found here: > > http

Re: [PATCH] mt9p031: Use gpio_is_valid()

2013-05-02 Thread Prabhakar Lad
Hi Laurent, Thanks for the patch. On Thu, May 2, 2013 at 4:34 PM, Laurent Pinchart wrote: > Replace the manual validity checks for the reset GPIO with the > gpio_is_valid() function. > > Signed-off-by: Laurent Pinchart Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from

Re: Terratec Grabby hwrev 2

2013-05-02 Thread Timo Teras
On Mon, 29 Apr 2013 15:26:18 +0300 Timo Teras wrote: > > > When comparing these two picture, you see that the frame is offset > > > with one or two pixels in x-direction. Perhaps this is a byte > > > offset, and in RGB format causes color values to be connected to > > > wrong pixel. > > > > > > A

Re: Terratec Grabby hwrev 2

2013-05-02 Thread Timo Teras
On Thu, 2 May 2013 10:04:56 +0300 Timo Teras wrote: > On Wed, 1 May 2013 19:11:53 +0200 > Jon Arne Jørgensen wrote: > > > On Thu, Mar 28, 2013 at 04:54:59PM +0200, Timo Teras wrote: > > > On Thu, 28 Mar 2013 15:35:56 +0200 > > > Timo Teras wrote: > > > > > > > On Thu, 28 Mar 2013 09:40:52 -03

Re: [PATCH V2 3/3] saa7115: Add register setup and config for gm7113c

2013-05-02 Thread Ezequiel Garcia
On Mon, Apr 29, 2013 at 10:41:09PM +0200, Jon Arne Jørgensen wrote: > > Signed-off-by: Jon Arne Jørgensen Every patch *must* have a proper commit message indicating what you're doing and why you're doing it. In particular, please add as much information as you can about this new clone decoder.

Re: [PATCH V2 2/3] saa7115: add detection code for gm7113c

2013-05-02 Thread Ezequiel Garcia
On Mon, Apr 29, 2013 at 10:41:08PM +0200, Jon Arne Jørgensen wrote: > Adds a code that (auto)detects gm7113c clones. The auto-detection > here is not perfect, as, on contrary to what it would be expected > by looking into its datasheets some devices would return, instead: > > saa7115 0-0025:

Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-05-02 Thread Ezequiel Garcia
Hi Jon, On Mon, Apr 29, 2013 at 10:41:07PM +0200, Jon Arne Jørgensen wrote: > As we're now seeing other variants from chinese clones, like > gm1113c, we'll need to add more bits at the detection code. > > So, move it into a separate function. > > Signed-off-by: Mauro Carvalho Chehab > Signed-of

Re: [PATCH 0/3] saa7115: add detection code for gm7113c

2013-05-02 Thread Ezequiel Garcia
Hi Jon, On Mon, Apr 29, 2013 at 10:41:06PM +0200, Jon Arne Jørgensen wrote: > This is the second version of a patch-set previously posted by Mauro, > the first verseon was posted on 26 April, and can be found here: > http://www.spinics.net/lists/linux-media/msg63079.html > > The purpose of this p

Re: linux-next: Tree for May 1 (media/usb/stk1160)

2013-05-02 Thread Randy Dunlap
On 05/02/13 07:52, Mauro Carvalho Chehab wrote: > [media] stk1160: Make stk1160 module if SND is m and audio support is selected > > As reported by Randy: > > When CONFIG_SND=m and CONFIG_SND_AC97_CODEC=m and > CONFIG_VIDEO_STK1160=y > CONFIG_VIDEO_STK1160_AC97=y > > drivers/built-in.o: In funct

Re: [PATCH] mt9p031: Use gpio_is_valid()

2013-05-02 Thread Sylwester Nawrocki
On 05/02/2013 01:04 PM, Laurent Pinchart wrote: Replace the manual validity checks for the reset GPIO with the gpio_is_valid() function. Signed-off-by: Laurent Pinchart Reviewed-by: Sylwester Nawrocki --- drivers/media/i2c/mt9p031.c | 8 1 file changed, 4 insertions(+), 4 deleti

Re: [PATCH, RFC 00/22] ARM randconfig bugs

2013-05-02 Thread Rafael J. Wysocki
On Thursday, May 02, 2013 05:16:04 PM Arnd Bergmann wrote: > Hi subsystem maintainers, > > This is a set of patches to to fix build errors I hit while trying to > build lots of randconfig kernels on linux-next. > > Most of them are simple missing dependencies in Kconfig, but some are > more subst

cron job: media_tree daily build: WARNINGS

2013-05-02 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu May 2 19:00:30 CEST 2013 git branch: test git hash: 02615ed5e1b2283db2495af3cf8f4ee172c77d80 gcc versi

Re: [PATCH, RFC 22/22] radio-si4713: depend on SND_SOC

2013-05-02 Thread Arnd Bergmann
On Thursday 02 May 2013, Mauro Carvalho Chehab wrote: > Do you prefer to send it via your tree or via mine? Either way works for me. > > If you're willing to send it via your tree: > > Acked-by: Mauro Carvalho Chehab I'd prefer your tree, because the patch does not apply on 3.9. Arnd -

Re: [PATCH, RFC 22/22] radio-si4713: depend on SND_SOC

2013-05-02 Thread Mauro Carvalho Chehab
Em 02-05-2013 12:16, Arnd Bergmann escreveu: It is not possible to select SND_SOC_SI476X if we have not also enabled SND_SOC. warning: (RADIO_SI476X) selects SND_SOC_SI476X which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC) Cc: Hans Verkuil Cc: linux-media@

Re: [PATCH, RFC 22/22] radio-si4713: depend on SND_SOC

2013-05-02 Thread Arnd Bergmann
On Thursday 02 May 2013, edubez...@gmail.com wrote: > On Thu, May 2, 2013 at 11:16 AM, Arnd Bergmann wrote: > > It is not possible to select SND_SOC_SI476X if we have not also > > enabled SND_SOC. > > > > warning: (RADIO_SI476X) selects SND_SOC_SI476X which has unmet > > direct dependenci

Re: [PATCH, RFC 22/22] radio-si4713: depend on SND_SOC

2013-05-02 Thread edubez...@gmail.com
Arnd, On Thu, May 2, 2013 at 11:16 AM, Arnd Bergmann wrote: > It is not possible to select SND_SOC_SI476X if we have not also > enabled SND_SOC. > > warning: (RADIO_SI476X) selects SND_SOC_SI476X which has unmet > direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC) > > Cc: Han

[PATCH, RFC 00/22] ARM randconfig bugs

2013-05-02 Thread Arnd Bergmann
Hi subsystem maintainers, This is a set of patches to to fix build errors I hit while trying to build lots of randconfig kernels on linux-next. Most of them are simple missing dependencies in Kconfig, but some are more substantial. I would like to see at least the obvious patches get merged for 3

[PATCH, RFC 22/22] radio-si4713: depend on SND_SOC

2013-05-02 Thread Arnd Bergmann
It is not possible to select SND_SOC_SI476X if we have not also enabled SND_SOC. warning: (RADIO_SI476X) selects SND_SOC_SI476X which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC) Cc: Hans Verkuil Cc: linux-media@vger.kernel.org Signed-off-by: Arnd Bergmann -

Re: linux-next: Tree for May 1 (media/usb/stk1160)

2013-05-02 Thread Mauro Carvalho Chehab
Em 01-05-2013 14:59, Randy Dunlap escreveu: On 05/01/13 01:37, Stephen Rothwell wrote: Hi all, Please do not add any v3.11 destined work to your linux-next included branches until after v3.10-rc1 is released. Changes since 20130430: When CONFIG_SND=m and CONFIG_SND_AC97_CODEC=m and CONFIG_

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Arnd Bergmann
On Thursday 02 May 2013 08:55:18 Sascha Hauer wrote: > > +#if defined(CONFIG_OF) > > +static struct mt9p031_platform_data * > > + mt9p031_get_pdata(struct i2c_client *client) > > + > > +{ > > + if (client->dev.of_node) { > > By inverting the logic here and returning immediately you can saf

Re: [PATCH v2] media: i2c: tvp7002: enable TVP7002 decoder for media controller based usage

2013-05-02 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thu, May 2, 2013 at 4:40 PM, Laurent Pinchart wrote: > Ho Prabhakar, > > Thank you for the patch. > > On Thursday 02 May 2013 11:14:42 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> This patch enables tvp7002 decoder driver for media controller >> based

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Laurent Pinchart
Hi Prabhakar, On Thursday 02 May 2013 18:48:37 Prabhakar Lad wrote: > On Thu, May 2, 2013 at 4:32 PM, Laurent Pinchart wrote: > > On Thursday 02 May 2013 12:34:25 Prabhakar Lad wrote: > >> On Thu, May 2, 2013 at 12:25 PM, Sascha Hauer wrote: > >> > On Thu, May 02, 2013 at 11:52:34AM +0530, Prabhak

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thu, May 2, 2013 at 4:32 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Thursday 02 May 2013 12:34:25 Prabhakar Lad wrote: >> On Thu, May 2, 2013 at 12:25 PM, Sascha Hauer wrote: >> > On Thu, May 02, 2013 at 11:52:34AM +0530,

[PATCH v3 2/2] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in mixer_drv.c

2013-05-02 Thread Sachin Kamat
NULL check on clocks obtained using common clock APIs should not be done. Use IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/mixer_drv.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/s5p-tv/mix

[PATCH v3 1/2] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in hdmi_drv.c

2013-05-02 Thread Sachin Kamat
NULL check on clocks obtained using common clock APIs should not be done. Use IS_ERR only. Signed-off-by: Sachin Kamat --- Changes since v2: Moved clock reset code to a function. --- drivers/media/platform/s5p-tv/hdmi_drv.c | 25 +++-- 1 file changed, 19 insertions(+), 6 de

distro-specific hint for build(ing) media_build

2013-05-02 Thread Treutwein Bernhard
Hi, using the debian derivate SolusOS (http://www.solusos.com/) I encountered the request to hint package names ... Distro "SolusOS Eveline" can be handled with: give_ubuntu_hints. Regards -- Bernhard Treutwein Ludwig-Maximilians-Universität Ref. VI.3 Anwendungsbetreuung Martiusstr. 4/I

Re: [PATCH v2] media: i2c: tvp7002: enable TVP7002 decoder for media controller based usage

2013-05-02 Thread Laurent Pinchart
Ho Prabhakar, Thank you for the patch. On Thursday 02 May 2013 11:14:42 Prabhakar Lad wrote: > From: Lad, Prabhakar > > This patch enables tvp7002 decoder driver for media controller > based usage by adding v4l2_subdev_pad_ops operations support > for enum_mbus_code, set_pad_format, get_pad_fo

[PATCH] mt9p031: Use gpio_is_valid()

2013-05-02 Thread Laurent Pinchart
Replace the manual validity checks for the reset GPIO with the gpio_is_valid() function. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9p031.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index 8de

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Thursday 02 May 2013 12:34:25 Prabhakar Lad wrote: > On Thu, May 2, 2013 at 12:25 PM, Sascha Hauer wrote: > > On Thu, May 02, 2013 at 11:52:34AM +0530, Prabhakar Lad wrote: > >> From: Lad, Prabhakar > >> > >> add OF support for the mt9p031 sensor driver

Re: [PATCH v2 1/2] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in hdmi_drv.c

2013-05-02 Thread Sylwester Nawrocki
Hi Sachin, On 05/02/2013 07:03 AM, Sachin Kamat wrote: > NULL check on clocks obtained using common clock APIs should not > be done. Use IS_ERR only. > > Signed-off-by: Sachin Kamat > --- > Changes since v1: > Initialised clocks to invalid value. > --- > drivers/media/platform/s5p-tv/hdmi_drv.c

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Prabhakar Lad
Hi Sascha, Thanks for the quick review. On Thu, May 2, 2013 at 12:25 PM, Sascha Hauer wrote: > On Thu, May 02, 2013 at 11:52:34AM +0530, Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> add OF support for the mt9p031 sensor driver. >> Alongside this patch sorts the header inclusion alphabetic

Re: Terratec Grabby hwrev 2

2013-05-02 Thread Timo Teras
On Wed, 1 May 2013 19:11:53 +0200 Jon Arne Jørgensen wrote: > On Thu, Mar 28, 2013 at 04:54:59PM +0200, Timo Teras wrote: > > On Thu, 28 Mar 2013 15:35:56 +0200 > > Timo Teras wrote: > > > > > On Thu, 28 Mar 2013 09:40:52 -0300 > > > Mauro Carvalho Chehab wrote: > > > > > > > Em Thu, 28 Mar 2