Re: Question regarding developing V4L2 device driver and Streaming IO in v4l2-ctl

2013-04-08 Thread Hans Verkuil
On Tue April 9 2013 05:57:40 Tzu-Jung Lee wrote: > Hi Hans, > > > On Mon, Apr 8, 2013 at 10:07 PM, Hans Verkuil wrote: > > > > But try the patch below for v4l2-ctl: if you combine streaming with > > --decoder-cmd > > then instead of doing a STREAMOFF it will call the decoder command. And the > >

Re: [PATCH] v4l2-ctl: skip precalculate_bars() for compressed formats

2013-04-08 Thread Tzu-Jung Lee
Sorry.. wrong patch.. Please ignore this noise. Thanks. Roy On Tue, Apr 9, 2013 at 2:35 PM, Tzu-Jung Lee wrote: > Signed-off-by: Tzu-Jung Lee > --- > utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/utils/v4l2-ctl/v4l2-ctl-stre

[PATCH] v4l2-ctl: skip precalculate_bars() for compressed formats

2013-04-08 Thread Tzu-Jung Lee
Signed-off-by: Tzu-Jung Lee --- utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/utils/v4l2-ctl/v4l2-ctl-streaming.cpp b/utils/v4l2-ctl/v4l2-ctl-streaming.cpp index a6ea8b3..ec18312 100644 --- a/utils/v4l2-ctl/v4l2-ctl-streaming.cpp ++

Re: [patch] [media] dt3155v4l: unlock on error path

2013-04-08 Thread Dan Carpenter
On Tue, Apr 09, 2013 at 07:20:19AM +0200, Julia Lawall wrote: > On Tue, 9 Apr 2013, Dan Carpenter wrote: > > > We should unlock here and do some cleanup before returning. > > > > We can't actually hit this return path with the current code, so this > > patch is a basically a cleanup and doesn't ch

Re: [patch] [media] dt3155v4l: unlock on error path

2013-04-08 Thread Hans Verkuil
On Tue April 9 2013 07:15:40 Dan Carpenter wrote: > We should unlock here and do some cleanup before returning. > > We can't actually hit this return path with the current code, so this > patch is a basically a cleanup and doesn't change how the code works. > > Signed-off-by: Dan Carpenter Nack

Re: [patch] [media] dt3155v4l: unlock on error path

2013-04-08 Thread Julia Lawall
On Tue, 9 Apr 2013, Dan Carpenter wrote: > We should unlock here and do some cleanup before returning. > > We can't actually hit this return path with the current code, so this > patch is a basically a cleanup and doesn't change how the code works. Why keep the return path then? If the code is t

[patch] [media] dt3155v4l: unlock on error path

2013-04-08 Thread Dan Carpenter
We should unlock here and do some cleanup before returning. We can't actually hit this return path with the current code, so this patch is a basically a cleanup and doesn't change how the code works. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c b/driver

Re: [PATCH v2 1/2] omap3isp: Use the common clock framework

2013-04-08 Thread Mike Turquette
Quoting Laurent Pinchart (2013-04-04 04:51:40) > Expose the two ISP external clocks XCLKA and XCLKB as common clocks for > subdev drivers. > > Signed-off-by: Laurent Pinchart Acked-by: Mike Turquette Regards, Mike > --- > drivers/media/platform/omap3isp/isp.c | 270 > +++

Re: Question regarding developing V4L2 device driver and Streaming IO in v4l2-ctl

2013-04-08 Thread Tzu-Jung Lee
Hi Hans, > On Mon, Apr 8, 2013 at 10:07 PM, Hans Verkuil wrote: > > But try the patch below for v4l2-ctl: if you combine streaming with > --decoder-cmd > then instead of doing a STREAMOFF it will call the decoder command. And the > encoder now listens to the EOS event. > Note that --en/decoder-c

[PATCH] [media] soc-camera: remove "config MX3_VIDEO"

2013-04-08 Thread Paul Bolle
The last user of Kconfig symbol MX3_VIDEO was removed in v3.2. Its Kconfig entry can be removed now. Signed-off-by: Paul Bolle --- Tested with "git grep". drivers/media/platform/soc_camera/Kconfig | 4 1 file changed, 4 deletions(-) diff --git a/drivers/media/platform/soc_camera/Kconfig

Re: [PATCH v8 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-04-08 Thread Samuel Ortiz
Hi Andrey, On Mon, Apr 08, 2013 at 11:34:43AM -0700, Andrey Smirnov wrote: > On Mon, Apr 8, 2013 at 3:16 AM, Samuel Ortiz wrote: > > This file doesn't exist yet, which breaks bisectability. > > I'm fine with you including it with the first patch. I will prepare a > branch > > with the mfd patches

Re: [REVIEW PATCH 7/7] radio-si4713: add prio checking and control events.

2013-04-08 Thread edubez...@gmail.com
Hey Hans, On Mon, Apr 8, 2013 at 11:46 AM, edubez...@gmail.com wrote: > Hi Hans, > > On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Signed-off-by: Hans Verkuil > > Acked-by: Eduardo Valentin > Tested-by: Eduardo Valentin Here is the output of v4l2-complianc

cron job: media_tree daily build: ERRORS

2013-04-08 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Apr 8 19:00:22 CEST 2013 git branch: test git hash: 81e096c8ac6a064854c2157e0bf802dc4906678c gcc versi

[PATCH -next] media:

2013-04-08 Thread Randy Dunlap
From: Randy Dunlap Fix randconfig error when USB is not enabled: ERROR: "usb_control_msg" [drivers/media/common/cypress_firmware.ko] undefined! Signed-off-by: Randy Dunlap Cc: Antti Palosaari --- drivers/media/common/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux-nex

[PATCH] em28xx: save isoc endpoint number for DVB only if endpoint has alt settings with xMaxPacketSize != 0

2013-04-08 Thread Frank Schäfer
In addition to commit 72cc9ba3 "em28xx: ignore isoc DVB USB endpoints with wMaxPacketSize = 0 bytes for all alt settings" we should not save the endpoint number of the isoc DVB endpoint before it has been validated. While the current code works fine, dev->dvb_ep_isoc != 0 could be interpreted as in

Re: em28xx: kernel oops in em28xx_tuner_callback() when watching digital TV

2013-04-08 Thread Frank Schäfer
Am 08.04.2013 10:38, schrieb Hans Verkuil: > On Mon April 8 2013 00:02:15 Frank Schäfer wrote: >> >> In em28xx_start_streaming() and also em28xx_stop_streaming() we do >> >> struct em28xx *dev = dvb->adapter.priv; >> >> which I would say should be the culprit. >> Are you sure that dvb->adapter

Re: [REVIEW PATCH 7/7] radio-si4713: add prio checking and control events.

2013-04-08 Thread edubez...@gmail.com
Hi Hans, On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil Acked-by: Eduardo Valentin Tested-by: Eduardo Valentin Output of v4l2-compliant: is radio Driver Info: Driver name : radio-si4713 Card type : Silicon Labs

Re: [REVIEW PATCH 6/7] radio-si4713: convert to the control framework

2013-04-08 Thread edubez...@gmail.com
Hi, On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil Acked-by: Eduardo Valentin Tested-by: Eduardo Valentin Output of v4l2-compliant: is radio Driver Info: Driver name : radio-si4713 Card type : Silicon Labs Si471

Re: [REVIEW PATCH 5/7] radio-si4713: fix g/s_frequency

2013-04-08 Thread edubez...@gmail.com
Hi, On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote: > From: Hans Verkuil > > - check for invalid modulators. > - clamp frequency to valid range. > > Signed-off-by: Hans Verkuil Acked-by: Eduardo Valentin Tested-by: Eduardo Valentin Here is the output of v4l2-compliant: is radio Driver I

Re: [REVIEW PATCH 4/7] radio-si4713: use V4L2 core lock.

2013-04-08 Thread edubez...@gmail.com
Hi, On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote: > From: Hans Verkuil > > Simplify locking by using the V4L2 core lock mechanism. This allows us to > remove all locking from the i2c module. This will also simplify the upcoming > conversion to the control framework. > > Signed-off-by: Hans

Re: [PATCH v7 2/7] media: V4L2: support asynchronous subdevice registration

2013-04-08 Thread Sylwester Nawrocki
On 04/08/2013 03:55 PM, Guennadi Liakhovetski wrote: > On Mon, 8 Apr 2013, Sylwester Nawrocki wrote: >> On 04/08/2013 01:07 PM, Guennadi Liakhovetski wrote: [...] >>> +static struct v4l2_async_subdev *v4l2_async_belongs(struct >>> v4l2_async_notifier *notifier, >>> +

Re: [REVIEW PATCH 3/7] radio-si4713: improve querycap

2013-04-08 Thread edubez...@gmail.com
Hi, On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote: > From: Hans Verkuil > > Set bus_info and fill in device_caps. > > Signed-off-by: Hans Verkuil Acked-by: Eduardo Valentin Tested-by: Eduardo Valentin Here is the output of v4l2-compliant is radio Driver Info: Driver name : r

Re: [REVIEW PATCH 2/7] radio-si4713: embed struct video_device instead of allocating it.

2013-04-08 Thread edubez...@gmail.com
Hi, On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote: > From: Hans Verkuil > > Also set the v4l2_dev pointer in struct video_device as this was missing. > > Signed-off-by: Hans Verkuil Acked-by: Eduardo Valentin Tested-by: Eduardo Valentin Output of v4l2-compliant is the same as in patch

Re: [REVIEW PATCH 1/7] radio-si4713: remove audout ioctls

2013-04-08 Thread edubez...@gmail.com
Hi, On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote: > From: Hans Verkuil > > The audout ioctls are not appropriate for radio transmitters, they apply to > video output devices only. Remove them from this driver. > > Signed-off-by: Hans Verkuil Acked-by: Eduardo Valentin Tested-by: Eduardo

Re: [REVIEW PATCH 0/7] radio-si4713: driver overhaul

2013-04-08 Thread edubez...@gmail.com
Hans, On Mon, Apr 8, 2013 at 8:03 AM, edubez...@gmail.com wrote: > Hans, > > > > On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote: >> This patch series makes radio-si4713 compliant with v4l2-compliance. >> > > Thanks for your patches. > >> Eduardo, thanks for testing the previous code. I hope

Re: [PATCH RFC v2 1/2] max77693: added device tree support

2013-04-08 Thread Samuel Ortiz
Hi Andrzej, On Tue, Feb 19, 2013 at 04:36:16PM +0100, Andrzej Hajda wrote: > max77693 mfd main device uses only wakeup field > from max77693_platform_data. This field is mapped > to wakeup-source property in device tree. > Device tree bindings doc will be added in max77693-led patch. > > Signed-o

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-04-08 Thread Sylwester Nawrocki
On 04/08/2013 12:36 PM, Guennadi Liakhovetski wrote: > On Mon, 18 Mar 2013, Sylwester Nawrocki wrote: > > [snip] > >>> +unsigned long v4l2_clk_get_rate(struct v4l2_clk *clk) >>> +{ >>> + if (!clk->ops->get_rate) >>> + return -ENOSYS; >> >> I guess we should just WARN if this callback

[PATCH v8 0/7] V4L2 clock and async patches and soc-camera example

2013-04-08 Thread Guennadi Liakhovetski
Mostly just a re-spin of v7 with minor modifications. Guennadi Liakhovetski (7): media: V4L2: add temporary clock helpers media: V4L2: support asynchronous subdevice registration media: soc-camera: switch I2C subdevice drivers to use v4l2-clk soc-camera: add V4L2-async support sh_mobile_

[PATCH v8 5/7] sh_mobile_ceu_camera: add asynchronous subdevice probing support

2013-04-08 Thread Guennadi Liakhovetski
Use the v4l2-async API to support asynchronous subdevice probing, including the CSI2 subdevice. Synchronous probing is still supported too. Signed-off-by: Guennadi Liakhovetski --- .../platform/soc_camera/sh_mobile_ceu_camera.c | 134 - drivers/media/platform/soc_camera/sh_m

[PATCH v8 6/7] imx074: support asynchronous probing

2013-04-08 Thread Guennadi Liakhovetski
Both synchronous and asynchronous imx074 subdevice probing is supported by this patch. Signed-off-by: Guennadi Liakhovetski --- drivers/media/i2c/soc_camera/imx074.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/soc_camera/imx0

[PATCH v8 7/7] ARM: shmobile: convert ap4evb to asynchronously register camera subdevices

2013-04-08 Thread Guennadi Liakhovetski
Register the imx074 camera I2C and the CSI-2 platform devices directly in board platform data instead of letting the sh_mobile_ceu_camera driver and the soc-camera framework register them at their run-time. This uses the V4L2 asynchronous subdevice probing capability. Signed-off-by: Guennadi Liakh

[PATCH v8 2/7] media: V4L2: support asynchronous subdevice registration

2013-04-08 Thread Guennadi Liakhovetski
Currently bridge device drivers register devices for all subdevices synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor is attached to a video bridge device, the bridge driver will create an I2C device and wait for the respective I2C driver to probe. This makes linking of dev

[PATCH v8 3/7] media: soc-camera: switch I2C subdevice drivers to use v4l2-clk

2013-04-08 Thread Guennadi Liakhovetski
Instead of centrally enabling and disabling subdevice master clocks in soc-camera core, let subdevice drivers do that themselves, using the V4L2 clock API and soc-camera convenience wrappers. Signed-off-by: Guennadi Liakhovetski --- drivers/media/i2c/soc_camera/imx074.c | 18 ++-

[PATCH v8 1/7] media: V4L2: add temporary clock helpers

2013-04-08 Thread Guennadi Liakhovetski
Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers without a running clock. These clock sources should be controlled by their consumers. This should be performed, using the generic clock framework. Unfortunately

[PATCH v8 4/7] soc-camera: add V4L2-async support

2013-04-08 Thread Guennadi Liakhovetski
Add support for asynchronous subdevice probing, using the v4l2-async API. The legacy synchronous mode is still supported too, which allows to gradually update drivers and platforms. The selected approach adds a notifier for each struct soc_camera_device instance, i.e. for each video device node, ev

Re: Question regarding developing V4L2 device driver and Streaming IO in v4l2-ctl

2013-04-08 Thread Hans Verkuil
On Sat April 6 2013 18:23:46 Tzu-Jung Lee wrote: > Hi Hans, > > Thanks for the pointer to the EVENT and the ENC/DEC CMD :) > I just noticed that v4l2-ctl has a command category for them as well. > > If I configure the codec as a transcoder, and would like to transcode > a input bitstream with v4l

Re: [PATCH v7 2/7] media: V4L2: support asynchronous subdevice registration

2013-04-08 Thread Guennadi Liakhovetski
Hi Sylwester On Mon, 8 Apr 2013, Sylwester Nawrocki wrote: > Hi Guennadi, > > On 04/08/2013 01:07 PM, Guennadi Liakhovetski wrote: > > Currently bridge device drivers register devices for all subdevices > > synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor > > is attache

Re: [PATCH v7 2/7] media: V4L2: support asynchronous subdevice registration

2013-04-08 Thread Sylwester Nawrocki
Hi Guennadi, On 04/08/2013 01:07 PM, Guennadi Liakhovetski wrote: > Currently bridge device drivers register devices for all subdevices > synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor > is attached to a video bridge device, the bridge driver will create an I2C > device

Re: [PATCH] Fix s5c73m3-core.c compiler warning

2013-04-08 Thread Sylwester Nawrocki
On 04/08/2013 11:10 AM, Hans Verkuil wrote: > Fix for this compiler warning: > > CC [M] drivers/media/i2c/s5c73m3/s5c73m3-core.o > drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function ‘s5c73m3_load_fw’: > drivers/media/i2c/s5c73m3/s5c73m3-core.c:360:2: warning: format ‘%d’ expects > argument

[GIT PULL] s5p-mfc: decoder fix

2013-04-08 Thread Kamil Debski
Hi Mauro, Somehow the patch adding another way of ending video stream decoding was lost. I am not sure if this should be regarded as a fix or adding new functionality. It adds the ability to finish video decoding with an EOS command and notify the application with an event that the last frame was

Re: vivi kernel driver

2013-04-08 Thread Hans Verkuil
On Mon April 8 2013 14:42:32 Michal Lazo wrote: > Hi > 720x576 RGB 25, 30 fps and it take > > 25% cpu load on raspberry pi(ARM 700Mhz linux 3.6.11) or 8% on x86(AMD > 2GHz linux 3.2.0-39) > > it is simply too much No, that's what I would expect. Note that vivi was substantially improved recentl

Re: vivi kernel driver

2013-04-08 Thread Michal Lazo
Hi 720x576 RGB 25, 30 fps and it take 25% cpu load on raspberry pi(ARM 700Mhz linux 3.6.11) or 8% on x86(AMD 2GHz linux 3.2.0-39) it is simply too much On Mon, Apr 8, 2013 at 9:42 AM, Peter Senna Tschudin wrote: > Dear Michal, > > The CPU intensive part of the vivi driver is the image genera

[PATCH v3 3/3] davinic: vpss: trivial cleanup

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar this patch removes unnecessary header file inclusions and fixes the typo's. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/davinci/vpss.c b/d

[PATCH v3 2/3] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar The vpss clocks were enabled by calling a exported function from a driver in a machine code. calling driver code from platform code is incorrect way. This patch fixes this issue and calls the function from driver code itself. Signed-off-by: Lad, Prabhakar --- drivers/medi

[PATCH v3 1/3] media: davinci: vpss: enable vpss clocks

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar By default the VPSS clocks were enabled in capture driver for davinci family which creates duplicates for dm355/dm365/dm644x. This patch adds support to enable the VPSS clocks in VPSS driver, which avoids duplication of code and also adding clock aliases. This patch uses PM

[PATCH v3 0/3] davinci: vpss: clock cleanup

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar This patch series cleanup's the VPSS clock enabling. The first patch removes vpss clock enabling from the capture drivers and moves it to the VPSS driver itself. The second patch moves the venc_enable_vpss_clock() to the driver which was being done in platform code. Changes

Re: [REVIEW PATCH 0/7] radio-si4713: driver overhaul

2013-04-08 Thread edubez...@gmail.com
Hans, On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil wrote: > This patch series makes radio-si4713 compliant with v4l2-compliance. > Thanks for your patches. > Eduardo, thanks for testing the previous code. I hope this version resolves > all the issues we found. Can you test again? > Of course

Re: [PATCH 10/14] media: soc-camera: support OF cameras

2013-04-08 Thread Barry Song
Hi Guennadi, 2013/4/8 Guennadi Liakhovetski : > Hi Barry > > On Mon, 8 Apr 2013, Barry Song wrote: > >> hi Guennadi, >> >> 2012/9/27 Guennadi Liakhovetski : >> > With OF we aren't getting platform data any more. To minimise changes we >> > create all the missing data ourselves, including compulsor

Re: [PATCH v2 1/3] media: davinci: vpss: enable vpss clocks

2013-04-08 Thread Sekhar Nori
On 4/8/2013 5:08 PM, Prabhakar Lad wrote: > Sekhar, > > On Mon, Apr 8, 2013 at 3:56 PM, Sekhar Nori wrote: >> On 4/2/2013 5:14 PM, Prabhakar lad wrote: >>> From: Lad, Prabhakar >>> >>> By default the VPSS clocks were enabled in capture driver >>> for davinci family which creates duplicates for

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-08 Thread Daniel Vetter
On Mon, Apr 08, 2013 at 12:39:24PM +0200, Peter Zijlstra wrote: > On Thu, 2013-04-04 at 18:56 +0200, Daniel Vetter wrote: > > Presuming I'm still following we should be able to fix this with the > > new sleep state TASK_DEADLOCK and a flag somewhere in the thread info > > (let's call it PF_GTFO for

Re: [PATCH v2 1/3] media: davinci: vpss: enable vpss clocks

2013-04-08 Thread Prabhakar Lad
Sekhar, On Mon, Apr 8, 2013 at 3:56 PM, Sekhar Nori wrote: > On 4/2/2013 5:14 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> By default the VPSS clocks were enabled in capture driver >> for davinci family which creates duplicates for dm355/dm365/dm644x. >> This patch adds support to enab

Re: [PATCH 10/14] media: soc-camera: support OF cameras

2013-04-08 Thread Guennadi Liakhovetski
Hi Barry On Mon, 8 Apr 2013, Barry Song wrote: > hi Guennadi, > > 2012/9/27 Guennadi Liakhovetski : > > With OF we aren't getting platform data any more. To minimise changes we > > create all the missing data ourselves, including compulsory struct > > soc_camera_link objects. Host-client linking

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-08 Thread Viresh Kumar
On 8 April 2013 16:37, Vikas Sajjan wrote: > While migrating to common clock framework (CCF), I found that the FIMD clocks > were pulled down by the CCF. > If CCF finds any clock(s) which has NOT been claimed by any of the > drivers, then such clock(s) are PULLed low by CCF. > > Calling clk_prepar

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-08 Thread Vikas Sajjan
While migrating to common clock framework (CCF), I found that the FIMD clocks were pulled down by the CCF. If CCF finds any clock(s) which has NOT been claimed by any of the drivers, then such clock(s) are PULLed low by CCF. Calling clk_prepare() for FIMD clocks fixes the issue. This patch also r

[PATCH v7 3/7] media: soc-camera: switch I2C subdevice drivers to use v4l2-clk

2013-04-08 Thread Guennadi Liakhovetski
Instead of centrally enabling and disabling subdevice master clocks in soc-camera core, let subdevice drivers do that themselves, using the V4L2 clock API and soc-camera convenience wrappers. Signed-off-by: Guennadi Liakhovetski --- drivers/media/i2c/soc_camera/imx074.c | 18 ++-

[PATCH v7 2/7] media: V4L2: support asynchronous subdevice registration

2013-04-08 Thread Guennadi Liakhovetski
Currently bridge device drivers register devices for all subdevices synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor is attached to a video bridge device, the bridge driver will create an I2C device and wait for the respective I2C driver to probe. This makes linking of dev

[PATCH v7 4/7] soc-camera: add V4L2-async support

2013-04-08 Thread Guennadi Liakhovetski
Add support for asynchronous subdevice probing, using the v4l2-async API. The legacy synchronous mode is still supported too, which allows to gradually update drivers and platforms. The selected approach adds a notifier for each struct soc_camera_device instance, i.e. for each video device node, ev

[PATCH v7 0/7] V4L2 clock and async patches and soc-camera example

2013-04-08 Thread Guennadi Liakhovetski
Update of V4l2 clock and asynchronous probing patches. Various review comments are addressed, as described in individual patches. (Yes, this is an exact copy of the text in v6 ;-) ) A common notice for v7: while patches 1 and 2 introduce the new API, patches 3-7 use it. Reviewer comments mainly

[PATCH v7 7/7] ARM: shmobile: convert ap4evb to asynchronously register camera subdevices

2013-04-08 Thread Guennadi Liakhovetski
Register the imx074 camera I2C and the CSI-2 platform devices directly in board platform data instead of letting the sh_mobile_ceu_camera driver and the soc-camera framework register them at their run-time. This uses the V4L2 asynchronous subdevice probing capability. Signed-off-by: Guennadi Liakh

[PATCH v7 5/7] sh_mobile_ceu_camera: add asynchronous subdevice probing support

2013-04-08 Thread Guennadi Liakhovetski
Use the v4l2-async API to support asynchronous subdevice probing, including the CSI2 subdevice. Synchronous probing is still supported too. Signed-off-by: Guennadi Liakhovetski --- .../platform/soc_camera/sh_mobile_ceu_camera.c | 134 - drivers/media/platform/soc_camera/sh_m

[PATCH v7 1/7] media: V4L2: add temporary clock helpers

2013-04-08 Thread Guennadi Liakhovetski
Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers without a running clock. These clock sources should be controlled by their consumers. This should be performed, using the generic clock framework. Unfortunately

[PATCH v7 6/7] imx074: support asynchronous probing

2013-04-08 Thread Guennadi Liakhovetski
Both synchronous and asynchronous imx074 subdevice probing is supported by this patch. Signed-off-by: Guennadi Liakhovetski --- drivers/media/i2c/soc_camera/imx074.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/soc_camera/imx0

[REVIEW PATCH 04/12] hdpvr: remove hdpvr_fh and just use v4l2_fh.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil This prepares the driver for priority and control event handling. This patch also checks for correct streaming ownership and it makes a small improvement to the encoder_cmd ioctls: always zero 'flags' and drop the memset of 'raw' as that is already done by the v4l2 core. Sign

[REVIEW PATCH 11/12] hdpvr: add dv_timings support.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c | 217 + drivers/media/usb/hdpvr/hdpvr.h |1 + 2 files changed, 194 insertions(+), 24 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/m

[REVIEW PATCH 01/12] videodev2.h: fix incorrect V4L2_DV_FL_HALF_LINE bitmask.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil This was set to 1 << 0 which is the same as V4L2_DV_FL_REDUCED_BLANKING. It should be 1 << 3 instead. Luckily interlaced formats are rarely used, which is why this bug wasn't seen until now. Signed-off-by: Hans Verkuil --- include/uapi/linux/videodev2.h |2 +- 1 file cha

[REVIEW PATCH 10/12] hdpvr: add g/querystd, remove deprecated current_norm.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c | 62 ++--- drivers/media/usb/hdpvr/hdpvr.h |5 ++- 2 files changed, 54 insertions(+), 13 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/

[REVIEW PATCH 09/12] hdpvr: recognize firmware version 0x1e.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil This is the latest firmware version and - it seems - the most reliable. Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-core.c |1 + drivers/media/usb/hdpvr/hdpvr.h |1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/usb/hdpvr/hdpvr-

[REVIEW PATCH 03/12] hdpvr: convert to the control framework.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c | 515 + drivers/media/usb/hdpvr/hdpvr.h |8 + 2 files changed, 145 insertions(+), 378 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/

[REVIEW PATCH 00/12] hdpvr: driver overhaul

2013-04-08 Thread Hans Verkuil
This patch series updates the hdpvr driver to the latest v4l2 frameworks (except, as usual, vb2). It has been tested with my hdpvr and a HDTV signal generator and it looks pretty good. I did discover that you need the latest firmware to have the hdpvr handle input and format switches correctly. I

[REVIEW PATCH 06/12] hdpvr: support device_caps in querycap.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c index e30ece2..406eda8 100644 --- a/drivers/media/

[REVIEW PATCH 02/12] v4l2-dv-timings.h: add 480i59.94 and 576i50 CEA-861-E timings.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil These formats are supported by the HDPVR, but they were missing in the list. Note that these formats are different from the common PAL/NTSC/SECAM formats since all color channels are transmitted separately and so there is no PAL or NTSC or SECAM color encoding involved. Signed

[REVIEW PATCH 12/12] hdpvr: allow g/s_std when in legacy mode.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Otherwise gstreamer will no longer work. Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video

[REVIEW PATCH 05/12] hdpvr: add prio and control event support.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c index 4bbcf48..e30ece2 100644 --- a

[REVIEW PATCH 07/12] hdpvr: small fixes

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil - return EBUSY instead of EAGAIN. - add missing break. - remove unnecessary buf type check (done by the core). Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb

[REVIEW PATCH 08/12] hdpvr: register the video node at the end of probe.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Video nodes can be used at once after registration, so make sure the full initialization is done before registering them. Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-core.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/

Re: [PATCH v6 3/7] media: soc-camera: switch I2C subdevice drivers to use v4l2-clk

2013-04-08 Thread Guennadi Liakhovetski
On Wed, 27 Mar 2013, Laurent Pinchart wrote: > Hi Guennadi, > > Thanks for the patch. > > On Friday 15 March 2013 22:27:49 Guennadi Liakhovetski wrote: > > Instead of centrally enabling and disabling subdevice master clocks in > > soc-camera core, let subdevice drivers do that themselves, using

[REVIEW PATCH 3/7] radio-si4713: improve querycap

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Set bus_info and fill in device_caps. Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-si4713.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/radio/radio-si4713.c b/drivers/media/radio/radio-si4713.c index 70dc652..f0f0a90

[REVIEW PATCH 5/7] radio-si4713: fix g/s_frequency

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil - check for invalid modulators. - clamp frequency to valid range. Signed-off-by: Hans Verkuil --- drivers/media/radio/si4713-i2c.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/radio/si4713-i2c.c b/drivers/media/radio/si4713-i2

[REVIEW PATCH 7/7] radio-si4713: add prio checking and control events.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-si4713.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/media/radio/radio-si4713.c b/drivers/media/radio/radio-si4713.c index f8c6137..ba4cfc9 100644 --- a/drivers/media/radio/radio-si4713.c

[REVIEW PATCH 6/7] radio-si4713: convert to the control framework

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-si4713.c | 89 +--- drivers/media/radio/si4713-i2c.c | 908 drivers/media/radio/si4713-i2c.h | 65 ++- 3 files changed, 239 insertions(+), 823 deletions(-) diff --git a/dr

[REVIEW PATCH 4/7] radio-si4713: use V4L2 core lock.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Simplify locking by using the V4L2 core lock mechanism. This allows us to remove all locking from the i2c module. This will also simplify the upcoming conversion to the control framework. Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-si4713.c |4 + drivers/me

[REVIEW PATCH 1/7] radio-si4713: remove audout ioctls

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil The audout ioctls are not appropriate for radio transmitters, they apply to video output devices only. Remove them from this driver. Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-si4713.c | 32 1 file changed, 32 deletions(-) d

[REVIEW PATCH 2/7] radio-si4713: embed struct video_device instead of allocating it.

2013-04-08 Thread Hans Verkuil
From: Hans Verkuil Also set the v4l2_dev pointer in struct video_device as this was missing. Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-si4713.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/media/radio/radio-si4713.c b

[REVIEW PATCH 0/7] radio-si4713: driver overhaul

2013-04-08 Thread Hans Verkuil
This patch series makes radio-si4713 compliant with v4l2-compliance. Eduardo, thanks for testing the previous code. I hope this version resolves all the issues we found. Can you test again? This code is also available here: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/si471

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-08 Thread Peter Zijlstra
On Thu, 2013-04-04 at 18:56 +0200, Daniel Vetter wrote: > On Thu, Apr 4, 2013 at 3:31 PM, Daniel Vetter wrote: > >> In this case when O blocks Y isn't actually blocked, so our > >> TASK_DEADLOCK wakeup doesn't actually achieve anything. > >> > >> This means we also have to track (task) state so th

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-04-08 Thread Guennadi Liakhovetski
On Mon, 18 Mar 2013, Sylwester Nawrocki wrote: [snip] > > +unsigned long v4l2_clk_get_rate(struct v4l2_clk *clk) > > +{ > > + if (!clk->ops->get_rate) > > + return -ENOSYS; > > I guess we should just WARN if this callback is null and return 0 > or return value type of this function n

Re: [PATCH v2 1/3] media: davinci: vpss: enable vpss clocks

2013-04-08 Thread Sekhar Nori
On 4/2/2013 5:14 PM, Prabhakar lad wrote: > From: Lad, Prabhakar > > By default the VPSS clocks were enabled in capture driver > for davinci family which creates duplicates for dm355/dm365/dm644x. > This patch adds support to enable the VPSS clocks in VPSS driver, > which avoids duplication of co

Re: [PATCH v8 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-04-08 Thread Samuel Ortiz
Hi Andrey, On Tue, Mar 26, 2013 at 07:47:18PM -0700, Andrey Smirnov wrote: > From: Andrey Smirnov > > This patch adds all the functions used for exchanging commands with > the chip. > > Acked-by: Hans Verkuil > Signed-off-by: Andrey Smirnov > --- > drivers/mfd/si476x-cmd.c | 1554 >

Re: [PATCH v3] media: davinci: kconfig: fix incorrect selects

2013-04-08 Thread Sekhar Nori
On 4/8/2013 1:39 PM, Prabhakar Lad wrote: > Hi Sekhar, >> config VIDEO_DAVINCI_VPBE_DISPLAY >> - tristate "DM644X/DM365/DM355 VPBE HW module" >> - depends on ARCH_DAVINCI_DM644x || ARCH_DAVINCI_DM355 || >> ARCH_DAVINCI_DM365 >> - select VIDEO_VPSS_SYSTEM >> + tristate "TI

Re: [PATCH 10/14] media: soc-camera: support OF cameras

2013-04-08 Thread Barry Song
hi Guennadi, 2012/9/27 Guennadi Liakhovetski : > With OF we aren't getting platform data any more. To minimise changes we > create all the missing data ourselves, including compulsory struct > soc_camera_link objects. Host-client linking is now done, based on the OF > data. Media bus numbers also

[PATCH] Fix s5c73m3-core.c compiler warning

2013-04-08 Thread Hans Verkuil
Fix for this compiler warning: CC [M] drivers/media/i2c/s5c73m3/s5c73m3-core.o drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function ‘s5c73m3_load_fw’: drivers/media/i2c/s5c73m3/s5c73m3-core.c:360:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wforma

Re: em28xx: kernel oops in em28xx_tuner_callback() when watching digital TV

2013-04-08 Thread Hans Verkuil
On Mon April 8 2013 00:02:15 Frank Schäfer wrote: > > > In em28xx_start_streaming() and also em28xx_stop_streaming() we do > > struct em28xx *dev = dvb->adapter.priv; > > which I would say should be the culprit. > Are you sure that dvb->adapter.priv needs to be assigned to i2c_bus > instea

Re: [PATCH v3] media: davinci: kconfig: fix incorrect selects

2013-04-08 Thread Prabhakar Lad
Hi Sekhar, On Tue, Mar 12, 2013 at 2:44 PM, Sekhar Nori wrote: > drivers/media/platform/davinci/Kconfig uses selects where > it should be using 'depends on'. This results in warnings of > the following sort when doing randconfig builds. > > warning: (VIDEO_DM6446_CCDC && VIDEO_DM355_CCDC && VIDEO

Re: vivi kernel driver

2013-04-08 Thread Peter Senna Tschudin
Dear Michal, The CPU intensive part of the vivi driver is the image generation. This is not an issue for real drivers. Regards, Peter On Sun, Apr 7, 2013 at 9:32 PM, Michal Lazo wrote: > Hi > V4L2 driver vivi > generate 25% cpu load on raspberry pi(linux 3.6.11) or 8% on x86(linux > 3.2.0-39)

Re: No Signal with TerraTec Cinergy T PCIe dual

2013-04-08 Thread Oliver Schinagl
On 07-04-13 12:56, Jan Saris wrote: Hi, Sinse a couple of months I'm trying to get my second DVB-C card to work, but with no luck. I have searched a lot around and even tried the last media_build. I have the same card and while I don't see anything wrong (you have 2 dvb-t devices installed righ