Re: [QUERY] V4L async api

2013-03-21 Thread Prabhakar Lad
Guennadi, On Fri, Mar 22, 2013 at 11:02 AM, Prabhakar Lad wrote: > Guennadi, > > On Sun, Feb 3, 2013 at 2:32 AM, Guennadi Liakhovetski > wrote: >> On Wed, 30 Jan 2013, Prabhakar Lad wrote: >> >>> Hi Guennadi, >>> >>> I am working on adding v4l-asyn for capture and display device.. >>> >>> Here i

Re: [QUERY] V4L async api

2013-03-21 Thread Prabhakar Lad
Guennadi, On Sun, Feb 3, 2013 at 2:32 AM, Guennadi Liakhovetski wrote: > On Wed, 30 Jan 2013, Prabhakar Lad wrote: > >> Hi Guennadi, >> >> I am working on adding v4l-asyn for capture and display device.. >> >> Here is my hw details:-- >> 1: The capture device has two subdevs tvp514x @0x5c and tv

[PATCH -next] [media] dvb_usb_v2: make local function dvb_usb_v2_generic_io() static

2013-03-21 Thread Wei Yongjun
From: Wei Yongjun dvb_usb_v2_generic_io() was not declared. It should be static. Signed-off-by: Wei Yongjun --- drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c b/drivers/media/usb/dvb-usb

Re: [REVIEW PATCH 11/41] af9035: basic support for IT9135 v2 chips

2013-03-21 Thread Antti Palosaari
On 03/21/2013 11:54 PM, Mauro Carvalho Chehab wrote: Em Sun, 10 Mar 2013 04:03:03 +0200 Antti Palosaari escreveu: static struct ite_config af9035_it913x_config = { - .chip_ver = 0x01, + .chip_ver = 0x02, @@ -1153,6 +1161,7 @@ static int af9035_tuner_attach(struct dvb_usb_adapte

Re: [REVIEW PATCH 11/41] af9035: basic support for IT9135 v2 chips

2013-03-21 Thread Mauro Carvalho Chehab
Em Sun, 10 Mar 2013 04:03:03 +0200 Antti Palosaari escreveu: > Signed-off-by: Antti Palosaari > --- > drivers/media/usb/dvb-usb-v2/af9035.c | 44 > --- > 1 file changed, 31 insertions(+), 13 deletions(-) > > diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c >

Re: [PATCH] media: fix hdpvr build warning

2013-03-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Mar 2013 11:57:24 -0700 Randy Dunlap escreveu: > On 03/21/13 11:45, Mauro Carvalho Chehab wrote: > > Em Tue, 12 Mar 2013 11:40:29 -0700 > > Randy Dunlap escreveu: > > > >> From: Randy Dunlap > >> > >> Fix build warning in hdpvr: > >> > >> drivers/media/usb/hdpvr/hdpvr-video.c: warni

Re: [PATCH] media: fix hdpvr build warning

2013-03-21 Thread Randy Dunlap
On 03/21/13 11:45, Mauro Carvalho Chehab wrote: > Em Tue, 12 Mar 2013 11:40:29 -0700 > Randy Dunlap escreveu: > >> From: Randy Dunlap >> >> Fix build warning in hdpvr: >> >> drivers/media/usb/hdpvr/hdpvr-video.c: warning: "CONFIG_I2C_MODULE" is not >> defined [-Wundef] >> >> Signed-off-by: Rand

[PATCH 2/4] [media] tuners: use IS_ENABLED

2013-03-21 Thread Mauro Carvalho Chehab
Instead of checking everywhere there for 3 symbols, use instead IS_ENABLED macro. This replacement was done using this small perl script: my $data; $data .= $_ while (<>); if ($data =~ m/CONFIG_([A-Z\_\d]*)_MODULE/) { $data =~ s,defined\(CONFIG_($f)\)[\s\|\&\\\(\)]+defined\(CONFIG_($f)_M

[PATCH 1/4] [media] dvb-frontends: use IS_ENABLED

2013-03-21 Thread Mauro Carvalho Chehab
Instead of checking everywhere there for 3 symbols, use instead IS_ENABLED macro. This replacement was done using this small perl script: my $data; $data .= $_ while (<>); if ($data =~ m/CONFIG_([A-Z\_\d]*)_MODULE/) { $data =~ s,defined\(CONFIG_($f)\)[\s\|\&\\\(\)]+defined\(CONFIG_($f)_M

[PATCH 4/4] [media] dvb-usb/dvb-usb-v2: use IS_ENABLED

2013-03-21 Thread Mauro Carvalho Chehab
Instead of checking everywhere there for 3 symbols, use instead IS_ENABLED macro. This replacement was done using this small perl script: my $data; $data .= $_ while (<>); if ($data =~ m/CONFIG_([A-Z\_\d]*)_MODULE/) { $data =~ s,defined\(CONFIG_($f)\)[\s\|\&\\\(\)]+defined\(CONFIG_($f)_M

[PATCH 3/4] [media] cx23885: use IS_ENABLED

2013-03-21 Thread Mauro Carvalho Chehab
Instead of checking everywhere there for 3 symbols, use instead IS_ENABLED macro. This replacement was done using this small perl script: my $data; $data .= $_ while (<>); if ($data =~ m/CONFIG_([A-Z\_\d]*)_MODULE/) { $data =~ s,defined\(CONFIG_($f)\)[\s\|\&\\\(\)]+defined\(CONFIG_($f)_M

cron job: media_tree daily build: ERRORS

2013-03-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Mar 21 19:00:26 CET 2013 git branch: test git hash: bff7993936a1617f7502ddd2a09d37767fc8c929 gcc versio

Re: em28xx: commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke HVR 900

2013-03-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Mar 2013 19:21:02 +0100 Frank Schäfer escreveu: > Am 21.03.2013 16:34, schrieb Hans Verkuil: > > On Thu March 21 2013 11:03:27 Mauro Carvalho Chehab wrote: > >> Em Thu, 21 Mar 2013 09:33:41 +0100 > >> Hans Verkuil escreveu: > >> > >>> I tried to use my HVR 900 stick today and discover

Re: media-tree build is broken

2013-03-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Mar 2013 19:16:55 +0100 Frank Schäfer escreveu: > ... > Kernel: arch/x86/boot/bzImage is ready (#2) > ERROR: "__divdi3" [drivers/media/common/siano/smsdvb.ko] undefined! > make[1]: *** [__modpost] Fehler 1 > make: *** [modules] Fehler 2 > > > Mauro, I assume this is caused by one of

Re: [PATCH 0/4] media: si4713: minor updates

2013-03-21 Thread edubez...@gmail.com
Hans, >> > Are you still able to test the si4713 driver? Because I have patches >> >> >> >> I see. In fact that is my next step on my todo list for si4713. I >> still have an n900 that I can fetch from my drobe, so just a matter of >> booting it with newer kernel. >> >> > outstanding that I wou

Re: [PATCH] media: fix hdpvr build warning

2013-03-21 Thread Mauro Carvalho Chehab
Em Tue, 12 Mar 2013 11:40:29 -0700 Randy Dunlap escreveu: > From: Randy Dunlap > > Fix build warning in hdpvr: > > drivers/media/usb/hdpvr/hdpvr-video.c: warning: "CONFIG_I2C_MODULE" is not > defined [-Wundef] > > Signed-off-by: Randy Dunlap > Reported-by: Geert Uytterhoeven > Cc: Janne Gr

Re: em28xx: commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke HVR 900

2013-03-21 Thread Frank Schäfer
Am 21.03.2013 16:34, schrieb Hans Verkuil: > On Thu March 21 2013 11:03:27 Mauro Carvalho Chehab wrote: >> Em Thu, 21 Mar 2013 09:33:41 +0100 >> Hans Verkuil escreveu: >> >>> I tried to use my HVR 900 stick today and discovered that it no longer >>> worked. >>> I traced it to commit aab3125c43d8f

media-tree build is broken

2013-03-21 Thread Frank Schäfer
... Kernel: arch/x86/boot/bzImage is ready (#2) ERROR: "__divdi3" [drivers/media/common/siano/smsdvb.ko] undefined! make[1]: *** [__modpost] Fehler 1 make: *** [modules] Fehler 2 Mauro, I assume this is caused by one of the recent Siano patches ? Regards, Frank -- To unsubscribe from this list:

[PATCH 5/8] bttv: separate GPIO part from function audio_mux()

2013-03-21 Thread Frank Schäfer
Move the GPIO part of function audio_mux() to a separate function audio_mux_gpio(). This prepares the code for the next patch which will separate mute and input setting. Signed-off-by: Frank Schäfer Acked-by: Hans Verkuil --- drivers/media/pci/bt8xx/bttv-driver.c | 18 -- 1 Da

[PATCH 7/8] bttv: do not unmute the device before the first open

2013-03-21 Thread Frank Schäfer
Signed-off-by: Frank Schäfer Acked-by: Hans Verkuil --- drivers/media/pci/bt8xx/bttv-driver.c |4 +++- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index 0df4a16..55eab61 100644 ---

[PATCH 8/8] bttv: apply mute settings on open

2013-03-21 Thread Frank Schäfer
Previously, this has been done implicitly for video device nodes by calling set_input() (which calls audio_input() and also modified the mute setting). Since input and mute setting are now untangled (as much as possible), we need to apply the mute setting with an explicit call to audio_mute(). Also

[PATCH 6/8] bttv: untangle audio input and mute setting

2013-03-21 Thread Frank Schäfer
Split function audio_mux(): move the mute setting part to function audio_mute() and the input setting part to function audio_input(). Signed-off-by: Frank Schäfer Acked-by: Hans Verkuil --- drivers/media/pci/bt8xx/bttv-driver.c | 51 - 1 Datei geändert, 24 Zeil

[PATCH 4/8] bttv: rename field 'audio' in struct 'bttv' to 'audio_input'

2013-03-21 Thread Frank Schäfer
'audio_input' better describes the meaning of this field. Signed-off-by: Frank Schäfer Acked-by: Hans Verkuil --- drivers/media/pci/bt8xx/bttv-cards.c |2 +- drivers/media/pci/bt8xx/bttv-driver.c | 12 ++-- drivers/media/pci/bt8xx/bttvp.h |2 +- 3 Dateien geändert, 8 Ze

[PATCH 2/8] bttv: audio_mux(): do not change the value of the v4l2 mute control

2013-03-21 Thread Frank Schäfer
There are cases where we want to call audio_mux() without changing the value of the v4l2 mute control, for example - mute mute on last close - mute on device probing Signed-off-by: Frank Schäfer Acked-by: Hans Verkuil --- drivers/media/pci/bt8xx/bttv-driver.c |8 1 Datei geändert,

[PATCH 3/8] bttv: do not save the audio input in audio_mux()

2013-03-21 Thread Frank Schäfer
We can't and do not save the mute setting in function audio_mux(), so we should also not save the input in this function for consistency. Signed-off-by: Frank Schäfer Acked-by: Hans Verkuil --- drivers/media/pci/bt8xx/bttv-driver.c | 10 +- 1 Datei geändert, 5 Zeilen hinzugefügt(+), 5

[PATCH 0/8] bttv: refactor audio_mux() and fix muting/unmuting

2013-03-21 Thread Frank Schäfer
This patch series refactors function audio_mux() and fixes several issues related to muting/unmuting on probing and first open. Mute on last close will be fixed with further patches which are currently under review. Tested with a Hauppauge WinTV Theatre (model 37284, Rev B421). Frank Schäfer

[PATCH 1/8] bttv: audio_mux(): use a local variable "gpio_mute" instead of modifying the function parameter "mute"

2013-03-21 Thread Frank Schäfer
Function audio_mux() actually deals with two types of mute: gpio mute and subdevice muting. This patch claryfies the meaning of these values, but mainly prepares the code for the next patch. Signed-off-by: Frank Schäfer Acked-by: Hans Verkuil --- drivers/media/pci/bt8xx/bttv-driver.c |8 ++

Re: [RFC PATCH 09/10] bttv: fix mute on last close of the video device node

2013-03-21 Thread Frank Schäfer
Am 21.03.2013 11:56, schrieb Hans Verkuil: > On Wed 20 March 2013 20:24:49 Frank Schäfer wrote: >> Instead of applying the current mute setting on last device node close, >> always >> mute the device. > I am very pleased with the preceding 8 patches. That does exactly what I had > in mind. For thi

Re: em28xx: commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke HVR 900

2013-03-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Mar 2013 16:34:13 +0100 Hans Verkuil escreveu: > On Thu March 21 2013 11:03:27 Mauro Carvalho Chehab wrote: > > Em Thu, 21 Mar 2013 09:33:41 +0100 > > Hans Verkuil escreveu: > > > > > I tried to use my HVR 900 stick today and discovered that it no longer > > > worked. > > > I traced

Re: [PATCH] net: add ETH_P_802_3_MIN

2013-03-21 Thread David Miller
From: Simon Horman Date: Thu, 21 Mar 2013 17:29:28 +0900 > Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for > an 802.3 frame. Frames with a lower value in the ethernet type field > are Ethernet II. > > Also update all the users of this value that I could find to use the > new co

Re: em28xx: commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke HVR 900

2013-03-21 Thread Hans Verkuil
On Thu March 21 2013 11:03:27 Mauro Carvalho Chehab wrote: > Em Thu, 21 Mar 2013 09:33:41 +0100 > Hans Verkuil escreveu: > > > I tried to use my HVR 900 stick today and discovered that it no longer > > worked. > > I traced it to commit aab3125c43d8fecc7134e5f1e729fabf4dd196da: "em28xx: add > > s

Re: "./build --main-git" failed

2013-03-21 Thread Mauro Carvalho Chehab
Em Wed, 20 Mar 2013 08:17:48 -0700 escreveu: > Dear linux-media, > > I'm getting a fatal error with the "./build --main-git" command (see log > below). > Please help! The main branch got renamed. Just added a quick fix. Please test. -- Cheers, Mauro -- To unsubscribe from this list: send the

Re: [PATCH] net: add ETH_P_802_3_MIN

2013-03-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Mar 2013 17:29:28 +0900 Simon Horman escreveu: > Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for > an 802.3 frame. Frames with a lower value in the ethernet type field > are Ethernet II. > > Also update all the users of this value that I could find to use the > new c

Re: uvcvideo USERPTR mode busted?

2013-03-21 Thread Devin Heitmueller
On Thu, Mar 21, 2013 at 8:41 AM, Laurent Pinchart wrote: > Please submit it at some point :-) > > Is it a uvcvideo issue or a videobuf2 issue ? Yeah, it's definitely on my list. Basically if you hand videobuf2-vmalloc a piece of memory that is not page aligned, it gets treated as if paged aligne

Re: [PATCH] net: add ETH_P_802_3_MIN

2013-03-21 Thread Stefan Richter
On Mar 21 Simon Horman wrote: > Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for > an 802.3 frame. Frames with a lower value in the ethernet type field > are Ethernet II. > > Also update all the users of this value that I could find to use the > new constant. > > I anticipate add

Re: [PATCH 4/6] siano: remove the remaining CamelCase compliants

2013-03-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Mar 2013 14:18:11 +0100 Bjørn Mork escreveu: > Mauro Carvalho Chehab writes: > > > Remove the remaining CamelCase checkpatch.pl compliants. > > There are still a few left, but those are due to USB and > > DVB APIs. > [..] > > @@ -840,31 +840,31 @@ int smscore_configure_board(struct s

Re: [PATCH 1/6] siano: get rid of CammelCase from smscoreapi.h

2013-03-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Mar 2013 14:10:33 +0100 Bjørn Mork escreveu: > Mauro Carvalho Chehab writes: > > > It is almost impossible to see a compliant with checkpatch.pl > > on those Siano drivers, as there are simply too much violations > > on it. So, now that a big change was done, the better is to > > cle

Re: [PATCH 4/6] siano: remove the remaining CamelCase compliants

2013-03-21 Thread Bjørn Mork
Mauro Carvalho Chehab writes: > Remove the remaining CamelCase checkpatch.pl compliants. > There are still a few left, but those are due to USB and > DVB APIs. [..] > @@ -840,31 +840,31 @@ int smscore_configure_board(struct smscore_device_t > *coredev) > } > > if (board->mtu) { > -

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-21 Thread Fabio Porcedda
On Wed, Mar 20, 2013 at 12:46 PM, Arnd Bergmann wrote: > On Wednesday 20 March 2013, Fabio Porcedda wrote: >> >> On Wed, Mar 20, 2013 at 11:20 AM, Arnd Bergmann wrote: >> > On Wednesday 20 March 2013, Fabio Porcedda wrote: >> >> I think we can check inside the deferred_probe_work_func() >> >> if

Re: [PATCH 1/6] siano: get rid of CammelCase from smscoreapi.h

2013-03-21 Thread Bjørn Mork
Mauro Carvalho Chehab writes: > It is almost impossible to see a compliant with checkpatch.pl > on those Siano drivers, as there are simply too much violations > on it. So, now that a big change was done, the better is to > cleanup the checkpatch compliants. > > Let's first replace all CammelCase

[PATCH 4/6] siano: remove the remaining CamelCase compliants

2013-03-21 Thread Mauro Carvalho Chehab
Remove the remaining CamelCase checkpatch.pl compliants. There are still a few left, but those are due to USB and DVB APIs. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/siano/sms-cards.c | 4 +- drivers/media/common/siano/smscoreapi.c | 256 ++-

[PATCH 5/6] siano: Fix the remaining checkpatch.pl compliants

2013-03-21 Thread Mauro Carvalho Chehab
Fix all other remaining checkpatch.pl compliants on the Siano driver, except for the 80-cols (soft) limit. Those are harder to fix, and probably not worth to do right now. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/siano/smscoreapi.c | 15 +++ drivers/media/com

[PATCH 6/6] siano: make some functions static

2013-03-21 Thread Mauro Carvalho Chehab
drivers/media/common/siano/smsdvb-debugfs.c:51:6: warning: no previous prototype for 'smsdvb_print_dvb_stats' [-Wmissing-prototypes] drivers/media/common/siano/smsdvb-debugfs.c:154:6: warning: no previous prototype for 'smsdvb_print_isdb_stats' [-Wmissing-prototypes] drivers/media/common/siano/sm

[PATCH 2/6] siano: convert structure names to lowercase

2013-03-21 Thread Mauro Carvalho Chehab
There are several structures defined in uppercase. Convert them to lowercase, and simplify their names, when possible. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/siano/smscoreapi.h | 52 ++--- drivers/media/common/siano/smsdvb-debugfs.c | 6 ++-- d

[PATCH 3/6] [siano] fix checkpatch.pl compliants on smscoreapi.h

2013-03-21 Thread Mauro Carvalho Chehab
Fix the remaining checkpatch.pl compliants at smscoreapi.h, except by the "line over 80 characters" on comments. Fixing those would require more time, as the better is to convert them into the struct descriptions used inside the kernel, as described at: Documentation/kernel-doc-nano-HOWTO.t

Re: uvcvideo USERPTR mode busted?

2013-03-21 Thread Laurent Pinchart
On Sunday 03 March 2013 09:57:14 Devin Heitmueller wrote: > On Sun, Mar 3, 2013 at 4:37 AM, Rémi Denis-Courmont wrote: > > Hello, > > > > Trying to use USERPTR buffers with UVC, user space gets stuck either in > > poll(POLLIN) or in ioctl(VIDIOC_DQBUF). It seems the UVC driver never ever

Re: [PATCH] dvb-apps/scan: distinguish transponders with different polarisations

2013-03-21 Thread Adam Sampson
On Wed, Mar 06, 2013 at 12:11:45AM +, Adam Sampson wrote: > [scan] assumes that transponders can be uniquely identified by > frequency -- which is a reasonable assumption for DVB-T and DVB-C, but > not for DVB-S. > I've attached a patch that makes it check the polarisation, [...] Does anyone h

[PATCH 2/2] [media] siano: add MODULE_FIRMWARE() macros

2013-03-21 Thread Mauro Carvalho Chehab
This driver can use several firmwares. Provide such info at module firmware metadata. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/siano/smscoreapi.c | 24 drivers/media/common/siano/smscoreapi.h | 6 +- 2 files changed, 29 insertions(+), 1 deletion

[PATCH 1/2] [media] siano: use defines for firmware names

2013-03-21 Thread Mauro Carvalho Chehab
There are too many firmwares there. As we need to add MODULE_FIMWARE() macros, the better is to define their names on just one place and use the macros for both cards/device type tables and MODULE_FIRMWARE(). Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/siano/sms-cards.c | 14 +

Re: [RFC PATCH 09/10] bttv: fix mute on last close of the video device node

2013-03-21 Thread Hans Verkuil
On Wed 20 March 2013 20:24:49 Frank Schäfer wrote: > Instead of applying the current mute setting on last device node close, always > mute the device. I am very pleased with the preceding 8 patches. That does exactly what I had in mind. For this patch and the next (I would have combined those two

Re: [RFC PATCH 08/10] bttv: apply mute settings on open

2013-03-21 Thread Hans Verkuil
On Wed 20 March 2013 20:24:48 Frank Schäfer wrote: > Previously, this has been done implicitly for video device nodes by calling > set_input() (which calls audio_input() and also modified the mute > setting). > Since input and mute setting are now untangled (as much as possible), we need > to > ap

Re: [RFC PATCH 07/10] bttv: do not unmute the device before the first open

2013-03-21 Thread Hans Verkuil
On Wed 20 March 2013 20:24:47 Frank Schäfer wrote: Acked-by: Hans Verkuil Regards, Hans > Signed-off-by: Frank Schäfer > --- > drivers/media/pci/bt8xx/bttv-driver.c |4 +++- > 1 Datei geändert, 3 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) > > diff --git a/drivers/media/pci/bt8xx

Re: [RFC PATCH 06/10] bttv: untangle audio input and mute setting

2013-03-21 Thread Hans Verkuil
On Wed 20 March 2013 20:24:46 Frank Schäfer wrote: > Split function audio_mux(): > move the mute setting part to function audio_mute() and the input setting part > to function audio_input(). Acked-by: Hans Verkuil Regards, Hans > Signed-off-by: Frank Schäfer > --- > drivers/media/pci

Re: [PATCH v2 3/8] drivers: char: use module_platform_driver_probe()

2013-03-21 Thread Herbert Xu
On Thu, Mar 14, 2013 at 06:09:33PM +0100, Fabio Porcedda wrote: > This patch converts the drivers to use the > module_platform_driver_probe() macro which makes the code smaller and > a bit simpler. > > Signed-off-by: Fabio Porcedda > Cc: Greg Kroah-Hartman > Cc: Matt Mackall > Cc: Herbert Xu >

Re: [RFC PATCH 05/10] bttv: separate GPIO part from function audio_mux()

2013-03-21 Thread Hans Verkuil
On Wed 20 March 2013 20:24:45 Frank Schäfer wrote: > Move the GPIO part of function audio_mux() to a separate function > audio_mux_gpio(). > This prepares the code for the next patch which will separate mute and input > setting. Acked-by: Hans Verkuil Regards, Hans > Signed-off-by: Fra

Re: [RFC PATCH 04/10] bttv: rename field 'audio' in struct 'bttv' to 'audio_input'

2013-03-21 Thread Hans Verkuil
On Wed 20 March 2013 20:24:44 Frank Schäfer wrote: > 'audio_input' better describes the meaning of this field. Acked-by: Hans Verkuil Regards, Hans > Signed-off-by: Frank Schäfer > --- > drivers/media/pci/bt8xx/bttv-cards.c |2 +- > drivers/media/pci/bt8xx/bttv-driver.c | 12 +

Re: [RFC PATCH 03/10] bttv: do not save the audio input in audio_mux()

2013-03-21 Thread Hans Verkuil
On Wed 20 March 2013 20:24:43 Frank Schäfer wrote: > We can't and do not save the mute setting in function audio_mux(), so we > should also not save the input in this function for consistency. Acked-by: Hans Verkuil Regards, Hans > > Signed-off-by: Frank Schäfer > --- > drivers/medi

Re: [RFC PATCH 02/10] bttv: audio_mux(): do not change the value of the v4l2 mute control

2013-03-21 Thread Hans Verkuil
On Wed 20 March 2013 20:24:42 Frank Schäfer wrote: > There are cases where we want to call audio_mux() without changing the value > of > the v4l2 mute control, for example > - mute mute on last close > - mute on device probing Acked-by: Hans Verkuil Regards, Hans > Signed-off-by: Fran

Re: [RFC PATCH 01/10] bttv: audio_mux(): use a local variable "gpio_mute" instead of modifying the function parameter "mute"

2013-03-21 Thread Hans Verkuil
On Wed 20 March 2013 20:24:41 Frank Schäfer wrote: > Function audio_mux() actually deals with two types of mute: gpio mute and > subdevice muting. > This patch claryfies the meaning of these values, but mainly prepares the > code for > the next patch. > > Signed-off-by: Frank Schäfer Acked-by:

Re: em28xx: commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke HVR 900

2013-03-21 Thread Hans Verkuil
On Thu 21 March 2013 11:03:27 Mauro Carvalho Chehab wrote: > Em Thu, 21 Mar 2013 09:33:41 +0100 > Hans Verkuil escreveu: > > > I tried to use my HVR 900 stick today and discovered that it no longer > > worked. > > I traced it to commit aab3125c43d8fecc7134e5f1e729fabf4dd196da: "em28xx: add > > s

Re: [PATCH v2 3/8] drivers: char: use module_platform_driver_probe()

2013-03-21 Thread Herbert Xu
On Thu, Mar 21, 2013 at 11:15:26AM +0100, Fabio Porcedda wrote: > On Thu, Mar 21, 2013 at 10:55 AM, Herbert Xu > wrote: > > On Thu, Mar 14, 2013 at 06:09:33PM +0100, Fabio Porcedda wrote: > >> This patch converts the drivers to use the > >> module_platform_driver_probe() macro which makes the code

Re: [PATCH v2 3/8] drivers: char: use module_platform_driver_probe()

2013-03-21 Thread Fabio Porcedda
On Thu, Mar 21, 2013 at 10:55 AM, Herbert Xu wrote: > On Thu, Mar 14, 2013 at 06:09:33PM +0100, Fabio Porcedda wrote: >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler. >> >> Signed-off-by: Fabio Porcedda >> Cc:

Re: em28xx: commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke HVR 900

2013-03-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Mar 2013 09:33:41 +0100 Hans Verkuil escreveu: > I tried to use my HVR 900 stick today and discovered that it no longer worked. > I traced it to commit aab3125c43d8fecc7134e5f1e729fabf4dd196da: "em28xx: add > support for registering multiple i2c buses". > > The kernel messages for whe

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-21 Thread Prabhakar Lad
Anatolij, On Thu, Mar 21, 2013 at 2:40 PM, Anatolij Gustschin wrote: > On Thu, 21 Mar 2013 13:49:50 +0530 > Prabhakar Lad wrote: > ... >> > drivers/media/v4l2-core/Makefile |2 +- >> > drivers/media/v4l2-core/v4l2-clk.c | 184 >> > >> > include/media

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-21 Thread Anatolij Gustschin
On Thu, 21 Mar 2013 13:49:50 +0530 Prabhakar Lad wrote: ... > > drivers/media/v4l2-core/Makefile |2 +- > > drivers/media/v4l2-core/v4l2-clk.c | 184 > > > > include/media/v4l2-clk.h | 55 +++ > > 3 files changed, 240 insertions(+),

em28xx: commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke HVR 900

2013-03-21 Thread Hans Verkuil
I tried to use my HVR 900 stick today and discovered that it no longer worked. I traced it to commit aab3125c43d8fecc7134e5f1e729fabf4dd196da: "em28xx: add support for registering multiple i2c buses". The kernel messages for when it fails are: Mar 21 09:26:54 telek kernel: [ 1393.446606] em28xx:

[PATCH] net: add ETH_P_802_3_MIN

2013-03-21 Thread Simon Horman
Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for an 802.3 frame. Frames with a lower value in the ethernet type field are Ethernet II. Also update all the users of this value that I could find to use the new constant. I anticipate adding some more users of this constant when addi

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-21 Thread Prabhakar Lad
Hi Guennadi, On Sat, Mar 16, 2013 at 2:57 AM, Guennadi Liakhovetski wrote: > Typical video devices like camera sensors require an external clock source. > Many such devices cannot even access their hardware registers without a > running clock. These clock sources should be controlled by their con