Re: [REVIEW PATCH 4/5] v4l2: add const to argument of write-only s_register ioctl.

2013-03-15 Thread Guennadi Liakhovetski
On Fri, 15 Mar 2013, Hans Verkuil wrote: > From: Hans Verkuil > > This ioctl is defined as IOW, so pass the argument as const. > > Signed-off-by: Hans Verkuil > --- [snip] > drivers/media/i2c/soc_camera/mt9m001.c |2 +- > drivers/media/i2c/soc_camera/mt9m111.c |2 +

Re: [REVIEW PATCH 3/5] v4l2: pass std by value to the write-only s_std ioctl.

2013-03-15 Thread Guennadi Liakhovetski
Hi Hans On Fri, 15 Mar 2013, Hans Verkuil wrote: > From: Hans Verkuil > > This ioctl is defined as IOW, so pass the argument by value instead of by > reference. I could have chosen to add const instead, but this is 1) easier > to handle in drivers and 2) consistent with the s_std subdev operati

[PATCH v6 0/7] V4L2 clock and async patches and soc-camera example

2013-03-15 Thread Guennadi Liakhovetski
Update of V4l2 clock and asynchronous probing patches. Various review comments are addressed, as described in individual patches. Guennadi Liakhovetski (7): media: V4L2: add temporary clock helpers media: V4L2: support asynchronous subdevice registration media: soc-camera: switch I2C subdev

[PATCH v6 7/7] ARM: shmobile: convert ap4evb to asynchronously register camera subdevices

2013-03-15 Thread Guennadi Liakhovetski
Register the imx074 camera I2C and the CSI-2 platform devices directly in board platform data instead of letting the sh_mobile_ceu_camera driver and the soc-camera framework register them at their run-time. This uses the V4L2 asynchronous subdevice probing capability. Signed-off-by: Guennadi Liakh

[PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-15 Thread Guennadi Liakhovetski
Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers without a running clock. These clock sources should be controlled by their consumers. This should be performed, using the generic clock framework. Unfortunately

[PATCH v6 2/7] media: V4L2: support asynchronous subdevice registration

2013-03-15 Thread Guennadi Liakhovetski
Currently bridge device drivers register devices for all subdevices synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor is attached to a video bridge device, the bridge driver will create an I2C device and wait for the respective I2C driver to probe. This makes linking of dev

[PATCH v6 3/7] media: soc-camera: switch I2C subdevice drivers to use v4l2-clk

2013-03-15 Thread Guennadi Liakhovetski
Instead of centrally enabling and disabling subdevice master clocks in soc-camera core, let subdevice drivers do that themselves, using the V4L2 clock API and soc-camera convenience wrappers. Signed-off-by: Guennadi Liakhovetski --- v6: clock name update drivers/media/i2c/soc_camera/imx074.c

[PATCH v6 4/7] soc-camera: add V4L2-async support

2013-03-15 Thread Guennadi Liakhovetski
Add support for asynchronous subdevice probing, using the v4l2-async API. The legacy synchronous mode is still supported too, which allows to gradually update drivers and platforms. The selected approach adds a notifier for each struct soc_camera_device instance, i.e. for each video device node, ev

[PATCH v6 6/7] imx074: support asynchronous probing

2013-03-15 Thread Guennadi Liakhovetski
Both synchronous and asynchronous imx074 subdevice probing is supported by this patch. Signed-off-by: Guennadi Liakhovetski --- v6: update to new v4l2-async API, use soc_camera_power_init() drivers/media/i2c/soc_camera/imx074.c | 24 +--- 1 files changed, 21 insertions(+)

[PATCH v6 5/7] sh_mobile_ceu_camera: add asynchronous subdevice probing support

2013-03-15 Thread Guennadi Liakhovetski
Use the v4l2-async API to support asynchronous subdevice probing, including the CSI2 subdevice. Synchronous probing is still supported too. Signed-off-by: Guennadi Liakhovetski --- v6: update to the new v4l2-async API .../platform/soc_camera/sh_mobile_ceu_camera.c | 136 -

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, H Hartley Sweeten wrote: > Arnd, > > Ill look at converting the ep93xx pwm driver to the PWM subsystem. The only > issue is > the current driver exposes a sysfs interface that I think is not available in > that subsystem. You can probably keep providing that interface i

cron job: media_tree daily build: WARNINGS

2013-03-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Mar 15 19:00:21 CET 2013 git branch: test git hash: 4d35435d3ffb853b491f5bb21a62529cd925d660 gcc versio

Re: DVB memory leak?

2013-03-15 Thread Devin Heitmueller
On Fri, Mar 15, 2013 at 2:45 PM, Moasat wrote: > Thanks for looking into it. It wouldn't surprise me to find out that Myth is > not checking the error condition. But even if it did, would that keep the > card functioning? No, it would not keep the card functioning. But you would at least not

Re: msp3400 problem in linux-3.7.0

2013-03-15 Thread Benjamin Schindler
Hi I think I've just been really stupid. I tried latest git, but got not sound. I then checked my volumes again and noticed, that the rear-mic channel was muted. I didn't have that channel in 3.2 (just had mic) so I didn't notice... So may be sound wasn't broken after all in vanilla. Would i

Re: DVB memory leak?

2013-03-15 Thread Moasat
>From: "Devin Heitmueller" >To: moa...@moasat.dyndns.org >Cc: linux-media@vger.kernel.org >Sent: Friday, March 15, 2013 11:06:28 AM >Subject: Re: DVB memory leak? > >On Fri, Mar 15, 2013 at 11:19 AM, wrote: >> I've been fighting a situation where the kernel appears to be running out of >> memor

Re: [PATCH v2 8/8] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread Greg Kroah-Hartman
On Thu, Mar 14, 2013 at 06:09:38PM +0100, Fabio Porcedda wrote: > This patch converts the drivers to use the > module_platform_driver_probe() macro which makes the code smaller and > a bit simpler. Someone else beat you to this fix for these files, sorry. greg k-h -- To unsubscribe from this list

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread Fabio Porcedda
On Fri, Mar 15, 2013 at 12:28 PM, Arnd Bergmann wrote: > On Friday 15 March 2013, Fabio Porcedda wrote: >> >> * Regarding the use of module_platform_driver_probe, I'm a little worried >> >> about >> >> the interactions with deferred probing. I don't think there are any >> >> regressions, >> >>

RE: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread H Hartley Sweeten
On Thursday, March 14, 2013 6:58 AM, Arnd Bergmann wrote: > On Thursday 14 March 2013, Fabio Porcedda wrote: >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler. >> >> Signed-off-by: Fabio Porcedda >> Cc: Greg Kro

Re: [RFC PATCH v2 2/6] bttv: audio_mux(): do not change the value of the v4l2 mute control

2013-03-15 Thread Frank Schäfer
Hi Hans, thank you for reviewing and sorry for the delayed reply ! Am 12.03.2013 14:41, schrieb Hans Verkuil: > On Sun 10 March 2013 22:53:50 Frank Schäfer wrote: >> There are cases where we want to call audio_mux() without changing the value >> of >> the v4l2 mute control, for example >> - mute

Re: [PATCH] [media] ir: IR_RX51 only works on OMAP2

2013-03-15 Thread Tony Lindgren
* Timo Kokkonen [130314 23:43]: > On 03.14 2013 22:56:44, Arnd Bergmann wrote: > > This driver can be enabled on OMAP1 at the moment, which breaks > > allyesconfig for that platform. Let's mark it OMAP2PLUS-only > > in Kconfig, since that is the only thing it builds on. > > > > Acked-by: Timo Ko

Re: DVB memory leak?

2013-03-15 Thread Devin Heitmueller
On Fri, Mar 15, 2013 at 11:19 AM, wrote: > I've been fighting a situation where the kernel appears to be running out of > memory over a period of time. I originally had my low address space reserve > set to 4096 and memory compaction on. I would get this error within a few > days of reboot:

DVB memory leak?

2013-03-15 Thread moasat
I've been fighting a situation where the kernel appears to be running out of memory over a period of time. I originally had my low address space reserve set to 4096 and memory compaction on. I would get this error within a few days of reboot: Mar 06 19:25:03 [kernel] [168311.801139] DVBRead:

Re: [REVIEW PATCH 3/5] v4l2: pass std by value to the write-only s_std ioctl.

2013-03-15 Thread Hans Verkuil
On Fri March 15 2013 14:58:35 Mauro Carvalho Chehab wrote: > Em Fri, 15 Mar 2013 11:27:23 +0100 > Hans Verkuil escreveu: > > > From: Hans Verkuil > > > > This ioctl is defined as IOW, so pass the argument by value instead of by > > reference. I could have chosen to add const instead, but this i

Re: [REVIEW PATCH 3/5] v4l2: pass std by value to the write-only s_std ioctl.

2013-03-15 Thread Jonathan Corbet
On Fri, 15 Mar 2013 11:27:23 +0100 Hans Verkuil wrote: > diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c > b/drivers/media/platform/marvell-ccic/mcam-core.c > index 92a33f0..76a8623 100644 > --- a/drivers/media/platform/marvell-ccic/mcam-core.c > +++ b/drivers/media/platform/marvell

Re: [RFC V1 5/8] smi2021: Add smi2021_video.c

2013-03-15 Thread Ezequiel Garcia
On Thu, Mar 14, 2013 at 03:07:01PM +0100, Jon Arne Jørgensen wrote: > This file is responsible for all communication with the video hardware > and also starting and stopping the capture. > > It also contains the setup and handling of the usb ISOCHRONOUS transfers. > > Signed-off-by: Jon Arne Jørg

Re: [RFC V1 4/8] smi2021: Add smi2021_v4l2.c

2013-03-15 Thread Ezequiel Garcia
On Thu, Mar 14, 2013 at 03:07:00PM +0100, Jon Arne Jørgensen wrote: > This file is responsible for registering the device with the v4l2 subsystem, > and the communication with v4l2. > Most of the v4l2 ioctls are just passed on to vidbuf2. > > Signed-off-by: Jon Arne Jørgensen > --- > drivers/med

Re: [RFC V1 3/8] smi2021: Add smi2021_i2c.c

2013-03-15 Thread Ezequiel Garcia
On Thu, Mar 14, 2013 at 03:06:59PM +0100, Jon Arne Jørgensen wrote: > This file is responsible for registering the device > with the kernel i2c subsystem. > v4l2 talks to the saa7113 chip of the device via i2c. > > Signed-off-by: Jon Arne Jørgensen > --- > drivers/media/usb/smi2021/smi2021_i2c.c

Re: [REVIEW PATCH 5/5] v4l2-ioctl: simplify debug code.

2013-03-15 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 15 March 2013 11:27:25 Hans Verkuil wrote: > From: Hans Verkuil > > The core debug code can now be simplified since all the write-only ioctls > are now const and will not modify the data they pass to the drivers. > > So instead of logging write-only ioc

Re: [REVIEW PATCH 4/5] v4l2: add const to argument of write-only s_register ioctl.

2013-03-15 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 15 March 2013 11:27:24 Hans Verkuil wrote: > From: Hans Verkuil > > This ioctl is defined as IOW, so pass the argument as const. > > Signed-off-by: Hans Verkuil [snip] > diff --git a/drivers/media/pci/ivtv/ivtv-ioctl.c > b/drivers/media/pci/ivtv/ivtv

Re: [RFC V1 2/8] smi2021: Add smi2021_main.c

2013-03-15 Thread Ezequiel Garcia
On Thu, Mar 14, 2013 at 03:06:58PM +0100, Jon Arne Jørgensen wrote: > This is the core of the smi2021 module. > It will register the module with the kernel, and register the > usb probe function. > > Signed-off-by: Jon Arne Jørgensen > --- > drivers/media/usb/smi2021/smi2021_main.c | 339 >

Re: [REVIEW PATCH 1/5] v4l2: add const to argument of write-only s_frequency ioctl.

2013-03-15 Thread Hans Verkuil
On Fri March 15 2013 13:08:23 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 15 March 2013 11:27:21 Hans Verkuil wrote: > > From: Hans Verkuil > > > > This ioctl is defined as IOW, so pass the argument as const. > > > > Signed-off-by: Hans Verkuil > > [snip] > >

Re: [REVIEW PATCH 3/5] v4l2: pass std by value to the write-only s_std ioctl.

2013-03-15 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 15 March 2013 11:27:23 Hans Verkuil wrote: > From: Hans Verkuil > > This ioctl is defined as IOW, so pass the argument by value instead of by > reference. I could have chosen to add const instead, but this is 1) easier > to handle in drivers and 2) consi

Re: [RFC V1 1/8] smi2021: Add the header file

2013-03-15 Thread Ezequiel Garcia
On Thu, Mar 14, 2013 at 03:06:57PM +0100, Jon Arne Jørgensen wrote: > This is the header file for the smi2021 module. > > Signed-off-by: Jon Arne Jørgensen > --- > drivers/media/usb/smi2021/smi2021.h | 228 > > 1 file changed, 228 insertions(+) > create mod

Re: [REVIEW PATCH 2/5] v4l2: add const to argument of write-only s_tuner ioctl.

2013-03-15 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 15 March 2013 11:27:22 Hans Verkuil wrote: > From: Hans Verkuil > > This ioctl is defined as IOW, so pass the argument as const. > > Signed-off-by: Hans Verkuil Acked-by: Laurent Pinchart -- Regards, Laurent Pinchart -- To unsubscribe from this l

Re: [RFC V1 0/8] Add a driver for somagic smi2021

2013-03-15 Thread Ezequiel Garcia
On Thu, Mar 14, 2013 at 03:06:56PM +0100, Jon Arne Jørgensen wrote: > This patch-set will add a driver for the Somagic SMI2021 chip. > > This chip is found inside different usb video-capture devices. > Most of them are branded as EasyCap, but there also seems to be > some other brands selling devi

Re: dvb-apps: Additional channels for Netherlands

2013-03-15 Thread Oliver Schinagl
On 15-03-13 00:33, Dmitry Katsubo wrote: On 11.03.2013 13:10, Oliver Schinagl wrote: and what is interesting the comments refer to radio-stations only. TV zenderlijst is pure DVB-T frequencies. I have not found a single FM frequency there. Note that if you open it via their website, there are t

Re: [REVIEW PATCH 1/5] v4l2: add const to argument of write-only s_frequency ioctl.

2013-03-15 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 15 March 2013 11:27:21 Hans Verkuil wrote: > From: Hans Verkuil > > This ioctl is defined as IOW, so pass the argument as const. > > Signed-off-by: Hans Verkuil [snip] > diff --git a/drivers/media/radio/radio-isa.c > b/drivers/media/radio/radio-isa.c

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Fabio Porcedda wrote: > >> * Regarding the use of module_platform_driver_probe, I'm a little worried > >> about > >> the interactions with deferred probing. I don't think there are any > >> regressions, > >> but we should probably make people aware that one cannot ret

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread Fabio Porcedda
On Thu, Mar 14, 2013 at 3:06 PM, Sascha Hauer wrote: > On Thu, Mar 14, 2013 at 01:58:05PM +, Arnd Bergmann wrote: >> On Thursday 14 March 2013, Fabio Porcedda wrote: >> > This patch converts the drivers to use the >> > module_platform_driver_probe() macro which makes the code smaller and >> >

[REVIEW PATCH 4/5] v4l2: add const to argument of write-only s_register ioctl.

2013-03-15 Thread Hans Verkuil
From: Hans Verkuil This ioctl is defined as IOW, so pass the argument as const. Signed-off-by: Hans Verkuil --- drivers/media/dvb-frontends/au8522_decoder.c|2 +- drivers/media/i2c/ad9389b.c |2 +- drivers/media/i2c/adv7183.c |2 +- drive

[REVIEW PATCH 5/5] v4l2-ioctl: simplify debug code.

2013-03-15 Thread Hans Verkuil
From: Hans Verkuil The core debug code can now be simplified since all the write-only ioctls are now const and will not modify the data they pass to the drivers. So instead of logging write-only ioctls before the driver is called this can now be done afterwards, which is cleaner when it comes to

[REVIEW PATCH 0/5] v4l2: constify _IOW ioctls

2013-03-15 Thread Hans Verkuil
This is the second and last phase of ensuring that the arguments of write-only ioctls in V4L2 are const. The first phase was 4-5 months ago and added const to s_crop, s_modulator, s_audio, s_audout, (un)subscribe_event, s_freq_hw_seek, s_jpegcomp and s_fbuf. This second phase adds const to s_frequ

[REVIEW PATCH 1/5] v4l2: add const to argument of write-only s_frequency ioctl.

2013-03-15 Thread Hans Verkuil
From: Hans Verkuil This ioctl is defined as IOW, so pass the argument as const. Signed-off-by: Hans Verkuil --- drivers/media/i2c/cx25840/cx25840-core.c |2 +- drivers/media/i2c/msp3400-driver.c |2 +- drivers/media/i2c/tvaudio.c |2 +- dr

[REVIEW PATCH 3/5] v4l2: pass std by value to the write-only s_std ioctl.

2013-03-15 Thread Hans Verkuil
From: Hans Verkuil This ioctl is defined as IOW, so pass the argument by value instead of by reference. I could have chosen to add const instead, but this is 1) easier to handle in drivers and 2) consistent with the s_std subdev operation. Signed-off-by: Hans Verkuil --- drivers/media/common/s

[REVIEW PATCH 2/5] v4l2: add const to argument of write-only s_tuner ioctl.

2013-03-15 Thread Hans Verkuil
From: Hans Verkuil This ioctl is defined as IOW, so pass the argument as const. Signed-off-by: Hans Verkuil --- drivers/media/i2c/cx25840/cx25840-core.c |2 +- drivers/media/i2c/msp3400-driver.c |2 +- drivers/media/i2c/saa6588.c |2 +- dr

Re: msp3400 problem in linux-3.7.0

2013-03-15 Thread Hans Verkuil
On Fri March 15 2013 10:56:51 Benjamin Schindler wrote: > I just tried to apply the patch, but it does not apply cleanly: > > metis linux # patch -p1 < /home/benjamin/Downloads/bttv-patch.txt > patching file drivers/media/pci/bt8xx/bttv-driver.c > Hunk #1 FAILED at 2007. > Hunk #2 FAILED at 2024.

Re: msp3400 problem in linux-3.7.0

2013-03-15 Thread Benjamin Schindler
I just tried to apply the patch, but it does not apply cleanly: metis linux # patch -p1 < /home/benjamin/Downloads/bttv-patch.txt patching file drivers/media/pci/bt8xx/bttv-driver.c Hunk #1 FAILED at 2007. Hunk #2 FAILED at 2024. Hunk #3 succeeded at 4269 with fuzz 2 (offset 34 lines). Hunk #4 su