[PATCH] xc5000: fix incorrect debug printnk

2013-03-12 Thread Dmitri Belimov
Hello I found very small bag in xc5000 source. When set option debug=1 and listen a radio we see in dmesg xc5000: xc_SetTVStandard() Standard = M/N-NTSC/PAL-BTSC at all time. But true value is "FM Radio-INPUT1_MONO". It happens because in function xc5000_set_radio_freq get correct value Vide

Re: [RFC 12/12] mipi-csis: Enable all interrupts for fimc-is usage

2013-03-12 Thread Arun Kumar K
Hi Sylwester, >> >> /* Interrupt mask */ >> #define S5PCSIS_INTMSK 0x10 >> -#define S5PCSIS_INTMSK_EN_ALL0xf000103f >> +#define S5PCSIS_INTMSK_EN_ALL0xfc00103f > > Do you know what interrupts are assigned to the CSIS_INTMSK > bits 26, 27 ? In

RE: [REVIEW PATCH V4 01/12] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2013-03-12 Thread Libin Yang
Hi Guennadi, >-Original Message- >From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] >Sent: Tuesday, March 12, 2013 6:08 PM >To: Libin Yang >Cc: Albert Wang; cor...@lwn.net; Linux Media Mailing List >Subject: RE: [REVIEW PATCH V4 01/12] [media] marvell-ccic: add MIPI support for >m

cron job: media_tree daily build: WARNINGS

2013-03-12 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 12 19:00:25 CET 2013 git branch: test git hash: 457ba4ce4f435d0b4dd82a0acc6c796e541a2ea7 gcc versio

[PATCH] media: fix hdpvr build warning

2013-03-12 Thread Randy Dunlap
From: Randy Dunlap Fix build warning in hdpvr: drivers/media/usb/hdpvr/hdpvr-video.c: warning: "CONFIG_I2C_MODULE" is not defined [-Wundef] Signed-off-by: Randy Dunlap Reported-by: Geert Uytterhoeven Cc: Janne Grunau --- drivers/media/usb/hdpvr/hdpvr-video.c |2 +- 1 file changed, 1 in

V4L2 subdevice naming (was Re: [PATCH 1/6 v4] media: V4L2: support asynchronous subdevice registration)

2013-03-12 Thread Guennadi Liakhovetski
Hi all (this is a _conscious_ case of top-posting, hopefully a justified one :-) ) The discussion, I'd like to continue here is pretty old (2 months), so, instead of asking everyone to go and re-read the thread, I'll try to summarise the problem here and encourage everyone to contribute to a fi

[PATCH v4] media: V4L2: add temporary clock helpers

2013-03-12 Thread Guennadi Liakhovetski
Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers without a running clock. These clock sources should be controlled by their consumers. This should be performed, using the generic clock framework. Unfortunately

Re: [RFC 12/12] mipi-csis: Enable all interrupts for fimc-is usage

2013-03-12 Thread Sylwester Nawrocki
Hi Arun, On 03/08/2013 03:59 PM, Arun Kumar K wrote: > FIMC-IS firmware needs all the MIPI-CSIS interrupts to be enabled. > This patch enables all those MIPI interrupts. > > Signed-off-by: Arun Kumar K > --- > drivers/media/platform/s5p-fimc/mipi-csis.c |2 +- > 1 file changed, 1 insertion(

Re: [PATCH 2/2] hverkuil/go7007: staging: media: go7007: rmmod firmware protection stuff

2013-03-12 Thread Hans Verkuil
On Tue 12 March 2013 16:09:30 Volokh Konstantin wrote: > If firmware wasn`t load, rmmod fail with oops: > > usbcore: deregistering interface driver go7007 > BUG: unable to handle kernel NULL pointer dereference at (null) > IP: [] __mutex_lock_slowpath+0xa2/0x140 > PGD 13143b067 PUD 132a5

Re: [PATCH 1/2] hverkuil/go7007: staging: media: go7007: Restore b_frame control

2013-03-12 Thread Hans Verkuil
On Tue 12 March 2013 16:09:29 Volokh Konstantin wrote: > Signed-off-by: Volokh Konstantin Just wondering: did you test this? If you get the latest v4l-utils code and run: v4l2-ctl --stream-mmap=3 (first set the format to MPEG2) you should see B frames appearing. > --- > drivers/staging/media

[PATCH 2/2] hverkuil/go7007: staging: media: go7007: rmmod firmware protection stuff

2013-03-12 Thread Volokh Konstantin
If firmware wasn`t load, rmmod fail with oops: usbcore: deregistering interface driver go7007 BUG: unable to handle kernel NULL pointer dereference at (null) IP: [] __mutex_lock_slowpath+0xa2/0x140 PGD 13143b067 PUD 132a52067 PMD 0 Oops: 0002 [#1] SMP Modules linked in: go7007_usb(C-) go

[PATCH 1/2] hverkuil/go7007: staging: media: go7007: Restore b_frame control

2013-03-12 Thread Volokh Konstantin
Signed-off-by: Volokh Konstantin --- drivers/staging/media/go7007/go7007-priv.h |1 + drivers/staging/media/go7007/go7007-v4l2.c |7 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/go7007/go7007-priv.h b/drivers/staging/media/go7007/go7007-pri

Re: [PATCH 1/1] [media] timblogiw: Fix sparse warning

2013-03-12 Thread Sachin Kamat
On 19 February 2013 17:30, Sachin Kamat wrote: > Fixes the below warning: > drivers/media/platform/timblogiw.c:81:31: warning: > symbol 'timblogiw_tvnorms' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat ping.. > --- > drivers/media/platform/timblogiw.c |2 +- > 1 f

Re: [REVIEW PATCH 00/42] go7007: complete overhaul

2013-03-12 Thread Hans Verkuil
On Tue 12 March 2013 15:37:03 Darrick Burch wrote: > > This week I'll also receive a Plextor PX-M402U to test with and an ADS DVD > > XPress DX2 is also on its way (I did some ebay shopping!). > > As it happens I've been working with the DVD Xpress DX2. I found a patch > floating around the Inter

Re: [REVIEW PATCH 00/42] go7007: complete overhaul

2013-03-12 Thread Darrick Burch
> This week I'll also receive a Plextor PX-M402U to test with and an ADS DVD > XPress DX2 is also on its way (I did some ebay shopping!). As it happens I've been working with the DVD Xpress DX2. I found a patch floating around the Internet, with the needed code to add support for it, but I was ch

Re: [RFC PATCH 5/8] s5p-fimc: Add ISP video capture driver stubs

2013-03-12 Thread Hans Verkuil
On Mon 11 March 2013 20:44:49 Sylwester Nawrocki wrote: > This patch adds a video capture node for the FIMC-IS ISP IP block > and Makefile/Kconfig to actually enable the driver's compilation. > > The ISP video capture driver is still a work in progress. > > Signed-off-by: Sylwester Nawrocki > Si

Re: [RFC PATCH 1/8] s5p-fimc: Add Exynos4x12 FIMC-IS driver

2013-03-12 Thread Hans Verkuil
On Mon 11 March 2013 20:44:45 Sylwester Nawrocki wrote: > This patch adds a set of core files of the Exynos4x12 FIMC-IS > V4L2 driver. This includes main functionality like allocating > memory, loading the firmware, FIMC-IS register interface and > host CPU <-> IS command and error code definitions

[GIT PULL] 3.10 minor updates

2013-03-12 Thread Guennadi Liakhovetski
Hi Mauro Here go a couple of minor updates for 3.10, just to get them upstream out of my mailbox :) The following changes since commit 84c73929c71764075cbe6f7f39fbe746fcd25d99: Add linux-next specific files for 20130312 (2013-03-12 15:45:33 +1100) are available in the git repository at

[GIT PULL] soc-camera fixes for 3.9 / stable

2013-03-12 Thread Guennadi Liakhovetski
Hi Mauro All these patches are fixes and are also good for stable, of them the patch from me "fix Oops" should only go back as far as 3.7. The following changes since commit 7c6baa304b841673d3a55ea4fcf9a5cbf7a1674b: Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/k

Re: [RFC 04/12] s5p-csis: Adding Exynos5250 compatibility

2013-03-12 Thread Sylwester Nawrocki
Hi Shaik, On 03/11/2013 07:58 AM, Shaik Ameer Basha wrote: > Hi Sylwester, > > On Mon, Mar 11, 2013 at 2:10 AM, Sylwester Nawrocki > wrote: >> On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> Please don't leave the change log empty. I'll apply this patch. >> I'm just wondering, if there ar

Re: [RFC PATCH v2 2/6] bttv: audio_mux(): do not change the value of the v4l2 mute control

2013-03-12 Thread Hans Verkuil
On Sun 10 March 2013 22:53:50 Frank Schäfer wrote: > There are cases where we want to call audio_mux() without changing the value > of > the v4l2 mute control, for example > - mute mute on last close > - mute on device probing > > Signed-off-by: Frank Schäfer Acked-by: Hans Verkuil I think i

Re: [RFC PATCH v2 1/6] bttv: audio_mux() use a local variable "gpio_mute" instead of modifying the function parameter "mute"

2013-03-12 Thread Hans Verkuil
On Sun 10 March 2013 22:53:49 Frank Schäfer wrote: > Function audio_mux() actually deals with two types of mute: gpio mute and > subdevice muting. > This patch claryfies the meaning of these values, but mainly prepares the > code for > the next patch. > > Signed-off-by: Frank Schäfer Acked-by:

Re: omap3isp: iommu register problem.

2013-03-12 Thread Laurent Pinchart
Hi Javier, On Tuesday 12 March 2013 08:52:39 javier Martin wrote: > On 11 March 2013 21:51, Laurent Pinchart wrote: > > Hi Javier, > > > >> [2.706939] omap3isp omap3isp: Revision 15.0 found > >> [2.712402] omap_iommu_attach: 1 > >> [2.715942] omap_iommu_attach: 2 > >> [2.719329] o

[PATCH] mt9m111: fix Oops - initialise context before dereferencing

2013-03-12 Thread Guennadi Liakhovetski
A recent commit "[media] soc-camera: Push probe-time power management to drivers" causes an Oops during mt9m111 driver probing because its .ctx private data field is now dereferenced before it is initialised. Fix this by initialising the field earlier. Reported-by: Javier Martin Signed-off-by: Gu

Re: [PATCH v2] media: i.MX27 camera: fix picture source width

2013-03-12 Thread javier Martin
On 12 March 2013 10:39, Guennadi Liakhovetski wrote: > On Tue, 12 Mar 2013, javier Martin wrote: > >> Hi Guernnadi, Christoph, >> >> On 12 March 2013 09:25, Christoph Fritz wrote: >> > On Tue, 2013-03-12 at 08:58 +0100, Guennadi Liakhovetski wrote: >> >> On Thu, 7 Mar 2013, javier Martin wrote: >

RE: [REVIEW PATCH V4 01/12] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2013-03-12 Thread Guennadi Liakhovetski
Hi Libin On Tue, 12 Mar 2013, Libin Yang wrote: > Hi Guennadi, > > Thanks for your careful review. Please help see my comments below. > > >-Original Message- > >From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] > >Sent: Tuesday, March 05, 2013 5:35 AM > >To: Albert Wang > >Cc:

Re: [PATCH v2] media: i.MX27 camera: fix picture source width

2013-03-12 Thread Guennadi Liakhovetski
On Tue, 12 Mar 2013, javier Martin wrote: > Hi Guernnadi, Christoph, > > On 12 March 2013 09:25, Christoph Fritz wrote: > > On Tue, 2013-03-12 at 08:58 +0100, Guennadi Liakhovetski wrote: > >> On Thu, 7 Mar 2013, javier Martin wrote: > > > >> > What mbus format are you using? Could you please ch

RE: [REVIEW PATCH V4 01/12] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2013-03-12 Thread Libin Yang
Hi Guennadi, Thanks for your careful review. Please help see my comments below. >-Original Message- >From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] >Sent: Tuesday, March 05, 2013 5:35 AM >To: Albert Wang >Cc: cor...@lwn.net; Linux Media Mailing List; Libin Yang >Subject: Re: [

Re: [PATCH v2] media: i.MX27 camera: fix picture source width

2013-03-12 Thread javier Martin
Hi Guernnadi, Christoph, On 12 March 2013 09:25, Christoph Fritz wrote: > On Tue, 2013-03-12 at 08:58 +0100, Guennadi Liakhovetski wrote: >> On Thu, 7 Mar 2013, javier Martin wrote: > >> > What mbus format are you using? Could you please check if the s_width >> > value that your sensor mt9m001 re

Re: [PATCH v2] media: i.MX27 camera: fix picture source width

2013-03-12 Thread Christoph Fritz
On Tue, 2013-03-12 at 08:58 +0100, Guennadi Liakhovetski wrote: > On Thu, 7 Mar 2013, javier Martin wrote: > > What mbus format are you using? Could you please check if the s_width > > value that your sensor mt9m001 returns is correct? Remember it should > > be in pixels, not in bytes. > > Thank

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-12 Thread Sekhar Nori
On 3/12/2013 10:44 AM, Prabhakar Lad wrote: > Hi Sekhar, > > Thanks for the patch! few nits below > > also version number for patch is missing as this should have been v2 :) Missed that, sorry. > BTW this patch still is not present in media list. Not sure what is happening there. Its an open

Re: [PATCH v2] media: i.MX27 camera: fix picture source width

2013-03-12 Thread Guennadi Liakhovetski
Hi Javier On Thu, 7 Mar 2013, javier Martin wrote: > Hi, > sorry for the long delay. I missed this one. > > On 5 March 2013 18:56, Guennadi Liakhovetski wrote: > > (Javier's opinion requested) > > > > I'm no expert in i.MX27 hardware, would be great to have an ack from > > someone, intensively

Re: omap3isp: iommu register problem.

2013-03-12 Thread javier Martin
Hi Laurent, Guennadi, On 11 March 2013 21:51, Laurent Pinchart wrote: > Hi Javier, >> [2.706939] omap3isp omap3isp: Revision 15.0 found >> [2.712402] omap_iommu_attach: 1 >> [2.715942] omap_iommu_attach: 2 >> [2.719329] omap_iommu_attach: 3 >> [2.722778] omap_iommu_attach: 4 >

Re: [PATCH] [media] soc_camera: remove two outdated selects

2013-03-12 Thread Guennadi Liakhovetski
Hi Paul On Mon, 11 Mar 2013, Paul Bolle wrote: > Release v2.6.30 removed the MT9M001_PCA9536_SWITCH and > MT9V022_PCA9536_SWITCH Kconfig symbols, in commits > 36034dc325ecab63c8cfb992fbf9a1a8e94738a2 ("V4L/DVB (11032): mt9m001: > allow setting of bus width from board code") and > e958e27adeade7fa

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-12 Thread cstsai
Dear Sir, Please don't send update emails to me Whenever I need I can check from website Thanks & Regards, cstsai - Original Message - From: "Prabhakar Lad" To: "Sekhar Nori" Cc: "Russell King" ; ; "Mauro Carvalho Chehab" ; Sent: Tuesday, March 12, 2013 1:14 PM Subject: Re: [