Re: [PATCH 1/2] [RFC] video: exynos mipi dsi: Making Exynos MIPI Complaint with CDF

2013-01-02 Thread Sachin Kamat
Hi Vikas, Some nitpicks inline Subject: s/Complaint/Compliant On 2 January 2013 18:47, Vikas C Sajjan wrote: > From: Vikas Sajjan > Please add some description about this patch here. > Signed-off-by: Vikas Sajjan > --- > drivers/video/exynos/exynos_mipi_dsi.c| 46 > +

Re: DT bindings for subdevices

2013-01-02 Thread Prabhakar Lad
Hi Guennadi, Thanks for your response! On Wed, Jan 2, 2013 at 3:49 PM, Guennadi Liakhovetski wrote: > Hi Prabhakar > > On Wed, 2 Jan 2013, Prabhakar Lad wrote: > >> Hi, >> >> This is my first step towards DT support for media, Question might be >> bit amateur :) > > No worries, we're all doing o

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2013-01-02 Thread Matthew Gyurgyik
On 01/02/2013 03:59 PM, Antti Palosaari wrote: On 12/18/2012 05:08 AM, Matthew Gyurgyik wrote: I can test patches Tue and Wed this week. Afterwards, I probably won't be able to test anything until Dec 28th/29th as I will be away from my workstation. In regards to my issue compiling my kernel, i

Re: [PATCH 2/3] [media] s5p-mfc: Remove redundant 'break'

2013-01-02 Thread Sachin Kamat
Thanks Kamil. I assume you have 'Acked' this patch as well :) On 2 January 2013 23:59, Kamil Debski wrote: > Hi Sachin, > > Thank you for your patch. > > Best wishes, > -- > Kamil Debski > Linux Platform Group > Samsung Poland R&D Center > >> -Original Message- >> From: linux-media-ow...

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2013-01-02 Thread David Härdeman
On Tue, Dec 11, 2012 at 10:59:06PM +0200, Antti Palosaari wrote: >Yes, that is. I have said it "million" times I would like to see that >implemented as a one single 4 byte NEC, but it is currently what it >is. What I understand David Härdeman has done some work toward that >too, but it is not ready

Re: [PATCH 2/3] [media] winbond-cir: increase IR receiver resolution

2013-01-02 Thread David Härdeman
On Wed, Oct 24, 2012 at 10:22:41PM +0100, Sean Young wrote: >This is needed for carrier reporting. > >Signed-off-by: Sean Young >--- > drivers/media/rc/winbond-cir.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) Using a resolution of 2us rather than 10us means that the res

Re: [PATCH] mt9p031: Add support for regulators

2013-01-02 Thread Laurent Pinchart
Hi Guennadi, Thanks for the review. On Wednesday 02 January 2013 21:49:53 Guennadi Liakhovetski wrote: > On Wed, 2 Jan 2013, Laurent Pinchart wrote: > > Enable the regulators when powering the sensor up, and disable them when > > powering it down. > > > > The regulators are mandatory. Boards tha

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-02 Thread Sylwester Nawrocki
On 01/02/2013 06:10 AM, Dan Carpenter wrote: clk_get() returns NULL if CONFIG_HAVE_CLK is disabled. It's not a problem for this driver, as it never dereferences what's returned from clk_get(). It would have to include , which it doesn't and which would have clearly indicated abuse of the clock

Re: [PATCH v2 2/5] em28xx: respect the message size constraints for i2c transfers

2013-01-02 Thread Sascha Sommer
Hello Frank, Am Wed, 02 Jan 2013 22:25:10 +0100 schrieb Frank Schäfer : > Hi Sascha, > > Am 02.01.2013 21:45, schrieb Sascha Sommer: > > Hello, > > > > Am Sat, 22 Dec 2012 22:07:46 -0200 > > schrieb Mauro Carvalho Chehab : > > > >> Em Sun, 16 Dec 2012 19:23:28 +0100 > >> Frank Schäfer escreveu:

Re: [PATCH RFC v2 02/15] [media] Add a V4L2 OF parser

2013-01-02 Thread Sylwester Nawrocki
Hi Guennadi, On 01/02/2013 12:58 PM, Guennadi Liakhovetski wrote: --- /dev/null +++ b/drivers/media/v4l2-core/v4l2-of.c @@ -0,0 +1,249 @@ +/* + * V4L2 OF binding parsing library + * + * Copyright (C) 2012 Renesas Electronics Corp. + * Author: Guennadi Liakhovetski + * + * This program is free so

Re: [PATCH RFC v2 01/15] [media] Add common video interfaces OF bindings documentation

2013-01-02 Thread Guennadi Liakhovetski
Hi Sylwester On Wed, 2 Jan 2013, Sylwester Nawrocki wrote: > Hi Guennadi, > > On 01/02/2013 12:31 PM, Guennadi Liakhovetski wrote: > > Hi Sylwester > > > > Thanks for picking up these patches! In general both look good to me, just > > a couple of nit-picks, that I couldn't help remarking:-) >

Re: [PATCH v2 2/5] em28xx: respect the message size constraints for i2c transfers

2013-01-02 Thread Frank Schäfer
Am 02.01.2013 22:40, schrieb Antti Palosaari: > On 01/02/2013 11:29 PM, Frank Schäfer wrote: >> Am 02.01.2013 22:15, schrieb Antti Palosaari: >>> On 01/02/2013 11:12 PM, Frank Schäfer wrote: Hi Antti, Am 02.01.2013 20:29, schrieb Antti Palosaari: > On 12/24/2012 01:09 PM, Frank S

Re: [PATCH RFC v2 01/15] [media] Add common video interfaces OF bindings documentation

2013-01-02 Thread Sylwester Nawrocki
Hi Guennadi, On 01/02/2013 12:31 PM, Guennadi Liakhovetski wrote: Hi Sylwester Thanks for picking up these patches! In general both look good to me, just a couple of nit-picks, that I couldn't help remarking:-) Sure, thanks again for the feedback. On Mon, 31 Dec 2012, Sylwester Nawrocki wro

Re: [PATCH v2 2/5] em28xx: respect the message size constraints for i2c transfers

2013-01-02 Thread Antti Palosaari
On 01/02/2013 11:29 PM, Frank Schäfer wrote: Am 02.01.2013 22:15, schrieb Antti Palosaari: On 01/02/2013 11:12 PM, Frank Schäfer wrote: Hi Antti, Am 02.01.2013 20:29, schrieb Antti Palosaari: On 12/24/2012 01:09 PM, Frank Schäfer wrote: Am 23.12.2012 15:46, schrieb Mauro Carvalho Chehab: Em

Re: [PATCH RFC 05/17] fc0012: use struct for driver config

2013-01-02 Thread Hans-Frieder Vogt
Hello Antti, sorry that I didn't react earlier. Your patch series look very good to me. I am happy to aknowledge it. Acked-by: Hans-Frieder Vogt Am Dienstag, 1. Januar 2013 schrieb Antti Palosaari: > Hans-Frieder, > Care to ack fc0012 related changes from that patch serie? > > http://git.linu

cron job: media_tree daily build: ERRORS

2013-01-02 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Wed Jan 2 19:00:15 CET 2013 git hash:8cd7085ff460ead3aba6174052a408f4ad52ac36 gcc version: i686-linux-gcc (GCC

Re: [PATCH v2 2/5] em28xx: respect the message size constraints for i2c transfers

2013-01-02 Thread Frank Schäfer
Am 02.01.2013 22:15, schrieb Antti Palosaari: > On 01/02/2013 11:12 PM, Frank Schäfer wrote: >> Hi Antti, >> >> Am 02.01.2013 20:29, schrieb Antti Palosaari: >>> On 12/24/2012 01:09 PM, Frank Schäfer wrote: Am 23.12.2012 15:46, schrieb Mauro Carvalho Chehab: > Em Sun, 23 Dec 2012 14:58:12

Re: [PATCH v2 2/5] em28xx: respect the message size constraints for i2c transfers

2013-01-02 Thread Frank Schäfer
Hi Sascha, Am 02.01.2013 21:45, schrieb Sascha Sommer: > Hello, > > Am Sat, 22 Dec 2012 22:07:46 -0200 > schrieb Mauro Carvalho Chehab : > >> Em Sun, 16 Dec 2012 19:23:28 +0100 >> Frank Schäfer escreveu: >> >>> The em2800 can transfer up to 4 bytes per i2c message. >>> All other em25xx/em27xx/28x

Re: [PATCH 2/6] em28xx: refactor the code in em28xx_usb_disconnect()

2013-01-02 Thread Frank Schäfer
Am 02.01.2013 20:40, schrieb Antti Palosaari: > On 12/28/2012 01:02 AM, Frank Schäfer wrote: >> The main purpose of this patch is to move the call of >> em28xx_release_resources() >> after the call of em28xx_close_extension(). >> This is necessary, because some resources might be needed/used by the

Re: [PATCH v2 2/5] em28xx: respect the message size constraints for i2c transfers

2013-01-02 Thread Antti Palosaari
On 01/02/2013 11:12 PM, Frank Schäfer wrote: Hi Antti, Am 02.01.2013 20:29, schrieb Antti Palosaari: On 12/24/2012 01:09 PM, Frank Schäfer wrote: Am 23.12.2012 15:46, schrieb Mauro Carvalho Chehab: Em Sun, 23 Dec 2012 14:58:12 +0100 Frank Schäfer escreveu: Am 23.12.2012 01:07, schrieb Maur

Re: [PATCH v2 2/5] em28xx: respect the message size constraints for i2c transfers

2013-01-02 Thread Frank Schäfer
Hi Antti, Am 02.01.2013 20:29, schrieb Antti Palosaari: > On 12/24/2012 01:09 PM, Frank Schäfer wrote: >> Am 23.12.2012 15:46, schrieb Mauro Carvalho Chehab: >>> Em Sun, 23 Dec 2012 14:58:12 +0100 >>> Frank Schäfer escreveu: >>> Am 23.12.2012 01:07, schrieb Mauro Carvalho Chehab: > Em Su

Re: [PATCH v2 2/5] em28xx: respect the message size constraints for i2c transfers

2013-01-02 Thread Sascha Sommer
Hello, Am Sat, 22 Dec 2012 22:07:46 -0200 schrieb Mauro Carvalho Chehab : > Em Sun, 16 Dec 2012 19:23:28 +0100 > Frank Schäfer escreveu: > > > The em2800 can transfer up to 4 bytes per i2c message. > > All other em25xx/em27xx/28xx chips can transfer at least 64 bytes > > per message. > > > > I

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2013-01-02 Thread Antti Palosaari
On 12/18/2012 05:08 AM, Matthew Gyurgyik wrote: I can test patches Tue and Wed this week. Afterwards, I probably won't be able to test anything until Dec 28th/29th as I will be away from my workstation. In regards to my issue compiling my kernel, it helps if I include devtmpfs. :) Matthew, tes

Re: [PATCH] mt9p031: Add support for regulators

2013-01-02 Thread Guennadi Liakhovetski
Hi Laurent On Wed, 2 Jan 2013, Laurent Pinchart wrote: > Enable the regulators when powering the sensor up, and disable them when > powering it down. > > The regulators are mandatory. Boards that don't allow controlling the > sensor power lines must provide dummy regulators. I have been told se

Re: [PATCH 2/6] em28xx: refactor the code in em28xx_usb_disconnect()

2013-01-02 Thread Antti Palosaari
On 12/28/2012 01:02 AM, Frank Schäfer wrote: The main purpose of this patch is to move the call of em28xx_release_resources() after the call of em28xx_close_extension(). This is necessary, because some resources might be needed/used by the extensions fini() functions when they get closed. Also ma

Re: [PATCH v2 2/5] em28xx: respect the message size constraints for i2c transfers

2013-01-02 Thread Antti Palosaari
On 12/24/2012 01:09 PM, Frank Schäfer wrote: Am 23.12.2012 15:46, schrieb Mauro Carvalho Chehab: Em Sun, 23 Dec 2012 14:58:12 +0100 Frank Schäfer escreveu: Am 23.12.2012 01:07, schrieb Mauro Carvalho Chehab: Em Sun, 16 Dec 2012 19:23:28 +0100 Frank Schäfer escreveu: Those devices are lim

RE: [PATCH 1/3] [media] s5p-mfc: use mfc_err instead of printk

2013-01-02 Thread Kamil Debski
Hi Sachin, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sachin Kamat > Sent: Friday, December 28, 2012 11:18 AM > To: linux-media@vger.ke

RE: [PATCH 2/3] [media] s5p-mfc: Remove redundant 'break'

2013-01-02 Thread Kamil Debski
Hi Sachin, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sachin Kamat > Sent: Friday, December 28, 2012 11:18

RE: [PATCH Resend] [media] s5p-mfc: Fix an error check

2013-01-02 Thread Kamil Debski
Hi Sachin, Thank you for finding and correcting this. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Wednesday, January 02, 2013 11:46 AM > To: linux-media@vger.kernel.org >

Re: [PATCH/RFC 0/4] Re: dma_mmap_coherent / ARCH_HAS_DMA_MMAP_COHERENT

2013-01-02 Thread Marek Szyprowski
Hello, On 12/28/2012 8:23 PM, Geert Uytterhoeven wrote: On Sun, Dec 16, 2012 at 5:03 PM, Geert Uytterhoeven wrote: > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:204: error: implicit declaration of function ‘dma_mma

Re: [PATCH/RFC 4/4] common: dma-mapping: Move dma_common_*() to

2013-01-02 Thread Marek Szyprowski
Hello, On 12/28/2012 8:23 PM, Geert Uytterhoeven wrote: dma_common_mmap() and dma_common_get_sgtable() are defined in drivers/base/dma-mapping.c, and always compiled if CONFIG_HAS_DMA=y. However, their forward declarations and the inline functions defined on top of them (dma_mmap_attrs(), dma_m

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2013-01-02 Thread Fabio Estevam
On Wed, Jan 2, 2013 at 10:35 AM, javier Martin wrote: > Sorry Fabio but IMHO that's not enough. The probe() callback may work > properly but it doesn't mean that buffer and HW handling for i.MX25 > are functional. > The condition to keep i.MX25 support in this file was that you were > going to fi

[PATCH 2/2] [RFC] video: display: Adding frame related ops to MIPI DSI video source struct

2013-01-02 Thread Vikas C Sajjan
From: Vikas Sajjan Signed-off-by: Vikas Sajjan --- include/video/display.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/include/video/display.h b/include/video/display.h index b639fd0..fb2f437 100644 --- a/include/video/display.h +++ b/include/video/display.h @@ -117,6 +117,12 @

[PATCH 1/2] [RFC] video: exynos mipi dsi: Making Exynos MIPI Complaint with CDF

2013-01-02 Thread Vikas C Sajjan
From: Vikas Sajjan Signed-off-by: Vikas Sajjan --- drivers/video/exynos/exynos_mipi_dsi.c| 46 ++--- drivers/video/exynos/exynos_mipi_dsi_common.c | 22 drivers/video/exynos/exynos_mipi_dsi_common.h | 12 +++ include/video/exynos_mipi_dsim.h

[PATCH 0/2] Making Exynos MIPI Complaint with Common Display Framework

2013-01-02 Thread Vikas C Sajjan
From: Vikas Sajjan This patchset contains 2 RFCs, 1st RFC has modiifications in exynos MIPI DSI driver. 2nd RFC has additions done to video source struct as per exynos requirements. I have NOT tested the patch yet, as i am yet recieve the MIPI DSI panel. This based on Tomi's CDF RFC. I am yet t

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2013-01-02 Thread javier Martin
Hi Fabio, On 2 January 2013 13:25, Fabio Estevam wrote: > Hi Javier, > > On Wed, Jan 2, 2013 at 10:18 AM, javier Martin > wrote: > >> That's great. Did you need to change anything in the mx2 camera driver >> for mx25 to work? Have you already submitted the patches? > > I only touched board file

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2013-01-02 Thread javier Martin
Hi Fabio, Guennadi, sorry for the long delay but I've been out of the office for a month and without internet access. On 27 November 2012 14:05, Fabio Estevam wrote: > I just added the camera support to mach-mx25_3ds.c (which I will > submit it soon to arm kernel list) and it works fine: > > soc-

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2013-01-02 Thread Fabio Estevam
Hi Javier, On Wed, Jan 2, 2013 at 10:18 AM, javier Martin wrote: > That's great. Did you need to change anything in the mx2 camera driver > for mx25 to work? Have you already submitted the patches? I only touched board file code: http://www.spinics.net/lists/arm-kernel/msg210216.html ,and have

[PATCH] davinci: dm355: Fix uninitialized variable compiler warnings

2013-01-02 Thread Lad, Prabhakar
drivers/media/platform/davinci/dm355_ccdc.c:593:9: warning: ‘val1’ may be used uninitialized in this function [-Wuninitialized] drivers/media/platform/davinci/dm355_ccdc.c:560:6: note: ‘val1’ was declared here This is a false positive but the compiler has no way to know about it, so initialize th

Re: [PATCH RFC v2 02/15] [media] Add a V4L2 OF parser

2013-01-02 Thread Guennadi Liakhovetski
Hi Sylwester Just one question to this one: On Mon, 31 Dec 2012, Sylwester Nawrocki wrote: > diff --git a/drivers/media/v4l2-core/v4l2-of.c > b/drivers/media/v4l2-core/v4l2-of.c > new file mode 100644 > index 000..cdac04b > --- /dev/null > +++ b/drivers/media/v4l2-core/v4l2-of.c > @@ -0,0 +

[PATCH] davinci: dm644x: fix enum ccdc_gama_width and enum ccdc_data_size comparision warning

2013-01-02 Thread Lad, Prabhakar
while the effect is harmless this patch fixes following build warning, drivers/media/platform/davinci/dm644x_ccdc.c: In function ‘validate_ccdc_param’: drivers/media/platform/davinci/dm644x_ccdc.c:233:32: warning: comparison between ‘enum ccdc_gama_width’ and ‘enum ccdc_data_size’ [-Wenum-compare]

[PATCH] mt9p031: Add support for regulators

2013-01-02 Thread Laurent Pinchart
Enable the regulators when powering the sensor up, and disable them when powering it down. The regulators are mandatory. Boards that don't allow controlling the sensor power lines must provide dummy regulators. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9p031.c | 24 +

Re: [PATCH RFC v2 01/15] [media] Add common video interfaces OF bindings documentation

2013-01-02 Thread Guennadi Liakhovetski
Hi Sylwester Thanks for picking up these patches! In general both look good to me, just a couple of nit-picks, that I couldn't help remarking:-) On Mon, 31 Dec 2012, Sylwester Nawrocki wrote: > From: Guennadi Liakhovetski > > This patch adds a document describing common OF bindings for video

Re: [PATCH] [media] coda: Fix build due to iram.h rename

2013-01-02 Thread Sascha Hauer
Hi Mauro, On Thu, Dec 27, 2012 at 08:15:12PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 17 Dec 2012 10:37:14 +0100 > Sascha Hauer escreveu: > > > On Wed, Nov 14, 2012 at 11:04:42AM -0200, Fabio Estevam wrote: > > > commit c045e3f13 (ARM: imx: include iram.h rather than mach/iram.h) > > > cha

[PATCH] mt9p031: Use devm_* managed helpers

2013-01-02 Thread Laurent Pinchart
Replace kzalloc and gpio_request_one by their managed equivalents. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9p031.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index e328332..e0bad5

[PATCH 1/2] mt9m032: Fix PLL setup

2013-01-02 Thread Laurent Pinchart
The MT9M032 PLL was assumed to be identical to the MT9P031 PLL but differs significantly. Update the registers definitions and PLL limits according to the datasheet. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9m032.c | 24 +--- 1 files changed, 13 insertions(+)

[PATCH 2/2] mt9m032: Define MT9M032_READ_MODE1 bits

2013-01-02 Thread Laurent Pinchart
Replace hardcoded values with #define's. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9m032.c | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a/drivers/media/i2c/mt9m032.c b/drivers/media/i2c/mt9m032.c index 30d755a..de150d3 100644 --- a/dr

RE: [PATCH-Trivial] [media] s5p-mfc: Fix a typo in error message in s5p_mfc_pm.c

2013-01-02 Thread Kamil Debski
Hi Sachin, Thank you for this patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Wednesday, January 02, 2013 10:14 AM > To: linux-media@vger.kernel.org > Cc: k.deb...@sam

[GIT PULL FOR v3.9] Subdev registration fix

2013-01-02 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 8cd7085ff460ead3aba6174052a408f4ad52ac36: [media] get_dvb_firmware: Fix the location of firmware for Terratec HTC (2013-01-01 11:18:26 -0200) are available in the git repository at: git://linuxtv.org/pinchartl/media.git v4l2/core Laurent Pinchar

[PATCH Resend] [media] s5p-mfc: Fix an error check

2013-01-02 Thread Sachin Kamat
Checking unsigned variable for negative value always returns false. Hence make this value signed as we expect it to be negative too. Fixes the following smatch warning: drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:572 s5p_mfc_set_enc_ref_buffer_v6() warn: unsigned 'buf_size1' is never less than

[PATCH 1/1] [media] s5p-mfc: Fix an error check

2013-01-02 Thread Sachin Kamat
Checking unsigned variable for negative value always returns false. Hence make this value signed as we expect it to be negative too. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH RFC 07/11] it913x: make remote controller optional

2013-01-02 Thread Antti Palosaari
On 01/02/2013 05:24 AM, Fabio Estevam wrote: On Sun, Dec 9, 2012 at 10:45 PM, Antti Palosaari wrote: Do not compile remote controller when RC-core is disabled by Kconfig. Cc: Malcolm Priestley Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/it913x.c | 36 +++

Re: DT bindings for subdevices

2013-01-02 Thread Guennadi Liakhovetski
Hi Prabhakar On Wed, 2 Jan 2013, Prabhakar Lad wrote: > Hi, > > This is my first step towards DT support for media, Question might be > bit amateur :) No worries, we're all doing our first steps in this direction right at the moment. These two recent threads should give you an idea as to where

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-02 Thread Russell King - ARM Linux
On Wed, Jan 02, 2013 at 10:44:32AM +0100, Julia Lawall wrote: > On Wed, 2 Jan 2013, Russell King - ARM Linux wrote: > > > On Wed, Jan 02, 2013 at 08:10:36AM +0300, Dan Carpenter wrote: > > > clk_get() returns NULL if CONFIG_HAVE_CLK is disabled. > > > > > > I told Tony about this but everyone has

RE: [PATCH -next] [media] s5p-mfc: remove unused variable

2013-01-02 Thread Kamil Debski
Hi Wei, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Wei Yongjun > Sent: Sunday, December 02, 2012 1:17 PM >

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-02 Thread Julia Lawall
On Wed, 2 Jan 2013, Russell King - ARM Linux wrote: > On Wed, Jan 02, 2013 at 08:10:36AM +0300, Dan Carpenter wrote: > > clk_get() returns NULL if CONFIG_HAVE_CLK is disabled. > > > > I told Tony about this but everyone has been gone with end of year > > holidays so it hasn't been addressed. > > >

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-02 Thread Russell King - ARM Linux
On Wed, Jan 02, 2013 at 08:29:57AM +0100, Julia Lawall wrote: > There are dereferences to the result of clk_get a few times. I tried the > following semantic patch: And those are buggy; struct clk is _SUPPOSED_ to be an OPAQUE COOKIE and no one other than the clk code should be dereferencing it.

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-02 Thread Russell King - ARM Linux
On Wed, Jan 02, 2013 at 08:10:36AM +0300, Dan Carpenter wrote: > clk_get() returns NULL if CONFIG_HAVE_CLK is disabled. > > I told Tony about this but everyone has been gone with end of year > holidays so it hasn't been addressed. > > Tony, please fix it so people don't apply these patches until

[PATCH-Trivial] [media] s5p-mfc: Fix a typo in error message in s5p_mfc_pm.c

2013-01-02 Thread Sachin Kamat
Fixed a trivial typo. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc_pm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c b/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c index 2895333..6aa38a5 100644 ---

[PATCH/RFC] crystalhd-video (vaapi-backend): struct VADriverVTable *vtable; is heap, updated to API 0.32, configure GLX support misdetection

2013-01-02 Thread thomas schorpp
Hi, I've found at http://gitorious.org/crystalhd-video "palatis" has started an vaapi backend for crystalhd and updated it to API rev. 0.32 but RFC #1, Applicable Linux Media API for Broadcom Crystal HD decoders: I don't know yet if vaapi or vdpau is the right approach for a acceptable API for

Re: [PATCH V3 09/15] [media] marvell-ccic: add get_mcam function for marvell-ccic driver

2013-01-02 Thread Guennadi Liakhovetski
On Sun, 16 Dec 2012, Jonathan Corbet wrote: > On Sat, 15 Dec 2012 17:57:58 +0800 > Albert Wang wrote: > > > This patch adds get_mcam() inline function which is prepared for > > adding soc_camera support in marvell-ccic driver > > Time for a bikeshed moment: "get" generally is understood to mean

Re: [PATCH V3 08/15] [media] marvell-ccic: switch to resource managed allocation and request

2013-01-02 Thread Guennadi Liakhovetski
On Sat, 15 Dec 2012, Albert Wang wrote: > From: Libin Yang > > This patch switchs to resource managed allocation and request in mmp-driver. > It can remove free resource operations. > > Signed-off-by: Albert Wang > Signed-off-by: Libin Yang > --- > drivers/media/platform/marvell-ccic/mmp-dri