Hi Thierry,
Am Freitag, den 23.11.2012, 20:56 +0100 schrieb Thierry Reding:
> On Thu, Nov 22, 2012 at 10:45:31PM +0100, Laurent Pinchart wrote:
> [...]
> > Display entities are accessed by driver using notifiers. Any driver can
> > register a display entity notifier with the CDF, which then calls
devm_clk_get() is a device managed function and makes error handling
a bit simpler.
Cc: Shaik Ameer Basha
Signed-off-by: Sachin Kamat
---
drivers/media/platform/exynos-gsc/gsc-core.c | 17 -
1 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/media/platform
From: Sylwester Nawrocki
Make sure there is no unbalanced clk_unprepare call and add missing
clock release in the driver's remove() callback.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Sachin Kamat
---
drivers/media/platform/exynos-gsc/gsc-core.c | 15 ---
1 files changed,
In case of clk_prepare failure, the function gsc_clk_get also prints
"failed to get clock" which is not correct. Hence move the error
messages to their respective blocks. While at it, also renamed the labels
meaningfully.
Cc: Shaik Ameer Basha
Signed-off-by: Sachin Kamat
---
drivers/media/platf
Hi Sylwester,
I have re-organised this series as per your suggestion and included your patch
"exynos-gsc: Correct clock handling". However, I have created 3 patches as I
found making them into 2 a little cumbersome. Hope they look good.
This series is based on samsung/for_v3.8 branch of
git://linu
devm_clk_get() is device managed and makes error handling
and cleanup a bit simpler.
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-tv/hdmi_drv.c | 20 +---
1 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c
b/d
devm_clk_get() is device managed function and makes error handling
and exit code a bit simpler.
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-tv/sdo_drv.c | 39 +-
1 files changed, 12 insertions(+), 27 deletions(-)
diff --git a/drivers/media/platform/s
devm_* APIs are device managed and make error handling and
cleanup simpler.
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-tv/mixer_drv.c | 85 +++--
1 files changed, 20 insertions(+), 65 deletions(-)
diff --git a/drivers/media/platform/s5p-tv/mixer_drv.c
Fixes the following checkpatch warnings:
WARNING: sizeof *fmt should be sizeof(*fmt)
WARNING: sizeof *res should be sizeof(*res)
WARNING: sizeof *res should be sizeof(*res)
WARNING: sizeof sd->name should be sizeof(sd->name)
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-tv/hdmi_drv
Fixes the following checkpatch warning:
WARNING: sizeof *ctx should be sizeof(*ctx)
FILE: media/platform/s5p-tv/hdmiphy_drv.c:287:
ctx = kzalloc(sizeof *ctx, GFP_KERNEL);
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-tv/hdmiphy_drv.c |2 +-
1 files changed, 1 insertions(
Silences several checkpatch warnings of the type:
WARNING: sizeof *out should be sizeof(*out)
FILE: media/platform/s5p-tv/mixer_video.c:98:
out = kzalloc(sizeof *out, GFP_KERNEL);
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-tv/mixer_video.c | 18 +
Silences checkpatch warnings of type:
WARNING: sizeof mdev->res should be sizeof(mdev->res)
FILE: media/platform/s5p-tv/mixer_drv.c:301:
memset(&mdev->res, 0, sizeof mdev->res);
WARNING: sizeof *mdev should be sizeof(*mdev)
FILE: media/platform/s5p-tv/mixer_drv.c:385:
mdev = kzallo
Silences checkpatch warnings of the type:
WARNING: sizeof filter_y_horiz_tap8 should be sizeof(filter_y_horiz_tap8)
FILE: media/platform/s5p-tv/mixer_reg.c:473:
filter_y_horiz_tap8, sizeof filter_y_horiz_tap8);
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-tv/mixer_r
Silences the following checkpatch warnings:
WARNING: sizeof *sdev should be sizeof(*sdev)
FILE: media/platform/s5p-tv/sdo_drv.c:304:
sdev = devm_kzalloc(&pdev->dev, sizeof *sdev, GFP_KERNEL);
WARNING: sizeof sdev->sd.name should be sizeof(sdev->sd.name)
FILE: media/platform/s5p-tv/sdo_drv.c
Build tested based on samsung/for_v3.8 branch of
git://linuxtv.org/snawrocki/media.git tree.
Sachin Kamat (9):
[media] s5p-tv: Add missing braces around sizeof in sdo_drv.c
[media] s5p-tv: Add missing braces around sizeof in mixer_video.c
[media] s5p-tv: Add missing braces around sizeof in m
Hi Sylwester,
On 25 November 2012 21:02, Sylwester Nawrocki
wrote:
> Hi Sachin,
>
>
> On 11/23/2012 12:50 PM, Sachin Kamat wrote:
>>
>> devm_clk_get is device managed and makes error handling and cleanup
>> a bit simpler.
>
>
> Can we postpone this once devm_clk_prepare() is available ?
Ok. No pr
HI Sakari,
On Mon, Nov 26, 2012 at 5:58 AM, Sakari Ailus wrote:
>
> Hi Prabhakar,
> On Sun, Nov 25, 2012 at 09:57:23PM +0530, Prabhakar Lad wrote:
>> On Fri, Nov 23, 2012 at 7:31 PM, Hans Verkuil wrote:
>> > On Fri November 23 2012 14:57:53 Sakari Ailus wrote:
> ...
>> >> I think it should go un
On Sat, 2012-11-24 at 23:08 -0500, Bob Lightfoot wrote:
> Devin :
> Let me see if I can answer some of your questions.
>
>
> 2. Links on Google to files related to this issue :
> A. The Main Can on the Tuner Card -
>https://docs.google.com/open?id=0B95B_9punKEmeHBUNHprMnVNV00
> B.
Hi Prabhakar,
On Sun, Nov 25, 2012 at 09:57:23PM +0530, Prabhakar Lad wrote:
> On Fri, Nov 23, 2012 at 7:31 PM, Hans Verkuil wrote:
> > On Fri November 23 2012 14:57:53 Sakari Ailus wrote:
...
> >> I think it should go under staging, the same directory as the driver.
> >>
> >> Hans, Mauro: could
Hi Sylwester,
On Sat, Nov 17, 2012 at 2:39 AM, Sylwester Nawrocki
wrote:
> Hi Alexey,
>
>
> On 11/16/2012 03:10 PM, Alexey Klimov wrote:
+static int s3c_camif_hw_init(struct camif_dev *camif, struct camif_vp
*vp)
+{
+ unsigned int ip_rev = camif->variant->ip_revisio
Hi Hans,
On Fri, Nov 23, 2012 at 2:31 PM, Hans Verkuil wrote:
> Hi Alexey,
>
> On Mon November 12 2012 19:41:57 Alexey Klimov wrote:
>> Hi Mauro, Hans, all,
>>
>> On Fri, Nov 2, 2012 at 6:34 PM, Mauro Carvalho Chehab
>> wrote:
>> > Em Fri, 2 Nov 2012 14:47:49 +0100
>> > Hans Verkuil escreveu:
>
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date:Sun Nov 25 19:00:21 CET 2012
git hash:1323024fd3296537dd34da70fe70b4df12a308ec
gcc version: i686-linux-gcc (GCC
Hi all,
Today, I finally merged the DMABUF V4L2 patches from Tomasz.
The DMABUF allows replacing the old V4L2 Overlay method by something more
robust and safer.
It was a long road to get them ready for their upstream inclusion, and to
be able to test on both embedded and personal computers.
Alo
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Dear Devin:
Using v4l2-ctl and mplayer I have the svideo working and the
Tuner is not.
I find it interesting that the Frequency is not taking I suspect
your theory of subdev framework may hold water.
> [root@mythbox ~]# v4l2-ctl -d /dev/video
Function saa7134_probe_i2c_ir(..) in saa7134-input.c does not set any RC type
for Pinnacle PCTV 110i (and perhaps other) remote controls. For some other RCs
the setting (assinging some value to "type" member of the device structure)
is done either in this function or elsewhere (AFAIR), but not for
Hi,
On Fri, Nov 23, 2012 at 7:31 PM, Hans Verkuil wrote:
> On Fri November 23 2012 14:57:53 Sakari Ailus wrote:
>> Hi Prabhakar,
>>
>> On Fri, Nov 23, 2012 at 06:51:28PM +0530, Prabhakar Lad wrote:
>> > Hi Sakari,
>> >
>> > On Fri, Nov 23, 2012 at 6:43 PM, Sakari Ailus wrote:
>> > > Hi Prabhakar
Hi Sachin,
On 11/23/2012 12:50 PM, Sachin Kamat wrote:
devm_clk_get is device managed and makes error handling and cleanup
a bit simpler.
Can we postpone this once devm_clk_prepare() is available ?
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-fimc/mipi-csis.c |6 +-
Thanks Shaik,
Sachin, I've applied the last patch fixing the checkpatch.pl warning.
As for the remaining three, can you please squash them, together
with following patch
From cb7b42d2089206c8134fa195c0d1f4145fcb4f72 Mon Sep 17 00:00:00 2001
From: Sylwester Nawrocki
Date: Sun, 25 Nov 2012 14:16
Hi Sylwester,
On Thu, Nov 22, 2012 at 10:44:22PM +0100, Sylwester Nawrocki wrote:
> >>the data
> >>will not be displayed before this time, secondary to the nominal frame rate
> >>determined by the current video standard in enqueued order.
> >>Applications can
> >>for example zero this field to dis
Hi Sylwester,
Sylwester Nawrocki wrote:
> Hi All,
>
> On 11/14/2012 02:06 PM, Laurent Pinchart wrote:
> ...
+
+static DEFINE_MUTEX(clk_lock);
+static LIST_HEAD(v4l2_clk);
>>>
>>> As Sylwester mentioned, what about s/v4l2_clk/v4l2_clks/ ?
>>
>> Don't you
em28xx_urb_data_copy_vbi() is actually an extended version of
em28xx_urb_data_copy(). With the preceding fixes and improvements, it works
fine with both, vbi and non-vbi data streams without performance impacts.
So rename em28xx_urb_data_copy_vbi() to em28xx_urb_data_copy(), delete the
the old imp
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c |5 ++---
1 Datei geändert, 2 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx/em28xx-video.c
index 12e4b0a..6843784 100644
--- a/drivers/media
The current code doesn't set the frame field when a normal video header is
received. This bug didn't cause any trouble, because this type of header is
never received in vbi mode.
Fix it, because we want to use this function with disabled vbi in the future.
Also simplifiy the code.
Signed-off-by: F
Set capture type to 1 (video start) when the video frame start header is
detected. This bug didn't cause any trouble, because this type of header is
never received in vbi mode.
Fix it, because we want to use this function with disabled vbi in the future.
Also start with capture type -1 to avoid pro
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 45 ---
1 Datei geändert, 24 Zeilen hinzugefügt(+), 21 Zeilen entfernt(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx/em28xx-video.c
index 7994d17..0bbc6d
The header check/removal code at the end of function em28xx_urb_data_copy_vbi()
is obsolete, because this is already done earlier in this function.
In fact it is incomplete (doesn't check for vbi header) and causes trouble
when the first data bytes are the same as header bytes (which is fortunately
Patches 1-5 prepare function em28xx_urb_data_copy_vbi() to also work with
non-vbi video data.
Patch 6 finally renames em28xx_urb_data_copy_vbi() and changes to code to use
this function for both, vbi and non-vbi video data streams.
The changes have been tested with the following devices:
- "Silv
37 matches
Mail list logo
