Re: [PATCH] [media] coda: Do not use __cancel_delayed_work()

2012-10-09 Thread javier Martin
On 10 October 2012 05:43, Tejun Heo wrote: > On Wed, Oct 10, 2012 at 12:33:29AM -0300, Fabio Estevam wrote: >> From: Fabio Estevam >> >> commit 136b5721d (workqueue: deprecate __cancel_delayed_work()) made >> __cancel_delayed_work deprecated. Use cancel_delayed_work instead and get >> rid of >>

Re: video: USB webcam fails since kernel 3.2

2012-10-09 Thread Martin-Éric Racine
2012/10/10 Jean-Francois Moine : > On Tue, 9 Oct 2012 15:54:46 -0700 > Jonathan Nieder wrote: > >> Hi, >> >> In June, Martin-Éric Racine wrote: >> >> > Since recent kernels, this ASUS W5F's built-in webcam fails to be >> > detected. Gstreamer-based applications (Cheese, >> > gstreamer-properties)

Re: video: USB webcam fails since kernel 3.2

2012-10-09 Thread Jonathan Nieder
Jean-Francois Moine wrote: > I tried to prepare a patch set for the vc032x, That's good to hear. Does that you mean you have a rough patchset available, even if it doesn't work perfectly yet? I'd be happy to see some patches e.g. with [PATCH/WIP] in the subject line so there is something for pe

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-09 Thread Hans Verkuil
On Wed October 10 2012 03:05:30 Mauro Carvalho Chehab wrote: > Em Mon, 8 Oct 2012 15:03:36 +0200 > Hans Verkuil escreveu: > > > On Sun October 7 2012 13:13:36 Sylwester Nawrocki wrote: > > > On 10/07/2012 03:19 AM, Michael West wrote: > > > > This patch changes versions.txt and disables VIDEO_M5

Re: video: USB webcam fails since kernel 3.2

2012-10-09 Thread Jean-Francois Moine
On Tue, 9 Oct 2012 15:54:46 -0700 Jonathan Nieder wrote: > Hi, > > In June, Martin-Éric Racine wrote: > > > Since recent kernels, this ASUS W5F's built-in webcam fails to be > > detected. Gstreamer-based applications (Cheese, > > gstreamer-properties) immediately crash whenever trying to access

Re: video: USB webcam fails since kernel 3.2

2012-10-09 Thread Martin-Éric Racine
2012/10/10 Jonathan Nieder : > Hi, > > In June, Martin-Éric Racine wrote: > >> Since recent kernels, this ASUS W5F's built-in webcam fails to be >> detected. Gstreamer-based applications (Cheese, >> gstreamer-properties) immediately crash whenever trying to access >> the video device. > [...] >> vi

[PATCH] [media] coda: Fix 'driver_data' for mx53

2012-10-09 Thread Fabio Estevam
From: Fabio Estevam CODA_7541 is the coda_product type for mx53. The 'driver_data' for mx53 is CODA_IMX53 instead. Signed-off-by: Fabio Estevam --- drivers/media/platform/coda.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/coda.c b/drivers/medi

Re: [PATCH] [media] coda: Do not use __cancel_delayed_work()

2012-10-09 Thread Tejun Heo
On Wed, Oct 10, 2012 at 12:33:29AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > commit 136b5721d (workqueue: deprecate __cancel_delayed_work()) made > __cancel_delayed_work deprecated. Use cancel_delayed_work instead and get rid > of > the following warning: > > drivers/media/platfor

[PATCH] [media] coda: Do not use __cancel_delayed_work()

2012-10-09 Thread Fabio Estevam
From: Fabio Estevam commit 136b5721d (workqueue: deprecate __cancel_delayed_work()) made __cancel_delayed_work deprecated. Use cancel_delayed_work instead and get rid of the following warning: drivers/media/platform/coda.c:1543: warning: '__cancel_delayed_work' is deprecated (declared at incl

Re: udev breakages -

2012-10-09 Thread Felipe Contreras
On Thu, Oct 4, 2012 at 9:17 PM, Alan Cox wrote: >> I don't know how to handle the /dev/ptmx issue properly from within >> devtmpfs, does anyone? Proposals are always welcome, the last time this >> came up a week or so ago, I don't recall seeing any proposals, just a >> general complaint. > > Is i

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-09 Thread Mauro Carvalho Chehab
Em Mon, 8 Oct 2012 15:03:36 +0200 Hans Verkuil escreveu: > On Sun October 7 2012 13:13:36 Sylwester Nawrocki wrote: > > On 10/07/2012 03:19 AM, Michael West wrote: > > > This patch changes versions.txt and disables VIDEO_M5MOLS which > > > fixed the build for my 3.2 kernel but looking at the lo

Re: [PATCH] [for 3.7] stk1160: Add support for S-Video input

2012-10-09 Thread Ezequiel Garcia
On Tue, Oct 9, 2012 at 9:13 PM, Mauro Carvalho Chehab wrote: > Em Tue, 9 Oct 2012 21:11:04 -0300 > Mauro Carvalho Chehab escreveu: > >> Em Tue, 9 Oct 2012 21:04:46 -0300 >> Mauro Carvalho Chehab escreveu: >> >> > Em Tue, 9 Oct 2012 20:52:06 -0300 >> > Ezequiel Garcia escreveu: >> > >> > > On Tu

Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration

2012-10-09 Thread Kevin Hilman
Sakari Ailus writes: > Hi Kevin, > > Thanks for the comments! > > On Tue, Oct 09, 2012 at 01:50:04PM -0700, Kevin Hilman wrote: >> Hi Sakari, >> >> Sakari Ailus writes: >> >> > The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to >> > the actual CSI-2 receivers outside t

Re: [PATCH] [for 3.7] stk1160: Add support for S-Video input

2012-10-09 Thread Mauro Carvalho Chehab
Em Tue, 9 Oct 2012 21:11:04 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 9 Oct 2012 21:04:46 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Tue, 9 Oct 2012 20:52:06 -0300 > > Ezequiel Garcia escreveu: > > > > > On Tue, Oct 9, 2012 at 7:25 PM, Mauro Carvalho Chehab > > > wrote: > > > > E

Re: [PATCH] [for 3.7] stk1160: Add support for S-Video input

2012-10-09 Thread Mauro Carvalho Chehab
Em Tue, 9 Oct 2012 21:04:46 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 9 Oct 2012 20:52:06 -0300 > Ezequiel Garcia escreveu: > > > On Tue, Oct 9, 2012 at 7:25 PM, Mauro Carvalho Chehab > > wrote: > > > Em Tue, 9 Oct 2012 19:01:03 -0300 > > > Ezequiel Garcia escreveu: > > > > > Let me k

Re: [PATCH] [for 3.7] stk1160: Add support for S-Video input

2012-10-09 Thread Mauro Carvalho Chehab
Em Tue, 9 Oct 2012 20:52:06 -0300 Ezequiel Garcia escreveu: > On Tue, Oct 9, 2012 at 7:25 PM, Mauro Carvalho Chehab > wrote: > > Em Tue, 9 Oct 2012 19:01:03 -0300 > > Ezequiel Garcia escreveu: > > > >> In order to fully replace easycap driver with stk1160, > >> it's also necessary to add S-Vid

Re: [PATCH] [for 3.7] stk1160: Add support for S-Video input

2012-10-09 Thread Ezequiel Garcia
On Tue, Oct 9, 2012 at 7:25 PM, Mauro Carvalho Chehab wrote: > Em Tue, 9 Oct 2012 19:01:03 -0300 > Ezequiel Garcia escreveu: > >> In order to fully replace easycap driver with stk1160, >> it's also necessary to add S-Video support. >> >> A similar patch backported for v3.2 kernel has been >> tes

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-09 Thread Mauro Carvalho Chehab
Hi Julia, Em Mon, 8 Oct 2012 10:31:33 +0200 (CEST) Julia Lawall escreveu: > I found only 15 uses of I2C_MSG_OP, out of 653 uses of one of the three > macros. Since I2C_MSG_OP has the complete set of flags, I think it should > be OK? > > One of the uses, in drivers/media/i2c/adv7604.c, is as fo

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-09 Thread Mauro Carvalho Chehab
Em Mon, 8 Oct 2012 10:31:33 +0200 (CEST) Julia Lawall escreveu: > I found only 15 uses of I2C_MSG_OP, out of 653 uses of one of the three > macros. Since I2C_MSG_OP has the complete set of flags, I think it should > be OK? > > One of the uses, in drivers/media/i2c/adv7604.c, is as follows: > >

Re: [git:v4l-dvb/for_v3.7] [media] tda18271-common: hold the I2C adapter during write transfers

2012-10-09 Thread Michael Krufky
On Tue, Oct 9, 2012 at 6:44 PM, Mauro Carvalho Chehab wrote: > Em Sun, 7 Oct 2012 09:19:51 -0400 > Michael Krufky escreveu: > >> umm, again, i didn't actually ACK the patch, I verbally said "ok, i guess" >> >> You shouldn't forge someone's signature, Mauro. :-( > > First of all, acked-by is not

Re: [PATCH v2 2/6] Add the main bulk of core driver for SI476x code

2012-10-09 Thread Andrey Smirnov
On 10/08/2012 11:33 PM, Mark Brown wrote: > On Fri, Oct 05, 2012 at 06:54:58PM -0700, Andrey Smirnov wrote: > >> +err = regulator_enable(core->supplies.va); >> +if (err < 0) >> +break; >> + >> +

Re: video: USB webcam fails since kernel 3.2

2012-10-09 Thread Jonathan Nieder
Hi, In June, Martin-Éric Racine wrote: > Since recent kernels, this ASUS W5F's built-in webcam fails to be > detected. Gstreamer-based applications (Cheese, > gstreamer-properties) immediately crash whenever trying to access > the video device. [...] > video_source:sr[3246]: segfault at 0 ip (n

Re: [git:v4l-dvb/for_v3.7] [media] tda18271-common: hold the I2C adapter during write transfers

2012-10-09 Thread Mauro Carvalho Chehab
Em Sun, 7 Oct 2012 09:19:51 -0400 Michael Krufky escreveu: > umm, again, i didn't actually ACK the patch, I verbally said "ok, i guess" > > You shouldn't forge someone's signature, Mauro. :-( First of all, acked-by is not a signature. Those tags (acked, reviewed, tested, reported, etc) are pur

Re: [git:v4l-dvb/for_v3.7] [media] ds3000: add module parameter to force firmware upload

2012-10-09 Thread Mauro Carvalho Chehab
Em Mon, 08 Oct 2012 21:23:44 +0200 Rémi Cardona escreveu: > Hi Mauro, > > There's indeed a conflict since (as far as I can tell) only patch #6 of > a 7 patch series was applied. > > The entire patch series is: > - http://patchwork.linuxtv.org/patch/14752/ > - http://patchwork.linuxtv.org/patc

Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration

2012-10-09 Thread Sakari Ailus
Hi Kevin, Thanks for the comments! On Tue, Oct 09, 2012 at 01:50:04PM -0700, Kevin Hilman wrote: > Hi Sakari, > > Sakari Ailus writes: > > > The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to > > the actual CSI-2 receivers outside the ISP itself. Allow changing this >

Re: [git:v4l-dvb/for_v3.7] [media] omap3isp: Replace cpu_is_omap3630() with ISP revision check

2012-10-09 Thread Mauro Carvalho Chehab
Em Mon, 08 Oct 2012 22:33:59 +0200 Laurent Pinchart escreveu: > Mauro, > > On Saturday 06 October 2012 17:31:58 Mauro Carvalho Chehab wrote: > > This is an automatic generated email to let you know that the following > > patch were queued at the http://git.linuxtv.org/media_tree.git tree: > > P

Re: [PATCH] [for 3.7] stk1160: Add support for S-Video input

2012-10-09 Thread Mauro Carvalho Chehab
Em Tue, 9 Oct 2012 19:01:03 -0300 Ezequiel Garcia escreveu: > In order to fully replace easycap driver with stk1160, > it's also necessary to add S-Video support. > > A similar patch backported for v3.2 kernel has been > tested by three different users. > > Signed-off-by: Ezequiel Garcia > --

Re: [GIT PULL for 3.7-rc1] media updates - part 1

2012-10-09 Thread Mauro Carvalho Chehab
Em Tue, 9 Oct 2012 14:43:46 -0300 Ezequiel Garcia escreveu: > On Fri, Oct 5, 2012 at 10:42 AM, Mauro Carvalho Chehab ... > > Ezequiel García (13): > > [media] em28xx: Remove useless runtime->private_data usage > > [media] media: Add stk1160 new driver (easycap replacement) > > [

[PATCH] [for 3.7] stk1160: Add support for S-Video input

2012-10-09 Thread Ezequiel Garcia
In order to fully replace easycap driver with stk1160, it's also necessary to add S-Video support. A similar patch backported for v3.2 kernel has been tested by three different users. Signed-off-by: Ezequiel Garcia --- Hi Mauro, I'm sending this for inclusion in v3.7 second media pull request.

Re: [GIT PULL] Disintegrate UAPI for media

2012-10-09 Thread Mauro Carvalho Chehab
a214e66b462680cf86b210b74a8: > > Merge branch 'akpm' (Andrew's patch-bomb) (2012-10-09 16:23:15 +0900) > > are available in the git repository at: > > > git://git.infradead.org/users/dhowells/linux-headers.git > tags/disintegrate-media-20121009 &g

Re: [PATCH 3/3] libv4lconvert: update the list of pac7302 webcams

2012-10-09 Thread Robert Abel
Hi, sorry for digging this up. On 09.09.2012 23:26, Hans de Goede wrote: > The 0x0f here is a mask, so this one entry covers all device ids from > 0x2620 - 0x262f, so... > >> { 0x06f8, 0x3009, 0,NULL, NULL, V4LCONTROL_ROTATED_90_JPEG }, >> { 0x06f8, 0x301b, 0,NULL, NULL, V4LCO

Re: Update on the CEC API

2012-10-09 Thread Mauro Carvalho Chehab
Em Mon, 08 Oct 2012 19:45:14 +0200 Florian Fainelli escreveu: > On Monday 08 October 2012 17:49:00 Hans Verkuil wrote: > > On Mon October 8 2012 17:06:20 Florian Fainelli wrote: > > > Hi Hans, > > > > > > On Thursday 27 September 2012 16:33:30 Hans Verkuil wrote: > > > > Hi all, > > > > > > > >

Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration

2012-10-09 Thread Kevin Hilman
Hi Sakari, Sakari Ailus writes: > The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to > the actual CSI-2 receivers outside the ISP itself. Allow changing this > configuration from the ISP driver. > > Signed-off-by: Sakari Ailus These control module registers (CSIRXFE, C

cron job: media_tree daily build: WARNINGS

2012-10-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Tue Oct 9 19:00:26 CEST 2012 git hash:d92462401dde1effa04a51d0a15000e6246d2a43 gcc version: i686-linux-gcc (GC

Re: [GIT PULL for 3.7-rc1] media updates - part 1

2012-10-09 Thread Ezequiel Garcia
On Fri, Oct 5, 2012 at 10:42 AM, Mauro Carvalho Chehab wrote: > Hi Linus, > > Please pull from: > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media > v4l_for_linus > > For the first part of the media updates for Kernel 3.7. > > This series contain: > > - A major tree renam

RE: [PATCH] Fixed list_del corruption in videobuf-core.c : videobuf_queue_cancel()

2012-10-09 Thread Hiremath, Vaibhav
On Tue, Oct 09, 2012 at 14:08:18, Andrey Mandychev wrote: > Hi, > > Please find below some additional comments. > > Actually it's not a real issue. It's more warning than issue. When you > are trying to delete element from the queue the implementation of > list_del (in list_debug.c) checks that p

Re: [PATCH RFC 1/5] V4L: Add V4L2_MBUS_FMT_S5C_UYVY_JPEG_1X8 media bus format

2012-10-09 Thread Sylwester Nawrocki
Hi Vincent, On 10/09/2012 03:36 PM, Vincent ABRIOU wrote: > Hi Sylwester, > > I'm wondering why don't you simply define V4L2_MBUS_FMT_UYVY_JPEG_1X8 > without any reference to your camera? Because it's not a plain UYVY/JPEG data. There is an additional meta-data that follows interleaved UYVY/JPEG

Re: [PATCH v2 5/6] Add a V4L2 driver for SI476X MFD

2012-10-09 Thread halli manjunatha
On Tue, Oct 9, 2012 at 4:38 AM, Hans Verkuil wrote: > Note: I'm CC-ing Halli. Halli, can you take a look at the proposed controls? > > On Mon 8 October 2012 19:57:17 Andrey Smirnov wrote: >> On 10/08/2012 02:30 AM, Hans Verkuil wrote: >> > On Sat October 6 2012 03:55:01 Andrey Smirnov wrote: >> >>

Re: [PATCH 0/11] introduce macros for i2c_msg initialization

2012-10-09 Thread Julia Lawall
On Tue, 9 Oct 2012, Jean Delvare wrote: > Hi Julia, > > On Sun, 7 Oct 2012 17:38:30 +0200, Julia Lawall wrote: > > This patch set introduces some macros for describing how an i2c_msg is > > being initialized. There are three macros: I2C_MSG_READ, for a read > > message, I2C_MSG_WRITE, for a writ

Re: [PATCH 0/11] introduce macros for i2c_msg initialization

2012-10-09 Thread Jean Delvare
Hi Julia, On Sun, 7 Oct 2012 17:38:30 +0200, Julia Lawall wrote: > This patch set introduces some macros for describing how an i2c_msg is > being initialized. There are three macros: I2C_MSG_READ, for a read > message, I2C_MSG_WRITE, for a write message, and I2C_MSG_OP, for some other > kind of

Re: [PATCH] qv4l2: avoid empty titles for the video control tabs

2012-10-09 Thread Hans Verkuil
On Tue October 9 2012 16:46:04 Frank Schäfer wrote: > The video control class names are used as titles for the GUI-tabs. > The current code relies on the driver enumerating the control classes > properly when using V4L2_CTRL_FLAG_NEXT_CTRL. > But the UVC-driver (and likely others, too) don't do tha

Re: [PATCH RFC] V4L: Add get/set_frame_desc subdev callbacks

2012-10-09 Thread Sylwester Nawrocki
Hi Sakari, Thanks for the review. On 10/08/2012 11:12 PM, Sakari Ailus wrote: > Hi Sylwester, > > Thanks for the patch. I noticed this is already in Mauro's tree and is there > without my ack. I know it's partly my own fault since I haven't commented it > earlier. > > Sylwester Nawrocki wrote:

[PATCH] qv4l2: avoid empty titles for the video control tabs

2012-10-09 Thread Frank Schäfer
The video control class names are used as titles for the GUI-tabs. The current code relies on the driver enumerating the control classes properly when using V4L2_CTRL_FLAG_NEXT_CTRL. But the UVC-driver (and likely others, too) don't do that, so we can end up with an empty class name string. Make s

[PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread Fabio Estevam
Since mx27 transitioned to the commmon clock framework in 3.5, the correct way to acquire the csi clock is to get csi_ahb and csi_per clocks separately. By not doing so the camera sensor does not probe correctly: soc-camera-pdrv soc-camera-pdrv.0: Probing soc-camera-pdrv.0 mx2-camera mx2-camera.0

Re: [PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread Russell King - ARM Linux
On Mon, Oct 08, 2012 at 07:37:03PM -0300, Fabio Estevam wrote: > @@ -460,7 +462,11 @@ static int mx2_camera_add_device(struct > soc_camera_device *icd) > if (pcdev->icd) > return -EBUSY; > > - ret = clk_prepare_enable(pcdev->clk_csi); > + ret = clk_prepare_enable(pcde

RE: [PATCH RFC 1/5] V4L: Add V4L2_MBUS_FMT_S5C_UYVY_JPEG_1X8 media bus format

2012-10-09 Thread Vincent ABRIOU
Hi Sylwester, I'm wondering why don't you simply define V4L2_MBUS_FMT_UYVY_JPEG_1X8 without any reference to your camera? Indeed, many other cameras could support Jpeg interleaved with YUV and it will avoid to define a new media bus type for every cameras integrated under V4L2 supporting JPEG/YUV

[GIT PULL] Disintegrate UAPI for media

2012-10-09 Thread David Howells
git repository at: git://git.infradead.org/users/dhowells/linux-headers.git tags/disintegrate-media-20121009 for you to fetch changes up to 1c436decd49665be131887b08d172a7989cdceee: UAPI: (Scripted) Disintegrate include/linux/dvb (2012-10-09

Re: [PATCH 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-09 Thread Gaëtan Carlier
Hi, On 10/05/2012 11:53 PM, Fabio Estevam wrote: During the clock conversion for mx27 the "per4_gate" clock was missed to get registered as a dependency of mx2-camera driver. In the old mx27 clock driver we used to have: DEFINE_CLOCK1(csi_clk, 0, NULL, 0, parent, &csi_clk1, &per4_clk); ,so doe

Re: [PATCH 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-09 Thread javier Martin
On 5 October 2012 23:53, Fabio Estevam wrote: > During the clock conversion for mx27 the "per4_gate" clock was missed to get > registered as a dependency of mx2-camera driver. > > In the old mx27 clock driver we used to have: > > DEFINE_CLOCK1(csi_clk, 0, NULL, 0, parent, &csi_clk1, &per4_clk); >

Re: [PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread javier Martin
On 9 October 2012 14:48, Gaëtan Carlier wrote: > Hi, > > On 10/09/2012 12:37 AM, Fabio Estevam wrote: >> >> From: Fabio Estevam >> >> Since mx27 transitioned to the commmon clock framework in 3.5, the correct >> way >> to acquire the csi clock is to get csi_ahb and csi_per clocks separately. >> >

Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

2012-10-09 Thread Julia Lawall
On Tue, 9 Oct 2012, Jean Delvare wrote: > Hi Julia, > > On Mon, 8 Oct 2012 07:24:11 +0200 (CEST), Julia Lawall wrote: > > > Sorry, I mean either: > > > > > > I2C_MSG_WRITE(priv->cfg->i2c_address, ®, sizeof(reg)), > > > I2C_MSG_READ(priv->cfg->i2c_address, val, sizeof(*val)), > > > > Of course.

Re: [PATCH 2/13] drivers/media/tuners/mxl5007t.c: use macros for i2c_msg initialization

2012-10-09 Thread Julia Lawall
On Tue, 9 Oct 2012, Jean Delvare wrote: > Hi Julia, > > On Sun, 7 Oct 2012 17:38:33 +0200, Julia Lawall wrote: > > From: Julia Lawall > > > > Introduce use of I2c_MSG_READ/WRITE/OP, for readability. > > Next time you send this patch set, please Cc me on every post so that I > don't have to hunt

Re: [PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread Gaëtan Carlier
Hi, On 10/09/2012 12:37 AM, Fabio Estevam wrote: From: Fabio Estevam Since mx27 transitioned to the commmon clock framework in 3.5, the correct way to acquire the csi clock is to get csi_ahb and csi_per clocks separately. By not doing so the camera sensor does not probe correctly: soc-camera-

Re: [PATCH 2/13] drivers/media/tuners/mxl5007t.c: use macros for i2c_msg initialization

2012-10-09 Thread Jean Delvare
Hi Julia, On Sun, 7 Oct 2012 17:38:33 +0200, Julia Lawall wrote: > From: Julia Lawall > > Introduce use of I2c_MSG_READ/WRITE/OP, for readability. Next time you send this patch set, please Cc me on every post so that I don't have to hunt for them on lkml.org. > In each case, a length expresse

Re: [PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread Fabio Estevam
; frequency: 6650 This 66.5MHz is wrong. > > Furthermore, it's not correct, since there isn't such "per" clock for > the CSI in 3.5 [1], 3.6 [2], linux-next-20121008[3], or > next-20121009[4]. Well, you are looking to all git trees after the conversion to the

Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

2012-10-09 Thread Jean Delvare
Hi Julia, On Mon, 8 Oct 2012 07:24:11 +0200 (CEST), Julia Lawall wrote: > > Sorry, I mean either: > > > > I2C_MSG_WRITE(priv->cfg->i2c_address, ®, sizeof(reg)), > > I2C_MSG_READ(priv->cfg->i2c_address, val, sizeof(*val)), > > Of course. Sorry for not having seen that. I can do that. Ee

Re: [PATCH 9/13] drivers/media/tuners/fc0011.c: use macros for i2c_msg initialization

2012-10-09 Thread Jean Delvare
On Sun, 7 Oct 2012 18:50:31 +0200 (CEST), Julia Lawall wrote: > On Sun, 7 Oct 2012, walter harms wrote: > > Am 07.10.2012 17:38, schrieb Julia Lawall: > >> @@ -97,10 +96,8 @@ static int fc0011_readreg(struct fc0011_priv *priv, u8 > >> reg, u8 *val) > >> { > >>u8 dummy; > >>struct i2c_msg

Re: Media_build broken by [PATCH RFC v3 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-10-09 Thread Sylwester Nawrocki
Hi Laurent On 10/08/2012 10:42 PM, Laurent Pinchart wrote: > Hi, > > When did the {get,set}_frame_desc subdev operations reach mainline ? Last I > knew is that they were an RFC, and they're now suddenly in, without even one > ack from an embedded v4l developer :-S I'm not totally happy with tha

Re: [PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread javier Martin
_ahb); > + > dev_info(&pdev->dev, "MX2 Camera driver unloaded\n"); > > return 0; > -- > 1.7.9.5 > This patch doesn't fix the BUG it claims to, since I have it working properly in our Visstrim M10 platform with

Re: [PATCH 05/14] media: add a V4L2 OF parser

2012-10-09 Thread Hans Verkuil
On Tue 9 October 2012 12:34:48 Sylwester Nawrocki wrote: > Hi Guennadi, > > On 10/08/2012 11:40 AM, Guennadi Liakhovetski wrote: > > On Fri, 5 Oct 2012, Sylwester Nawrocki wrote: > >> I would really like to see more than one user until we add any core code. > >> No that it couldn't be changed afte

Re: [PATCH 05/14] media: add a V4L2 OF parser

2012-10-09 Thread Sylwester Nawrocki
Hi Guennadi, On 10/08/2012 11:40 AM, Guennadi Liakhovetski wrote: > On Fri, 5 Oct 2012, Sylwester Nawrocki wrote: >> I would really like to see more than one user until we add any core code. >> No that it couldn't be changed afterwards, but it would be nice to ensure >> the concepts are right and

Re: [PATCH v2 1/3] mt9v022: add v4l2 controls for blanking

2012-10-09 Thread Guennadi Liakhovetski
On Sat, 6 Oct 2012, Anatolij Gustschin wrote: > Hi Guennadi, > > On Fri, 28 Sep 2012 00:03:45 +0200 > Anatolij Gustschin wrote: > > > Add controls for horizontal and vertical blanking. Also add an error > > message for case that the control handler init failed. Since setting > > the blanking re

Re: [PATCH v2 1/6] Add header files and Kbuild plumbing for SI476x MFD core

2012-10-09 Thread Hans Verkuil
On Mon 8 October 2012 20:38:01 Andrey Smirnov wrote: > On 10/08/2012 01:43 AM, Hans Verkuil wrote: > > On Sat October 6 2012 03:54:57 Andrey Smirnov wrote: > >> This patch adds all necessary header files and Kbuild plumbing for the > >> core driver for Silicon Laboratories Si476x series of AM/FM tu

Re: [PATCH v2 3/6] Add commands abstraction layer for SI476X MFD

2012-10-09 Thread Hans Verkuil
On Mon 8 October 2012 22:06:29 Andrey Smirnov wrote: > On 10/08/2012 01:56 AM, Hans Verkuil wrote: > > On Sat October 6 2012 03:54:59 Andrey Smirnov wrote: > >> This patch adds all the functions used for exchanging commands with > >> the chip. > >> > >> Signed-off-by: Andrey Smirnov > >> --- > >>

Re: [PATCH v2 5/6] Add a V4L2 driver for SI476X MFD

2012-10-09 Thread Hans Verkuil
Note: I'm CC-ing Halli. Halli, can you take a look at the proposed controls? On Mon 8 October 2012 19:57:17 Andrey Smirnov wrote: > On 10/08/2012 02:30 AM, Hans Verkuil wrote: > > On Sat October 6 2012 03:55:01 Andrey Smirnov wrote: > >> This commit adds a driver that exposes all the radio related

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-09 Thread Guennadi Liakhovetski
On Tue, 9 Oct 2012, Hans Verkuil wrote: > On Mon 8 October 2012 23:14:01 Guennadi Liakhovetski wrote: > > On Mon, 8 Oct 2012, Laurent Pinchart wrote: > > > > > On Monday 08 October 2012 14:00:38 Stephen Warren wrote: > > > > On 10/02/2012 08:33 AM, Guennadi Liakhovetski wrote: > > > > > On Tue, 2

Re: omap3isp: no pixel rate control in subdev

2012-10-09 Thread Sakari Ailus
Hi Pete, On Tue, Oct 09, 2012 at 09:06:04AM +0100, P Jackson wrote: > On Sat, Oct 06, 2012 at 02:47:44PM +0100, P Jackson wrote: > > I'm trying to get an mt9t001 sensor board working on a Gumstix Overo board > > using the latest omap3isp-omap3isp-stable branch from the > > linuxtv.org/media.git

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-09 Thread Hans Verkuil
On Mon 8 October 2012 23:14:01 Guennadi Liakhovetski wrote: > On Mon, 8 Oct 2012, Laurent Pinchart wrote: > > > On Monday 08 October 2012 14:00:38 Stephen Warren wrote: > > > On 10/02/2012 08:33 AM, Guennadi Liakhovetski wrote: > > > > On Tue, 2 Oct 2012, Rob Herring wrote: > > > >> On 09/27/2012

Re: omap3isp: no pixel rate control in subdev

2012-10-09 Thread Laurent Pinchart
Hi, On Tuesday 09 October 2012 09:06:04 P Jackson wrote: > From: Sakari Ailus > Sent: Monday, 8 October 2012, 23:33 > On Sat, Oct 06, 2012 at 02:47:44PM +0100, P Jackson wrote: > > I'm trying to get an mt9t001 sensor board working on a Gumstix Overo board > > using the latest omap3isp-omap3isp-st

Re: omap3isp: no pixel rate control in subdev

2012-10-09 Thread P Jackson
Hi Sakari, From: Sakari Ailus Sent: Monday, 8 October 2012, 23:33 Hi, On Sat, Oct 06, 2012 at 02:47:44PM +0100, P Jackson wrote: > I'm trying to get an mt9t001 sensor board working on a Gumstix Overo board > using the latest omap3isp-omap3isp-stable branch from the > linuxtv.org/media.git

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-09 Thread Steffen Trumtrar
Hi Laurent, On Mon, Oct 08, 2012 at 10:52:04PM +0200, Laurent Pinchart wrote: > Hi Steffen, > > On Monday 08 October 2012 14:48:01 Steffen Trumtrar wrote: > > On Mon, Oct 08, 2012 at 02:13:50PM +0200, Laurent Pinchart wrote: > > > On Thursday 04 October 2012 19:59:20 Steffen Trumtrar wrote: > > >