Hi Tomasz,
On Friday 08 June 2012 16:31:31 Tomasz Stanislawski wrote:
> Hi Laurent and Subash,
>
> I confirm the issue found by Subash. The function vb2_dc_kaddr_to_pages does
> fail for some occasions. The failures are rather strange like 'got 95 of
> 150 pages'. It took me some time to find the
On 28/05/2012, Sylwester Nawrocki wrote:
> On 05/26/2012 05:11 PM, Sachin Kamat wrote:
>> Fixes the following sparse warnings:
>
> Hi Sachin. Thanks, in case somebody else applies this patch
> before I do:
> Acked-by: Sylwester Nawrocki
>
Thanks Sylwester.
> I would just change the summary line
On Sat, Jun 09, 2012 at 10:47:32AM +0300, Dan Carpenter wrote:
> The test here is never true because '&' was used instead of '|'. It was
> the same as:
>
> if (status & ((1<<16) & (1<<17)) ...
>
> Signed-off-by: Dan Carpenter
> ---
> I don't have this hardware and this one really should b
On Sun, Jun 10, 2012 at 09:42:22PM +0200, Ralph Metzler wrote:
> Dan Carpenter writes:
> > Hello Ralph Metzler,
> >
> > The patch 43dd07f758d8: "[media] DRX-K: Initial check-in" from Jul 3,
> > 2011, leads to the following warning:
> > drivers/media/dvb/frontends/drxk_hard.c:2980 ADCSynchron
Hi Mauro,
Here are two V4L2 API cleanup patches; the first removes __user from
videodev2.h from a few places, making it possible to use the header file
as such in user space, while the second one changes the
v4l2_buffer.input field back to reserved.
The following changes since commit 5472d3f1784
Dan Carpenter writes:
> Hello Ralph Metzler,
>
> The patch 43dd07f758d8: "[media] DRX-K: Initial check-in" from Jul 3,
> 2011, leads to the following warning:
> drivers/media/dvb/frontends/drxk_hard.c:2980 ADCSynchronization()
> warn: suspicious bitop condition
>
> 2977
Both V4L2 and V4L2 subdev interface have very similar selection APIs with
differences foremost related to in-memory and media bus formats. However,
the selection targets are the same for both. Most targets are and in the
future will likely continue to be more the same than with any differences.
Thu
Signed-off-by: Sakari Ailus
---
drivers/media/video/omap3isp/ispccdc.c|6 ++--
drivers/media/video/omap3isp/isppreview.c |6 ++--
drivers/media/video/omap3isp/ispresizer.c |6 ++--
drivers/media/video/smiapp/smiapp-core.c | 30 +-
drivers/media/video/v4l2-subdev
From: Sylwester Nawrocki
This patch drops the _ACTIVE part from the selection target names as
a prerequisite to unify the selection target names on subdevs and regular
video nodes.
Although not exactly the same, the meaning of V4L2_SEL_TGT_*_ACTIVE and
V4L2_SUBDEV_SEL_TGT_*_ACTUAL selection targ
The string "_ACTUAL" does not say anything more about the target names. Drop
it. V4L2 selection API was changed by "V4L: Rename
V4L2_SEL_TGT_[CROP/COMPOSE]_ACTIVE to
V4L2_SEL_TGT_[CROP/COMPOSE]" by Sylwester Nawrocki. This patch does the same
for the V4L2 subdev API.
Signed-off-by: Sakari Ailus
Hi all,
This patchset contains two patches already sent to the list ages ago,
and two new patches to unify the selections documentation as well.
The selection target documentation is moved to a new section whereas the
true meaning of the targets is documented as part of the interface they
are rel
To whom it may concern:
I expect to participate in the conference "Wavelets and Applications"
which will take place at the Euler Mathematical Institute in St.
Petersburg, Russia, July 8 - 15.
The conference is about mathematics, not Linux. So during the conference
sessions I will be wearing my
On Sun June 10 2012 19:32:36 Hans Verkuil wrote:
> On Sun June 10 2012 18:46:52 Mauro Carvalho Chehab wrote:
> > 3) it would be interesting if you could benchmark the previous code and the
> > new
> > one, to see what gains this change introduced, in terms of v4l2-core
> > footprint and
> > perfo
Hi Mauro,
This pull req contains just a single patch: fix for CREATE_BUFS
documentation which was broken by "[media] v4l2: use __u32 rather than
enums in ioctl() structs".
This really must make it to 3.5.
The following changes since commit 5472d3f17845c4398c6a510b46855820920c2181:
[media] mt9
In function saa7164_api_i2c_read variable regval was set but not used. Tested
by compilation only.
Signed-off-by: Peter Senna Tschudin
---
drivers/media/video/saa7164/saa7164-api.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/media/video/saa7164/saa7164-api.c
b/
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date:Sun Jun 10 19:00:15 CEST 2012
git hash:5472d3f17845c4398c6a510b46855820920c2181
gcc version: i686-linux-gcc (GC
On Sun June 10 2012 18:46:52 Mauro Carvalho Chehab wrote:
> Em 10-06-2012 07:25, Hans Verkuil escreveu:
> > Hi all,
> >
> > This large patch series makes a number of changes to the core (ioctl
> > handling in particular) and vb2. It all builds on one another, so there
> > wasn't much point in spli
Signed-off-by: Tomasz Moń
---
drivers/media/video/mem2mem_testdev.c | 135 ++---
1 file changed, 124 insertions(+), 11 deletions(-)
diff --git a/drivers/media/video/mem2mem_testdev.c
b/drivers/media/video/mem2mem_testdev.c
index d2dec58..e1b66e9 100644
--- a/driver
On Sat, 9 Jun 2012, Hans Verkuil wrote:
On Wed June 6 2012 09:06:23 Julia Lawall wrote:
The files drivers/media/video/bt8xx/bttv-audio-hook.c and
drivers/media/video/tvaudio.c contain a number of occurrences of eg:
mode |= V4L2_TUNER_MODE_LANG1 | V4L2_TUNER_MODE_LANG2;
and
if (mode & V4L2_TU
Em 10-06-2012 07:25, Hans Verkuil escreveu:
> Hi all,
>
> This large patch series makes a number of changes to the core (ioctl
> handling in particular) and vb2. It all builds on one another, so there
> wasn't much point in splitting it. Most patches are fairly trivial, so it
> is not as bad as it
Hi.
Unfortunatly my cable provider "Comhem" moved almost all channels to
QAM256.
The results are terrible on my two cards. Blocky picture and skipping
audio.
I've tried all suggestions i've found on mailing lists to change
different values in stv0297.c but without luck.
What i cannot see is,
Hi.
Unfortunatly my cable provider "Comhem" moved almost all channels to QAM256.
The results are terrible on my two cards. Blocky picture and skipping audio.
I've tried all suggestions i've found on mailing lists to change
different values in stv0297.c but without luck.
What i cannot see is, if
Ping? This thing still causes spinlock errors in 3.5-rc2.
On Sat, May 26, 2012 at 9:25 PM, Sasha Levin wrote:
> Initialize the spinlock for each hardware time.
>
> Signed-off-by: Sasha Levin
> ---
> drivers/staging/media/lirc/lirc_serial.c | 6 ++
> 1 files changed, 6 insertions(+), 0 de
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx88/cx88-alsa.c | 31 +-
drivers/media/video/cx88/cx88-blackbird.c | 71 -
drivers/media/video/cx88/cx88-cards.c | 11 +
drivers/media/video/cx88/cx88-core.c |3 +-
drivers/media/video/cx88/cx88-
From: Hans Verkuil
These are global properties and do not belong in the filehandle struct.
Note: the overlay related fields were just removed: they weren't used at all.
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx88/cx88-video.c | 49 ++---
drivers/medi
From: Hans Verkuil
This information is available elsewhere already.
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx88/cx88-video.c | 89 ++---
drivers/media/video/cx88/cx88.h |2 -
2 files changed, 37 insertions(+), 54 deletions(-)
diff --git a/d
From: Hans Verkuil
- missing COMPRESSED flag for MPEG formats
- set colorspace
- set sizeimage
- add tuner index checks
- setup the frequency ranges correctly
- add missing g_chip_ident ioctl
- fix audmode handling
- don't handle vbi formats on a video node and vice versa.
cx88 now passes the v4
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx88/cx88-blackbird.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/video/cx88/cx88-blackbird.c
b/drivers/media/video/cx88/cx88-blackbird.c
index 9cc6c95..8b13620 100644
--- a/drivers/
From: Hans Verkuil
radio only sees audio controls, video sees video and audio and vbi
sees none.
Also disable the chroma_agc control if secam is selected.
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx88/cx88-cards.c | 15 +++-
drivers/media/video/cx88/cx88-core.c |7 +-
driver
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx88/cx88-blackbird.c | 12 +---
drivers/media/video/cx88/cx88-video.c | 90 ++---
drivers/media/video/cx88/cx88.h |2 +
3 files changed, 36 insertions(+), 68 deletions(-)
diff
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx88/cx88-blackbird.c |4
drivers/media/video/cx88/cx88-core.c |1 +
drivers/media/video/cx88/cx88-video.c |4
drivers/media/video/cx88/cx88.h |3 +++
4 files changed, 12 insertio
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx88/cx88-blackbird.c |5 -
drivers/media/video/cx88/cx88-video.c | 16 ++--
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/media/video/cx88/cx88-blackbird.c
b/drivers/medi
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx88/cx88-blackbird.c | 108 +++--
drivers/media/video/cx88/cx88.h |2 +-
2 files changed, 40 insertions(+), 70 deletions(-)
diff --git a/drivers/media/video/cx88/cx88-blackbird.c
b/d
From: Hans Verkuil
current_norm can only be used if there is a single device node since it is
local to the device node. In this case multiple device nodes share a single
tuner.
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx88/cx88-blackbird.c | 12 +---
drivers/media/video/cx
Hi all,
This patch series converts the cx88 driver to use the control framework,
and it also fixes various other things so that v4l2-compliance likes it
a lot better.
It also replaces .ioctl with .unlocked_ioctl in cx88-blackbird. I don't
think I need to do extra locking myself, but let me know i
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/pwc/pwc-if.c | 155 -
drivers/media/video/pwc/pwc-v4l.c | 140 +++--
drivers/media/video/pwc/pwc.h |3 -
3 files changed, 24 insertions(+), 274 delet
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/vivi.c | 160 ++--
1 file changed, 21 insertions(+), 139 deletions(-)
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
index 1e4da5e..1e8c4f3 100644
--- a/drivers
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 60 ++
1 file changed, 29 insertions(+), 31 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index f33bb00..4a7b75b 100644
--
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 336 --
1 file changed, 141 insertions(+), 195 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 109615d..f33bb00 100644
From: Hans Verkuil
Add the necessary plumbing to make it possible to replace the switch by a
table driven implementation.
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 91 --
1 file changed, 78 insertions(+), 13 deletions(-)
diff --gi
From: Hans Verkuil
A block of code is moved down in the code to make later changes easier.
Do just the move without other changes to keep the diff readable for the
upcoming patch.
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 288 +++---
1
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 35 +--
1 file changed, 13 insertions(+), 22 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 0de31c4..6c91674 100644
--- a
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 139 --
1 file changed, 89 insertions(+), 50 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index a7e583e..c22a310 100644
--
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 207 --
1 file changed, 67 insertions(+), 140 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index c22a310..f5cf92e 100644
-
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 123 ++
1 file changed, 46 insertions(+), 77 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 9e39b74..a7e583e 100644
--
From: Hans Verkuil
v4l_i2c_print_ioctl wasn't used and v4l_print_ioctl could be replaced by
v4l_i2c_printk_ioctl.
Signed-off-by: Hans Verkuil
---
drivers/media/video/pvrusb2/pvrusb2-v4l2.c |4 ++--
drivers/media/video/sn9c102/sn9c102.h |2 +-
drivers/media/video/uvc/uvc_v4l2.c
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/vivi.c |9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
index 08c1024..8dd5ae6 100644
--- a/drivers/media/video/vivi.c
+++ b/drivers/media/video/vivi.c
@@
From: Hans Verkuil
This prepares struct video_device for easier integration with vb2.
It also introduces a new lock that protects the vb2_queue. It is up
to the driver to use it or not.
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 29 +
incl
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 395 +++---
1 file changed, 198 insertions(+), 197 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 1f7982a..4fb113b 100644
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 438 --
1 file changed, 228 insertions(+), 210 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 7d093ca..a23a7e4 100644
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index a4115ce..109615d 100644
--- a/drivers/media/video/v4l2-ioctl.c
+++ b/drivers/medi
From: Hans Verkuil
Use some macro magic to reduce the length of the lines in the table. This
makes it more readable.
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 189 +++---
1 file changed, 96 insertions(+), 93 deletions(-)
diff --git a/d
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/vivi.c | 25 +++--
1 file changed, 7 insertions(+), 18 deletions(-)
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
index 8dd5ae6..1e4da5e 100644
--- a/drivers/media/video/vivi.c
+
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-dev.c | 41
1 file changed, 29 insertions(+), 12 deletions(-)
diff --git a/drivers/media/video/v4l2-dev.c b/drivers/media/video/v4l2-dev.c
index 5c0bb18..54f387d 100644
--- a/
From: Hans Verkuil
That is now handled by sysfs.
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx18/cx18-ioctl.c | 18 --
drivers/media/video/cx18/cx18-ioctl.h |2 --
drivers/media/video/cx18/cx18-streams.c |4 ++--
3 files changed, 2 insertions(+), 22 delet
From: Hans Verkuil
The switch statement that determine how much data should be copied from
userspace is replaced by a table lookup.
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 103 +++---
1 file changed, 41 insertions(+), 62 deletions(-)
From: Hans Verkuil
- add device_caps
- set colorspace
- s_parm should support a fps of 0 (== reset to nominal fps)
Signed-off-by: Hans Verkuil
---
drivers/media/video/pwc/pwc-v4l.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/drivers/media/vi
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 278 +-
1 file changed, 154 insertions(+), 124 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index f5cf92e..0de31c4 100644
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 47 --
1 file changed, 20 insertions(+), 27 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 48852ca..7d093ca 100644
--
From: Hans Verkuil
This is now controlled by sysfs.
Signed-off-by: Hans Verkuil
---
drivers/media/video/ivtv/ivtv-ioctl.c | 12
drivers/media/video/ivtv/ivtv-ioctl.h |1 -
drivers/media/video/ivtv/ivtv-streams.c |4 ++--
3 files changed, 2 insertions(+), 15 deletions
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-dev.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/media/video/v4l2-dev.c b/drivers/media/video/v4l2-dev.c
index 1500208..5c0bb18 100644
--- a/drivers/media/video/v4l2-dev.c
++
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 692 +++---
1 file changed, 346 insertions(+), 346 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 4a7b75b..48852ca 100644
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
Documentation/DocBook/media/v4l/vidioc-create-bufs.xml |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/DocBook/media/v4l/vidioc-create-bufs.xml
b/Documentation/DocBook/media/v4l/vidioc-create-bufs.xm
From: Hans Verkuil
Add helper functions to make it easier to adapt drivers to vb2.
These helpers take care of core locking and check if the filehandle is the
owner of the queue.
This patch also adds support for count == 0 in create_bufs.
Signed-off-by: Hans Verkuil
---
drivers/media/video/vi
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 314 --
1 file changed, 164 insertions(+), 150 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index a23a7e4..1f7982a 100644
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-ioctl.c | 262 ++
1 file changed, 127 insertions(+), 135 deletions(-)
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 4fb113b..9e39b74 100644
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/video/v4l2-dev.c |2 ++
drivers/media/video/vivi.c |6 +-
include/linux/videodev2.h |6 +++---
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/media/video/v4l2-dev.c b/drivers/media
Hi all,
This large patch series makes a number of changes to the core (ioctl
handling in particular) and vb2. It all builds on one another, so there
wasn't much point in splitting it. Most patches are fairly trivial, so it
is not as bad as it looks :-)
I will go through the patches one by one:
-
68 matches
Mail list logo