On Sun June 10 2012 03:43:49 Daniel Glöckner wrote:
> This patchset is made up of changes I did to the tvaudio driver
> back in 2009. IIRC I started these to get automatic mono/stereo
> swiching working again in mplayer. These changes have been tested
> with a TDA9873H only and most of the time the
As V4L2_TUNER_MODE_SAP == V4L2_TUNER_MODE_LANG2, we make
V4L2_TUNER_MODE_LANG1 equal to V4L2_TUNER_MODE_STEREO.
Signed-off-by: Daniel Glöckner
---
drivers/media/video/tvaudio.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/tvaudio.c b/drivers/medi
It is never read and only assigned 0.
Signed-off-by: Daniel Glöckner
---
drivers/media/video/tvaudio.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c
index 3fbaaa0..fc37587 100644
--- a/drivers/media/video/
The passed audio mode is not a bitfield.
Signed-off-by: Daniel Glöckner
---
drivers/media/video/tvaudio.c | 24 ++--
1 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c
index 9b85e2a..76a8cbe 100644
Judging from the data sheet it will automatically switch to the next
best audio mode in accordance with the V4L2 tuner audio matrix.
Signed-off-by: Daniel Glöckner
---
drivers/media/video/tvaudio.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/tvaud
Many of the audio decoders handled by the driver support this mode,
so the driver should support it as well.
Coding style errors are done to blend into the surrounding code.
Signed-off-by: Daniel Glöckner
---
drivers/media/video/tvaudio.c | 34 --
1 files chang
The V4L2 spec says reporting mono and stereo at the same time means
the hardware can not distinguish between the two. So when we can,
we should report only one of them.
Signed-off-by: Daniel Glöckner
---
drivers/media/video/tvaudio.c | 12 ++--
1 files changed, 6 insertions(+), 6 delet
V4L2 specifies the audio mode to use for combinations of possible
(rxsubchans) and requested (audmode) audio modes. Up to now tvaudio
has made these decisions automatically based on the possible audio
modes from setting of the frequency until VIDIOC_S_TUNER was called.
It then forced the hardware t
The V4L2_TUNER_MODE_* constants are not suited for use in bitfields.
Signed-off-by: Daniel Glöckner
---
drivers/media/video/tvaudio.c | 63 +---
1 files changed, 27 insertions(+), 36 deletions(-)
diff --git a/drivers/media/video/tvaudio.c b/drivers/media/vi
These constants were unused so far but need | instead of &.
Signed-off-by: Daniel Glöckner
---
drivers/media/video/tvaudio.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c
index c5b1a73..9b85e2a 1006
This patchset is made up of changes I did to the tvaudio driver
back in 2009. IIRC I started these to get automatic mono/stereo
swiching working again in mplayer. These changes have been tested
with a TDA9873H only and most of the time there was stereo. The
last patch is just a few hours old and ha
Mauro,
If possible, I'd prefer folding this patch into commit 8173090acb33
("v4l: fix compiler warnings"), which introduced the build error.
Thank you!
drivers/media/video/pms.c: In function ‘pms_probe’:
drivers/media/video/pms.c:1047:2: error: implicit declaration of function
‘kzalloc’ [-Werror
On Sat, Jun 09, 2012 at 10:05:16AM +0200, Hans Verkuil wrote:
> On Wed June 6 2012 09:06:23 Julia Lawall wrote:
> > The files drivers/media/video/bt8xx/bttv-audio-hook.c and
> > drivers/media/video/tvaudio.c contain a number of occurrences of eg:
> >
> > mode |= V4L2_TUNER_MODE_LANG1 | V4L2_TUNER
Hi,
On 06/09/2012 07:06 PM, Bernard GODARD wrote:
Dear all,
I am using a Philips Toucam Pro 2 webcam with the program qastrocam-g2
(astronomy program that use some specific functions of the PWC
driver).
I have been using this program with this camera for a long time on
different Linux distribut
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date:Sat Jun 9 19:00:17 CEST 2012
git hash:5472d3f17845c4398c6a510b46855820920c2181
gcc version: i686-linux-gcc (GC
On Sat, Jun 9, 2012 at 12:22 AM, Erik Gilling wrote:
> The current linux graphics stack does not allow synchronization
> between the GPU and a camera/video decoder. When we've seen people
> try to support this behind the scenes, they get it wrong and introduce
> bugs that can take weeks to track
Peter Senna Tschudin wrote:
>Dear List,
>
>I've sent some janitor/newbie patches and I want to know if am I doing
>something wrong before continuing with more patches.
>
>The patches I've submitted:
>http://patchwork.linuxtv.org/patch/11576/
>
> This one was sent only to the list, I've not cc:
-Original Message-
>From: Devin Heitmueller
>Sent: Jun 7, 2012 8:45 PM
>To: sitten74...@mypacks.net
>Cc: linux-media@vger.kernel.org
>Subject: Re: hdpvr lockup with audio dropouts
>
>On Thu, Jun 7, 2012 at 7:53 PM, wrote:
>> Apparently there is a known issue where the HD-PVR cannot handl
Dear List,
I've sent some janitor/newbie patches and I want to know if am I doing
something wrong before continuing with more patches.
The patches I've submitted:
http://patchwork.linuxtv.org/patch/11576/
This one was sent only to the list, I've not cc:
Mauro Carvalho Chehab
Thomas Pet
In function fops_open variable type was set but not used. Tested by compilation
only.
Signed-off-by: Peter Senna Tschudin
---
drivers/media/common/saa7146_fops.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/media/common/saa7146_fops.c
b/drivers/media/common/saa7146_fops.c
In function pvr2_s_crop variable cap was set but not used. Tested by
compilation only.
Signed-off-by: Peter Senna Tschudin
---
drivers/media/video/pvrusb2/pvrusb2-v4l2.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
b/drivers/media/video/pvr
In function pvr2_try_ext_ctrls variable ret was set but not used. Tested by
compilation only.
Signed-off-by: Peter Senna Tschudin
---
drivers/media/video/pvrusb2/pvrusb2-v4l2.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
b/drivers/media/vi
In function pvr2_queryctrl variable ret was set but not used. Tested by
compilation only.
Signed-off-by: Peter Senna Tschudin
---
drivers/media/video/pvrusb2/pvrusb2-v4l2.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
b/drivers/media/video/
In function pvr2_enum_input variable ret was set but not used. Tested by
compilation only.
Signed-off-by: Peter Senna Tschudin
---
drivers/media/video/pvrusb2/pvrusb2-v4l2.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
b/drivers/media/video
On Fri, Jun 8, 2012 at 3:56 PM, Erik Gilling wrote:
>> I guess my other thought is that implicit vs explicit is not
>> mutually exclusive, though I'd guess there'd be interesting
>> deadlocks to have to debug if both were in use _at the same
>> time_. :-)
>
> I think this is an approach worth inve
Signed-off-by: Hans Verkuil
diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
index e8714aa..98a856f 100644
--- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
+++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
@@ -89,
Hello Ben Collins,
The patch faa4fd2a0951: "Staging: solo6x10: New driver (staging) for
Softlogic 6x10" from Jun 17, 2010, leads to the following warning:
drivers/staging/media/solo6x10/tw28.c:352 tw2815_setup()
warn: x |= 0
tbl_ntsc_tw2815_common[0x06] |= 0x03 & (DEFAULT_HDELAY
Signed-off-by: Ezequiel Garcia
---
drivers/media/video/em28xx/em28xx-input.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/em28xx/em28xx-input.c
b/drivers/media/video/em28xx/em28xx-input.c
index 2630b26..53cc36b 100644
--- a/drivers/media/video/em28
On Wed June 6 2012 09:06:23 Julia Lawall wrote:
> The files drivers/media/video/bt8xx/bttv-audio-hook.c and
> drivers/media/video/tvaudio.c contain a number of occurrences of eg:
>
> mode |= V4L2_TUNER_MODE_LANG1 | V4L2_TUNER_MODE_LANG2;
>
> and
>
> if (mode & V4L2_TUNER_MODE_MONO)
>
> (both f
The test here is never true because '&' was used instead of '|'. It was
the same as:
if (status & ((1<<16) & (1<<17)) ...
Signed-off-by: Dan Carpenter
---
I don't have this hardware and this one really should be tested or
checked by someone who knows the spec. It could be that the inte
30 matches
Mail list logo
