[PATCH] staging: media: go7007: Adlink MPG24 board issues

2012-05-10 Thread volokh84
From: Volokh Konstantin This issuses applyed only for Adlink MPG24 board with go7007 & wis2804, all whese changes was tested for continuos load&restart mode This is minimal changes needed for start up go7007&wis2804 to work correctly in 3.4 branch Changes: - When go7007 reset device, i2c

[PATCH 2/2] au0828: Move under dvb

2012-05-10 Thread Ismael Luceno
Signed-off-by: Ismael Luceno --- drivers/media/dvb/Kconfig |1 + drivers/media/dvb/Makefile |1 + drivers/media/{video => dvb}/au0828/Kconfig|0 drivers/media/{video => dvb}/au0828/Makefile |0 drivers/media/{video =>

[PATCH 1/2] au0828: Add USB ID used by many dongles

2012-05-10 Thread Ismael Luceno
Tested with Yfeng 680 ATV dongle. Signed-off-by: Ismael Luceno --- drivers/media/video/au0828/au0828-cards.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/video/au0828/au0828-cards.c b/drivers/media/video/au0828/au0828-cards.c index 1c6015a..e3fe9a6 100644 --- a/drivers

[PATCH] staging: media: go7007: Adlink MPG24 board issues

2012-05-10 Thread volokh84
From: Volokh Konstantin This issuses applyed only for Adlink MPG24 board with go7007 & wis2804, all whese changes was tested for continuos load&restart mode This is minimal changes needed for start up go7007&wis2804 to work correctly in 3.4 branch Changes: - When go7007 reset device, i2c

RE: [PATCH v2 01/13] davinci: vpif: add check for genuine interrupts in the isr

2012-05-10 Thread Hadli, Manjunath
Hi Laurent, On Tue, Apr 17, 2012 at 15:36:16, Laurent Pinchart wrote: > Hi Manjunath, > > Thanks for the patch. > > On Tuesday 17 April 2012 14:22:59 Manjunath Hadli wrote: > > As the same interrupt is shared between capture and display devices, > > sometimes we get isr calls where the interrup

RE: [PATCH v2 05/13] davinci: vpif display: declare contiguous region of memory handled by dma_alloc_coherent

2012-05-10 Thread Hadli, Manjunath
Hi Laurent, On Tue, Apr 17, 2012 at 15:32:55, Laurent Pinchart wrote: > Hi Manjunath, > > Thanks for the patch. > > On Tuesday 17 April 2012 14:23:03 Manjunath Hadli wrote: > > add support to declare contiguous region of memory to be handled when > > requested by dma_alloc_coherent call. The us

RE: [PATCH v2 07/13] davinci: vpif: add support to use videobuf_iolock()

2012-05-10 Thread Hadli, Manjunath
Hi Laurent, On Tue, Apr 17, 2012 at 15:16:50, Laurent Pinchart wrote: > Hi Manjunath, > > Thanks for the patch. > > On Tuesday 17 April 2012 14:23:05 Manjunath Hadli wrote: > > add support to use videobuf_iolock() instead of VPIF defined > > vpif_uservirt_to_phys API. Use videobuf_to_dma_contig

Re: [PATCH v3 10/9] sh_mobile_ceu_camera: Support user-configurable line stride

2012-05-10 Thread Laurent Pinchart
Hi Guennadi, On Wednesday 09 May 2012 23:56:49 Guennadi Liakhovetski wrote: > From: Laurent Pinchart > > In image mode, the CEU allows configurable line strides up to 8188 > pixels. > > Signed-off-by: Laurent Pinchart > [g.liakhovet...@gmx.de: unify sh_mobile_ceu_set_rect() in data-fetch mode]

Re: [ANN] Selection API naming meeting #v4l-meeting next Monday

2012-05-10 Thread Laurent Pinchart
Hi Sakari, On Thursday 10 May 2012 23:18:49 Sakari Ailus wrote: > Hi all, > > Let's have a quick meeting 14:00 Finnish time (GMT + 3) next Monday on > #v4l-meeting on two topics: > > - Selection target naming. It has been proposed that the _ACTUAL / _ACTIVE > be removed and e.g. the crop targe

Re: [PATCH v3 1/1] v4l2: use __u32 rather than enums in ioctl() structs

2012-05-10 Thread Sakari Ailus
On Thu, May 10, 2012 at 01:17:16PM +0200, Hans Verkuil wrote: > Acked-by: Hans Verkuil Thanks!!! -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord.

[ANN] Selection API naming meeting #v4l-meeting next Monday

2012-05-10 Thread Sakari Ailus
Hi all, Let's have a quick meeting 14:00 Finnish time (GMT + 3) next Monday on #v4l-meeting on two topics: - Selection target naming. It has been proposed that the _ACTUAL / _ACTIVE be removed and e.g. the crop targets would be then called V4L2_SEL_TGT_CROP and V4L2_SUBDEV_SEL_TGT_CROP on V4L

Re: [PATCH] V4L: marvell-ccic: (cosmetic) remove redundant variable assignment

2012-05-10 Thread Jonathan Corbet
On Tue, 8 May 2012 18:56:15 +0200 (CEST) Guennadi Liakhovetski wrote: > The "ret = 0" assignment in mcam_vidioc_s_fmt_vid_cap() is redundant, > because at that location "ret" is anyway guaranteed to be == 0. True enough. Acked-by: Jonathan Corbet jon -- To unsubscribe from this list: send the

Re: [GIT PULL FOR v3.5] Update v4l2-dev/ioctl.c to add gspca locking requirements

2012-05-10 Thread Hans de Goede
Hi, On 05/10/2012 05:35 PM, Laurent Pinchart wrote: Hi Hans, On Thursday 10 May 2012 13:59:34 Hans Verkuil wrote: Hi Mauro, Here is the pull request for this. HdG's gspca work depends on this and he likes to get this in for 3.5. I think these are pretty good improvements and for 3.6 I intend

cron job: media_tree daily build: WARNINGS

2012-05-10 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu May 10 19:00:15 CEST 2012 git hash:121b3ddbe4ad17df77cb7284239be0a63d9a66bd gcc version: i686-linux-gcc (GC

Re: em28xx : can work on ARM beagleboard ?

2012-05-10 Thread chrbruno
Sorry, the link is broken, see http://www.spinics.net/lists/linux-omap/msg64931.html Regards, Christian Le 10/05/2012 18:43, chrbruno a écrit : Hi, I'm not sure about the fix (it could break the driver for other em28xx cards) but I will try to post a patch for the em28xx problem on ARM Next

Re: em28xx : can work on ARM beagleboard ?

2012-05-10 Thread chrbruno
Hi, I'm not sure about the fix (it could break the driver for other em28xx cards) but I will try to post a patch for the em28xx problem on ARM Next, I have encountered the same USB problem you described : USB stopping after a long capture (and ethernet stops too) For this problem, I think a pa

Re: [RFCv1] DVB-USB improvements

2012-05-10 Thread Antti Palosaari
On 10.05.2012 17:14, Mauro Carvalho Chehab wrote: Em 08-05-2012 10:12, Antti Palosaari escreveu: Factors behind the changes are mostly coming from the fact current struct dvb_usb_device_properties contains so many static configuration options. You cannot change single dvb_usb_device_properties

Re: [GIT PULL FOR v3.5] Update v4l2-dev/ioctl.c to add gspca locking requirements

2012-05-10 Thread Laurent Pinchart
Hi Hans, On Thursday 10 May 2012 13:59:34 Hans Verkuil wrote: > Hi Mauro, > > Here is the pull request for this. HdG's gspca work depends on this and he > likes to get this in for 3.5. I think these are pretty good improvements > and for 3.6 I intend to build on it, basically getting rid of the w

Re: Advice on extending libv4l for media controller support

2012-05-10 Thread Sergio Aguirre
Hi Ivan, Great to hear from you! Long time :) On Thu, May 10, 2012 at 10:09 AM, Ivan T. Ivanov wrote: > > Hi Sergio, > > On Thu, 2012-05-10 at 08:54 -0500, Sergio Aguirre wrote: >> +Atsuo >> >> On Wed, May 9, 2012 at 7:08 PM, Sergio Aguirre >> wrote: >> > Hi Hans, >> > >> > I'm interested in us

Re: Advice on extending libv4l for media controller support

2012-05-10 Thread Ivan T. Ivanov
Hi Sergio, On Thu, 2012-05-10 at 08:54 -0500, Sergio Aguirre wrote: > +Atsuo > > On Wed, May 9, 2012 at 7:08 PM, Sergio Aguirre > wrote: > > Hi Hans, > > > > I'm interested in using libv4l along with my omap4 camera project to > > adapt it more easily > > to Android CameraHAL, and other applic

Re: Re: [PATCH] Terratec Cinergy C PCI HD (CI)

2012-05-10 Thread Igor M. Liplianin
On 9 мая 2012 20:57:49 Bjørn Mork wrote: > "Igor M. Liplianin" writes: > > This patch seems for rectifying a typo. But actually the difference > > between > > mantis_vp2040.c and mantis_vp2033.c code is a card name only. > > Yes, there are major code duplication issues in this driver. > > > Sign

Re: [PATCH] drivers: cma: don't fail if migration returns -EAGAIN

2012-05-10 Thread Minchan Kim
On Thu, May 10, 2012 at 03:19:35PM +0200, Marek Szyprowski wrote: > alloc_contig_range() function might return -EAGAIN if migrate_pages() call migrate_page never return -EAGAIN and I can't find any -EAGAIN return in alloc_contig_range. Am I seeing different tree? > fails for some temporarily lo

Re: [RFCv1] DVB-USB improvements

2012-05-10 Thread Devin Heitmueller
On Thu, May 10, 2012 at 10:14 AM, Mauro Carvalho Chehab wrote: > In order to add analog support, it is likely simpler to take em28xx (mainly > em28xx-video) as an > example on how things are implemented on analog side. The gspca > implementation may also help a > lot, but it doesn't contain the

Re: Advice on extending libv4l for media controller support

2012-05-10 Thread Laurent Pinchart
Hi Hans, On Thursday 10 May 2012 16:20:42 Hans de Goede wrote: > Hi, > > I somehow missed the original mail. This is in essence the same problem > as with the omap3 and Laurent and Sakari and I did a design for that > in Brussels in the last quarter of 2011, Laurent and Sakari would work > on fle

Re: Advice on extending libv4l for media controller support

2012-05-10 Thread Hans de Goede
Hi, I somehow missed the original mail. This is in essence the same problem as with the omap3 and Laurent and Sakari and I did a design for that in Brussels in the last quarter of 2011, Laurent and Sakari would work on fleshing that out, so it is probably best to talk to them about this. Regards

Re: [RFCv1] DVB-USB improvements

2012-05-10 Thread Mauro Carvalho Chehab
Em 08-05-2012 10:12, Antti Palosaari escreveu: > Factors behind the changes are mostly coming from the fact current struct > dvb_usb_device_properties contains so many static configuration options. > You cannot change single dvb_usb_device_properties easily (safely) at runtime > since it is usual

Re: Advice on extending libv4l for media controller support

2012-05-10 Thread Sergio Aguirre
+Atsuo On Wed, May 9, 2012 at 7:08 PM, Sergio Aguirre wrote: > Hi Hans, > > I'm interested in using libv4l along with my omap4 camera project to > adapt it more easily > to Android CameraHAL, and other applications, to reduce complexity of > them mostly... > > So, but the difference is that, this

Re: em28xx : can work on ARM beagleboard ?

2012-05-10 Thread Mauro Carvalho Chehab
Em 08-05-2012 15:18, CB escreveu: > Hello, > > I would like to know if someone has already used the em28xx driver on a > beagleboard xM > (the connected device is a Dazzle DVC 100) > > I have tried with an Angstrom Narcissus image and a Debian but I still get > "select timeouts" and skipped fra

[PATCH] drivers: cma: don't fail if migration returns -EAGAIN

2012-05-10 Thread Marek Szyprowski
alloc_contig_range() function might return -EAGAIN if migrate_pages() call fails for some temporarily locked pages. Such case should not be fatal to dma_alloc_from_contiguous(), which should retry allocation like in case of -EBUSY error. Reported-by: Haojian Zhuang Signed-off-by: Marek Szyprowski

Re: [RFC] HDMI-CEC proposal

2012-05-10 Thread Hans Verkuil
On Thu 10 May 2012 13:43:16 Florian Fainelli wrote: > Hello Murali, > > On Thursday 10 May 2012 12:40:05 muralidhar dixit wrote: > > Hello Florian, > > > > I do have similar implementation for my CEC driver. > > And I prefer most of the CEC messaged to be handled in the user space and > > have th

[GIT PULL FOR v3.5] Update v4l2-dev/ioctl.c to add gspca locking requirements

2012-05-10 Thread Hans Verkuil
Hi Mauro, Here is the pull request for this. HdG's gspca work depends on this and he likes to get this in for 3.5. I think these are pretty good improvements and for 3.6 I intend to build on it, basically getting rid of the whole huge switch statement in v4l2-ioctl.c and replace it with table l

Re: [RFC] HDMI-CEC proposal

2012-05-10 Thread Florian Fainelli
Hello Murali, On Thursday 10 May 2012 12:40:05 muralidhar dixit wrote: > Hello Florian, > > I do have similar implementation for my CEC driver. > And I prefer most of the CEC messaged to be handled in the user space and > have the kernel driver bare minimum with interfaces to > 1) REGISTER CEC de

Re: [PATCH v3 1/1] v4l2: use __u32 rather than enums in ioctl() structs

2012-05-10 Thread Hans Verkuil
On Thu 10 May 2012 08:02:07 Sakari Ailus wrote: > V4L2 uses the enum type in IOCTL arguments in IOCTLs that were defined until > the use of enum was considered less than ideal. Recently Rémi Denis-Courmont > brought up the issue by proposing a patch to convert the enums to unsigned: > > http://www

[PATCH 03/23] V4L: Add an extended camera white balance control

2012-05-10 Thread Sylwester Nawrocki
This patch adds V4L2_CID_AUTO_N_PRESET_WHITE_BALANCE control which is an extended version of the V4L2_CID_AUTO_WHITE_BALANCE control, including white balance presets. The following presets are defined: - V4L2_WHITE_BALANCE_INCANDESCENT, - V4L2_WHITE_BALANCE_FLUORESCENT, - V4L2_WHITE_BALANCE_FLU

[PATCH 04/23] V4L: Add camera wide dynamic range control

2012-05-10 Thread Sylwester Nawrocki
Add V4L2_CID_WIDE_DYNAMIC_RANGE camera class control for the camera wide dynamic range (WDR, HDR) feature. This control can be used to enable/disable wide dynamic range. It might get converted to a menu control in future if more options are needed. Signed-off-by: HeungJun Kim Signed-off-by: Sylwe

[PATCH 01/23] V4L: Add helper function for standard integer menu controls

2012-05-10 Thread Sylwester Nawrocki
This patch adds v4l2_ctrl_new_int_menu() helper function which can be used in drivers for creating standard integer menu control with driver-specific menu item list. It is similar to v4l2_ctrl_new_std_menu(), except it doesn't have a mask parameter and an additional qmenu parameter allows passing a

[PATCH 10/23] V4L: Add auto focus targets to the selections API

2012-05-10 Thread Sylwester Nawrocki
The camera automatic focus algorithms may require setting up a spot or rectangle coordinates or multiple such parameters. The automatic focus selection targets are introduced in order to allow applications to query and set such coordinates. Those selections are intended to be used together with th

[PATCH 02/23] V4L: Add camera exposure bias control

2012-05-10 Thread Sylwester Nawrocki
The camera may in some conditions incorrectly determine the exposure, and a manual automatic exposure correction may be needed. This patch adds V4L2_CID_AUTO_EXPOSURE_BIAS control which allows to add some offset in the automatic exposure control loop, to compensate for frame under- or over-exposure

[PATCH 05/23] V4L: Add camera image stabilization control

2012-05-10 Thread Sylwester Nawrocki
Add V4L2_CID_IMAGE_STABILIZATION control for the camera image stabilization feature. This control can be used to enable/disable image stabilization. It might get converted to a menu control in future if more options are needed. Signed-off-by: HeungJun Kim Signed-off-by: Sylwester Nawrocki Signed

[PATCH 08/23] V4L: Add camera scene mode control

2012-05-10 Thread Sylwester Nawrocki
Add control for the scene mode feature available in image sensor with more advanced ISP firmware. The V4L2_CID_SCENE_MODE menu control allows to select a set of parameters or a specific image processing and capture control algorithm optimized for common image capture conditions. Signed-off-by: Heu

[PATCH 09/23] V4L: Add camera 3A lock control

2012-05-10 Thread Sylwester Nawrocki
The V4L2_CID_3A_LOCK bitmask control allows applications to pause or resume the automatic exposure, focus and wite balance adjustments. It can be used, for example, to lock the 3A adjustments right before a still image is captured, for pre-focus, etc. The applications can control each of the algori

[PATCH 14/23] m5mols: Refactored controls handling

2012-05-10 Thread Sylwester Nawrocki
This patch is a prerequisite for the new controls addition. It consolidates the control handling code, which is moved to m5mols_controls.c and staticized. The controls initialization is reordered to better reflect the control clusters and make the diffs smaller when new controls are added. To make

[PATCH 07/23] V4L: Add camera exposure metering control

2012-05-10 Thread Sylwester Nawrocki
The V4L2_CID_EXPOSURE_METERING control allows to determine a method used by the camera for measuring the amount of light available for automatic exposure. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Documentation/DocBook/media/v4l/controls.xml | 29 +

[PATCH 17/23] m5mols: Add auto and preset white balance control

2012-05-10 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/m5mols/m5mols.h |4 +-- drivers/media/video/m5mols/m5mols_controls.c | 47 -- 2 files changed, 39 insertions(+), 12 deletions(-) diff --git a/drivers/media/video/m5mols/

[PATCH 18/23] m5mols: Add exposure bias control

2012-05-10 Thread Sylwester Nawrocki
Add integer menu control for exposure bias. The control value range is -2.0 EV to +2.0 EV, in 0.5 EV steps. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/m5mols/m5mols.h |4 +++- drivers/media/video/m5mols/m5mols_controls.c | 24 ++

[PATCH 19/23] m5mols: Add wide dynamic range control

2012-05-10 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/m5mols/m5mols.h |2 ++ drivers/media/video/m5mols/m5mols_controls.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/drivers/media/video/m5mols/m5mols.h b/drivers/me

[PATCH 20/23] m5mols: Add image stabilization control

2012-05-10 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/m5mols/m5mols.h |2 ++ drivers/media/video/m5mols/m5mols_controls.c | 20 2 files changed, 22 insertions(+) diff --git a/drivers/media/video/m5mols/m5mols.h b/drivers/medi

[PATCH 23/23] m5mols: Add 3A lock control

2012-05-10 Thread Sylwester Nawrocki
Add control for locking automatic exposure, focus and white balance adjustments. While at it, tidy up the data structure documentation. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/m5mols/m5mols.h | 10 ++- drivers/media/video/m5mols/m5mols_c

[PATCH 21/23] m5mols: Add exposure metering control

2012-05-10 Thread Sylwester Nawrocki
This patch adds V4L2_CID_EXPOSURE_METERING control which allows to select the light metering mode for automatic exposure as one of the following modes: spot (small area at the frame center), center weighted and frame averaged. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- d

[PATCH 22/23] m5mols: Add JPEG compression quality control

2012-05-10 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/m5mols/m5mols.h |2 ++ drivers/media/video/m5mols/m5mols_controls.c | 10 -- drivers/media/video/m5mols/m5mols_reg.h |1 + 3 files changed, 11 insertions(+), 2 deletions(-) dif

[PATCH 16/23] m5mols: Add ISO sensitivity controls

2012-05-10 Thread Sylwester Nawrocki
Add controls for manual/auto ISO sensitivity. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/m5mols/m5mols.h |7 drivers/media/video/m5mols/m5mols_controls.c | 56 ++ 2 files changed, 63 insertions(+) diff --gi

[PATCH 11/23] V4L: Add auto focus targets to the subdev selections API

2012-05-10 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Documentation/DocBook/media/v4l/dev-subdev.xml | 27 +++- .../media/v4l/vidioc-subdev-g-selection.xml| 14 -- include/linux/v4l2-subdev.h|4 +++ 3 files changed,

[PATCH 06/23] V4L: Add camera ISO sensitivity controls

2012-05-10 Thread Sylwester Nawrocki
Add ISO sensitivity and ISO auto/manual controls. The sensitivity values are related to level of amplification of the analog signal between image sensor and ADC. These controls allow to support sensors exposing an interface to accept the ISO values directly. Signed-off-by: Sylwester Nawrocki Sign

[PATCH 15/23] m5mols: Use proper sensor mode for the controls

2012-05-10 Thread Sylwester Nawrocki
The parameters corresponding to the V4L controls can be reconfigured only in associated M-5MOLS operation mode. Use struct v4l2_ctrl priv field to assign the working mode to the controls which can be modified only in certain conditions. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Pa

[PATCH 12/23] V4L: Add camera auto focus controls

2012-05-10 Thread Sylwester Nawrocki
Add following auto focus controls: - V4L2_CID_AUTO_FOCUS_START - single-shot auto focus start - V4L2_CID_AUTO_FOCUS_STOP - single-shot auto focus stop - V4L2_CID_AUTO_FOCUS_STATUS - automatic focus status - V4L2_CID_AUTO_FOCUS_AREA - automatic focus area selection - V4L2_CID_AUTO_FOCUS_RANGE

[PATCH 13/23] m5mols: Convert macros to inline functions

2012-05-10 Thread Sylwester Nawrocki
Make to_sd and to_m5mols macros static inline functions for better type safety. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/m5mols/m5mols.h | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/m5m

[PATCH v5 00/23] V4L: camera control enhancements

2012-05-10 Thread Sylwester Nawrocki
Hi everyone, It's probably the last update of this patch series, it contains a few minor changes to the V4L2 API patches and updated patches for m5mols sensor driver that were previously posted to LMML. Changes since v4: - removed V4L2_AUTO_FOCUS_STATUS_LOST AF status bit definition; - added

RE: [PATCH 1/2] [media] s5p-g2d: Fix NULL pointer warnings in g2d.c file

2012-05-10 Thread Kamil Debski
Hi Sachin, Thanks for the patch. Best regards, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: 10 May 2012 08:36 > To: linux-media@vger.kernel.org > Cc: mche...@infradead.org; k.deb...@sams

RE: [PATCH 2/2] [media] s5p-g2d: Add missing static storage class in g2d.c file

2012-05-10 Thread Kamil Debski
Hi Sachin, Thanks for the patch. Best regards, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: 10 May 2012 08:36 > To: linux-media@vger.kernel.org > Cc: mche...@infradead.org; k.deb...@sams

RE: [PATCH 2/2] [media] s5p-mfc: Add missing static storage class to silence warnings

2012-05-10 Thread Kamil Debski
Hi Sachin, Thanks for the patch. Best regards, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: 10 May 2012 08:32 > To: linux-media@vger.kernel.org > Cc: mche...@infradead.org; k.deb...@sams

RE: [PATCH 1/2] [media] s5p-mfc: Fix NULL pointer warnings

2012-05-10 Thread Kamil Debski
Hi Sachin, Thanks for the patch. Best regards, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: 10 May 2012 08:32 > > Fixes the following type of warnings detected by sparse: > warning: Using plain integer as NULL point

Re: [GIT PULL FOR 3.5] s5p-fimc driver updates

2012-05-10 Thread Sylwester Nawrocki
On 05/04/2012 05:31 PM, Sylwester Nawrocki wrote: > Hi Mauro, > > The following changes since commit 34b2debaa62bfa384ef91b61cf2c40c48e86a5e2: > > s5p-fimc: Correct memory allocation for VIDIOC_CREATE_BUFS (2012-05-04 > 17:07:24 +0200) > > are available in the git repository at: > > git://

Re: [RFCv1 PATCH 2/5] v4l2-dev/ioctl: determine the valid ioctls upfront.

2012-05-10 Thread Hans Verkuil
On Thu 10 May 2012 10:10:21 Hans de Goede wrote: > Hi, > > Comments inline. > > On 05/10/2012 09:05 AM, Hans Verkuil wrote: > > From: Hans Verkuil > > > > Rather than testing whether an ioctl is implemented in the driver or not > > every time the ioctl is called, do it upfront when the device is

Re: [RFCv1 PATCH 2/5] v4l2-dev/ioctl: determine the valid ioctls upfront.

2012-05-10 Thread Hans de Goede
Hi, On 05/10/2012 10:10 AM, Hans de Goede wrote: @@ -526,19 +518,28 @@ static long __video_do_ioctl(struct file *file, return ret; } - if ((vfd->debug& V4L2_DEBUG_IOCTL)&& - !(vfd->debug& V4L2_DEBUG_IOCTL_ARG)) { - v4l_print_ioctl(vfd->name, cmd); - printk(KERN_CONT "\n"); - } - if (test_bit

Re: [RFCv1 PATCH 2/5] v4l2-dev/ioctl: determine the valid ioctls upfront.

2012-05-10 Thread Hans Verkuil
On Thu 10 May 2012 09:05:11 Hans Verkuil wrote: > From: Hans Verkuil > > Rather than testing whether an ioctl is implemented in the driver or not > every time the ioctl is called, do it upfront when the device is registered. > > This also allows a driver to disable certain ioctls based on the ca

Re: [RFCv1 PATCH 5/5] v4l2-dev: add flag to have the core lock all file operations.

2012-05-10 Thread Hans de Goede
Hi, Looks good, ack. Acked-by: Hans de Goede Regards, Hans On 05/10/2012 09:05 AM, Hans Verkuil wrote: From: Hans Verkuil This used to be the default if the lock pointer was set, but now that lock is by default only used for ioctl serialization. Those drivers that already used core lockin

Re: [RFCv1 PATCH 4/5] v4l2-ioctl: handle priority handling based on a table lookup.

2012-05-10 Thread Hans de Goede
Hi, Looks good, ack. Acked-by: Hans de Goede Regards, Hans On 05/10/2012 09:05 AM, Hans Verkuil wrote: From: Hans Verkuil Rather than checking the priority for each ioctl that needs to, just mark such ioctls in the table and do it only once. Signed-off-by: Hans Verkuil --- drivers/medi

Re: [RFCv1 PATCH 3/5] tea575x-tuner: mark VIDIOC_S_HW_FREQ_SEEK as an invalid ioctl.

2012-05-10 Thread Hans de Goede
Hi, Looks good, ack. Acked-by: Hans de Goede Regards, Hans On 05/10/2012 09:05 AM, Hans Verkuil wrote: From: Hans Verkuil The tea575x-tuner framework can support the VIDIOC_S_HW_FREQ_SEEK for only some of the tea575x-based boards. Mark this ioctl as invalid if the board doesn't support it

Re: [RFCv1 PATCH 2/5] v4l2-dev/ioctl: determine the valid ioctls upfront.

2012-05-10 Thread Hans de Goede
Hi, Comments inline. On 05/10/2012 09:05 AM, Hans Verkuil wrote: From: Hans Verkuil Rather than testing whether an ioctl is implemented in the driver or not every time the ioctl is called, do it upfront when the device is registered. This also allows a driver to disable certain ioctls based o

Re: [RFCv1 PATCH 1/5] v4l2-dev: make it possible to skip locking for selected ioctls.

2012-05-10 Thread Hans de Goede
Hi, Looks good, ack. Acked-by: Hans de Goede Regards, Hans On 05/10/2012 09:05 AM, Hans Verkuil wrote: From: Hans Verkuil Using the V4L2 core lock is a very robust method that is usually very good at doing the right thing. But some drivers, particularly USB drivers, may want to prevent th

[RFCv1 PATCH 4/5] v4l2-ioctl: handle priority handling based on a table lookup.

2012-05-10 Thread Hans Verkuil
From: Hans Verkuil Rather than checking the priority for each ioctl that needs to, just mark such ioctls in the table and do it only once. Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 181 +- 1 file changed, 40 insertions(+), 141 delet

[RFCv1 PATCH 3/5] tea575x-tuner: mark VIDIOC_S_HW_FREQ_SEEK as an invalid ioctl.

2012-05-10 Thread Hans Verkuil
From: Hans Verkuil The tea575x-tuner framework can support the VIDIOC_S_HW_FREQ_SEEK for only some of the tea575x-based boards. Mark this ioctl as invalid if the board doesn't support it. This fixes an issue with S_HW_FREQ_SEEK in combination with priority handling: since the priority check is d

[RFCv1 PATCH 5/5] v4l2-dev: add flag to have the core lock all file operations.

2012-05-10 Thread Hans Verkuil
From: Hans Verkuil This used to be the default if the lock pointer was set, but now that lock is by default only used for ioctl serialization. Those drivers that already used core locking have this flag set explicitly, except for some drivers where it was obvious that there was no need to seriali

[RFCv1 PATCH 2/5] v4l2-dev/ioctl: determine the valid ioctls upfront.

2012-05-10 Thread Hans Verkuil
From: Hans Verkuil Rather than testing whether an ioctl is implemented in the driver or not every time the ioctl is called, do it upfront when the device is registered. This also allows a driver to disable certain ioctls based on the capabilities of the detected board, something you can't do tod

[RFCv1 PATCH 1/5] v4l2-dev: make it possible to skip locking for selected ioctls.

2012-05-10 Thread Hans Verkuil
From: Hans Verkuil Using the V4L2 core lock is a very robust method that is usually very good at doing the right thing. But some drivers, particularly USB drivers, may want to prevent the core from taking the lock for specific ioctls, particularly buffer queuing ioctls. The reason is that certai

[RFCv1 PATCH 0/5] Improvements to the core ioctl/fops handling

2012-05-10 Thread Hans Verkuil
Hi all, This patch series makes improvements to the way the v4l2 core handles locking and how it handles the ioctls. This is driven by some requirements from the work on the gspca driver, but it is also a good starting point to clean up the v4l2-ioctl.c source. The gspca requirement was to have