Re: [ANNOUNCE] DVBv5 tools version 0.0.1

2012-01-07 Thread Mauro Carvalho Chehab
On 07-01-2012 10:19, Mauro Carvalho Chehab wrote: > As previously commented at the ML, I'm developing a set of tools > using DVBv5 API. Instead of starting from something existing, > I decided to start from scratch, in order to avoid polluting it > with DVBv3 legacy stuff. Of course, I did some res

Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-07 Thread Laurent Pinchart
Hi Sakari, On Saturday 07 January 2012 23:51:24 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Tuesday 20 December 2011 21:28:05 Sakari Ailus wrote: > >> From: Sakari Ailus > >> > >> Configure CSI-2 phy based on platform data in the ISP driver rather than > >> in platform code. > >> > >>

Re: [RFC 12/17] omap3isp: Add lane configuration to platform data

2012-01-07 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: > On Tuesday 20 December 2011 21:28:04 Sakari Ailus wrote: >> From: Sakari Ailus >> >> Add lane configuration (order of clock and data lane) to platform data on >> both CCP2 and CSI-2. >> >> Signed-off-by: Sakari Ailus >> --- >> drivers/media/video/omap3isp/i

Re: [RFC 09/17] v4l: Add pad op for pipeline validation

2012-01-07 Thread Sakari Ailus
Hi Laurent, Thanks for the review!! Laurent Pinchart wrote: > On Tuesday 20 December 2011 21:28:01 Sakari Ailus wrote: >> From: Sakari Ailus >> >> smiapp_pad_ops.validate_pipeline is intended to validate the full pipeline >> which is implemented by the driver to which the subdev implementing thi

Re: [RFC 14/17] omap3isp: Use pixelrate from sensor media bus frameformat

2012-01-07 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: > On Tuesday 20 December 2011 21:28:06 Sakari Ailus wrote: >> From: Sakari Ailus >> >> Configure the ISP based on the pixelrate in media bus frame format. >> Previously the same was configured from the board code. >> >> Signed-off-by: Sakari Ailus >> --- >> d

Re: [RFC 16/17] smiapp: Add driver.

2012-01-07 Thread Sakari Ailus
Hi Sylwester, Thanks for the review!!! Sylwester Nawrocki wrote: > Hi Sakari, > > I have a just a few comments below. It was rather brief a review, given the > size of the patch.. :-) Good points. I'll make the changes, as well as those Laurent pointed out, and send a new version of the driver.

Re: [RFC 17/17] rm680: Add camera init

2012-01-07 Thread Sakari Ailus
Hi Sylwester, Thanks for the review! Sylwester Nawrocki wrote: > On 12/20/2011 09:28 PM, Sakari Ailus wrote: >> + >> +static int rm680_sec_camera_set_xshutdown(struct v4l2_subdev *subdev, >> u8 set) > > It may be more efficient to just use u32. The function got removed already. ;-) >> +{ >> +

Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-07 Thread Sakari Ailus
Hi Laurent, Thanks for the review!!! Laurent Pinchart wrote: > On Tuesday 20 December 2011 21:28:05 Sakari Ailus wrote: >> From: Sakari Ailus >> >> Configure CSI-2 phy based on platform data in the ISP driver rather than in >> platform code. >> >> Signed-off-by: Sakari Ailus >> --- >> drivers/

Re: [RFC 17/17] rm680: Add camera init

2012-01-07 Thread Sakari Ailus
Hi Laurent, Thanks for the review! Laurent Pinchart wrote: > On Tuesday 20 December 2011 21:28:09 Sakari Ailus wrote: >> This currently introduces an extra file to the arch/arm/mach-omap2 >> directory: board-rm680-camera.c. Keeping the device tree in mind, the >> context of the file could be repr

[PATCH] em28xx: Fix tuner_type for Terratec Cinergy 200 USB

2012-01-07 Thread Sascha Sommer
Hello, the card definition of the Terratec Cinergy 200 USB uses the wrong tuner type. Therefore some channels are currently missing. Attached patch fixes this problem. Regards Sascha Fix tuner type for the Terratec Cinergy 200 USB Signed-off-by: Sascha Sommer diff --git a/drivers/media/video

[PATCH] em28xx: increase maxwidth for em2800

2012-01-07 Thread Sascha Sommer
Hello, The MaxPacketSize for em2800 based devices is too small to capture at full resolution. Therefore scale down when the maximum frame size is selected. The previous workaround that simply reduced the X resolution cannot be used because it crops a part of the input as the em2800 can only sca

[PATCH] em28xx: Do not modify EM28XX_R06_I2C_CLK for em2800

2012-01-07 Thread Sascha Sommer
Hello, writing the EM28XX_R06_I2C_CLK register leads to the problem that the i2c bus on the Terratec Cinergy 200 USB is no longer usable when the system is rebooted. The device needs to be unplugged in order to bring it back to life. Attached patch conditionally disables the write in em28xx_p

[PATCH] em28xx: Fix: I2C_CLK write error message checks wrong return code

2012-01-07 Thread Sascha Sommer
Hello, it looks like the return value check that is done after setting the I2C speed checks the wrong return code. Attached patch fixes this problem. Regards Sascha Fix: I2C_CLK write error message checks wrong return code Signed-off-by: Sascha Sommer diff --git a/drivers/media/video/em28

Re: [ANNOUNCE] DVBv5 tools version 0.0.1

2012-01-07 Thread Mauro Carvalho Chehab
On 07-01-2012 15:29, Honza Petrouš wrote: > Hi Mauro. > > 2012/1/7 Mauro Carvalho Chehab : >> As previously commented at the ML, I'm developing a set of tools >> using DVBv5 API. Instead of starting from something existing, >> I decided to start from scratch, in order to avoid polluting it >> with

cron job: media_tree daily build: ERRORS

2012-01-07 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sat Jan 7 19:05:21 CET 2012 git hash:2f78604a433a12571ec3e54054fbfacc7525b307 gcc version: i686-linux-gcc (GCC

Re: [ANNOUNCE] DVBv5 tools version 0.0.1

2012-01-07 Thread Honza Petrouš
Hi Mauro. 2012/1/7 Mauro Carvalho Chehab : > As previously commented at the ML, I'm developing a set of tools > using DVBv5 API. Instead of starting from something existing, > I decided to start from scratch, in order to avoid polluting it > with DVBv3 legacy stuff. Of course, I did some research

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-07 Thread Sakari Ailus
Laurent Pinchart wrote: > Hi Sakari, > > On Saturday 07 January 2012 12:09:29 Sakari Ailus wrote: >> Sakari Ailus wrote: >> ... >> >>> On second thought, I think I'll combine them into a new anonymous struct >>> the field name of which I call "pad", unless that requires too intrusive >>> changes i

Re: [PATCH 2/2] [media] af9005, af9015: use symbolic names for USB id table indices

2012-01-07 Thread Luca Olivetti
Al 07/01/12 09:11, En/na Jonathan Nieder ha escrit: > The af9005_properties and af9015_properties tables make use of USB ids > from the USB id tables with hardcoded indices, as in > "&af9015_usb_table[30]". Adding new entries before the end breaks > such references, so everyone has had to carefull

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-07 Thread Laurent Pinchart
Hi Sakari, On Saturday 07 January 2012 12:09:29 Sakari Ailus wrote: > Sakari Ailus wrote: > ... > > > On second thought, I think I'll combine them into a new anonymous struct > > the field name of which I call "pad", unless that requires too intrusive > > changes in other drivers. How about that?

Re: cx231xx: possible circular locking dependency detected on 3.2

2012-01-07 Thread Thomas Petazzoni
Le Fri, 6 Jan 2012 22:42:31 +0100, Thomas Petazzoni a écrit : > Hello, > > I'm running the Hauppauge USB-Live 2 device on an ARM OMAP3 platform. > After loading the cx231xx driver and launching v4l2grab, I immediately > get: > > [ 407.087158] cx231xx #0: setPowerMode::mode = 48, No Change req

[PATCH] em28xx: simplify argument passing to em28xx_init_dev()

2012-01-07 Thread Thomas Petazzoni
The 'struct em28xx *' pointer was passed by reference to the em28xx_init_dev() function, for no reason. Instead, just pass it by value, which is much more logical and simple. Signed-off-by: Thomas Petazzoni --- drivers/media/video/em28xx/em28xx-cards.c |5 ++--- 1 files changed, 2 insertions

[PATCH 1/4] cx231xx: use URB_NO_TRANSFER_DMA_MAP on URBs allocated with usb_alloc_urb()

2012-01-07 Thread Thomas Petazzoni
URBs allocated with usb_alloc_urb() are allocated from DMA-coherent areas, and therefore it is not necessary to call dma_map_single() on such buffers. Worst, on ARM, calling dma_map_single() on a DMA-coherent buffer will trigger a BUG_ON() in arch/arm/mm/dma-mapping.c. Therefore, we mark all URBs

[PATCH 4/4] cx231xx: simplify argument passing to cx231xx_init_dev()

2012-01-07 Thread Thomas Petazzoni
The 'struct cx231xx *' pointer was passed by reference to the cx231xx_init_dev() function, for no reason. Instead, just pass it by value, which is much more logical and simple. Signed-off-by: Thomas Petazzoni --- drivers/media/video/cx231xx/cx231xx-cards.c |5 ++--- 1 files changed, 2 insert

[PATCH 3/4] cx231xx: remove useless 'lif' variable in cx231xx_usb_probe()

2012-01-07 Thread Thomas Petazzoni
Now that we set the intfdata on the right interface, the 'lif' variable is useless. Signed-off-by: Thomas Petazzoni --- drivers/media/video/cx231xx/cx231xx-cards.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/media/video/cx231xx/cx231xx-cards.c b/driver

[PATCH 2/4] cx231xx: fix crash after load/unload/load of module

2012-01-07 Thread Thomas Petazzoni
The following sequence of commands was triggering a kernel crash in cdev_get(): modprobe cx231xx rmmod cx231xx modprobe cx231xx v4l2grab -n 1 The problem was that cx231xx_usb_disconnect() was not doing anything because the test: if (!dev->udev) return; was reached (i

Re: [PATCH] v4l2: v4l2-fh: v4l2_fh_is_singular should use list head to test

2012-01-07 Thread Mauro Carvalho Chehab
On 05-01-2012 05:57, Sakari Ailus wrote: > On Thu, Jan 05, 2012 at 10:52:02AM +0800, Scott Jiang wrote: >> 2012/1/4 Sakari Ailus : >>> Hi Scott, >>> >>> Thanks for the patch. >>> >>> On Wed, Dec 21, 2011 at 10:30:54AM -0500, Scott Jiang wrote: list_is_singular accepts a list head to test wheth

[PATCH v3] cx23885: add Terratec Cinergy T PCIe dual

2012-01-07 Thread linxutv
From: Stefan Ringel Signed-off-by: Stefan Ringel --- drivers/media/video/cx23885/cx23885-cards.c | 11 ++ drivers/media/video/cx23885/cx23885-dvb.c | 53 +++ drivers/media/video/cx23885/cx23885.h |1 + 3 files changed, 65 insertions(+), 0 deletions(-)

[ANNOUNCE] DVBv5 tools version 0.0.1

2012-01-07 Thread Mauro Carvalho Chehab
As previously commented at the ML, I'm developing a set of tools using DVBv5 API. Instead of starting from something existing, I decided to start from scratch, in order to avoid polluting it with DVBv3 legacy stuff. Of course, I did some research inside the existing tools, in order to fill in the b

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-07 Thread Sakari Ailus
Sakari Ailus wrote: ... > On second thought, I think I'll combine them into a new anonymous struct > the field name of which I call "pad", unless that requires too intrusive > changes in other drivers. How about that? And the answer to that is "no". The smia++ driver does store the format, crop an

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-07 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: > Hi Sakari, > > On Friday 06 January 2012 12:27:03 Sakari Ailus wrote: >> Laurent Pinchart wrote: >>> On Tuesday 20 December 2011 21:27:56 Sakari Ailus wrote: From: Sakari Ailus Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELE

[PATCH 2/2] [media] af9005, af9015: use symbolic names for USB id table indices

2012-01-07 Thread Jonathan Nieder
The af9005_properties and af9015_properties tables make use of USB ids from the USB id tables with hardcoded indices, as in "&af9015_usb_table[30]". Adding new entries before the end breaks such references, so everyone has had to carefully tiptoe to only add entries at the end of the list. In the

[PATCH 1/2] [media] a800: use symbolic names for a800_table indices

2012-01-07 Thread Jonathan Nieder
The USB id table opens with a comment: /* do not change the order of the ID table */ because the dvb_usb_device_properties::devices field makes use of USB ids using hardcoded indices, as in "&a800_table[1]". Inserting new USB ids before the end of the table can cause these indices to go

[PATCH 0/2] Re: [RFC/PATCH] [media] dw2102: use symbolic names for dw2102_table indices

2012-01-07 Thread Jonathan Nieder
(-cc: Eduard) Mauro Carvalho Chehab wrote: > This looks like a good idea to me. From time to time, when conflict rises, > sometimes those dvb-usb tables with the magic numbers got unnoticed > conflicts. > > So, I'm picking this one. Yay. :) > It should be noticed that this is a common constructo