Laurent Pinchart wrote:
> > > On Saturday 05 November 2011 22:42:01 Clemens Ladisch wrote:
> > > > When enumerating an entity, assign the entire entity specification
> > > > instead of only the first two words. (This requires giving the
> > > > specification union a name.)
>
> Your patch looks go
On Tue, Nov 15, 2011 at 07:49:52PM +0200, Andy Shevchenko wrote:
> This series incorporates Sakari's comments and couple of fixes from my version
> of the driver.
>
> Andy Shevchenko (9):
> as3645a: mention lm3555 as a clone of that chip
> as3645a: print vendor and revision of the chip
> as3
On Tue, Nov 15, 2011 at 05:21:03PM +0100, Laurent Pinchart wrote:
> Hi everybody,
>
> v3 was missing a small bug fix (setting ctrl->cur.val to 0 before adding bits
> in the fault control read code). v4 fixes that (and also includes a cosmetic
> fix).
>
> Laurent Pinchart (2):
> v4l: Add over-cu
On 15 November 2011 22:35, Tim Draper wrote:
> On 15 November 2011 21:48, Malcolm Priestley wrote:
>> On Tue, 2011-11-15 at 18:53 +, Tim Draper wrote:
>>> > Are you sure that your system hasn't rolled to 2.6.38-13-generic
>>> > yesterday or today even?
>>> >
>>> still on 2.6.38-12-generic. i'
lirc_serial_probe() must fail if request_irq() returns an error, even if
it isn't EBUSY or EINVAL,
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_serial.c | 21 +
1 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/media/lirc/li
Device not found? ENODEV, not EINVAL.
Write to read-only device? EPERM, not EBADF.
Invalid argument? EINVAL, not ENOSYS.
Unsupported ioctl? ENOIOCTLCMD, not ENOSYS.
Another function returned an error code? Use that, don't replace it.
Signed-off-by: Ben Hutchings
---
drivers/staging/media/li
A resume function cannot remove the device it is resuming!
Signed-off-by: Ben Hutchings
---
I haven't seen any report of this deadlock, but it seems pretty obvious.
Ben.
drivers/staging/media/lirc/lirc_serial.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers
Failure to allocate the I/O region leaves the IRQ allocated.
A later failure leaves them both allocated.
Reported-by: Torsten Crass
References: http://bugs.debian.org/645811
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_serial.c | 19 ---
1 files changed, 16
Currently the module init function registers a platform_device and
only then allocates its IRQ and I/O region. This allows allocation to
race with the device's suspend() function. Instead, allocate
resources in the platform driver's probe() function and free them in
the remove() function.
The mo
Hi folks,
I'm messing around trying to get my Kworld PC150-U ATSC hybrid tuner
card (17de:a134) to work, and I think I'm almost done. I've been able
to get all of the functionality to work on its own: remote control,
FM, NTSC, composite input, and ATSC, but for some reason, whenever I
use the ATS
Hi Gary,
On Monday 14 November 2011 12:42:54 Gary Thomas wrote:
> On 2011-11-11 07:26, Laurent Pinchart wrote:
> > On Wednesday 09 November 2011 17:24:26 Gary Thomas wrote:
> >> On 2011-11-09 09:18, Laurent Pinchart wrote:
> >>> On Wednesday 09 November 2011 12:01:34 Gary Thomas wrote:
> On 2
Hi Andy,
On Tuesday 15 November 2011 17:55:55 Andy Shevchenko wrote:
> On Tue, 2011-11-15 at 14:12 +0100, Laurent Pinchart wrote:
> > > > +struct as3645a {
> > > > + struct v4l2_subdev subdev;
> > > > + struct as3645a_platform_data *platform_data;
> > > > +
> > > > + struct mutex
Hi Clemens,
On Tuesday 15 November 2011 14:02:21 Clemens Ladisch wrote:
> Laurent Pinchart wrote:
> > On Saturday 05 November 2011 22:42:01 Clemens Ladisch wrote:
> > > When enumerating an entity, assign the entire entity specification
> > > instead of only the first two words. (This requires giv
On 15 November 2011 21:48, Malcolm Priestley wrote:
> On Tue, 2011-11-15 at 18:53 +, Tim Draper wrote:
>> > Are you sure that your system hasn't rolled to 2.6.38-13-generic
>> > yesterday or today even?
>> >
>> still on 2.6.38-12-generic. i've ensured auto-updates are disabled so
>> it should
Hello Hans,
On 11/07/2011 11:37 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> If V4L2_CAP_DEVICE_CAPS is set, then the new device_caps field is filled with
> the capabilities of the opened device node.
>
> The capabilities field traditionally contains the capabilities of the whole
> device. E
> Are you sure that your system hasn't rolled to 2.6.38-13-generic
> yesterday or today even?
>
still on 2.6.38-12-generic. i've ensured auto-updates are disabled so
it should be in the same state as it when it was working.
worth re-applying the update/patch? i presume i just need to make &&
make i
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date:Tue Nov 15 19:00:14 CET 2011
git hash:e9eb0dadba932940f721f9d27544a7818b2fa1c5
gcc version: i686-linux-gcc (GCC
It seems the timeout value couldn't be different for either external or
software strobe (accordingly to as3645a datasheet, table 6).
This patch doesn't prevent to use software watchdog, because it will use
another mechanism to stop strobing (i.e. low "out" pin).
Signed-off-by: Andy Shevchenko
--
Signed-off-by: Andy Shevchenko
---
drivers/media/video/as3645a.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c
index 774f797..5f8fa68 100644
--- a/drivers/media/video/as3645a.c
+++ b/drivers/media/video/as36
Signed-off-by: Andy Shevchenko
---
drivers/media/video/as3645a.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c
index 8882a14..5c7e42f 100644
--- a/drivers/media/video/as3645a.c
+++ b/drivers/media/video/as
Signed-off-by: Andy Shevchenko
---
drivers/media/video/as3645a.c | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c
index 9aebaa2..774f797 100644
--- a/drivers/media/video/as3645a.c
+++ b/drivers/med
Signed-off-by: Andy Shevchenko
---
drivers/media/video/as3645a.c | 23 ---
1 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c
index 541f8bc..9aebaa2 100644
--- a/drivers/media/video/as3645a.c
+++ b/d
Signed-off-by: Andy Shevchenko
---
drivers/media/video/as3645a.c | 12 ++--
include/media/as3645a.h | 32 +---
2 files changed, 19 insertions(+), 25 deletions(-)
diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c
index 108bc0f
Signed-off-by: Andy Shevchenko
---
drivers/media/video/as3645a.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c
index 5c7e42f..108bc0f 100644
--- a/drivers/media/video/as3645a.c
+++ b/drivers/media/video/as3
This series incorporates Sakari's comments and couple of fixes from my version
of the driver.
Andy Shevchenko (9):
as3645a: mention lm3555 as a clone of that chip
as3645a: print vendor and revision of the chip
as3645a: remove unused code
as3645a: No error, no message.
as3645a: move limit
The as3645a_registered() is used to detect connected chip. It would be nice to
print the detected value every time we load the module. The "Vendor" is
probably better word to use there. For example, lm3555 (NSC) is slightly
different to as3645a.
Signed-off-by: Andy Shevchenko
---
drivers/media/v
Signed-off-by: Andy Shevchenko
---
drivers/media/video/as3645a.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c
index a9f857f..ef1226d 100644
--- a/drivers/media/video/as3645a.c
+++ b/drivers/media/video/as36
On Tue, 2011-11-15 at 14:12 +0100, Laurent Pinchart wrote:
> > > +struct as3645a {
> > > + struct v4l2_subdev subdev;
> > > + struct as3645a_platform_data *platform_data;
> > > +
> > > + struct mutex power_lock;
> > > + int power_count;
> > > +
> > > + /* Static parameters */
> > > + u8 vref;
> >
This patch adds the driver for the as3645a LED flash controller. This
controller supports a high power led in flash and torch modes and an
indicator light, sometimes also called privacy light.
Signed-off-by: Laurent Pinchart
Signed-off-by: Nayden Kanchev
Signed-off-by: Tuukka Toivonen
Signed-of
Hi everybody,
v3 was missing a small bug fix (setting ctrl->cur.val to 0 before adding bits
in the fault control read code). v4 fixes that (and also includes a cosmetic
fix).
Laurent Pinchart (2):
v4l: Add over-current and indicator flash fault bits
as3645a: Add driver for LED flash controlle
Flash controllers can report over-current and indicator fault
conditions. Define flash fault control bits for them.
Signed-off-by: Laurent Pinchart
Acked-by: Andy Shevchenko
---
Documentation/DocBook/media/v4l/controls.xml | 10 ++
include/linux/videodev2.h|2 +
Laurent Pinchart wrote:
> Hi Sakari,
Heippa,
> On Tuesday 15 November 2011 16:28:06 Sakari Ailus wrote:
>> Laurent Pinchart wrote:
>>> On Monday 14 November 2011 10:34:57 Sakari Ailus wrote:
>
> [snip]
>
> + if (rval & ~AS_FAULT_INFO_INDICATOR_LED)
> + dev_dbg(&client->dev, "No
Hi Sakari,
On Tuesday 15 November 2011 16:28:06 Sakari Ailus wrote:
> Laurent Pinchart wrote:
> > On Monday 14 November 2011 10:34:57 Sakari Ailus wrote:
[snip]
> >>> + if (rval & ~AS_FAULT_INFO_INDICATOR_LED)
> >>> + dev_dbg(&client->dev, "No faults, nice\n");
> >>> +
> >>> + return rva
This patch adds the driver for the as3645a LED flash controller. This
controller supports a high power led in flash and torch modes and an
indicator light, sometimes also called privacy light.
Signed-off-by: Laurent Pinchart
Signed-off-by: Nayden Kanchev
Signed-off-by: Tuukka Toivonen
Signed-of
Flash controllers can report over-current and indicator fault
conditions. Define flash fault control bits for them.
Signed-off-by: Laurent Pinchart
Acked-by: Andy Shevchenko
---
Documentation/DocBook/media/v4l/controls.xml | 10 ++
include/linux/videodev2.h|2 +
Hi everybody,
Here's the third version of the as3645a flash controller driver.
Compared to v2, it addresses most of Sakari's comments. I've left an unneeded
default case in a switch statement to avoid gcc complaining about uninitialized
variables, and I haven't removed the control values cache fr
Laurent Pinchart wrote:
> Hi Sakari,
Hi Laurent,
> On Monday 14 November 2011 10:34:57 Sakari Ailus wrote:
>> Hi Laurent,
>>
>> Thanks for the patch!! I have a few comments below.
>
> Thanks for the review.
Thanks for the reply to my review. :-)
...
>>> +struct as3645a {
>>> + struct v4l2_s
Sergei,
On Tue, Nov 15, 2011 at 16:10:16, Sergei Shtylyov wrote:
> Hello.
>
> On 14-11-2011 19:09, Manjunath Hadli wrote:
>
> > move the register base addresses and offsets used only by dm644x
> > platform file from platform header dm644x.h to dm644x.c as they are
> > used only in the c file.
Sergei,
On Tue, Nov 15, 2011 at 16:24:49, Sergei Shtylyov wrote:
> Hello.
>
> On 14-11-2011 19:09, Manjunath Hadli wrote:
>
> > include davinci_common.h file in files using the platform header file
> > for dm355, dm365, dm644x and dm646x and delete the individual platform
> > header files.
>
Sergei,
On Tue, Nov 15, 2011 at 15:33:14, Sergei Shtylyov wrote:
> Hello.
>
> On 14-11-2011 19:09, Manjunath Hadli wrote:
>
> > remove the code from individual platform header files for dm365,
> > dm355, dm644x and dm646x and consolidate it into a single and common
> > header file davinci_comm
Hi Sakari,
On Monday 14 November 2011 10:34:57 Sakari Ailus wrote:
> Hi Laurent,
>
> Thanks for the patch!! I have a few comments below.
Thanks for the review.
> Laurent Pinchart wrote:
> > This patch adds the driver for the as3645a LED flash controller. This
> > controller supports a high powe
Laurent Pinchart wrote:
> On Saturday 05 November 2011 22:42:01 Clemens Ladisch wrote:
> > When enumerating an entity, assign the entire entity specification
> > instead of only the first two words. (This requires giving the
> > specification union a name.)
>
> What about this (untested) simpler
On Mon, 2011-11-14 at 11:34 +0200, Sakari Ailus wrote:
> Hi Laurent,
>
> Thanks for the patch!! I have a few comments below.
Most of your comments is about to be addressed by my patches.
Please, wait a bit, And I send my series as I promised.
--
Andy Shevchenko
Intel Finland Oy
--
To unsubsc
On 11/15/2011 01:14 PM, Claus Olesen wrote:
PCTV 290e usb stick - locking issue
===
The locking issue with the 290e is not resolved as of
yesterdays auto update to kernel 3.1.1-1.fc16.i686.PAE on Fedora 16.
The symptoms are that no usb stick is usable unless the em
PCTV 290e usb stick - locking issue
===
The locking issue with the 290e is not resolved as of
yesterdays auto update to kernel 3.1.1-1.fc16.i686.PAE on Fedora 16.
The symptoms are that no usb stick is usable unless the em28xx_dvb
module is manually unloaded and the 2
Hello.
On 14-11-2011 19:09, Manjunath Hadli wrote:
include davinci_common.h file in files using the platform
header file for dm355, dm365, dm644x and dm646x and delete the
individual platform header files.
Signed-off-by: Manjunath Hadli
[...]
diff --git a/drivers/media/video/davinci/vpif.
Hello.
On 14-11-2011 19:09, Manjunath Hadli wrote:
move the register base addresses and offsets used only by dm644x
platform file from platform header dm644x.h to dm644x.c as they
are used only in the c file.
Signed-off-by: Manjunath Hadli
---
arch/arm/mach-davinci/dm644x.c |
Hello.
On 14-11-2011 19:09, Manjunath Hadli wrote:
remove the code from individual platform header files for
dm365, dm355, dm644x and dm646x and consolidate it into a
single and common header file davinci_common.h.
Include the new header file in individual platform header
files as a pre-cursor
48 matches
Mail list logo
