Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Hans de Goede
Hi, Lots of good stuff in this thread! It seems Mauro has answered most things, so I'm just going to respond to this bit. On 09/07/2011 05:37 AM, Devin Heitmueller wrote: We've added a parameter for that on xawtv3 (--alsa-latency). We've parametrized it at the alsa stream function call. So, a

Compiling on 2.6.32-31-generic fails (nightly build server has same problem)

2011-09-06 Thread Lothsahn
I'm using Mythbuntu 10.04 LTS with the 2.6.32-31-generic kernel.  I tried to compile the latest v4l code, and I'm getting the following compile error: /home/lowmanator/media_build/v4l/tda18271-common.c: In function '_tda_printk': /home/lowmanator/media_build/v4l/tda18271-common.c:682: error: sto

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Devin Heitmueller
On Tue, Sep 6, 2011 at 11:42 PM, Devin Heitmueller wrote: > One more thing worth noting before I quit for the night: > > What audio processor is on your WinTV USB 2 device?  The DVC-90 has an > emp202.  Perhaps the WInTV uses a different audio processor (while > still using an em2820 as the bridge

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Devin Heitmueller
On Tue, Sep 6, 2011 at 11:37 PM, Devin Heitmueller wrote: > On Tue, Sep 6, 2011 at 11:29 PM, Mauro Carvalho Chehab > wrote: >>> Basically the above starts at the *maximum* capture resolution and >>> works its way down.  One might argue that this heuristic makes more >>> sense anyway - why *wouldn

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Devin Heitmueller
On Tue, Sep 6, 2011 at 11:29 PM, Mauro Carvalho Chehab wrote: >> Basically the above starts at the *maximum* capture resolution and >> works its way down.  One might argue that this heuristic makes more >> sense anyway - why *wouldn't* you want the highest quality audio >> possible by default (rat

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Mauro Carvalho Chehab
Em 07-09-2011 00:20, Devin Heitmueller escreveu: > On Tue, Sep 6, 2011 at 10:58 PM, Devin Heitmueller > wrote: >> On Tue, Sep 6, 2011 at 11:29 AM, Mauro Carvalho Chehab >> wrote: >>> There are several issues with the original alsa_stream code that got >>> fixed on xawtv3, made by me and by Hans d

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Mauro Carvalho Chehab
Em 06-09-2011 23:58, Devin Heitmueller escreveu: > On Tue, Sep 6, 2011 at 11:29 AM, Mauro Carvalho Chehab > wrote: >> There are several issues with the original alsa_stream code that >> got fixed on xawtv3, made by me and by Hans de Goede. Basically, >> the code were re-written, in order to follo

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Devin Heitmueller
On Tue, Sep 6, 2011 at 10:58 PM, Devin Heitmueller wrote: > On Tue, Sep 6, 2011 at 11:29 AM, Mauro Carvalho Chehab > wrote: >> There are several issues with the original alsa_stream code that got >> fixed on xawtv3, made by me and by Hans de Goede. Basically, the >> code were re-written, in order

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Devin Heitmueller
On Tue, Sep 6, 2011 at 11:29 AM, Mauro Carvalho Chehab wrote: > There are several issues with the original alsa_stream code that got > fixed on xawtv3, made by me and by Hans de Goede. Basically, the > code were re-written, in order to follow the alsa best practises. > > Backport the changes from

Re: [PATCHv2] ISP:BUILD:FIX: Move media_entity_init() and

2011-09-06 Thread Mauro Carvalho Chehab
Em 06-09-2011 11:47, Laurent Pinchart escreveu: > Hi Vaibhav, > > On Tuesday 06 September 2011 16:12:35 Hiremath, Vaibhav wrote: >> On Monday, September 05, 2011 6:20 PM Laurent Pinchart wrote: >>> On Sunday 04 September 2011 15:32:28 Mauro Carvalho Chehab wrote: >> >> >> >>> I don't mind splitti

[PATCH] uvcvideo: Fix crash when linking entities

2011-09-06 Thread Laurent Pinchart
The uvc_mc_register_entity() function wrongfully selects the media_entity associated with a UVC entity when creating links. This results in access to uninitialized media_entity structures and can hit a BUG_ON statement in media_entity_create_link(). Fix it. Signed-off-by: Laurent Pinchart --- dr

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Mauro Carvalho Chehab
Em 06-09-2011 18:18, Devin Heitmueller escreveu: > On Tue, Sep 6, 2011 at 3:12 PM, Mauro Carvalho Chehab > wrote: >>> From a practical standpoint, the Ubuntu folks have the original tvtime >>> tarball and all their changes in one patch, which is clearly a bunch >>> of patches that are mashed toget

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Devin Heitmueller
On Tue, Sep 6, 2011 at 3:12 PM, Mauro Carvalho Chehab wrote: >> From a practical standpoint, the Ubuntu folks have the original tvtime >> tarball and all their changes in one patch, which is clearly a bunch >> of patches that are mashed together probably in their build system. I >> need to reach o

Re: [PATCH v2] [media] at91: add code to initialize and manage the ISI_MCK for Atmel ISI driver.

2011-09-06 Thread Sylwester Nawrocki
On 09/06/2011 10:05 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: >> I'm not entirely sure on this one, but as we had a similar situation with >> clocks, we decided to extablish the clock hierarchy in the board code, and >> only deal with the actual device clocks in the driver itself. I.e., we >> mov

Re: [RFC] Reserved fields in v4l2_mbus_framefmt, v4l2_subdev_format alignment

2011-09-06 Thread Sakari Ailus
On Tue, Sep 06, 2011 at 09:10:17PM +0200, Sylwester Nawrocki wrote: > Hi Sakari, Hi Sylwester, > On 09/05/2011 05:55 PM, Sakari Ailus wrote: > > Hi all, > > > > I recently came across a few issues in the definitions of v4l2_subdev_format > > and v4l2_mbus_framefmt when I was working on sensor co

Re: [PATCH 0/19 v4] s5p-fimc driver conversion to media controller and control framework

2011-09-06 Thread Mauro Carvalho Chehab
Em 03-09-2011 13:32, Sylwester Nawrocki escreveu: > On 09/01/2011 05:30 PM, Sylwester Nawrocki wrote: >> Hello, >> >> following is a fourth version of the patchset converting s5p-fimc driver >> to the media controller API and the new control framework. >> >> Mauro, could you please have a look at t

Re: [PATCH v2] [media] at91: add code to initialize and manage the ISI_MCK for Atmel ISI driver.

2011-09-06 Thread Jean-Christophe PLAGNIOL-VILLARD
On 08:54 Tue 06 Sep , Guennadi Liakhovetski wrote: > On Tue, 6 Sep 2011, Josh Wu wrote: > > > This patch enable the configuration for ISI_MCK, which is provided by > > programmable clock. > > > > Signed-off-by: Josh Wu > > --- > > drivers/media/video/atmel-isi.c | 60 > > +++

Re: [PATCH v4] s5p-fimc: Add runtime PM support in the mem-to-mem driver

2011-09-06 Thread Sylwester Nawrocki
On 09/05/2011 11:20 PM, Sakari Ailus wrote: +static int fimc_suspend(struct device *dev) +{ + struct fimc_dev *fimc = dev_get_drvdata(dev); + + dbg("fimc%d: state: 0x%lx", fimc->id, fimc->state); + + if (test_and_set_bit(ST_LPM,&fimc->state)) + re

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Mauro Carvalho Chehab
Em 06-09-2011 15:41, Devin Heitmueller escreveu: > On Tue, Sep 6, 2011 at 2:19 PM, Hans de Goede wrote: >> I think that what should be done is contact the debian / ubuntu maintainers, >> get any interesting fixes they have which the kl version misses merged, >> and then just declare the kl version

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Michael Krufky
On Tue, Sep 6, 2011 at 2:43 PM, Hans de Goede wrote: > Hi, > > On 09/06/2011 08:35 PM, Michael Krufky wrote: >> >> On Tue, Sep 6, 2011 at 2:19 PM, Hans de Goede  wrote: >>> >>> Hi, >>> >>> On 09/06/2011 06:24 PM, Devin Heitmueller wrote: >>> >>> >>> I've been thinking for a while that perhap

Re: [RFC] Reserved fields in v4l2_mbus_framefmt, v4l2_subdev_format alignment

2011-09-06 Thread Sylwester Nawrocki
Hi Sakari, On 09/05/2011 05:55 PM, Sakari Ailus wrote: > Hi all, > > I recently came across a few issues in the definitions of v4l2_subdev_format > and v4l2_mbus_framefmt when I was working on sensor control that I wanted to > bring up here. The appropriate structure right now look like this: >

cron job: media_tree daily build: ERRORS

2011-09-06 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Tue Sep 6 19:00:19 CEST 2011 git hash:1b19e42952963ae2a09a655f487de15b7c81c5b7 gcc version: i686-linux-gcc (GC

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Hans de Goede
Hi, On 09/06/2011 08:35 PM, Michael Krufky wrote: On Tue, Sep 6, 2011 at 2:19 PM, Hans de Goede wrote: Hi, On 09/06/2011 06:24 PM, Devin Heitmueller wrote: I've been thinking for a while that perhaps the project should be renamed (or I considered prepending "kl" onto the front resulting i

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Devin Heitmueller
On Tue, Sep 6, 2011 at 2:19 PM, Hans de Goede wrote: > I think that what should be done is contact the debian / ubuntu maintainers, > get any interesting fixes they have which the kl version misses merged, > and then just declare the kl version as being the new official upstream > (with the blessi

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Mauro Carvalho Chehab
Em 06-09-2011 13:24, Devin Heitmueller escreveu: > On Tue, Sep 6, 2011 at 11:40 AM, Mauro Carvalho Chehab > wrote: >> Hi Devin, >> >> Em 06-09-2011 12:29, Mauro Carvalho Chehab escreveu: >>> There are several issues with the original alsa_stream code that got >>> fixed on xawtv3, made by me and b

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Michael Krufky
On Tue, Sep 6, 2011 at 2:19 PM, Hans de Goede wrote: > Hi, > > On 09/06/2011 06:24 PM, Devin Heitmueller wrote: > > > >> I've been thinking for a while that perhaps the project should be >> renamed (or I considered prepending "kl" onto the front resulting in >> it being called "kl-tvtime").  This

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Hans de Goede
Hi, On 09/06/2011 06:24 PM, Devin Heitmueller wrote: I've been thinking for a while that perhaps the project should be renamed (or I considered prepending "kl" onto the front resulting in it being called "kl-tvtime"). This isn't out of vanity but rather my concern that the fork will get conf

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Joe Perches
On Tue, 2011-09-06 at 19:23 +0300, Antti Palosaari wrote: > hmm, lets see. Maybe I will add --format=email as keyboard shortcut button. or add [format] pretty = email to your .gitconfig or create and use a check_commitlog shell script or... -- To unsubscribe from this list: send the li

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Devin Heitmueller
On Tue, Sep 6, 2011 at 11:40 AM, Mauro Carvalho Chehab wrote: > Hi Devin, > > Em 06-09-2011 12:29, Mauro Carvalho Chehab escreveu: >> There are several issues with the original alsa_stream code that got >> fixed on xawtv3, made by me and by Hans de Goede. Basically, the >> code were re-written, in

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Antti Palosaari
On 09/06/2011 07:10 PM, Joe Perches wrote: On Tue, 2011-09-06 at 18:30 +0300, Antti Palosaari wrote: On 09/06/2011 06:15 PM, Joe Perches wrote: On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote: So what is recommended way to ensure patch is correct currently? a) before commit Use check

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Joe Perches
On Tue, 2011-09-06 at 18:30 +0300, Antti Palosaari wrote: > On 09/06/2011 06:15 PM, Joe Perches wrote: > > On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote: > >> So what is recommended way to ensure patch is correct currently? > >> a) before commit > > Use checkpatch. > >> b) after commit >

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Antti Palosaari
On 09/06/2011 06:15 PM, Joe Perches wrote: On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote: So what is recommended way to ensure patch is correct currently? a) before commit Use checkpatch. b) after commit Make the output of the commit log look like a patch. --format=email But

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Mauro Carvalho Chehab
Hi Devin, Em 06-09-2011 12:29, Mauro Carvalho Chehab escreveu: > There are several issues with the original alsa_stream code that got > fixed on xawtv3, made by me and by Hans de Goede. Basically, the > code were re-written, in order to follow the alsa best practises. > > Backport the changes fro

Re: How to git and build HVR-2200 drivers from Kernel labs ?

2011-09-06 Thread Steven Toth
>>> Eg should I use the source from "git clone >>> git://kernellabs.com/stoth/saa7164- >>> dev.git" or do you recommend something else that might be more stable ? >> >> pull a snapshot: >> >> >> http://www.kernellabs.com/gitweb/?p=stoth/saa7164-stable.git;a=snapshot;h=87e0c0378bf2068df5d0c43acd66ae

[PATCH 10/10] tvtime: Bump to version 1.0.3

2011-09-06 Thread Mauro Carvalho Chehab
Need to update its version, in order to allow distros to use it. Signed-off-by: Mauro Carvalho Chehab --- ChangeLog|7 +++ NEWS | 10 +- configure.ac |4 ++-- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index 147b822..c6

[PATCH 08/10] Use a saner way to disable screensaver

2011-09-06 Thread Mauro Carvalho Chehab
Backport a Fedora patch that improves the way to disable the screensaver: commit 36cc9d2e1d762eddf5d8278fa58edd4680a7b449 Author: Tomas Smetana Date: Mon Nov 8 22:01:57 2010 +0100 - fix #571339 use a saner way to disable screensaver, thanks to Debian folks for the patch, namely Resul

[PATCH 06/10] Backport UVC fix from Fedora

2011-09-06 Thread Mauro Carvalho Chehab
>From Fedora logs: fix #655038 - tvtime does not work with UVC webcams Signed-off-by: Mauro Carvalho Chehab --- src/videoinput.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/videoinput.c b/src/videoinput.c index 2102b04..a8fd829 100644 --- a/src/videoinput

[PATCH 07/10] Add mkinstalldirs

2011-09-06 Thread Mauro Carvalho Chehab
This is needed for make distcheck to be happy. Not sure why this script is not here already... tvtime 1.0.2 tarball has it. Signed-off-by: Mauro Carvalho Chehab --- mkinstalldirs | 111 +++ src/Makefile.am |3 +- 2 files changed, 113 ins

[PATCH 05/10] Ignore auto-generated files

2011-09-06 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- .gitignore | 17 + docs/.gitignore |3 +++ intl/.gitignore |2 ++ m4/.gitignore |8 po/.gitignore |7 +++ src/.gitignore |9 + 6 files changed, 46 insertions(+), 0 deletions(-) create mo

[PATCH 04/10] Properly document alsa mixer

2011-09-06 Thread Mauro Carvalho Chehab
Backported from Fedora: commit 16ee4edaccd1a6a6869e4abf07581a2f7c6df1fb Author: Tomas Smetana Date: Thu Jul 9 07:09:44 2009 + - fix a typo in the default config file commit a4c64442a7c94cd175bca661e88682ee8de87ce4 Author: Tomas Smetana Date: Sun Jun 28 10:01:27 2009 + - tr

[PATCH 03/10] Backport mixer-alsa patch from Fedora

2011-09-06 Thread Mauro Carvalho Chehab
commit e53212e85a71d831fff3bf61c792ed7235fa3a79 Author: Tomas Smetana Date: Mon May 11 16:24:09 2009 + Added first version of the ALSA mixer patch. Unused yet. Signed-off-by: Mauro Carvalho Chehab --- configure.ac | 12 ++- src/Makefile.am | 15 ++- src/commands.c |8 +

[PATCH 02/10] Fix make dist target

2011-09-06 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 50687c2..3a38aac 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -38,7 +38,7 @@ COMMON_SRCS = mixer.c videoinput.c rtcti

[PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Mauro Carvalho Chehab
There are several issues with the original alsa_stream code that got fixed on xawtv3, made by me and by Hans de Goede. Basically, the code were re-written, in order to follow the alsa best practises. Backport the changes from xawtv, in order to make it to work on a wider range of V4L and sound ada

Re: [RFC] Support for H.264/MPEG4 encoder (VPU) in i.MX27.

2011-09-06 Thread Guennadi Liakhovetski
Hi Javier On Tue, 6 Sep 2011, javier Martin wrote: > Hi, > we are planning to add support to H.264/MPEG4 encoder inside the > i.MX27 to v4l2. It is mainly a hardware module that has the following > features: > > - It needs two input buffers (current frame and previous frame). > - It produces a t

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Joe Perches
On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote: > So what is recommended way to ensure patch is correct currently? > a) before commit Use checkpatch. > b) after commit Make the output of the commit log look like a patch. -- To unsubscribe from this list: send the line "unsubscribe li

[RFC] Support for H.264/MPEG4 encoder (VPU) in i.MX27.

2011-09-06 Thread javier Martin
Hi, we are planning to add support to H.264/MPEG4 encoder inside the i.MX27 to v4l2. It is mainly a hardware module that has the following features: - It needs two input buffers (current frame and previous frame). - It produces a third buffer as output, containing the encoded frame, and generates

Re: [PATCH] arm: omap: Fix build error in ispccdc.c

2011-09-06 Thread Laurent Pinchart
Hi Joerg, On Tuesday 06 September 2011 16:02:15 Joerg Roedel wrote: > The following build error occurs with 3.1-rc5: > > CC drivers/media/video/omap3isp/ispccdc.o > /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c: In > function 'ccdc_lsc_config': > /home/data/repos/l

Re: [PATCHv2] ISP:BUILD:FIX: Move media_entity_init() and

2011-09-06 Thread Laurent Pinchart
Hi Vaibhav, On Tuesday 06 September 2011 16:12:35 Hiremath, Vaibhav wrote: > On Monday, September 05, 2011 6:20 PM Laurent Pinchart wrote: > > On Sunday 04 September 2011 15:32:28 Mauro Carvalho Chehab wrote: > > > > > I don't mind splitting the config option. An alternative would be to > > com

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Antti Palosaari
On 09/06/2011 10:50 AM, Bjørn Mork wrote: Antti Palosaari writes: I am almost sure this have been working earlier, but now it seems like nothing is acceptable for checkpatch.pl! I did surely about 20 --amend and tried to remove everything, without luck. Could someone point out whats new accept

RE: [PATCHv2] ISP:BUILD:FIX: Move media_entity_init() and

2011-09-06 Thread Hiremath, Vaibhav
> -Original Message- > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Monday, September 05, 2011 6:20 PM > To: Mauro Carvalho Chehab > Cc: Hiremath, Vaibhav; Ravi, Deepthy; linux-media@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-o...@vger.kernel.org >

[PATCH] arm: omap: Fix build error in ispccdc.c

2011-09-06 Thread Joerg Roedel
The following build error occurs with 3.1-rc5: CC drivers/media/video/omap3isp/ispccdc.o /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c: In function 'ccdc_lsc_config': /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:2: error: implicit d

Re: [PATCH] v4l2: uvcvideo use after free bug fix

2011-09-06 Thread Yang Ruirui
- Original message - > Hi, > > On Tuesday 06 September 2011 15:02:54 Hans Verkuil wrote: > > On Tuesday, September 06, 2011 14:12:14 Laurent Pinchart wrote: > > > On Tuesday 06 September 2011 14:08:08 Dave Young wrote: > > > > Reported-by: Sitsofe Wheeler > > > > Signed-off-by: Dave Youn

Re: [PATCH] media: Add camera controls for the ov5642 driver

2011-09-06 Thread Sakari Ailus
On Tue, Sep 06, 2011 at 01:03:57PM +, Bastian Hecht wrote: > Hello Sakari, > > 2011/9/6 Sakari Ailus : > > On Tue, Sep 06, 2011 at 09:35:24AM +, Bastian Hecht wrote: > >> Hello Sakari, > >> > >> 2011/9/6 Sakari Ailus : > >> > On Tue, Sep 06, 2011 at 09:01:15AM +, Bastian Hecht wrote: >

Re: use soc-camera mt9m111 with omap3isp

2011-09-06 Thread Laurent Pinchart
Hi Lee, On Tuesday 06 September 2011 15:40:09 LBM wrote: > hi Laurent Pinchart > > you say "Everything is in the latest mainline kernel." but my kernel > just 2.6.32.so I need to migrate the new V4L2 subdev to the old kernel . > please show me the diff You will need to backport all that yourse

Re: [PATCH] v4l2: uvcvideo use after free bug fix

2011-09-06 Thread Laurent Pinchart
Hi, On Tuesday 06 September 2011 15:02:54 Hans Verkuil wrote: > On Tuesday, September 06, 2011 14:12:14 Laurent Pinchart wrote: > > On Tuesday 06 September 2011 14:08:08 Dave Young wrote: > > > Reported-by: Sitsofe Wheeler > > > Signed-off-by: Dave Young > > > Tested-by: Sitsofe Wheeler > > > A

[PATCH/RFC] media: Add camera controls for the ov5642 driver

2011-09-06 Thread Bastian Hecht
The driver now supports automatic/manual gain, automatic/manual white balance, automatic/manual exposure control, vertical flip, brightness control, contrast control and saturation control. Additionally the following effects are available now: rotating the hue in the colorspace, gray scale image an

Re: [RFC/PATCH 0/1] Ignore ctrl_class

2011-09-06 Thread Sakari Ailus
On Tue, Sep 06, 2011 at 02:55:39PM +0200, Hans Verkuil wrote: > On Tuesday, September 06, 2011 13:45:48 Sakari Ailus wrote: > > Hi Hans, > > > > On Tue, Sep 06, 2011 at 01:20:26PM +0200, Hans Verkuil wrote: > > > On Tuesday, September 06, 2011 13:07:42 Sakari Ailus wrote: > > > > Hi, > > > > > >

Re: [PATCH] v4l2: uvcvideo use after free bug fix

2011-09-06 Thread Hans Verkuil
On Tuesday, September 06, 2011 14:12:14 Laurent Pinchart wrote: > Hans, > > On Tuesday 06 September 2011 14:08:08 Dave Young wrote: > > Reported-by: Sitsofe Wheeler > > Signed-off-by: Dave Young > > Tested-by: Sitsofe Wheeler > > Acked-by: Laurent Pinchart > > > > Unplugging uvc video camera

Re: [PATCHv2] adp1653: make ->power() method optional

2011-09-06 Thread Sakari Ailus
Hi Andy, On Thu, Aug 18, 2011 at 04:32:21PM +0300, Andy Shevchenko wrote: > On Thu, 2011-08-18 at 14:51 +0300, Sakari Ailus wrote: > > On Thu, Aug 18, 2011 at 02:32:02PM +0300, Andy Shevchenko wrote: > > > On Thu, 2011-08-18 at 14:22 +0300, Andy Shevchenko wrote: > > > > The ->power() could be a

Re: [PATCH] media: Add camera controls for the ov5642 driver

2011-09-06 Thread Bastian Hecht
Hello Sakari, 2011/9/6 Sakari Ailus : > On Tue, Sep 06, 2011 at 09:35:24AM +, Bastian Hecht wrote: >> Hello Sakari, >> >> 2011/9/6 Sakari Ailus : >> > On Tue, Sep 06, 2011 at 09:01:15AM +, Bastian Hecht wrote: >> >> 2011/9/6 Sakari Ailus : >> >> > On Tue, Sep 06, 2011 at 07:56:40AM +,

Re: [RFC/PATCH 0/1] Ignore ctrl_class

2011-09-06 Thread Hans Verkuil
On Tuesday, September 06, 2011 13:45:48 Sakari Ailus wrote: > Hi Hans, > > On Tue, Sep 06, 2011 at 01:20:26PM +0200, Hans Verkuil wrote: > > On Tuesday, September 06, 2011 13:07:42 Sakari Ailus wrote: > > > Hi, > > > > > > I remember being in a discussion a while ago regarding the requirement of

Re: [PATCH] media: Add camera controls for the ov5642 driver

2011-09-06 Thread Sakari Ailus
On Tue, Sep 06, 2011 at 09:35:24AM +, Bastian Hecht wrote: > Hello Sakari, > > 2011/9/6 Sakari Ailus : > > On Tue, Sep 06, 2011 at 09:01:15AM +, Bastian Hecht wrote: > >> 2011/9/6 Sakari Ailus : > >> > On Tue, Sep 06, 2011 at 07:56:40AM +, Bastian Hecht wrote: > >> >> Hello Sakari! > >

Re: [RFC] New class for low level sensors controls?

2011-09-06 Thread Sakari Ailus
On Tue, Sep 06, 2011 at 01:41:11PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Tuesday 06 September 2011 13:36:53 Sakari Ailus wrote: > > Hi all, > > > > We are beginning to have raw bayer image sensor drivers in the mainline. > > Typically such sensors are not controlled by general purpos

Re: [PATCH] v4l2: uvcvideo use after free bug fix

2011-09-06 Thread Laurent Pinchart
Hans, On Tuesday 06 September 2011 14:08:08 Dave Young wrote: > Reported-by: Sitsofe Wheeler > Signed-off-by: Dave Young > Tested-by: Sitsofe Wheeler > Acked-by: Laurent Pinchart > > Unplugging uvc video camera trigger following oops: > > eeepc kernel: [ 1393.500719] usb 3-2: USB disconnect,

[PATCH] v4l2: uvcvideo use after free bug fix

2011-09-06 Thread Dave Young
Reported-by: Sitsofe Wheeler Signed-off-by: Dave Young Tested-by: Sitsofe Wheeler Acked-by: Laurent Pinchart Unplugging uvc video camera trigger following oops: eeepc kernel: [ 1393.500719] usb 3-2: USB disconnect, device number 4 eeepc kernel: [ 1393.504351] uvcvideo: Failed to resubmit vide

Re: [RFC/PATCH 0/1] Ignore ctrl_class

2011-09-06 Thread Sakari Ailus
Hi Hans, On Tue, Sep 06, 2011 at 01:20:26PM +0200, Hans Verkuil wrote: > On Tuesday, September 06, 2011 13:07:42 Sakari Ailus wrote: > > Hi, > > > > I remember being in a discussion a while ago regarding the requirement of > > having all the controls belonging to the same class in > > VIDIOC_{TRY

Re: [RFC] New class for low level sensors controls?

2011-09-06 Thread Laurent Pinchart
Hi Sakari, On Tuesday 06 September 2011 13:36:53 Sakari Ailus wrote: > Hi all, > > We are beginning to have raw bayer image sensor drivers in the mainline. > Typically such sensors are not controlled by general purpose applications > but e.g. require a camera control algorithm framework in user s

[RFC] New class for low level sensors controls?

2011-09-06 Thread Sakari Ailus
Hi all, We are beginning to have raw bayer image sensor drivers in the mainline. Typically such sensors are not controlled by general purpose applications but e.g. require a camera control algorithm framework in user space. This needs to be implemented in libv4l for general purpose applications to

Re: [media-ctl][PATCHv5 1/5] libmediactl: restruct error path

2011-09-06 Thread Laurent Pinchart
Hi Andy, On Tuesday 06 September 2011 12:50:25 Andy Shevchenko wrote: > On Tue, 2011-09-06 at 13:46 +0300, Andy Shevchenko wrote: > > On Tue, 2011-09-06 at 12:25 +0200, Laurent Pinchart wrote: > > > I've slightly modified 1/5 and 3/5 (the first one returned -1 from > > > media_enum_entities(), whi

Re: [RFC/PATCH 0/1] Ignore ctrl_class

2011-09-06 Thread Hans Verkuil
On Tuesday, September 06, 2011 13:07:42 Sakari Ailus wrote: > Hi, > > I remember being in a discussion a while ago regarding the requirement of > having all the controls belonging to the same class in > VIDIOC_{TRY,S,G}_EXT_CTRLS. The answer I remember was that there was a > historical reason for

[RFC/PATCH 1/1] v4l: Ignore ctrl_class

2011-09-06 Thread Sakari Ailus
Back in the old days there was probably a reason to require that controls that are being used to access using VIDIOC_{TRY,G,S}_EXT_CTRLS belonged to the same class. These days such reason does not exist, or at least cannot be remembered, and concrete examples of the opposite can be seen: a single (

[RFC/PATCH 0/1] Ignore ctrl_class

2011-09-06 Thread Sakari Ailus
Hi, I remember being in a discussion a while ago regarding the requirement of having all the controls belonging to the same class in VIDIOC_{TRY,S,G}_EXT_CTRLS. The answer I remember was that there was a historical reason for this and it no longer exists. So here's the patch. The changes in driv

Re: [media-ctl][PATCHv5 1/5] libmediactl: restruct error path

2011-09-06 Thread Andy Shevchenko
On Tue, 2011-09-06 at 13:46 +0300, Andy Shevchenko wrote: > On Tue, 2011-09-06 at 12:25 +0200, Laurent Pinchart wrote: > > I've slightly modified 1/5 and 3/5 (the first one returned -1 from > > media_enum_entities(), which made media-ctl stop with a failure message) > > and > > pushed the resu

Re: [media-ctl][PATCHv5 1/5] libmediactl: restruct error path

2011-09-06 Thread Andy Shevchenko
On Tue, 2011-09-06 at 12:25 +0200, Laurent Pinchart wrote: > I've slightly modified 1/5 and 3/5 (the first one returned -1 from > media_enum_entities(), which made media-ctl stop with a failure message) and > pushed the result to the repository. Okay. I looked at them. One minor comment: udef_un

Re: [PATCH 1/2 v5] media: Add support for arbitrary resolution

2011-09-06 Thread Laurent Pinchart
Hi Bastian, On Tuesday 06 September 2011 11:19:05 Bastian Hecht wrote: > This patch adds the ability to get arbitrary resolutions with a width > up to 2592 and a height up to 720 pixels instead of the standard 1280x720 > only. > > Signed-off-by: Bastian Hecht Acked-by: Laurent Pinchart Finall

Re: [PATCH] mt9p031: Do not use PLL if external frequency is the same as target frequency.

2011-09-06 Thread javier Martin
On 6 September 2011 12:27, Laurent Pinchart wrote: > Hi Javier, > > On Tuesday 06 September 2011 12:03:00 Javier Martin wrote: >> This patch adds a check to see whether ext_freq and target_freq are equal >> and, if true, PLL won't be used. > > Thanks for the patch. > > As you're touching PLL code,

Re: [PATCH] mt9p031: Do not use PLL if external frequency is the same as target frequency.

2011-09-06 Thread Laurent Pinchart
Hi Javier, On Tuesday 06 September 2011 12:03:00 Javier Martin wrote: > This patch adds a check to see whether ext_freq and target_freq are equal > and, if true, PLL won't be used. Thanks for the patch. As you're touching PLL code, what about fixing PLL setup by computing parameters dynamically

Re: [media-ctl][PATCHv5 1/5] libmediactl: restruct error path

2011-09-06 Thread Laurent Pinchart
Hi Andy, Thank you for the patches. I've slightly modified 1/5 and 3/5 (the first one returned -1 from media_enum_entities(), which made media-ctl stop with a failure message) and pushed the result to the repository. I've also added another patch to fix autoconf malloc/realloc tests when cross

[PATCH] mt9p031: Do not use PLL if external frequency is the same as target frequency.

2011-09-06 Thread Javier Martin
This patch adds a check to see whether ext_freq and target_freq are equal and, if true, PLL won't be used. Signed-off-by: Javier Martin --- drivers/media/video/mt9p031.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/mt9p031.c b/dri

Re: [PATCH] media: Add camera controls for the ov5642 driver

2011-09-06 Thread Bastian Hecht
Hello Sakari, 2011/9/6 Sakari Ailus : > On Tue, Sep 06, 2011 at 09:01:15AM +, Bastian Hecht wrote: >> 2011/9/6 Sakari Ailus : >> > On Tue, Sep 06, 2011 at 07:56:40AM +, Bastian Hecht wrote: >> >> Hello Sakari! >> > >> > Hi Bastian, >> > >> >> 2011/9/6 Sakari Ailus : >> >> > Hi Bastian, >>

[PATCH 1/2 v5] media: Add support for arbitrary resolution

2011-09-06 Thread Bastian Hecht
This patch adds the ability to get arbitrary resolutions with a width up to 2592 and a height up to 720 pixels instead of the standard 1280x720 only. Signed-off-by: Bastian Hecht --- diff --git a/drivers/media/video/ov5642.c b/drivers/media/video/ov5642.c index 6410bda..e52fdb1 100644 --- a/drive

Re: [PATCH 1/2 v4] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-06 Thread Bastian Hecht
I forgot the sign-off and just discovered checkpatch errors. I'll repost the fixed version. Sorry for spam. 2011/9/6 Bastian Hecht : > This patch adds the ability to get arbitrary resolutions with a width > up to 2592 and a height up to 720 pixels instead of the standard 1280x720 > only. > > --- >

Re: Getting started with OMAP3 ISP

2011-09-06 Thread Enrico
On Tue, Sep 6, 2011 at 10:49 AM, Laurent Pinchart wrote: > On Monday 05 September 2011 18:37:04 you wrote: >> Yes that was the first thing i tried, anyway now i have it finally >> working. Well at least yavta doesn't hang, do you know some >> application to see raw yuv images? I made a typo since

Re: [PATCH] media: Add camera controls for the ov5642 driver

2011-09-06 Thread Sakari Ailus
On Tue, Sep 06, 2011 at 09:01:15AM +, Bastian Hecht wrote: > 2011/9/6 Sakari Ailus : > > On Tue, Sep 06, 2011 at 07:56:40AM +, Bastian Hecht wrote: > >> Hello Sakari! > > > > Hi Bastian, > > > >> 2011/9/6 Sakari Ailus : > >> > Hi Bastian, > >> > > >> > On Mon, Sep 05, 2011 at 09:32:55AM +00

[PATCH 1/2 v4] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-06 Thread Bastian Hecht
This patch adds the ability to get arbitrary resolutions with a width up to 2592 and a height up to 720 pixels instead of the standard 1280x720 only. --- diff --git a/drivers/media/video/ov5642.c b/drivers/media/video/ov5642.c index 6410bda..3d7038c 100644 --- a/drivers/media/video/ov5642.c +++ b/

Re: Getting started with OMAP3 ISP

2011-09-06 Thread Enrico
On Tue, Sep 6, 2011 at 10:48 AM, Laurent Pinchart wrote: > On Monday 05 September 2011 18:37:04 Enrico wrote: >> Now the problem is that the fix is weird...as you suggested you must >> use half height values for VD0 and VD1 (2/3) interrupts, problem is >> that it only works if you DISABLE vd1 inte

Re: [PATCH] media: Add camera controls for the ov5642 driver

2011-09-06 Thread Bastian Hecht
2011/9/6 Sakari Ailus : > On Tue, Sep 06, 2011 at 07:56:40AM +, Bastian Hecht wrote: >> Hello Sakari! > > Hi Bastian, > >> 2011/9/6 Sakari Ailus : >> > Hi Bastian, >> > >> > On Mon, Sep 05, 2011 at 09:32:55AM +, Bastian Hecht wrote: >> >> 2011/9/1 Sakari Ailus : >> >> > On Thu, Sep 01, 2011

Re: use soc-camera mt9m111 with omap3isp

2011-09-06 Thread Laurent Pinchart
Hi Lee, On Tuesday 06 September 2011 10:23:30 LBM wrote: > hi Laurent Pinchart > thank you very much! > > now i find the "Sub-device pad-level operations " come from you > http://lwn.net/Articles/427934/ > > so if you can give me the full codes about this patchs? Everything is in the latest m

Re: Getting started with OMAP3 ISP

2011-09-06 Thread Laurent Pinchart
Hi Enrico, (CC'ing Hans de Goede) On Monday 05 September 2011 18:37:04 Enrico wrote: > On Fri, Sep 2, 2011 at 1:27 PM, Laurent Pinchart wrote: > > On Friday 02 September 2011 11:02:23 Enrico wrote: > >> Right now my problem is that i can't get the isp to generate > >> interrupts, i think there is

Re: [PATCH] at91: add Atmel ISI and ov2640 support on m10/g45 board.

2011-09-06 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:55 Mon 05 Sep , Wu, Josh wrote: > > > On 09/03/2011 2:22 AM Jean-Christophe PLAGNIOL-VILLARD wrote: > > >> > >> #include > >> #include > >> @@ -194,6 +197,95 @@ static void __init ek_add_device_nand(void) > >>at91_add_device_nand(&ek_nand_data); > >> } > >> > >> +/* > >>

Re: [PATCH] media: Add camera controls for the ov5642 driver

2011-09-06 Thread Sakari Ailus
On Tue, Sep 06, 2011 at 07:56:40AM +, Bastian Hecht wrote: > Hello Sakari! Hi Bastian, > 2011/9/6 Sakari Ailus : > > Hi Bastian, > > > > On Mon, Sep 05, 2011 at 09:32:55AM +, Bastian Hecht wrote: > >> 2011/9/1 Sakari Ailus : > >> > On Thu, Sep 01, 2011 at 11:14:08AM +0200, Sylwester Nawro

Re: BUG: unable to handle kernel paging request at 6b6b6bcb (v4l2_device_disconnect+0x11/0x30)

2011-09-06 Thread Laurent Pinchart
On Tuesday 06 September 2011 00:31:03 Sitsofe Wheeler wrote: > On Mon, Sep 05, 2011 at 12:16:42PM +0200, Hans Verkuil wrote: > > On Monday, September 05, 2011 12:13:26 Hans Verkuil wrote: > > > The original order is correct, but what I missed is that for drivers > > > that release (free) everything

Re: [media-ctl][PATCHv4 3/3] libmediactl: get the device name via udev

2011-09-06 Thread Andy Shevchenko
On Mon, 2011-09-05 at 16:57 +0200, Laurent Pinchart wrote: > > > This will break binary compatibility if an application creates a struct > > > media_device instances itself. On the other hand applications are not > > > supposed to do that. > > > > > > As the struct udev pointer is only used inter

Re: use soc-camera mt9m111 with omap3isp

2011-09-06 Thread Laurent Pinchart
Hi Lee, On Tuesday 06 September 2011 07:07:34 LBM wrote: > hi my friend > i use the omap3530 board from "ema-tech",which is the third of TI. > Now i use the mt9m111,it's very difficulty for me to get the images > from this sensor ,becaus it just a soc-camera. can you tell me how to use > this sens

Re: BUG: unable to handle kernel paging request at 6b6b6bcb (v4l2_device_disconnect+0x11/0x30)

2011-09-06 Thread Dave Young
On Tue, Sep 6, 2011 at 6:31 AM, Sitsofe Wheeler wrote: > On Mon, Sep 05, 2011 at 12:16:42PM +0200, Hans Verkuil wrote: >> On Monday, September 05, 2011 12:13:26 Hans Verkuil wrote: >> > >> > The original order is correct, but what I missed is that for drivers >> > that release (free) everything in

Re: [PATCH] media: Add camera controls for the ov5642 driver

2011-09-06 Thread Bastian Hecht
Hello Sakari! 2011/9/6 Sakari Ailus : > Hi Bastian, > > On Mon, Sep 05, 2011 at 09:32:55AM +, Bastian Hecht wrote: >> 2011/9/1 Sakari Ailus : >> > On Thu, Sep 01, 2011 at 11:14:08AM +0200, Sylwester Nawrocki wrote: >> >> Hi Sakari, >> >> >> >> On 09/01/2011 10:47 AM, Sakari Ailus wrote: >> >>

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Bjørn Mork
Antti Palosaari writes: > I am almost sure this have been working earlier, but now it seems like > nothing is acceptable for checkpatch.pl! I did surely about 20 --amend > and tried to remove everything, without luck. Could someone point out > whats new acceptable logging format for checkpatch.pl

Re: migrate soc-camera to V4L2

2011-09-06 Thread Guennadi Liakhovetski
On Tue, 6 Sep 2011, LBM wrote: > hi Guennadi >thank you very much! > but,how can i port mt9m111 to work with omap3?can you give me some > examples? I'm hoping to get a fixed version of Hans' patches by the end of the day today. After that the use of struct soc_camera_device has to be el

Re: migrate soc-camera to V4L2

2011-09-06 Thread Guennadi Liakhovetski
Hi Lee On Tue, 6 Sep 2011, LBM wrote: > hi Guennadi > I used Hans's codes about "migrate soc-camera to the new V4L2 > control framework".There is a problem,the programe can't go to exec the > function "soc_camera_probe()". You don't need it. > I find some information,that say it need