[PATH v2] cxd2820r: fix possible out-of-array lookup

2011-07-28 Thread HoP
When I2C_WRITE is used the msg[] array contains one element only. Don't access msg[1] in that case. Also moved rest of msg2[1] setting to be used only if needed. Signed-off-by: Honza Petrous --- diff -r ae517614bf00 drivers/media/dvb/frontends/cxd2820r_core.c --- a/drivers/media/dvb/frontends/c

Re: [PATCH v3] tuner_xc2028: Allow selection of the frequency adjustment code for XC3028

2011-07-28 Thread Alina Friedrichsen
Hi Mauro and Devin, first I'm a she. > Could you please check if the enclosed patch fixes the tuner issue? > > Use it instead of the patch you've made. If it doesn't work, please send > us > the dmesg logs with tuner-xc2028 debug enabled. Great, it works! :) Much, much thanks. Please let this

[PATCH 1/2] [media] rc-main: Fix device de-registration logic

2011-07-28 Thread Mauro Carvalho Chehab
rc unregister logic were deadly broken, preventing some drivers to be removed. Among the broken things, rc_dev_uevent() is being called during device_del(), causing a data filling on an area that it is not ready anymore. Also, some drivers have a stop callback defined, that needs to be called befo

[PATCH 2/2] [media] em28xx: Fix IR unregister logic

2011-07-28 Thread Mauro Carvalho Chehab
The input stop() callback already calls the em28xx_ir_stop method. Calling it again causes an oops. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/video/em28xx/em28xx-input.c b/drivers/media/video/em28xx/em28xx-input.c index 5d12b14..679da48 100644 --- a/drivers/media/video/em2

Re: linux-next: build failure after merge of the moduleh tree

2011-07-28 Thread Stephen Rothwell
Hi Paul, On Fri, 29 Jul 2011 15:25:33 +1000 Stephen Rothwell wrote: > > After merging the moduleh tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/media/rc/ir-raw.c: In function 'init_decoders': > drivers/media/rc/ir-raw.c:354:2: error: implicit declaration o

linux-next: build failure after merge of the moduleh tree

2011-07-28 Thread Stephen Rothwell
Hi Paul, After merging the moduleh tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/media/rc/ir-raw.c: In function 'init_decoders': drivers/media/rc/ir-raw.c:354:2: error: implicit declaration of function 'request_module' I have added this patch for today: From: S

Re: [GIT PATCHES FOR 3.1] s5p-fimc and noon010pc30 driver updates

2011-07-28 Thread Mauro Carvalho Chehab
Em 28-07-2011 19:57, Sylwester Nawrocki escreveu: > On 07/28/2011 03:20 PM, Mauro Carvalho Chehab wrote: >> Accumulating sub-dev controls at the video node is the right thing to do. >> >> An MC-aware application will need to handle with that, but that doesn't >> sound to >> be hard. All such appl

Re: [GIT PATCHES FOR 3.1] s5p-fimc and noon010pc30 driver updates

2011-07-28 Thread Sylwester Nawrocki
On 07/28/2011 03:20 PM, Mauro Carvalho Chehab wrote: >>> In summary: The V4L2 API is not a legacy API that needs a "compatibility >>> mode". Removing controls like VIDIOC_S_INPUT, VIDIOC_*CTRL, etc in >>> favor of the media controller API is wrong. This specific patch itself seems >> >> Yes, it's t

[PATCH 2/2] af9015: use logic or instead of sum numbers

2011-07-28 Thread Antti Palosaari
Style issue. Signed-off-by: Antti Palosaari --- drivers/media/dvb/dvb-usb/af9015.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/af9015.c b/drivers/media/dvb/dvb-usb/af9015.c index 1fb8248..3e7e9d9 100644 --- a/driv

[PATCH 1/2] af9015: map remote for Leadtek WinFast DTV2000DS

2011-07-28 Thread Antti Palosaari
Thanks to Thomas Gutzler for reporting this. Signed-off-by: Antti Palosaari Cc: Thomas Gutzler --- drivers/media/dvb/dvb-usb/af9015.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/af9015.c b/drivers/media/dvb/dvb-usb/af9015.c index d7ad05f.

[PATCH] em28xx: use MFE lock for PCTV nanoStick T2 290e

2011-07-28 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/video/em28xx/em28xx-dvb.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-dvb.c b/drivers/media/video/em28xx/em28xx-dvb.c index ab8a740..b9cfe93 100644 --- a/drivers/media/video/em28

[PATCH 3/3] anysee: use multi-frontend (MFE)

2011-07-28 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/dvb/dvb-usb/anysee.c | 299 --- drivers/media/dvb/dvb-usb/anysee.h |1 + 2 files changed, 206 insertions(+), 94 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/anysee.c b/drivers/media/dvb/dvb-usb/anyse

[PATCH 2/3] dvb-usb: multi-frontend support (MFE)

2011-07-28 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 85 +++--- drivers/media/dvb/dvb-usb/dvb-usb-init.c |4 ++ drivers/media/dvb/dvb-usb/dvb-usb.h | 11 +++- 3 files changed, 78 insertions(+), 22 deletions(-) diff --git a/drivers/

Re: [PATCH 2/3] v4l: events: Define frame start event

2011-07-28 Thread Laurent Pinchart
Hi Sakari, On Thursday 28 July 2011 22:28:57 Sakari Ailus wrote: > On Thu, Jul 28, 2011 at 01:52:21PM +0200, Laurent Pinchart wrote: > > On Tuesday 26 July 2011 20:49:43 Sakari Ailus wrote: [snip] > > > + > > > + struct > > > v4l2_event_frame_sync + > > cols="3"> > > > + &cs-str;

Re: [PATCH 2/3] v4l: events: Define frame start event

2011-07-28 Thread Sakari Ailus
On Thu, Jul 28, 2011 at 01:52:21PM +0200, Laurent Pinchart wrote: > Hi Sakari, Hi Laurent, Thanks for the comments! > On Tuesday 26 July 2011 20:49:43 Sakari Ailus wrote: > > Define a frame start event to tell user space when the reception of a frame > > starts. > > You might want to rename 'fr

Re: [PATCH v3] tuner_xc2028: Allow selection of the frequency adjustment code for XC3028

2011-07-28 Thread Mauro Carvalho Chehab
Alina, Em 22-07-2011 15:35, Alina Friedrichsen escreveu: > Since many, many kernel releases my Hauppauge WinTV HVR-1400 doesn't work > anymore, and nobody feels responsible to fix it. Could you please check if the enclosed patch fixes the tuner issue? Use it instead of the patch you've made. If

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-28 Thread Jose Alberto Reguero
On Miércoles, 27 de Julio de 2011 21:22:26 Antti Palosaari escribió: > On 07/24/2011 12:45 AM, Jose Alberto Reguero wrote: > > Read without write work as with write. Attached updated patch. > > > > ttusb2-6.diff > > > > - read = i+1< num&& (msg[i+1].flags& I2C_M_RD); > > +

[PATCH 2/2] tda18271c2dd: Fix saw filter configuration for DVB-6 @ 6MHz

2011-07-28 Thread Mauro Carvalho Chehab
Currently, the driver assumes that all QAM carriers are spaced with 8MHz. This is wrong, and may decrease QoS on Countries like Brazil, that have DVB-C carriers with 6MHz-spaced. Fortunately, both ITU-T J-83 and EN 300 429 specifies a way to associate the symbol rate with the bandwidth needed for

[PATCH 1/2] em28xx: Fix DVB-C maxsize for em2884

2011-07-28 Thread Mauro Carvalho Chehab
The logic at em28xx_isoc_dvb_max_packetsize() sucks, at least for newer chips: it just returns a magic number. There's no code there to guess the needed packet size. Yet, it is better than nothing. Rewrite the code in order to change the default to 752 for em2884 and newer chips and provide a bett

[PATCH 0/2] Some fixes for DVB-C with DRX-K

2011-07-28 Thread Mauro Carvalho Chehab
Those two fixes are needed in order to properly support DVB-C with Terratec H5 here in Brazil. After those, the quality of the image for DVB-C is now acceptable. Mauro Carvalho Chehab (2): em28xx: Fix DVB-C maxsize for em2884 tda18271c2dd: Fix saw filter configuration for DVB-6 @ 6MHz driver

[cron job] v4l-dvb daily build: ERRORS

2011-07-28 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Thu Jul 28 19:00:47 CEST 2011 git hash:3d589db03f09c1ace6f71849085595f1f114cd3c gcc version: i686-linux-gcc (GCC) 4.5

RFC: Negotiating frame buffer size between sensor subdevs and bridge devices

2011-07-28 Thread Sylwester Nawrocki
Hello, Trying to capture images in JPEG format with regular "image sensor -> mipi-csi receiver -> host interface" H/W configuration I've found there is no standard way to communicate between the sensor subdev and the host driver what is exactly a required maximum buffer size to capture a frame.

[PATCH 2/2] af9015: use logic or instead of sum numbers

2011-07-28 Thread Antti Palosaari
Style issue. Signed-off-by: Antti Palosaari --- drivers/media/dvb/dvb-usb/af9015.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/af9015.c b/drivers/media/dvb/dvb-usb/af9015.c index 1fb8248..3e7e9d9 100644 --- a/dr

[PATCH 1/2] af9015: map remote for Leadtek WinFast DTV2000DS

2011-07-28 Thread Antti Palosaari
Thanks to Thomas Gutzler for reporting this. Signed-off-by: Antti Palosaari Cc: Thomas Gutzler --- drivers/media/dvb/dvb-usb/af9015.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/af9015.c b/drivers/media/dvb/dvb-usb/af9015.c index d7ad05

[PATCH 1/2] af9015: map remote for Leadtek WinFast DTV2000DS

2011-07-28 Thread Antti Palosaari
Thanks to Thomas Gutzler for reporting this. Signed-off-by: Antti Palosaari Cc: Thomas Gutzler --- -- http://palosaari.fi/ drivers/media/dvb/dvb-usb/af9015.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/af9015.c b/drivers/media/dvb/dvb

Re: [git:v4l-dvb/for_v3.1] [media] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam on HP Mini 5103 netbook

2011-07-28 Thread Kirill Smelkov
On Thu, Jul 28, 2011 at 11:55:04AM -0300, Mauro Carvalho Chehab wrote: > Em 28-07-2011 10:54, Kirill Smelkov escreveu: > > Mauro, thanks for answering, > > > > On Thu, Jul 28, 2011 at 10:45:29AM -0300, Mauro Carvalho Chehab wrote: > >> Em 28-07-2011 08:42, Kirill Smelkov escreveu: > >>> On Wed, Ju

Re: [git:v4l-dvb/for_v3.1] [media] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam on HP Mini 5103 netbook

2011-07-28 Thread Mauro Carvalho Chehab
Em 28-07-2011 10:54, Kirill Smelkov escreveu: > Mauro, thanks for answering, > > On Thu, Jul 28, 2011 at 10:45:29AM -0300, Mauro Carvalho Chehab wrote: >> Em 28-07-2011 08:42, Kirill Smelkov escreveu: >>> On Wed, Jul 27, 2011 at 09:42:08PM +0200, Mauro Carvalho Chehab wrote: This is an automa

[PATCH] em28xx: use MFE lock for PCTV nanoStick T2 290e

2011-07-28 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/video/em28xx/em28xx-dvb.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-dvb.c b/drivers/media/video/em28xx/em28xx-dvb.c index ab8a740..b9cfe93 100644 --- a/drivers/media/video/em

Re: [PATCHv2] adp1653: check error code of adp1653_init_controls

2011-07-28 Thread Laurent Pinchart
Hi Andy, On Thursday 28 July 2011 09:59:38 Andy Shevchenko wrote: > Potentially the adp1653_init_controls could return an error. In our case > the error was ignored, meanwhile it means incorrect initialization of V4L2 > controls. Additionally we have to free control handler structures in case > of

Re: [git:v4l-dvb/for_v3.1] [media] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam on HP Mini 5103 netbook

2011-07-28 Thread Kirill Smelkov
Mauro, thanks for answering, On Thu, Jul 28, 2011 at 10:45:29AM -0300, Mauro Carvalho Chehab wrote: > Em 28-07-2011 08:42, Kirill Smelkov escreveu: > > On Wed, Jul 27, 2011 at 09:42:08PM +0200, Mauro Carvalho Chehab wrote: > >> This is an automatic generated email to let you know that the followin

Re: [git:v4l-dvb/for_v3.1] [media] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam on HP Mini 5103 netbook

2011-07-28 Thread Mauro Carvalho Chehab
Em 28-07-2011 08:42, Kirill Smelkov escreveu: > On Wed, Jul 27, 2011 at 09:42:08PM +0200, Mauro Carvalho Chehab wrote: >> This is an automatic generated email to let you know that the following >> patch were queued at the >> http://git.linuxtv.org/media_tree.git tree: >> >> Subject: [media] uvcvi

Re: [GIT PATCHES FOR 3.1] s5p-fimc and noon010pc30 driver updates

2011-07-28 Thread Mauro Carvalho Chehab
Em 28-07-2011 07:09, Sylwester Nawrocki escreveu: > Hi Mauro, > > On 07/28/2011 04:55 AM, Mauro Carvalho Chehab wrote: >> Hi Sylwester, >> >> Em 27-07-2011 13:35, Sylwester Nawrocki escreveu: >>> Hi Mauro, >> In summary: The V4L2 API is not a legacy API that needs a "compatibility >> mode". Removi

[PATCH 2/6] drivers/media/dvb/dvb-usb/usb-urb.c: adjust array index

2011-07-28 Thread Julia Lawall
From: Julia Lawall Convert array index from the loop bound to the loop index. A simplified version of the semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2,ar; @@ for(e1 = 0; e1 < e2; e1++) { <... ar[ - e2 + e1 ] ...> } // Signed

Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

2011-07-28 Thread Hans Verkuil
On Thursday, July 28, 2011 14:29:38 Guennadi Liakhovetski wrote: > On Thu, 28 Jul 2011, Hans Verkuil wrote: > > > On Thursday, July 28, 2011 06:11:38 Pawel Osciak wrote: > > > Hi Guennadi, > > > > > > On Wed, Jul 20, 2011 at 01:43, Guennadi Liakhovetski > > > wrote: > > > > A possibility to prea

Re: Trying to support for HAUPPAUGE HVR-930C

2011-07-28 Thread Benjamin Larsson
On 07/28/2011 10:53 AM, Eddi De Pieri wrote: > Hi, > > I'd like to share my work to get hvr 930c. > > > Actually the device don't work yet. > > Please someone can review my work? > [ ...] > + struct { > + unsigned char r[4]; > + int len; > + } regs[] = { > +

Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

2011-07-28 Thread Guennadi Liakhovetski
On Thu, 28 Jul 2011, Hans Verkuil wrote: > On Thursday, July 28, 2011 06:11:38 Pawel Osciak wrote: > > Hi Guennadi, > > > > On Wed, Jul 20, 2011 at 01:43, Guennadi Liakhovetski > > wrote: > > > A possibility to preallocate and initialise buffers of different sizes > > > in V4L2 is required for a

Re: Create account on linuxtv wiki broken

2011-07-28 Thread Johannes Stezenbach
On Thu, Jul 28, 2011 at 02:14:14PM +0200, Gary van der Merwe wrote: > > I want to fix a url on http://linuxtv.org/wiki/ , but I got > an internal server error when I tried to create an account. > To whom/where should I report this? To the webmaster, of course. Anyway, thanks for reporting and

Create account on linuxtv wiki broken

2011-07-28 Thread Gary van der Merwe
Hi I want to fix a url on http://linuxtv.org/wiki/ , but I got an internal server error when I tried to create an account. To whom/where should I report this? Regards, Gary signature.asc Description: This is a digitally signed message part

Re: [PATCH 2/3] v4l: events: Define frame start event

2011-07-28 Thread Laurent Pinchart
Hi Sakari, On Tuesday 26 July 2011 20:49:43 Sakari Ailus wrote: > Define a frame start event to tell user space when the reception of a frame > starts. You might want to rename 'frame start' to 'frame sync' in the subject and commit message as well. > Signed-off-by: Sakari Ailus > --- > Docum

[PATCH] Add support for new revision of KNC 1 DVB-C cards. Using tda10024 instead of tda10023, which is compatible to tda10023 driver.

2011-07-28 Thread Julian Scheel
Signed-off-by: Julian Scheel --- drivers/media/dvb/ttpci/budget-av.c |4 drivers/media/dvb/ttpci/budget-core.c |2 ++ drivers/media/dvb/ttpci/budget.h |1 + 3 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/ttpci/budget-av.c b/drivers/media/

Re: [git:v4l-dvb/for_v3.1] [media] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam on HP Mini 5103 netbook

2011-07-28 Thread Kirill Smelkov
On Wed, Jul 27, 2011 at 09:42:08PM +0200, Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch > were queued at the > http://git.linuxtv.org/media_tree.git tree: > > Subject: [media] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam on HP Mini

AVerMedia a867r bkl removal

2011-07-28 Thread Romain Aviolat
Hi, I bought an AVerMedia a867r two weeks ago (<- my uninteresting life). It's a DVB-T HD usb tuner, with infra-red built-in and a remote control. Avermedia provides Linux drivers for this products, that's why I've chosen it first but... The driver seems to use some depreciated code (lock_kernel(

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-28 Thread Laurent Pinchart
Hi Guennadi, Thanks for the review. On Thursday 28 July 2011 10:31:24 Guennadi Liakhovetski wrote: > On Mon, 11 Jul 2011, Laurent Pinchart wrote: > > On Friday 24 June 2011 21:45:57 Florian Tobias Schandinat wrote: > > > On 06/24/2011 06:55 PM, Geert Uytterhoeven wrote: > > > > On Fri, Jun 24, 20

Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

2011-07-28 Thread Guennadi Liakhovetski
Hi Sylwester On Wed, 27 Jul 2011, Sylwester Nawrocki wrote: > Hi Gueannadi, > > On 07/20/2011 10:43 AM, Guennadi Liakhovetski wrote: > > A possibility to preallocate and initialise buffers of different sizes > > in V4L2 is required for an efficient implementation of asnapshot mode. > > This patc

Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

2011-07-28 Thread Guennadi Liakhovetski
On Tue, 26 Jul 2011, Hans Verkuil wrote: [snip] > I am happy with the API. The only thing that's unclear to me is whether you > can call > CREATE_BUFS after REQBUFS. And if not, then why not? It would also be helpful > to see > the full patch series as the last one was from April. It is interes

Re: [GIT PATCHES FOR 3.1] s5p-fimc and noon010pc30 driver updates

2011-07-28 Thread Sylwester Nawrocki
Hi Mauro, On 07/28/2011 04:55 AM, Mauro Carvalho Chehab wrote: > Hi Sylwester, > > Em 27-07-2011 13:35, Sylwester Nawrocki escreveu: >> Hi Mauro, >> >> The following changes since commit f0a21151140da01c71de636f482f2eddec2840cc: >> >> Merge tag 'v3.0' into staging/for_v3.1 (2011-07-22 13:33:14

Trying to support for HAUPPAUGE HVR-930C

2011-07-28 Thread Eddi De Pieri
Hi, I'd like to share my work to get hvr 930c. I had to apply some change to drxk structure too! The patch is created with git diff at with these latest 3 commit: commit 9bc5f6fa12c9e3e1e73e66bfabe9d463ea779b08 commit a65ea1e0dba7df0f3b6d55098162cf0125164c6c commit e5d993e5423ea4b81ccdbe2fa157ca

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-28 Thread Guennadi Liakhovetski
On Mon, 11 Jul 2011, Laurent Pinchart wrote: > On Friday 24 June 2011 21:45:57 Florian Tobias Schandinat wrote: > > On 06/24/2011 06:55 PM, Geert Uytterhoeven wrote: > > > On Fri, Jun 24, 2011 at 08:19, Paul Mundt wrote: > > >> On Thu, Jun 23, 2011 at 06:08:03PM +0200, Geert Uytterhoeven wrote: >

[PATCHv2] adp1653: check error code of adp1653_init_controls

2011-07-28 Thread Andy Shevchenko
Potentially the adp1653_init_controls could return an error. In our case the error was ignored, meanwhile it means incorrect initialization of V4L2 controls. Additionally we have to free control handler structures in case of apd1653_init_controls or media_entity_init failure. Signed-off-by: Andy S

Re: [PATCH] adp1653: check error code of adp1653_init_controls

2011-07-28 Thread Andy Shevchenko
On Wed, 2011-07-27 at 11:15 +0300, Sakari Ailus wrote: > On Wed, Jul 27, 2011 at 10:58:02AM +0300, Andy Shevchenko wrote: > > Potentially the adp1653_init_controls could return an error. In our case the > > error was ignored, meanwhile it means incorrect initialization of V4L2 > > controls. > > H