Re: no mmu on videobuf2

2011-06-15 Thread Scott Jiang
2011/6/16 Marek Szyprowski : > Hello Scott, > >> Hi Marek and Laurent, >> >> I am working on v4l2 drivers for blackfin which is a no mmu soc. >> I found videobuf allocate memory in mmap not reqbuf, so I turn to videobuf2. >> But __setup_offsets() use plane offset to fill m.offset, which is >> alway

Re: [RFCv2 PATCH 0/5] tuner-core: fix s_std and s_tuner

2011-06-15 Thread Hans Verkuil
On Wednesday, June 15, 2011 22:49:39 Devin Heitmueller wrote: > On Wed, Jun 15, 2011 at 4:37 PM, Hans Verkuil wrote: > > But the driver has that information, so it should act accordingly. > > > > So on first open you can check whether the current input has a tuner and > > power on the tuner in tha

RE: no mmu on videobuf2

2011-06-15 Thread Marek Szyprowski
Hello Scott, > Hi Marek and Laurent, > > I am working on v4l2 drivers for blackfin which is a no mmu soc. > I found videobuf allocate memory in mmap not reqbuf, so I turn to videobuf2. > But __setup_offsets() use plane offset to fill m.offset, which is > always 0 for single-planar buffer. > So pg

no mmu on videobuf2

2011-06-15 Thread Scott Jiang
Hi Marek and Laurent, I am working on v4l2 drivers for blackfin which is a no mmu soc. I found videobuf allocate memory in mmap not reqbuf, so I turn to videobuf2. But __setup_offsets() use plane offset to fill m.offset, which is always 0 for single-planar buffer. So pgoff in get_unmapped_area cal

Re: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Zach Pfeffer
On 15 June 2011 16:39, Larry Bassel wrote: > On 15 Jun 11 10:36, Marek Szyprowski wrote: >> Hello, >> >> On Tuesday, June 14, 2011 10:42 PM Arnd Bergmann wrote: >> >> > On Tuesday 14 June 2011 20:58:25 Zach Pfeffer wrote: >> > > I've seen this split bank allocation in Qualcomm and TI SoCs, with >>

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-15 Thread Kassey Lee
Jon: after review your code: 1) here is the code, that deal with controller we can share.but still need to tune. 2) for mcam_ctlr_stop_dma implementation, I guess you know something about the silicon limitation, but we found it can not pass our stress test(1000 times capture tes

Re: uvcvideo failure under xHCI

2011-06-15 Thread Sarah Sharp
On Wed, Jun 15, 2011 at 06:39:57PM -0700, Sarah Sharp wrote: > When I plug in a webcam under an xHCI host controller in 3.0-rc3+ > (basically top of Greg's usb-linus branch) with xHCI debugging turned > on, the host controller occasionally cannot keep up with the isochronous > transfers, and it tel

Re: [PATCH 8/8] marvell-cam: Basic working MMP camera driver

2011-06-15 Thread Kassey Lee
2011/6/12 Jonathan Corbet : > Now we have a camera working over the marvell cam controller core.  It > works like the cafe driver and has all the same limitations, contiguous DMA > only being one of them.  But it's a start. > > Signed-off-by: Jonathan Corbet > --- >  drivers/media/video/Makefile  

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-15 Thread Kassey Lee
2011/6/14 Jonathan Corbet : > On Tue, 14 Jun 2011 10:58:47 +0800 > Kassey Lee wrote: > >> > +#include >> > +#include >> > +#include >> > + >> Would be good to sort headers alphabetically > > Um, I suppose.  You're sure you don't want inverse Christmas-tree ordering? > :) > >> > +static int cafe

Re: soc_camera_set_fmt in soc_camera_open

2011-06-15 Thread Kassey Lee
2011/6/13 Guennadi Liakhovetski : > On Mon, 13 Jun 2011, Kassey Lee wrote: > >> On Fri, Jun 10, 2011 at 5:16 PM, Guennadi Liakhovetski < >> g.liakhovet...@gmx.de> wrote: >> >> > On Fri, 10 Jun 2011, Kassey Lee wrote: >> > >> > > hi, Guennadi: >> > > >> > >           in drivers/media/video/soc_camer

uvcvideo failure under xHCI

2011-06-15 Thread Sarah Sharp
Hi Laurent, I think this issue has been happening for a while now, but my recent patches to remove most of the xHCI debugging have finally allowed me to use a webcam under xHCI with debugging on. Unfortunately, it doesn't work very well. When I plug in a webcam under an xHCI host controller in 3

Re: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Philip Balister
On 06/15/2011 12:37 AM, Arnd Bergmann wrote: On Wednesday 15 June 2011 09:11:39 Marek Szyprowski wrote: I see your concerns, but I really wonder how to determine the properties of the global/default cma pool. You definitely don't want to give all available memory o CMA, because it will have nega

Re: [PATCH] [media] af9015: setup rc keytable for LC-Power LC-USB-DVBT

2011-06-15 Thread Antti Palosaari
Moikka Juergen, On 06/13/2011 03:38 AM, Juergen Lock wrote: af9015_rc_query: key repeated Does that help? Repeat check logick in function af9015_rc_query() is failing for some reason. You could try to look that function and checks if you wish as I cannot reproduce it. Add debug dump i

Re: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Arnd Bergmann
On Wednesday 15 June 2011 23:39:58 Larry Bassel wrote: > On 15 Jun 11 10:36, Marek Szyprowski wrote: > > On Tuesday, June 14, 2011 10:42 PM Arnd Bergmann wrote: > > > > > On Tuesday 14 June 2011 20:58:25 Zach Pfeffer wrote: > > > > I've seen this split bank allocation in Qualcomm and TI SoCs, with

Re: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Larry Bassel
On 15 Jun 11 10:36, Marek Szyprowski wrote: > Hello, > > On Tuesday, June 14, 2011 10:42 PM Arnd Bergmann wrote: > > > On Tuesday 14 June 2011 20:58:25 Zach Pfeffer wrote: > > > I've seen this split bank allocation in Qualcomm and TI SoCs, with > > > Samsung, that makes 3 major SoC vendors (I wou

Re: [RFCv2 PATCH 0/5] tuner-core: fix s_std and s_tuner

2011-06-15 Thread Devin Heitmueller
On Wed, Jun 15, 2011 at 4:37 PM, Hans Verkuil wrote: > But the driver has that information, so it should act accordingly. > > So on first open you can check whether the current input has a tuner and > power on the tuner in that case. On S_INPUT you can also poweron/off > accordingly > (bit iffy a

Re: [RFCv2 PATCH 0/5] tuner-core: fix s_std and s_tuner

2011-06-15 Thread Hans Verkuil
On Wednesday, June 15, 2011 22:09:45 Devin Heitmueller wrote: > On Wed, Jun 15, 2011 at 3:55 PM, Hans Verkuil wrote: > > Why would that violate the spec? If the last filehandle is closed, then > > you can safely poweroff the tuner. The only exception is when you have a > > radio > > tuner whose a

Re: [RFCv2 PATCH 0/5] tuner-core: fix s_std and s_tuner

2011-06-15 Thread Devin Heitmueller
On Wed, Jun 15, 2011 at 3:55 PM, Hans Verkuil wrote: > Why would that violate the spec? If the last filehandle is closed, then > you can safely poweroff the tuner. The only exception is when you have a radio > tuner whose audio output is hooked up to some line-in: there you can't power > off > th

Re: [RFCv2 PATCH 0/5] tuner-core: fix s_std and s_tuner

2011-06-15 Thread Hans Verkuil
On Saturday, June 11, 2011 19:08:04 Devin Heitmueller wrote: > On Sat, Jun 11, 2011 at 1:02 PM, Hans Verkuil wrote: > > OK, but how do you get it into standby in the first place? (I must be > > missing > > something here...) > > The tuner core puts the chip into standby when the last V4L filehan

[cron job] v4l-dvb daily build: ERRORS

2011-06-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Wed Jun 15 19:00:33 CEST 2011 git hash:f49c454fe981d955d7c3d620f6baa04fb9876adc gcc version: i686-linux-gcc (GCC) 4.5

Re: [RFCv1 PATCH 0/8] Allocate events per-event-type, v4l2-ctrls cleanup

2011-06-15 Thread Sakari Ailus
Hans Verkuil wrote: This patch series consists of two parts: the first four patches change the way events are allocated and what to do when the event queue is full. These first four patches are the most important ones to review. The big change is that event allocation now happens when subscribin

Re: [PATCH] v4l: Don't access media entity after is has been destroyed

2011-06-15 Thread Sakari Ailus
Laurent Pinchart wrote: Entities associated with video device nodes are unregistered in video_unregister_device(). This destroys the entity even though it can still be accessed through open video device nodes. Move the media_device_unregister_entity() call from video_unregister_device() to v4l2_

Re: [RFCv1 PATCH 1/8] v4l2-events/fh: merge v4l2_events into v4l2_fh

2011-06-15 Thread Hans Verkuil
On Wednesday, June 15, 2011 18:59:05 Sakari Ailus wrote: > Hans Verkuil wrote: > > On Wednesday, June 15, 2011 11:30:07 Sakari Ailus wrote: > >> Hi Hans, > >> > >> Many thanks for the patch. I'm very happy to see this! > >> > >> I have just one comment below. > >> > >>> diff --git a/include/media/v

Re: [RFCv1 PATCH 1/8] v4l2-events/fh: merge v4l2_events into v4l2_fh

2011-06-15 Thread Sakari Ailus
Hans Verkuil wrote: On Wednesday, June 15, 2011 11:30:07 Sakari Ailus wrote: Hi Hans, Many thanks for the patch. I'm very happy to see this! I have just one comment below. diff --git a/include/media/v4l2-event.h b/include/media/v4l2-event.h index 45e9c1e..042b893 100644 --- a/include/media/v

Re: [RFCv1 PATCH 1/8] v4l2-events/fh: merge v4l2_events into v4l2_fh

2011-06-15 Thread Hans Verkuil
On Wednesday, June 15, 2011 11:30:07 Sakari Ailus wrote: > Hi Hans, > > Many thanks for the patch. I'm very happy to see this! > > I have just one comment below. > > > diff --git a/include/media/v4l2-event.h b/include/media/v4l2-event.h > > index 45e9c1e..042b893 100644 > > --- a/include/media/v

Re: Some fixes for alsa_stream

2011-06-15 Thread Mauro Carvalho Chehab
Em 15-06-2011 11:35, Hans de Goede escreveu: >>> This is a combination of the assumption there is a shared period size >>> between >>> the input device and the output device + the broken error handling. >> >> The code is doing a negotiation, in order to find a period that are >> acceptable >> by

Re: [PATCH] Add support for PCTV452E.

2011-06-15 Thread Igor M. Liplianin
>From my point of view we can count the beginning was here: http://www.spinics.net/lists/linux-dvb/msg26431.html The later history is difficult to restore, but possible. BR Igor -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.k

Re: Some fixes for alsa_stream

2011-06-15 Thread Mauro Carvalho Chehab
Em 15-06-2011 11:35, Hans de Goede escreveu: > Hi, > > On 06/15/2011 04:25 PM, Mauro Carvalho Chehab wrote: >> Em 15-06-2011 10:43, Hans de Goede escreveu: > > > >>> Right, because ConsoleKit ensures that devices like floppydrives, cdroms, >>> audio cards, >>> webcams, etc. are only available

Re: Some fixes for alsa_stream

2011-06-15 Thread Mauro Carvalho Chehab
Em 15-06-2011 11:25, Mauro Carvalho Chehab escreveu: > Em 15-06-2011 10:43, Hans de Goede escreveu: >> Hi, >> >> On 06/14/2011 04:45 PM, Mauro Carvalho Chehab wrote: >>> Em 14-06-2011 11:37, Hans de Goede escreveu: Hi, On 06/14/2011 04:17 PM, Mauro Carvalho Chehab wrote: > Em 14-

Re: Some fixes for alsa_stream

2011-06-15 Thread Hans de Goede
Hi, On 06/15/2011 04:25 PM, Mauro Carvalho Chehab wrote: Em 15-06-2011 10:43, Hans de Goede escreveu: >> Right, because ConsoleKit ensures that devices like floppydrives, cdroms, audio cards, >> webcams, etc. are only available to users sitting behind the console, > > This is a wrong assump

Re: Some fixes for alsa_stream

2011-06-15 Thread Mauro Carvalho Chehab
Em 15-06-2011 10:43, Hans de Goede escreveu: > Hi, > > On 06/14/2011 04:45 PM, Mauro Carvalho Chehab wrote: >> Em 14-06-2011 11:37, Hans de Goede escreveu: >>> Hi, >>> >>> On 06/14/2011 04:17 PM, Mauro Carvalho Chehab wrote: Em 14-06-2011 10:52, Devin Heitmueller escreveu: >>> >>> >>> Y

Re: Some fixes for alsa_stream

2011-06-15 Thread Hans de Goede
Hi, On 06/14/2011 04:45 PM, Mauro Carvalho Chehab wrote: Em 14-06-2011 11:37, Hans de Goede escreveu: Hi, On 06/14/2011 04:17 PM, Mauro Carvalho Chehab wrote: Em 14-06-2011 10:52, Devin Heitmueller escreveu: Yes. The default for capture is the one detected via sysfs. The default for pl

[PATCH] dvb-usb/technisat-usb2: don't use flush_scheduled_work()

2011-06-15 Thread Tejun Heo
flush_scheduled_work() is deprecated and scheduled to be removed. technisat-usb2 already sync-cancels the only work item it uses and there's no reason for it to call flush_scheduled_work(). Don't use it. Signed-off-by: Tejun Heo Cc: Mauro Carvalho Chehab Cc: Patrick Boettcher --- I was re-scan

Re: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Thomas Hellstrom
On 06/15/2011 01:53 PM, Daniel Vetter wrote: On Tue, Jun 14, 2011 at 20:30, Arnd Bergmann wrote: On Tuesday 14 June 2011 18:58:35 Michal Nazarewicz wrote: Ah yes, I forgot that separate regions for different purposes could decrease fragmentation. That is indeed a good point,

[PATCH] [media] gspca/zc3xx: add usb_id for HP Premium Starter Cam

2011-06-15 Thread Wolfram Sang
Signed-off-by: Wolfram Sang --- Fixes https://bugzilla.kernel.org/show_bug.cgi?id=13479 drivers/media/video/gspca/zc3xx.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/gspca/zc3xx.c b/drivers/media/video/gspca/zc3xx.c index 61cdd56..dbbab48 100644

Re: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Daniel Vetter
On Tue, Jun 14, 2011 at 20:30, Arnd Bergmann wrote: > On Tuesday 14 June 2011 18:58:35 Michal Nazarewicz wrote: >> Ah yes, I forgot that separate regions for different purposes could >> decrease fragmentation. > > That is indeed a good point, but having a good allocator algorithm > could also solv

Re: [PATCH 1/8] marvell-cam: Move cafe-ccic into its own directory

2011-06-15 Thread Mauro Carvalho Chehab
Em 14-06-2011 23:01, Kassey Lee escreveu: > Jon, > if you agree to change it in another patch, and now just to keep > it with the driver that works for years. > that is OK. thanks. > I am looking forward your patch based on VB2, because based on > current cafe_ccic.c, it is hard to s

Re: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Michal Nazarewicz
On Wed, 15 Jun 2011 13:20:42 +0200, Arnd Bergmann wrote: The point is that on the higher level device drivers, we want to hide the presence of CMA and/or IOMMU behind the dma mapping API, but the device drivers do need to know about the bank properties. Gotcha, thanks. -- Best regards,

Re: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Arnd Bergmann
On Tuesday 14 June 2011, Jordan Crouse wrote: > > On 06/14/2011 02:42 PM, Arnd Bergmann wrote: > > On Tuesday 14 June 2011 20:58:25 Zach Pfeffer wrote: > >> I've seen this split bank allocation in Qualcomm and TI SoCs, with > >> Samsung, that makes 3 major SoC vendors (I would be surprised if > >>

Re: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Arnd Bergmann
On Wednesday 15 June 2011, Michal Nazarewicz wrote: > On Tue, 14 Jun 2011 22:42:24 +0200, Arnd Bergmann wrote: > > * We still need to solve the same problem in case of IOMMU mappings > > at some point, even if today's hardware doesn't have this combination. > > It would be good to use the same

Re: [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Arnd Bergmann
On Wednesday 15 June 2011, Marek Szyprowski wrote: > > > If possible I would like to make cma something similar to > > > declare_dma_coherent()&friends, so the board/platform/bus startup code > > > will just call declare_dma_contiguous() to enable support for cma for > > > particular devices. > >

Re: [RFCv1 PATCH 1/8] v4l2-events/fh: merge v4l2_events into v4l2_fh

2011-06-15 Thread Sakari Ailus
Hi Hans, Many thanks for the patch. I'm very happy to see this! I have just one comment below. > diff --git a/include/media/v4l2-event.h b/include/media/v4l2-event.h > index 45e9c1e..042b893 100644 > --- a/include/media/v4l2-event.h > +++ b/include/media/v4l2-event.h > @@ -43,17 +43,6 @@ struct

Re: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Michal Nazarewicz
On Tue, 14 Jun 2011 22:42:24 +0200, Arnd Bergmann wrote: * We still need to solve the same problem in case of IOMMU mappings at some point, even if today's hardware doesn't have this combination. It would be good to use the same solution for both. I don't think I follow. What does IOMMU h

Re: [PATCH] v4l: Don't access media entity after is has been destroyed

2011-06-15 Thread Laurent Pinchart
Mauro, I forgot to mention in the subject line that this fix should go to 3.0. It fixes a kernel oops when a UVC webcam is disconnected during streaming. I'll send a pull request in the next few days after getting an ack on this patch. Hans, could you please test if it fixes your issue ? --

RE: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Marek Szyprowski
Hello, On Tuesday, June 14, 2011 10:42 PM Arnd Bergmann wrote: > On Tuesday 14 June 2011 20:58:25 Zach Pfeffer wrote: > > I've seen this split bank allocation in Qualcomm and TI SoCs, with > > Samsung, that makes 3 major SoC vendors (I would be surprised if > > Nvidia didn't also need to do this)

[PATCH] v4l: Don't access media entity after is has been destroyed

2011-06-15 Thread Laurent Pinchart
Entities associated with video device nodes are unregistered in video_unregister_device(). This destroys the entity even though it can still be accessed through open video device nodes. Move the media_device_unregister_entity() call from video_unregister_device() to v4l2_device_release() to ensure

RE: [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Marek Szyprowski
Hello, On Wednesday, June 15, 2011 9:37 AM Arnd Bergmann wrote: > On Wednesday 15 June 2011 09:11:39 Marek Szyprowski wrote: > > I see your concerns, but I really wonder how to determine the properties > > of the global/default cma pool. You definitely don't want to give all > > available memory

Re: [PATCH 1/4 v9] v4l: add fourcc definitions for compressed formats.

2011-06-15 Thread Laurent Pinchart
Hi Kamil, On Wednesday 15 June 2011 10:05:42 Kamil Debski wrote: > On 15 June 2011 08:40 Hans Verkuil wrote: > > On Tuesday, June 14, 2011 18:36:53 Kamil Debski wrote: > > > Add fourcc definitions and documentation for the following > > > compressed formats: H264, H264 without start codes, > > > M

RE: [PATCH 1/4 v9] v4l: add fourcc definitions for compressed formats.

2011-06-15 Thread Kamil Debski
Hi, > -Original Message- > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: 15 June 2011 08:40 > To: Kamil Debski > Cc: linux-media@vger.kernel.org; m.szyprow...@samsung.com; > kyungmin.p...@samsung.com; jaeryul...@samsung.com; > laurent.pinch...@ideasonboard.com; jtp.p...@samsung.c

RE: [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Marek Szyprowski
Hello, On Tuesday, June 14, 2011 3:49 PM Arnd Bergmann wrote: > On Monday 13 June 2011, Marek Szyprowski wrote: > > cm_alloc/free are definitely not meant to be called from device drivers. > > They should be only considered as a backend for dma-mapping. > > > > 'Raw' contiguous memory block doesn

Re: xc4000 and analog tv

2011-06-15 Thread Devin Heitmueller
On Wed, Jun 15, 2011 at 2:26 AM, Artem Pastukhov wrote: > It's possible to get analog tv from xc4000? > > I have Pinnacle PCTV Hybrid Stick Solo No, this is not currently possible. The limitation has nothing to do with the xc4000 driver but rather the dvb-usb framework which currently has no ana

Re: [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Arnd Bergmann
On Wednesday 15 June 2011 09:11:39 Marek Szyprowski wrote: > I see your concerns, but I really wonder how to determine the properties > of the global/default cma pool. You definitely don't want to give all > available memory o CMA, because it will have negative impact on kernel > operation (kernel

RE: [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Marek Szyprowski
Hello, On Tuesday, June 14, 2011 8:30 PM Arnd Bergmann wrote: > On Tuesday 14 June 2011 18:58:35 Michal Nazarewicz wrote: > > On Tue, 14 Jun 2011 18:03:00 +0200, Arnd Bergmann wrote: > > > For all I know, that is something that is only true for a few very > > > special Samsung devices, > > > > Ma

Re: [PATCH 4/4 v9] MFC: Add MFC 5.1 V4L2 driver

2011-06-15 Thread Hans Verkuil
On Tuesday, June 14, 2011 18:36:56 Kamil Debski wrote: > Multi Format Codec 5.1 is a hardware video coding acceleration > module found in the S5PV210 and Exynos4 Samsung SoCs. It is > capable of handling a range of video codecs and this driver > provides a V4L2 interface for video decoding and enco