Re: [beagleboard] [PATCH v6 2/2] Add support for mt9p031 sensor in Beagleboard XM.

2011-06-01 Thread javier Martin
Hi Koen, On 1 June 2011 20:08, Koen Kooi wrote: > > Op 1 jun 2011, om 17:36 heeft Javier Martin het volgende geschreven: > >> New "version" and "vdd_io" flags have been added. >> >> A subtle change now prevents camera from being registered >> in the wrong platform. > > I get a decent picture now

RE: [PATCH] [media] V4L/videobuf2-memops: use pr_debug for debug messages

2011-06-01 Thread Marek Szyprowski
Hello, On Thursday, June 02, 2011 3:35 AM Mauro Carvalho Chehab wrote: > Hi Kyungmin, > > Em 01-06-2011 21:50, Kyungmin Park escreveu: > > Acked-by: Kyungmin Park > > As this patch is really trivial and makes sense, I've just applied it > earlier today. thanks! > > --- > > > > I think it's b

Re: [linux-dvb] XC4000 patches for kernel 2.6.37.2

2011-06-01 Thread Mohammad Bahathir Hashim
I am a Pinnacle PCTV 340e user for 2 years. Since the release of "Christmast Gift" in kernellabs.org, I privately made patches to ports the driver until the latest vanilla 2.6.39. I have no problem using the driver for my daily DVB-T viewing usage. Since it is open sourced, I also want to publish

Re: [PATCH] [media] V4L/videobuf2-memops: use pr_debug for debug messages

2011-06-01 Thread Mauro Carvalho Chehab
Hi Kyungmin, Em 01-06-2011 21:50, Kyungmin Park escreveu: > Acked-by: Kyungmin Park As this patch is really trivial and makes sense, I've just applied it earlier today. > --- > > I think it's better to add the videobuf2 maintainer entry for proper > person to know the changes. > In this case,

Re: [PATCH v4 0/3] TV driver for Samsung S5P platform (media part)

2011-06-01 Thread Kyungmin Park
Hi, It's good to know the future chip design changes. but as it doesn't be known to others except the internal chip design team. So with restricted information. there's no way to implement it with current known chip. If you want to change the design. open and show the changed IPs. another thing i

Re: [PATCH] [media] V4L/videobuf2-memops: use pr_debug for debug messages

2011-06-01 Thread Kyungmin Park
Acked-by: Kyungmin Park --- I think it's better to add the videobuf2 maintainer entry for proper person to know the changes. In this case, Marek is missing. If any objection, I will make a patch. Thank you, Kyungmin Park 2011/6/2 Uwe Kleine-König : > Otherwise they clutter the dmesg buffer ev

Re: [beagleboard] [PATCH v5 2/2] Add support for mt9p031 (LI-5M03 module) in Beagleboard xM.

2011-06-01 Thread Chris Rodley
Hi, --- On Wed, 1/6/11, Chris Rodley wrote: > From: Chris Rodley > Subject: Re: [beagleboard] [PATCH v5 2/2] Add support for mt9p031 (LI-5M03 > module) in Beagleboard xM. > To: javier.mar...@vista-silicon.com > Cc: beaglebo...@googlegroups.com, linux-media@vger.kernel.org, > g.liakhovet...@gmx

Re: [PATCH] OMAP2: V4L2: Remove GFP_DMA allocation as ZONE_DMA is not configured on OMAP

2011-06-01 Thread Sakari Ailus
Hi Amber, Thanks for the patch. On Tue, May 31, 2011 at 08:15:36PM +0530, Amber Jain wrote: > Remove GFP_DMA from the __get_free_pages() call from omap24xxcam as ZONE_DMA > is not configured on OMAP. Earlier the page allocator used to return a page > from ZONE_NORMAL even when GFP_DMA is passed a

Re: Capabilities of the Omap3 ISP driver

2011-06-01 Thread Sakari Ailus
On Sun, May 29, 2011 at 03:27:23PM +0200, Bastian Hecht wrote: > Hello Laurent, > > I'm on to a project that needs two synced separate small cameras for > stereovision. It's for harvesting tomatoes in fact :) > > I was thinking about realizing this on an DM3730 with 2 aptina csi2 > cameras that a

Re: [beagleboard] [PATCH v5 2/2] Add support for mt9p031 (LI-5M03 module) in Beagleboard xM.

2011-06-01 Thread Chris Rodley
Hi Javier, Koen, On 02/06/11 06:08, Koen Kooi wrote: > > Op 1 jun 2011, om 17:36 heeft Javier Martin het volgende geschreven: > >> New "version" and "vdd_io" flags have been added. >> >> A subtle change now prevents camera from being registered >> in the wrong platform. > > I get a decent picture

Re: HVR-1300 analog inputs

2011-06-01 Thread linuxtv
Only FYI, I am using the HVR-1300 with the build-media.git repo (sorry I forget the correct name). UK PAL-I capturing fine at full res. Using mtythv and tested using smplayer on /dev/video0 (or video1). (Full UK PAL res). I know that won't directly help, but at least you know that is can/does wor

Media patches with review pending (14 patches)

2011-06-01 Thread Mauro Carvalho Chehab
This is the list of the patches currently on my queue (13 patches from patchwork and one patch that patchwork lost due to a database corruption). There's not much patches there, as I've applied most of the pending stuff. Unfortunately, however, patchwork is not reliable. I noticed at least 2 patch

Re: [PATCH 3/3] [media] DocBook: Add rules to auto-generate some media docbook

2011-06-01 Thread Mauro Carvalho Chehab
Em 01-06-2011 13:01, Randy Dunlap escreveu: > On Wed, 01 Jun 2011 07:52:33 -0300 Mauro Carvalho Chehab wrote: > >> Hi Randy, >> >> Em 26-05-2011 00:10, Randy Dunlap escreveu: >>> On Wed, 25 May 2011 12:26:42 -0300 Mauro Carvalho Chehab wrote: >>> Auto-generate the videodev2.h.xml,frontend.h.x

Fwd: [PATCH] ngene: blocking and nonblocking io for sec0

2011-06-01 Thread Mauro Carvalho Chehab
Oliver/Ralph, Could you please review this patch? On a quick look, it looks fine on my eyes, but I don't have any ngene hardware here for testing. Thanks! Mauro Mensagem original Date: Thu, 12 May 2011 15:47:09 +0200 From: Issa Gorissen To: linux-media@vger.kernel.org Subject:

Re: [PATCH] FE_GET_PROPERTY should be _IOW, because the associated structure is transferred from userspace to kernelspace. Keep the old ioctl around for compatibility so that existing code is not brok

2011-06-01 Thread Mauro Carvalho Chehab
Em 23-05-2011 12:32, Andreas Oberritter escreveu: > On 05/23/2011 04:51 PM, Hans Petter Selasky wrote: >> On Monday 23 May 2011 16:37:18 Andreas Oberritter wrote: >>> On 05/23/2011 03:58 PM, Hans Petter Selasky wrote: From be7d0f72ebf4d945cfb2a5c9cc871707f72e1e3c Mon Sep 17 00:00:00 2001

[PATCH] Add remote control support for mantis

2011-06-01 Thread Christoph Pinkl
Sorry forgot signoff Signed-off-by: Christoph Pinkl --- drivers/media/dvb/mantis/hopper_cards.c|2 +- drivers/media/dvb/mantis/mantis_cards.c| 27 +++- drivers/media/dvb/mantis/mantis_common.h | 23 ++- drivers/media/dvb/mantis/mantis_input.c|

[PATCH] Add remote control support for mantis

2011-06-01 Thread Christoph Pinkl
--- drivers/media/dvb/mantis/hopper_cards.c|2 +- drivers/media/dvb/mantis/mantis_cards.c| 27 +++- drivers/media/dvb/mantis/mantis_common.h | 23 ++- drivers/media/dvb/mantis/mantis_input.c| 169 +++ drivers/media/dvb/mantis/m

[PATCH] [media] V4L/videobuf2-memops: use pr_debug for debug messages

2011-06-01 Thread Uwe Kleine-König
Otherwise they clutter the dmesg buffer even on a production kernel. Signed-off-by: Uwe Kleine-König --- drivers/media/video/videobuf2-memops.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/videobuf2-memops.c b/drivers/media/video/videobuf2-me

Re: [PATCH] Increase a timeout, so that bad scheduling does not accidentially cause a timeout.

2011-06-01 Thread Mauro Carvalho Chehab
Manu, Another patch for your review. Cheers, Mauro Em 23-05-2011 11:22, Hans Petter Selasky escreveu: > --HPS > > > dvb-usb-0015.patch > > > From 18faaafc9cbbe478bb49023bbeae490149048560 Mon Sep 17 00:00:00 2001 > From: Hans Petter Selasky > Date: Mon, 23 May 2011 16:21:47 +0200 > Subject:

[PATCH v6] radio-sf16fmr2: convert to generic TEA575x interface

2011-06-01 Thread Ondrej Zary
Convert radio-sf16fmr2 to use generic TEA575x implementation. Most of the driver code goes away as SF16-FMR2 is basically just a TEA5757 tuner connected to ISA bus. The card can optionally be equipped with PT2254A volume control (equivalent of TC9154AP) - the volume setting is completely reworked (

Re: [alsa-devel] [PATCH v5] [resend] radio-sf16fmr2: convert to generic TEA575x interface

2011-06-01 Thread Ondrej Zary
On Wednesday 01 June 2011 17:45:31 Mauro Carvalho Chehab wrote: > Em 26-05-2011 04:45, Takashi Iwai escreveu: > > At Wed, 25 May 2011 21:21:30 -0300, > > > > Mauro Carvalho Chehab wrote: > >> Em 23-05-2011 09:17, Ondrej Zary escreveu: > >>> Convert radio-sf16fmr2 to use generic TEA575x implementati

RE: [PATCH 5/5 v2] [media] ov9740: Add suspend/resume

2011-06-01 Thread Guennadi Liakhovetski
On Tue, 31 May 2011, Andrew Chew wrote: > > > + /* For suspend/resume. */ > > > + struct v4l2_mbus_framefmt current_mf; > > > + int current_enable; > > > > bool? > > Are you sure you want this to be a bool? This thing is trying to shadow > the "enable" paramet

[no subject]

2011-06-01 Thread Emil Meier
unsubscribe linux-media -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 4/5 v2] [media] ov9740: Remove hardcoded resolution regs

2011-06-01 Thread Guennadi Liakhovetski
On Tue, 31 May 2011, Andrew Chew wrote: > > > + /* Width must be a multiple of 4 pixels. */ > > > + *width += *width % 4; > > > > No, this doesn't make it a multiple of 4, unless it was > > even;) Just take 5 > > as an example. What you really want here is > > Geez, you're right. Not sure wha

Re: [PATCH] stb0899: Removed an extra byte sent at init on DiSEqC bus

2011-06-01 Thread Mauro Carvalho Chehab
Em 01-06-2011 13:24, Manu Abraham escreveu: > On 6/1/11, Mauro Carvalho Chehab wrote: > Mauro, > > I have been away from home and not yet back due to a nasty back > sprain, but expect to return mid next week. Sorry to hear about it. I hope you to recover soon from the sprain. > Please hold off

[cron job] v4l-dvb daily build: ERRORS

2011-06-01 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Wed Jun 1 19:00:42 CEST 2011 git hash:f9b51477fe540fb4c65a05027fdd6f2ecce4db3b gcc version: i686-linux-gcc (GCC) 4.5

[PATCH 1/2] [media] uvc_entity: initialize return value

2011-06-01 Thread Mauro Carvalho Chehab
drivers/media/video/uvc/uvc_entity.c: In function ‘uvc_mc_register_entities’: drivers/media/video/uvc/uvc_entity.c:33: warning: ‘ret’ may be used uninitialized in this function Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/video/uvc/uvc_entity.c b/drivers/media/video/uvc/uvc_

[PATCH 2/2] [media] soc_camera: preserve const attribute

2011-06-01 Thread Mauro Carvalho Chehab
drivers/media/video/soc_camera.c: In function ‘soc_camera_video_start’: drivers/media/video/soc_camera.c:1515: warning: initialization discards qualifiers from pointer target type Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/video/soc_camera.c b/drivers/media/video/soc_camera

Re: [beagleboard] [PATCH v6 2/2] Add support for mt9p031 sensor in Beagleboard XM.

2011-06-01 Thread Koen Kooi
Op 1 jun 2011, om 17:36 heeft Javier Martin het volgende geschreven: > New "version" and "vdd_io" flags have been added. > > A subtle change now prevents camera from being registered > in the wrong platform. I get a decent picture now with the following: media-ctl -r -l '"mt9p031 2-0048":0->"O

Re: [PATCH] update dvb-c scanfile hu-Digikabel

2011-06-01 Thread Christoph Pfister
2011/5/31 Marton Balint : > # HG changeset patch > # User Marton Balint > # Date 1306844422 -7200 > # Node ID 15083eb9eb32e906d2961597965320d328b3782e > # Parent  7ebf32ed9124c7e58049dc9f59b514a222757b7d > update dvb-c scanfile hu-Digikabel Pushed, thanks. Christoph > diff -r 7ebf32ed9124 -r 1

Re: [bug-report] unconditionally calling cxd2820r_get_tuner_i2c_adapter() from em28xx-dvb.c creates a hard module dependency

2011-06-01 Thread Bjørn Mork
Bjørn Mork writes: > diff --git a/drivers/media/video/em28xx/em28xx-dvb.c > b/drivers/media/video/em28xx/em28xx-dvb.c > index 7904ca4..d994592 100644 > --- a/drivers/media/video/em28xx/em28xx-dvb.c > +++ b/drivers/media/video/em28xx/em28xx-dvb.c > @@ -669,7 +669,8 @@ static int dvb_init(struct e

Re: [PATCH] Make DVB NET configurable in the kernel.

2011-06-01 Thread Hans Petter Selasky
> > Patch is ok, but the code when DVB_NET is not defined can > be simpler. > > So, I'm applying the following patch after yours: Looks good! --HPS -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo inf

[PATCH] media: omap3isp: fix a pontential NULL deref

2011-06-01 Thread Ohad Ben-Cohen
Fix a potential NULL pointer dereference by skipping registration of external entities in case none are provided. This is useful at least when testing mere memory-to-memory scenarios. Signed-off-by: Ohad Ben-Cohen --- drivers/media/video/omap3isp/isp.c |2 +- 1 files changed, 1 insertions(+

Re: [PATCH] stb0899: Removed an extra byte sent at init on DiSEqC bus

2011-06-01 Thread Manu Abraham
On 6/1/11, Mauro Carvalho Chehab wrote: > Em 19-10-2010 14:05, Mauro Carvalho Chehab escreveu: >> Em 19-10-2010 10:55, Florent AUDEBERT escreveu: >>> On 06/11/2010 06:01 PM, Florent AUDEBERT wrote: I noticed a stray 0x00 at init on DiSEqC bus (KNC1 DVB-S2) with a DiSEqC tool analyzer. >>

Re: [PATCH] Make DVB NET configurable in the kernel.

2011-06-01 Thread Mauro Carvalho Chehab
Em 23-05-2011 10:11, Hans Petter Selasky escreveu: > --HPS > > > dvb-usb-0012.patch > > > From 7222450a9d6f96f652237c65019fb25f54586d01 Mon Sep 17 00:00:00 2001 > From: Hans Petter Selasky > Date: Mon, 23 May 2011 14:43:35 +0200 > Subject: [PATCH] Make DVB NET configurable in the kernel. > >

Re: [PATCH 3/3] [media] DocBook: Add rules to auto-generate some media docbook

2011-06-01 Thread Randy Dunlap
On Wed, 01 Jun 2011 07:52:33 -0300 Mauro Carvalho Chehab wrote: > Hi Randy, > > Em 26-05-2011 00:10, Randy Dunlap escreveu: > > On Wed, 25 May 2011 12:26:42 -0300 Mauro Carvalho Chehab wrote: > > > >> Auto-generate the videodev2.h.xml,frontend.h.xml and the indexes. > >> > >> Some logic at the M

Re: HVR-1300 analog inputs

2011-06-01 Thread Devin Heitmueller
On Wed, Jun 1, 2011 at 11:36 AM, Florent Audebert wrote: > Hi, > > I'm experimenting around with an Hauppauge HVR-1300 (cx88_blackbird) analog > inputs (PAL-I signal). > > Using qv4l2 (trunk) and 2.6.36.4, I successfully get a clean image on both > composite and s-video inputs with resolutions of

Re: [alsa-devel] [PATCH v5] [resend] radio-sf16fmr2: convert to generic TEA575x interface

2011-06-01 Thread Mauro Carvalho Chehab
Em 26-05-2011 04:45, Takashi Iwai escreveu: > At Wed, 25 May 2011 21:21:30 -0300, > Mauro Carvalho Chehab wrote: >> >> Em 23-05-2011 09:17, Ondrej Zary escreveu: >>> Convert radio-sf16fmr2 to use generic TEA575x implementation. Most of the >>> driver code goes away as SF16-FMR2 is basically just a

[PATCH v6 2/2] Add support for mt9p031 sensor in Beagleboard XM.

2011-06-01 Thread Javier Martin
New "version" and "vdd_io" flags have been added. A subtle change now prevents camera from being registered in the wrong platform. Signed-off-by: Javier Martin --- arch/arm/mach-omap2/Makefile |1 + arch/arm/mach-omap2/board-omap3beagle-camera.c | 95

[PATCH v6 1/2] Add driver for Aptina (Micron) mt9p031 sensor.

2011-06-01 Thread Javier Martin
Clock frequency of 57MHz used in previous version was wrong since when VDD_IO is 1.8V it can only support 48MHz. Two new platform flags have been added: - vdd_io: indicates whether the chip is powered with 1.8 or 2.8 VDD_IO. So that it can use the maximum allowed frequency. - version: monochrome

[PATCH] stv090x: set status bits when there is no lock

2011-06-01 Thread Guy Martin
Currently, the stv090x driver only set the status bits to SCVYL when there is a lock. This patch set the right bits even if there is no lock. Signed-off-by: Guy Martin -- drivers/media/dvb/frontends/stv090x.c | 35 ++-- 1 files changed, 15 insertions(+), 20 deleti

mt9p031 + omap3isp

2011-06-01 Thread Joel A Fernandes
Hi, Could anyone explain what is the state of mt9p031 + omap3isp driver support with v4l2? Currently it required media-ctl + udev rules but it doesn't "just" work, could anyone briefly describe what kind of changes would be required to get it to work? Thanks, -Joel -- To unsubscribe from this l

Re: [PATCH] stb0899: Fix not locking DVB-S transponder

2011-06-01 Thread Mauro Carvalho Chehab
Manu, Please review. Lutz, scripts/checkpatch.pl complains about a few bad style used on your patches: ERROR: space prohibited after that open parenthesis '(' #42: FILE: drivers/media/dvb/frontends/stb0899_algo.c:343: + if ( !lock ) { ERROR: space prohibited before that close parenthesis

Re: [PATCH] Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt

2011-06-01 Thread Mauro Carvalho Chehab
Manu, Em 13-08-2010 10:51, Stefan escreveu: > Hello Marko > > I confirm this patch reduces the amount of interrupts to nearly one third: > > [*] v4l mercurial wo patch: about 600 calls/sec over a 10 seconds interval > [*] v4l mercurial with patch: about 160 calls/sec over a 10 seconds interval >

Re: [PATCH] stb0899: Removed an extra byte sent at init on DiSEqC bus

2011-06-01 Thread Mauro Carvalho Chehab
Em 19-10-2010 14:05, Mauro Carvalho Chehab escreveu: > Em 19-10-2010 10:55, Florent AUDEBERT escreveu: >> On 06/11/2010 06:01 PM, Florent AUDEBERT wrote: >>> I noticed a stray 0x00 at init on DiSEqC bus (KNC1 DVB-S2) with a DiSEqC >>> tool analyzer. >>> >>> I removed the register from initializatio

Re: [GIT PATCHES FOR 2.6.41] Add bitmask controls

2011-06-01 Thread Mauro Carvalho Chehab
Em 01-06-2011 10:27, Hans Verkuil escreveu: >> Hi Hans, >> >> Em 23-05-2011 08:15, Hans Verkuil escreveu: >>> Hi Mauro, >>> >>> These patches for 2.6.41 add support for bitmask controls, needed for >>> the >>> upcoming Flash API and HDMI API. >> >> DocBook changes need do a s/2.6.41/3.1/. > > Of c

Re: [GIT PULL FOR 2.6.40] PCTV nanoStick T2 290e (Sony CXD2820R DVB-T/T2/C)

2011-06-01 Thread Mauro Carvalho Chehab
Em 25-05-2011 17:42, Antti Palosaari escreveu: > Moikka Mauro, > > Fixes... > > > The following changes since commit 87cf028f3aa1ed51fe29c36df548aa714dc7438f: > > [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through > GPIO reworked (2011-05-21 11:10:28 -0300) > > are

Re: [GIT PATCHES FOR 2.6.41] Add bitmask controls

2011-06-01 Thread Hans Verkuil
> Hi Hans, > > Em 23-05-2011 08:15, Hans Verkuil escreveu: >> Hi Mauro, >> >> These patches for 2.6.41 add support for bitmask controls, needed for >> the >> upcoming Flash API and HDMI API. > > DocBook changes need do a s/2.6.41/3.1/. Of course, I saw your DocBook changes going today. > That's s

Announcing v4l-utils-0.8.4

2011-06-01 Thread Hans de Goede
Hi, I'm happy to announce the release of v4l-utils-0.8.4. After some somewhat boring releases, this release contains some interesting improvements: * Various enhancements to libv4l which should result in significantly less cpu usage with uvc HD cameras in several scenarios * A library for ass

Re: [GIT PATCHES FOR 2.6.41] Add bitmask controls

2011-06-01 Thread Mauro Carvalho Chehab
Hi Hans, Em 23-05-2011 08:15, Hans Verkuil escreveu: > Hi Mauro, > > These patches for 2.6.41 add support for bitmask controls, needed for the > upcoming Flash API and HDMI API. DocBook changes need do a s/2.6.41/3.1/. That's said, I'm not sure if it is a good idea to add bitmask type, instead

Re: [GIT PULL FOR 2.6.40] Anysee

2011-06-01 Thread Mauro Carvalho Chehab
Em 25-05-2011 18:43, Antti Palosaari escreveu: > Moikka Mauro, > > Two new models and some fixes. > > > The following changes since commit 87cf028f3aa1ed51fe29c36df548aa714dc7438f: > > [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through > GPIO reworked (2011-05-21 11:

Re: [GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

2011-06-01 Thread Mauro Carvalho Chehab
Em 23-05-2011 06:20, Jean-Francois Moine escreveu: > The following changes since commit > 87cf028f3aa1ed51fe29c36df548aa714dc7438f: > > [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through > GPIO reworked (2011-05-21 11:10:28 -0300) > > are available in the git repositor

Re: [bug-report] unconditionally calling cxd2820r_get_tuner_i2c_adapter() from em28xx-dvb.c creates a hard module dependency

2011-06-01 Thread Bjørn Mork
Another possible solution... This is my last one, I promise :-) I looked at dvb_attach() and realized that you can ab^H^Hreuse it. This makes the patch tiny, and allow you to continue hiding struct cxd2820r_priv. Bjørn >From b570bbad12c1d164ed92c6711a1775db29c4c0a7 Mon Sep 17 00:00:00 2001

V4L2_PIX_FMT_JPGL is missing a proper documentation at V4L2 API

2011-06-01 Thread Mauro Carvalho Chehab
Hi Jean-François, I've added on our tree a DocBook patch that helps to detect the gaps between the videodev2.h header and the specs. It is complaining that a symbol is missing: Error: no ID for constraint linkend: V4L2-PIX-FMT-JPGL. According with videodev2, this is a "JPEG-Lite" FOURCC: includ

Re: [bug-report] unconditionally calling cxd2820r_get_tuner_i2c_adapter() from em28xx-dvb.c creates a hard module dependency

2011-06-01 Thread Bjørn Mork
Antti Palosaari writes: > On 06/01/2011 12:45 PM, Bjørn Mork wrote: >> Don't know the proper fix. My naïve quick-fix was just to move struct >> cxd2820r_priv into cxd2820r.h and making the function static inlined. >> However, I do see that you may not want the struct in cxd2820r.h. But I >> trus

[bug-report] unconditionally calling cxd2820r_get_tuner_i2c_adapter() from em28xx-dvb.c creates a hard module dependency

2011-06-01 Thread Bjørn Mork
Hello, I noticed this warning WARNING: "cxd2820r_get_tuner_i2c_adapter" [/usr/local/src/git/linux-2.6/drivers/media/video/em28xx/em28xx-dvb.ko] undefined! while building the driver in 2.6.32 with backported 290e support. This warning does not appear with 3.0.0-rc1, but the call still doe

Re: [bug-report] unconditionally calling cxd2820r_get_tuner_i2c_adapter() from em28xx-dvb.c creates a hard module dependency

2011-06-01 Thread Antti Palosaari
On 06/01/2011 12:45 PM, Bjørn Mork wrote: Don't know the proper fix. My naïve quick-fix was just to move struct cxd2820r_priv into cxd2820r.h and making the function static inlined. However, I do see that you may not want the struct in cxd2820r.h. But I trust that you have a brilliant solution

Re: Capabilities of the Omap3 ISP driver

2011-06-01 Thread Laurent Pinchart
Hi Bastian, On Wednesday 01 June 2011 10:18:21 Bastian Hecht wrote: > 2011/5/30 Laurent Pinchart : > > On Monday 30 May 2011 23:39:13 Bastian Hecht wrote: > >> 2011/5/30 Laurent Pinchart : > >> > On Sunday 29 May 2011 15:27:23 Bastian Hecht wrote: > >> >> Hello Laurent, > >> >> > >> >> I'm on to

Re: Capabilities of the Omap3 ISP driver

2011-06-01 Thread Bastian Hecht
2011/5/30 Laurent Pinchart : > Hi Bastian, > > On Monday 30 May 2011 23:39:13 Bastian Hecht wrote: >> 2011/5/30 Laurent Pinchart : >> > On Sunday 29 May 2011 15:27:23 Bastian Hecht wrote: >> >> Hello Laurent, >> >> >> >> I'm on to a project that needs two synced separate small cameras for >> >> ste

Writing descriptive commit messages (was Re: PCTV nanoStick T2 290e support - Thank you!)

2011-06-01 Thread Bjørn Mork
Bjørn Mork writes: > Rémi Denis-Courmont writes: >> On Fri, 27 May 2011 13:36:37 +0200, Bjørn Mork wrote: >> >>> I'm a bit curious about this device. It seems to only be marketed as a >>> DVB-T2 device in areas where that spec is used. But looking at your >>> driver, it seems that the device a

RE: [PATCH] OMAP: V4L2: Remove GFP_DMA allocation as ZONE_DMA is not configured on OMAP

2011-06-01 Thread JAIN, AMBER
As per Vaibhav's review comments, I have split the patch into 2 different (independent) patches: - one for omap_vout - and another for omap24xxcam.c (name changed to [PATCH] OMAP2: V4L2: Remove GFP_DMA allocation as ZONE_DMA is not configured on OMAP ) If you have difficulty in finding it I can s

Re: [RFCv2 PATCH 07/11] v4l2-ctrls: add control events.

2011-06-01 Thread Sakari Ailus
On Sat, May 28, 2011 at 05:08:30PM +0200, Hans Verkuil wrote: > On Saturday, May 28, 2011 12:48:45 Sakari Ailus wrote: [clip] > > Do we really need type and default_value in the event? They are static, and > > on the other hand, the type should be already defined by the control so > > that's static

Re: [PATCH] OMAP: V4L2: Remove GFP_DMA allocation as ZONE_DMA is not configured on OMAP

2011-06-01 Thread Sakari Ailus
On Tue, May 31, 2011 at 03:58:46PM +0530, JAIN, AMBER wrote: > I have tested it on OMAP4430 blaze and OMAP3430 SDP platforms. > > I do not have the hardware to test omap24xxcam change. Can someone please > help me on this? I have the hardware, but this driver is not testable right now as it is in