[PATCH][Trivial] Media, DVB, Siano, smsusb: Avoid static analysis report about 'use after free'.

2011-04-21 Thread Jesper Juhl
In drivers/media/dvb/siano/smsusb.c we have this code: ... kfree(dev); sms_info("device %p destroyed", dev); ... at least one static analysis tool (Coverity Prevent) complains about this as a use-after-free bug. While it's true that we do use the pointer variable

Re: [PATCH] Fixes stb0899 not locking

2011-04-21 Thread Steffen Barszus
On Mon, 04 Apr 2011 14:02:31 +0200 Lutz Sammer wrote: > Fixes stb0899 not locking. > See http://www.spinics.net/lists/linux-media/msg30486.html ... > > When stb0899_check_data is entered, it could happen, that the data is > already locked and the data search looped. stb0899_check_data fails > t

[cron job] v4l-dvb daily build: ERRORS

2011-04-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Thu Apr 21 19:00:25 CEST 2011 git hash:a4761a092fd3b6bf8b5f9cfe361670c86cdcc8ca gcc version: i686-linux-gcc (GCC) 4.5

[PATCH v4 3/3] v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers

2011-04-21 Thread Sylwester Nawrocki
Add the subdev driver for the MIPI CSIS units available in S5P and Exynos4 SoC series. This driver supports both CSIS0 and CSIS1 MIPI-CSI2 receivers. The driver requires Runtime PM to be enabled for proper operation. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/med

[PATCH v4 2/3] v4l: Move S5P FIMC driver into Video Capture Devices

2011-04-21 Thread Sylwester Nawrocki
s5p-fimc now also implements a camera capture video node so move it under the "Video capture devices" Kconfig menu. Also update the entry to reflect the driver's coverage of EXYNOS4 SoCs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/video/Kconfig | 19 +

[PATCH 1/3] v4l: Add V4L2_MBUS_FMT_JPEG_1X8 media bus format

2011-04-21 Thread Sylwester Nawrocki
Add V4L2_MBUS_FMT_JPEG_1X8 format and the corresponding Docbook documentation. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Laurent Pinchart --- Documentation/DocBook/v4l/subdev-formats.xml | 46 ++ include/linux/v4l2-mediabus.h

[PATCH v4] Add v4l2 subdev driver for S5P MIPI-CSI receivers

2011-04-21 Thread Sylwester Nawrocki
Hello, this is a fourth version of the subdev driver for MIPI-CSI2 receivers present on S5PVx10 and EXYNOS4 SoCs. This patch set also adds a V4L2_MBUS_FMT_JPEG_1X8 media bus format and moves the s5p-fimc driver to Video Capture Devices kconfig group. I don't expect this driver to undergo any majo

Re: [PATCH 2/7] ARM: Samsung: update/rewrite Samsung SYSMMU (IOMMU) driver

2011-04-21 Thread Arnd Bergmann
On Thursday 21 April 2011, Marek Szyprowski wrote: > > No, I think that would be much worse, it definitely destroys all kinds of > > assumptions that the core code makes about devices. However, I don't think > > it's much of a problem to just create two child devices and use them > > from the main

RE: [PATCH 2/7] ARM: Samsung: update/rewrite Samsung SYSMMU (IOMMU) driver

2011-04-21 Thread Marek Szyprowski
Hello, On Thursday, April 21, 2011 2:00 PM Arnd Bergmann wrote: > On Thursday 21 April 2011, Marek Szyprowski wrote: > > On Wednesday, April 20, 2011 6:07 PM Arnd Bergmann wrote: > > > On Wednesday 20 April 2011, Marek Szyprowski wrote: > > > > The only question is how a device can allocate a buf

Re: Driver for r5u870 USB webcams

2011-04-21 Thread Hans de Goede
Hi, On 04/21/2011 03:08 PM, Jon Mason wrote: My laptop has the "Ricoh Co., Ltd Visual Communication Camera VGP-VCC7 [R5U870]" webcam. A quick scan of the kernel does not show the USB ID listed. `lsusb` has it listed as: Bus 001 Device 005: ID 05ca:183a Ricoh Co., Ltd Visual Communication Came

Driver for r5u870 USB webcams

2011-04-21 Thread Jon Mason
My laptop has the "Ricoh Co., Ltd Visual Communication Camera VGP-VCC7 [R5U870]" webcam. A quick scan of the kernel does not show the USB ID listed. `lsusb` has it listed as: Bus 001 Device 005: ID 05ca:183a Ricoh Co., Ltd Visual Communication Camera VGP-VCC7 [R5U870] I managed to find a Linux

Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-21 Thread Hans Verkuil
On Thursday, April 21, 2011 13:41:01 Sakari Ailus wrote: > Laurent Pinchart wrote: > > Hi Sakari, > > Hi Laurent, > > > On Saturday 16 April 2011 10:51:27 Sakari Ailus wrote: > >> Hans Verkuil wrote: > Hans Verkuil wrote: > > Whenever a control changes value an event is sent to anyone th

Re: [PATCH 2/7] ARM: Samsung: update/rewrite Samsung SYSMMU (IOMMU) driver

2011-04-21 Thread Arnd Bergmann
On Thursday 21 April 2011, Marek Szyprowski wrote: > On Wednesday, April 20, 2011 6:07 PM Arnd Bergmann wrote: > > On Wednesday 20 April 2011, Marek Szyprowski wrote: > > > The only question is how a device can allocate a buffer that will be most > > > convenient for IOMMU mapping (i.e. will requir

Re: [RFCv1 PATCH 4/9] v4l2-ctrls: add per-control events.

2011-04-21 Thread Sakari Ailus
Laurent Pinchart wrote: > Hi Sakari, Hi Laurent, > On Saturday 16 April 2011 10:51:27 Sakari Ailus wrote: >> Hans Verkuil wrote: Hans Verkuil wrote: > Whenever a control changes value an event is sent to anyone that > subscribed > to it. > > Signed-off-by: Hans Verkuil >

RE: [PATCH 2/7] ARM: Samsung: update/rewrite Samsung SYSMMU (IOMMU) driver

2011-04-21 Thread Marek Szyprowski
Hello, On Wednesday, April 20, 2011 6:07 PM Arnd Bergmann wrote: > On Wednesday 20 April 2011, Marek Szyprowski wrote: > > On Tuesday, April 19, 2011 4:30 PM Arnd Bergmann wrote: > > > > Sounds good. I think we should put it into a new drivers/iommu, along > > > with your specific iommu implemen

Re: [PATCH v16 01/13] davinci vpbe: V4L2 display driver for DM644X SoC

2011-04-21 Thread Laurent Pinchart
Hi Manjunath, On Wednesday 20 April 2011 17:30:08 Hadli, Manjunath wrote: > Hi Laurent, > Thank you for you very valuable and detailed comments. I have fixed a lot > of your suggestions and there are a few questions I need more explanation > for. I will send the fixed and updated patches as a fol

Re: [PATCH v3] media:uvc_driver: add uvc support on no-mmu arch

2011-04-21 Thread Daniel Glöckner
On Thu, Apr 21, 2011 at 05:57:31PM +0800, Bob Liu wrote: > On Thu, Apr 21, 2011 at 5:47 PM, Daniel Glöckner wrote: > > On Thu, Apr 21, 2011 at 04:20:36PM +0800, Bob Liu wrote: > >> > on mmu systems do_mmap_pgoff contains a len = PAGE_ALIGN(len); line. > >> > If we depend on this behavior, why not

Re: [PATCH v3] media:uvc_driver: add uvc support on no-mmu arch

2011-04-21 Thread Bob Liu
On Thu, Apr 21, 2011 at 5:47 PM, Daniel Glöckner wrote: > On Thu, Apr 21, 2011 at 04:20:36PM +0800, Bob Liu wrote: >> > on mmu systems do_mmap_pgoff contains a len = PAGE_ALIGN(len); line. >> > If we depend on this behavior, why not do it here as well and get rid >> > of the #ifdef? >> > >> >> If

[PATCH 2/3] gspca - kinect: fix a typo s/steram/stream/

2011-04-21 Thread Antonio Ospite
From: Drew Fisher Signed-off-by: Drew Fisher Signed-off-by: Antonio Ospite --- drivers/media/video/gspca/kinect.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c index 79c4ef5..b4f9e2b 100644 ---

[PATCH 0/3] gspca_kinect fixup

2011-04-21 Thread Antonio Ospite
Hi, some incremental fixes for the gspca kinect driver, the first patch in the series by Drew Fisher addresses the issue Mauro was pointing out. Thanks, Antonio Antonio Ospite (1): gspca - kinect: fix comments referring to color camera Drew Fisher (2): gspca - kinect: move communication

[PATCH 3/3] gspca - kinect: fix comments referring to color camera

2011-04-21 Thread Antonio Ospite
Use the expression "video stream" instead of "color camera" which is more correct as the driver supports the RGB and IR image on the same endpoint. Signed-off-by: Antonio Ospite --- drivers/media/video/gspca/kinect.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH 1/3] gspca - kinect: move communications buffers out of stack

2011-04-21 Thread Antonio Ospite
From: Drew Fisher Move large communications buffers out of stack and into device structure. This prevents the frame size from being >1kB and fixes a compiler warning when CONFIG_FRAME_WARN=1024: drivers/media/video/gspca/kinect.c: In function ‘send_cmd.clone.0’: drivers/media/video/gspca/kinect.

Re: [PATCH v3] media:uvc_driver: add uvc support on no-mmu arch

2011-04-21 Thread Daniel Glöckner
On Thu, Apr 21, 2011 at 04:20:36PM +0800, Bob Liu wrote: > > on mmu systems do_mmap_pgoff contains a len = PAGE_ALIGN(len); line. > > If we depend on this behavior, why not do it here as well and get rid > > of the #ifdef? > > > > If do it in do_mmap_pgoff() the whole system will be effected, I am

Re: OMAP3 ISP and tvp5151 driver.

2011-04-21 Thread Laurent Pinchart
Hi Raffaele, On Wednesday 20 April 2011 17:25:58 Raffaele Recalcati wrote: > On Wed, Mar 30, 2011 at 3:32 PM, Laurent Pinchart wrote: > > On Wednesday 30 March 2011 13:05:08 Loïc Akue wrote: > >> Hi Laurent, > >> > >> > The OMAP3 ISP should support interleaving interlaced frames, but > >> > that'

Re: OMAP3 ISP deadlocks on my new arm

2011-04-21 Thread Laurent Pinchart
Hi Sakari, On Tuesday 19 April 2011 09:31:05 Sakari Ailus wrote: > Laurent Pinchart wrote: > ... > > > That's the ideal situation: sensors should not produce any data (or > > rather any transition on the VS/HS signals) when they're supposed to be > > stopped. Unfortunately that's not always easy,

Re: [PATCH v3] media:uvc_driver: add uvc support on no-mmu arch

2011-04-21 Thread Bob Liu
On Thu, Apr 21, 2011 at 3:59 PM, Daniel Glöckner wrote: > Hi Bob, > > On Thu, Apr 21, 2011 at 11:17:42AM +0800, Bob Liu wrote: >> +#ifdef CONFIG_MMU >>       if (i == queue->count || size != queue->buf_size) { >> +#else >> +     if (i == queue->count || PAGE_ALIGN(size) != queue->buf_size) { >> +#

Re: [PATCH 0/2] V4L: Extended crop/compose API, ver2

2011-04-21 Thread Laurent Pinchart
Hi Tomasz, On Tuesday 19 April 2011 18:02:07 Tomasz Stanislawski wrote: > Hi Laurent, > > > I wish it would be that simple. Let me show you an example, taken from > > the OMAP3 ISP resizer driver. The following equation comes from the > > OMAP3 ISP documentation and describes the relationship bet

asus p7131 and linux-image-2.6.38-2-amd64

2011-04-21 Thread Nicole B.
I'm using my asus my cinema p7131 hybrid tv tuner [ lspci 01:01.0 Multimedia controller: Philips Semiconductors SAA7131/SAA7133/SAA7135 Video Broadcast Decoder (rev d1) ] whith my debian gnu linux 7.0 wheezy, but it returns a corrupted video and stream when i'm using the DVB-T tuner, making th

asus p7131 and linux-image-2.6.38-2-amd64

2011-04-21 Thread Nicole B.
I'm using my asus my cinema p7131 hybrid tv tuner [ lspci 01:01.0 Multimedia controller: Philips Semiconductors SAA7131/SAA7133/SAA7135 Video Broadcast Decoder (rev d1) ] whith my debian gnu linux 7.0 wheezy, but it returns a corrupted video and stream when i'm using the DVB-T tuner, making th

Re: [PATCH v3] media:uvc_driver: add uvc support on no-mmu arch

2011-04-21 Thread Daniel Glöckner
Hi Bob, On Thu, Apr 21, 2011 at 11:17:42AM +0800, Bob Liu wrote: > +#ifdef CONFIG_MMU > if (i == queue->count || size != queue->buf_size) { > +#else > + if (i == queue->count || PAGE_ALIGN(size) != queue->buf_size) { > +#endif on mmu systems do_mmap_pgoff contains a len = PAGE_ALIGN(len